AggregateRootBehaviour::reconstituteFromEvents() - Code Metrics - Inspection of "Version: 1.0.0" - EventSaucePHP/EventSauce - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#84)

by Frank

created 2021-04-16 14:02 UTC

AggregateRootBehaviour::reconstituteFromEvents() A

↳ Parent: AggregateRootBehaviour

Complexity

Conditions	3
Paths	2

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	3
eloc	5
nc	2
nop	2
dl	0
loc	12
ccs	4
cts	4
cp	1
crap	3
rs	10
c	4
b	0
f	0

<?php

declare(strict_types=1);

namespace EventSauce\EventSourcing;

use Generator;

/**
 * @see AggregateRoot
 */
trait AggregateRootBehaviour
{
    use AggregateAlwaysAppliesEvents;

    private AggregateRootId $aggregateRootId;
    private int $aggregateRootVersion = 0;
    /** @var list<object> */
filter:
    dependency_paths: ["lib/*"]
    private array $recordedEvents = [];

    private function __construct(AggregateRootId $aggregateRootId)
    {
        $this->aggregateRootId = $aggregateRootId;
    }

    public function aggregateRootId(): AggregateRootId
    {
        return $this->aggregateRootId;
    }

    /**
     * @see AggregateRoot::aggregateRootVersion
     */
    public function aggregateRootVersion(): int
    {
        return $this->aggregateRootVersion;
    }

    protected function recordThat(object $event): void
    {
        $this->apply($event);
        $this->recordedEvents[] = $event;
    }

    /**
     * @return object[]
     */
    public function releaseEvents(): array
    {
        $releasedEvents = $this->recordedEvents;

        $this->recordedEvents = [];

        return $releasedEvents;
    }

    /**
     * @see AggregateRoot::reconstituteFromEvents
     */
    public static function reconstituteFromEvents(AggregateRootId $aggregateRootId, Generator $events): static
    {
        $aggregateRoot = new static($aggregateRootId);

        /** @var object $event */
        foreach ($events as $event) {
            $aggregateRoot->apply($event);
        }

        $aggregateRoot->aggregateRootVersion = $events->getReturn() ?: 0;

        return $aggregateRoot;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace EventSauce\EventSourcing;
6
7		use Generator;
8
9		/**
10		* @see AggregateRoot
11		*/
12		trait AggregateRootBehaviour
13		{
14		use AggregateAlwaysAppliesEvents;
15
16		private AggregateRootId $aggregateRootId;
17		private int $aggregateRootVersion = 0;
18		/** @var list<object> */
		0 ignored issues – show Bug introduced 2021-03-31 19:19 UTC by Report Bug Copy Issue Report The type `EventSauce\EventSourcing\list` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
19		private array $recordedEvents = [];
20
21		private function __construct(AggregateRootId $aggregateRootId)
22		{
23		$this->aggregateRootId = $aggregateRootId;
24		}
25
26		public function aggregateRootId(): AggregateRootId
27		{
28		return $this->aggregateRootId;
29	17	}
30
31	17	/**
32	17	* @see AggregateRoot::aggregateRootVersion
33		*/
34	14	public function aggregateRootVersion(): int
35		{
36	14	return $this->aggregateRootVersion;
37		}
38
39		protected function recordThat(object $event): void
40		{
41		$this->apply($event);
42	16	$this->recordedEvents[] = $event;
43		}
44	16
45		/**
46		* @return object[]
47	11	*/
48		public function releaseEvents(): array
49	11	{
50	11	$releasedEvents = $this->recordedEvents;
		0 ignored issues – show Documentation Bug introduced 2021-03-31 19:19 UTC by Report Bug Copy Issue Report It seems like `$this->recordedEvents` of type `array` is incompatible with the declared type `EventSauce\EventSourcing\list` of property `$recordedEvents`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
51	11	$this->recordedEvents = [];
52	11
53		return $releasedEvents;
54	9	}
55
56	9	/**
57	9	* @see AggregateRoot::reconstituteFromEvents
58	9	*/
59		public static function reconstituteFromEvents(AggregateRootId $aggregateRootId, Generator $events): static
60		{
61		$aggregateRoot = new static($aggregateRootId);
62
63	14	/** @var object $event */
64		foreach ($events as $event) {
65	14	$aggregateRoot->apply($event);
66	14	}
67
68	14	$aggregateRoot->aggregateRootVersion = $events->getReturn() ?: 0;
69
70		return $aggregateRoot;
71		}
72		}
73

EventSaucePHP / EventSauce

Pull Request — master (#84)

AggregateRootBehaviour::reconstituteFromEvents() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like