SyncPublisher::publish() - Code Metrics - Inspection of "Merge pull request #20 from Evaneos/amqp-pecl" - Evaneos/Burrow - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 613d98...fa04c9 )

by Rémi

created 2017-01-11 14:42 UTC

SyncPublisher::publish() B

↳ Parent: SyncPublisher

Complexity

Conditions	2
Paths	1

Size

Total Lines	25
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	8.8571
c	0
b	0
f	0
cc	2
eloc	16
nc	1
nop	3

<?php

namespace Burrow\Publisher;

use Burrow\Driver;
use Burrow\Message;
use Burrow\QueueHandler;
use Burrow\QueuePublisher;

class SyncPublisher implements QueuePublisher
{
    /** @var Driver */
    private $driver;

    /** @var string */
    private $exchangeName;

    /** @var int */
    private $timeout;

    /**
     * Constructor
     *
     * @param Driver $driver
     * @param string $exchangeName
     * @param int    $timeout
     */
    public function __construct(Driver $driver, $exchangeName, $timeout = 10)
    {
        $this->driver = $driver;
        $this->exchangeName = $exchangeName;
        $this->timeout = $timeout;
    }

    /**
     * Publish a message on the queue
     *
     * @param mixed    $data
     * @param string   $routingKey
     * @param string[] $headers
     *
     * @return mixed
     */
    public function publish($data, $routingKey = '', array $headers = [])
    {
        $response = null;
        $correlationId = uniqid();
        $replyTo = $this->driver->declareSimpleQueue('', Driver::QUEUE_EXCLUSIVE);

        $this->driver->publish(
            $this->exchangeName,
            new Message($data, $routingKey, $headers, $correlationId, $replyTo)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->driver->consume(
            $replyTo,
            function (Message $message) use ($replyTo, $correlationId, &$response) {
                if ($message->getCorrelationId() == $correlationId) {
                    $response = $message->getBody();
                    return QueueHandler::STOP_CONSUMING;
                }
                return QueueHandler::CONTINUE_CONSUMING;
            },
            $this->timeout
        );

        return $response;
    }
}


1			<?php
2
3			namespace Burrow\Publisher;
4
5			use Burrow\Driver;
6			use Burrow\Message;
7			use Burrow\QueueHandler;
8			use Burrow\QueuePublisher;
9
10			class SyncPublisher implements QueuePublisher
11			{
12			/** @var Driver */
13			private $driver;
14
15			/** @var string */
16			private $exchangeName;
17
18			/** @var int */
19			private $timeout;
20
21			/**
22			* Constructor
23			*
24			* @param Driver $driver
25			* @param string $exchangeName
26			* @param int $timeout
27			*/
28			public function __construct(Driver $driver, $exchangeName, $timeout = 10)
29			{
30			$this->driver = $driver;
31			$this->exchangeName = $exchangeName;
32			$this->timeout = $timeout;
33			}
34
35			/**
36			* Publish a message on the queue
37			*
38			* @param mixed $data
39			* @param string $routingKey
40			* @param string[] $headers
41			*
42			* @return mixed
43			*/
44			public function publish($data, $routingKey = '', array $headers = [])
45			{
46			$response = null;
47			$correlationId = uniqid();
48			$replyTo = $this->driver->declareSimpleQueue('', Driver::QUEUE_EXCLUSIVE);
49
50			$this->driver->publish(
51			$this->exchangeName,
52			new Message($data, $routingKey, $headers, $correlationId, $replyTo)
			0 ignored issues – show Documentation introduced 2017-01-11 15:02 UTC by Report Bug Copy Issue Report `$headers` is of type `array<integer,string>`, but the function expects a `array<integer,object<string>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53			);
54
55			$this->driver->consume(
56			$replyTo,
57			function (Message $message) use ($replyTo, $correlationId, &$response) {
58			if ($message->getCorrelationId() == $correlationId) {
59			$response = $message->getBody();
60			return QueueHandler::STOP_CONSUMING;
61			}
62			return QueueHandler::CONTINUE_CONSUMING;
63			},
64			$this->timeout
65			);
66
67			return $response;
68			}
69			}
70

Evaneos / Burrow

Push — master ( 613d98...fa04c9 )

SyncPublisher::publish() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like