Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 20 | class PhpAmqpLibDriver implements Driver |
||
| 21 | { |
||
| 22 | const DELIVERY_MODE = 'delivery_mode'; |
||
| 23 | const CONTENT_TYPE = 'content_type'; |
||
| 24 | const APPLICATION_HEADERS = 'application_headers'; |
||
| 25 | const CORRELATION_ID = 'correlation_id'; |
||
| 26 | const REPLY_TO = 'reply_to'; |
||
| 27 | |||
| 28 | /** @var AbstractConnection */ |
||
| 29 | private $connection; |
||
| 30 | |||
| 31 | /** @var AMQPChannel */ |
||
| 32 | private $channel; |
||
| 33 | |||
| 34 | /** @var bool */ |
||
| 35 | private $stop = false; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * PhpAmqpLibDriver constructor. |
||
| 39 | * |
||
| 40 | * @param AbstractConnection $connection |
||
| 41 | */ |
||
| 42 | public function __construct(AbstractConnection $connection) |
||
| 46 | |||
| 47 | /** |
||
| 48 | * Declare a persistent queue |
||
| 49 | * |
||
| 50 | * @param string $queueName |
||
| 51 | * @param string $type |
||
| 52 | * |
||
| 53 | * @return string |
||
| 54 | */ |
||
| 55 | public function declareSimpleQueue($queueName = '', $type = self::QUEUE_DURABLE) |
||
| 64 | |||
| 65 | /** |
||
| 66 | * Declare an exchange |
||
| 67 | * |
||
| 68 | * @param string $exchangeName |
||
| 69 | * @param string $type |
||
| 70 | * |
||
| 71 | * @return string |
||
| 72 | */ |
||
| 73 | public function declareExchange($exchangeName = '', $type = self::EXCHANGE_TYPE_FANOUT) |
||
| 79 | |||
| 80 | /** |
||
| 81 | * Bind an existing queue to an exchange |
||
| 82 | * |
||
| 83 | * @param string $exchange |
||
| 84 | * @param string $queueName |
||
| 85 | * @param string $routingKey |
||
| 86 | * @return void |
||
| 87 | */ |
||
| 88 | public function bindQueue($exchange, $queueName, $routingKey = '') |
||
| 92 | |||
| 93 | /** |
||
| 94 | * Create a persisting queue and bind it to an exchange |
||
| 95 | * |
||
| 96 | * @param string $exchange |
||
| 97 | * @param string $queueName |
||
| 98 | * @param string $routingKey |
||
| 99 | * @return void |
||
| 100 | */ |
||
| 101 | public function declareAndBindQueue($exchange, $queueName, $routingKey = '') |
||
| 106 | |||
| 107 | /** |
||
| 108 | * Delete a queue |
||
| 109 | * |
||
| 110 | * @param string $queueName |
||
| 111 | * @return void |
||
| 112 | */ |
||
| 113 | public function deleteQueue($queueName) |
||
| 117 | |||
| 118 | /** |
||
| 119 | * Delete an exchange |
||
| 120 | * |
||
| 121 | * @param string $exchangeName |
||
| 122 | * @return void |
||
| 123 | */ |
||
| 124 | public function deleteExchange($exchangeName) |
||
| 128 | |||
| 129 | /** |
||
| 130 | * Publish a message in the exchange |
||
| 131 | * |
||
| 132 | * @param string $exchangeName |
||
| 133 | * @param Message $message |
||
| 134 | * |
||
| 135 | * @return void |
||
| 136 | */ |
||
| 137 | public function publish($exchangeName, Message $message) |
||
| 145 | |||
| 146 | /** |
||
| 147 | * Consume the queue |
||
| 148 | * |
||
| 149 | * @param string $queueName |
||
| 150 | * @param callable $callback |
||
| 151 | * @param int $timeout |
||
| 152 | * @param bool $autoAck |
||
| 153 | * |
||
| 154 | * @return void |
||
| 155 | * @throws \Exception |
||
| 156 | */ |
||
| 157 | public function consume($queueName, callable $callback, $timeout = 0, $autoAck = true) |
||
| 200 | |||
| 201 | /** |
||
| 202 | * Acknowledge the reception of the message |
||
| 203 | * |
||
| 204 | * @param Message $message |
||
| 205 | * |
||
| 206 | * @return void |
||
| 207 | */ |
||
| 208 | public function ack(Message $message) |
||
| 212 | |||
| 213 | /** |
||
| 214 | * Aknowledge an error during the consumption of the message |
||
| 215 | * |
||
| 216 | * @param Message $message |
||
| 217 | * @param bool $requeue |
||
| 218 | * |
||
| 219 | * @return void |
||
| 220 | */ |
||
| 221 | public function nack(Message $message, $requeue = true) |
||
| 225 | |||
| 226 | /** |
||
| 227 | * Close the connection |
||
| 228 | * |
||
| 229 | * @return void |
||
| 230 | */ |
||
| 231 | public function close() |
||
| 238 | |||
| 239 | /** |
||
| 240 | * @return AMQPChannel |
||
| 241 | */ |
||
| 242 | private function getChannel() |
||
| 250 | |||
| 251 | /** |
||
| 252 | * Returns the message parameters |
||
| 253 | * |
||
| 254 | * @param Message $message |
||
| 255 | * |
||
| 256 | * @return array |
||
| 257 | */ |
||
| 258 | View Code Duplication | private static function getMessageProperties(Message $message) |
|
| 277 | |||
| 278 | /** |
||
| 279 | * @param AMQPMessage $message |
||
| 280 | * |
||
| 281 | * @return array |
||
| 282 | */ |
||
| 283 | private static function getHeaders(AMQPMessage $message) |
||
| 288 | |||
| 289 | /** |
||
| 290 | * @param AMQPMessage $message |
||
| 291 | * |
||
| 292 | * @return string |
||
| 293 | */ |
||
| 294 | private static function getCorrelationId(AMQPMessage $message) |
||
| 299 | |||
| 300 | /** |
||
| 301 | * @param AMQPMessage $message |
||
| 302 | * |
||
| 303 | * @return string |
||
| 304 | */ |
||
| 305 | private static function getReplyTo(AMQPMessage $message) |
||
| 310 | } |
||
| 311 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: