SendMetricListenerProvider - Code Metrics - Inspection of "feat: allow to send metrics to StatsD or DogStatsD" - Evaneos/Burrow - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#27)

by Frederic

created 2018-12-19 13:34 UTC

SendMetricListenerProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	5
dl	0
loc	31
ccs	11
cts	11
cp	1
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	provideListeners()	0	10	1

<?php

namespace Burrow\Event\Listener\Metric;

use Burrow\Event\DaemonStarted;
use Burrow\Event\DaemonStopped;
use Burrow\Event\MessageConsumed;
use Burrow\Event\MessageReceived;
use Burrow\Metric\MetricService;
use League\Event\ListenerAcceptorInterface;
use League\Event\ListenerProviderInterface;

class SendMetricListenerProvider implements ListenerProviderInterface
{
    /** @var MetricService  */
    private $metricService;

    /**
     * SendMetricSubscriber constructor.
     *
     * @param MetricService $metricService
     */
    public function __construct(MetricService $metricService)
    {
        $this->metricService = $metricService;
    }

    /**
     * @param ListenerAcceptorInterface $listenerAcceptor
     *
     * @return ListenerProviderInterface|void
     */
    public function provideListeners(ListenerAcceptorInterface $listenerAcceptor)
    {
        $listenerAcceptor->addListener(DaemonStarted::NAME, new SendMetricOnDaemonStarted($this->metricService));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $listenerAcceptor->addListener(DaemonStopped::NAME, new SendMetricOnDaemonStopped($this->metricService));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $listenerAcceptor->addListener(MessageReceived::NAME, new SendMetricOnMessageReceived($this->metricService));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $sendMetricOnMessageConsumed = new SendMetricOnMessageConsumed($this->metricService);
        $listenerAcceptor->addListener(MessageReceived::NAME, $sendMetricOnMessageConsumed);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $listenerAcceptor->addListener(MessageConsumed::NAME, $sendMetricOnMessageConsumed);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		namespace Burrow\Event\Listener\Metric;
4
5		use Burrow\Event\DaemonStarted;
6		use Burrow\Event\DaemonStopped;
7		use Burrow\Event\MessageConsumed;
8		use Burrow\Event\MessageReceived;
9		use Burrow\Metric\MetricService;
10		use League\Event\ListenerAcceptorInterface;
11		use League\Event\ListenerProviderInterface;
12
13		class SendMetricListenerProvider implements ListenerProviderInterface
14		{
15		/** @var MetricService */
16		private $metricService;
17
18		/**
19		* SendMetricSubscriber constructor.
20		*
21		* @param MetricService $metricService
22		*/
23	3	public function __construct(MetricService $metricService)
24		{
25	3	$this->metricService = $metricService;
26	3	}
27
28		/**
29		* @param ListenerAcceptorInterface $listenerAcceptor
30		*
31		* @return ListenerProviderInterface\|void
32		*/
33	3	public function provideListeners(ListenerAcceptorInterface $listenerAcceptor)
34		{
35	3	$listenerAcceptor->addListener(DaemonStarted::NAME, new SendMetricOnDaemonStarted($this->metricService));
		0 ignored issues – show Documentation introduced 2018-12-17 13:06 UTC by Report Bug Copy Issue Report `new \Burrow\Event\Listen...d($this->metricService)` is of type `object<Burrow\Event\List...dMetricOnDaemonStarted>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36	3	$listenerAcceptor->addListener(DaemonStopped::NAME, new SendMetricOnDaemonStopped($this->metricService));
		0 ignored issues – show Documentation introduced 2018-12-17 13:06 UTC by Report Bug Copy Issue Report `new \Burrow\Event\Listen...d($this->metricService)` is of type `object<Burrow\Event\List...dMetricOnDaemonStopped>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37	3	$listenerAcceptor->addListener(MessageReceived::NAME, new SendMetricOnMessageReceived($this->metricService));
		0 ignored issues – show Documentation introduced 2018-12-17 13:06 UTC by Report Bug Copy Issue Report `new \Burrow\Event\Listen...d($this->metricService)` is of type `object<Burrow\Event\List...etricOnMessageReceived>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38
39	3	$sendMetricOnMessageConsumed = new SendMetricOnMessageConsumed($this->metricService);
40	3	$listenerAcceptor->addListener(MessageReceived::NAME, $sendMetricOnMessageConsumed);
		0 ignored issues – show Documentation introduced 2018-12-18 16:04 UTC by Report Bug Copy Issue Report `$sendMetricOnMessageConsumed` is of type `object<Burrow\Event\List...etricOnMessageConsumed>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41	3	$listenerAcceptor->addListener(MessageConsumed::NAME, $sendMetricOnMessageConsumed);
		0 ignored issues – show Documentation introduced 2018-12-18 16:04 UTC by Report Bug Copy Issue Report `$sendMetricOnMessageConsumed` is of type `object<Burrow\Event\List...etricOnMessageConsumed>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42	3	}
43		}
44

Evaneos / Burrow

Pull Request — master (#27)

SendMetricListenerProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like