Issues in qte.php - New Issues - Inspection of "Add tests requirements" - ErnadoO/qte - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Branch — master (1e3863)

by Erwan
created 2016-06-21 17:51 UTC
qte.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
<?php
/**
 *
 * @package Quick Title Edition Extension
 * @copyright (c) 2015 ABDev
 * @copyright (c) 2015 PastisD
 * @copyright (c) 2015 Geolim4 <http://geolim4.com>
 * @copyright (c) 2015 Zoddo <[email protected]>
 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
 *
 */

namespace abdev\qte;

class qte
{
	const KEEP = -2;
	const REMOVE = -1;

	/** @var \phpbb\request\request */
	protected $request;

	/** @var \phpbb\cache\driver\driver_interface */
	protected $cache;

	/** @var \phpbb\config\config */
	protected $config;

	/** @var \phpbb\db\driver\driver_interface */
	protected $db;

	/** @var \phpbb\template\template */
	protected $template;

	/** @var \phpbb\user */
	protected $user;

	/** @var \phpbb\log\log */
	protected $log;

	/** @var string */
	protected $root_path;

	/** @var string */
	protected $php_ext;

	/** @var string */
	protected $table_prefix;

	/** @var array */
	protected $attr = array();

	/** @var array */
	protected $name = array();

	public function __construct(\phpbb\request\request $request, \phpbb\cache\driver\driver_interface $cache, \phpbb\config\config $config, \phpbb\db\driver\driver_interface $db, \phpbb\template\template $template, \phpbb\user $user, \phpbb\log\log $log, $root_path, $php_ext, $table_prefix)
	{
		$this->request = $request;
		$this->cache = $cache;
		$this->config = $config;
		$this->db = $db;
		$this->template = $template;
		$this->user = $user;
		$this->log = $log;

		$this->root_path = $root_path;
		$this->php_ext = $php_ext;
		$this->table_prefix = $table_prefix;

		$this->get_attributes();
	}

	protected function get_attributes()
	{
		if (($this->attr = $this->cache->get('_attr')) === false)
		{
			$sql = 'SELECT *
				FROM ' . $this->table_prefix . 'topics_attr
				ORDER BY left_id ASC';
			$result = $this->db->sql_query($sql);

			$this->attr = array();
			while ($row = $this->db->sql_fetchrow($result))
			{
				$this->attr[$row['attr_id']] = array(
					'attr_id' => (int) $row['attr_id'],
					'attr_type' => (bool) $row['attr_type'],
					'attr_name' => $row['attr_name'],
					'attr_desc' => $row['attr_desc'],
					'attr_img' => $row['attr_img'],
					'attr_colour' => $row['attr_colour'],
					'attr_date' => $row['attr_date'],
					'attr_user_colour' => (bool) $row['attr_user_colour'],
					'attr_auths' => $row['attr_auths'],
				);
			}
			$this->db->sql_freeresult();

			$this->cache->put('_attr', $this->attr);
		}
	}

	public function get_users_by_topic_id($topic_list)
	{
		$this->name = array();
		if (!empty($topic_list))
		{
			$sql = 'SELECT u.user_id, u.username, u.user_colour
				FROM ' . USERS_TABLE . ' u
				LEFT JOIN ' . TOPICS_TABLE . ' t ON (u.user_id = t.topic_attr_user)
				WHERE ' . $this->db->sql_in_set('t.topic_id', array_map('intval', $topic_list)) . '
					AND t.topic_attr_user <> ' . ANONYMOUS;
			$result = $this->db->sql_query($sql);

			while ($row = $this->db->sql_fetchrow($result))
			{
				$this->name[$row['user_id']] = array(
					'user_id' => (int) $row['user_id'],
					'username' => $row['username'],
					'user_colour' => $row['user_colour'],
				);
			}
			$this->db->sql_freeresult();
		}
	}

	public function get_users_by_user_id($user_id)
	{
		$sql = 'SELECT user_id, username, user_colour
			FROM ' . USERS_TABLE . '
			WHERE user_id = ' . (int) $user_id;
		$result = $this->db->sql_query($sql);

		$this->name = array();
		while ($row = $this->db->sql_fetchrow($result))
		{
			$this->name[$row['user_id']] = array(
				'user_id' => (int) $row['user_id'],
				'username' => $row['username'],
				'user_colour' => $row['user_colour'],
			);
		}
		$this->db->sql_freeresult();
	}

	public function get_attr_name_by_id($attr_id)
	{
		$sql = 'SELECT attr_name
			FROM ' . $this->table_prefix . 'topics_attr
			WHERE attr_id = ' . (int) $attr_id;
		$result = $this->db->sql_query($sql);
		$attr_name = (string) $this->db->sql_fetchfield('attr_name');
		$this->db->sql_freeresult($result);

		if (empty($attr_name))
		{
			return;
		}

		return $attr_name;
	}

	public function attr_select($forum_id = 0, $author_id = 0, $attribute_id = 0, $hide_attr = array())
	{
		// include that file !
		if (!function_exists('group_memberships'))
		{
			include $this->root_path . 'includes/functions_user.' . $this->php_ext;
		}

		// load language
		$this->user->add_lang_ext('abdev/qte', 'attributes');

		// get groups membership !
		$user_membership = group_memberships(false, $this->user->data['user_id']);

		$show_remove = true;
		$user_groups = array();
		if (!empty($user_membership))
		{
			foreach ($user_membership as $row)
			{
				$row['group_id'] = (int) $row['group_id'];
				$user_groups[$row['group_id']] = $row['group_id'];
			}
		}
		unset($user_membership);

		// get current time once !
		$current_time = time();

		$show_select = false;

		$attributes = array();
		foreach ($this->attr as $attr)
		{
			if (empty($attr['attr_auths']))
			{
				$attr_auths = array(array(
					'forums_ids' => array(),
					'groups_ids' => array(),
					'author' => false,
				));
			}
			else
			{
				$attr_auths = json_decode($attr['attr_auths'], true);
			}

			foreach ($attr_auths as $attr_auth)
			{
				$forum_ids = $attr_auth['forums_ids'];
				$group_ids = $attr_auth['groups_ids'];

				if (is_array($forum_ids) && in_array($forum_id, $forum_ids))
				{
					if (is_array($group_ids) && array_intersect($group_ids, $user_groups) || ($attr_auth['author'] && ($author_id == $this->user->data['user_id'])))
					{
						// show the selector !
						$show_select = true;

						$groups_removed = array_intersect($user_groups, $hide_attr);
						if (!empty($hide_attr) && (count($groups_removed) >= count($user_groups)))
						{
							$show_remove = false;
						}

						if (!isset($attributes[$attr['attr_id']]))
						{
							// parse the attribute name
							$attribute_name = str_replace(array('%mod%', '%date%'), array($this->user->data['username'], $this->user->format_date($current_time, $attr['attr_date'])), $this->attr_lng_key($attr['attr_name']));

							$attributes[$attr['attr_id']] = array(
								'type' => $attr['attr_type'],
								'name' => $attribute_name,
								'desc' => $this->attr_lng_key($attr['attr_desc']),
								'colour' => $this->attr_colour($attr['attr_name'], $attr['attr_colour']),

								'select' => (!empty($attribute_id) && ($attr['attr_id'] == $attribute_id)),

								's_desc' => !empty($attr['attr_desc']),
							);
						}
					}
				}
			}
			unset($attr_auth);
		}
		unset($attr);

		foreach ($attributes as $attr_id => $attr_row)
		{
			$this->template->assign_block_vars('attributes', array(
				'QTE_ID' => $attr_id,
				'QTE_TYPE' => $attr_row['type'],
				'QTE_NAME' => $attr_row['name'],
				'QTE_DESC' => $attr_row['desc'],
				'QTE_COLOUR' => $attr_row['colour'],

				'IS_SELECTED' => $attr_row['select'],

				'S_QTE_DESC' => !empty($attr_row['s_desc']) ? true : false,
			));
		}
		unset($attr_id, $attr_row);

		if ($show_select)
		{
			$this->template->assign_vars(array(
				'S_QTE_SELECT' => true,
				'S_QTE_REMOVE' => $show_remove,
				'S_QTE_EMPTY' => (empty($attribute_id) || ($attribute_id == -1) || ($attribute_id == -2)),
				'S_QTE_SELECTED' => ($show_remove && ($attribute_id == -1)),

				'L_QTE_SELECT' => $this->user->lang['QTE_ATTRIBUTE_' . (!empty($attribute_id) ? ($show_remove ? 'REMOVE' : 'RESTRICT') : 'ADD')],
			));
		}
	}

	public function attr_search()
	{
		// load language
		$this->user->add_lang_ext('abdev/qte', array('attributes', 'attributes_acp'));

		$show_select = false;

		$attributes = array();
		foreach ($this->attr as $attr)
		{
			if (empty($attr['attr_auths']))
			{
				$attr_auths = array(array(
					'forums_ids' => array(),
					'groups_ids' => array(),
					'author' => false,
				));
			}
			else
			{
				$attr_auths = json_decode($attr['attr_auths'], true);
			}

			foreach ($attr_auths as $attr_auth)
			{
				// show the selector !
				$show_select = true;

				if (!isset($attributes[$attr['attr_id']]))
				{
					// parse the attribute name
					$attribute_name = str_replace(array('%mod%', '%date%'), array($this->user->lang['QTE_KEY_USERNAME'], $this->user->lang['QTE_KEY_DATE']), $this->attr_lng_key($attr['attr_name']));

					$attributes[$attr['attr_id']] = array(
						'type' => $attr['attr_type'],
						'name' => $attribute_name,
						'desc' => $this->attr_lng_key($attr['attr_desc']),
						'colour' => $this->attr_colour($attr['attr_name'], $attr['attr_colour']),

						's_desc' => !empty($attr['attr_desc']) ? true : false,
					);
				}
			}
			unset($attr_auth);
		}
		unset($attr);

		foreach ($attributes as $attr_id => $attr_row)
		{
			$this->template->assign_block_vars('attributes', array(
				'QTE_ID' => $attr_id,
				'QTE_TYPE' => $attr_row['type'],
				'QTE_NAME' => $attr_row['name'],
				'QTE_DESC' => $attr_row['desc'],
				'QTE_COLOUR' => $attr_row['colour'],

				'S_QTE_DESC' => $attr_row['s_desc'],
			));
		}
		unset($attr_id, $attr_row);

		if ($show_select)
		{
			$this->template->assign_var('S_QTE_SELECT', true);
		}
	}

	public function attr_sort($forum_id = 0, $attribute_id = 0)
	{
		// load language
		$this->user->add_lang_ext('abdev/qte', array('attributes', 'attributes_acp'));

		$show_select = false;

		$attributes = array();
		foreach ($this->attr as $attr)
		{
			if (empty($attr['attr_auths']))
			{
				$attr_auths = array(array(
					'forums_ids' => array(),
					'groups_ids' => array(),
					'author' => false,
				));
			}
			else
			{
				$attr_auths = json_decode($attr['attr_auths'], true);
			}

			foreach ($attr_auths as $attr_auth)
			{
				$forum_ids = $attr_auth['forums_ids'];

				if (is_array($forum_ids) && in_array($forum_id, $forum_ids))
				{
					// show the selector !
					$show_select = true;

					if (!isset($attributes[$attr['attr_id']]))
					{
						// parse the attribute name
						$attribute_name = str_replace(array('%mod%', '%date%'), array($this->user->lang['QTE_KEY_USERNAME'], $this->user->lang['QTE_KEY_DATE']), $this->attr_lng_key($attr['attr_name']));

						$attributes[$attr['attr_id']] = array(
							'type' => $attr['attr_type'],
							'name' => $attribute_name,
							'desc' => $this->attr_lng_key($attr['attr_desc']),
							'colour' => $this->attr_colour($attr['attr_name'], $attr['attr_colour']),

							'select' => (!empty($attribute_id) && ($attr['attr_id'] == $attribute_id)) ? true : false,

							's_desc' => !empty($attr['attr_desc']) ? true : false,
						);
					}
				}
			}
			unset($attr_auth);
		}
		unset($attr);

		foreach ($attributes as $attr_id => $attr_row)
		{
			$this->template->assign_block_vars('attributes', array(
				'QTE_ID' => $attr_id,
				'QTE_TYPE' => $attr_row['type'],
				'QTE_NAME' => $attr_row['name'],
				'QTE_DESC' => $attr_row['desc'],
				'QTE_COLOUR' => $attr_row['colour'],

				'IS_SELECTED' => $attr_row['select'],

				'S_QTE_DESC' => $attr_row['s_desc'],
			));
		}
		unset($attr_id, $attr_row);

		if ($show_select)
		{
			$this->template->assign_var('S_QTE_SELECT', true);
		}
	}

	public function attr_default($forum_id = 0, $attribute_id = 0)
	{
		// load language
		$this->user->add_lang_ext('abdev/qte', array('attributes', 'attributes_acp'));

		$show_select = false;

		$attributes = array();
		foreach ($this->attr as $attr)
		{
			if (empty($attr['attr_auths']))
			{
				$attr_auths = array(array(
					'forums_ids' => array(),
					'groups_ids' => array(),
					'author' => false,
				));
			}
			else
			{
				$attr_auths = json_decode($attr['attr_auths'], true);
			}

			foreach ($attr_auths as $attr_auth)
			{
				$forum_ids = $attr_auth['forums_ids'];

				if (is_array($forum_ids) && in_array($forum_id, $forum_ids))
				{
					// show the selector !
					$show_select = true;

					if (!isset($attributes[$attr['attr_id']]))
					{
						// parse the attribute name
						$attribute_name = str_replace(array('%mod%', '%date%'), array($this->user->lang['QTE_KEY_USERNAME'], $this->user->lang['QTE_KEY_DATE']), $this->attr_lng_key($attr['attr_name']));

						$attributes[$attr['attr_id']] = array(
							'type' => $attr['attr_type'],
							'name' => $attribute_name,
							'desc' => $this->attr_lng_key($attr['attr_desc']),
							'colour' => $this->attr_colour($attr['attr_name'], $attr['attr_colour']),

							'select' => (!empty($attribute_id) && ($attr['attr_id'] == $attribute_id)) ? true : false,

							's_desc' => !empty($attr['attr_desc']) ? true : false,
						);
					}
				}
			}
			unset($attr_auth);
		}
		unset($attr);

		foreach ($attributes as $attr_id => $attr_row)
		{
			$this->template->assign_block_vars('attributes', array(
				'QTE_ID' => $attr_id,
				'QTE_TYPE' => $attr_row['type'],
				'QTE_NAME' => $attr_row['name'],
				'QTE_DESC' => $attr_row['desc'],
				'QTE_COLOUR' => $attr_row['colour'],

				'IS_SELECTED' => $attr_row['select'],

				'S_QTE_DESC' => $attr_row['s_desc'],
			));
		}
		unset($attr_id, $attr_row);

		if ($show_select)
		{
			$this->template->assign_var('S_QTE_SELECT', true);
		}
	}

	public function attr_display($attribute_id = 0, $user_id = 0, $timestamp = 0)
	{
		if (empty($attribute_id) || empty($user_id) || empty($timestamp))
		{
			return false;
		}

		if (isset($this->attr[$attribute_id]))
		{
			$attribute_colour = $this->attr_colour($this->attr[$attribute_id]['attr_name'], $this->attr[$attribute_id]['attr_colour']);

			if (isset($this->name[$user_id]['user_id']))
			{
				$attribute_username = get_username_string(($this->attr[$attribute_id]['attr_user_colour'] ? 'no_profile' : 'username'), $this->name[$user_id]['user_id'], $this->name[$user_id]['username'], $this->name[$user_id]['user_colour']);
			}
			else
			{
				$attribute_username = $this->user->lang['GUEST'];
			}

			$attribute_date = $this->user->format_date($timestamp, $this->attr[$attribute_id]['attr_date']);

			$attribute_name = str_replace(array('%mod%', '%date%'), array($attribute_username, $attribute_date), $this->attr_lng_key($this->attr[$attribute_id]['attr_name']));

			return !$this->attr[$attribute_id]['attr_type'] ? '<span' . $attribute_colour . '>' . $attribute_name . '</span>' : $this->attr_img_key($this->attr[$attribute_id]['attr_img'], $attribute_name);
		}
	}

	public function attr_title($attribute_id = 0, $user_id = 0, $timestamp = 0)
	{
		if (empty($attribute_id) || empty($user_id) || empty($timestamp))
		{
			return false;
		}

		if (isset($this->attr[$attribute_id]))
		{
			if (isset($this->name[$user_id]['user_id']))
			{
				$attribute_username = get_username_string('username', $this->name[$user_id]['user_id'], $this->name[$user_id]['username'], $this->name[$user_id]['user_colour']);
			}
			else
			{
				$attribute_username = $this->user->lang['GUEST'];
			}

			$attribute_date = $this->user->format_date($timestamp, $this->attr[$attribute_id]['attr_date']);

			$attribute_name = str_replace(array('%mod%', '%date%'), array($attribute_username, $attribute_date), $this->attr_lng_key($this->attr[$attribute_id]['attr_name']));

			return $attribute_name;
		}
	}

	public function attr_apply($attribute_id = 0, $topic_id = 0, $forum_id = 0, $topic_attribute = '')
	{
		if (empty($topic_id) || empty($forum_id) || empty($attribute_id))
		{
			return;
		}

		// time !
		$current_time = time();

		if ($attribute_id == -1)
		{
			$fields = array(
				'topic_attr_id' => 0,
				'topic_attr_user' => 0,
				'topic_attr_time' => 0,
			);
		}
		else
		{
			$fields = array(
				'topic_attr_id' => $attribute_id,
				'topic_attr_user' => $this->user->data['user_id'],
				'topic_attr_time' => $current_time,
			);
		}

		$sql = 'UPDATE ' . TOPICS_TABLE . '
			SET ' . $this->db->sql_build_array('UPDATE', $fields) . '
			WHERE topic_id = ' . (int) $topic_id;
		$this->db->sql_query($sql);

		$sql = 'SELECT topic_id
			FROM ' . TOPICS_TABLE . '
			WHERE topic_moved_id = ' . (int) $topic_id;
		$result = $this->db->sql_query($sql);
		$shadow_topic_id = (int) $this->db->sql_fetchfield('topic_id');
		$this->db->sql_freeresult($result);

		if (!empty($shadow_topic_id))
		{
			$sql = 'UPDATE ' . TOPICS_TABLE . '
				SET ' . $this->db->sql_build_array('UPDATE', $fields) . '
				WHERE topic_id = ' . $shadow_topic_id;
			$this->db->sql_query($sql);
		}

		$meta_url = append_sid("{$this->root_path}viewtopic.$this->php_ext", "f=$forum_id&amp;t=$topic_id");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
		meta_refresh(3, $meta_url);

		// load language
		$this->user->add_lang('posting');
		$this->user->add_lang_ext('abdev/qte', 'attributes');

		$message = $this->user->lang['QTE_ATTRIBUTE_' . ($attribute_id == -1 ? 'REMOVED' : (empty($topic_attribute) ? 'ADDED' : 'UPDATED'))] . '<br /><br />' . sprintf($this->user->lang['VIEW_MESSAGE'], '<a href="' . $meta_url . '">', '</a>');
		$message .= '<br /><br />' . sprintf($this->user->lang['RETURN_FORUM'], '<a href="' . append_sid("{$this->root_path}viewforum.$this->php_ext", 'f=' . $forum_id) . '">', '</a>');
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

		trigger_error($message);
	}

	public function mcp_attr_apply($attribute_id = 0, $topic_ids = array())
	{
		// load language
		$this->user->add_lang_ext('abdev/qte', 'attributes');

		if (!sizeof($topic_ids))
		{
			trigger_error('NO_TOPIC_SELECTED');
		}

		if (!phpbb_check_ids($topic_ids, TOPICS_TABLE, 'topic_id'))
		{
			return;
		}

		// time !
		$current_time = time();

		$sql = 'SELECT topic_id, forum_id, topic_title, topic_attr_id
			FROM ' . TOPICS_TABLE . '
			WHERE ' . $this->db->sql_in_set('topic_id', array_map('intval', $topic_ids));
		$result = $this->db->sql_query($sql);

		// log this action
		while ($row = $this->db->sql_fetchrow($result))
		{
			$message = ($attribute_id == -1) ? 'REMOVED' : (empty($row['topic_attr_id']) ? 'ADDED' : 'UPDATED');
			$additional_data = array(
				'forum_id'	=> $row['forum_id'],
				'topic_id'	=> $row['topic_id'],
				$row['topic_title'],
			);
			$this->log->add('mod', $this->user->data['user_id'], $this->user->ip, 'MCP_ATTRIBUTE_' . $message, $current_time, $additional_data);
		}
		$this->db->sql_freeresult($result);

		if ($attribute_id == -1)
		{
			$fields = array(
				'topic_attr_id' => 0,
				'topic_attr_user' => 0,
				'topic_attr_time' => 0,
			);
		}
		else
		{
			$fields = array(
				'topic_attr_id' => $attribute_id,
				'topic_attr_user' => $this->user->data['user_id'],
				'topic_attr_time' => $current_time,
			);
		}

		$sql = 'UPDATE ' . TOPICS_TABLE . '
			SET ' . $this->db->sql_build_array('UPDATE', $fields) . '
			WHERE ' . $this->db->sql_in_set('topic_id', array_map('intval', $topic_ids));
		$this->db->sql_query($sql);

		$sql = 'SELECT topic_id
			FROM ' . TOPICS_TABLE . '
			WHERE ' . $this->db->sql_in_set('topic_moved_id', array_map('intval', $topic_ids));
		$result = $this->db->sql_query($sql);

		$shadow_topic_ids = array();
		while ($row = $this->db->sql_fetchrow($result))
		{
			$shadow_topic_ids[] = (int) $row['topic_id'];
		}
		$this->db->sql_freeresult($result);

		if (sizeof($shadow_topic_ids))
		{
			$sql = 'UPDATE ' . TOPICS_TABLE . '
				SET ' . $this->db->sql_build_array('UPDATE', $fields) . '
				WHERE ' . $this->db->sql_in_set('topic_id', array_map('intval', $shadow_topic_ids));
			$this->db->sql_query($sql);
		}

		$redirect = $this->request->variable('redirect', $this->user->data['session_page']);

		meta_refresh(3, $redirect);
		trigger_error($this->user->lang['QTE_TOPIC' . (sizeof($topic_ids) == 1 ? '' : 'S') . '_ATTRIBUTE_' . $message] . '<br /><br />' . sprintf($this->user->lang['RETURN_PAGE'], '<a href="' . $redirect . '">', '</a>'));

		return;
	}

	public function getAttr()
	{
		return $this->attr;
	}

	// borrowed function from "ACP Announcement Centre" mod
	public function qte_group_select($group_ids, $exclude_ids = array(), $manage_founder = false)
	{
		$exclude_sql = ($exclude_ids !== false && sizeof($exclude_ids)) ? 'WHERE ' . $this->db->sql_in_set('group_id', array_map('intval', $exclude_ids), true) : '';
		$sql_and = !$this->config['coppa_enable'] ? ($exclude_sql ? ' AND ' : ' WHERE ') . "group_name <> 'REGISTERED_COPPA'" : '';
		$sql_founder = ($manage_founder !== false) ? (($exclude_sql || $sql_and) ? ' AND ' : ' WHERE ') . 'group_founder_manage = ' . (int) $manage_founder : '';

		$sql = 'SELECT group_id, group_name, group_type
			FROM ' . GROUPS_TABLE . "
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
			$exclude_sql
			$sql_and
			$sql_founder
			ORDER BY group_type DESC, group_name ASC";
		$result = $this->db->sql_query($sql);

		$s_group_options = '';
		while ($row = $this->db->sql_fetchrow($result))
		{
			$selected = in_array($row['group_id'], $group_ids) ? ' selected="selected"' : '';
			$s_group_options .= '<option' . (($row['group_type'] == GROUP_SPECIAL) ? ' class="sep"' : '') . ' value="' . $row['group_id'] . '"' . $selected . '>' . (($row['group_type'] == GROUP_SPECIAL) ? $this->user->lang['G_' . $row['group_name']] : $row['group_name']) . '</option>';
		}
		$this->db->sql_freeresult($result);

		return $s_group_options;
	}

	// borrowed from "Categories Hierarchy" : used to check if a language key exists
	public function attr_lng_key($key)
	{
		// load language
		$this->user->add_lang_ext('abdev/qte', 'attributes');

		return isset($this->user->lang[$key]) ? $this->user->lang[$key] : $key;
	}

	// borrowed from "Categories Hierarchy" : used to check if a image key exists
	public function attr_img_key($key, $alt)
	{
		return empty($key) ? '' : (preg_match('#^[a-z0-9_-]+$#i', $key) ? $this->user->img($key, $alt) : '<img src="' . (preg_match('#^(ht|f)tp[s]?\://#i', $key) ? $key : $this->root_path . $key) . '" alt="' . $alt . '" title="' . $alt . '" />');
	}

	public function attr_colour($a_name, $a_colour)
	{
		$a_name = preg_replace("#[^a-z0-9 _-]#", '', strtolower($a_name));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		if (!empty($a_name))
		{
			$a_name .= '-qte';
		}

		return ' class="qte-attr ' . $a_name . '"' . (!empty($a_colour) ? ' style="color:#' . $a_colour . '; font-weight:bold;"' : '');
	}
}

ErnadoO / qte

Branch — master (1e3863)

qte.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like
