Completed
Pull Request — master (#13)
by Erwan
02:05
created
migrations/v200/convert_old_permissions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 
53 53
 		while ($row = $this->db->sql_fetchrow($result))
54 54
 		{
55
-			$auth_option = 'f_qte_attr_'.$row['attr_id'];
55
+			$auth_option = 'f_qte_attr_' . $row['attr_id'];
56 56
 			$migrator_tool_permission->add($auth_option, false);
57 57
 
58 58
 			$attr_permissions_array[$auth_option] = json_decode($row['attr_auths'], true);
Please login to merge, or discard this patch.
event/search_listener.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
 
31 31
 	public function __construct(\phpbb\request\request $request, \ernadoo\qte\qte $qte, \ernadoo\qte\search\fulltext_attribute $qte_search)
32 32
 	{
33
-		$this->request		= $request;
34
-		$this->qte			= $qte;
35
-		$this->qte_search	= $qte_search;
33
+		$this->request = $request;
34
+		$this->qte = $qte;
35
+		$this->qte_search = $qte_search;
36 36
 	}
37 37
 
38 38
 	static public function getSubscribedEvents()
@@ -119,8 +119,8 @@  discard block
 block discarded – undo
119 119
 	{
120 120
 		if ($this->searc_attr)
121 121
 		{
122
-			$keywords	= utf8_normalize_nfc($this->request->variable('keywords', '', true));
123
-			$author		= $this->request->variable('author', '', true);
122
+			$keywords = utf8_normalize_nfc($this->request->variable('keywords', '', true));
123
+			$author = $this->request->variable('author', '', true);
124 124
 
125 125
 			if (!$keywords && !$author)
126 126
 			{
Please login to merge, or discard this patch.
event/main_listener.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -33,9 +33,9 @@  discard block
 block discarded – undo
33 33
 
34 34
 	public function __construct(\phpbb\request\request $request, \phpbb\template\template $template, \phpbb\user $user, \phpbb\log\log $log, \ernadoo\qte\qte $qte)
35 35
 	{
36
-		$this->request	= $request;
37
-		$this->template	= $template;
38
-		$this->user		= $user;
36
+		$this->request = $request;
37
+		$this->template = $template;
38
+		$this->user = $user;
39 39
 		$this->log		= $log;
40 40
 		$this->qte		= $qte;
41 41
 	}
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 
120 120
 				if ($topic_attribute != \ernadoo\qte\qte::KEEP)
121 121
 				{
122
-					$post_data['topic_attr_id']		= (int) $topic_attribute;
122
+					$post_data['topic_attr_id'] = (int) $topic_attribute;
123 123
 					$post_data['topic_attr_user']	= (int) $this->user->data['user_id'];
124 124
 					$post_data['topic_attr_time']	= time();
125 125
 
@@ -142,11 +142,11 @@  discard block
 block discarded – undo
142 142
 
143 143
 		if ($event['post_data']['force_attr'])
144 144
 		{
145
-			if ($post_data['attr_id'] == \ernadoo\qte\qte::REMOVE && ($event['mode'] == 'post' || ($event['mode'] == 'edit' && $event['post_data']['topic_first_post_id'] == $event['post_id'])) )
145
+			if ($post_data['attr_id'] == \ernadoo\qte\qte::REMOVE && ($event['mode'] == 'post' || ($event['mode'] == 'edit' && $event['post_data']['topic_first_post_id'] == $event['post_id'])))
146 146
 			{
147 147
 				$error = $event['error'];
148 148
 				$error[] = $this->user->lang['QTE_ATTRIBUTE_UNSELECTED'];
149
-				$event['error'] = $error ;
149
+				$event['error'] = $error;
150 150
 
151 151
 				// init the value
152 152
 				$post_data['attr_id'] = 0;
Please login to merge, or discard this patch.
event/mcp_listener.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -30,8 +30,8 @@  discard block
 block discarded – undo
30 30
 	*/
31 31
 	public function __construct(\phpbb\request\request $request, \ernadoo\qte\qte $qte)
32 32
 	{
33
-		$this->request	= $request;
34
-		$this->qte		= $qte;
33
+		$this->request = $request;
34
+		$this->qte = $qte;
35 35
 	}
36 36
 
37 37
 	static public function getSubscribedEvents()
@@ -56,8 +56,8 @@  discard block
 block discarded – undo
56 56
 
57 57
 	public function mcp_select_assign_attributes($event)
58 58
 	{
59
-		$attr_id	= (int) $this->request->variable('attr_id', 0);
60
-		$forum_id	= (int) $event['forum_info']['forum_id'];
59
+		$attr_id = (int) $this->request->variable('attr_id', 0);
60
+		$forum_id = (int) $event['forum_info']['forum_id'];
61 61
 
62 62
 		if ($attr_id)
63 63
 		{
Please login to merge, or discard this patch.
qte.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -69,16 +69,16 @@  discard block
 block discarded – undo
69 69
 	*/
70 70
 	public function __construct(\phpbb\request\request $request, \phpbb\cache\driver\driver_interface $cache, \phpbb\db\driver\driver_interface $db, \phpbb\template\template $template, \phpbb\user $user, \phpbb\log\log $log, \phpbb\auth\auth $auth, $root_path, $php_ext, $table_prefix)
71 71
 	{
72
-		$this->request		= $request;
72
+		$this->request = $request;
73 73
 		$this->cache		= $cache;
74
-		$this->db			= $db;
75
-		$this->template		= $template;
74
+		$this->db = $db;
75
+		$this->template = $template;
76 76
 		$this->user			= $user;
77
-		$this->log			= $log;
77
+		$this->log = $log;
78 78
 		$this->auth			= $auth;
79 79
 
80
-		$this->root_path	= $root_path;
81
-		$this->php_ext		= $php_ext;
80
+		$this->root_path = $root_path;
81
+		$this->php_ext = $php_ext;
82 82
 		$this->table_prefix = $table_prefix;
83 83
 
84 84
 		$this->_get_attributes();
@@ -168,10 +168,10 @@  discard block
 block discarded – undo
168 168
 	public function attr_select($forum_id, $author_id = 0, $attribute_id = 0, $viewtopic_url = '')
169 169
 	{
170 170
 		$show_select	= false;
171
-		$current_time	= time();
172
-		$can_edit		= $this->auth->acl_get('m_qte_attr_edit', $forum_id);
171
+		$current_time = time();
172
+		$can_edit = $this->auth->acl_get('m_qte_attr_edit', $forum_id);
173 173
 		$can_remove		= $this->auth->acl_get('m_qte_attr_del', $forum_id);
174
-		$is_author		= $this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id;
174
+		$is_author = $this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id;
175 175
 
176 176
 		// Basic auth
177 177
 		if (!$can_remove && !$can_edit && !$is_author)
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 
182 182
 		foreach ($this->_attr as $attr)
183 183
 		{
184
-			if (!$this->auth->acl_get('f_qte_attr_'.$attr['attr_id'], $forum_id))
184
+			if (!$this->auth->acl_get('f_qte_attr_' . $attr['attr_id'], $forum_id))
185 185
 			{
186 186
 				continue;
187 187
 			}
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
 	{
252 252
 		foreach ($this->_attr as $attr)
253 253
 		{
254
-			$forum_allowed = $this->auth->acl_getf('f_qte_attr_'.$attr['attr_id'], true);
254
+			$forum_allowed = $this->auth->acl_getf('f_qte_attr_' . $attr['attr_id'], true);
255 255
 
256 256
 			if (isset($forum_allowed[$forum_id]))
257 257
 			{
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
 	{
285 285
 		foreach ($this->_attr as $attr)
286 286
 		{
287
-			$forum_allowed = $this->auth->acl_getf('f_qte_attr_'.$attr['attr_id'], true);
287
+			$forum_allowed = $this->auth->acl_getf('f_qte_attr_' . $attr['attr_id'], true);
288 288
 
289 289
 			if (isset($forum_allowed[$forum_id]))
290 290
 			{
@@ -395,8 +395,8 @@  discard block
 block discarded – undo
395 395
 			return;
396 396
 		}
397 397
 
398
-		$can_edit		= $this->auth->acl_get('m_qte_attr_edit', $forum_id) || $this->auth->acl_get('f_qte_attr_'.$attribute_id, $forum_id) && $this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id;
399
-		$can_remove		= $this->auth->acl_get('m_qte_attr_del', $forum_id);
398
+		$can_edit = $this->auth->acl_get('m_qte_attr_edit', $forum_id) || $this->auth->acl_get('f_qte_attr_' . $attribute_id, $forum_id) && $this->user->data['is_registered'] && $this->user->data['user_id'] == $author_id;
399
+		$can_remove = $this->auth->acl_get('m_qte_attr_del', $forum_id);
400 400
 
401 401
 		if (!$can_edit && $attribute_id != self::REMOVE || !$can_remove && $attribute_id == self::REMOVE)
402 402
 		{
@@ -470,8 +470,8 @@  discard block
 block discarded – undo
470 470
 	*/
471 471
 	public function mcp_attr_apply($attribute_id = 0, $forum_id = 0, $topic_ids = array())
472 472
 	{
473
-		$can_edit		= $this->auth->acl_get('m_qte_attr_edit', $forum_id);
474
-		$can_remove		= $this->auth->acl_get('m_qte_attr_del', $forum_id);
473
+		$can_edit = $this->auth->acl_get('m_qte_attr_edit', $forum_id);
474
+		$can_remove = $this->auth->acl_get('m_qte_attr_del', $forum_id);
475 475
 
476 476
 		if (!$can_edit && $attribute_id != self::REMOVE || !$can_remove && $attribute_id == self::REMOVE)
477 477
 		{
@@ -582,7 +582,7 @@  discard block
 block discarded – undo
582 582
 			$a_class_name = preg_replace('#[^a-z0-9 _-]#', '', strtolower($a_name));
583 583
 		}
584 584
 
585
-		return ' class="qte-attr ' . (isset($a_class_name) ?  $a_class_name : '') . '"' . (!empty($a_colour) ? ' style="color:#' . $a_colour . '; font-weight:bold;"' : '');
585
+		return ' class="qte-attr ' . (isset($a_class_name) ? $a_class_name : '') . '"' . (!empty($a_colour) ? ' style="color:#' . $a_colour . '; font-weight:bold;"' : '');
586 586
 	}
587 587
 
588 588
 	/**
Please login to merge, or discard this patch.
event/acp_listener.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -36,11 +36,11 @@  discard block
 block discarded – undo
36 36
 
37 37
 	public function __construct(\phpbb\request\request $request, \phpbb\cache\driver\driver_interface $cache, \phpbb\db\driver\driver_interface $db, \phpbb\user $user, \ernadoo\qte\qte $qte, $table_prefix)
38 38
 	{
39
-		$this->request	= $request;
39
+		$this->request = $request;
40 40
 		$this->cache	= $cache;
41
-		$this->db		= $db;
41
+		$this->db = $db;
42 42
 		$this->user		= $user;
43
-		$this->qte		= $qte;
43
+		$this->qte = $qte;
44 44
 
45 45
 		$this->table_prefix = $table_prefix;
46 46
 	}
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 	{
66 66
 		$categories				= $event['categories'];
67 67
 		$categories				= array_merge($categories, array('qte' => 'ACL_CAT_QTE'));
68
-		$event['categories']	= $categories;
68
+		$event['categories'] = $categories;
69 69
 
70 70
 		$permissions = $event['permissions'];
71 71
 
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 		foreach ($this->qte->getAttr() as $attr)
79 79
 		{
80 80
 			$permissions += array(
81
-				'f_qte_attr_'.$attr['attr_id'] => array('lang' => $this->user->lang('QTE_CAN_USE_ATTR', $attr['attr_name']), 'cat' => 'qte'),
81
+				'f_qte_attr_' . $attr['attr_id'] => array('lang' => $this->user->lang('QTE_CAN_USE_ATTR', $attr['attr_name']), 'cat' => 'qte'),
82 82
 			);
83 83
 		}
84 84
 		$event['permissions'] = $permissions;
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 		$dest_forum_ids = array();
226 226
 		while ($row = $this->db->sql_fetchrow($result))
227 227
 		{
228
-			$dest_forum_ids[]	= (int) $row['forum_id'];
228
+			$dest_forum_ids[] = (int) $row['forum_id'];
229 229
 		}
230 230
 		$this->db->sql_freeresult($result);
231 231
 
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
 		$acl_options_ids = array();
244 244
 		while ($row = $this->db->sql_fetchrow($result))
245 245
 		{
246
-			$acl_options_ids[]	= (int) $row['auth_option_id'];
246
+			$acl_options_ids[] = (int) $row['auth_option_id'];
247 247
 		}
248 248
 
249 249
 		// From the mysql documentation:
Please login to merge, or discard this patch.
acp/main_module.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -27,18 +27,18 @@  discard block
 block discarded – undo
27 27
 	{
28 28
 		global $phpbb_container, $db, $user, $phpbb_log, $template, $cache, $request, $table_prefix;
29 29
 
30
-		$this->qte						= $phpbb_container->get('ernadoo.qte');
31
-		$this->migrator_tool_permission	= $phpbb_container->get('migrator.tool.permission');
30
+		$this->qte = $phpbb_container->get('ernadoo.qte');
31
+		$this->migrator_tool_permission = $phpbb_container->get('migrator.tool.permission');
32 32
 
33 33
 		$action			= $request->variable('action', '');
34 34
 		$submit			= $request->is_set_post('submit');
35 35
 		$attr_id		= $request->variable('id', 0);
36
-		$attr_auth_id	= $request->variable('attr_auth_id', 0);
36
+		$attr_auth_id = $request->variable('attr_auth_id', 0);
37 37
 
38 38
 		$error = array();
39 39
 		$clear_dest_perms = false;
40 40
 
41
-		$this->tpl_name		= 'acp_attributes';
41
+		$this->tpl_name = 'acp_attributes';
42 42
 		$this->page_title	= 'QTE_MANAGE_TITLE';
43 43
 
44 44
 		$user->add_lang_ext('ernadoo/qte', array('attributes', 'attributes_acp'));
@@ -156,14 +156,14 @@  discard block
 block discarded – undo
156 156
 							$db->sql_query($sql);
157 157
 							$attr_id = $db->sql_nextid();
158 158
 
159
-							$this->migrator_tool_permission->add('f_qte_attr_'.$attr_id, false);
159
+							$this->migrator_tool_permission->add('f_qte_attr_' . $attr_id, false);
160 160
 
161 161
 							$message = 'ADDED';
162 162
 						}
163 163
 
164 164
 						if ($attr_auth_id)
165 165
 						{
166
-							$this->_copy_permission('f_qte_attr_'.$attr_id, 'f_qte_attr_'.$attr_auth_id, $clear_dest_perms);
166
+							$this->_copy_permission('f_qte_attr_' . $attr_id, 'f_qte_attr_' . $attr_auth_id, $clear_dest_perms);
167 167
 						}
168 168
 
169 169
 						$cache->destroy('_attr');
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 
272 272
 					$phpbb_log->add('admin', $user->data['user_id'], $user->ip, 'LOG_ATTRIBUTE_REMOVED', time(), array($attr_name));
273 273
 
274
-					$this->migrator_tool_permission->remove('f_qte_attr_'.$attr_id, false);
274
+					$this->migrator_tool_permission->remove('f_qte_attr_' . $attr_id, false);
275 275
 
276 276
 					$sql = 'DELETE FROM ' . $table_prefix . 'topics_attr
277 277
 						WHERE attr_id = ' . (int) $attr_id;
Please login to merge, or discard this patch.