acp_directory::update_cat_data() - Code Metrics - ErnadoO/mod-phpbb-directory - Measure and Improve Code Quality continuously with Scrutinizer

acp_directory::update_cat_data() F
last analyzed 2016-07-09 11:20 UTC

↳ Parent: acp_directory
Complexity

Conditions	20
Paths	1288
Size

Total Lines	149
Code Lines	71
Duplication

Lines	4
Ratio	2.68 %
Importance

Changes	2
Bugs	0	Features	0
Metric	Value
cc	20
eloc	71
c	2
b	0
f	0
nc	1288
nop	1
dl	4
loc	149
rs	2
How to fix Long Method Complexity

<?php

/**
*
* @author Erwan NADER (ErnadoO) [email protected]
* @package acp
* @version $Id$
* @copyright (c) 2008 http://www.phpbb-services.com
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/

/**
 * @ignore
 */
if (!defined('IN_PHPBB'))
{
	exit;
}

/**
* @package acp
*/
class acp_directory
namespace YourVendor;

class YourClass { }
{
	var $u_action;
	var $new_config;
	var $parent_id = 0;

	function main($id, $mode)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		global $db, $user, $auth, $template, $cache, $phpbb_seo;
		global $config, $phpbb_root_path, $phpbb_admin_path, $phpEx;

		$action		= request_var('action', '');
		$start		= request_var('start', 0);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$submit		= (isset($_POST['submit'])) ? true : false;
		$update		= (isset($_POST['update'])) ? true : false;
		$cat_id		= request_var('c', 0);
		$link_id	= request_var('u', 0);

		$form_key = 'acp_dir_cat';
		add_form_key($form_key);

		$this->parent_id	= request_var('parent_id', 0);
		$cat_data = $errors = array();
		if ($update && !check_form_key($form_key))
		{
			$update = false;
			$errors[] = $user->lang['FORM_INVALID'];
		}

		switch($mode)
		{
			case 'main':
				$this->page_title = 'ACP_DIRECTORY';
class MyClass { }

$x = new MyClass();
$x->foo = true;
				$this->tpl_name = 'acp_dir_main';
class MyClass { }

$x = new MyClass();
$x->foo = true;
				$user->add_lang('install');

				if ($action)
				{
					if (!confirm_box(true))
					{
						switch ($action)
						{
							case 'votes':
								$confirm = true;
								$confirm_lang = 'DIR_RESET_VOTES_CONFIRM';
							break;

							case 'comments':
								$confirm = true;
								$confirm_lang = 'DIR_RESET_COMMENTS_CONFIRM';
							break;

							case 'clicks':
								$confirm = true;
								$confirm_lang = 'DIR_RESET_CLICKS_CONFIRM';
							break;

							case 'orphans':
								$confirm = true;
								$confirm_lang = 'DIR_DELETE_ORPHANS';
								break;

							default:
								$confirm = true;
								$confirm_lang = 'CONFIRM_OPERATION';
						}

						if ($confirm)
						{
							confirm_box(false, $user->lang[$confirm_lang], build_hidden_fields(array(
								'i'			=> $id,
								'mode'		=> $mode,
								'action'	=> $action,
							)));
						}
					}
					else
					{
						switch ($action)
						{
							case 'votes':

								switch ($db->sql_layer)
								{
									case 'sqlite':
									case 'firebird':
										$db->sql_query('DELETE FROM ' . DIR_VOTE_TABLE);
									break;

									default:
										$db->sql_query('TRUNCATE TABLE ' . DIR_VOTE_TABLE);
									break;
								}

								$sql = 'UPDATE ' . DIR_LINK_TABLE . ' SET
									link_vote = 0,
									link_note = 0';
								$db->sql_query($sql);
							break;

							case 'comments':

								switch ($db->sql_layer)
								{
									case 'sqlite':
									case 'firebird':
										$db->sql_query('DELETE FROM ' . DIR_COMMENT_TABLE);
									break;

									default:
										$db->sql_query('TRUNCATE TABLE ' . DIR_COMMENT_TABLE);
									break;
								}

								$sql = 'UPDATE ' . DIR_LINK_TABLE . ' SET
									link_comment = 0';
								$db->sql_query($sql);
							break;

							case 'clicks':
								$sql = 'UPDATE ' . DIR_LINK_TABLE . ' SET
									link_view = 0';
								$db->sql_query($sql);
							break;

							case 'orphans':
								orphan_files(true);
							break;
						}
					}
				}

				// Get current and latest version
				$errstr = '';
				$errno = 0;

				$info = get_remote_file('www.phpbb-services.com', '/updatecheck', 'annuaire.txt', $errstr, $errno);

				if ($info === false)
				{
					trigger_error('VERSIONCHECK_FAIL', E_USER_WARNING);
				}

				$info = explode("\n", $info);
				$latest_version = trim($info[0]);
				$announce = trim($info[1]);
				$announce = (strpos($announce, '&amp;') === false) ? str_replace('&', '&amp;', $announce) : $announce;
				$download_link = trim($info[2]);
				$download_link = (strpos($download_link, '&amp;') === false) ? str_replace('&', '&amp;', $download_link) : $download_link;

				$up_to_date = (version_compare(str_replace('rc', 'RC', strtolower($config['dir_version'])), str_replace('rc', 'RC', strtolower($latest_version)), '<')) ? false : true;

				// Count number of categories
				$sql = 'SELECT COUNT(cat_id) AS nb_cats
					FROM ' . DIR_CAT_TABLE;
				$result = $db->sql_query($sql);
				$total_cats = (int) $db->sql_fetchfield('nb_cats');
				$db->sql_freeresult($result);

				// Cont number of links
				$sql = 'SELECT link_id, link_active
					FROM ' . DIR_LINK_TABLE;
				$result = $db->sql_query($sql);
				$total_links = $waiting_links = 0;
				while($row = $db->sql_fetchrow($result))
				{
					$total_links++;
					if (!$row['link_active'])
					{
						$waiting_links++;
					}
				}
				$db->sql_freeresult($result);

				// Comments number calculating
				$sql = 'SELECT COUNT(comment_id) AS nb_comments
					FROM ' . DIR_COMMENT_TABLE;
				$result = $db->sql_query($sql);
				$total_comments = (int) $db->sql_fetchfield('nb_comments');
				$db->sql_freeresult($result);

				// Votes number calculating
				$sql = 'SELECT COUNT(vote_id) AS nb_votes
					FROM ' . DIR_VOTE_TABLE;
				$result = $db->sql_query($sql);
				$total_votes = (int) $db->sql_fetchfield('nb_votes');
				$db->sql_freeresult($result);

				// Click number calculating
				$sql = 'SELECT SUM(link_view) AS nb_clicks
					FROM ' . DIR_LINK_TABLE;
				$result = $db->sql_query($sql);
				$total_clicks = (int) $db->sql_fetchfield('nb_clicks');
				$db->sql_freeresult($result);

				$banners_dir_size = 0;

				if ($banners_dir = @opendir($phpbb_root_path . 'images/directory/banners/'))
				{
					while (($file = readdir($banners_dir)) !== false)
					{
						if ($file[0] != '.' && $file[0] != '..' && strpos($file, 'index.') === false && strpos($file, '.db') === false)
						{
							$banners_dir_size += filesize($phpbb_root_path . 'images/directory/banners/' . $file);
						}
					}
					closedir($banners_dir);

					$banners_dir_size = get_formatted_filesize($banners_dir_size);
				}
				else
				{
					// Couldn't open banners dir.
					$banners_dir_size = $user->lang['NOT_AVAILABLE'];
				}

				$total_orphan = orphan_files();

				$template->assign_vars(array(
					'S_UP_TO_DATE'		=> $up_to_date,
					'S_VERSION_CHECK'	=> true,
					'U_ACTION'			=> $this->u_action,

					'LATEST_VERSION'	=> $latest_version,
					'CURRENT_VERSION'	=> $config['dir_version'],
					'U_ANNOUNCE'		=> $announce,
					'U_DOWNLOAD'		=> $download_link,

					'TOTAL_CATS'		=> $total_cats,
					'TOTAL_LINKS'		=> $total_links-$waiting_links,
					'WAITING_LINKS'		=> $waiting_links,
					'TOTAL_COMMENTS'	=> $total_comments,
					'TOTAL_VOTES'		=> $total_votes,
					'TOTAL_CLICKS'		=> $total_clicks,
					'TOTAL_ORPHANS'		=> $total_orphan,
					'BANNERS_DIR_SIZE'	=> $banners_dir_size,
				));
				break;

			case 'settings':
				$display_vars = array(
					'title'	=> 'ACP_DIRECTORY_SETTINGS',
					'vars'	=> array(
						'legend1' => 'DIR_PARAM',

						'dir_banner_width'					=> '',
						'dir_banner_height'					=> '',

						'dir_mail'							=> array('lang' => 'DIR_MAIL_VALIDATION',	'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => false),
						'dir_activ_checkurl'				=> array('lang' => 'DIR_ACTIVE_CHECK',		'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
						'dir_activ_flag'					=> array('lang' => 'DIR_ACTIV_FLAG',		'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => false),
						'dir_activ_rss'						=> array('lang' => 'DIR_ACTIV_RSS',			'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
						'dir_activ_pagerank'				=> array('lang' => 'DIR_ACTIV_PAGERANK',	'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
						'dir_show'							=> array('lang' => 'DIR_SHOW',				'validate' => 'int:1', 	'type' => 'text:3:3',		'explain' => false),
						'dir_length_describe'				=> array('lang' => 'DIR_MAX_DESC',			'validate' => 'int:1', 	'type' => 'text:3:3',		'explain' => false),
						'dir_new_time'						=> array('lang' => 'DIR_NEW_TIME',			'validate' => 'int', 	'type' => 'text:3:3',		'explain' => true),
						'dir_default_order'					=> array('lang' => 'DIR_DEFAULT_ORDER',		'validate' => 'string', 'type' => 'select',			'explain' => true, 'method' => 'get_order_list', 'params' => array('{CONFIG_VALUE}')),

						'legend2'							=> 'DIR_RECENT_GUEST',
						'dir_recent_block'					=> array('lang' => 'DIR_RECENT_ENABLE',		'validate' => 'bool',		'type' => 'radio:yes_no',	'explain' => true),
						'dir_recent_rows'					=> array('lang' => 'DIR_RECENT_ROWS',		'validate' => 'int:1',		'type' => 'text:3:3',		'explain' => false),
						'dir_recent_columns'				=> array('lang' => 'DIR_RECENT_COLUMNS',	'validate' => 'int:1',		'type' => 'text:3:3',		'explain' => false),
						'dir_recent_exclude'				=> array('lang' => 'DIR_RECENT_EXCLUDE',	'validate' => 'string',		'type' => 'text:6:99',			'explain' => true),

						'legend3'							=> 'DIR_ADD_GUEST',
						'dir_visual_confirm'				=> array('lang' => 'DIR_VISUAL_CONFIRM',	'validate' => 'bool',		'type' => 'radio:yes_no',	'explain' => true),
						'dir_visual_confirm_max_attempts'	=> array('lang' => 'DIR_MAX_ADD_ATTEMPTS',	'validate' => 'int:1:10',	'type' => 'text:3:3',		'explain' => true),

						'legend4'							=> 'DIR_THUMB_PARAM',
						'dir_activ_thumb'					=> array('lang' => 'DIR_ACTIVE_THUMB',			'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => false),
						'dir_activ_thumb_remote'			=> array('lang' => 'DIR_ACTIVE_THUMB_REMOTE',	'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
						'dir_thumb_service'					=> array('lang' => 'DIR_THUMB_SERVICE',			'validate' => 'string', 'type' => 'select',			'explain' => true, 'method' => 'get_thumb_service_list', 'params' => array('{CONFIG_VALUE}')),
						'dir_thumb_service_reverse'			=> array('lang' => 'DIR_THUMB_SERVICE_REVERSE',	'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),

						'legend5'							=> 'DIR_COMM_PARAM',
						'dir_allow_bbcode'					=> array('lang' => 'DIR_ALLOW_BBCODE',		'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => false),
						'dir_allow_links'					=> array('lang' => 'DIR_ALLOW_LINKS',		'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => false),
						'dir_allow_smilies'					=> array('lang' => 'DIR_ALLOW_SMILIES',		'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => false),
						'dir_length_comments'				=> array('lang' => 'DIR_LENGTH_COMMENTS',	'validate' => 'int:2',	'type' => 'text:3:3',		'explain' => true),
						'dir_comments_per_page'				=> array('lang' => 'DIR_COMM_PER_PAGE',		'validate' => 'int:1',	'type' => 'text:3:3',		'explain' => false),

						'legend6'							=> 'DIR_BANN_PARAM',
						'dir_activ_banner'					=> array('lang' => 'DIR_ACTIV_BANNER',		'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => false),
						'dir_banner'						=> array('lang' => 'DIR_MAX_BANN',			'validate' => 'int',	'type' => 'dimension:3:4',	'explain' => true, 'append' => ' ' . $user->lang['PIXEL']),
						'dir_banner_filesize'				=> array('lang' => 'DIR_MAX_SIZE',			'validate' => 'int:0',	'type' => 'text:5:10',		'explain' => true, 'append' => ' ' . $user->lang['BYTES']),
						'dir_storage_banner'				=> array('lang' => 'DIR_STORAGE_BANNER',	'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
					)
				);

				// phpbb_seo installed
				if (!empty($phpbb_seo))
				{
					// Rewrite enable, and patch installed
					if($phpbb_seo->cache_config['settings']['url_rewrite'] && method_exists($phpbb_seo,'directory'))
					{
						$display_vars['vars'] += array(
							'legend7'					=> 'DIR_REWRITE_PARAM',
							'dir_activ_rewrite'			=> array('lang' => 'DIR_ACTIV_REWRITE',	'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
							//'dir_urlR'						=> array('lang' => 'DIR_RELATIVE_PATH',	'validate' => 'string',	'type' => 'text:10:99',		'explain' => true, 'append' => '/'),

						);
					}
				}
				$display_vars['vars'] += array(
					'legend8'					=> 'ACP_SUBMIT_CHANGES',
				);


				if (isset($display_vars['lang']))
				{
					$user->add_lang($display_vars['lang']);
				}

				$this->new_config = $config;
				$cfg_array = (isset($_REQUEST['config'])) ? utf8_normalize_nfc(request_var('config', array('' => ''), true)) : $this->new_config;
				$error = array();

				// We validate the complete config if whished
				validate_config_vars($display_vars['vars'], $cfg_array, $error);

				// Do not write values if there is an error
				if (sizeof($error))
				{
					$submit = false;
				}

				// We go through the display_vars to make sure no one is trying to set variables he/she is not allowed to...
				foreach ($display_vars['vars'] as $config_name => $null)
				{

					if (!isset($cfg_array[$config_name]) || strpos($config_name, 'legend') !== false)
					{
						continue;
					}

					$this->new_config[$config_name] = $config_value = $cfg_array[$config_name];

					if ($submit)
					{
						set_config($config_name, $config_value);
					}
				}

				if ($submit)

				{
					add_log('admin', 'DIR_CONFIG_' . strtoupper($mode));

					trigger_error($user->lang['CONFIG_UPDATED'] . adm_back_link($this->u_action));
				}

				$this->tpl_name = 'acp_board';
				$this->page_title = $display_vars['title'];

				$template->assign_vars(array(
					'L_TITLE'			=> $user->lang[$display_vars['title']],
					'L_TITLE_EXPLAIN'	=> $user->lang[$display_vars['title'] . '_EXPLAIN'],

					'S_ERROR'			=> (sizeof($error)) ? true : false,
					'ERROR_MSG'			=> implode('<br />', $error),

 					'U_ACTION'			=> $this->u_action)
				);

				// Output relevant page
				foreach ($display_vars['vars'] as $config_key => $vars)
				{
					if (!is_array($vars) && strpos($config_key, 'legend') === false)
					{
						continue;
					}

					if (strpos($config_key, 'legend') !== false)
					{
						$template->assign_block_vars('options', array(
							'S_LEGEND'	=> true,
							'LEGEND'	=> (isset($user->lang[$vars])) ? $user->lang[$vars] : $vars)
						);

						continue;
					}

					$type = explode(':', $vars['type']);

					$l_explain = '';
					if ($vars['explain'] && isset($vars['lang_explain']))
					{
						$l_explain = (isset($user->lang[$vars['lang_explain']])) ? $user->lang[$vars['lang_explain']] : $vars['lang_explain'];
					}
					else if ($vars['explain'])
					{
						$l_explain = (isset($user->lang[$vars['lang'] . '_EXPLAIN'])) ? $user->lang[$vars['lang'] . '_EXPLAIN'] : '';
					}

					$template->assign_block_vars('options', array(
						'KEY'			=> $config_key,
						'TITLE'			=> (isset($user->lang[$vars['lang']])) ? $user->lang[$vars['lang']] : $vars['lang'],
						'S_EXPLAIN'		=> $vars['explain'],
						'TITLE_EXPLAIN'	=> $l_explain,
						'CONTENT'		=> build_cfg_template($type, $config_key, $this->new_config, $config_key, $vars),
					));

					unset($display_vars['vars'][$config_key]);
				}

			break;

			case 'cat':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				// Major routines
				if ($update)
				{
					switch ($action)
					{
						case 'delete':
							$action_subcats		= request_var('action_subcats', '');
							$subcats_to_id		= request_var('subcats_to_id', 0);
							$action_links		= request_var('action_links', '');
							$links_to_id		= request_var('links_to_id', 0);

							$errors = $this->delete_cat($cat_id, $action_links, $action_subcats, $links_to_id, $subcats_to_id);

							if (sizeof($errors))
							{
								break;
							}

							$cache->destroy('sql', DIR_CAT_TABLE);

							trigger_error($user->lang['DIR_CAT_DELETED'] . adm_back_link($this->u_action . '&amp;parent_id=' . $this->parent_id));

						break;

						case 'edit':
							$cat_data = array(
								'cat_id'		=>	$cat_id
							);
						// No break here
						case 'add':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

							$cat_data += array(
								'parent_id'				=> request_var('cat_parent_id', (int)$this->parent_id),
								'cat_parents'			=> '',
								'cat_name'				=> utf8_normalize_nfc(request_var('cat_name', '', true)),
								'cat_desc'				=> utf8_normalize_nfc(request_var('cat_desc', '', true)),
								'cat_desc_uid'			=> '',
								'cat_desc_options'		=> 7,
								'cat_desc_bitfield'		=> '',
								'cat_icon'				=> request_var('cat_icon', ''),
								'display_subcat_list'	=> request_var('display_on_index', false),
								'cat_allow_comments'	=> request_var('allow_comments', 1),
								'cat_allow_votes'		=> request_var('allow_votes', 1),
								'cat_must_describe'		=> request_var('must_describe', 1),
								'cat_count_all'			=> request_var('count_all', 0),
								'cat_validate'			=> request_var('validate', 0),
								'cat_link_back'			=> request_var('link_back', 0),
								'cat_cron_enable'		=> request_var('cron_enable', 0),
								'cat_cron_freq'			=> request_var('cron_every', 7),
								//'cat_cron_next'		=> request_var('cat_cron_next', time()+604800),

								'cat_cron_nb_check'		=> request_var('nb_check', 1),
							);

							// Get data for cat description if specified
							if ($cat_data['cat_desc'])
							{
								generate_text_for_storage($cat_data['cat_desc'], $cat_data['cat_desc_uid'], $cat_data['cat_desc_bitfield'], $cat_data['cat_desc_options'], request_var('desc_parse_bbcode', false), request_var('desc_parse_urls', false), request_var('desc_parse_smilies', false));
							}

							$errors = $this->update_cat_data($cat_data);

							if (!sizeof($errors))
							{
								$cache->destroy('sql', DIR_CAT_TABLE);

								$message = ($action == 'add') ? $user->lang['DIR_CAT_CREATED'] : $user->lang['DIR_CAT_UPDATED'];

								trigger_error($message . adm_back_link($this->u_action . '&amp;parent_id=' . $this->parent_id));
							}
						break;
					}
				}
				$this->page_title = 'ACP_DIRECTORY';
				$this->tpl_name = 'acp_dir_cat';

				switch ($action)
				{
					case 'progress_bar':
						$start = request_var('start', 0);
						$total = request_var('total', 0);

						$this->display_progress_bar($start, $total);
					break;

					case 'sync':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

						if (!$cat_id)

						{
							trigger_error($user->lang['DIR_NO_CAT'] . adm_back_link($this->u_action . '&amp;parent_id=' . $this->parent_id), E_USER_WARNING);
						}

						@set_time_limit(0);

						$sql = 'SELECT cat_name, cat_links
							FROM ' . DIR_CAT_TABLE . '
							WHERE cat_id = ' . (int)$cat_id;
						$result = $db->sql_query($sql);
						$row = $db->sql_fetchrow($result);
						$db->sql_freeresult($result);

						if (!$row)

						{
							trigger_error($user->lang['DIR_NO_CAT'] . adm_back_link($this->u_action . '&amp;parent_id=' . $this->parent_id), E_USER_WARNING);
						}

						if ($row['cat_links'])
						{
							$sql = 'SELECT MIN(link_id) as min_link_id, MAX(link_id) as max_link_id
								FROM ' . DIR_LINK_TABLE . '
								WHERE link_cat = ' . (int)$cat_id . '
									AND link_active = 1';
							$result = $db->sql_query($sql);
							$row2 = $db->sql_fetchrow($result);
							$db->sql_freeresult($result);

							// Typecast to int if there is no data available
							$row2['min_link_id'] = (int) $row2['min_link_id'];
							$row2['max_link_id'] = (int) $row2['max_link_id'];

							$start = request_var('start', $row2['min_link_id']);

							$batch_size = 200;
							$end = $start + $batch_size;

							// Sync all topics in batch mode...
							sync_dir_links($start, $end);

							if ($end < $row2['max_link_id'])
							{
								// We really need to find a way of showing statistics... no progress here
								$sql = 'SELECT COUNT(link_id) as num_links
									FROM ' . DIR_LINK_TABLE . '
									WHERE link_cat = ' . (int)$cat_id . '
										AND link_active = 1
										AND link_id BETWEEN ' . $start . ' AND ' . $end;
								$result = $db->sql_query($sql);
								$links_done = request_var('links_done', 0) + (int) $db->sql_fetchfield('num_links');
								$db->sql_freeresult($result);

								$start += $batch_size;

								$url = $this->u_action . "&amp;parent_id={$this->parent_id}&amp;c=$cat_id&amp;action=sync&amp;start=$start&amp;links_done=$links_done&amp;total={$row['cat_links']}";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

								meta_refresh(0, $url);

								$template->assign_vars(array(
									'U_PROGRESS_BAR'		=> $this->u_action . "&amp;action=progress_bar&amp;start=$links_done&amp;total={$row['cat_links']}",
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
									'UA_PROGRESS_BAR'		=> addslashes($this->u_action . "&amp;action=progress_bar&amp;start=$links_done&amp;total={$row['cat_links']}"),
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
									'S_CONTINUE_SYNC'		=> true,
									'L_PROGRESS_EXPLAIN'	=> sprintf($user->lang['SYNC_IN_PROGRESS_EXPLAIN'], $links_done, $row['cat_links']))
								);

								return;
							}
						}

						$url = $this->u_action . "&amp;parent_id={$this->parent_id}&amp;c=$cat_id&amp;action=sync_cat";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
						meta_refresh(0, $url);

						$template->assign_vars(array(
							'U_PROGRESS_BAR'		=> $this->u_action . '&amp;action=progress_bar',
							'UA_PROGRESS_BAR'		=> addslashes($this->u_action . '&amp;action=progress_bar'),
							'S_CONTINUE_SYNC'		=> true,
							'L_PROGRESS_EXPLAIN'	=> sprintf($user->lang['SYNC_IN_PROGRESS_EXPLAIN'], 0, $row['cat_links']))
						);

						return;
					break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

					case 'sync_cat':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

						$sql = 'SELECT cat_name
							FROM ' . DIR_CAT_TABLE . '
							WHERE cat_id = ' . (int)$cat_id;
						$result = $db->sql_query($sql);
						$row = $db->sql_fetchrow($result);
						$db->sql_freeresult($result);

						if (!$row)

						{
							trigger_error($user->lang['DIR_NO_CAT'] . adm_back_link($this->u_action . '&amp;parent_id=' . $this->parent_id), E_USER_WARNING);
						}

						sync_dir_cat($cat_id);

						add_log('admin', 'LOG_DIR_CAT_SYNC', $row['cat_name']);
						$cache->destroy('sql', DIR_CAT_TABLE);

						$template->assign_var('L_DIR_CAT_RESYNCED', sprintf($user->lang['DIR_CAT_RESYNCED'], $row['cat_name']));

					break;

					case 'move_up':
					case 'move_down':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

						if (!$cat_id)

						{
							trigger_error($user->lang['DIR_NO_CAT'] . adm_back_link($this->u_action . '&amp;parent_id=' . $this->parent_id), E_USER_WARNING);
						}

						$sql = 'SELECT cat_id, cat_name, parent_id, left_id, right_id
							FROM ' . DIR_CAT_TABLE . '
							WHERE cat_id = ' . (int)$cat_id;
						$result = $db->sql_query($sql);
						$row = $db->sql_fetchrow($result);
						$db->sql_freeresult($result);

						if (!$row)

						{
							trigger_error($user->lang['DIR_NO_CAT'] . adm_back_link($this->u_action . '&amp;parent_id=' . $this->parent_id), E_USER_WARNING);
						}

						$move_cat_name = $this->move_cat_by($row, $action, 1);

						if ($move_cat_name !== false)
						{
							add_log('admin', 'LOG_DIR_CAT_' . strtoupper($action), $row['cat_name'], $move_cat_name);
							$cache->destroy('sql', DIR_CAT_TABLE);
						}

						break;

					case 'add':
					case 'edit':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

						// Show form to create/modify a categorie
						if ($action == 'edit')
						{
							$this->page_title = 'DIR_EDIT_CAT';
							$row = $this->get_cat_info($cat_id);

							if (!$update)
							{
								$cat_data = $row;
							}
							else
							{
								$cat_data['left_id'] = $row['left_id'];
								$cat_data['right_id'] = $row['right_id'];
							}

							// Make sure no direct child categories are able to be selected as parents.
							$exclude_cats = array();
							foreach (get_dir_cat_branch($cat_id, 'children') as $row2)
							{
								$exclude_cats[] = $row2['cat_id'];
							}
							$parents_list = make_cat_select($cat_data['parent_id'], $exclude_cats);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
						}
						else
						{
							$this->page_title = 'DIR_CREATE_CAT';

							$cat_id = $this->parent_id;
							$parents_list = make_cat_select($this->parent_id);

							// Fill categorie data with default values
							if (!$update)
							{
								$cat_data = array(
									'parent_id'				=> $this->parent_id,
									'cat_name'				=> utf8_normalize_nfc(request_var('cat_name', '', true)),
									'cat_desc'				=> '',
									'cat_icon'				=> '',
									'cat_allow_comments'	=> true,
									'cat_allow_votes'		=> true,
									'cat_must_describe'		=> true,
									'cat_count_all'			=> false,
									'cat_validate'			=> false,
									'enable_icons'			=> false,

									'display_subcat_list'	=> true,

									'cat_link_back'			=> false,
									'cat_cron_enable'		=> false,
									'cat_cron_freq'			=> 7,
									'cat_cron_nb_check'		=> 1,
								);
							}
						}

						$dir_cat_desc_data = array(
							'text'			=> $cat_data['cat_desc'],
							'allow_bbcode'	=> true,
							'allow_smilies'	=> true,
							'allow_urls'	=> true
						);

						// Parse desciption if specified
						if ($cat_data['cat_desc'])
						{
							if (!isset($cat_data['cat_desc_uid']))
							{
								// Before we are able to display the preview and plane text, we need to parse our request_var()'d value...
								$cat_data['cat_desc_uid'] = '';
								$cat_data['cat_desc_bitfield'] = '';
								$cat_data['cat_desc_options'] = 0;

								generate_text_for_storage($cat_data['cat_desc'], $cat_data['cat_desc_uid'], $cat_data['cat_desc_bitfield'], $cat_data['cat_desc_options'], request_var('desc_allow_bbcode', false), request_var('desc_allow_urls', false), request_var('desc_allow_smilies', false));
							}

							// decode...
							$dir_cat_desc_data = generate_text_for_edit($cat_data['cat_desc'], $cat_data['cat_desc_uid'], $cat_data['cat_desc_options']);
						}

						$sql = 'SELECT cat_id
							FROM ' . DIR_CAT_TABLE . '
							WHERE cat_id <> ' . (int)$cat_id;
						$result = $db->sql_query_limit($sql, 1);

						if ($db->sql_fetchrow($result))
						{
							$template->assign_vars(array(
								'S_MOVE_DIR_CAT_OPTIONS'	=> make_cat_select($cat_data['parent_id'], $cat_id))
							);
						}
						$db->sql_freeresult($result);

						$template->assign_vars(array(
							'S_EDIT_CAT'		=> true,
							'S_ERROR'			=> (sizeof($errors)) ? true : false,
							'S_CAT_PARENT_ID'	=> $cat_data['parent_id'],
							'S_ADD_ACTION'		=> ($action == 'add') ? true : false,

							'U_BACK'			=> $this->u_action . '&amp;parent_id=' . $this->parent_id,
							'U_EDIT_ACTION'		=> $this->u_action . "&amp;parent_id={$this->parent_id}&amp;action=$action&amp;c=$cat_id",
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

							'L_TITLE'					=> $user->lang[$this->page_title],
							'ERROR_MSG'					=> (sizeof($errors)) ? implode('<br />', $errors) : '',
							'ICON_IMAGE'				=> ($cat_data['cat_icon']) ? $phpbb_root_path . 'images/directory/icons/' . $cat_data['cat_icon'] : $phpbb_admin_path . 'images/spacer.gif',

							'DIR_ICON_PATH'				=> $phpbb_root_path . 'images/directory/icons',
							'DIR_CAT_NAME'				=> $cat_data['cat_name'],
							'DIR_CAT_DESC'				=> $dir_cat_desc_data['text'],

							'S_DESC_BBCODE_CHECKED'		=> ($dir_cat_desc_data['allow_bbcode']) ? true : false,
							'S_DESC_SMILIES_CHECKED'	=> ($dir_cat_desc_data['allow_smilies']) ? true : false,
							'S_DESC_URLS_CHECKED'		=> ($dir_cat_desc_data['allow_urls']) ? true : false,
							'S_DISPLAY_SUBCAT_LIST'		=> ($cat_data['display_subcat_list']) ? true : false,
							'S_PARENT_OPTIONS'			=> $parents_list,
							'S_ICON_OPTIONS'			=> get_dir_icon_list($cat_data['cat_icon']),
							'S_ALLOW_COMMENTS'			=> ($cat_data['cat_allow_comments']) ? true : false,
							'S_ALLOW_VOTES'				=> ($cat_data['cat_allow_votes']) ? true : false,
							'S_MUST_DESCRIBE'			=> ($cat_data['cat_must_describe']) ? true : false,
							'S_COUNT_ALL'				=> ($cat_data['cat_count_all']) ? true : false,
							'S_VALIDATE'				=> ($cat_data['cat_validate']) ? true : false,

							'DIR_CRON_EVERY'			=> $cat_data['cat_cron_freq'],
							'DIR_NEXT_CRON_ACTION'		=> !empty($cat_data['cat_cron_next']) ? $user->format_date($cat_data['cat_cron_next']) : '-',
							'DIR_CRON_NB_CHECK'			=> $cat_data['cat_cron_nb_check'],

							'S_LINK_BACK'				=> ($cat_data['cat_link_back']) ? true : false,
							'S_CRON_ENABLE'				=> ($cat_data['cat_cron_enable']) ? true : false,

							// In acp, append_sid() always adds SID in url, so we can use "&" delimiter in the javascript function in template for timestamp parametre
							'U_DATE'					=> append_sid($phpbb_root_path.'directory.'.$phpEx)
						));

					return;

					case 'delete':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

						if (!$cat_id)

						{
							trigger_error($user->lang['DIR_NO_CAT'] . adm_back_link($this->u_action . '&amp;parent_id=' . $this->parent_id), E_USER_WARNING);
						}

						$cat_data = $this->get_cat_info($cat_id);

						$subcats_id = array();
						$subcats = get_dir_cat_branch($cat_id, 'children');

						foreach ($subcats as $row)
						{
							$subcats_id[] = $row['cat_id'];
						}

						$cat_list = make_cat_select($cat_data['parent_id'], $subcats_id);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

						$sql = 'SELECT cat_id
							FROM ' . DIR_CAT_TABLE . '
							WHERE cat_id <> ' . (int)$cat_id;
						$result = $db->sql_query_limit($sql, 1);

						if ($db->sql_fetchrow($result))
						{
							$template->assign_vars(array(
								'S_MOVE_DIR_CAT_OPTIONS'	=> make_cat_select($cat_data['parent_id'], $subcats_id)) // , false, true, false???
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
							);
						}
						$db->sql_freeresult($result);

						$parent_id = ($this->parent_id == $cat_id) ? 0 : $this->parent_id;

						$template->assign_vars(array(
							'S_DELETE_DIR_CAT'		=> true,
							'U_ACTION'				=> $this->u_action . "&amp;parent_id={$parent_id}&amp;action=delete&amp;c=$cat_id",
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
							'U_BACK'				=> $this->u_action . '&amp;parent_id=' . $this->parent_id,

							'DIR_CAT_NAME'			=> $cat_data['cat_name'],
							'S_HAS_SUBCATS'		=> ($cat_data['right_id'] - $cat_data['left_id'] > 1) ? true : false,
							'S_CATS_LIST'			=> $cat_list,
							'S_ERROR'				=> (sizeof($errors)) ? true : false,
							'ERROR_MSG'				=> (sizeof($errors)) ? implode('<br />', $errors) : '')
						);

						return;
					break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
				}

				// Default management page
				if (!$this->parent_id)
				{
					$navigation = $user->lang['DIR_INDEX'];
				}
				else
				{
					$navigation = '<a href="' . $this->u_action . '">' . $user->lang['DIR_INDEX'] . '</a>';

					$cats_nav = get_dir_cat_branch($this->parent_id, 'parents', 'descending');

					foreach ($cats_nav as $row)
					{
						if ($row['cat_id'] == $this->parent_id)
						{
							$navigation .= ' -&gt; ' . $row['cat_name'];
						}
						else
						{
							$navigation .= ' -&gt; <a href="' . $this->u_action . '&amp;parent_id=' . $row['cat_id'] . '">' . $row['cat_name'] . '</a>';
						}
					}
				}

				// Jumpbox
				$cat_box = make_cat_select($this->parent_id);

				if ($action == 'sync' || $action == 'sync_cat')
				{
					$template->assign_var('S_RESYNCED', true);
				}

				$sql = 'SELECT cat_id, parent_id, right_id, left_id, cat_name, cat_icon, cat_desc_uid, cat_desc_bitfield, cat_desc, cat_desc_options, cat_links
					FROM ' . DIR_CAT_TABLE . '
					WHERE parent_id = ' . (int)$this->parent_id . '
					ORDER BY left_id';
				$result = $db->sql_query($sql);

				if ($row = $db->sql_fetchrow($result))
				{
					do
					{
						$folder_image = ($row['left_id'] + 1 != $row['right_id']) ? '<img src="images/icon_subfolder.gif" alt="' . $user->lang['DIR_SUBCAT'] . '" />' : '<img src="images/icon_folder.gif" alt="' . $user->lang['FOLDER'] . '" />';

						$url = $this->u_action . "&amp;parent_id=$this->parent_id&amp;c={$row['cat_id']}";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

						$template->assign_block_vars('cats', array(
							'FOLDER_IMAGE'		=> $folder_image,
							'CAT_IMAGE'			=> ($row['cat_icon']) ? '<img src="' . $phpbb_root_path . 'images/directory/icons/' . $row['cat_icon'] . '" alt="" />' : '',
							'CAT_NAME'			=> $row['cat_name'],
							'CAT_DESCRIPTION'	=> generate_text_for_display($row['cat_desc'], $row['cat_desc_uid'], $row['cat_desc_bitfield'], $row['cat_desc_options']),
							'CAT_LINKS'			=> $row['cat_links'],

							'U_CAT'				=> $this->u_action . '&amp;parent_id=' . $row['cat_id'],
							'U_MOVE_UP'			=> $url . '&amp;action=move_up',
							'U_MOVE_DOWN'		=> $url . '&amp;action=move_down',
							'U_EDIT'			=> $url . '&amp;action=edit',
							'U_DELETE'			=> $url . '&amp;action=delete',
							'U_SYNC'			=> $url . '&amp;action=sync')
						);
					}
					while ($row = $db->sql_fetchrow($result));
				}
				else if ($this->parent_id)
				{
					$row = $this->get_cat_info($this->parent_id);

					$url = $this->u_action . '&amp;parent_id=' . $this->parent_id . '&amp;c=' . $row['cat_id'];

					$template->assign_vars(array(
						'S_NO_CATS'			=> true,

						'U_EDIT'			=> $url . '&amp;action=edit',
						'U_DELETE'			=> $url . '&amp;action=delete',
						'U_SYNC'			=> $url . '&amp;action=sync')
					);
				}
				$db->sql_freeresult($result);

				$template->assign_vars(array(
					'ERROR_MSG'		=> (sizeof($errors)) ? implode('<br />', $errors) : '',
					'NAVIGATION'	=> $navigation,
					'CAT_BOX'		=> $cat_box,
					'U_SEL_ACTION'	=> $this->u_action,
					'U_ACTION'		=> $this->u_action . '&amp;parent_id=' . $this->parent_id,

					'U_PROGRESS_BAR'	=> $this->u_action . '&amp;action=progress_bar',
					'UA_PROGRESS_BAR'	=> addslashes($this->u_action . '&amp;action=progress_bar'),
				));

			break;

			case 'val':
				$this->page_title = 'ACP_DIRECTORY';
				$this->tpl_name = 'acp_dir_val';

				$mark	= (isset($_POST['link_id'])) ? request_var('link_id', array(0)) : array();
				$start	= request_var('start', 0);
				$submit = isset($_POST['submit']);

				$form_key = 'acp_dir_val';
				add_form_key($form_key);
				$subscibed_cat = $loop = $affected_link = array();

				if (!class_exists('messenger'))
				{
					include($phpbb_root_path . 'includes/functions_messenger.' . $phpEx);
				}
				$messenger	= new messenger(false);

				if ($submit && sizeof($mark))
				{
					if ($action !== 'delete' && !check_form_key($form_key))

					{
						trigger_error($user->lang['FORM_INVALID'] . adm_back_link($this->u_action), E_USER_WARNING);
					}

					$sql_array = array(
						'SELECT'	=> 'a.link_id, a.link_name, a.link_url, a.link_description, a.link_banner, a.link_user_id, a.link_guest_email, u.username, u.user_email, u.user_lang, u.user_notify_type, c.cat_name',
						'FROM'		=> array(
							DIR_LINK_TABLE	=> 'a'),
						'LEFT_JOIN'	=> array(
								array(
									'FROM'	=> array(USERS_TABLE => 'u'),
									'ON'	=> 'u.user_id = a.link_user_id'
								),
								array(
									'FROM'	=> array(DIR_CAT_TABLE => 'c'),
									'ON'	=> 'a.link_cat = c.cat_id'
								)
							),
						'WHERE'		=> $db->sql_in_set('a.link_id', $mark));

					$sql = $db->sql_build_query('SELECT', $sql_array);
					$result = $db->sql_query($sql);

					while ($row = $db->sql_fetchrow($result))
					{
						$link_data[$row['link_id']] = $row;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
						$affected_link[] = $row['link_name'];
						$row['link_cat'] = request_var('c'.$row['link_id'], 0);

						$cat_data[$row['link_cat']] = isset($cat_data[$row['link_cat']]) ? $cat_data[$row['link_cat']] + 1 : 1;

						if ($action == 'activate')
						{
							// We need to get back the suscribers
							if (!isset($subscibed_cat[$row['link_cat']]))
							{
								$sql_array = array(
									'SELECT'	=> 'u.user_id, u.username, u.user_email, u.user_lang, u.user_jabber, u.user_notify_type',
									'FROM'		=> array(
											DIR_NOTIFICATION_TABLE	=> 'an'),
									'LEFT_JOIN'	=> array(
										array(
											'FROM'	=> array(USERS_TABLE => 'u'),
											'ON'	=> 'an.n_user_id = u.user_id'
										)
									),
									'WHERE'		=> 'an.n_cat_id = ' . (int)$row['link_cat']);
								$sql = $db->sql_build_query('SELECT', $sql_array);
								$result2 = $db->sql_query($sql);

								while ($row2 = $db->sql_fetchrow($result2))
								{
										$subscibed_cat[$row['link_cat']][$row2['user_id']] = array(
											'username'		=> $row2['username'],
											'user_email'	=> $row2['user_email'],
											'user_lang'		=> $row2['user_lang'],
											'user_jabber'	=> $row2['user_jabber']
										);
								}
								$db->sql_freeresult($result2);
							}

							if(isset($subscibed_cat[$row['link_cat']]))
							{
								$messenger->replyto($config['board_email']);

								$cat_data2 = $subscibed_cat[$row['link_cat']];

								$messenger->headers('X-AntiAbuse: Board servername - ' . $config['server_name']);
								$messenger->headers('X-AntiAbuse: User_id - ' . $user->data['user_id']);
								$messenger->headers('X-AntiAbuse: Username - ' . $user->data['username']);

								foreach ($cat_data2 as $user_id => $user_data)
								{
									$messenger->template('mods/directory/notification', $user_data['user_lang']);
									$messenger->to($user_data['user_email'], $user_data['username']);
									$messenger->im($user_data['user_jabber'], $user_data['username']);

									$messenger->assign_vars(array(
										'USERNAME'			=> $user_data['username'],
										'CAT_NAME'			=> strip_tags($row['cat_name']),
										'LINK_NAME'			=> $row['link_name'],
										'LINK_URL'			=> $row['link_url'],
										'LINK_DESCRIPTION'	=> preg_replace('/(\[.*?\])(.*?)(\[\/.*?\])/si', '\\1', $row['link_description']),
									));

									$messenger->send($user_data['user_notify_type']);
								}

							}

							$sql = 'UPDATE ' . DIR_LINK_TABLE . ' SET link_active = 1, link_time = '. time() .', link_cat = '.request_var('c'.$row['link_id'], 0).'
								WHERE link_id = ' . (int)$row['link_id'];
							$db->sql_query($sql);
						}
						elseif($row['link_banner'] && !preg_match('/^(http:\/\/|https:\/\/|ftp:\/\/|ftps:\/\/|www\.).+/si', $row['link_banner']))

						{
							if (file_exists($phpbb_root_path . 'images/directory/banners' .'/'. basename($row['link_banner'])))
							{
								@unlink($phpbb_root_path . 'images/directory/banners' .'/'. basename($row['link_banner']));
							}
						}
					}
					$db->sql_freeresult($result);

					switch ($action)
					{
						case 'activate':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

							foreach ($cat_data as $cat_id => $count)
							{
								$sql = 'UPDATE ' . DIR_CAT_TABLE . ' SET cat_links = cat_links + '.$count.'
									WHERE cat_id = ' . (int)$cat_id;
								$db->sql_query($sql);
							}

							add_log('admin', 'LOG_LINK_ACTIVE', implode(', ', $affected_link));

						break;

						case 'delete':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

							if (confirm_box(true))
							{
								foreach ($mark as $link_id)
								{
									$sql = 'DELETE FROM ' . DIR_LINK_TABLE . ' WHERE link_id = ' . (int)$link_id;
									$db->sql_query($sql);
								}

								add_log('admin', 'LOG_LINK_DELETE', implode(', ', $affected_link));
							}
							else
							{
								$s_hidden_fields = array(
									'mode'			=> $mode,
									'action'		=> $action,
									'link_id'		=> $mark,
									'submit'		=> 1,
									'start'			=> $start,
								);
								confirm_box(false, $user->lang['CONFIRM_OPERATION'], build_hidden_fields($s_hidden_fields));
							}
						break;
					}

					$messenger->reset();

					$messenger->headers('X-AntiAbuse: Board servername - ' . $config['server_name']);
					$messenger->headers('X-AntiAbuse: User_id - ' . $user->data['user_id']);
					$messenger->headers('X-AntiAbuse: Username - ' . $user->data['username']);

					foreach ($link_data as $id => $row)
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
					{
						$username = ($row['link_user_id'] == ANONYMOUS) ? $row['link_guest_email'] : $row['username'];
						$email = ($row['link_user_id'] == ANONYMOUS) ? $row['link_guest_email'] : $row['user_email'];

						$messenger->template('mods/directory/user_validation', $row['user_lang']);
						$messenger->subject($user->lang['EMAIL_SUBJECT_' . strtoupper($action)]);
						$messenger->to($email, $username);

						$messenger->assign_vars(array(
							'USERNAME'	=> htmlspecialchars_decode($username),
							'TEXT'		=> sprintf($user->lang['EMAIL_TEXT_' . strtoupper($action)], $row['link_name'], htmlspecialchars_decode($config['sitename']), generate_board_url())
						));

						$messenger->send($row['user_notify_type']);
					}
				}

				$sql = 'SELECT COUNT(1) AS total_links
					FROM ' . DIR_LINK_TABLE . '
					WHERE link_active = 0';
				$result = $db->sql_query($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
				$total_links = (int) $db->sql_fetchfield('total_links');

				if ($start >= $total_links)
				{
					$start = ($start - 10 < 0) ? 0 : $start - 10;
				}

				$sql_array = array(
					'SELECT'	=> 'a.link_id, a.link_name, a.link_url, a.link_description, a.link_cat, a.link_user_id, a.link_uid, a.link_bitfield, a.link_flags, a.link_banner, a.link_time, c.cat_name, u.user_id, u.username, u.user_colour',
					'FROM'		=> array(
						DIR_LINK_TABLE	=> 'a'),
					'LEFT_JOIN'	=> array(
							array(
								'FROM'	=> array(DIR_CAT_TABLE => 'c'),
								'ON'	=> 'c.cat_id = a.link_cat'
							),
							array(
								'FROM'	=> array(USERS_TABLE => 'u'),
								'ON'	=> 'u.user_id = a.link_user_id'
							)
						),
					'WHERE'		=> 'a.link_active = 0',
					'ORDER_BY'	=> 'link_id ASC');

				$sql = $db->sql_build_query('SELECT', $sql_array);
				$result = $db->sql_query_limit($sql, 10, $start);

				$row = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
				while ($row = $db->sql_fetchrow($result))
				{
					$s_banner = '';
					if (!empty($row['link_banner']))
					{
						if (!preg_match('/^(http:\/\/|https:\/\/|ftp:\/\/|ftps:\/\/|www\.).+/si', $row['link_banner']))
						{
							$u_banner = $phpbb_root_path.'images/directory/banners/' . basename($row['link_banner']);
						}
						else
						{
							$u_banner = $row['link_banner'];
						}

						list($width, $height) = @getimagesize($u_banner);

						if (($width > $config['dir_banner_width'] || $height > $config['dir_banner_height']) && $config['dir_banner_width'] > 0 && $config['dir_banner_height'] > 0)

						{
							$coef_w = $width / $config['dir_banner_width'];
							$coef_h = $height / $config['dir_banner_height'];
							$coef_max = max($coef_w, $coef_h);
							$width /= $coef_max;
							$height /= $coef_max;
						}

						$s_banner = '<img src="' . $u_banner . '" width="' . $width . '" height="' . $height . '" border="0" alt="" />';
					}

					$username = ($row['link_user_id'] == ANONYMOUS) ? $row['link_guest_email'] : $row['username'];

					$link_row = array(
						'LINK_URL'			=> $row['link_url'],
						'LINK_NAME'			=> $row['link_name'],
						'LINK_DESC'			=> generate_text_for_display($row['link_description'], $row['link_uid'], $row['link_bitfield'], $row['link_flags']),
						'L_DIR_USER_PROP'	=> sprintf($user->lang['DIR_USER_PROP'], get_username_string('full', $row['link_user_id'], $username, $row['user_colour']), '<select name=c'.$row['link_id'].'>'.make_cat_select($row['link_cat']).'</select>', $user->format_date($row['link_time'])),
						'BANNER'			=> $s_banner,
						'LINK_ID'			=> $row['link_id'],

					);
					$template->assign_block_vars('linkrow', $link_row);
				}
				$db->sql_freeresult($result);

				$option_ary = array('activate' => 'DIR_LINK_ACTIVATE', 'delete' => 'DIR_LINK_DELETE');

				$template->assign_vars(array(
					'PAGINATION'			=> generate_pagination($this->u_action . "&amp;i=$id&amp;action=$action&amp;mode=$mode", $total_links, 10, $start),
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
					'PAGE_NUMBER'			=> on_page($total_links, 10, $start),
					'U_ACTION'				=> $this->u_action . '&amp;start=' . $start,
					'S_LINKS_OPTIONS'		=> build_select($option_ary),
				));

			break;
		}
	}

	function get_thumb_service_list($value)

	{
		$thumbshot = array(
			'apercite.fr'		=> 'http://www.apercite.fr/apercite/120x90/oui/oui/',
			'thumbshots.org'	=> 'http://open.thumbshots.org/image.pxf?url=',
			'easy-thumb.net'	=> 'http://www.easy-thumb.net/min.html?url=',
		);

		$tpl = '';
		foreach ($thumbshot as $service => $url)
		{
			$selected = ($url == $value) ? 'selected="selected"' : '';

			$tpl .= '<option value="' . $url . '" ' . $selected . '>' . $service . '</option>';
		}
		$tpl .= '</select>';

		return ($tpl);
	}

	function get_order_list($value)

	{
		global $user;

		$order_array = array(
			'a a',
			'a d',
			't a',
			't d',
			'r a',
			'r d',
			's a',
			's d',
			'v a',
			'v d'
		);
		$tpl = '';
		foreach ($order_array as $i)
		{
			$selected = ($i == $value) ? 'selected="selected"' : '';
			$order_substr = trim(str_replace(' ', '_', $i));
			$tpl .= '<option value="' . $i . '" ' . $selected . '>' . $user->lang['DIR_ORDER_' . strtoupper($order_substr)] . '</option>';
		}
		$tpl .= '</select>';

		return ($tpl);
	}

	function get_cat_info($dir_cat_id)

	{
		global $db;

		$sql = 'SELECT cat_id, parent_id, right_id, left_id, cat_desc, cat_desc_uid, cat_desc_options, cat_icon, cat_name, display_subcat_list, cat_allow_comments, cat_allow_votes, cat_must_describe, cat_count_all, cat_validate, cat_cron_freq, cat_cron_nb_check, cat_link_back, cat_cron_enable, cat_cron_next
			FROM ' . DIR_CAT_TABLE . '
			WHERE cat_id = ' . (int)$dir_cat_id;
		$result = $db->sql_query($sql);
		$row = $db->sql_fetchrow($result);
		$db->sql_freeresult($result);

		if (!$row)
		{
			trigger_error('DIR_ERROR_NO_CATS', E_USER_ERROR);
		}

		return $row;
	}

	function update_cat_data(&$cat_data)

	{
		global $db, $user, $cache;

		$errors = array();

		if (!$cat_data['cat_name'])
		{
			$errors[] = $user->lang['DIR_CAT_NAME_EMPTY'];
		}

		if (utf8_strlen($cat_data['cat_desc']) > 4000)
		{
			$errors[] = $user->lang['DIR_CAT_DESC_TOO_LONG'];
		}

		if (($cat_data['cat_cron_enable'] && $cat_data['cat_cron_freq'] <= 0) || $cat_data['cat_cron_nb_check'] < 0)
		{
			$errors[] = $user->lang['DIR_CAT_DATA_NEGATIVE'];
		}

		// Unset data that are not database fields
		$cat_data_sql = $cat_data;

		// What are we going to do tonight Brain? The same thing we do everynight,
		// try to take over the world ... or decide whether to continue update
		// and if so, whether it's a new cat/link or an existing one
		if (sizeof($errors))
		{
			return $errors;
		}

		if (!$cat_data_sql['cat_link_back'])
		{
			$cat_data_sql['cat_cron_enable'] = 0;
		}

		if(!$cat_data_sql['cat_cron_enable'])
		{
			$cat_data_sql['cat_cron_next'] = 0;
		}

		if (!$cat_data_sql['parent_id'])
		{
			$cat_data_sql['display_subcat_list'] = 0;
		}

		if (!isset($cat_data_sql['cat_id']))
		{
			// no cat_id means we're creating a new categorie
			if ($cat_data_sql['parent_id'])
			{
				$sql = 'SELECT left_id, right_id
					FROM ' . DIR_CAT_TABLE . '
					WHERE cat_id = ' . (int)$cat_data_sql['parent_id'];
				$result = $db->sql_query($sql);
				$row = $db->sql_fetchrow($result);
				$db->sql_freeresult($result);

				if (!$row)

				{
					trigger_error($user->lang['PARENT_NOT_EXIST'] . adm_back_link($this->u_action . '&amp;' . $this->parent_id), E_USER_WARNING);
				}

				$sql = 'UPDATE ' . DIR_CAT_TABLE . '
					SET left_id = left_id + 2, right_id = right_id + 2
					WHERE left_id > ' . (int)$row['right_id'];
				$db->sql_query($sql);

				$sql = 'UPDATE ' . DIR_CAT_TABLE . '
					SET right_id = right_id + 2
					WHERE ' . (int)$row['left_id'] . ' BETWEEN left_id AND right_id';
				$db->sql_query($sql);

				$cat_data_sql['left_id'] = $row['right_id'];
				$cat_data_sql['right_id'] = $row['right_id'] + 1;
			}
			else
			{
				$sql = 'SELECT MAX(right_id) AS right_id
					FROM ' . DIR_CAT_TABLE;
				$result = $db->sql_query($sql);
				$row = $db->sql_fetchrow($result);
				$db->sql_freeresult($result);

				$cat_data_sql['left_id'] = $row['right_id'] + 1;
				$cat_data_sql['right_id'] = $row['right_id'] + 2;
			}

			if ($cat_data_sql['cat_cron_enable'])
			{
				$cat_data_sql['cat_cron_next'] = time() + $cat_data_sql['cat_cron_freq']*86400;
			}

			$sql = 'INSERT INTO ' . DIR_CAT_TABLE . ' ' . $db->sql_build_array('INSERT', $cat_data_sql);
			$db->sql_query($sql);

			$cat_data['cat_id'] = $db->sql_nextid();

			add_log('admin', 'LOG_DIR_CAT_ADD', $cat_data['cat_name']);
		}
		else
		{

			$row = $this->get_cat_info($cat_data_sql['cat_id']);

			if ($row['parent_id'] != $cat_data_sql['parent_id'])
			{
				$errors = $this->move_cat($cat_data_sql['cat_id'], $cat_data_sql['parent_id']);
			}

			if (sizeof($errors))
			{
				return $errors;
			}

			if($cat_data_sql['cat_cron_enable'])
			{
				if($row['cat_cron_freq'] != $cat_data_sql['cat_cron_freq'] || !$row['cat_cron_enable'])
				{
					$cat_data_sql['cat_cron_next'] = time() + $cat_data_sql['cat_cron_freq']*86400;
				}
			}

			if ($row['cat_name'] != $cat_data_sql['cat_name'])
			{
				// the cat name has changed, clear the parents list of all categories (for safety)
				$sql = 'UPDATE ' . DIR_CAT_TABLE . "
					SET cat_parents = ''";
				$db->sql_query($sql);
			}

			// Setting the cat id to the categorie id is not really received well by some dbs. ;)
			$cat_id = $cat_data_sql['cat_id'];
			unset($cat_data_sql['cat_id']);

			$sql = 'UPDATE ' . DIR_CAT_TABLE . '
				SET ' . $db->sql_build_array('UPDATE', $cat_data_sql) . '
				WHERE cat_id = ' . (int)$cat_id;
			$db->sql_query($sql);

			// Add it back
			$cat_data['cat_id'] = $cat_id;

			add_log('admin', 'LOG_DIR_CAT_EDIT', $cat_data['cat_name']);
		}

		return $errors;
	}

	function move_cat($from_id, $to_id)

	{
		global $db, $user;

		$to_data = $moved_ids = $errors = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		$moved_cats = get_dir_cat_branch($from_id, 'children', 'descending');
		$from_data = $moved_cats[0];
		$diff = sizeof($moved_cats) * 2;

		$moved_ids = array();
		for ($i = 0; $i < sizeof($moved_cats); ++$i)
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
		{
			$moved_ids[] = $moved_cats[$i]['cat_id'];
		}

		// Resync parents
		$sql = 'UPDATE ' . DIR_CAT_TABLE . "
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
			SET right_id = right_id - $diff, cat_parents = ''
			WHERE left_id < " . (int)$from_data['right_id'] . "
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				AND right_id > " . (int)$from_data['right_id'];
		$db->sql_query($sql);

		// Resync righthand side of tree
		$sql = 'UPDATE ' . DIR_CAT_TABLE . "
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
			SET left_id = left_id - $diff, right_id = right_id - $diff, cat_parents = ''
			WHERE left_id > " . (int)$from_data['right_id'];
		$db->sql_query($sql);

		if ($to_id > 0)
		{
			// Retrieve $to_data again, it may have been changed...
			$to_data = $this->get_cat_info($to_id);

			// Resync new parents
			$sql = 'UPDATE ' . DIR_CAT_TABLE . "
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
				SET right_id = right_id + $diff, cat_parents = ''
				WHERE " . (int)$to_data['right_id'] . ' BETWEEN left_id AND right_id
					AND ' . $db->sql_in_set('cat_id', $moved_ids, true);
			$db->sql_query($sql);

			// Resync the righthand side of the tree
			$sql = 'UPDATE ' . DIR_CAT_TABLE . "
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
				SET left_id = left_id + $diff, right_id = right_id + $diff, cat_parents = ''
				WHERE left_id > " . (int)$to_data['right_id'] . '
					AND ' . $db->sql_in_set('cat_id', $moved_ids, true);
			$db->sql_query($sql);

			// Resync moved branch
			$to_data['right_id'] += $diff;

			if ($to_data['right_id'] > $from_data['right_id'])
			{
				$diff = '+ ' . ($to_data['right_id'] - $from_data['right_id'] - 1);
			}
			else
			{
				$diff = '- ' . abs($to_data['right_id'] - $from_data['right_id'] - 1);
			}
		}
		else
		{
			$sql = 'SELECT MAX(right_id) AS right_id
				FROM ' . DIR_CAT_TABLE . '
				WHERE ' . $db->sql_in_set('cat_id', $moved_ids, true);
			$result = $db->sql_query($sql);
			$row = $db->sql_fetchrow($result);
			$db->sql_freeresult($result);

			$diff = '+ ' . ($row['right_id'] - $from_data['left_id'] + 1);
		}

		$sql = 'UPDATE ' . DIR_CAT_TABLE . "
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
			SET left_id = left_id $diff, right_id = right_id $diff, cat_parents = ''
			WHERE " . $db->sql_in_set('cat_id', $moved_ids);
		$db->sql_query($sql);

		return $errors;
	}

	function display_progress_bar($start, $total)

	{
		global $template, $user;

		adm_page_header($user->lang['SYNC_IN_PROGRESS']);

		$template->set_filenames(array(
			'body'	=> 'progress_bar.html')
		);

		$template->assign_vars(array(
			'L_PROGRESS'			=> $user->lang['SYNC_IN_PROGRESS'],
			'L_PROGRESS_EXPLAIN'	=> ($start && $total) ? sprintf($user->lang['SYNC_IN_PROGRESS_EXPLAIN'], $start, $total) : $user->lang['SYNC_IN_PROGRESS'])
		);

		adm_page_footer();
	}

	function move_cat_by($dir_cat_row, $action = 'move_up', $steps = 1)

	{
		global $db;

		/**
		* Fetch all the siblings between the module's current spot
		* and where we want to move it to. If there are less than $steps
		* siblings between the current spot and the target then the
		* module will move as far as possible
		*/
		$sql = 'SELECT cat_id, cat_name, left_id, right_id
			FROM ' . DIR_CAT_TABLE . '
			WHERE parent_id = ' . (int)$dir_cat_row['parent_id'] . '
				AND ' . (($action == 'move_up') ? 'right_id < ' . (int)$dir_cat_row['right_id'] . ' ORDER BY right_id DESC' : 'left_id > ' . (int)$dir_cat_row['left_id'] . ' ORDER BY left_id ASC');
		$result = $db->sql_query_limit($sql, $steps);

		$target = array();
		while ($row = $db->sql_fetchrow($result))
		{
			$target = $row;
		}
		$db->sql_freeresult($result);

		if (!sizeof($target))
		{
			// The cat is already on top or bottom
			return false;
		}

		/**
		* $left_id and $right_id define the scope of the nodes that are affected by the move.
		* $diff_up and $diff_down are the values to substract or add to each node's left_id
		* and right_id in order to move them up or down.
		* $move_up_left and $move_up_right define the scope of the nodes that are moving
		* up. Other nodes in the scope of ($left_id, $right_id) are considered to move down.
		*/
		if ($action == 'move_up')
		{
			$left_id = $target['left_id'];
			$right_id = $dir_cat_row['right_id'];

			$diff_up = $dir_cat_row['left_id'] - $target['left_id'];
			$diff_down = $dir_cat_row['right_id'] + 1 - $dir_cat_row['left_id'];

			$move_up_left = $dir_cat_row['left_id'];
			$move_up_right = $dir_cat_row['right_id'];
		}
		else
		{
			$left_id = $dir_cat_row['left_id'];
			$right_id = $target['right_id'];

			$diff_up = $dir_cat_row['right_id'] + 1 - $dir_cat_row['left_id'];
			$diff_down = $target['right_id'] - $dir_cat_row['right_id'];

			$move_up_left = $dir_cat_row['right_id'] + 1;
			$move_up_right = $target['right_id'];
		}

		// Now do the dirty job
		$sql = 'UPDATE ' . DIR_CAT_TABLE . "
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
			SET left_id = left_id + CASE
				WHEN left_id BETWEEN {$move_up_left} AND {$move_up_right} THEN -{$diff_up}
				ELSE {$diff_down}
			END,
			right_id = right_id + CASE
				WHEN right_id BETWEEN {$move_up_left} AND {$move_up_right} THEN -{$diff_up}
				ELSE {$diff_down}
			END,
			cat_parents = ''
			WHERE
				left_id BETWEEN {$left_id} AND {$right_id}
				AND right_id BETWEEN {$left_id} AND {$right_id}";
		$db->sql_query($sql);

		return $target['cat_name'];
	}

	function delete_cat($cat_id, $action_links = 'delete', $action_subcats = 'delete', $links_to_id = 0, $subcats_to_id = 0)

	{
		global $db, $user, $cache;

		$cat_data = $this->get_cat_info($cat_id);

		$errors = array();
		$log_action_posts = $log_action_cats = $posts_to_name = $subcats_to_name = '';
		$cat_ids = array($cat_id);

		if ($action_links == 'delete')
		{
			$log_action_posts = 'LINKS';
			$errors = array_merge($errors, $this->delete_cat_content($cat_id));
		}
		else if ($action_links == 'move')
		{
			if (!$links_to_id)
			{
				$errors[] = $user->lang['DIR_NO_DESTINATION_CAT'];
			}
			else
			{
				$log_action_posts = 'MOVE_LINKS';

				$sql = 'SELECT cat_name
					FROM ' . DIR_CAT_TABLE . '
					WHERE cat_id = ' . (int)$links_to_id;
				$result = $db->sql_query($sql);
				$row = $db->sql_fetchrow($result);
				$db->sql_freeresult($result);

				if (!$row)
				{
					$errors[] = $user->lang['DIR_NO_CAT'];
				}
				else
				{
					$posts_to_name = $row['cat_name'];
					$errors = array_merge($errors, $this->move_cat_content($cat_id, $links_to_id));
				}
			}
		}

		if (sizeof($errors))
		{
			return $errors;
		}

		if ($action_subcats == 'delete')
		{
			$log_action_cats = 'CATS';
			$rows = get_dir_cat_branch($cat_id, 'children', 'descending', false);

			foreach ($rows as $row)
			{
				$cat_ids[] = $row['cat_id'];
				$errors = array_merge($errors, $this->delete_cat_content($row['cat_id']));
			}

			if (sizeof($errors))
			{
				return $errors;
			}

			$diff = sizeof($cat_ids) * 2;

			$sql = 'DELETE FROM ' . DIR_CAT_TABLE . '
				WHERE ' . $db->sql_in_set('cat_id', $cat_ids);
			$db->sql_query($sql);

		}
		else if ($action_subcats == 'move')
		{
			if (!$subcats_to_id)
			{
				$errors[] = $user->lang['DIR_NO_DESTINATION_CAT'];
			}
			else
			{
				$log_action_cats = 'MOVE_CATS';

				$sql = 'SELECT cat_name
					FROM ' . DIR_CAT_TABLE . '
					WHERE cat_id = ' . (int)$subcats_to_id;
				$result = $db->sql_query($sql);
				$row = $db->sql_fetchrow($result);
				$db->sql_freeresult($result);

				if (!$row)
				{
					$errors[] = $user->lang['DIR_NO_CAT'];
				}
				else
				{
					$subcats_to_name = $row['cat_name'];

					$sql = 'SELECT cat_id
						FROM ' . DIR_CAT_TABLE . '
						WHERE parent_id = ' . (int)$cat_id;
					$result = $db->sql_query($sql);

					while ($row = $db->sql_fetchrow($result))
					{
						$this->move_cat($row['cat_id'], $subcats_to_id);
					}
					$db->sql_freeresult($result);

					// Grab new cat data for correct tree updating later
					$cat_data = $this->get_cat_info($cat_id);

					$sql = 'UPDATE ' . DIR_CAT_TABLE . '
						SET parent_id = ' . (int)$subcats_to_id . '
							WHERE parent_id = ' . (int)$cat_id;
					$db->sql_query($sql);

					$diff = 2;
					$sql = 'DELETE FROM ' . DIR_CAT_TABLE . '
						WHERE cat_id = ' . (int)$cat_id;
					$db->sql_query($sql);
				}
			}

			if (sizeof($errors))
			{
				return $errors;
			}
		}
		else
		{
			$diff = 2;
			$sql = 'DELETE FROM ' . DIR_CAT_TABLE . '
				WHERE cat_id = ' . (int)$cat_id;
			$db->sql_query($sql);
		}

		// Resync tree
		$sql = 'UPDATE ' . DIR_CAT_TABLE . "
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
			SET right_id = right_id - $diff
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			WHERE left_id < {$cat_data['right_id']} AND right_id > {$cat_data['right_id']}";
		$db->sql_query($sql);

		$sql = 'UPDATE ' . DIR_CAT_TABLE . "
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
			SET left_id = left_id - $diff, right_id = right_id - $diff
			WHERE left_id > {$cat_data['right_id']}";
		$db->sql_query($sql);

		$log_action = implode('_', array($log_action_posts, $log_action_cats));

		switch ($log_action)
		{
			case 'MOVE_LINKS_MOVE_CATS':
				add_log('admin', 'LOG_DIR_CAT_DEL_MOVE_LINKS_MOVE_CATS', $posts_to_name, $subcats_to_name, $cat_data['cat_name']);
			break;

			case 'MOVE_LINKS_CATS':
				add_log('admin', 'LOG_DIR_CAT_DEL_MOVE_LINKS_CATS', $posts_to_name, $cat_data['cat_name']);
			break;

			case 'LINKS_MOVE_CATS':
				add_log('admin', 'LOG_DIR_CAT_DEL_LINKS_MOVE_CATS', $subcats_to_name, $cat_data['cat_name']);
			break;

			case '_MOVE_CATS':
				add_log('admin', 'LOG_DIR_CAT_DEL_MOVE_CATS', $subcats_to_name, $cat_data['cat_name']);
			break;

			case 'MOVE_LINKS_':
				add_log('admin', 'LOG_DIR_CAT_DEL_MOVE_LINKS', $posts_to_name, $cat_data['cat_name']);
			break;

			case 'LINKS_CATS':
				add_log('admin', 'LOG_DIR_CAT_DEL_LINKS_CATS', $cat_data['cat_name']);
			break;

			case '_CATS':
				add_log('admin', 'LOG_DIR_CAT_DEL_CATS', $cat_data['cat_name']);
			break;

			case 'LINKS_':
				add_log('admin', 'LOG_DIR_CAT_DEL_LINKS', $cat_data['cat_name']);
			break;

			default:
				add_log('admin', 'LOG_DIR_CAT_DEL_CAT', $cat_data['cat_name']);
			break;
		}

		return $errors;
	}

	function move_cat_content($from_id, $to_id)

	{
		global $db;

		$sql = 'UPDATE ' . DIR_LINK_TABLE . '
			SET link_cat = ' . (int)$to_id . '
			WHERE link_cat = ' . (int)$from_id;
		$db->sql_query($sql);

		$sql = 'DELETE FROM ' . DIR_NOTIFICATION_TABLE . '
			WHERE n_cat_id = ' . (int)$from_id;
		$db->sql_query($sql);

		sync_dir_cat($to_id);

		return array();
	}

	function delete_cat_content($cat_id)

	{
		global $db, $phpbb_root_path;

		$db->sql_transaction('begin');

		// Before we remove anything we make sure we are able to adjust the post counts later. ;)
		$sql = 'SELECT link_id, link_banner
			FROM ' . DIR_LINK_TABLE . '
			WHERE link_cat = ' . (int)$cat_id;
		$result = $db->sql_query($sql);

		$link_ids = array();
		while ($row = $db->sql_fetchrow($result))
		{
			$link_ids[] = $row['link_id'];

			if($row['link_banner'] && !preg_match('/^(http:\/\/|https:\/\/|ftp:\/\/|ftps:\/\/|www\.).+/si', $row['link_banner']))

			{
				if (file_exists($phpbb_root_path . 'images/directory/banners' .'/'. basename($row['link_banner'])))
				{
					@unlink($phpbb_root_path . 'images/directory/banners' .'/'. basename($row['link_banner']));
				}
			}
		}
		$db->sql_freeresult($result);

		if (sizeof($link_ids))
		{
			// Delete links datas
			$link_datas_ary = array(
				DIR_COMMENT_TABLE	=> 'comment_link_id',
				DIR_VOTE_TABLE		=> 'vote_link_id',
			);

			foreach ($link_datas_ary as $table => $field)
			{
				$db->sql_query("DELETE FROM $table WHERE " . $db->sql_in_set($field, $link_ids));
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
			}
		}

		// Delete cats datas
		$cat_datas_ary = array(
			DIR_LINK_TABLE			=> 'link_cat',
			DIR_NOTIFICATION_TABLE	=> 'n_cat_id',
		);

		foreach ($cat_datas_ary as $table => $field)
		{
			$db->sql_query("DELETE FROM $table WHERE $field = " . (int)$cat_id);
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
		}

		$db->sql_transaction('commit');

		return array();
	}
}

function get_dir_cat_branch($dir_cat_id, $type = 'all', $order = 'descending', $include_cat = true)
{
	global $db;

	switch ($type)
	{
		case 'parents':
			$condition = 'f1.left_id BETWEEN f2.left_id AND f2.right_id';
		break;

		case 'children':
			$condition = 'f2.left_id BETWEEN f1.left_id AND f1.right_id';
		break;

		default:
			$condition = 'f2.left_id BETWEEN f1.left_id AND f1.right_id OR f1.left_id BETWEEN f2.left_id AND f2.right_id';
		break;
	}

	$rows = array();

	$sql = 'SELECT f2.cat_id, f2.cat_name, f2.left_id, f2.right_id
		FROM ' . DIR_CAT_TABLE . ' f1
		LEFT JOIN ' . DIR_CAT_TABLE . " f2 ON ($condition)
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
		WHERE f1.cat_id = " . (int)$dir_cat_id . "
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		ORDER BY f2.left_id " . (($order == 'descending') ? 'ASC' : 'DESC');
	$result = $db->sql_query($sql);

	while ($row = $db->sql_fetchrow($result))
	{
		if (!$include_cat && $row['cat_id'] == $dir_cat_id)
		{
			continue;
		}

		$rows[] = $row;
	}
	$db->sql_freeresult($result);

	return $rows;
}

function make_cat_select($select_id = false, $ignore_id = false)
{
	global $db;

	// This query is identical to the jumpbox one
	$sql = 'SELECT cat_id, cat_name, parent_id, left_id, right_id
		FROM ' . DIR_CAT_TABLE . '
		ORDER BY left_id ASC';
	$result = $db->sql_query($sql);

	$right = 0;
	$padding_store = array('0' => '');
	$padding = '';
	$cat_list = '';

	while ($row = $db->sql_fetchrow($result))
	{
		if ($row['left_id'] < $right)

		{
			$padding .= '&nbsp; &nbsp;';
			$padding_store[$row['parent_id']] = $padding;
		}
		else if ($row['left_id'] > $right + 1)
		{
			$padding = (isset($padding_store[$row['parent_id']])) ? $padding_store[$row['parent_id']] : '';
		}

		$right = $row['right_id'];
		$disabled = false;

		if (((is_array($ignore_id) && in_array($row['cat_id'], $ignore_id)) || $row['cat_id'] == $ignore_id))
		{
			$disabled = true;
		}

		$selected = (($row['cat_id'] == $select_id) ? ' selected="selected"' : '');
		$cat_list .= '<option value="' . $row['cat_id'] . '"' . (($disabled) ? ' disabled="disabled" class="disabled-option"' : $selected) . '>' . $padding . $row['cat_name'] . '</option>';
	}
	$db->sql_freeresult($result);
	unset($padding_store);

	return $cat_list;
}

function sync_dir_cat($cat_id)
{
	global $db;

	$sql = 'SELECT COUNT(link_id) AS num_links
		FROM ' . DIR_LINK_TABLE . '
		WHERE link_cat = ' . (int)$cat_id . '
		AND link_active = 1';
	$result = $db->sql_query($sql);
	$total_links = (int) $db->sql_fetchfield('num_links');
	$db->sql_freeresult($result);

	$sql = 'UPDATE ' . DIR_CAT_TABLE . '
		SET cat_links = ' . $total_links . '
		WHERE cat_id = ' . (int)$cat_id;
	$db->sql_query($sql);

	return;
}

function sync_dir_links($start, $stop)
{
	global $db;

	$sql = 'UPDATE ' . DIR_LINK_TABLE . '
		SET	link_comment = 0,
			link_note = 0,
			link_vote = 0
		WHERE link_id BETWEEN ' . (int)$start . ' AND ' . (int)$stop;
	$db->sql_query($sql);

	$sql = 'SELECT vote_link_id, COUNT(vote_note) AS nb_vote, SUM(vote_note) AS total FROM ' . DIR_VOTE_TABLE . '
		WHERE vote_link_id BETWEEN ' . (int)$start . ' AND ' . (int)$stop . '
		GROUP BY vote_link_id';
	$result = $db->sql_query($sql);
	while ($tmp = $db->sql_fetchrow($result))
	{
		$sql = 'UPDATE ' . DIR_LINK_TABLE . ' SET
			link_note = ' . (int)$tmp['total'] . ',
			link_vote = ' . (int)$tmp['nb_vote'] . '
			WHERE link_id = ' . (int)$tmp['vote_link_id'];
		$db->sql_query($sql);
	}
	$db->sql_freeresult($result);

	$sql = 'SELECT 	comment_link_id, COUNT(comment_id) AS nb_comment FROM ' . DIR_COMMENT_TABLE . '
		WHERE comment_link_id BETWEEN ' . (int)$start . ' AND ' . (int)$stop . '
		GROUP BY comment_link_id';
	$result = $db->sql_query($sql);
	while ($tmp = $db->sql_fetchrow($result))
	{
		$sql = 'UPDATE ' . DIR_LINK_TABLE . ' SET
			link_comment = ' . (int)$tmp['nb_comment'] . '
			WHERE link_id = ' . (int)$tmp['comment_link_id'];
		$db->sql_query($sql);
	}
	$db->sql_freeresult($result);

	return;
}

function get_dir_icon_list($value)
{
	global $phpbb_root_path;

	$imglist = filelist($phpbb_root_path . 'images/directory/icons', '');
	$edit_img = $filename_list = '';
	$ranks = $existing_imgs = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

	foreach ($imglist as $path => $img_ary)
	{
		sort($img_ary);

		foreach ($img_ary as $img)
		{
			$img = $path . $img;

			if (!in_array($img, $existing_imgs) || $action == 'edit')

			{
				if ($img == $value)
				{
					$selected = ' selected="selected"';
					$edit_img = $img;
				}
				else
				{
					$selected = '';
				}

				if (strlen($img) > 255)
				{
					continue;
				}

				$filename_list .= '<option value="' . htmlspecialchars($img) . '"' . $selected . '>' . $img . '</option>';
			}
		}
	}
	$filename_list = '<option value=""' . (($edit_img == '') ? ' selected="selected"' : '') . '>----------</option>' . $filename_list;
	return ($filename_list);
}

function orphan_files($delete = false)
{
	global $db, $phpbb_root_path;

	$banner_path = 'images/directory/banners/';
	$imglist = filelist($phpbb_root_path . $banner_path);
	$physical_files = $logical_files = $orphan_files = array();

	if (!empty($imglist['']))
	{
		$imglist = array_values($imglist);
		$imglist = $imglist[0];

		foreach($imglist as $key => $img)
		{
			$physical_files[] = $img;
		}
		$sql = 'SELECT link_banner FROM ' . DIR_LINK_TABLE . '
		WHERE link_banner <> \'\'';
		$result = $db->sql_query($sql);

		while($row = $db->sql_fetchrow($result))
		{
			if (!preg_match('/^(http:\/\/|https:\/\/|ftp:\/\/|ftps:\/\/|www\.).+/si', $row['link_banner']))
			{
				$logical_files[] = basename($row['link_banner']);
			}
		}
		$db->sql_freeresult($result);

		$orphan_files = array_diff($physical_files, $logical_files);
	}

	if(!$delete)
	{
		return sizeof($orphan_files);
	}

	$directory = $phpbb_root_path.'images/directory/banners';

	$dh = @opendir($directory);
	while (($file = readdir($dh)) !== false)
	{
		if (in_array($file, $orphan_files))
		{
			@unlink($directory .'/'.$file);
		}
	}
}

?>
acp_directory::update_cat_data() F
last analyzed 2016-07-09 11:20 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-09 11:20 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 23 and the first side effect is on line 17. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			*
4			* @author Erwan NADER (ErnadoO) [email protected]
5			* @package acp
6			* @version $Id$
7			* @copyright (c) 2008 http://www.phpbb-services.com
8			* @license http://opensource.org/licenses/gpl-license.php GNU Public License
9			*
10			*/
11
12			/**
13			* @ignore
14			*/
15			if (!defined('IN_PHPBB'))
16			{
17			exit;
18			}
19
20			/**
21			* @package acp
22			*/
23			class acp_directory
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-09 11:20 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
24			{
25			var $u_action;
26			var $new_config;
27			var $parent_id = 0;
28
29			function main($id, $mode)
			0 ignored issues – show Best Practice introduced 2016-07-09 11:20 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style introduced 2016-07-09 11:20 UTC by Report Bug Copy Issue Report `main` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-07-09 11:20 UTC by Report Bug Copy Issue Report `main` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
30			{
31			global $db, $user, $auth, $template, $cache, $phpbb_seo;
32			global $config, $phpbb_root_path, $phpbb_admin_path, $phpEx;
33
34			$action = request_var('action', '');
35			$start = request_var('start', 0);
			0 ignored issues – show Unused Code introduced 2016-07-09 11:20 UTC by Report Bug Copy Issue Report `$start` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
36			$submit = (isset($_POST['submit'])) ? true : false;
ErnadoO / mod-phpbb-directory

acp_directory::update_cat_data() F last analyzed 2016-07-09 11:20 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

acp_directory::update_cat_data() F
last analyzed 2016-07-09 11:20 UTC
