link::__construct() - Code Metrics - Inspection of "v2.0.0-RC2" - ErnadoO/ext-phpbb-directory - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — 3.2.x ( be9360...c8dee9 )

by Erwan
created 2018-08-22 15:33 UTC
link::__construct() A

↳ Parent: link
Complexity

Conditions	1
Paths	1
Size

Total Lines
Duplication

Lines	17
Ratio	100 %
Importance

Changes
Metric	Value
dl	17
loc	17
rs	9.7
c	0
b	0
f	0
cc	1
nc	1
nop	14
How to fix Many Parameters

<?php
/**
*
* phpBB Directory extension for the phpBB Forum Software package.
*
* @copyright (c) 2014 ErnadoO <http://www.phpbb-services.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
*/

namespace ernadoo\phpbbdirectory\core;

class link extends helper
{
	/** @var \phpbb\db\driver\driver_interface */
	protected $db;

	/** @var \phpbb\config\config */
	protected $config;

	/** @var \phpbb\language\language */
	protected $language;

	/** @var \phpbb\template\template */
	protected $template;

	/** @var \phpbb\user */
	protected $user;

	/** @var \phpbb\controller\helper */
	protected $helper;

	/** @var \phpbb\request\request */
	protected $request;

	/** @var \phpbb\auth\auth */
	protected $auth;

	/** @var \phpbb\notification\manager */
	protected $notification;

	/** @var \phpbb\filesystem\filesystem_interface */
	protected $filesystem;

	/** @var \FastImageSize\FastImageSize */
	protected $imagesize;

	/** @var \phpbb\files\upload */
	protected $files_upload;

	/** @var string phpBB root path */
	protected $root_path;

	/** @var string phpEx */
	protected $php_ext;

	/**
	* Constructor
	*
	* @param \phpbb\db\driver\driver_interface 					$db					Database object
	* @param \phpbb\config\config 								$config				Config object
	* @param \phpbb\language\language							$language			Language object
	* @param \phpbb\template\template 							$template			Template object
	* @param \phpbb\user 										$user				User object
	* @param \phpbb\controller\helper 							$helper				Controller helper object
	* @param \phpbb\request\request 							$request			Request object
	* @param \phpbb\auth\auth 									$auth				Auth object
	* @param \phpbb\notification\manager						$notification		Notification object
	* @param \phpbb\filesystem\filesystem_interface				$filesystem			phpBB filesystem helper
	* @param \FastImageSize\FastImageSize						$imagesize 			FastImageSize class
	* @param \phpbb\files\upload								$files_upload		Upload object
	* @param string         									$root_path			phpBB root path
	* @param string         									$php_ext			phpEx
	*/
	public function __construct(\phpbb\db\driver\driver_interface $db, \phpbb\config\config $config, \phpbb\language\language $language, \phpbb\template\template $template, \phpbb\user $user, \phpbb\controller\helper $helper, \phpbb\request\request $request, \phpbb\auth\auth $auth, \phpbb\notification\manager $notification, \phpbb\filesystem\filesystem_interface $filesystem, \FastImageSize\FastImageSize $imagesize, \phpbb\files\upload $files_upload, $root_path, $php_ext)
	{
		$this->db				= $db;
		$this->config			= $config;
		$this->language			= $language;
		$this->template			= $template;
		$this->user				= $user;
		$this->helper			= $helper;
		$this->request			= $request;
		$this->auth				= $auth;
		$this->notification		= $notification;
		$this->filesystem		= $filesystem;
		$this->imagesize		= $imagesize;
		$this->files_upload 	= $files_upload;
		$this->root_path		= $root_path;
		$this->php_ext			= $php_ext;
	}

	/**
	* Add a link into db
	*
	* @param	array	$data			Contains all data to insert in db
	* @param	bool	$need_approval	Links needs to be approved?
	* @return	null
	*/
	public function add($data, $need_approval)
	{
		$notification_data = array();

		$this->db->sql_transaction('begin');

		$sql = 'INSERT INTO ' . $this->links_table . ' ' . $this->db->sql_build_array('INSERT', $data);
		$this->db->sql_query($sql);
		$notification_data['link_id'] = $this->db->sql_nextid();

		if (!$need_approval || $this->auth->acl_get('a_') || $this->auth->acl_get('m_'))
		{
			$sql = 'UPDATE ' . $this->categories_table . '
				SET cat_links = cat_links + 1
				WHERE cat_id = ' . (int) $data['link_cat'];
			$this->db->sql_query($sql);

			$notification_type = 'ernadoo.phpbbdirectory.notification.type.directory_website';
		}
		else if ($this->config['dir_mail'])
		{
			$notification_type = 'ernadoo.phpbbdirectory.notification.type.directory_website_in_queue';
		}

		$this->db->sql_transaction('commit');

		if (isset($notification_type))
		{
			$notification_data = array_merge($notification_data,
				array(
					'user_from'			=> (int) $data['link_user_id'],
					'link_name'			=> $data['link_name'],
					'link_url'			=> $data['link_url'],
					'link_description'	=> $data['link_description'],
					'cat_id'			=> (int) $data['link_cat'],
					'cat_name'			=> \ernadoo\phpbbdirectory\core\categorie::getname((int) $data['link_cat']),
				)
			);

			$this->notification->add_notifications($notification_type, $notification_data);
		}
	}

	/**
	* Edit a link of the db
	*
	* @param	array	$data			Contains all data to edit in db
	* @param	int		$link_id		is link's id, for WHERE clause
	* @param	bool	$need_approval	Links needs to be approved?
	* @return	null
	*/
	public function edit($data, $link_id, $need_approval)
	{
		$notification_data = array(
			'link_id'			=> (int) $link_id,
			'user_from'			=> (int) $data['link_user_id'],
			'link_name'			=> $data['link_name'],
			'link_description'	=> $data['link_description'],
			'cat_id'			=> (int) $data['link_cat'],
			'cat_name'			=> \ernadoo\phpbbdirectory\core\categorie::getname((int) $data['link_cat']),
		);

		$old_cat = array_pop($data);

		if ($old_cat != $data['link_cat'] || $need_approval)
		{
			$this->notification->delete_notifications('ernadoo.phpbbdirectory.notification.type.directory_website', (int) $link_id);

			$this->db->sql_transaction('begin');

			$sql = 'UPDATE ' . $this->categories_table . '
				SET cat_links = cat_links - 1
				WHERE cat_id = ' . (int) $old_cat;
			$this->db->sql_query($sql);

			if (!$need_approval)
			{
				$sql = 'UPDATE ' . $this->categories_table . '
					SET cat_links = cat_links + 1
					WHERE cat_id = ' . (int) $data['link_cat'];
				$this->db->sql_query($sql);

				$notification_type = 'ernadoo.phpbbdirectory.notification.type.directory_website';
			}
			else
			{
				$data['link_active'] = false;
				$notification_type = 'ernadoo.phpbbdirectory.notification.type.directory_website_in_queue';
			}

			$this->db->sql_transaction('commit');

			$this->notification->add_notifications($notification_type, $notification_data);
		}

		$sql = 'UPDATE ' . $this->links_table . '
			SET ' . $this->db->sql_build_array('UPDATE', $data) . '
			WHERE link_id = ' . (int) $link_id;
		$this->db->sql_query($sql);
	}

	/**
	* Delete a link of the db
	*
	* @param	int 	$cat_id		The category ID
	* @param	mixed 	$link_id	Link's id, for WHERE clause
	* @return	null
	*/
	public function del($cat_id, $link_id)
	{
		$this->db->sql_transaction('begin');

		$url_array = is_array($link_id) ? $link_id : array($link_id);

		// Delete links datas
		$link_datas_ary = array(
			$this->links_table		=> 'link_id',
			$this->comments_table	=> 'comment_link_id',
			$this->votes_table		=> 'vote_link_id',
		);

		$sql = 'SELECT link_banner
			FROM ' . $this->links_table . '
			WHERE '. $this->db->sql_in_set('link_id', $url_array);
		$result = $this->db->sql_query($sql);

		while ($row = $this->db->sql_fetchrow($result))
		{
			if ($row['link_banner'] && !preg_match('/^(http:\/\/|https:\/\/|ftp:\/\/|ftps:\/\/|www\.).+/si', $row['link_banner']))
			{
				$banner_img = $this->root_path . $this->get_banner_path(basename($row['link_banner']));

				if (file_exists($banner_img))
				{
					@unlink($banner_img);
				}
			}
		}

		foreach ($link_datas_ary as $table => $field)
		{
			$this->db->sql_query("DELETE FROM $table WHERE ".$this->db->sql_in_set($field, $url_array));
		}

		$sql = 'UPDATE ' . $this->categories_table . '
			SET cat_links = cat_links - '.sizeof($url_array).'
			WHERE cat_id = ' . (int) $cat_id;
		$this->db->sql_query($sql);

		$this->db->sql_transaction('commit');

		foreach ($url_array as $link_id)
		{
			$this->notification->delete_notifications(array(
				'ernadoo.phpbbdirectory.notification.type.directory_website',
				'ernadoo.phpbbdirectory.notification.type.directory_website_in_queue'
			), $link_id);
		}

		if ($this->request->is_ajax())
		{
			$sql = 'SELECT cat_links
				FROM ' . $this->categories_table . '
				WHERE cat_id = ' . (int) $cat_id;
			$result = $this->db->sql_query($sql);
			$data = $this->db->sql_fetchrow($result);

			$json_response = new \phpbb\json_response;
			$json_response->send(array(
				'success' => true,

				'MESSAGE_TITLE'	=> $this->language->lang('INFORMATION'),
				'MESSAGE_TEXT'	=> $this->language->lang('DIR_DELETE_OK'),
				'LINK_ID'		=> $link_id,
				'TOTAL_LINKS'	=> $this->language->lang('DIR_NB_LINKS', (int) $data['cat_links']),
			));
		}
	}

	/**
	* Increments link view counter
	*
	* @param	int		$link_id	Link's id, for WHERE clause
	* @return	null
	* @throws	\phpbb\exception\http_exception
	*/
	public function view($link_id)
	{
		$sql = 'SELECT link_id, link_url
			FROM ' . $this->links_table . '
			WHERE link_id = ' . (int) $link_id;
		$result = $this->db->sql_query($sql);
		$data = $this->db->sql_fetchrow($result);

		if (empty($data['link_id']))
		{
			throw new \phpbb\exception\http_exception(404, 'DIR_ERROR_NO_LINKS');
		}

		$sql = 'UPDATE ' . $this->links_table . '
			SET link_view = link_view + 1
			WHERE link_id = ' . (int) $link_id;
		$this->db->sql_query($sql);

		redirect($data['link_url'], false, true);
		return;
	}

	/**
	* Verify that an URL exist before add into db
	*
	* @param	string	$url	The URL to check
	* @return	bool			True if url is reachable, else false.
	*/
	public function checkurl($url)
	{
		$details = parse_url($url);

		$default_port = 80;
		$hostname = $details['host'];

		if ($details['scheme'] == 'https')
		{
			$default_port = 443;
			$hostname = 'ssl://' . $details['host'];
		}

		if (!isset($details['path']))
		{
			$details['path'] = '/';
		}

		$port = (isset($details['port']) && !empty($details['port'])) ? (int) $details['port'] : $default_port;

		if ($sock = @fsockopen($hostname, $port, $errno, $errstr, 1))
		{
			$requete = 'GET '.$details['path']." HTTP/1.1\r\n";
			$requete .= 'Host: '.$details['host']."\r\n\r\n";

			// Send a HTTP GET header
			fputs($sock, $requete);
			// answer from server
			$str = fgets($sock, 1024);
			preg_match("'HTTP/1\.. (.*) (.*)'U", $str, $parts);
			fclose($sock);

			return !($parts[1] == '404');
		}
		return false;
	}

	/**
	* Delete the final '/', if no path
	*
	* @param	string	$url	URL to clean
	* @return	string	$url	The correct string.
	*/
	public function clean_url($url)
	{
		$details = parse_url($url);

		if (isset($details['path']) && $details['path'] == '/' && !isset($details['query']))
		{
			return substr($url, 0, -1);
		}
		return $url;
	}

	/**
	* Display a flag
	*
	* @param	array	$data	Link's data from db
	* @return	string			Flag path.
	*/
	public function display_flag($data)
	{
		global $phpbb_extension_manager;

		$ext_path = $phpbb_extension_manager->get_extension_path('ernadoo/phpbbdirectory', true);
		$flag_path = $ext_path.'images/flags/';
		$img_flag = 'no_flag.png';

		if ($this->config['dir_activ_flag'] && !empty($data['link_flag']) && file_exists($flag_path . $data['link_flag']))
		{
			$img_flag = $data['link_flag'];
		}

		return $this->get_img_path('flags', $img_flag);
	}

	/**
	* Calculate the link's note
	*
	* @param	int		$total_note		Sum of all link's notes
	* @param	int		$nb_vote		Number of votes
	* @param	bool	$votes_status	Votes are enable in this category?
	* @return	string	$note			The calculated note.
	*/
	public function display_note($total_note, $nb_vote, $votes_status)
	{
		if (!$votes_status)
		{
			return;
		}

		$note = ($nb_vote < 1) ? '' : $total_note / $nb_vote;
		$note = (strlen($note) > 2) ? number_format($note, 1) : $note;

		return ($nb_vote) ? $this->language->lang('DIR_FROM_TEN', $note) : $this->language->lang('DIR_NO_NOTE');
	}

	/**
	* Display the vote form for auth users
	*
	* @param	array	$data	Link's data from db
	* @return	null|string		Html combo list or nothing if votes are not available.
	*/
	public function display_vote($data)
	{
		if ($this->user->data['is_registered'] && $this->auth->acl_get('u_vote_dir') && empty($data['vote_user_id']))
		{
			$list = '<select name="vote">';
			for ($i = 0; $i <= 10; $i++)
			{
				$list .= '<option value="' . $i . '"' . (($i == 5) ? ' selected="selected"' : '') . '>' . $i . '</option>';
			}
			$list .= '</select>';

			return $list;
		}
	}

	/**
	* Display the RSS icon
	*
	* @param	array	$data	Link's data from db
	* @return	null|string		RSS feed URL or nothing.
	*/
	public function display_rss($data)
	{
		if ($this->config['dir_activ_rss'] && !empty($data['link_rss']))
		{
				return $data['link_rss'];
		}
	}

	/**
	* Display link's thumb if thumb service enabled.
	* if thumb don't exists in db or if a new service was choosen in acp
	* thumb is research
	*
	* @param	array		$data	Link's data from db
	* @return	string|null			Thumb or null.
	*/
	public function display_thumb($data)
	{
		if ($this->config['dir_activ_thumb'])
		{
			if (!$data['link_thumb'] || ($this->config['dir_thumb_service_reverse'] && (!strstr($data['link_thumb'], 'ascreen.jpg') && (!strstr($data['link_thumb'], $this->config['dir_thumb_service'])))))
			{
				$thumb = $this->thumb_process($data['link_url']);

				$sql = 'UPDATE ' . $this->links_table . "
					SET link_thumb = '" . $this->db->sql_escape($thumb) . "'
					WHERE link_id = " . (int) $data['link_id'];
				$this->db->sql_query($sql);

				return $thumb;
			}
			return $data['link_thumb'];
		}
	}

	/**
	* Display and resize a banner
	*
	* @param	array	$data		link's data from db
	* @return	string	$s_banner	html code.
	*/
	public function display_bann($data)
	{
		if (!empty($data['link_banner']))
		{
			if (!preg_match('/^(http:\/\/|https:\/\/|ftp:\/\/|ftps:\/\/|www\.).+/si', $data['link_banner']))
			{
				$img_src = $this->helper->route('ernadoo_phpbbdirectory_banner_controller', array('banner_img' => $data['link_banner']));
				$physical_path = $this->get_banner_path($data['link_banner']);
			}
			else
			{
				$img_src = $physical_path = $data['link_banner'];
			}

			if (($image_data = $this->imagesize->getImageSize($physical_path)) === false)
			{
				return '';
			}

			$width = $image_data['width'];
			$height = $image_data['height'];

			if (($width > $this->config['dir_banner_width'] || $height > $this->config['dir_banner_height']) && $this->config['dir_banner_width'] > 0 && $this->config['dir_banner_height'] > 0)
			{
				$coef_w = $width / $this->config['dir_banner_width'];
				$coef_h = $height / $this->config['dir_banner_height'];
				$coef_max = max($coef_w, $coef_h);
				$width /= $coef_max;
				$height /= $coef_max;
			}

			return '<img src="' . $img_src . '" width="' . $width . '" height="' . $height . '" alt="'.$data['link_name'].'" title="'.$data['link_name'].'" />';
		}
		return '';
	}

	/**
	* Add a vote in db, for a specifi link
	*
	* @param	int		$link_id	Link_id from db
	* @param	int		$note		Note submeted
	* @return	null
	*/
	public function add_vote($link_id, $note)
	{
		$data = array(
			'vote_link_id' 		=> (int) $link_id,
			'vote_user_id' 		=> $this->user->data['user_id'],
			'vote_note'			=> (int) $note,
		);

		$this->db->sql_transaction('begin');

		$sql = 'INSERT INTO ' . $this->votes_table . ' ' . $this->db->sql_build_array('INSERT', $data);
		$this->db->sql_query($sql);

		$sql = 'UPDATE ' . $this->links_table . '
			SET link_vote = link_vote + 1,
			link_note = link_note + ' . (int) $data['vote_note'] . '
		WHERE link_id = ' . (int) $link_id;
		$this->db->sql_query($sql);

		$this->db->sql_transaction('commit');

		if ($this->request->is_ajax())
		{
			$sql= 'SELECT link_vote, link_note FROM ' . $this->links_table . ' WHERE link_id = ' . (int) $link_id;
			$result = $this->db->sql_query($sql);
			$data = $this->db->sql_fetchrow($result);

			$note = $this->display_note($data['link_note'], $data['link_vote'], true);

			$json_response = new \phpbb\json_response;
			$json_response->send(array(
				'success' => true,

				'MESSAGE_TITLE'	=> $this->language->lang('INFORMATION'),
				'MESSAGE_TEXT'	=> $this->language->lang('DIR_VOTE_OK'),
				'NOTE'			=> $note,
				'NB_VOTE'		=> $this->language->lang('DIR_NB_VOTES', (int) $data['link_vote']),
				'LINK_ID'		=> $link_id
			));
		}
	}

	/**
	* Search an appropriate thumb for url
	*
	* @param	string	$url	Link's url
	* @return	string			The thumb url
	*/
	public function thumb_process($url)
	{
		if (!$this->config['dir_activ_thumb'])
		{
			return $this->root_path.'images/directory/nothumb.gif';
		}

		$details = parse_url($url);

		$root_url		= $details['scheme'].'://'.$details['host'];
		$absolute_url	= isset($details['path']) ? $root_url.$details['path'] : $root_url;

		if ($this->config['dir_activ_thumb_remote'] && $this->_ascreen_exist($details['scheme'], $details['host']))
		{
			return $root_url.'/ascreen.jpg';
		}
		return $this->config['dir_thumb_service'].$absolute_url;
	}

	/**
	* Check if ascreen thumb exists
	*
	* @param	string	$protocol	The protocol
	* @param	string	$host		The hostname
	* @return	bool				True if ascreen file exixts, else false
	*/
	private function _ascreen_exist($protocol, $host)
	{
		if (($thumb_info = $this->imagesize->getImageSize($protocol.'://'.$host.'/ascreen.jpg')) !== false)
		{
			// Obviously this is an image, we did some additional tests
			if ($thumb_info['width'] == '120' && $thumb_info['height'] == '90' && $thumb_info['type'] == 2)
			{
				return true;
			}
		}
		return false;
	}

	/**
	* Primary work on banner, can edit, copy or check a banner
	*
	* @param	string	$banner	The banner's remote url
	* @param	array	$error	The array error, passed by reference
	* @return	null
	*/
	public function banner_process(&$banner, &$error)
	{
		$old_banner = $this->request->variable('old_banner', '');

		$destination = $this->root_path . $this->get_banner_path();

		// Can we upload?
		$can_upload = ($this->config['dir_storage_banner'] && $this->filesystem->exists($destination) && $this->filesystem->is_writable($destination) && (@ini_get('file_uploads') || strtolower(@ini_get('file_uploads')) == 'on')) ? true : false;

		if ($banner && $can_upload)
		{
			$file = $this->_banner_upload($banner, $error);
		}
		else if ($banner)
		{
			$file = $this->_banner_remote($banner, $error);
		}
		else if ($this->request->is_set_post('delete_banner') && $old_banner)
		{
			$this->_banner_delete($old_banner);
			return;
		}

		if (!sizeof($error))
		{
			if ($banner && $old_banner && !preg_match('/^(http:\/\/|https:\/\/|ftp:\/\/|ftps:\/\/|www\.).+/si', $old_banner))
			{
				$this->_banner_delete($old_banner);
			}

			$banner = !empty($file) ? $file : '';
		}
	}

	/**
	* Copy a remonte banner to server.
	* called by banner_process()
	*
	* @param	string	$banner The banner's remote url
	* @param	array	$error	The array error, passed by reference
	* @return	false|string	String if no errors, else false
	*/
	private function _banner_upload($banner, &$error)
	{
		/** @var \phpbb\files\upload $upload */
		$upload = $this->files_upload
			->set_error_prefix('DIR_BANNER_')
			->set_allowed_extensions(array('jpg', 'jpeg', 'gif', 'png'))
			->set_max_filesize($this->config['dir_banner_filesize'])
			->set_disallowed_content((isset($this->config['mime_triggers']) ? explode('|', $this->config['mime_triggers']) : false));

		$file = $upload->handle_upload('files.types.remote', $banner);

		$prefix = unique_id() . '_';
		$file->clean_filename('real', $prefix);

		if (sizeof($file->error))
		{
			$file->remove();
			$error = array_merge($error, $file->error);
			$error = array_map(array($this->language, 'lang'), $error);
			return false;
		}

		$destination = $this->get_banner_path();

		// Move file and overwrite any existing image
		$file->move_file($destination, true);

		return strtolower($file->get('realname'));
	}

	/**
	* Check than remote banner exists
	* called by banner_process()
	*
	* @param	string	$banner	The banner's remote url
	* @param	array	$error	The array error, passed by reference
	* @return	false|string	String if no errors, else false
	*/
	private function _banner_remote($banner, &$error)
	{
		if (!preg_match('#^(http|https|ftp)://#i', $banner))
		{
			$banner = 'http://' . $banner;
		}
		if (!preg_match('#^(http|https|ftp)://(?:(.*?\.)*?[a-z0-9\-]+?\.[a-z]{2,4}|(?:\d{1,3}\.){3,5}\d{1,3}):?([0-9]*?).*?\.(gif|jpg|jpeg|png)$#i', $banner))
		{
			$error[] = $this->language->lang('DIR_BANNER_URL_INVALID');
			return false;
		}

		// Get image dimensions
		if (($image_data = $this->imagesize->getImageSize($banner)) === false)
		{
			$error[] = $this->language->lang('DIR_BANNER_UNABLE_GET_IMAGE_SIZE');
			return false;
		}

		if (!empty($image_data) && ($image_data['width'] < 2 || $image_data['height'] < 2))
		{
			$error[] = $this->language->lang('DIR_BANNER_UNABLE_GET_IMAGE_SIZE');
			return false;
		}

		$width = $image_data['width'];
		$height = $image_data['height'];

		if ($width <= 0 || $height <= 0)
		{
			$error[] = $this->language->lang('DIR_BANNER_UNABLE_GET_IMAGE_SIZE');
			return false;
		}

		// Check image type
		$types		= \phpbb\files\upload::image_types();
		$extension	= strtolower(\phpbb\files\filespec::get_extension($banner));

		// Check if this is actually an image
		if ($file_stream = @fopen($banner, 'r'))
		{
			// Timeout after 1 second
			stream_set_timeout($file_stream, 1);
			// read some data to ensure headers are present
			fread($file_stream, 1024);
			$meta = stream_get_meta_data($file_stream);
			if (isset($meta['wrapper_data']['headers']) && is_array($meta['wrapper_data']['headers']))
			{
				$headers = $meta['wrapper_data']['headers'];
			}
			else if (isset($meta['wrapper_data']) && is_array($meta['wrapper_data']))
			{
				$headers = $meta['wrapper_data'];
			}
			else
			{
				$headers = array();
			}

			foreach ($headers as $header)
			{
				$header = preg_split('/ /', $header, 2);
				if (strtr(strtolower(trim($header[0], ':')), '_', '-') === 'content-type')
				{
					if (strpos($header[1], 'image/') !== 0)
					{
						$error[] = 'DIR_BANNER_URL_INVALID';
						fclose($file_stream);
						return false;
					}
					else
					{
						fclose($file_stream);
						break;
					}
				}
			}
		}
		else
		{
			$error[] = 'DIR_BANNER_URL_INVALID';
			return false;
		}

		if (!empty($image_data) && (!isset($types[$image_data['type']]) || !in_array($extension, $types[$image_data['type']])))
		{
			if (!isset($types[$image_data['type']]))
			{
				$error[] = $this->language->lang('UNABLE_GET_IMAGE_SIZE');
			}
			else
			{
				$error[] = $this->language->lang('DIR_BANNER_IMAGE_FILETYPE_MISMATCH', $types[$image_data['type']][0], $extension);
			}
			return false;
		}

		if (($this->config['dir_banner_width'] || $this->config['dir_banner_height']) && ($width > $this->config['dir_banner_width'] || $height > $this->config['dir_banner_height']))
		{
			$error[] = $this->language->lang('DIR_BANNER_WRONG_SIZE', $this->config['dir_banner_width'], $this->config['dir_banner_height'], $width, $height);
			return false;
		}

		return $banner;
	}

	/**
	* Delete a banner from server
	*
	* @param	string	$file	The file's name
	* @return	bool			True if delete success, else false
	*/
	private function _banner_delete($file)
	{
		$old_banner = $this->root_path  . $this->get_banner_path($file);

		if (file_exists($old_banner))
		{
			@unlink($old_banner);
			return true;
		}

		return false;
	}

	/**
	* List flags
	*
	* @param	string	$flag_path	The flag directory path
	* @param	string	$value		Selected flag
	* @return	string	$list		Html code
	*/
	public function get_dir_flag_list($flag_path, $value)
	{
		$list = '';

		$this->language->add_lang('directory_flags', 'ernadoo/phpbbdirectory');

		$flags = $this->preg_grep_keys('/^DIR_FLAG_CODE_/i', $this->language->get_lang_array());

		if (extension_loaded('intl'))
		{
			$locale = $this->language->lang('USER_LANG');

			$col = new \Collator($locale);
			$col->asort($flags);
		}
		else
		{
			asort($flags);
		}

		foreach ($flags as $file => $name)
		{
			$img_file = strtolower(substr(strrchr($file, '_'), 1)).'.png';

			if (file_exists($flag_path.$img_file))
			{
				$list .= '<option value="' . $img_file . '" ' . (($img_file == $value) ? 'selected="selected"' : '') . '>' . $name . '</option>';
			}
		}

		return $list;
	}

	/**
	* Display recents links added
	*
	* @return	null
	*/
	public function recents()
	{
		if ($this->config['dir_recent_block'])
		{
			$limit_sql		= $this->config['dir_recent_rows'] * $this->config['dir_recent_columns'];
			$exclude_array	= array_filter(explode(',', str_replace(' ', '', $this->config['dir_recent_exclude'])));

			$sql_array = array(
				'SELECT'	=> 'l.link_id, l.link_cat, l.link_url, l.link_user_id, l.link_comment, l. link_description, l.link_vote, l.link_note, l.link_view, l.link_time, l.link_name, l.link_thumb, u.user_id, u.username, u.user_colour, c.cat_name',
				'FROM'		=> array(
						$this->links_table	=> 'l'),
				'LEFT_JOIN'	=> array(
						array(
							'FROM'	=> array(USERS_TABLE	=> 'u'),
							'ON'	=> 'l.link_user_id = u.user_id'
						),
						array(
							'FROM'	=> array($this->categories_table => 'c'),
							'ON'	=> 'l.link_cat = c.cat_id'
						)
				),
				'WHERE'		=> 'l.link_active = 1' . (sizeof($exclude_array) ? ' AND ' . $this->db->sql_in_set('l.link_cat', $exclude_array, true) : ''),
				'ORDER_BY'	=> 'l.link_time DESC, l.link_id DESC');

			$sql = $this->db->sql_build_query('SELECT', $sql_array);
			$result = $this->db->sql_query_limit($sql, $limit_sql, 0);
			$num = 0;
			$rowset = array();

			while ($site = $this->db->sql_fetchrow($result))
			{
				$rowset[$site['link_id']] = $site;
			}
			$this->db->sql_freeresult($result);

			if (sizeof($rowset))
			{
				$this->template->assign_block_vars('block', array(
					'S_COL_WIDTH'			=> (100 / $this->config['dir_recent_columns']) . '%',
				));

				foreach ($rowset as $row)
				{
					if (($num % $this->config['dir_recent_columns']) == 0)
					{
						$this->template->assign_block_vars('block.row', array());
					}

					$this->template->assign_block_vars('block.row.col', array(
						'NAME'						=> $row['link_name'],
						'USER'						=> get_username_string('full', $row['link_user_id'], $row['username'], $row['user_colour']),
						'TIME'						=> ($row['link_time']) ? $this->user->format_date($row['link_time']) : '',
						'CAT'						=> $row['cat_name'],
						'COUNT'						=> $row['link_view'],
						'COMMENT'					=> $row['link_comment'],

						'U_CAT'						=> $this->helper->route('ernadoo_phpbbdirectory_dynamic_route_' . $row['link_cat']),
						'U_COMMENT'					=> $this->helper->route('ernadoo_phpbbdirectory_comment_view_controller', array('link_id' => (int) $row['link_id'])),
						'U_LINK'					=> $row['link_url'],
						'U_THUMB'					=> $this->display_thumb($row),
						'U_VIEW'					=> $this->helper->route('ernadoo_phpbbdirectory_view_controller', array('link_id' => (int) $row['link_id'])),

						'L_DIR_SEARCH_NB_CLICKS'	=> $this->language->lang('DIR_SEARCH_NB_CLICKS', (int) $row['link_view']),
						'L_DIR_SEARCH_NB_COMMS'		=> $this->language->lang('DIR_SEARCH_NB_COMMS', (int) $row['link_comment']),
					));
					$num++;
				}

				while (($num % $this->config['dir_recent_columns']) != 0)
				{
					$this->template->assign_block_vars('block.row.col2', array());
					$num++;
				}
			}
		}
	}

	/**
	* Validate back link
	*
	* @param	string		$remote_url	Page URL contains the backlink
	* @param	bool		$optional	Link back is optional in this category?
	* @param	bool		$cron		This methos is called by con process?
	* @return	false|string			Either false if validation succeeded or a string which will be used as the error message (with the variable name appended)
	*/
	public function validate_link_back($remote_url, $optional, $cron = false)
	{
		if (!$cron)
		{
			if (empty($remote_url) && $optional)
			{
				return false;
			}

			if (!preg_match('#^http[s]?://(.*?\.)*?[a-z0-9\-]+\.[a-z]{2,4}#i', $remote_url))
			{
				return 'DIR_ERROR_WRONG_DATA_BACK';
			}
		}

		if (false === ($handle = @fopen($remote_url, 'r')))
		{
			return 'DIR_ERROR_NOT_FOUND_BACK';
		}

		$buff = '';

		// Read by packet, faster than file_get_contents()
		while (!feof($handle))
		{
			$buff .= fgets($handle, 256);

			if (stristr($buff, $this->config['server_name']))
			{
				@fclose($handle);
				return false;
			}
		}
		@fclose($handle);

		return 'DIR_ERROR_NO_LINK_BACK';
	}
}

ErnadoO / ext-phpbb-directory

Push — 3.2.x ( be9360...c8dee9 )

link::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like
