categories::__construct() - Code Metrics - Inspection of "Update tests" - ErnadoO/ext-phpbb-directory - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.3.x ( 37d736...41194d )

by Erwan

created 2017-08-27 10:52 UTC

categories::__construct() A

↳ Parent: categories

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	15
nc	1
nop	11

How to fix Many Parameters

<?php
/**
*
* phpBB Directory extension for the phpBB Forum Software package.
*
* @copyright (c) 2014 ErnadoO <http://www.phpbb-services.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
*/

namespace ernadoo\phpbbdirectory\controller;

use Symfony\Component\HttpFoundation\RedirectResponse;
use \ernadoo\phpbbdirectory\core\helper;
use E1379\SpeakingUrl\SpeakingUrl;

class categories extends helper
{
	/** @var \phpbb\db\driver\driver_interface */
	protected $db;

	/** @var \phpbb\config\config */
	protected $config;

	/** @var \phpbb\language\language */
	protected $language;

	/** @var \phpbb\template\template */
	protected $template;

	/** @var \phpbb\user */
	protected $user;

	/** @var \phpbb\controller\helper */
	protected $helper;

	/** @var \phpbb\request\request */
	protected $request;

	/** @var \phpbb\auth\auth */
	protected $auth;

	/** @var \phpbb\pagination */
	protected $pagination;

	/** @var \ernadoo\phpbbdirectory\core\categorie */
	protected $categorie;

	/** @var \ernadoo\phpbbdirectory\core\link */
	protected $link;

	/**
	* Constructor
	*
	* @param \phpbb\db\driver\driver_interface					$db			Database object
	* @param \phpbb\config\config								$config		Config object
	* @param \phpbb\language\language							$language	Language object
	* @param \phpbb\template\template							$template	Template object
	* @param \phpbb\user										$user		User object
	* @param \phpbb\controller\helper							$helper		Controller helper object
	* @param \phpbb\request\request								$request	Request object
	* @param \phpbb\auth\auth									$auth		Auth object
	* @param \phpbb\pagination									$pagination	Pagination object
	* @param \ernadoo\phpbbdirectory\core\categorie				$categorie	PhpBB Directory extension categorie object
	* @param \ernadoo\phpbbdirectory\core\link					$link		PhpBB Directory extension link object
	*/
	public function __construct(\phpbb\db\driver\driver_interface $db, \phpbb\config\config $config, \phpbb\language\language $language, \phpbb\template\template $template, \phpbb\user $user, \phpbb\controller\helper $helper, \phpbb\request\request $request, \phpbb\auth\auth $auth, \phpbb\pagination $pagination, \ernadoo\phpbbdirectory\core\categorie $categorie, \ernadoo\phpbbdirectory\core\link $link)
	{
		$this->db			= $db;
		$this->config		= $config;
		$this->language		= $language;
		$this->template		= $template;
		$this->user			= $user;
		$this->helper		= $helper;
		$this->request		= $request;
		$this->auth			= $auth;
		$this->pagination	= $pagination;
		$this->categorie	= $categorie;
		$this->link			= $link;

		$language->add_lang('directory', 'ernadoo/phpbbdirectory');

		$template->assign_vars(array(
			'S_PHPBB_DIRECTORY'	=> true,
		));
	}

	/**
	* Base controller to be accessed with the URL /directory
	*
	* @return	\Symfony\Component\HttpFoundation\Response	A Symfony Response object
	*/
	public function base()
	{
		$this->categorie->display();
		$this->link->recents();

		return $this->helper->render('body.html', $this->language->lang('DIRECTORY'));
	}

	/**
	* Legacy view controller for display a category
	* Used with /directory/categorie/{cat_id}
	* @deprecated 2.0.0 No longer used since dynamic routing.
	*
	* @param	int		$cat_id		The category ID
	* @param	int		$page		Page number taken from the URL
	* @param	int		$sort_days	Specifies the maximum amount of days a link may be old
	* @param	string	$sort_key	is the key of $sort_by_sql for the selected sorting: a|t|r|s|v
	* @param	string	$sort_dir	is either a or d representing ASC and DESC (ascending|descending)
	* @param	string	$mode		watch|unwatch
	* @return	\Symfony\Component\HttpFoundation\Response	A Symfony Response object
	* @throws	\phpbb\exception\http_exception
	*/
	public function view($cat_id, $page, $sort_days, $sort_key, $sort_dir, $mode = '')

	{
		if (false === $this->categorie->get($cat_id))
		{
			throw new \phpbb\exception\http_exception(404, 'DIR_ERROR_NO_CATS');
		}

		$url = $this->helper->route('ernadoo_phpbbdirectory_dynamic_route_' . $cat_id, array('page' => $page));

		return new RedirectResponse($url, 301);
	}

	/**
	* View controller for display a category
	*
	* @param	int		$cat_id		The category ID
	* @param	int		$page		Page number taken from the URL
	* @param	int		$sort_days	Specifies the maximum amount of days a link may be old
	* @param	string	$sort_key	is the key of $sort_by_sql for the selected sorting: a|t|r|s|v|p
	* @param	string	$sort_dir	is either a or d representing ASC and DESC (ascending|descending)
	* @param	string	$mode		watch|unwatch
	* @return	\Symfony\Component\HttpFoundation\Response	A Symfony Response object
	* @throws	\phpbb\exception\http_exception
	*/
	public function view_route($cat_id, $page = 1, $sort_days = 0, $sort_key = '', $sort_dir = '', $mode = '')
	{
		if (false === $this->categorie->get($cat_id))
		{
			throw new \phpbb\exception\http_exception(404, 'DIR_ERROR_NO_CATS');
		}

		$start = ($page - 1) * $this->config['dir_show'];

		$default_sort_days	= 0;
		$default_sort_key	= (string) substr($this->config['dir_default_order'], 0, 1);
		$default_sort_dir	= (string) substr($this->config['dir_default_order'], 2);

		$sort_days	= (!$sort_days) ? $this->request->variable('st', $default_sort_days) : $sort_days;
		$sort_key 	= (!$sort_key) ? $this->request->variable('sk', $default_sort_key) : $sort_key;
		$sort_dir	= (!$sort_dir) ? $this->request->variable('sd', $default_sort_dir) : $sort_dir;
		$link_list = $rowset = array();

		// Categorie ordering options
		$limit_days		= array(0 => $this->language->lang('SEE_ALL'), 1 => $this->language->lang('1_DAY'), 7 => $this->language->lang('7_DAYS'), 14 => $this->language->lang('2_WEEKS'), 30 => $this->language->lang('1_MONTH'), 90 => $this->language->lang('3_MONTHS'), 180 => $this->language->lang('6_MONTHS'), 365 => $this->language->lang('1_YEAR'));
		$sort_by_text	= array('a' => $this->language->lang('AUTHOR'), 't' => $this->language->lang('POST_TIME'), 'r' => $this->language->lang('DIR_COMMENTS_ORDER'), 's' =>  $this->language->lang('DIR_NAME_ORDER'), 'v' => $this->language->lang('DIR_NB_CLICKS_ORDER'));
		$sort_by_sql	= array('a' => 'u.username_clean', 't' => array('l.link_time', 'l.link_id'), 'r' => 'l.link_comment', 's' => 'LOWER(l.link_name)', 'v' => 'l.link_view');

		$s_limit_days = $s_sort_key = $s_sort_dir = $u_sort_param = '';
		gen_sort_selects($limit_days, $sort_by_text, $sort_days, $sort_key, $sort_dir, $s_limit_days, $s_sort_key, $s_sort_dir, $u_sort_param, $default_sort_days, $default_sort_key, $default_sort_dir);

		$u_sort_param = ($sort_days === $default_sort_days && $sort_key == $default_sort_key && $sort_dir == $default_sort_dir) ? array() : array('sort_days' => $sort_days, 'sort_key' => $sort_key, 'sort_dir' => $sort_dir);

		// Are we watching this categorie?
		$s_watching_categorie = array(
			'link'			=> '',
			'link_toggle'	=> '',
			'title'			=> '',
			'title_toggle'	=> '',
			'is_watching'	=> false,
		);

		if ($this->config['email_enable'] && $this->user->data['is_registered'])
		{
			$notify_status = (isset($this->categorie->data['notify_status'])) ? $this->categorie->data['notify_status'] : null;

			if (($message = $this->categorie->watch_categorie($mode, $s_watching_categorie, $this->user->data['user_id'], $cat_id, $notify_status)))
			{
				return $this->helper->message($message);
			}
		}

		// A deadline has been selected
		if ($sort_days)
		{
			$min_post_time = time() - ($sort_days * 86400);

			$sql = 'SELECT COUNT(link_id) AS nb_links
				FROM ' . $this->links_table . '
				WHERE link_cat = ' . (int) $cat_id . '
					AND link_time >= ' . $min_post_time;
			$result = $this->db->sql_query($sql);
			$nb_links = (int) $this->db->sql_fetchfield('nb_links');
			$this->db->sql_freeresult($result);

			if ($this->request->is_set_post('sort'))
			{
				$start = 0;
			}
			$sql_limit_time = " AND l.link_time >= $min_post_time";
		}
		else
		{
			$sql_limit_time = '';
			$nb_links		= (int) $this->categorie->data['cat_links'];
		}

		// Make sure $start is set to the last page if it exceeds the amount
		$start = $this->pagination->validate_start($start, $this->config['dir_show'], $nb_links);

		// Build navigation links
		$this->categorie->generate_dir_nav($this->categorie->data);

		// Jumpbox
		$this->categorie->make_cat_jumpbox();

		$base_url = array(
			'routes'	=> 'ernadoo_phpbbdirectory_dynamic_route_' . $cat_id,
			'params'	=> array_merge(array('cat_id' => $cat_id), $u_sort_param),
		);

		$this->pagination->generate_template_pagination($base_url, 'pagination', 'page', $nb_links, $this->config['dir_show'], $start);

		$this->template->assign_vars(array(
			'CAT_NAME'				=> $this->categorie->data['cat_name'],

			'S_SELECT_SORT_DIR'		=> $s_sort_dir,
			'S_SELECT_SORT_KEY'		=> $s_sort_key,
			'S_SELECT_SORT_DAYS'	=> $s_limit_days,
			'S_CATLIST'				=> $this->categorie->make_cat_select($cat_id),
			'S_PAGE_ACTION'			=> $this->helper->route('ernadoo_phpbbdirectory_dynamic_route_' . $cat_id, array('page' => $page)),
			'S_CAT_ID'				=> $cat_id,

			'TOTAL_LINKS'			=> $this->language->lang('DIR_NB_LINKS', (int) $nb_links),

			'U_NEW_SITE' 			=> $this->helper->route('ernadoo_phpbbdirectory_new_controller', array('cat_id' => $cat_id)),

			'U_VIEW_CAT'			=> $this->helper->route('ernadoo_phpbbdirectory_dynamic_route_' . $cat_id),
			'U_WATCH_CAT'			=> $s_watching_categorie['link'],
			'U_WATCH_CAT_TOGGLE'	=> $s_watching_categorie['link_toggle'],
			'S_WATCH_CAT_TITLE'		=> $s_watching_categorie['title'],
			'S_WATCH_CAT_TOGGLE'	=> $s_watching_categorie['title_toggle'],
			'S_WATCHING_CAT'		=> $s_watching_categorie['is_watching'],
		));

		// If the user is trying to reach late pages, start searching from the end
		$store_reverse = false;
		$sql_limit = $this->config['dir_show'];
		if ($start > $nb_links / 2)
		{
			$store_reverse = true;

			// Select the sort order
			$direction = (($sort_dir == 'd') ? 'ASC' : 'DESC');

			$sql_limit = $this->pagination->reverse_limit($start, $sql_limit, $nb_links);
			$sql_start = $this->pagination->reverse_start($start, $sql_limit, $nb_links);
		}
		else
		{
			// Select the sort order
			$direction = (($sort_dir == 'd') ? 'DESC' : 'ASC');
			$sql_start = $start;
		}

		if (is_array($sort_by_sql[$sort_key]))
		{
			$sql_sort_order = implode(' ' . $direction . ', ', $sort_by_sql[$sort_key]) . ' ' . $direction;
		}
		else
		{
			$sql_sort_order = $sort_by_sql[$sort_key] . ' ' . $direction;
		}

		// Grab just the sorted link ids
		$sql_array = array(
			'SELECT'	=> 'l.link_id',
			'FROM'		=> array(
					$this->links_table	=> 'l'),
			'LEFT_JOIN'	=> array(
					array(
						'FROM'	=> array(USERS_TABLE	=> 'u'),
						'ON'	=> 'l.link_user_id = u.user_id'
					),
			),
			'WHERE'		=> "l.link_cat = $cat_id
				AND l.link_active = 1
					$sql_limit_time",
			'ORDER_BY'	=> $sql_sort_order
		);

		$sql = $this->db->sql_build_query('SELECT', $sql_array);
		$result = $this->db->sql_query_limit($sql, $sql_limit, $sql_start);

		while ($row = $this->db->sql_fetchrow($result))
		{
			$link_list[] = (int) $row['link_id'];
		}
		$this->db->sql_freeresult($result);

		if (sizeof($link_list))
		{
			// We get links, informations about poster, votes and number of comments
			$sql_array = array(
				'SELECT'	=> 'l.link_id, l.link_cat, l.link_url, l.link_user_id, l.link_comment, l. link_description, l.link_banner, l.link_rss, l. link_uid, l.link_bitfield, l.link_flags, l.link_vote, l.link_note, l.link_view, l.link_time, l.link_name, l.link_flag, l.link_thumb, u.user_id, u.username, u.user_colour, v.vote_user_id',
				'FROM'		=> array(
						$this->links_table	=> 'l'),
				'LEFT_JOIN'	=> array(
						array(
							'FROM'	=> array(USERS_TABLE	=> 'u'),
							'ON'	=> 'l.link_user_id = u.user_id'
						),
						array(
							'FROM'	=> array($this->votes_table => 'v'),
							'ON'	=> 'l.link_id = v.vote_link_id AND v.vote_user_id = ' . $this->user->data['user_id']
						)
				),
				'WHERE'		=> $this->db->sql_in_set('l.link_id', $link_list)
			);

			$sql = $this->db->sql_build_query('SELECT', $sql_array);
			$result = $this->db->sql_query($sql);

			while ($site = $this->db->sql_fetchrow($result))
			{
				$rowset[$site['link_id']] = $site;
			}
			$this->db->sql_freeresult($result);

			$link_list = ($store_reverse) ? array_reverse($link_list) : $link_list;

			$votes_status 		= ($this->categorie->data['cat_allow_votes']) ? true : false;
			$comments_status 	= ($this->categorie->data['cat_allow_comments']) ? true : false;

			foreach ($link_list as $link_id)
			{
				$site = &$rowset[$link_id];

				$s_flag		= $this->link->display_flag($site);
				$s_note		= $this->link->display_note($site['link_note'], $site['link_vote'], $votes_status);
				$s_thumb	= $this->link->display_thumb($site);
				$s_vote		= $this->link->display_vote($site);
				$s_banner	= $this->link->display_bann($site);
				$s_rss		= $this->link->display_rss($site);

				$edit_allowed 	= ($this->user->data['is_registered'] && ($this->auth->acl_get('m_edit_dir') || ($this->user->data['user_id'] == $site['link_user_id'] && $this->auth->acl_get('u_edit_dir'))));
				$delete_allowed = ($this->user->data['is_registered'] && ($this->auth->acl_get('m_delete_dir') || ($this->user->data['user_id'] == $site['link_user_id'] && $this->auth->acl_get('u_delete_dir'))));

				$this->template->assign_block_vars('site', array(
					'BANNER'		=> $s_banner,
					'COUNT'			=> $this->language->lang('DIR_NB_CLICKS', (int) $site['link_view']),
					'DESCRIPTION' 	=> generate_text_for_display($site['link_description'], $site['link_uid'], $site['link_bitfield'], $site['link_flags']),
					'LINK_ID'		=> $site['link_id'],
					'NAME'			=> $site['link_name'],
					'NB_COMMENT'	=> ($comments_status) ? $this->language->lang('DIR_NB_COMMS', (int) $site['link_comment']) : '',
					'NB_VOTE'		=> $this->language->lang('DIR_NB_VOTES', (int) $site['link_vote']),
					'NOTE'			=> $s_note,
					'RSS'			=> $s_rss,
					'TIME'			=> ($site['link_time']) ? $this->user->format_date($site['link_time']) : '',
					'USER'			=> get_username_string('full', $site['link_user_id'], $site['username'], $site['user_colour']),
					'VOTE_LIST'		=> ($votes_status) ? $s_vote : '',

					'IMG_FLAG'		=> $s_flag,
					'ON_CLICK' 		=> "onclick=\"window.open('".$this->helper->route('ernadoo_phpbbdirectory_view_controller', array('link_id' => (int) $site['link_id']))."'); return false;\"",

					'S_NEW_LINK'	=> (((time() - $site['link_time']) / 86400) <= $this->config['dir_new_time']) ? true : false,

					'U_COMMENT'		=> ($comments_status) ? $this->helper->route('ernadoo_phpbbdirectory_comment_view_controller', array('link_id' => (int) $site['link_id'])) : '',
					'U_DELETE'		=> $delete_allowed ? $this->helper->route('ernadoo_phpbbdirectory_delete_controller', array('cat_id' => (int) $cat_id, 'link_id' => (int) $site['link_id'], '_referer' => $this->helper->get_current_url())) : '',
					'U_EDIT'		=> $edit_allowed ? $this->helper->route('ernadoo_phpbbdirectory_edit_controller', array('cat_id' => (int) $cat_id, 'link_id' => (int) $site['link_id'])) : '',
					'U_FORM_VOTE'	=> ($votes_status) ? $this->helper->route('ernadoo_phpbbdirectory_vote_controller', array('cat_id' => (int) $site['link_cat'], 'link_id' => (int) $site['link_id'])) : '',
					'U_LINK'		=> $site['link_url'],
					'U_THUMB'		=> $s_thumb,
				));
			}
		}
		else
		{
			$this->template->assign_block_vars('no_draw_link', array());
		}

		$page_title = $this->language->lang('DIRECTORY') . ' - ' . $this->categorie->data['cat_name'];

		$this->categorie->display();

		return $this->helper->render('view_cat.html', $page_title);
	}

	/**
	* date controller for return a date
	*
	* @return	\phpbb\json_response	A Json Response
	* @throws	\phpbb\exception\http_exception
	*/
	public function return_date()
	{
		if (!$this->request->is_ajax())
		{
			throw new \phpbb\exception\http_exception(403, 'DIR_ERROR_NOT_AUTH');
		}

		$timestamp = $this->request->variable('timestamp', 0);
		$json_response = new \phpbb\json_response;
		$json_response->send(array(
			'success'	=> true,
			'DATE'		=> $this->user->format_date((int) $timestamp),
		));
	}

	/**
	* slug controller for return a slugify category name
	*
	* @return	\phpbb\json_response	A Json Response
	* @throws	\phpbb\exception\http_exception
	*/
	public function return_slug()
	{
		if (!$this->request->is_ajax())
		{
			throw new \phpbb\exception\http_exception(403, 'DIR_ERROR_NOT_AUTH');
		}

		$slug = new SpeakingUrl();
		$cat_name = $this->request->variable('cat_name', '', true);

		$json_response = new \phpbb\json_response;
		$json_response->send(array(
			'success'	=> true,
			'SLUG'		=> $slug->getSlug(html_entity_decode($cat_name), array('lang' => $this->config['default_lang'], 'symbols' => true)),
		));
	}
}


1		<?php
2		/**
3		*
4		* phpBB Directory extension for the phpBB Forum Software package.
5		*
6		* @copyright (c) 2014 ErnadoO <http://www.phpbb-services.com>
7		* @license GNU General Public License, version 2 (GPL-2.0)
8		*
9		*/
10
11		namespace ernadoo\phpbbdirectory\controller;
12
13		use Symfony\Component\HttpFoundation\RedirectResponse;
14		use \ernadoo\phpbbdirectory\core\helper;
15		use E1379\SpeakingUrl\SpeakingUrl;
16
17		class categories extends helper
18		{
19		/** @var \phpbb\db\driver\driver_interface */
20		protected $db;
21
22		/** @var \phpbb\config\config */
23		protected $config;
24
25		/** @var \phpbb\language\language */
26		protected $language;
27
28		/** @var \phpbb\template\template */
29		protected $template;
30
31		/** @var \phpbb\user */
32		protected $user;
33
34		/** @var \phpbb\controller\helper */
35		protected $helper;
36
37		/** @var \phpbb\request\request */
38		protected $request;
39
40		/** @var \phpbb\auth\auth */
41		protected $auth;
42
43		/** @var \phpbb\pagination */
44		protected $pagination;
45
46		/** @var \ernadoo\phpbbdirectory\core\categorie */
47		protected $categorie;
48
49		/** @var \ernadoo\phpbbdirectory\core\link */
50		protected $link;
51
52		/**
53		* Constructor
54		*
55		* @param \phpbb\db\driver\driver_interface $db Database object
56		* @param \phpbb\config\config $config Config object
57		* @param \phpbb\language\language $language Language object
58		* @param \phpbb\template\template $template Template object
59		* @param \phpbb\user $user User object
60		* @param \phpbb\controller\helper $helper Controller helper object
61		* @param \phpbb\request\request $request Request object
62		* @param \phpbb\auth\auth $auth Auth object
63		* @param \phpbb\pagination $pagination Pagination object
64		* @param \ernadoo\phpbbdirectory\core\categorie $categorie PhpBB Directory extension categorie object
65		* @param \ernadoo\phpbbdirectory\core\link $link PhpBB Directory extension link object
66		*/
67		public function __construct(\phpbb\db\driver\driver_interface $db, \phpbb\config\config $config, \phpbb\language\language $language, \phpbb\template\template $template, \phpbb\user $user, \phpbb\controller\helper $helper, \phpbb\request\request $request, \phpbb\auth\auth $auth, \phpbb\pagination $pagination, \ernadoo\phpbbdirectory\core\categorie $categorie, \ernadoo\phpbbdirectory\core\link $link)
68		{
69		$this->db = $db;
70		$this->config = $config;
71		$this->language = $language;
72		$this->template = $template;
73		$this->user = $user;
74		$this->helper = $helper;
75		$this->request = $request;
76		$this->auth = $auth;
77		$this->pagination = $pagination;
78		$this->categorie = $categorie;
79		$this->link = $link;
80
81		$language->add_lang('directory', 'ernadoo/phpbbdirectory');
82
83		$template->assign_vars(array(
84		'S_PHPBB_DIRECTORY' => true,
85		));
86		}
87
88		/**
89		* Base controller to be accessed with the URL /directory
90		*
91		* @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
92		*/
93		public function base()
94		{
95		$this->categorie->display();
96		$this->link->recents();
97
98		return $this->helper->render('body.html', $this->language->lang('DIRECTORY'));
99		}
100
101		/**
102		* Legacy view controller for display a category
103		* Used with /directory/categorie/{cat_id}
104		* @deprecated 2.0.0 No longer used since dynamic routing.
105		*
106		* @param int $cat_id The category ID
107		* @param int $page Page number taken from the URL
108		* @param int $sort_days Specifies the maximum amount of days a link may be old
109		* @param string $sort_key is the key of $sort_by_sql for the selected sorting: a\|t\|r\|s\|v
110		* @param string $sort_dir is either a or d representing ASC and DESC (ascending\|descending)
111		* @param string $mode watch\|unwatch
112		* @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
113		* @throws \phpbb\exception\http_exception
114		*/
115		public function view($cat_id, $page, $sort_days, $sort_key, $sort_dir, $mode = '')
		0 ignored issues – show Unused Code introduced 2017-08-20 00:32 UTC by Report Bug Copy Issue Report The parameter `$mode` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-26 16:32 UTC by Report Bug Copy Issue Report The parameter `$sort_days` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-26 16:32 UTC by Report Bug Copy Issue Report The parameter `$sort_key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-26 16:32 UTC by Report Bug Copy Issue Report The parameter `$sort_dir` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
116		{
117		if (false === $this->categorie->get($cat_id))
118		{
119		throw new \phpbb\exception\http_exception(404, 'DIR_ERROR_NO_CATS');
120		}
121
122		$url = $this->helper->route('ernadoo_phpbbdirectory_dynamic_route_' . $cat_id, array('page' => $page));
123
124		return new RedirectResponse($url, 301);
125		}
126
127		/**
128		* View controller for display a category
129		*
130		* @param int $cat_id The category ID
131		* @param int $page Page number taken from the URL
132		* @param int $sort_days Specifies the maximum amount of days a link may be old
133		* @param string $sort_key is the key of $sort_by_sql for the selected sorting: a\|t\|r\|s\|v\|p
134		* @param string $sort_dir is either a or d representing ASC and DESC (ascending\|descending)
135		* @param string $mode watch\|unwatch
136		* @return \Symfony\Component\HttpFoundation\Response A Symfony Response object
137		* @throws \phpbb\exception\http_exception
138		*/
139		public function view_route($cat_id, $page = 1, $sort_days = 0, $sort_key = '', $sort_dir = '', $mode = '')
140		{
141		if (false === $this->categorie->get($cat_id))
142		{
143		throw new \phpbb\exception\http_exception(404, 'DIR_ERROR_NO_CATS');
144		}
145
146		$start = ($page - 1) * $this->config['dir_show'];
147
148		$default_sort_days = 0;
149		$default_sort_key = (string) substr($this->config['dir_default_order'], 0, 1);
150		$default_sort_dir = (string) substr($this->config['dir_default_order'], 2);
151
152		$sort_days = (!$sort_days) ? $this->request->variable('st', $default_sort_days) : $sort_days;
153		$sort_key = (!$sort_key) ? $this->request->variable('sk', $default_sort_key) : $sort_key;
154		$sort_dir = (!$sort_dir) ? $this->request->variable('sd', $default_sort_dir) : $sort_dir;
155		$link_list = $rowset = array();
156
157		// Categorie ordering options
158		$limit_days = array(0 => $this->language->lang('SEE_ALL'), 1 => $this->language->lang('1_DAY'), 7 => $this->language->lang('7_DAYS'), 14 => $this->language->lang('2_WEEKS'), 30 => $this->language->lang('1_MONTH'), 90 => $this->language->lang('3_MONTHS'), 180 => $this->language->lang('6_MONTHS'), 365 => $this->language->lang('1_YEAR'));
159		$sort_by_text = array('a' => $this->language->lang('AUTHOR'), 't' => $this->language->lang('POST_TIME'), 'r' => $this->language->lang('DIR_COMMENTS_ORDER'), 's' => $this->language->lang('DIR_NAME_ORDER'), 'v' => $this->language->lang('DIR_NB_CLICKS_ORDER'));
160		$sort_by_sql = array('a' => 'u.username_clean', 't' => array('l.link_time', 'l.link_id'), 'r' => 'l.link_comment', 's' => 'LOWER(l.link_name)', 'v' => 'l.link_view');
161
162		$s_limit_days = $s_sort_key = $s_sort_dir = $u_sort_param = '';
163		gen_sort_selects($limit_days, $sort_by_text, $sort_days, $sort_key, $sort_dir, $s_limit_days, $s_sort_key, $s_sort_dir, $u_sort_param, $default_sort_days, $default_sort_key, $default_sort_dir);
164
165		$u_sort_param = ($sort_days === $default_sort_days && $sort_key == $default_sort_key && $sort_dir == $default_sort_dir) ? array() : array('sort_days' => $sort_days, 'sort_key' => $sort_key, 'sort_dir' => $sort_dir);
166
167		// Are we watching this categorie?
168		$s_watching_categorie = array(
169		'link' => '',
170		'link_toggle' => '',
171		'title' => '',
172		'title_toggle' => '',
173		'is_watching' => false,
174		);
175
176		if ($this->config['email_enable'] && $this->user->data['is_registered'])
177		{
178		$notify_status = (isset($this->categorie->data['notify_status'])) ? $this->categorie->data['notify_status'] : null;
179
180		if (($message = $this->categorie->watch_categorie($mode, $s_watching_categorie, $this->user->data['user_id'], $cat_id, $notify_status)))
181		{
182		return $this->helper->message($message);
183		}
184		}
185
186		// A deadline has been selected
187		if ($sort_days)
188		{
189		$min_post_time = time() - ($sort_days * 86400);
190
191		$sql = 'SELECT COUNT(link_id) AS nb_links
192		FROM ' . $this->links_table . '
193		WHERE link_cat = ' . (int) $cat_id . '
194		AND link_time >= ' . $min_post_time;
195		$result = $this->db->sql_query($sql);
196		$nb_links = (int) $this->db->sql_fetchfield('nb_links');
197		$this->db->sql_freeresult($result);
198
199		if ($this->request->is_set_post('sort'))
200		{
201		$start = 0;
202		}
203		$sql_limit_time = " AND l.link_time >= $min_post_time";
204		}
205		else
206		{
207		$sql_limit_time = '';
208		$nb_links = (int) $this->categorie->data['cat_links'];
209		}
210
211		// Make sure $start is set to the last page if it exceeds the amount
212		$start = $this->pagination->validate_start($start, $this->config['dir_show'], $nb_links);
213
214		// Build navigation links
215		$this->categorie->generate_dir_nav($this->categorie->data);
216
217		// Jumpbox
218		$this->categorie->make_cat_jumpbox();
219
220		$base_url = array(
221		'routes' => 'ernadoo_phpbbdirectory_dynamic_route_' . $cat_id,
222		'params' => array_merge(array('cat_id' => $cat_id), $u_sort_param),
223		);
224
225		$this->pagination->generate_template_pagination($base_url, 'pagination', 'page', $nb_links, $this->config['dir_show'], $start);
226
227		$this->template->assign_vars(array(
228		'CAT_NAME' => $this->categorie->data['cat_name'],
229
230		'S_SELECT_SORT_DIR' => $s_sort_dir,
231		'S_SELECT_SORT_KEY' => $s_sort_key,
232		'S_SELECT_SORT_DAYS' => $s_limit_days,
233		'S_CATLIST' => $this->categorie->make_cat_select($cat_id),
234		'S_PAGE_ACTION' => $this->helper->route('ernadoo_phpbbdirectory_dynamic_route_' . $cat_id, array('page' => $page)),
235		'S_CAT_ID' => $cat_id,
236
237		'TOTAL_LINKS' => $this->language->lang('DIR_NB_LINKS', (int) $nb_links),
238
239		'U_NEW_SITE' => $this->helper->route('ernadoo_phpbbdirectory_new_controller', array('cat_id' => $cat_id)),
240
241		'U_VIEW_CAT' => $this->helper->route('ernadoo_phpbbdirectory_dynamic_route_' . $cat_id),
242		'U_WATCH_CAT' => $s_watching_categorie['link'],
243		'U_WATCH_CAT_TOGGLE' => $s_watching_categorie['link_toggle'],
244		'S_WATCH_CAT_TITLE' => $s_watching_categorie['title'],
245		'S_WATCH_CAT_TOGGLE' => $s_watching_categorie['title_toggle'],
246		'S_WATCHING_CAT' => $s_watching_categorie['is_watching'],
247		));
248
249		// If the user is trying to reach late pages, start searching from the end
250		$store_reverse = false;
251		$sql_limit = $this->config['dir_show'];
252		if ($start > $nb_links / 2)
253		{
254		$store_reverse = true;
255
256		// Select the sort order
257		$direction = (($sort_dir == 'd') ? 'ASC' : 'DESC');
258
259		$sql_limit = $this->pagination->reverse_limit($start, $sql_limit, $nb_links);
260		$sql_start = $this->pagination->reverse_start($start, $sql_limit, $nb_links);
261		}
262		else
263		{
264		// Select the sort order
265		$direction = (($sort_dir == 'd') ? 'DESC' : 'ASC');
266		$sql_start = $start;
267		}
268
269	View Code Duplication	if (is_array($sort_by_sql[$sort_key]))
270		{
271		$sql_sort_order = implode(' ' . $direction . ', ', $sort_by_sql[$sort_key]) . ' ' . $direction;
272		}
273		else
274		{
275		$sql_sort_order = $sort_by_sql[$sort_key] . ' ' . $direction;
276		}
277
278		// Grab just the sorted link ids
279		$sql_array = array(
280		'SELECT' => 'l.link_id',
281		'FROM' => array(
282		$this->links_table => 'l'),
283		'LEFT_JOIN' => array(
284		array(
285		'FROM' => array(USERS_TABLE => 'u'),
286		'ON' => 'l.link_user_id = u.user_id'
287		),
288		),
289		'WHERE' => "l.link_cat = $cat_id
290		AND l.link_active = 1
291		$sql_limit_time",
292		'ORDER_BY' => $sql_sort_order
293		);
294
295		$sql = $this->db->sql_build_query('SELECT', $sql_array);
296		$result = $this->db->sql_query_limit($sql, $sql_limit, $sql_start);
297
298		while ($row = $this->db->sql_fetchrow($result))
299		{
300		$link_list[] = (int) $row['link_id'];
301		}
302		$this->db->sql_freeresult($result);
303
304		if (sizeof($link_list))
305		{
306		// We get links, informations about poster, votes and number of comments
307		$sql_array = array(
308		'SELECT' => 'l.link_id, l.link_cat, l.link_url, l.link_user_id, l.link_comment, l. link_description, l.link_banner, l.link_rss, l. link_uid, l.link_bitfield, l.link_flags, l.link_vote, l.link_note, l.link_view, l.link_time, l.link_name, l.link_flag, l.link_thumb, u.user_id, u.username, u.user_colour, v.vote_user_id',
309		'FROM' => array(
310		$this->links_table => 'l'),
311		'LEFT_JOIN' => array(
312		array(
313		'FROM' => array(USERS_TABLE => 'u'),
314		'ON' => 'l.link_user_id = u.user_id'
315		),
316		array(
317		'FROM' => array($this->votes_table => 'v'),
318		'ON' => 'l.link_id = v.vote_link_id AND v.vote_user_id = ' . $this->user->data['user_id']
319		)
320		),
321		'WHERE' => $this->db->sql_in_set('l.link_id', $link_list)
322		);
323
324		$sql = $this->db->sql_build_query('SELECT', $sql_array);
325		$result = $this->db->sql_query($sql);
326
327		while ($site = $this->db->sql_fetchrow($result))
328		{
329		$rowset[$site['link_id']] = $site;
330		}
331		$this->db->sql_freeresult($result);
332
333		$link_list = ($store_reverse) ? array_reverse($link_list) : $link_list;
334
335		$votes_status = ($this->categorie->data['cat_allow_votes']) ? true : false;
336		$comments_status = ($this->categorie->data['cat_allow_comments']) ? true : false;
337
338		foreach ($link_list as $link_id)
339		{
340		$site = &$rowset[$link_id];
341
342		$s_flag = $this->link->display_flag($site);
343		$s_note = $this->link->display_note($site['link_note'], $site['link_vote'], $votes_status);
344		$s_thumb = $this->link->display_thumb($site);
345		$s_vote = $this->link->display_vote($site);
346		$s_banner = $this->link->display_bann($site);
347		$s_rss = $this->link->display_rss($site);
348
349		$edit_allowed = ($this->user->data['is_registered'] && ($this->auth->acl_get('m_edit_dir') \|\| ($this->user->data['user_id'] == $site['link_user_id'] && $this->auth->acl_get('u_edit_dir'))));
350		$delete_allowed = ($this->user->data['is_registered'] && ($this->auth->acl_get('m_delete_dir') \|\| ($this->user->data['user_id'] == $site['link_user_id'] && $this->auth->acl_get('u_delete_dir'))));
351
352		$this->template->assign_block_vars('site', array(
353		'BANNER' => $s_banner,
354		'COUNT' => $this->language->lang('DIR_NB_CLICKS', (int) $site['link_view']),
355		'DESCRIPTION' => generate_text_for_display($site['link_description'], $site['link_uid'], $site['link_bitfield'], $site['link_flags']),
356		'LINK_ID' => $site['link_id'],
357		'NAME' => $site['link_name'],
358		'NB_COMMENT' => ($comments_status) ? $this->language->lang('DIR_NB_COMMS', (int) $site['link_comment']) : '',
359		'NB_VOTE' => $this->language->lang('DIR_NB_VOTES', (int) $site['link_vote']),
360		'NOTE' => $s_note,
361		'RSS' => $s_rss,
362		'TIME' => ($site['link_time']) ? $this->user->format_date($site['link_time']) : '',
363		'USER' => get_username_string('full', $site['link_user_id'], $site['username'], $site['user_colour']),
364		'VOTE_LIST' => ($votes_status) ? $s_vote : '',
365
366		'IMG_FLAG' => $s_flag,
367		'ON_CLICK' => "onclick=\"window.open('".$this->helper->route('ernadoo_phpbbdirectory_view_controller', array('link_id' => (int) $site['link_id']))."'); return false;\"",
368
369		'S_NEW_LINK' => (((time() - $site['link_time']) / 86400) <= $this->config['dir_new_time']) ? true : false,
370
371		'U_COMMENT' => ($comments_status) ? $this->helper->route('ernadoo_phpbbdirectory_comment_view_controller', array('link_id' => (int) $site['link_id'])) : '',
372		'U_DELETE' => $delete_allowed ? $this->helper->route('ernadoo_phpbbdirectory_delete_controller', array('cat_id' => (int) $cat_id, 'link_id' => (int) $site['link_id'], '_referer' => $this->helper->get_current_url())) : '',
373		'U_EDIT' => $edit_allowed ? $this->helper->route('ernadoo_phpbbdirectory_edit_controller', array('cat_id' => (int) $cat_id, 'link_id' => (int) $site['link_id'])) : '',
374		'U_FORM_VOTE' => ($votes_status) ? $this->helper->route('ernadoo_phpbbdirectory_vote_controller', array('cat_id' => (int) $site['link_cat'], 'link_id' => (int) $site['link_id'])) : '',
375		'U_LINK' => $site['link_url'],
376		'U_THUMB' => $s_thumb,
377		));
378		}
379		}
380		else
381		{
382		$this->template->assign_block_vars('no_draw_link', array());
383		}
384
385		$page_title = $this->language->lang('DIRECTORY') . ' - ' . $this->categorie->data['cat_name'];
386
387		$this->categorie->display();
388
389		return $this->helper->render('view_cat.html', $page_title);
390		}
391
392		/**
393		* date controller for return a date
394		*
395		* @return \phpbb\json_response A Json Response
396		* @throws \phpbb\exception\http_exception
397		*/
398		public function return_date()
399		{
400		if (!$this->request->is_ajax())
401		{
402		throw new \phpbb\exception\http_exception(403, 'DIR_ERROR_NOT_AUTH');
403		}
404
405		$timestamp = $this->request->variable('timestamp', 0);
406		$json_response = new \phpbb\json_response;
407		$json_response->send(array(
408		'success' => true,
409		'DATE' => $this->user->format_date((int) $timestamp),
410		));
411		}
412
413		/**
414		* slug controller for return a slugify category name
415		*
416		* @return \phpbb\json_response A Json Response
417		* @throws \phpbb\exception\http_exception
418		*/
419		public function return_slug()
420		{
421		if (!$this->request->is_ajax())
422		{
423		throw new \phpbb\exception\http_exception(403, 'DIR_ERROR_NOT_AUTH');
424		}
425
426		$slug = new SpeakingUrl();
427		$cat_name = $this->request->variable('cat_name', '', true);
428
429		$json_response = new \phpbb\json_response;
430		$json_response->send(array(
431		'success' => true,
432		'SLUG' => $slug->getSlug(html_entity_decode($cat_name), array('lang' => $this->config['default_lang'], 'symbols' => true)),
433		));
434		}
435		}
436

ErnadoO / ext-phpbb-directory

Push — 3.3.x ( 37d736...41194d )

categories::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like