Conditions | 1 |
Paths | 1 |
Total Lines | 124 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
22 | public function update_schema() |
||
23 | { |
||
24 | return array( |
||
25 | 'add_tables' => array( |
||
26 | $this->table_prefix . 'directory_cats' => array( |
||
27 | 'COLUMNS' => array( |
||
28 | 'cat_id' => array('UINT', null, 'auto_increment'), |
||
29 | 'parent_id' => array('UINT', 0), |
||
30 | 'left_id' => array('UINT', 0), |
||
31 | 'right_id' => array('UINT', 0), |
||
32 | 'cat_parents' => array('MTEXT_UNI', ''), |
||
33 | 'cat_name' => array('VCHAR', ''), |
||
34 | 'cat_desc' => array('TEXT_UNI', ''), |
||
35 | 'cat_desc_bitfield' => array('VCHAR', ''), |
||
36 | 'cat_desc_options' => array('TIMESTAMP', 7), |
||
37 | 'cat_desc_uid' => array('VCHAR:8', ''), |
||
38 | 'cat_links' => array('UINT', 0), |
||
39 | 'cat_icon' => array('VCHAR', ''), |
||
40 | 'display_subcat_list' => array('BOOL', 1), |
||
41 | 'cat_allow_comments' => array('BOOL', 1), |
||
42 | 'cat_allow_votes' => array('BOOL', 1), |
||
43 | 'cat_must_describe' => array('BOOL', 1), |
||
44 | 'cat_count_all' => array('BOOL', 0), |
||
45 | 'cat_validate' => array('BOOL', 1), |
||
46 | 'cat_link_back' => array('BOOL', 0), |
||
47 | 'cat_cron_enable' => array('BOOL', 0), |
||
48 | 'cat_cron_next' => array('TIMESTAMP', 0), |
||
49 | 'cat_cron_freq' => array('UINT', 7), |
||
50 | 'cat_cron_nb_check' => array('UINT', 1), |
||
51 | ), |
||
52 | |||
53 | 'PRIMARY_KEY' => array('cat_id'), |
||
54 | |||
55 | 'KEYS' => array( |
||
56 | 'l_r_id' => array('INDEX', array('left_id', 'right_id')), |
||
57 | ), |
||
58 | ), |
||
59 | |||
60 | $this->table_prefix . 'directory_comments' => array( |
||
61 | 'COLUMNS' => array( |
||
62 | 'comment_id' => array('UINT', null, 'auto_increment'), |
||
63 | 'comment_date' => array('TIMESTAMP', 0), |
||
64 | 'comment_link_id' => array('UINT', 0), |
||
65 | 'comment_user_id' => array('UINT', 0), |
||
66 | 'comment_user_ip' => array('VCHAR:40', ''), |
||
67 | 'comment_text' => array('MTEXT_UNI', ''), |
||
68 | 'comment_uid' => array('VCHAR:8', 0), |
||
69 | 'comment_flags' => array('TIMESTAMP', 0), |
||
70 | 'comment_bitfield' => array('VCHAR', ''), |
||
71 | ), |
||
72 | |||
73 | 'PRIMARY_KEY' => array('comment_id'), |
||
74 | ), |
||
75 | |||
76 | $this->table_prefix . 'directory_links' => array( |
||
77 | 'COLUMNS' => array( |
||
78 | 'link_id' => array('UINT', null, 'auto_increment'), |
||
79 | 'link_time' => array('TIMESTAMP', 0), |
||
80 | 'link_uid' => array('VCHAR:8', ''), |
||
81 | 'link_flags' => array('TIMESTAMP', 0), |
||
82 | 'link_bitfield' => array('VCHAR', ''), |
||
83 | 'link_url' => array('VCHAR', ''), |
||
84 | 'link_description' => array('MTEXT_UNI', ''), |
||
85 | 'link_view' => array('UINT', 0), |
||
86 | 'link_active' => array('BOOL', 0), |
||
87 | 'link_cat' => array('UINT', 0), |
||
88 | 'link_user_id' => array('UINT', 0), |
||
89 | 'link_name' => array('XSTEXT_UNI', ''), |
||
90 | 'link_rss' => array('VCHAR', ''), |
||
91 | 'link_banner' => array('VCHAR', ''), |
||
92 | 'link_back' => array('VCHAR', ''), |
||
93 | 'link_nb_check' => array('TINT:3', 0), |
||
94 | 'link_flag' => array('VCHAR', ''), |
||
95 | 'link_guest_email' => array('XSTEXT_UNI', ''), |
||
96 | 'link_vote' => array('UINT', 0), |
||
97 | 'link_comment' => array('TIMESTAMP', 0), |
||
98 | 'link_note' => array('UINT', 0), |
||
99 | 'link_pagerank' => array('CHAR:2', ''), |
||
100 | 'link_thumb' => array('VCHAR', ''), |
||
101 | ), |
||
102 | |||
103 | 'PRIMARY_KEY' => array('link_id'), |
||
104 | |||
105 | 'KEYS' => array( |
||
106 | 'link_id' => array('UNIQUE', array('link_id')), |
||
107 | 'link_c_a' => array('INDEX', array('link_cat', 'link_active')), |
||
108 | 'link_time' => array('INDEX', array('link_time')), |
||
109 | 'link_u_id' => array('INDEX', array('link_user_id')), |
||
110 | ), |
||
111 | ), |
||
112 | |||
113 | $this->table_prefix . 'directory_watch' => array( |
||
114 | 'COLUMNS' => array( |
||
115 | 'cat_id' => array('UINT', 0), |
||
116 | 'user_id' => array('UINT', 0), |
||
117 | 'notify_status' => array('UINT', 0), |
||
118 | ), |
||
119 | |||
120 | 'KEYS' => array( |
||
121 | 'c_id' => array('INDEX', array('cat_id')), |
||
122 | 'u_id' => array('INDEX', array('user_id')), |
||
123 | 'n_stat' => array('INDEX', array('notify_status')), |
||
124 | ), |
||
125 | |||
126 | ), |
||
127 | |||
128 | $this->table_prefix . 'directory_votes' => array( |
||
129 | 'COLUMNS' => array( |
||
130 | 'vote_id' => array('UINT', null, 'auto_increment'), |
||
131 | 'vote_link_id' => array('UINT', 0), |
||
132 | 'vote_user_id' => array('UINT', 0), |
||
133 | 'vote_note' => array('TINT:2', 0), |
||
134 | ), |
||
135 | |||
136 | 'PRIMARY_KEY' => array('vote_id'), |
||
137 | |||
138 | 'KEYS' => array( |
||
139 | 'v_l_id' => array('INDEX', array('vote_link_id')), |
||
140 | 'v_u_id' => array('INDEX', array('vote_user_id')), |
||
141 | ), |
||
142 | ), |
||
143 | ), |
||
144 | ); |
||
145 | } |
||
146 | |||
336 |