| Conditions | 1 |
| Paths | 1 |
| Total Lines | 93 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 160 | public function update_data() |
||
| 161 | { |
||
| 162 | return array( |
||
| 163 | array('config.add', array('dir_mail', '1')), |
||
| 164 | array('config.add', array('dir_activ_flag', '1')), |
||
| 165 | array('config.add', array('dir_show', '10')), |
||
| 166 | array('config.add', array('dir_default_order', 't d')), |
||
| 167 | array('config.add', array('dir_allow_bbcode', '1')), |
||
| 168 | array('config.add', array('dir_allow_flash', '1')), |
||
| 169 | array('config.add', array('dir_allow_links', '1')), |
||
| 170 | array('config.add', array('dir_allow_smilies', '1')), |
||
| 171 | array('config.add', array('dir_length_describe', '255')), |
||
| 172 | array('config.add', array('dir_activ_banner', '1')), |
||
| 173 | array('config.add', array('dir_banner_height', '60')), |
||
| 174 | array('config.add', array('dir_banner_width', '480')), |
||
| 175 | array('config.add', array('dir_activ_checkurl', '1')), |
||
| 176 | array('config.add', array('dir_activ_pagerank', '1')), |
||
| 177 | array('config.add', array('dir_activ_thumb', '1')), |
||
| 178 | array('config.add', array('dir_activ_thumb_remote', '1')), |
||
| 179 | array('config.add', array('dir_visual_confirm', '1')), |
||
| 180 | array('config.add', array('dir_visual_confirm_max_attempts', '3')), |
||
| 181 | array('config.add', array('dir_length_comments', '256')), |
||
| 182 | array('config.add', array('dir_new_time', '7')), |
||
| 183 | array('config.add', array('dir_comments_per_page', '10')), |
||
| 184 | array('config.add', array('dir_storage_banner', '1')), |
||
| 185 | array('config.add', array('dir_banner_filesize', '30000')), |
||
| 186 | array('config.add', array('dir_thumb_service', 'http://www.apercite.fr/apercite/120x90/oui/oui/')), |
||
| 187 | array('config.add', array('dir_thumb_service_reverse', '0')), |
||
| 188 | array('config.add', array('dir_activ_rss', '1')), |
||
| 189 | array('config.add', array('dir_recent_block', '1')), |
||
| 190 | array('config.add', array('dir_recent_exclude', '1')), |
||
| 191 | array('config.add', array('dir_recent_rows', '1')), |
||
| 192 | array('config.add', array('dir_recent_columns', '5')), |
||
| 193 | array('config.add', array('dir_root_path', './')), |
||
| 194 | array('config.add', array('dir_activ_rewrite', '0')), |
||
| 195 | |||
| 196 | array('module.add', array( |
||
| 197 | 'acp', |
||
| 198 | 'ACP_CAT_DOT_MODS', |
||
| 199 | 'ACP_DIRECTORY' |
||
| 200 | )), |
||
| 201 | |||
| 202 | array('module.add', array( |
||
| 203 | 'acp', |
||
| 204 | 'ACP_DIRECTORY', |
||
| 205 | array( |
||
| 206 | 'module_basename' => '\ernadoo\phpbbdirectory\acp\phpbbdirectory_module', |
||
| 207 | 'modes' => array('main', 'settings', 'cat', 'val'), |
||
| 208 | ), |
||
| 209 | )), |
||
| 210 | |||
| 211 | array('permission.add', array('u_comment_dir')), |
||
| 212 | array('permission.add', array('u_search_dir')), |
||
| 213 | array('permission.add', array('u_submit_dir')), |
||
| 214 | array('permission.add', array('u_vote_dir')), |
||
| 215 | array('permission.add', array('u_edit_comment_dir')), |
||
| 216 | array('permission.add', array('u_delete_comment_dir')), |
||
| 217 | array('permission.add', array('u_edit_dir')), |
||
| 218 | array('permission.add', array('u_delete_dir')), |
||
| 219 | array('permission.add', array('m_edit_dir')), |
||
| 220 | array('permission.add', array('m_delete_dir')), |
||
| 221 | array('permission.add', array('m_edit_comment_dir')), |
||
| 222 | array('permission.add', array('m_delete_comment_dir')), |
||
| 223 | |||
| 224 | array('permission.permission_set', |
||
| 225 | array('ROLE_USER_FULL', |
||
| 226 | array( |
||
| 227 | 'u_comment_dir', |
||
| 228 | 'u_search_dir', |
||
| 229 | 'u_submit_dir', |
||
| 230 | 'u_vote_dir', |
||
| 231 | 'u_edit_comment_dir', |
||
| 232 | 'u_delete_comment_dir', |
||
| 233 | 'u_edit_dir', |
||
| 234 | 'u_delete_dir', |
||
| 235 | ) |
||
| 236 | ) |
||
| 237 | ), |
||
| 238 | |||
| 239 | array('permission.permission_set', |
||
| 240 | array('ROLE_MOD_FULL', |
||
| 241 | array( |
||
| 242 | 'm_edit_dir', |
||
| 243 | 'm_delete_dir', |
||
| 244 | 'm_edit_comment_dir', |
||
| 245 | 'm_delete_comment_dir', |
||
| 246 | ) |
||
| 247 | ) |
||
| 248 | ), |
||
| 249 | |||
| 250 | array('custom', array(array(&$this, 'create_directories'))), |
||
| 251 | ); |
||
| 252 | } |
||
| 253 | |||
| 336 |