Passed
Pull Request — master (#123)
by Sebastian
05:58
created
Classes/Controller/TableOfContentsController.php 1 patch
Upper-Lower-Casing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
         $this->filterParams = $this->getParametersSafely('filterParameter');
52 52
 
53 53
         // output is done by main action
54
-        $this->forward('main', null, null, ['filterParameter' => $this->filterParams]);
54
+        $this->forward('main', NULL, NULL, ['filterParameter' => $this->filterParams]);
55 55
     }
56 56
 
57 57
     /**
@@ -64,8 +64,8 @@  discard block
 block discarded – undo
64 64
         // Load current document.
65 65
         $this->loadDocument($this->requestData);
66 66
         if (
67
-            $this->document === null
68
-            || $this->document->getDoc() === null
67
+            $this->document === NULL
68
+            || $this->document->getDoc() === NULL
69 69
         ) {
70 70
             // Quit without doing anything if required variables are not set.
71 71
             return;
@@ -127,12 +127,12 @@  discard block
 block discarded – undo
127 127
             }
128 128
             // Go through table of contents and create all menu entries.
129 129
             foreach ($this->document->getDoc()->tableOfContents as $entry) {
130
-                $menuArray[] = $this->getMenuEntry($entry, true);
130
+                $menuArray[] = $this->getMenuEntry($entry, TRUE);
131 131
             }
132 132
         } else {
133 133
             // Go through table of contents and create top-level menu entries.
134 134
             foreach ($this->document->getDoc()->tableOfContents as $entry) {
135
-                $menuArray[] = $this->getMenuEntry($entry, false);
135
+                $menuArray[] = $this->getMenuEntry($entry, FALSE);
136 136
             }
137 137
             // Build table of contents from database.
138 138
             $result = $this->documentRepository->getTableOfContentsFromDb($this->document->getUid(), $this->document->getPid(), $this->settings);
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
                         'pagination' => '',
152 152
                         'targetUid' => $resArray['uid']
153 153
                     ];
154
-                    $menuArray[0]['_SUB_MENU'][] = $this->getMenuEntry($entry, false);
154
+                    $menuArray[0]['_SUB_MENU'][] = $this->getMenuEntry($entry, FALSE);
155 155
                 }
156 156
             }
157 157
         }
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 
175 175
         // Go through table of contents and create all menu entries.
176 176
         foreach ($this->document->getDoc()->tableOfContents as $entry) {
177
-            $menuEntry = $this->getMenuEntryWithImage($entry, true);
177
+            $menuEntry = $this->getMenuEntryWithImage($entry, TRUE);
178 178
             if (!empty($menuEntry)) {
179 179
                 $menuArray[] = $menuEntry;
180 180
             }
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
      *
193 193
      * @return array HMENU array for menu entry
194 194
      */
195
-    protected function getMenuEntry(array $entry, $recursive = false)
195
+    protected function getMenuEntry(array $entry, $recursive = FALSE)
196 196
     {
197 197
         $entry = $this->resolveMenuEntry($entry);
198 198
 
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
         }
251 251
         // Build sub-menu if available and called recursively.
252 252
         if (
253
-            $recursive === true
253
+            $recursive === TRUE
254 254
             && !empty($entry['children'])
255 255
         ) {
256 256
             // Build sub-menu only if one of the following conditions apply:
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
                     if (in_array($child['id'], $this->activeEntries)) {
269 269
                         $entryArray['ITEM_STATE'] = 'ACT';
270 270
                     }
271
-                    $entryArray['_SUB_MENU'][] = $this->getMenuEntry($child, true);
271
+                    $entryArray['_SUB_MENU'][] = $this->getMenuEntry($child, TRUE);
272 272
                 }
273 273
             }
274 274
             // Append "IFSUB" to "ITEM_STATE" if this entry has sub-entries.
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
         return $entry;
305 305
     }
306 306
 
307
-    protected function getMenuEntryWithImage(array $entry, $recursive = false)
307
+    protected function getMenuEntryWithImage(array $entry, $recursive = FALSE)
308 308
     {
309 309
         $entryArray = [];
310 310
 
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
         $entryArray['doNotLinkIt'] = 1;
326 326
         $entryArray['ITEM_STATE'] = 'HEADER';
327 327
 
328
-        if ($entry['children'] === null) {
328
+        if ($entry['children'] === NULL) {
329 329
             $entryArray['description'] = $entry['description'];
330 330
             $id = $this->document->getDoc()->smLinks['l2p'][$entry['id']][0];
331 331
             $entryArray['image'] = $this->document->getDoc()->getFileLocation($this->document->getDoc()->physicalStructureInfo[$id]['files']['THUMBS']);
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
 
339 339
         // Build sub-menu if available and called recursively.
340 340
         if (
341
-            $recursive == true
341
+            $recursive == TRUE
342 342
             && !empty($entry['children'])
343 343
         ) {
344 344
             // Build sub-menu only if one of the following conditions apply:
Please login to merge, or discard this patch.
Classes/Controller/MetadataController.php 1 patch
Upper-Lower-Casing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -80,8 +80,8 @@  discard block
 block discarded – undo
80 80
         // Load current document.
81 81
         $this->loadDocument($this->requestData);
82 82
         if (
83
-            $this->document === null
84
-            || $this->document->getDoc() === null
83
+            $this->document === NULL
84
+            || $this->document->getDoc() === NULL
85 85
         ) {
86 86
             // Quit without doing anything if required variables are not set.
87 87
             return '';
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
      *
131 131
      * @return string The metadata array ready for output
132 132
      */
133
-    protected function printMetadata(array $metadataArray, $useOriginalIiifManifestMetadata = false)
133
+    protected function printMetadata(array $metadataArray, $useOriginalIiifManifestMetadata = FALSE)
134 134
     {
135 135
         if ($useOriginalIiifManifestMetadata) {
136 136
             $iiifData = [];
@@ -148,14 +148,14 @@  discard block
 block discarded – undo
148 148
                             $iiifData[$key] = [
149 149
                                 'label' => $key,
150 150
                                 'value' => $group,
151
-                                'buildUrl' => true,
151
+                                'buildUrl' => TRUE,
152 152
                             ];
153 153
                         } else {
154 154
                             // Data output
155 155
                             $iiifData[$key] = [
156 156
                                 'label' => $key,
157 157
                                 'value' => $group,
158
-                                'buildUrl' => false,
158
+                                'buildUrl' => FALSE,
159 159
                             ];
160 160
                         }
161 161
                     } else {
@@ -172,18 +172,18 @@  discard block
 block discarded – undo
172 172
                                 $iiifData[$key]['data'][] = [
173 173
                                     'label' => $nolabel ? '' : $label,
174 174
                                     'value' => $value,
175
-                                    'buildUrl' => true,
175
+                                    'buildUrl' => TRUE,
176 176
                                 ];
177 177
                             } else {
178 178
                                 $iiifData[$key]['data'][] = [
179 179
                                     'label' => $label,
180 180
                                     'value' => $value,
181
-                                    'buildUrl' => false,
181
+                                    'buildUrl' => FALSE,
182 182
                                 ];
183 183
                             }
184 184
                         }
185 185
                     }
186
-                    $this->view->assign('useIiif', true);
186
+                    $this->view->assign('useIiif', TRUE);
187 187
                     $this->view->assign('iiifData', $iiifData);
188 188
                 }
189 189
             }
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
                     if ($metadataName == 'title') {
214 214
                         // Get title of parent document if needed.
215 215
                         if (empty(implode('', $metadataValue)) && $this->settings['getTitle'] && $this->document->getPartof()) {
216
-                            $superiorTitle = Doc::getTitle($this->document->getPartof(), true);
216
+                            $superiorTitle = Doc::getTitle($this->document->getPartof(), TRUE);
217 217
                             if (!empty($superiorTitle)) {
218 218
                                 $metadataArray[$i][$metadataName] = ['[' . $superiorTitle . ']'];
219 219
                             }
Please login to merge, or discard this patch.