Passed
Pull Request — master (#123)
by Sebastian
03:13
created
Classes/Common/SolrSearch.php 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
             // in which case metadata of toplevel entry isn't yet filled.
99 99
             if (empty($document['metadata'])) {
100 100
                 $document['metadata'] = $this->fetchToplevelMetadataFromSolr([
101
-                    'query' => 'uid:' . $document['uid'],
101
+                    'query' => 'uid:'.$document['uid'],
102 102
                     'start' => 0,
103 103
                     'rows' => 1,
104 104
                     'sort' => ['score' => 'desc'],
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
             if (empty($document['title']) && $document['partOf'] > 0) {
110 110
                 $superiorTitle = Doc::getTitle($document['partOf'], true);
111 111
                 if (!empty($superiorTitle)) {
112
-                    $document['title'] = '[' . $superiorTitle . ']';
112
+                    $document['title'] = '['.$superiorTitle.']';
113 113
                 }
114 114
             }
115 115
         }
@@ -172,13 +172,13 @@  discard block
 block discarded – undo
172 172
         // Set search query.
173 173
         if (
174 174
             (!empty($this->searchParams['fulltext']))
175
-            || preg_match('/' . $fields['fulltext'] . ':\((.*)\)/', trim($this->searchParams['query']), $matches)
175
+            || preg_match('/'.$fields['fulltext'].':\((.*)\)/', trim($this->searchParams['query']), $matches)
176 176
         ) {
177 177
             // If the query already is a fulltext query e.g using the facets
178 178
             $this->searchParams['query'] = empty($matches[1]) ? $this->searchParams['query'] : $matches[1];
179 179
             // Search in fulltext field if applicable. Query must not be empty!
180 180
             if (!empty($this->searchParams['query'])) {
181
-                $query = $fields['fulltext'] . ':(' . Solr::escapeQuery(trim($this->searchParams['query'])) . ')';
181
+                $query = $fields['fulltext'].':('.Solr::escapeQuery(trim($this->searchParams['query'])).')';
182 182
             }
183 183
             $params['fulltext'] = true;
184 184
         } else {
@@ -201,9 +201,9 @@  discard block
 block discarded – undo
201 201
                         in_array($this->searchParams['extOperator'][$i], $allowedOperators)
202 202
                     ) {
203 203
                         if (!empty($query)) {
204
-                            $query .= ' ' . $this->searchParams['extOperator'][$i] . ' ';
204
+                            $query .= ' '.$this->searchParams['extOperator'][$i].' ';
205 205
                         }
206
-                        $query .= Indexer::getIndexFieldName($this->searchParams['extField'][$i], $this->settings['storagePid']) . ':(' . Solr::escapeQuery($this->searchParams['extQuery'][$i]) . ')';
206
+                        $query .= Indexer::getIndexFieldName($this->searchParams['extField'][$i], $this->settings['storagePid']).':('.Solr::escapeQuery($this->searchParams['extQuery'][$i]).')';
207 207
                     }
208 208
                 }
209 209
             }
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
         // Add filter query for date search
213 213
         if (!empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) {
214 214
             // combine dateFrom and dateTo into range search
215
-            $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}'. $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']';
215
+            $params['filterquery'][]['query'] = '{!join from='.$fields['uid'].' to='.$fields['uid'].'}'.$fields['date'].':['.$this->searchParams['dateFrom'].' TO '.$this->searchParams['dateTo'].']';
216 216
         }
217 217
 
218 218
         // Add filter query for faceting.
@@ -229,22 +229,22 @@  discard block
 block discarded – undo
229 229
         ) {
230 230
             // Search in document and all subordinates (valid for up to three levels of hierarchy).
231 231
             $params['filterquery'][]['query'] = '_query_:"{!join from='
232
-                . $fields['uid'] . ' to=' . $fields['partof'] . '}'
233
-                . $fields['uid'] . ':{!join from=' . $fields['uid'] . ' to=' . $fields['partof'] . '}'
234
-                . $fields['uid'] . ':' . $this->searchParams['documentId'] . '"' . ' OR {!join from='
235
-                . $fields['uid'] . ' to=' . $fields['partof'] . '}'
236
-                . $fields['uid'] . ':' . $this->searchParams['documentId'] . ' OR '
237
-                . $fields['uid'] . ':' . $this->searchParams['documentId'];
232
+                . $fields['uid'].' to='.$fields['partof'].'}'
233
+                . $fields['uid'].':{!join from='.$fields['uid'].' to='.$fields['partof'].'}'
234
+                . $fields['uid'].':'.$this->searchParams['documentId'].'"'.' OR {!join from='
235
+                . $fields['uid'].' to='.$fields['partof'].'}'
236
+                . $fields['uid'].':'.$this->searchParams['documentId'].' OR '
237
+                . $fields['uid'].':'.$this->searchParams['documentId'];
238 238
         }
239 239
 
240 240
         // if a collection is given, we prepare the collection query string
241 241
         if ($this->collection) {
242 242
             if ($this->collection instanceof Collection) {
243
-                $collectionsQueryString = '"' . $this->collection->getIndexName() . '"';
243
+                $collectionsQueryString = '"'.$this->collection->getIndexName().'"';
244 244
             } else {
245 245
                 $collectionsQueryString = '';
246 246
                 foreach ($this->collection as $index => $collectionEntry) {
247
-                    $collectionsQueryString .= ($index > 0 ? ' OR ' : '') . '"' . $collectionEntry->getIndexName() . '"';
247
+                    $collectionsQueryString .= ($index > 0 ? ' OR ' : '').'"'.$collectionEntry->getIndexName().'"';
248 248
                 }
249 249
             }
250 250
 
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
                 $params['filterquery'][]['query'] = 'toplevel:true';
253 253
                 $params['filterquery'][]['query'] = 'partof:0';
254 254
             }
255
-            $params['filterquery'][]['query'] = 'collection_faceting:(' . $collectionsQueryString . ')';
255
+            $params['filterquery'][]['query'] = 'collection_faceting:('.$collectionsQueryString.')';
256 256
         }
257 257
 
258 258
         // Set some query parameters.
@@ -279,8 +279,8 @@  discard block
 block discarded – undo
279 279
         if ($this->listedMetadata) {
280 280
             foreach ($this->listedMetadata as $metadata) {
281 281
                 if ($metadata->getIndexStored() || $metadata->getIndexIndexed()) {
282
-                    $listMetadataRecord = $metadata->getIndexName() . '_' . ($metadata->getIndexTokenized() ? 't' : 'u') . ($metadata->getIndexStored() ? 's' : 'u') . ($metadata->getIndexIndexed() ? 'i' : 'u');
283
-                    $params['fields'] .= ',' . $listMetadataRecord;
282
+                    $listMetadataRecord = $metadata->getIndexName().'_'.($metadata->getIndexTokenized() ? 't' : 'u').($metadata->getIndexStored() ? 's' : 'u').($metadata->getIndexIndexed() ? 'i' : 'u');
283
+                    $params['fields'] .= ','.$listMetadataRecord;
284 284
                     $params['listMetadataRecords'][$metadata->getIndexName()] = $listMetadataRecord;
285 285
                 }
286 286
             }
@@ -324,8 +324,8 @@  discard block
 block discarded – undo
324 324
                 }
325 325
                 if ($documents[$doc['uid']]) {
326 326
                     // translate language code if applicable
327
-                    if($doc['metadata']['language']) {
328
-                        foreach($doc['metadata']['language'] as $indexName => $language) {
327
+                    if ($doc['metadata']['language']) {
328
+                        foreach ($doc['metadata']['language'] as $indexName => $language) {
329 329
                             $doc['metadata']['language'][$indexName] = Helper::getLanguageName($doc['metadata']['language'][$indexName]);
330 330
                         }
331 331
                     }
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
                             $children = $childrenOf[$doc['uid']] ?? [];
365 365
                             if (!empty($children)) {
366 366
                                 $metadataOf = $this->fetchToplevelMetadataFromSolr([
367
-                                    'query' => 'partof:' . $doc['uid'],
367
+                                    'query' => 'partof:'.$doc['uid'],
368 368
                                     'start' => 0,
369 369
                                     'rows' => 100,
370 370
                                 ]);
@@ -411,8 +411,8 @@  discard block
 block discarded – undo
411 411
         if ($this->listedMetadata) {
412 412
             foreach ($this->listedMetadata as $metadata) {
413 413
                 if ($metadata->getIndexStored() || $metadata->getIndexIndexed()) {
414
-                    $listMetadataRecord = $metadata->getIndexName() . '_' . ($metadata->getIndexTokenized() ? 't' : 'u') . ($metadata->getIndexStored() ? 's' : 'u') . ($metadata->getIndexIndexed() ? 'i' : 'u');
415
-                    $params['fields'] .= ',' . $listMetadataRecord;
414
+                    $listMetadataRecord = $metadata->getIndexName().'_'.($metadata->getIndexTokenized() ? 't' : 'u').($metadata->getIndexStored() ? 's' : 'u').($metadata->getIndexIndexed() ? 'i' : 'u');
415
+                    $params['fields'] .= ','.$listMetadataRecord;
416 416
                     $params['listMetadataRecords'][$metadata->getIndexName()] = $listMetadataRecord;
417 417
                 }
418 418
             }
@@ -425,8 +425,8 @@  discard block
 block discarded – undo
425 425
 
426 426
         foreach ($result['documents'] as $doc) {
427 427
             // translate language code if applicable
428
-            if($doc['metadata']['language']) {
429
-                foreach($doc['metadata']['language'] as $indexName => $language) {
428
+            if ($doc['metadata']['language']) {
429
+                foreach ($doc['metadata']['language'] as $indexName => $language) {
430 430
                     $doc['metadata']['language'][$indexName] = Helper::getLanguageName($doc['metadata']['language'][$indexName]);
431 431
                 }
432 432
             }
@@ -468,7 +468,7 @@  discard block
 block discarded – undo
468 468
         $cache = null;
469 469
         // Calculate cache identifier.
470 470
         if ($enableCache === true) {
471
-            $cacheIdentifier = Helper::digest($solr->core . print_r($parameters, true));
471
+            $cacheIdentifier = Helper::digest($solr->core.print_r($parameters, true));
472 472
             $cache = GeneralUtility::makeInstance(CacheManager::class)->getCache('tx_dlf_solr');
473 473
         }
474 474
         $resultSet = [
Please login to merge, or discard this patch.