Conditions | 6 |
Paths | 4 |
Total Lines | 70 |
Code Lines | 42 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
39 | public function main(ServerRequestInterface $request) |
||
40 | { |
||
41 | $output = [ |
||
42 | 'documents' => [], |
||
43 | 'numFound' => 0 |
||
44 | ]; |
||
45 | // Get input parameters and decrypt core name. |
||
46 | $parameters = $request->getParsedBody(); |
||
47 | if ($parameters === null) { |
||
48 | throw new \InvalidArgumentException('No parameters passed!', 1632322297); |
||
49 | } |
||
50 | $encrypted = (string) $parameters['encrypted']; |
||
51 | $start = intval($parameters['start']); |
||
52 | if (empty($encrypted)) { |
||
53 | throw new \InvalidArgumentException('No valid parameter passed!', 1580585079); |
||
54 | } |
||
55 | |||
56 | $core = Helper::decrypt($encrypted); |
||
57 | |||
58 | // Perform Solr query. |
||
59 | $solr = Solr::getInstance($core); |
||
60 | $fields = Solr::getFields(); |
||
61 | |||
62 | if ($solr->ready) { |
||
63 | $query = $solr->service->createSelect(); |
||
64 | $query->setFields([$fields['id'], $fields['uid'], $fields['page']]); |
||
65 | $query->setQuery($this->getQuery($fields, $parameters)); |
||
66 | $query->setStart($start)->setRows(20); |
||
67 | $query->addSort($fields['page'], $query::SORT_ASC); |
||
68 | $query->getHighlighting(); |
||
69 | $solrRequest = $solr->service->createRequest($query); |
||
70 | |||
71 | // it is necessary to add the custom parameters to the request |
||
72 | // because query object doesn't allow custom parameters |
||
73 | |||
74 | // field for which highlighting is going to be performed, |
||
75 | // is required if you want to have OCR highlighting |
||
76 | $solrRequest->addParam('hl.ocr.fl', $fields['fulltext']); |
||
77 | // return the coordinates of highlighted search as absolute coordinates |
||
78 | $solrRequest->addParam('hl.ocr.absoluteHighlights', 'on'); |
||
79 | // max amount of snippets for a single page |
||
80 | $solrRequest->addParam('hl.snippets', 40); |
||
81 | // we store the fulltext on page level and can disable this option |
||
82 | $solrRequest->addParam('hl.ocr.trackPages', 'off'); |
||
83 | |||
84 | $response = $solr->service->executeRequest($solrRequest); |
||
85 | $result = $solr->service->createResult($query, $response); |
||
86 | /** @scrutinizer ignore-call */ |
||
87 | $output['numFound'] = $result->getNumFound(); |
||
88 | $data = $result->getData(); |
||
89 | $highlighting = $data['ocrHighlighting']; |
||
90 | |||
91 | foreach ($result as $record) { |
||
92 | $resultDocument = new ResultDocument($record, $highlighting, $fields); |
||
93 | |||
94 | $document = [ |
||
95 | 'id' => $resultDocument->getId(), |
||
96 | 'uid' => !empty($resultDocument->getUid()) ? $resultDocument->getUid() : $parameters['uid'], |
||
97 | 'page' => $resultDocument->getPage(), |
||
98 | 'snippet' => $resultDocument->getSnippets(), |
||
99 | 'highlight' => $resultDocument->getHighlightsIds() |
||
100 | ]; |
||
101 | $output['documents'][] = $document; |
||
102 | } |
||
103 | } |
||
104 | // Create response object. |
||
105 | /** @var Response $response */ |
||
106 | $response = GeneralUtility::makeInstance(Response::class); |
||
107 | $response->getBody()->write(json_encode($output)); |
||
108 | return $response; |
||
109 | } |
||
141 |