Kitodo\Dlf\Common\IiifManifest::establishRecordId()

Complexity

Conditions	6
Paths	9

Size

Total Lines	48
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function establishRecordId($pid)
    {
        if ($this->iiif !== null) {
            /*
             *  FIXME This will not consistently work because we can not be sure to have the pid at hand. It may miss
             *  if the plugin that actually loads the manifest allows content from other pages.
             *  Up until now the cPid is only set after the document has been initialized. We need it before to
             *  check the configuration.
             *  TODO Saving / indexing should still work - check!
             */
            $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
                ->getQueryBuilderForTable('tx_dlf_metadata');
            // Get hidden records, too.
            $queryBuilder
                ->getRestrictions()
                ->removeByType(HiddenRestriction::class);
            $result = $queryBuilder
                ->select('tx_dlf_metadataformat.xpath AS querypath')
                ->from('tx_dlf_metadata')
                ->from('tx_dlf_metadataformat')
                ->from('tx_dlf_formats')
                ->where(
                    $queryBuilder->expr()->eq('tx_dlf_metadata.pid', intval($pid)),
                    $queryBuilder->expr()->eq('tx_dlf_metadataformat.pid', intval($pid)),
                    $queryBuilder->expr()->orX(
                        $queryBuilder->expr()->andX(
                            $queryBuilder->expr()->eq('tx_dlf_metadata.uid', 'tx_dlf_metadataformat.parent_id'),
                            $queryBuilder->expr()->eq('tx_dlf_metadataformat.encoded', 'tx_dlf_formats.uid'),
                            $queryBuilder->expr()->eq('tx_dlf_metadata.index_name', $queryBuilder->createNamedParameter('record_id')),
                            $queryBuilder->expr()->eq('tx_dlf_formats.type', $queryBuilder->createNamedParameter($this->getIiifVersion()))
                        ),
                        $queryBuilder->expr()->eq('tx_dlf_metadata.format', 0)
                    )
                )
                ->execute();
            while ($resArray = $result->fetch()) {
                $recordIdPath = $resArray['querypath'];
                if (!empty($recordIdPath)) {
                    try {
                        $this->recordId = $this->iiif->jsonPath($recordIdPath);

The property recordId is declared read-only in Kitodo\Dlf\Common\IiifManifest.

It seems like $this->iiif->jsonPath($recordIdPath) can also be of type Ubl\Iiif\Presentation\Common\Model\Resources\ManifestInterface or Ubl\Iiif\Presentation\Common\Model\Resources\ManifestInterface&Ubl\Iiif\Presentation\V1\Model\Resources\AbstractIiifResource1 or Ubl\Iiif\Presentation\Common\Model\Resources\ManifestInterface&Ubl\Iiif\Presentation\V2\Model\Resources\AbstractIiifResource2 or Ubl\Iiif\Presentation\Common\Model\Resources\ManifestInterface&Ubl\Iiif\Presentation\V3\Model\Resources\AbstractIiifResource3. However, the property $recordId is declared as type string. Maybe add an additional type check?

                    } catch (\Exception $e) {
                        $this->logger->warning('Could not evaluate JSONPath to get IIIF record ID');

The method warning() does not exist on TYPO3\CMS\Core\Log\LogManager.

                    }
                }
            }
            // For now, it's a hardcoded ID, not only as a fallback
            if (!isset($this->recordId)) {
                $this->recordId = $this->iiif->getId();
            }