Passed
Pull Request — master (#123)
by
unknown
04:37
created
Classes/Task/BaseAdditionalFieldProvider.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
         if (isset($submittedData['doc']) && empty($submittedData['doc'])) {
64 64
             Helper::addMessage(
65
-                Helper::getLanguageService()->getLL('additionalFields.doc') . ' ' . Helper::getLanguageService()->getLL('additionalFields.valid'),
65
+                Helper::getLanguageService()->getLL('additionalFields.doc').' '.Helper::getLanguageService()->getLL('additionalFields.valid'),
66 66
                 $messageTitle,
67 67
                 $messageSeverity,
68 68
                 true,
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
         if ((isset($submittedData['pid']) && (int) $submittedData['pid'] <= 0) || !isset($submittedData['pid'])) {
75 75
             Helper::addMessage(
76
-                Helper::getLanguageService()->getLL('additionalFields.pid') . ' ' . Helper::getLanguageService()->getLL('additionalFields.valid'),
76
+                Helper::getLanguageService()->getLL('additionalFields.pid').' '.Helper::getLanguageService()->getLL('additionalFields.valid'),
77 77
                 $messageTitle,
78 78
                 $messageSeverity,
79 79
                 true,
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 
90 90
         if ((isset($submittedData['lib']) && (int) $submittedData['lib'] <= 0)) {
91 91
             Helper::addMessage(
92
-                Helper::getLanguageService()->getLL('additionalFields.lib') . ' ' . Helper::getLanguageService()->getLL('additionalFields.valid'),
92
+                Helper::getLanguageService()->getLL('additionalFields.lib').' '.Helper::getLanguageService()->getLL('additionalFields.valid'),
93 93
                 $messageTitle,
94 94
                 $messageSeverity,
95 95
                 true,
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
         if ((isset($submittedData['solr']) && (int) $submittedData['solr'] <= 0) || !isset($submittedData['solr'])) {
102 102
             Helper::addMessage(
103
-                Helper::getLanguageService()->getLL('additionalFields.solr') . ' ' . Helper::getLanguageService()->getLL('additionalFields.valid'),
103
+                Helper::getLanguageService()->getLL('additionalFields.solr').' '.Helper::getLanguageService()->getLL('additionalFields.valid'),
104 104
                 $messageTitle,
105 105
                 $messageSeverity,
106 106
                 true,
@@ -178,8 +178,8 @@  discard block
 block discarded – undo
178 178
     protected function getDryRunField(bool $dryRun): array
179 179
     {
180 180
         $fieldName = 'dryRun';
181
-        $fieldId = 'task_' . $fieldName;
182
-        $fieldHtml = '<input type="checkbox" name="tx_scheduler[' . $fieldName . ']" id="' . $fieldId . '" value="1"' . ($dryRun ? ' checked="checked"' : '') . '>';
181
+        $fieldId = 'task_'.$fieldName;
182
+        $fieldHtml = '<input type="checkbox" name="tx_scheduler['.$fieldName.']" id="'.$fieldId.'" value="1"'.($dryRun ? ' checked="checked"' : '').'>';
183 183
         return [
184 184
             'code' => $fieldHtml,
185 185
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_tasks.xlf:additionalFields.dryRun',
@@ -201,15 +201,15 @@  discard block
 block discarded – undo
201 201
     protected function getSolrField(int $solr, int $pid): array
202 202
     {
203 203
         $fieldName = 'solr';
204
-        $fieldId = 'task_' . $fieldName;
204
+        $fieldId = 'task_'.$fieldName;
205 205
 
206 206
         $allSolrCores = $this->getSolrCores($pid);
207 207
         $options = [];
208 208
         $options[] = '<option value="-1"></option>';
209 209
         foreach ($allSolrCores as $label => $uid) {
210
-            $options[] = '<option value="' . $uid . '" ' . ($solr == $uid ? 'selected' : '') . ' >' . $label . '</option>';
210
+            $options[] = '<option value="'.$uid.'" '.($solr == $uid ? 'selected' : '').' >'.$label.'</option>';
211 211
         };
212
-        $fieldHtml = '<select name="tx_scheduler[' . $fieldName . ']" id="' . $fieldId . '">' . implode("\n", $options) . '</select>';
212
+        $fieldHtml = '<select name="tx_scheduler['.$fieldName.']" id="'.$fieldId.'">'.implode("\n", $options).'</select>';
213 213
         return [
214 214
             'code' => $fieldHtml,
215 215
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_tasks.xlf:additionalFields.solr',
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
     protected function getPidField(int $pid): array
231 231
     {
232 232
         $fieldName = 'pid';
233
-        $fieldId = 'task_' . $fieldName;
233
+        $fieldId = 'task_'.$fieldName;
234 234
 
235 235
         $pageRepository = GeneralUtility::makeInstance(PageTreeRepository::class);
236 236
         $pages = $pageRepository->getTree(0);
@@ -238,11 +238,11 @@  discard block
 block discarded – undo
238 238
         $options = [];
239 239
         foreach ($pages['_children'] as $page) {
240 240
             if ($page['doktype'] == 254) {
241
-                $options[] = '<option value="' . $page['uid'] . '" ' . ($pid == $page['uid'] ? 'selected' : '') . ' >' . $page['title'] . '</option>';
241
+                $options[] = '<option value="'.$page['uid'].'" '.($pid == $page['uid'] ? 'selected' : '').' >'.$page['title'].'</option>';
242 242
             }
243 243
         }
244 244
 
245
-        $fieldHtml = '<select name="tx_scheduler[' . $fieldName . ']" id="' . $fieldId . '">' . implode("\n", $options) . '</select>';
245
+        $fieldHtml = '<select name="tx_scheduler['.$fieldName.']" id="'.$fieldId.'">'.implode("\n", $options).'</select>';
246 246
         return [
247 247
             'code' => $fieldHtml,
248 248
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_tasks.xlf:additionalFields.pid',
@@ -263,8 +263,8 @@  discard block
 block discarded – undo
263 263
     protected function getOwnerField(string $owner): array
264 264
     {
265 265
         $fieldName = 'owner';
266
-        $fieldId = 'task_' . $fieldName;
267
-        $fieldHtml = '<input type="text" name="tx_scheduler[' . $fieldName . ']" id="' . $fieldId . '" value="' . $owner . '" >';
266
+        $fieldId = 'task_'.$fieldName;
267
+        $fieldHtml = '<input type="text" name="tx_scheduler['.$fieldName.']" id="'.$fieldId.'" value="'.$owner.'" >';
268 268
         return [
269 269
             'code' => $fieldHtml,
270 270
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_tasks.xlf:additionalFields.owner',
Please login to merge, or discard this patch.
Classes/Task/ReindexAdditionalFieldProvider.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -63,10 +63,10 @@  discard block
 block discarded – undo
63 63
 
64 64
         // Select for collection(s)
65 65
         $fieldName = 'coll';
66
-        $fieldId = 'task_' . $fieldName;
66
+        $fieldId = 'task_'.$fieldName;
67 67
         $options = $this->getCollOptions($taskInfo['coll'], $taskInfo['pid']);
68 68
         ;
69
-        $fieldHtml = '<select name="tx_scheduler[' . $fieldName . '][]" id="' . $fieldId . '" size="10" multiple="multiple">' . implode("\n", $options) . '</select>';
69
+        $fieldHtml = '<select name="tx_scheduler['.$fieldName.'][]" id="'.$fieldId.'" size="10" multiple="multiple">'.implode("\n", $options).'</select>';
70 70
         $additionalFields[$fieldId] = [
71 71
             'code' => $fieldHtml,
72 72
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_tasks.xlf:additionalFields.coll',
@@ -85,9 +85,9 @@  discard block
 block discarded – undo
85 85
 
86 86
         // Checkbox for all
87 87
         $fieldName = 'all';
88
-        $fieldId = 'task_' . $fieldName;
89
-        $fieldHtml = '<input type="checkbox" name="tx_scheduler[' . $fieldName . ']" id="' . $fieldId . '" value="1"' .
90
-            ($taskInfo['all'] ? ' checked="checked"' : '') . '>';
88
+        $fieldId = 'task_'.$fieldName;
89
+        $fieldHtml = '<input type="checkbox" name="tx_scheduler['.$fieldName.']" id="'.$fieldId.'" value="1"'.
90
+            ($taskInfo['all'] ? ' checked="checked"' : '').'>';
91 91
         $additionalFields[$fieldId] = [
92 92
             'code' => $fieldHtml,
93 93
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_tasks.xlf:additionalFields.all',
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         $options = [];
112 112
         $collections = $this->getCollections($pid);
113 113
         foreach ($collections as $label => $uid) {
114
-            $options[] = '<option value="' . $uid . '" ' . (in_array($uid, $coll) ? 'selected' : '') . ' >' . $label . '</option>';
114
+            $options[] = '<option value="'.$uid.'" '.(in_array($uid, $coll) ? 'selected' : '').' >'.$label.'</option>';
115 115
         }
116 116
         return $options;
117 117
     }
Please login to merge, or discard this patch.
Classes/Controller/View3DController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
             $this->view->assign('is3DViewer', $this->is3dViewer($this->requestData['model']));
37 37
             $embedded3DViewerUrl = $this->buildEmbedded3dViewerUrl($this->requestData['model']);
38 38
             if (!empty($this->requestData['viewer'])) {
39
-                $embedded3DViewerUrl .= '&viewer=' . $this->requestData['viewer'];
39
+                $embedded3DViewerUrl .= '&viewer='.$this->requestData['viewer'];
40 40
             }
41 41
             $this->view->assign('embedded3DViewerUrl', $embedded3DViewerUrl);
42 42
             return;
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
      */
73 73
     public function buildEmbedded3dViewerUrl(string $model): string
74 74
     {
75
-        return self::MIDDLEWARE_DLF_EMBEDDED_3D_VIEWER_PREFIX . '&model=' . $model;
75
+        return self::MIDDLEWARE_DLF_EMBEDDED_3D_VIEWER_PREFIX.'&model='.$model;
76 76
     }
77 77
 
78 78
 
Please login to merge, or discard this patch.
Classes/Middleware/Embedded3DViewer.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
         $modelInfo = PathUtility::pathinfo($parameters['model']);
70 70
         $modelFormat = $modelInfo["extension"];
71 71
         if (empty($modelFormat)) {
72
-            return $this->warningResponse('Model path "' . $parameters['model'] . '" has no extension format', $request);
72
+            return $this->warningResponse('Model path "'.$parameters['model'].'" has no extension format', $request);
73 73
         }
74 74
 
75 75
         if (empty($parameters['viewer'])) {
@@ -88,30 +88,30 @@  discard block
 block discarded – undo
88 88
         $defaultStorage = $storageRepository->getDefaultStorage();
89 89
 
90 90
         if (!$defaultStorage->hasFolder(self::VIEWER_FOLDER)) {
91
-            return $this->errorResponse('Required folder "' . self::VIEWER_FOLDER . '" was not found in the default storage "' . $defaultStorage->getName() . '"', $request);
91
+            return $this->errorResponse('Required folder "'.self::VIEWER_FOLDER.'" was not found in the default storage "'.$defaultStorage->getName().'"', $request);
92 92
         }
93 93
 
94 94
         $viewerModules = $defaultStorage->getFolder(self::VIEWER_FOLDER);
95 95
         if (!$viewerModules->hasFolder($viewer)) {
96
-            return $this->errorResponse('Viewer folder "' . $viewer . '" was not found under the folder "' . self::VIEWER_FOLDER . '"', $request);
96
+            return $this->errorResponse('Viewer folder "'.$viewer.'" was not found under the folder "'.self::VIEWER_FOLDER.'"', $request);
97 97
         }
98 98
 
99 99
         $viewerFolder = $viewerModules->getSubfolder($viewer);
100 100
         if (!$viewerFolder->hasFile(self::VIEWER_CONFIG_YML)) {
101
-            return $this->errorResponse('Viewer folder "' . $viewer . '" does not contain a file named "' . self::VIEWER_CONFIG_YML . '"', $request);
101
+            return $this->errorResponse('Viewer folder "'.$viewer.'" does not contain a file named "'.self::VIEWER_CONFIG_YML.'"', $request);
102 102
         }
103 103
 
104 104
         /** @var YamlFileLoader $yamlFileLoader */
105 105
         $yamlFileLoader = GeneralUtility::makeInstance(YamlFileLoader::class);
106
-        $viewerConfigPath = $defaultStorage->getName() . "/" . self::VIEWER_FOLDER . "/" . $viewer . "/";
107
-        $config = $yamlFileLoader->load($viewerConfigPath . self::VIEWER_CONFIG_YML)["viewer"];
106
+        $viewerConfigPath = $defaultStorage->getName()."/".self::VIEWER_FOLDER."/".$viewer."/";
107
+        $config = $yamlFileLoader->load($viewerConfigPath.self::VIEWER_CONFIG_YML)["viewer"];
108 108
 
109 109
         if (!isset($config["supportedModelFormats"]) || empty($config["supportedModelFormats"])) {
110
-            return $this->errorResponse('Required key "supportedModelFormats" does not exist in the file "' . self::VIEWER_CONFIG_YML . '" of viewer "' . $viewer . '" or has no value', $request);
110
+            return $this->errorResponse('Required key "supportedModelFormats" does not exist in the file "'.self::VIEWER_CONFIG_YML.'" of viewer "'.$viewer.'" or has no value', $request);
111 111
         }
112 112
 
113 113
         if (array_search(strtolower($modelFormat), array_map('strtolower', $config["supportedModelFormats"])) === false) {
114
-            return $this->warningResponse('Viewer "' . $viewer . '" does not support the model format "' . $modelFormat . '"', $request);
114
+            return $this->warningResponse('Viewer "'.$viewer.'" does not support the model format "'.$modelFormat.'"', $request);
115 115
         }
116 116
 
117 117
         $html = $this->getViewerHtml($config, $viewerConfigPath, $viewerFolder, $parameters['model'], $modelInfo);
Please login to merge, or discard this patch.
Classes/ExpressionLanguage/DocumentTypeFunctionProvider.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
                 if ($this->document) {
178 178
                     $doc = AbstractDocument::getInstance($this->document->getLocation(), ['storagePid' => $pid], true);
179 179
                 } else {
180
-                    $this->logger->error('Invalid UID "' . $requestData['id'] . '" or PID "' . $pid . '" for document loading');
180
+                    $this->logger->error('Invalid UID "'.$requestData['id'].'" or PID "'.$pid.'" for document loading');
181 181
                 }
182 182
             } elseif (GeneralUtility::isValidUrl($requestData['id'])) {
183 183
                 $doc = AbstractDocument::getInstance($requestData['id'], ['storagePid' => $pid], true);
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
                     }
192 192
                     $this->document->setLocation($requestData['id']);
193 193
                 } else {
194
-                    $this->logger->error('Invalid location given "' . $requestData['id'] . '" for document loading');
194
+                    $this->logger->error('Invalid location given "'.$requestData['id'].'" for document loading');
195 195
                 }
196 196
             }
197 197
             if ($this->document !== null && $doc !== null) {
@@ -204,11 +204,11 @@  discard block
 block discarded – undo
204 204
                 if ($doc !== null) {
205 205
                     $this->document->setCurrentDocument($doc);
206 206
                 } else {
207
-                    $this->logger->error('Failed to load document with record ID "' . $requestData['recordId'] . '"');
207
+                    $this->logger->error('Failed to load document with record ID "'.$requestData['recordId'].'"');
208 208
                 }
209 209
             }
210 210
         } else {
211
-            $this->logger->error('Empty UID or invalid PID "' . $pid . '" for document loading');
211
+            $this->logger->error('Empty UID or invalid PID "'.$pid.'" for document loading');
212 212
         }
213 213
     }
214 214
 }
Please login to merge, or discard this patch.
Classes/Controller/NavigationController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
         $pageOptions = [];
106 106
         for ($i = 1; $i <= $this->document->getCurrentDocument()->numPages; $i++) {
107 107
             $orderLabel = $this->document->getCurrentDocument()->physicalStructureInfo[$this->document->getCurrentDocument()->physicalStructure[$i]]['orderlabel'];
108
-            $pageOptions[$i] = '[' . $i . ']' . ($orderLabel ? ' - ' . htmlspecialchars($orderLabel) : '');
108
+            $pageOptions[$i] = '['.$i.']'.($orderLabel ? ' - '.htmlspecialchars($orderLabel) : '');
109 109
         }
110 110
 
111 111
         $this->view->assign('pageOptions', $pageOptions);
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
                 $measureOptions = [];
123 123
                 $measurePages = [];
124 124
                 for ($i = 1; $i <= $this->document->getCurrentDocument()->numMeasures; $i++) {
125
-                    $measureOptions[$i] = '[' . $i . ']' . ($this->document->getCurrentDocument()->musicalStructureInfo[$this->document->getCurrentDocument()->musicalStructure[$i]['measureid']]['orderlabel'] ? ' - ' . htmlspecialchars($this->document->getCurrentDocument()->musicalStructureInfo[$this->document->getCurrentDocument()->musicalStructureInfo[$i]]['orderlabel']) : '');
125
+                    $measureOptions[$i] = '['.$i.']'.($this->document->getCurrentDocument()->musicalStructureInfo[$this->document->getCurrentDocument()->musicalStructure[$i]['measureid']]['orderlabel'] ? ' - '.htmlspecialchars($this->document->getCurrentDocument()->musicalStructureInfo[$this->document->getCurrentDocument()->musicalStructureInfo[$i]]['orderlabel']) : '');
126 126
                     $measurePages[$i] = $this->document->getCurrentDocument()->musicalStructure[$i]['page'];
127 127
                 }
128 128
 
Please login to merge, or discard this patch.
Classes/Controller/ToolboxController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
                         $this->renderToolByName('renderScoreTool');
103 103
                         break;
104 104
                     default:
105
-                        $this->logger->warning('Incorrect tool configuration: "' . $this->settings['tools'] . '". Tool "' . $tool . '" does not exist.');
105
+                        $this->logger->warning('Incorrect tool configuration: "'.$this->settings['tools'].'". Tool "'.$tool.'" does not exist.');
106 106
                 }
107 107
             }
108 108
         }
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
                 }
302 302
                 break;
303 303
             } else {
304
-                $this->logger->warning('File not found in fileGrp "' . $fileGrp . '"');
304
+                $this->logger->warning('File not found in fileGrp "'.$fileGrp.'"');
305 305
             }
306 306
         }
307 307
         return $image;
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
385 385
             empty($firstPageLink)
386 386
             && empty($secondPageLink)
387 387
         ) {
388
-            $this->logger->warning('File not found in fileGrps "' . $this->extConf['files']['fileGrpDownload'] . '"');
388
+            $this->logger->warning('File not found in fileGrps "'.$this->extConf['files']['fileGrpDownload'].'"');
389 389
         }
390 390
 
391 391
         if (!empty($firstPageLink)) {
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
423 423
             }
424 424
         }
425 425
         if (empty($workLink)) {
426
-            $this->logger->warning('File not found in fileGrps "' . $this->extConf['files']['fileGrpDownload'] . '"');
426
+            $this->logger->warning('File not found in fileGrps "'.$this->extConf['files']['fileGrpDownload'].'"');
427 427
         }
428 428
         return $workLink;
429 429
     }
Please login to merge, or discard this patch.
Classes/Controller/AbstractController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -158,11 +158,11 @@  discard block
 block discarded – undo
158 158
                 if ($doc !== null) {
159 159
                     $this->document->setCurrentDocument($doc);
160 160
                 } else {
161
-                    $this->logger->error('Failed to load document with record ID "' . $this->requestData['recordId'] . '"');
161
+                    $this->logger->error('Failed to load document with record ID "'.$this->requestData['recordId'].'"');
162 162
                 }
163 163
             }
164 164
         } else {
165
-            $this->logger->error('Invalid ID "' . $documentId . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
165
+            $this->logger->error('Invalid ID "'.$documentId.'" or PID "'.$this->settings['storagePid'].'" for document loading');
166 166
         }
167 167
     }
168 168
 
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
             && !MathUtility::canBeInterpretedAsInteger($this->requestData['id'])
260 260
             && !GeneralUtility::isValidUrl($this->requestData['id'])
261 261
         ) {
262
-            $this->logger->warning('Invalid ID or URI "' . $this->requestData['id'] . '" for document loading');
262
+            $this->logger->warning('Invalid ID or URI "'.$this->requestData['id'].'" for document loading');
263 263
             unset($this->requestData['id']);
264 264
         }
265 265
 
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
         $pages = [];
356 356
         $pagesSect = [];
357 357
         $aRange = [];
358
-        $nRange = 5;    // ToDo: should be made configurable
358
+        $nRange = 5; // ToDo: should be made configurable
359 359
 
360 360
         // lower limit of the range
361 361
         $nBottom = $currentPageNumber - $nRange;
@@ -370,7 +370,7 @@  discard block
 block discarded – undo
370 370
 
371 371
         // check whether the first screen page is > 1, if yes then points must be added
372 372
         if ($aRange[0] > 1) {
373
-            array_push($pagesSect, ['label' => '...','startRecordNumber' => '...']);
373
+            array_push($pagesSect, ['label' => '...', 'startRecordNumber' => '...']);
374 374
         };
375 375
         $lastStartRecordNumberGrid = 0; // due to validity outside the loop
376 376
         foreach (range($firstPage, $lastPage) as $i) {
@@ -413,7 +413,7 @@  discard block
 block discarded – undo
413 413
 
414 414
                 // Check if screen page is in range
415 415
                 if (in_array($i, $aRange)) {
416
-                    array_push($pagesSect, ['label' => $i,'startRecordNumber' => $startRecordNumber]);
416
+                    array_push($pagesSect, ['label' => $i, 'startRecordNumber' => $startRecordNumber]);
417 417
                 };
418 418
             };
419 419
         };
@@ -476,7 +476,7 @@  discard block
 block discarded – undo
476 476
         if ($this->document) {
477 477
             $doc = AbstractDocument::getInstance($this->document->getLocation(), $this->settings, true);
478 478
         } else {
479
-            $this->logger->error('Invalid UID "' . $documentId . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
479
+            $this->logger->error('Invalid UID "'.$documentId.'" or PID "'.$this->settings['storagePid'].'" for document loading');
480 480
         }
481 481
 
482 482
         return $doc;
@@ -514,7 +514,7 @@  discard block
 block discarded – undo
514 514
             foreach ($this->requestData['multipleSource'] as $location) {
515 515
                 $document = AbstractDocument::getInstance($location, $this->settings, true);
516 516
                 if ($document !== null) {
517
-                    $this->documentArray['extra_' . $i] = $document;
517
+                    $this->documentArray['extra_'.$i] = $document;
518 518
                 }
519 519
                 $i++;
520 520
             }
@@ -538,7 +538,7 @@  discard block
 block discarded – undo
538 538
 
539 539
             $this->document->setLocation($documentId);
540 540
         } else {
541
-            $this->logger->error('Invalid location given "' . $documentId . '" for document loading');
541
+            $this->logger->error('Invalid location given "'.$documentId.'" for document loading');
542 542
         }
543 543
 
544 544
         return $doc;
Please login to merge, or discard this patch.
Classes/Controller/PageViewController.php 1 patch
Spacing   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -181,18 +181,18 @@  discard block
 block discarded – undo
181 181
             }
182 182
 
183 183
             $navigationArray[$i]['next'] = [
184
-                'tx_dlf[docPage][' . $i . ']' =>
184
+                'tx_dlf[docPage]['.$i.']' =>
185 185
                     MathUtility::forceIntegerInRange((int) $this->requestData['docPage'][$i] + 1, 1, $document->numPages, 1)
186 186
             ];
187 187
             $navigationArray[$i]['prev'] = [
188
-                'tx_dlf[docPage][' . $i . ']' =>
188
+                'tx_dlf[docPage]['.$i.']' =>
189 189
                     MathUtility::forceIntegerInRange((int) $this->requestData['docPage'][$i] - 1, 1, $document->numPages, 1)
190 190
             ];
191 191
 
192 192
             $navigateAllPageNext = array_merge(
193 193
                 $navigateAllPageNext,
194 194
                 [
195
-                    'tx_dlf[docPage][' . $i . ']' =>
195
+                    'tx_dlf[docPage]['.$i.']' =>
196 196
                         MathUtility::forceIntegerInRange((int) $this->requestData['docPage'][$i] + 1, 1, $document->numPages, 1)
197 197
                 ]
198 198
             );
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
             $navigateAllPagePrev = array_merge(
201 201
                 $navigateAllPagePrev,
202 202
                 [
203
-                    'tx_dlf[docPage][' . $i . ']' =>
203
+                    'tx_dlf[docPage]['.$i.']' =>
204 204
                         MathUtility::forceIntegerInRange((int) $this->requestData['docPage'][$i] - 1, 1, $document->numPages, 1)
205 205
                 ]
206 206
             );
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
             $navigateAllMeasureNext = array_merge(
209 209
                 $navigateAllMeasureNext,
210 210
                 [
211
-                    'tx_dlf[docMeasure][' . $i . ']' =>
211
+                    'tx_dlf[docMeasure]['.$i.']' =>
212 212
                         MathUtility::forceIntegerInRange((int) $this->requestData['docMeasure'][$i] + 1, 1, $document->numMeasures, 1)
213 213
                 ]
214 214
             );
@@ -216,19 +216,19 @@  discard block
 block discarded – undo
216 216
             $navigateAllMeasurePrev = array_merge(
217 217
                 $navigateAllMeasurePrev,
218 218
                 [
219
-                    'tx_dlf[docMeasure][' . $i . ']' =>
219
+                    'tx_dlf[docMeasure]['.$i.']' =>
220 220
                         MathUtility::forceIntegerInRange((int) $this->requestData['docMeasure'][$i] - 1, 1, $document->numMeasures, 1)
221 221
                 ]
222 222
             );
223 223
 
224 224
             if ($document->numMeasures > 0) {
225 225
                 $navigationMeasureArray[$i]['next'] = [
226
-                    'tx_dlf[docMeasure][' . $i . ']' =>
226
+                    'tx_dlf[docMeasure]['.$i.']' =>
227 227
                         MathUtility::forceIntegerInRange((int) $this->requestData['docMeasure'][$i] + 1, 1, $document->numMeasures, 1)
228 228
                 ];
229 229
 
230 230
                 $navigationMeasureArray[$i]['prev'] = [
231
-                    'tx_dlf[docMeasure][' . $i . ']' =>
231
+                    'tx_dlf[docMeasure]['.$i.']' =>
232 232
                         MathUtility::forceIntegerInRange((int) $this->requestData['docMeasure'][$i] - 1, 1, $document->numMeasures, 1)
233 233
                 ];
234 234
             }
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
             }
283 283
             $params = array_merge(
284 284
                 ['tx_dlf' => $this->requestData],
285
-                ['tx_dlf[multipleSource][' . $nextMultipleSourceKey . ']' => $formAddDocument->getLocation()],
285
+                ['tx_dlf[multipleSource]['.$nextMultipleSourceKey.']' => $formAddDocument->getLocation()],
286 286
                 ['tx_dlf[multiview]' => 1]
287 287
             );
288 288
             $uriBuilder = $this->uriBuilder;
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
                             // build link for each measure
330 330
                             $params = [
331 331
                                 'tx_dlf' => $this->requestData,
332
-                                'tx_dlf[docMeasure][' . $docNumber . ']' => $i
332
+                                'tx_dlf[docMeasure]['.$docNumber.']' => $i
333 333
                             ];
334 334
                         } else {
335 335
                             // build link for each measure
@@ -413,7 +413,7 @@  discard block
 block discarded – undo
413 413
         }
414 414
 
415 415
         if (empty($score)) {
416
-            $this->logger->notice('No score file found for page "' . $page . '" in fileGrps "' . $this->settings['fileGrpScore'] . '"');
416
+            $this->logger->notice('No score file found for page "'.$page.'" in fileGrps "'.$this->settings['fileGrpScore'].'"');
417 417
         }
418 418
         return $score;
419 419
     }
@@ -444,11 +444,11 @@  discard block
 block discarded – undo
444 444
                 $fulltext['mimetype'] = $file['mimeType'];
445 445
                 break;
446 446
             } else {
447
-                $this->logger->notice('No full-text file found for page "' . $page . '" in fileGrp "' . $fileGrpFulltext . '"');
447
+                $this->logger->notice('No full-text file found for page "'.$page.'" in fileGrp "'.$fileGrpFulltext.'"');
448 448
             }
449 449
         }
450 450
         if (empty($fulltext)) {
451
-            $this->logger->notice('No full-text file found for page "' . $page . '" in fileGrps "' . $this->extConf['files']['fileGrpFulltext'] . '"');
451
+            $this->logger->notice('No full-text file found for page "'.$page.'" in fileGrps "'.$this->extConf['files']['fileGrpFulltext'].'"');
452 452
         }
453 453
         return $fulltext;
454 454
     }
@@ -493,19 +493,19 @@  discard block
 block discarded – undo
493 493
                         $currentMeasureId = $docMeasures['measureCounterToMeasureId'][$this->requestData['docMeasure'][$i]];
494 494
                     }
495 495
 
496
-                    $jsViewer .= 'tx_dlf_viewer[' . $i . '] = new dlfViewer({
497
-                                controls: ["' . implode('", "', $this->controls) . '"],
498
-                                div: "tx-dfgviewer-map-' . $i . '",
499
-                                progressElementId: "' . $this->settings['progressElementId'] . '",
500
-                                counter: "' . $i . '",
501
-                                images: ' . json_encode($docImage) . ',
502
-                                fulltexts: ' . json_encode($docFulltext) . ',
503
-                                score: ' . json_encode($docScore) . ',
504
-                                annotationContainers: ' . json_encode($docAnnotationContainers) . ',
505
-                                measureCoords: ' . json_encode($docMeasures['measureCoordsCurrentSite']) . ',
506
-                                useInternalProxy: ' . ($this->settings['useInternalProxy'] ? 1 : 0) . ',
507
-                                currentMeasureId: "' . $currentMeasureId . '",
508
-                                measureIdLinks: ' . json_encode($docMeasures['measureLinks']) . '
496
+                    $jsViewer .= 'tx_dlf_viewer['.$i.'] = new dlfViewer({
497
+                                controls: ["' . implode('", "', $this->controls).'"],
498
+                                div: "tx-dfgviewer-map-' . $i.'",
499
+                                progressElementId: "' . $this->settings['progressElementId'].'",
500
+                                counter: "' . $i.'",
501
+                                images: ' . json_encode($docImage).',
502
+                                fulltexts: ' . json_encode($docFulltext).',
503
+                                score: ' . json_encode($docScore).',
504
+                                annotationContainers: ' . json_encode($docAnnotationContainers).',
505
+                                measureCoords: ' . json_encode($docMeasures['measureCoordsCurrentSite']).',
506
+                                useInternalProxy: ' . ($this->settings['useInternalProxy'] ? 1 : 0).',
507
+                                currentMeasureId: "' . $currentMeasureId.'",
508
+                                measureIdLinks: ' . json_encode($docMeasures['measureLinks']).'
509 509
                             });
510 510
                             ';
511 511
                     $i++;
@@ -515,8 +515,8 @@  discard block
 block discarded – undo
515 515
             // Viewer configuration.
516 516
             $viewerConfiguration = '$(document).ready(function() {
517 517
                     if (dlfUtils.exists(dlfViewer)) {
518
-                        ' . $jsViewer . '
519
-                        viewerCount = ' . ($i - 1) . ';
518
+                        ' . $jsViewer.'
519
+                        viewerCount = ' . ($i - 1).';
520 520
                     }
521 521
                 });';
522 522
         } else {
@@ -532,18 +532,18 @@  discard block
 block discarded – undo
532 532
             $viewerConfiguration = '$(document).ready(function() {
533 533
                     if (dlfUtils.exists(dlfViewer)) {
534 534
                         tx_dlf_viewer = new dlfViewer({
535
-                            controls: ["' . implode('", "', $this->controls) . '"],
536
-                            div: "' . $this->settings['elementId'] . '",
537
-                            progressElementId: "' . $this->settings['progressElementId'] . '",
538
-                            images: ' . json_encode($this->images) . ',
539
-                            fulltexts: ' . json_encode($this->fulltexts) . ',
540
-                            score: ' . json_encode($this->scores) . ',
541
-                            annotationContainers: ' . json_encode($this->annotationContainers) . ',
542
-                            measureCoords: ' . json_encode($docMeasures['measureCoordsCurrentSite']) . ',
543
-                            useInternalProxy: ' . ($this->settings['useInternalProxy'] ? 1 : 0) . ',
544
-                            verovioAnnotations: ' . json_encode($this->verovioAnnotations) . ',
545
-                            currentMeasureId: "' . $currentMeasureId . '",
546
-                            measureIdLinks: ' . json_encode($docMeasures['measureLinks']) . '
535
+                            controls: ["' . implode('", "', $this->controls).'"],
536
+                            div: "' . $this->settings['elementId'].'",
537
+                            progressElementId: "' . $this->settings['progressElementId'].'",
538
+                            images: ' . json_encode($this->images).',
539
+                            fulltexts: ' . json_encode($this->fulltexts).',
540
+                            score: ' . json_encode($this->scores).',
541
+                            annotationContainers: ' . json_encode($this->annotationContainers).',
542
+                            measureCoords: ' . json_encode($docMeasures['measureCoordsCurrentSite']).',
543
+                            useInternalProxy: ' . ($this->settings['useInternalProxy'] ? 1 : 0).',
544
+                            verovioAnnotations: ' . json_encode($this->verovioAnnotations).',
545
+                            currentMeasureId: "' . $currentMeasureId.'",
546
+                            measureIdLinks: ' . json_encode($docMeasures['measureLinks']).'
547 547
                         });
548 548
                     }
549 549
                 });';
@@ -640,7 +640,7 @@  discard block
 block discarded – undo
640 640
                     }
641 641
                     break;
642 642
                 } else {
643
-                    $this->logger->notice('No image file found for page "' . $page . '" in fileGrp "' . $fileGrpImages . '"');
643
+                    $this->logger->notice('No image file found for page "'.$page.'" in fileGrp "'.$fileGrpImages.'"');
644 644
                 }
645 645
 
646 646
             } else {
@@ -660,12 +660,12 @@  discard block
 block discarded – undo
660 660
                     }
661 661
                     break;
662 662
                 } else {
663
-                    $this->logger->notice('No image file found for page "' . $page . '" in fileGrp "' . $fileGrpImages . '"');
663
+                    $this->logger->notice('No image file found for page "'.$page.'" in fileGrp "'.$fileGrpImages.'"');
664 664
                 }
665 665
             }
666 666
         }
667 667
         if (empty($image)) {
668
-            $this->logger->warning('No image file found for page "' . $page . '" in fileGrps "' . $this->extConf['files']['fileGrpImages'] . '"');
668
+            $this->logger->warning('No image file found for page "'.$page.'" in fileGrps "'.$this->extConf['files']['fileGrpImages'].'"');
669 669
         }
670 670
         return $image;
671 671
     }
Please login to merge, or discard this patch.