Passed
Pull Request — master (#123)
by Sebastian
03:43
created
Classes/Common/Solr.php 1 patch
Braces   +21 added lines, -42 removed lines patch added patch discarded remove patch
@@ -37,8 +37,7 @@  discard block
 block discarded – undo
37 37
  * @property-read bool $ready Is the Solr service instantiated successfully?
38 38
  * @property-read \Solarium\Client $service This holds the Solr service object
39 39
  */
40
-class Solr implements LoggerAwareInterface
41
-{
40
+class Solr implements LoggerAwareInterface {
42 41
     use LoggerAwareTrait;
43 42
 
44 43
     /**
@@ -130,8 +129,7 @@  discard block
 block discarded – undo
130 129
      *
131 130
      * @return string The name of the new core
132 131
      */
133
-    public static function createCore($core = '')
134
-    {
132
+    public static function createCore($core = '') {
135 133
         // Get next available core name if none given.
136 134
         if (empty($core)) {
137 135
             $core = 'dlfCore' . self::getNextCoreNumber();
@@ -178,8 +176,7 @@  discard block
 block discarded – undo
178 176
      *
179 177
      * @return string The escaped query string
180 178
      */
181
-    public static function escapeQuery($query)
182
-    {
179
+    public static function escapeQuery($query) {
183 180
         $helper = GeneralUtility::makeInstance(\Solarium\Core\Query\Helper::class);
184 181
         // Escape query phrase or term.
185 182
         if (preg_match('/^".*"$/', $query)) {
@@ -202,8 +199,7 @@  discard block
 block discarded – undo
202 199
      *
203 200
      * @return string The escaped query string
204 201
      */
205
-    public static function escapeQueryKeepField($query, $pid)
206
-    {
202
+    public static function escapeQueryKeepField($query, $pid) {
207 203
         // Is there a field query?
208 204
         if (preg_match('/^[[:alnum:]]+_[tu][su]i:\(?.*\)?$/', $query)) {
209 205
             $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
@@ -253,8 +249,7 @@  discard block
 block discarded – undo
253 249
      *
254 250
      * @return array fields
255 251
      */
256
-    public static function getFields()
257
-    {
252
+    public static function getFields() {
258 253
         $conf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get(self::$extKey);
259 254
 
260 255
         $fields = [];
@@ -296,8 +291,7 @@  discard block
 block discarded – undo
296 291
      *
297 292
      * @return \Kitodo\Dlf\Common\Solr Instance of this class
298 293
      */
299
-    public static function getInstance($core = null)
300
-    {
294
+    public static function getInstance($core = null) {
301 295
         // Get core name if UID is given.
302 296
         if (MathUtility::canBeInterpretedAsInteger($core)) {
303 297
             $core = Helper::getIndexNameFromUid($core, 'tx_dlf_solrcores');
@@ -337,8 +331,7 @@  discard block
 block discarded – undo
337 331
      *
338 332
      * @return int First unused core number found
339 333
      */
340
-    public static function getNextCoreNumber($number = 0)
341
-    {
334
+    public static function getNextCoreNumber($number = 0) {
342 335
         $number = max(intval($number), 0);
343 336
         // Check if core already exists.
344 337
         $solr = self::getInstance('dlfCore' . $number);
@@ -356,8 +349,7 @@  discard block
 block discarded – undo
356 349
      *
357 350
      * @return void
358 351
      */
359
-    protected function loadSolrConnectionInfo()
360
-    {
352
+    protected function loadSolrConnectionInfo() {
361 353
         if (empty($this->config)) {
362 354
             $config = [];
363 355
             // Extract extension configuration.
@@ -397,8 +389,7 @@  discard block
 block discarded – undo
397 389
      *
398 390
      * @return array The Apache Solr Documents that were fetched
399 391
      */
400
-    public function search_raw($parameters = [])
401
-    {
392
+    public function search_raw($parameters = []) {
402 393
         // Set additional query parameters.
403 394
         $parameters['start'] = 0;
404 395
         $parameters['rows'] = $this->limit;
@@ -428,8 +419,7 @@  discard block
 block discarded – undo
428 419
      *
429 420
      * @return string|null The core name of the current query endpoint or null if core admin endpoint
430 421
      */
431
-    protected function _getCore()
432
-    {
422
+    protected function _getCore() {
433 423
         return $this->core;
434 424
     }
435 425
 
@@ -440,8 +430,7 @@  discard block
 block discarded – undo
440 430
      *
441 431
      * @return int The max number of results
442 432
      */
443
-    protected function _getLimit()
444
-    {
433
+    protected function _getLimit() {
445 434
         return $this->limit;
446 435
     }
447 436
 
@@ -452,8 +441,7 @@  discard block
 block discarded – undo
452 441
      *
453 442
      * @return int Total number of hits for last search
454 443
      */
455
-    protected function _getNumberOfHits()
456
-    {
444
+    protected function _getNumberOfHits() {
457 445
         return $this->numberOfHits;
458 446
     }
459 447
 
@@ -464,8 +452,7 @@  discard block
 block discarded – undo
464 452
      *
465 453
      * @return bool Is the search instantiated successfully?
466 454
      */
467
-    protected function _getReady()
468
-    {
455
+    protected function _getReady() {
469 456
         return $this->ready;
470 457
     }
471 458
 
@@ -476,8 +463,7 @@  discard block
 block discarded – undo
476 463
      *
477 464
      * @return \Solarium\Client Apache Solr service object
478 465
      */
479
-    protected function _getService()
480
-    {
466
+    protected function _getService() {
481 467
         return $this->service;
482 468
     }
483 469
 
@@ -490,8 +476,7 @@  discard block
 block discarded – undo
490 476
      *
491 477
      * @return void
492 478
      */
493
-    protected function _setCPid($value)
494
-    {
479
+    protected function _setCPid($value) {
495 480
         $this->cPid = max(intval($value), 0);
496 481
     }
497 482
 
@@ -504,8 +489,7 @@  discard block
 block discarded – undo
504 489
      *
505 490
      * @return void
506 491
      */
507
-    protected function _setLimit($value)
508
-    {
492
+    protected function _setLimit($value) {
509 493
         $this->limit = max(intval($value), 0);
510 494
     }
511 495
 
@@ -518,8 +502,7 @@  discard block
 block discarded – undo
518 502
      *
519 503
      * @return void
520 504
      */
521
-    protected function _setParams(array $value)
522
-    {
505
+    protected function _setParams(array $value) {
523 506
         $this->params = $value;
524 507
     }
525 508
 
@@ -532,8 +515,7 @@  discard block
 block discarded – undo
532 515
      *
533 516
      * @return mixed Value of $this->$var
534 517
      */
535
-    public function __get($var)
536
-    {
518
+    public function __get($var) {
537 519
         $method = '_get' . ucfirst($var);
538 520
         if (
539 521
             !property_exists($this, $var)
@@ -555,8 +537,7 @@  discard block
 block discarded – undo
555 537
      *
556 538
      * @return bool true if variable is set and not empty, false otherwise
557 539
      */
558
-    public function __isset($var)
559
-    {
540
+    public function __isset($var) {
560 541
         return !empty($this->__get($var));
561 542
     }
562 543
 
@@ -570,8 +551,7 @@  discard block
 block discarded – undo
570 551
      *
571 552
      * @return void
572 553
      */
573
-    public function __set($var, $value)
574
-    {
554
+    public function __set($var, $value) {
575 555
         $method = '_set' . ucfirst($var);
576 556
         if (
577 557
             !property_exists($this, $var)
@@ -592,8 +572,7 @@  discard block
 block discarded – undo
592 572
      *
593 573
      * @return void
594 574
      */
595
-    protected function __construct($core)
596
-    {
575
+    protected function __construct($core) {
597 576
         // Get Solr connection parameters from configuration.
598 577
         $this->loadSolrConnectionInfo();
599 578
         // Configure connection adapter.
Please login to merge, or discard this patch.
Classes/Common/SolrSearchResult/ResultDocument.php 1 patch
Braces   +19 added lines, -38 removed lines patch added patch discarded remove patch
@@ -24,8 +24,7 @@  discard block
 block discarded – undo
24 24
  * @subpackage dlf
25 25
  * @access public
26 26
  */
27
-class ResultDocument
28
-{
27
+class ResultDocument {
29 28
 
30 29
     /**
31 30
      * The identifier
@@ -134,8 +133,7 @@  discard block
 block discarded – undo
134 133
      *
135 134
      * @return void
136 135
      */
137
-    public function __construct($record, $highlighting, $fields)
138
-    {
136
+    public function __construct($record, $highlighting, $fields) {
139 137
         $this->id = $record[$fields['id']];
140 138
         $this->uid = $record[$fields['uid']];
141 139
         $this->page = $record[$fields['page']];
@@ -160,8 +158,7 @@  discard block
 block discarded – undo
160 158
      *
161 159
      * @return string The result's record identifier
162 160
      */
163
-    public function getId()
164
-    {
161
+    public function getId() {
165 162
         return $this->id;
166 163
     }
167 164
 
@@ -172,8 +169,7 @@  discard block
 block discarded – undo
172 169
      *
173 170
      * @return string|null The result's record unified identifier
174 171
      */
175
-    public function getUid()
176
-    {
172
+    public function getUid() {
177 173
         return $this->uid;
178 174
     }
179 175
 
@@ -184,8 +180,7 @@  discard block
 block discarded – undo
184 180
      *
185 181
      * @return int The result's record page
186 182
      */
187
-    public function getPage()
188
-    {
183
+    public function getPage() {
189 184
         return $this->page;
190 185
     }
191 186
 
@@ -196,8 +191,7 @@  discard block
 block discarded – undo
196 191
      *
197 192
      * @return string All result's record snippets imploded to one string
198 193
      */
199
-    public function getSnippets()
200
-    {
194
+    public function getSnippets() {
201 195
         return $this->snippets;
202 196
     }
203 197
 
@@ -208,8 +202,7 @@  discard block
 block discarded – undo
208 202
      *
209 203
      * @return string
210 204
      */
211
-    public function getThumbnail()
212
-    {
205
+    public function getThumbnail() {
213 206
         return $this->thumbnail;
214 207
     }
215 208
 
@@ -220,8 +213,7 @@  discard block
 block discarded – undo
220 213
      *
221 214
      * @return string
222 215
      */
223
-    public function getTitle()
224
-    {
216
+    public function getTitle() {
225 217
         return $this->title;
226 218
     }
227 219
 
@@ -232,8 +224,7 @@  discard block
 block discarded – undo
232 224
      *
233 225
      * @return boolean
234 226
      */
235
-    public function getToplevel()
236
-    {
227
+    public function getToplevel() {
237 228
         return $this->toplevel;
238 229
     }
239 230
 
@@ -244,8 +235,7 @@  discard block
 block discarded – undo
244 235
      *
245 236
      * @return string
246 237
      */
247
-    public function getType()
248
-    {
238
+    public function getType() {
249 239
         return $this->type;
250 240
     }
251 241
 
@@ -256,8 +246,7 @@  discard block
 block discarded – undo
256 246
      *
257 247
      * @return array(Page) All result's pages which contain search phrase
258 248
      */
259
-    public function getPages()
260
-    {
249
+    public function getPages() {
261 250
         return $this->pages;
262 251
     }
263 252
 
@@ -268,8 +257,7 @@  discard block
 block discarded – undo
268 257
      *
269 258
      * @return array(Region) All result's regions which contain search phrase
270 259
      */
271
-    public function getRegions()
272
-    {
260
+    public function getRegions() {
273 261
         return $this->regions;
274 262
     }
275 263
 
@@ -280,8 +268,7 @@  discard block
 block discarded – undo
280 268
      *
281 269
      * @return array(Highlight) All result's highlights of search phrase
282 270
      */
283
-    public function getHighlights()
284
-    {
271
+    public function getHighlights() {
285 272
         return $this->highlights;
286 273
     }
287 274
 
@@ -292,8 +279,7 @@  discard block
 block discarded – undo
292 279
      *
293 280
      * @return array(string) All result's highlights of search phrase
294 281
      */
295
-    public function getHighlightsIds()
296
-    {
282
+    public function getHighlightsIds() {
297 283
         $highlightsIds = [];
298 284
         foreach ($this->highlights as $highlight) {
299 285
             array_push($highlightsIds, $highlight->getId());
@@ -309,8 +295,7 @@  discard block
 block discarded – undo
309 295
      *
310 296
      * @return void
311 297
      */
312
-    private function parseSnippets()
313
-    {
298
+    private function parseSnippets() {
314 299
         $snippetArray = $this->getArrayByIndex('text');
315 300
 
316 301
         $this->snippets = !empty($snippetArray) ? implode(' [...] ', $snippetArray) : '';
@@ -324,8 +309,7 @@  discard block
 block discarded – undo
324 309
      *
325 310
      * @return void
326 311
      */
327
-    private function parsePages()
328
-    {
312
+    private function parsePages() {
329 313
         $pageArray = $this->getArrayByIndex('pages');
330 314
 
331 315
         $i = 0;
@@ -345,8 +329,7 @@  discard block
 block discarded – undo
345 329
      *
346 330
      * @return void
347 331
      */
348
-    private function parseRegions()
349
-    {
332
+    private function parseRegions() {
350 333
         $regionArray = $this->getArrayByIndex('regions');
351 334
 
352 335
         $i = 0;
@@ -366,8 +349,7 @@  discard block
 block discarded – undo
366 349
      *
367 350
      * @return void
368 351
      */
369
-    private function parseHighlights()
370
-    {
352
+    private function parseHighlights() {
371 353
         $highlightArray = $this->getArrayByIndex('highlights');
372 354
 
373 355
         foreach ($highlightArray as $highlights) {
@@ -388,8 +370,7 @@  discard block
 block discarded – undo
388 370
      *
389 371
      * @return array
390 372
      */
391
-    private function getArrayByIndex($index)
392
-    {
373
+    private function getArrayByIndex($index) {
393 374
         $objectArray = [];
394 375
         foreach ($this->snippetsForRecord as $snippet) {
395 376
             if (!empty($snippet[$index])) {
Please login to merge, or discard this patch.
Classes/Command/BaseCommand.php 1 patch
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -38,8 +38,7 @@  discard block
 block discarded – undo
38 38
  * @subpackage dlf
39 39
  * @access public
40 40
  */
41
-class BaseCommand extends Command
42
-{
41
+class BaseCommand extends Command {
43 42
     /**
44 43
      * @var CollectionRepository
45 44
      */
@@ -79,8 +78,7 @@  discard block
 block discarded – undo
79 78
      *
80 79
      * @return bool
81 80
      */
82
-    protected function initializeRepositories($storagePid)
83
-    {
81
+    protected function initializeRepositories($storagePid) {
84 82
         if (MathUtility::canBeInterpretedAsInteger($storagePid)) {
85 83
             $configurationManager = GeneralUtility::makeInstance(ConfigurationManager::class);
86 84
             $frameworkConfiguration = $configurationManager->getConfiguration(\TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface::CONFIGURATION_TYPE_FRAMEWORK);
@@ -159,8 +157,7 @@  discard block
 block discarded – undo
159 157
      *
160 158
      * @return bool true on success
161 159
      */
162
-    protected function saveToDatabase(Document $document)
163
-    {
160
+    protected function saveToDatabase(Document $document) {
164 161
         $success = false;
165 162
 
166 163
         $doc = $document->getDoc();
@@ -268,8 +265,7 @@  discard block
 block discarded – undo
268 265
      *
269 266
      * @return int The parent document's id.
270 267
      */
271
-    protected function getParentDocumentUidForSaving(Document $document)
272
-    {
268
+    protected function getParentDocumentUidForSaving(Document $document) {
273 269
         $doc = $document->getDoc();
274 270
 
275 271
         if ($doc !== null) {
Please login to merge, or discard this patch.
Classes/Command/IndexCommand.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -33,16 +33,14 @@  discard block
 block discarded – undo
33 33
  * @subpackage dlf
34 34
  * @access public
35 35
  */
36
-class IndexCommand extends BaseCommand
37
-{
36
+class IndexCommand extends BaseCommand {
38 37
 
39 38
     /**
40 39
      * Configure the command by defining the name, options and arguments
41 40
      *
42 41
      * @return void
43 42
      */
44
-    public function configure()
45
-    {
43
+    public function configure() {
46 44
         $this
47 45
             ->setDescription('Index single document into database and Solr.')
48 46
             ->setHelp('')
@@ -86,8 +84,7 @@  discard block
 block discarded – undo
86 84
      *
87 85
      * @return int
88 86
      */
89
-    protected function execute(InputInterface $input, OutputInterface $output)
90
-    {
87
+    protected function execute(InputInterface $input, OutputInterface $output) {
91 88
         $dryRun = $input->getOption('dry-run') != false ? true : false;
92 89
 
93 90
         $io = new SymfonyStyle($input, $output);
Please login to merge, or discard this patch.
Classes/Command/ReindexCommand.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -32,15 +32,13 @@  discard block
 block discarded – undo
32 32
  * @subpackage dlf
33 33
  * @access public
34 34
  */
35
-class ReindexCommand extends BaseCommand
36
-{
35
+class ReindexCommand extends BaseCommand {
37 36
     /**
38 37
      * Configure the command by defining the name, options and arguments
39 38
      *
40 39
      * @return void
41 40
      */
42
-    public function configure()
43
-    {
41
+    public function configure() {
44 42
         $this
45 43
             ->setDescription('Reindex a collection into database and Solr.')
46 44
             ->setHelp('')
@@ -90,8 +88,7 @@  discard block
 block discarded – undo
90 88
      *
91 89
      * @return int
92 90
      */
93
-    protected function execute(InputInterface $input, OutputInterface $output)
94
-    {
91
+    protected function execute(InputInterface $input, OutputInterface $output) {
95 92
         $dryRun = $input->getOption('dry-run') != false ? true : false;
96 93
 
97 94
         $io = new SymfonyStyle($input, $output);
Please login to merge, or discard this patch.
Classes/Command/HarvestCommand.php 1 patch
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -36,15 +36,13 @@  discard block
 block discarded – undo
36 36
  * @subpackage dlf
37 37
  * @access public
38 38
  */
39
-class HarvestCommand extends BaseCommand
40
-{
39
+class HarvestCommand extends BaseCommand {
41 40
     /**
42 41
      * Configure the command by defining the name, options and arguments
43 42
      *
44 43
      * @return void
45 44
      */
46
-    public function configure()
47
-    {
45
+    public function configure() {
48 46
         $this
49 47
             ->setDescription('Harvest OAI-PMH contents into database and Solr.')
50 48
             ->setHelp('')
@@ -100,8 +98,7 @@  discard block
 block discarded – undo
100 98
      *
101 99
      * @return int
102 100
      */
103
-    protected function execute(InputInterface $input, OutputInterface $output)
104
-    {
101
+    protected function execute(InputInterface $input, OutputInterface $output) {
105 102
         $dryRun = $input->getOption('dry-run') != false ? true : false;
106 103
 
107 104
         $io = new SymfonyStyle($input, $output);
@@ -265,8 +262,7 @@  discard block
 block discarded – undo
265 262
      *
266 263
      * @return void
267 264
      */
268
-    protected function handleOaiError(BaseoaipmhException $exception, SymfonyStyle $io)
269
-    {
265
+    protected function handleOaiError(BaseoaipmhException $exception, SymfonyStyle $io) {
270 266
         $io->error('ERROR: Trying to retrieve data from OAI interface resulted in error:' . "\n    " . $exception->getMessage());
271 267
     }
272 268
 }
Please login to merge, or discard this patch.
Classes/Updates/MigrateSettings.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,7 @@
 block discarded – undo
23 23
  * Class MigrateSettings
24 24
  * @internal
25 25
  */
26
-class MigrateSettings implements UpgradeWizardInterface
27
-{
26
+class MigrateSettings implements UpgradeWizardInterface {
28 27
 
29 28
     /**
30 29
      * Return the identifier for this wizard
Please login to merge, or discard this patch.
Classes/Updates/FileLocationUpdater.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -153,8 +153,7 @@  discard block
 block discarded – undo
153 153
      * @return array|int
154 154
      * @throws \RuntimeException
155 155
      */
156
-    protected function getRecordsFromTable($countOnly = false)
157
-    {
156
+    protected function getRecordsFromTable($countOnly = false) {
158 157
         $connectionPool = GeneralUtility::makeInstance(ConnectionPool::class);
159 158
         $allResults = [];
160 159
         $numResults = 0;
@@ -234,8 +233,7 @@  discard block
 block discarded – undo
234 233
      * @param array $row
235 234
      * @throws \Exception
236 235
      */
237
-    protected function migrateField($table, $row)
238
-    {
236
+    protected function migrateField($table, $row) {
239 237
         $fieldItem = trim($row[$this->fieldsToMigrate[$table]]);
240 238
 
241 239
         if (empty($fieldItem) || is_numeric($fieldItem)) {
Please login to merge, or discard this patch.
Classes/ViewHelpers/JsFooterViewHelper.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -19,13 +19,11 @@
 block discarded – undo
19 19
 /**
20 20
  * Add inline JavaScript code to footer *
21 21
  */
22
-class JsFooterViewHelper extends AbstractViewHelper
23
-{
22
+class JsFooterViewHelper extends AbstractViewHelper {
24 23
     /**
25 24
      * Initialize arguments.
26 25
      */
27
-    public function initializeArguments()
28
-    {
26
+    public function initializeArguments() {
29 27
         parent::initializeArguments();
30 28
         $this->registerArgument('inlineCode', 'string', 'Inline JavaScript', true);
31 29
     }
Please login to merge, or discard this patch.