Passed
Pull Request — master (#123)
by
unknown
05:05
created
Classes/Format/Alto.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -147,8 +147,7 @@
 block discarded – undo
147 147
      *
148 148
      * @param \SimpleXMLElement &$xml: The XML to register the namespace for
149 149
      */
150
-    private function registerAltoNamespace(\SimpleXMLElement &$xml)
151
-    {
150
+    private function registerAltoNamespace(\SimpleXMLElement &$xml) {
152 151
         $namespace = $xml->getDocNamespaces();
153 152
 
154 153
         if (in_array('http://www.loc.gov/standards/alto/ns-v2#', $namespace, true)) {
Please login to merge, or discard this patch.
Classes/Format/Mods.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,8 +24,7 @@
 block discarded – undo
24 24
  *
25 25
  * @access public
26 26
  */
27
-class Mods implements MetadataInterface
28
-{
27
+class Mods implements MetadataInterface {
29 28
     /**
30 29
      * @access private
31 30
      * @var \SimpleXMLElement The metadata XML
Please login to merge, or discard this patch.
Classes/Format/TeiHeader.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,8 +22,7 @@
 block discarded – undo
22 22
  *
23 23
  * @access public
24 24
  */
25
-class TeiHeader implements MetadataInterface
26
-{
25
+class TeiHeader implements MetadataInterface {
27 26
     /**
28 27
      * This extracts the essential TEIHDR metadata from XML
29 28
      *
Please login to merge, or discard this patch.
Classes/Api/Viaf/Client.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -26,8 +26,7 @@  discard block
 block discarded – undo
26 26
  *
27 27
  * @access public
28 28
  **/
29
-class Client
30
-{
29
+class Client {
31 30
     /**
32 31
      * @access protected
33 32
      * @var Logger This holds the logger
@@ -62,8 +61,7 @@  discard block
 block discarded – undo
62 61
      *
63 62
      * @return void
64 63
      **/
65
-    public function __construct(string $viaf, RequestFactory $requestFactory)
66
-    {
64
+    public function __construct(string $viaf, RequestFactory $requestFactory) {
67 65
         $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(static::class);
68 66
         $this->viafUrl = 'http://viaf.org/viaf/' . $viaf;
69 67
         $this->requestFactory = $requestFactory;
@@ -89,8 +87,7 @@  discard block
 block discarded – undo
89 87
      *
90 88
      * @return object|bool
91 89
      **/
92
-    public function getData()
93
-    {
90
+    public function getData() {
94 91
         $url = $this->getApiEndpoint();
95 92
         try {
96 93
             $response = $this->requestFactory->request($url);
Please login to merge, or discard this patch.
Classes/Api/Viaf/Profile.php 1 patch
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -26,8 +26,7 @@  discard block
 block discarded – undo
26 26
  *
27 27
  * @access public
28 28
  **/
29
-class Profile
30
-{
29
+class Profile {
31 30
     /**
32 31
      * @access private
33 32
      * @var Logger This holds the logger
@@ -55,8 +54,7 @@  discard block
 block discarded – undo
55 54
      *
56 55
      * @return void
57 56
      **/
58
-    public function __construct(string $viaf)
59
-    {
57
+    public function __construct(string $viaf) {
60 58
         $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(static::class);
61 59
         $this->client = new Client($viaf, GeneralUtility::makeInstance(RequestFactory::class));
62 60
     }
@@ -68,8 +66,7 @@  discard block
 block discarded – undo
68 66
      *
69 67
      * @return array|false
70 68
      **/
71
-    public function getData()
72
-    {
69
+    public function getData() {
73 70
         $this->getRaw();
74 71
         if ($this->raw !== false && !empty($this->raw)) {
75 72
             $data = [];
@@ -89,8 +86,7 @@  discard block
 block discarded – undo
89 86
      *
90 87
      * @return string|false
91 88
      **/
92
-    public function getAddress()
93
-    {
89
+    public function getAddress() {
94 90
         $this->getRaw();
95 91
         if ($this->raw !== false && !empty($this->raw->asXML())) {
96 92
             return (string) $this->raw->xpath('./ns1:nationalityOfEntity/ns1:data/ns1:text')[0];
@@ -107,8 +103,7 @@  discard block
 block discarded – undo
107 103
      *
108 104
      * @return string|false
109 105
      **/
110
-    public function getFullName()
111
-    {
106
+    public function getFullName() {
112 107
         $this->getRaw();
113 108
         if ($this->raw !== false && !empty($this->raw->asXML())) {
114 109
             $rawName = $this->raw->xpath('./ns1:mainHeadings/ns1:data/ns1:text');
Please login to merge, or discard this patch.
Classes/Api/Orcid/Client.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -26,8 +26,7 @@  discard block
 block discarded – undo
26 26
  *
27 27
  * @access public
28 28
  **/
29
-class Client
30
-{
29
+class Client {
31 30
     /**
32 31
      * @var string constant for API hostname
33 32
      **/
@@ -78,8 +77,7 @@  discard block
 block discarded – undo
78 77
      *
79 78
      * @return void
80 79
      **/
81
-    public function __construct(string $orcid, RequestFactory $requestFactory)
82
-    {
80
+    public function __construct(string $orcid, RequestFactory $requestFactory) {
83 81
         $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(static::class);
84 82
         $this->orcid = $orcid;
85 83
         $this->requestFactory = $requestFactory;
@@ -105,8 +103,7 @@  discard block
 block discarded – undo
105 103
      *
106 104
      * @return object|bool
107 105
      **/
108
-    public function getData()
109
-    {
106
+    public function getData() {
110 107
         $url = $this->getApiEndpoint();
111 108
         try {
112 109
             $response = $this->requestFactory->request($url);
Please login to merge, or discard this patch.
Classes/Api/Orcid/Profile.php 1 patch
Braces   +6 added lines, -12 removed lines patch added patch discarded remove patch
@@ -26,8 +26,7 @@  discard block
 block discarded – undo
26 26
  *
27 27
  * @access public
28 28
  **/
29
-class Profile
30
-{
29
+class Profile {
31 30
     /**
32 31
      * @access protected
33 32
      * @var Logger This holds the logger
@@ -55,8 +54,7 @@  discard block
 block discarded – undo
55 54
      *
56 55
      * @return void
57 56
      **/
58
-    public function __construct(string $orcid)
59
-    {
57
+    public function __construct(string $orcid) {
60 58
         $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(static::class);
61 59
         $this->client = new Client($orcid, GeneralUtility::makeInstance(RequestFactory::class));
62 60
     }
@@ -68,8 +66,7 @@  discard block
 block discarded – undo
68 66
      *
69 67
      * @return array|false
70 68
      **/
71
-    public function getData()
72
-    {
69
+    public function getData() {
73 70
         $this->getRaw('person');
74 71
         if ($this->raw !== false && !empty($this->raw)) {
75 72
             $data = [];
@@ -90,8 +87,7 @@  discard block
 block discarded – undo
90 87
      *
91 88
      * @return string|false
92 89
      **/
93
-    public function getAddress()
94
-    {
90
+    public function getAddress() {
95 91
         $this->getRaw('address');
96 92
         if ($this->raw !== false && !empty($this->raw)) {
97 93
             $this->raw->registerXPathNamespace('address', 'http://www.orcid.org/ns/address');
@@ -109,8 +105,7 @@  discard block
 block discarded – undo
109 105
      *
110 106
      * @return string|false
111 107
      **/
112
-    public function getEmail()
113
-    {
108
+    public function getEmail() {
114 109
         $this->getRaw('email');
115 110
         if ($this->raw !== false && !empty($this->raw)) {
116 111
             $this->raw->registerXPathNamespace('email', 'http://www.orcid.org/ns/email');
@@ -128,8 +123,7 @@  discard block
 block discarded – undo
128 123
      *
129 124
      * @return string|false
130 125
      **/
131
-    public function getFullName()
132
-    {
126
+    public function getFullName() {
133 127
         $this->getRaw('personal-details');
134 128
         if ($this->raw !== false && !empty($this->raw)) {
135 129
             $this->raw->registerXPathNamespace('personal-details', 'http://www.orcid.org/ns/personal-details');
Please login to merge, or discard this patch.
Classes/ViewHelpers/StdWrapViewHelper.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,7 @@
 block discarded – undo
23 23
  *
24 24
  * @access public
25 25
  */
26
-class StdWrapViewHelper extends AbstractViewHelper
27
-{
26
+class StdWrapViewHelper extends AbstractViewHelper {
28 27
     /**
29 28
      * @access protected
30 29
      * @var bool
Please login to merge, or discard this patch.
Classes/ViewHelpers/MetadataWrapVariableViewHelper.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -39,8 +39,7 @@
 block discarded – undo
39 39
  *
40 40
  * @access public
41 41
  */
42
-class MetadataWrapVariableViewHelper extends AbstractViewHelper
43
-{
42
+class MetadataWrapVariableViewHelper extends AbstractViewHelper {
44 43
     /**
45 44
      * @access public
46 45
      *
Please login to merge, or discard this patch.