Passed
Pull Request — master (#123)
by Sebastian
03:39
created
Classes/Controller/MetadataController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
             array_unshift($metadata, $data);
113 113
         }
114 114
         if (empty($metadata)) {
115
-            $this->logger->warning('No metadata found for document with UID ' . $this->document->getUid());
115
+            $this->logger->warning('No metadata found for document with UID '.$this->document->getUid());
116 116
             return '';
117 117
         }
118 118
         ksort($metadata);
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
                         if (empty(implode('', $value)) && $this->settings['getTitle'] && $this->document->getPartof()) {
216 216
                             $superiorTitle = Doc::getTitle($this->document->getPartof(), true);
217 217
                             if (!empty($superiorTitle)) {
218
-                                $metadata[$i][$name] = ['[' . $superiorTitle . ']'];
218
+                                $metadata[$i][$name] = ['['.$superiorTitle.']'];
219 219
                             }
220 220
                         }
221 221
                         if (!empty($value)) {
Please login to merge, or discard this patch.
Classes/Common/Indexer.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
                         $parent->setDoc($doc);
116 116
                         $success = self::add($parent);
117 117
                     } else {
118
-                        Helper::log('Could not load parent document with UID ' . $document->getDoc()->parentId, LOG_SEVERITY_ERROR);
118
+                        Helper::log('Could not load parent document with UID '.$document->getDoc()->parentId, LOG_SEVERITY_ERROR);
119 119
                         return false;
120 120
                     }
121 121
                 }
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                 self::$processedDocs[] = $document->getUid();
126 126
                 // Delete old Solr documents.
127 127
                 $updateQuery = self::$solr->service->createUpdate();
128
-                $updateQuery->addDeleteQuery('uid:' . $document->getUid());
128
+                $updateQuery->addDeleteQuery('uid:'.$document->getUid());
129 129
                 self::$solr->service->update($updateQuery);
130 130
 
131 131
                 // Index every logical unit as separate Solr document.
@@ -174,14 +174,14 @@  discard block
 block discarded – undo
174 174
             } catch (\Exception $e) {
175 175
                 if (!(\TYPO3_REQUESTTYPE & \TYPO3_REQUESTTYPE_CLI)) {
176 176
                     Helper::addMessage(
177
-                        Helper::getLanguageService()->getLL('flash.solrException') . ' ' . htmlspecialchars($e->getMessage()),
177
+                        Helper::getLanguageService()->getLL('flash.solrException').' '.htmlspecialchars($e->getMessage()),
178 178
                         Helper::getLanguageService()->getLL('flash.error'),
179 179
                         FlashMessage::ERROR,
180 180
                         true,
181 181
                         'core.template.flashMessages'
182 182
                     );
183 183
                 }
184
-                Helper::log('Apache Solr threw exception: "' . $e->getMessage() . '"', LOG_SEVERITY_ERROR);
184
+                Helper::log('Apache Solr threw exception: "'.$e->getMessage().'"', LOG_SEVERITY_ERROR);
185 185
                 return false;
186 186
             }
187 187
         } else {
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
         // Sanitize input.
215 215
         $pid = max(intval($pid), 0);
216 216
         if (!$pid) {
217
-            Helper::log('Invalid PID ' . $pid . ' for metadata configuration', LOG_SEVERITY_ERROR);
217
+            Helper::log('Invalid PID '.$pid.' for metadata configuration', LOG_SEVERITY_ERROR);
218 218
             return '';
219 219
         }
220 220
         // Load metadata configuration.
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
         $suffix = (in_array($index_name, self::$fields['tokenized']) ? 't' : 'u');
224 224
         $suffix .= (in_array($index_name, self::$fields['stored']) ? 's' : 'u');
225 225
         $suffix .= (in_array($index_name, self::$fields['indexed']) ? 'i' : 'u');
226
-        $index_name .= '_' . $suffix;
226
+        $index_name .= '_'.$suffix;
227 227
         return $index_name;
228 228
     }
229 229
 
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
             $solrDoc->setField('title', $metadata['title'][0], self::$fields['fieldboost']['title']);
338 338
             $solrDoc->setField('volume', $metadata['volume'][0], self::$fields['fieldboost']['volume']);
339 339
             // verify date formatting
340
-            if(strtotime($metadata['date'][0])) {
340
+            if (strtotime($metadata['date'][0])) {
341 341
                 // do not alter dates YYYY or YYYY-MM or YYYY-MM-DD
342 342
                 if (
343 343
                     preg_match("/^[\d]{4}$/", $metadata['date'][0])
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
                 ) {
347 347
                     $solrDoc->setField('date', $metadata['date'][0]);
348 348
                 // change date YYYYMMDD to YYYY-MM-DD
349
-                } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])){
349
+                } elseif (preg_match("/^[\d]{8}$/", $metadata['date'][0])) {
350 350
                     $solrDoc->setField('date', date("Y-m-d", strtotime($metadata['date'][0])));
351 351
                 // convert any datetime to proper ISO extended datetime format and timezone for SOLR
352 352
                 } else {
@@ -374,11 +374,11 @@  discard block
 block discarded – undo
374 374
                     $solrDoc->setField(self::getIndexFieldName($index_name, $document->getPid()), $data, self::$fields['fieldboost'][$index_name]);
375 375
                     if (in_array($index_name, self::$fields['sortables'])) {
376 376
                         // Add sortable fields to index.
377
-                        $solrDoc->setField($index_name . '_sorting', $metadata[$index_name . '_sorting'][0]);
377
+                        $solrDoc->setField($index_name.'_sorting', $metadata[$index_name.'_sorting'][0]);
378 378
                     }
379 379
                     if (in_array($index_name, self::$fields['facets'])) {
380 380
                         // Add facets to index.
381
-                        $solrDoc->setField($index_name . '_faceting', $data);
381
+                        $solrDoc->setField($index_name.'_faceting', $data);
382 382
                     }
383 383
                     if (in_array($index_name, self::$fields['autocomplete'])) {
384 384
                         $autocomplete = array_merge($autocomplete, $data);
@@ -403,14 +403,14 @@  discard block
 block discarded – undo
403 403
             } catch (\Exception $e) {
404 404
                 if (!(\TYPO3_REQUESTTYPE & \TYPO3_REQUESTTYPE_CLI)) {
405 405
                     Helper::addMessage(
406
-                        Helper::getLanguageService()->getLL('flash.solrException') . '<br />' . htmlspecialchars($e->getMessage()),
406
+                        Helper::getLanguageService()->getLL('flash.solrException').'<br />'.htmlspecialchars($e->getMessage()),
407 407
                         Helper::getLanguageService()->getLL('flash.error'),
408 408
                         FlashMessage::ERROR,
409 409
                         true,
410 410
                         'core.template.flashMessages'
411 411
                     );
412 412
                 }
413
-                Helper::log('Apache Solr threw exception: "' . $e->getMessage() . '"', LOG_SEVERITY_ERROR);
413
+                Helper::log('Apache Solr threw exception: "'.$e->getMessage().'"', LOG_SEVERITY_ERROR);
414 414
                 return false;
415 415
             }
416 416
         }
@@ -476,7 +476,7 @@  discard block
 block discarded – undo
476 476
                                 $data = self::removeAppendsFromAuthor($data);
477 477
                             }
478 478
                             // Add facets to index.
479
-                            $solrDoc->setField($index_name . '_faceting', $data);
479
+                            $solrDoc->setField($index_name.'_faceting', $data);
480 480
                         }
481 481
                     }
482 482
                     // Add sorting information to physical sub-elements if applicable.
@@ -484,7 +484,7 @@  discard block
 block discarded – undo
484 484
                         !empty($data)
485 485
                         && substr($index_name, -8) == '_sorting'
486 486
                     ) {
487
-                        $solrDoc->setField($index_name , $doc->metadataArray[$doc->toplevelId][$index_name]);
487
+                        $solrDoc->setField($index_name, $doc->metadataArray[$doc->toplevelId][$index_name]);
488 488
                     }
489 489
                 }
490 490
             }
@@ -501,14 +501,14 @@  discard block
 block discarded – undo
501 501
             } catch (\Exception $e) {
502 502
                 if (!(\TYPO3_REQUESTTYPE & \TYPO3_REQUESTTYPE_CLI)) {
503 503
                     Helper::addMessage(
504
-                        Helper::getLanguageService()->getLL('flash.solrException') . '<br />' . htmlspecialchars($e->getMessage()),
504
+                        Helper::getLanguageService()->getLL('flash.solrException').'<br />'.htmlspecialchars($e->getMessage()),
505 505
                         Helper::getLanguageService()->getLL('flash.error'),
506 506
                         FlashMessage::ERROR,
507 507
                         true,
508 508
                         'core.template.flashMessages'
509 509
                     );
510 510
                 }
511
-                Helper::log('Apache Solr threw exception: "' . $e->getMessage() . '"', LOG_SEVERITY_ERROR);
511
+                Helper::log('Apache Solr threw exception: "'.$e->getMessage().'"', LOG_SEVERITY_ERROR);
512 512
                 return false;
513 513
             }
514 514
         }
@@ -559,7 +559,7 @@  discard block
 block discarded – undo
559 559
     private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '') {
560 560
         $solrDoc = $updateQuery->createDocument();
561 561
         // Create unique identifier from document's UID and unit's XML ID.
562
-        $solrDoc->setField('id', $document->getUid() . $unit['id']);
562
+        $solrDoc->setField('id', $document->getUid().$unit['id']);
563 563
         $solrDoc->setField('uid', $document->getUid());
564 564
         $solrDoc->setField('pid', $document->getPid());
565 565
         $solrDoc->setField('partof', $document->getPartof());
Please login to merge, or discard this patch.