Erikmitk / kitodo-presentation

Classes/Validation/DocumentValidator.php

Braces +2 added lines, -4 removed lines

@@ -27,8 +27,7 @@ 
  *
  * @access public
  */
-class DocumentValidator
-{
+class DocumentValidator {
      /**
      * @access protected
      * @var Logger This holds the logger
@@ -63,8 +62,7 @@ 
      *
      * @return void
      */
-    public function __construct(array $metadata = [], array $requiredMetadataFields = [], ?\SimpleXMLElement $xml = null)
-    {
+    public function __construct(array $metadata = [], array $requiredMetadataFields = [], ?\SimpleXMLElement $xml = null) {
         $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(static::class);
         $this->metadata = $metadata;
         $this->requiredMetadataFields = $requiredMetadataFields;

Tests/Unit/Validation/DocumentValidatorTest.php

Braces +7 added lines, -14 removed lines

@@ -15,8 +15,7 @@ 
 use SimpleXMLElement;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class DocumentValidatorTest extends UnitTestCase
-{
+class DocumentValidatorTest extends UnitTestCase {
     public function setUp(): void
     {
         parent::setUp();
@@ -27,8 +26,7 @@ 
     /**
      * @test
      */
-    public function passesHasAllMandatoryMetadataFields()
-    {
+    public function passesHasAllMandatoryMetadataFields() {
         $metadata = [
             'record_id' => [
                 'xyz'
@@ -41,8 +39,7 @@ 
     /**
      * @test
      */
-    public function notPassesHasAllMandatoryMetadataFields()
-    {
+    public function notPassesHasAllMandatoryMetadataFields() {
         $metadata = [
             'document_format' => [
                 'METS'
@@ -55,8 +52,7 @@ 
     /**
      * @test
      */
-    public function passesHasCorrectLogicalStructure()
-    {
+    public function passesHasCorrectLogicalStructure() {
         $xml = $this->getXml('av_beispiel.xml');
 
         $documentValidator = new DocumentValidator([], [], $xml);
@@ -66,8 +62,7 @@ 
     /**
      * @test
      */
-    public function notPassesHasCorrectLogicalStructure()
-    {
+    public function notPassesHasCorrectLogicalStructure() {
         $xml = $this->getXml('av_beispiel.xml');
 
         $documentValidator = new DocumentValidator([], [], $xml);
@@ -77,8 +72,7 @@ 
     /**
      * @test
      */
-    public function passesHasCorrectPhysicalStructure()
-    {
+    public function passesHasCorrectPhysicalStructure() {
         $xml = $this->getXml('av_beispiel.xml');
 
         $documentValidator = new DocumentValidator([], [], $xml);
@@ -88,8 +82,7 @@ 
     /**
      * @test
      */
-    public function notPassesHasCorrectPhysicalStructure()
-    {
+    public function notPassesHasCorrectPhysicalStructure() {
         $xml = $this->getXml('two_dmdsec.xml');
 
         $documentValidator = new DocumentValidator([], [], $xml);

Classes/Domain/Repository/DocumentRepository.php

Braces +13 added lines, -26 removed lines

@@ -36,8 +36,7 @@ 
  *
  * @access public
  */
-class DocumentRepository extends Repository
-{
+class DocumentRepository extends Repository {
     /**
      * @access protected
      * @var array The controller settings passed to the repository for some special actions.
@@ -61,8 +60,7 @@ 
      *
      * @return Document|null
      */
-    public function findOneByParameters($parameters)
-    {
+    public function findOneByParameters($parameters) {
         $doc = null;
         $document = null;
 
@@ -108,8 +106,7 @@ 
      *
      * @return Document|null
      */
-    public function findOldestDocument()
-    {
+    public function findOldestDocument() {
         $query = $this->createQuery();
 
         $query->setOrderings(['tstamp' => QueryInterface::ORDER_ASCENDING]);
@@ -126,8 +123,7 @@ 
      *
      * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
      */
-    public function getChildrenOfYearAnchor($partOf, $structure)
-    {
+    public function getChildrenOfYearAnchor($partOf, $structure) {
         $query = $this->createQuery();
 
         $query->matching($query->equals('structure', $structure));
@@ -150,8 +146,7 @@ 
      *
      * @return Document|null
      */
-    public function findOneByIdAndSettings($uid, $settings = [])
-    {
+    public function findOneByIdAndSettings($uid, $settings = []) {
         $settings = ['documentSets' => $uid];
 
         return $this->findDocumentsBySettings($settings)->getFirst();
@@ -166,8 +161,7 @@ 
      *
      * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
      */
-    public function findDocumentsBySettings($settings = [])
-    {
+    public function findDocumentsBySettings($settings = []) {
         $query = $this->createQuery();
 
         $constraints = [];
@@ -200,8 +194,7 @@ 
      *
      * @return array|\TYPO3\CMS\Extbase\Persistence\QueryResultInterface
      */
-    public function findAllByCollectionsLimited($collections, int $limit = 50, int $offset = 0)
-    {
+    public function findAllByCollectionsLimited($collections, int $limit = 50, int $offset = 0) {
         $query = $this->createQuery();
 
         // order by start_date -> start_time...
@@ -241,8 +234,7 @@ 
      *
      * @return array
      */
-    public function getStatisticsForSelectedCollection($settings)
-    {
+    public function getStatisticsForSelectedCollection($settings) {
         if ($settings['collections']) {
             // Include only selected collections.
             $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
@@ -378,8 +370,7 @@ 
      *
      * @return Result
      */
-    public function getTableOfContentsFromDb($uid, $pid, $settings)
-    {
+    public function getTableOfContentsFromDb($uid, $pid, $settings) {
         // Build table of contents from database.
         $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
             ->getQueryBuilderForTable('tx_dlf_documents');
@@ -429,8 +420,7 @@ 
      *
      * @return array The found document object
      */
-    public function getOaiRecord($settings, $parameters)
-    {
+    public function getOaiRecord($settings, $parameters) {
         $where = '';
 
         if (!$settings['show_userdefined']) {
@@ -507,8 +497,7 @@ 
      *
      * @return array
      */
-    public function findAllByUids($uids, $checkPartof = false)
-    {
+    public function findAllByUids($uids, $checkPartof = false) {
         // get all documents from db we are talking about
         $connectionPool = GeneralUtility::makeInstance(ConnectionPool::class);
         $queryBuilder = $connectionPool->getQueryBuilderForTable('tx_dlf_documents');
@@ -557,8 +546,7 @@ 
      *
      * @return array
      */
-    public function findChildrenOfEach(array $uids)
-    {
+    public function findChildrenOfEach(array $uids) {
         $allDocuments = $this->findAllByUids($uids, true);
 
         $result = [];
@@ -583,8 +571,7 @@ 
      *
      * @return SolrSearch
      */
-    public function findSolrByCollection(Collection $collection, $settings, $searchParams, $listedMetadata = null, $indexedMetadata = null)
-    {
+    public function findSolrByCollection(Collection $collection, $settings, $searchParams, $listedMetadata = null, $indexedMetadata = null) {
         return $this->findSolr([$collection], $settings, $searchParams, $listedMetadata, $indexedMetadata);
     }
 

Classes/Common/Solr/SolrSearch.php

Braces +11 added lines, -22 removed lines

@@ -96,8 +96,7 @@ 
      *
      * @return void
      */
-    public function __construct(DocumentRepository $documentRepository, $collections, array $settings, array $searchParams, QueryResult $listedMetadata = null, QueryResult $indexedMetadata = null)
-    {
+    public function __construct(DocumentRepository $documentRepository, $collections, array $settings, array $searchParams, QueryResult $listedMetadata = null, QueryResult $indexedMetadata = null) {
         $this->documentRepository = $documentRepository;
         $this->collections = $collections;
         $this->settings = $settings;
@@ -217,8 +216,7 @@ 
      * @return mixed
      */
     #[\ReturnTypeWillChange]
-    public function offsetGet($offset)
-    {
+    public function offsetGet($offset) {
         $idx = $this->result['document_keys'][$offset];
         $document = $this->result['documents'][$idx] ?? null;
 
@@ -286,8 +284,7 @@ 
      *
      * @return mixed
      */
-    public function getSolrResults()
-    {
+    public function getSolrResults() {
         return $this->result['solrResults'];
     }
 
@@ -300,8 +297,7 @@ 
      *
      * @return mixed
      */
-    public function getByUid($uid)
-    {
+    public function getByUid($uid) {
         return $this->result['documents'][$uid];
     }
 
@@ -312,8 +308,7 @@ 
      *
      * @return SolrSearchQuery
      */
-    public function getQuery()
-    {
+    public function getQuery() {
         return new SolrSearchQuery($this);
     }
 
@@ -324,8 +319,7 @@ 
      *
      * @return SolrSearch
      */
-    public function getFirst()
-    {
+    public function getFirst() {
         return $this[0];
     }
 
@@ -336,8 +330,7 @@ 
      *
      * @return array
      */
-    public function toArray()
-    {
+    public function toArray() {
         return array_values($this->result['documents']);
     }
 
@@ -350,8 +343,7 @@ 
      *
      * @return int
      */
-    public function getNumFound()
-    {
+    public function getNumFound() {
         return $this->result['numFound'];
     }
 
@@ -362,8 +354,7 @@ 
      *
      * @return void
      */
-    public function prepare()
-    {
+    public function prepare() {
         // Prepare query parameters.
         $params = [];
         $matches = [];
@@ -479,8 +470,7 @@ 
      *
      * @return void
      */
-    public function submit($start, $rows, $processResults = true)
-    {
+    public function submit($start, $rows, $processResults = true) {
         $params = $this->params;
         $params['start'] = $start;
         $params['rows'] = $rows;
@@ -638,8 +628,7 @@ 
      *
      * @return array The Apache Solr Documents that were fetched
      */
-    protected function searchSolr($parameters = [], $enableCache = true)
-    {
+    protected function searchSolr($parameters = [], $enableCache = true) {
         // Set query.
         $parameters['query'] = isset($parameters['query']) ? $parameters['query'] : '*';
         $parameters['filterquery'] = isset($parameters['filterquery']) ? $parameters['filterquery'] : [];

Classes/Common/Solr/SearchResult/Region.php

Braces +2 added lines, -4 removed lines

@@ -20,8 +20,7 @@ 
  *
  * @access public
  */
-class Region
-{
+class Region {
 
     /**
      * @access private
@@ -87,8 +86,7 @@ 
      *
      * @return void
      */
-    public function __construct(int $id, array $region)
-    {
+    public function __construct(int $id, array $region) {
         $this->id = $id;
         $this->pageId = $region['pageIdx'] ?? null;
         $this->xBeginPosition = $region['ulx'];

Classes/Common/Helper.php

Braces +9 added lines, -18 removed lines

@@ -38,8 +38,7 @@ 
  *
  * @access public
  */
-class Helper
-{
+class Helper {
     /**
      * @access public
      * @static
@@ -199,8 +198,7 @@ 
      *
      * @return mixed The decrypted value or false on error
      */
-    public static function decrypt(string $encrypted)
-    {
+    public static function decrypt(string $encrypted) {
         if (
             !in_array(self::$cipherAlgorithm, openssl_get_cipher_methods(true))
             || !in_array(self::$hashAlgorithm, openssl_get_md_methods(true))
@@ -240,8 +238,7 @@ 
      *
      * @return \SimpleXMLElement|false
      */
-    public static function getXmlFileAsString($content)
-    {
+    public static function getXmlFileAsString($content) {
         // Don't make simplexml_load_string throw (when $content is an array
         // or object)
         if (!is_string($content)) {
@@ -313,8 +310,7 @@ 
      *
      * @return mixed Hashed string or false on error
      */
-    public static function digest(string $string)
-    {
+    public static function digest(string $string) {
         if (!in_array(self::$hashAlgorithm, openssl_get_md_methods(true))) {
             self::log('OpenSSL library doesn\'t support hash algorithm', LOG_SEVERITY_ERROR);
             return false;
@@ -334,8 +330,7 @@ 
      *
      * @return mixed Encrypted string or false on error
      */
-    public static function encrypt(string $string)
-    {
+    public static function encrypt(string $string) {
         if (
             !in_array(self::$cipherAlgorithm, openssl_get_cipher_methods(true))
             || !in_array(self::$hashAlgorithm, openssl_get_md_methods(true))
@@ -578,8 +573,7 @@ 
      *
      * @return array Array of substituted "NEW..." identifiers and their actual UIDs.
      */
-    public static function processDatabaseAsAdmin(array $data = [], array $cmd = [], $reverseOrder = false, $cmdFirst = false)
-    {
+    public static function processDatabaseAsAdmin(array $data = [], array $cmd = [], $reverseOrder = false, $cmdFirst = false) {
         $context = GeneralUtility::makeInstance(Context::class);
 
         if (
@@ -818,8 +812,7 @@ 
      *
      * @return void
      */
-    private function __construct()
-    {
+    private function __construct() {
         // This is a static class, thus no instances should be created.
     }
 
@@ -850,8 +843,7 @@ 
      *
      * @return string|bool
      */
-    public static function getUrl(string $url)
-    {
+    public static function getUrl(string $url) {
         if (!Helper::isValidHttpUrl($url)) {
             return false;
         }
@@ -932,8 +924,7 @@ 
      *
      * @return mixed
      */
-    private static function getLocalConfigurationByPath(string $path)
-    {
+    private static function getLocalConfigurationByPath(string $path) {
         $configurationManager = GeneralUtility::makeInstance(ConfigurationManager::class);
 
         if (array_key_exists(strtok($path, '/'), $configurationManager->getLocalConfiguration())) {

Classes/Task/IndexAdditionalFieldProvider.php

Braces +2 added lines, -4 removed lines

@@ -23,8 +23,7 @@ 
  *
  * @access public
  */
-class IndexAdditionalFieldProvider extends BaseAdditionalFieldProvider
-{
+class IndexAdditionalFieldProvider extends BaseAdditionalFieldProvider {
     /**
      * Gets additional fields to render in the form to add/edit a task
      *
@@ -33,8 +32,7 @@ 
      * @param \TYPO3\CMS\Scheduler\Controller\SchedulerModuleController $schedulerModule Reference to the scheduler backend module
      * @return array A two dimensional array, array('Identifier' => array('fieldId' => array('code' => '', 'label' => '', 'cshKey' => '', 'cshLabel' => ''))
      */
-    public function getAdditionalFields(array &$taskInfo, $task, SchedulerModuleController $schedulerModule)
-    {
+    public function getAdditionalFields(array &$taskInfo, $task, SchedulerModuleController $schedulerModule) {
         $currentSchedulerModuleAction = $schedulerModule->getCurrentAction();
 
         /** @var BaseTask $task */

Classes/Task/HarvestAdditionalFieldProvider.php

Braces +2 added lines, -4 removed lines

@@ -25,8 +25,7 @@ 
  *
  * @access public
  */
-class HarvestAdditionalFieldProvider extends BaseAdditionalFieldProvider
-{
+class HarvestAdditionalFieldProvider extends BaseAdditionalFieldProvider {
     /**
      * Gets additional fields to render in the form to add/edit a task
      *
@@ -35,8 +34,7 @@ 
      * @param \TYPO3\CMS\Scheduler\Controller\SchedulerModuleController $schedulerModule Reference to the scheduler backend module
      * @return array A two dimensional array, array('Identifier' => array('fieldId' => array('code' => '', 'label' => '', 'cshKey' => '', 'cshLabel' => ''))
      */
-    public function getAdditionalFields(array &$taskInfo, $task, SchedulerModuleController $schedulerModule)
-    {
+    public function getAdditionalFields(array &$taskInfo, $task, SchedulerModuleController $schedulerModule) {
         $currentSchedulerModuleAction = $schedulerModule->getCurrentAction();
 
         /** @var BaseTask $task */

Classes/Task/ReindexTask.php

Braces +2 added lines, -4 removed lines

@@ -23,10 +23,8 @@
  *
  * @access public
  */
-class ReindexTask extends BaseTask
-{
-    public function execute()
-    {
+class ReindexTask extends BaseTask {
+    public function execute() {
         $inputArray = [];
         if ($this->dryRun) {
             $inputArray['--dry-run'] = true;