Completed
Push — master ( 1253ac...bfdcd2 )
by
unknown
16s queued 13s
created
Classes/Controller/PageGridController.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -22,15 +22,13 @@  discard block
 block discarded – undo
22 22
  * @subpackage dlf
23 23
  * @access public
24 24
  */
25
-class PageGridController extends AbstractController
26
-{
25
+class PageGridController extends AbstractController {
27 26
     /**
28 27
      * The main method of the plugin
29 28
      *
30 29
      * @return void
31 30
      */
32
-    public function mainAction()
33
-    {
31
+    public function mainAction() {
34 32
         $this->loadDocument($this->requestData);
35 33
         if (
36 34
             $this->document === null
@@ -65,8 +63,7 @@  discard block
 block discarded – undo
65 63
      *
66 64
      * @return array The rendered entry ready for fluid
67 65
      */
68
-    protected function getEntry($number, $fileGrpThumbs)
69
-    {
66
+    protected function getEntry($number, $fileGrpThumbs) {
70 67
         // Set pagination.
71 68
         $entry['pagination'] = htmlspecialchars($this->document->getDoc()->physicalStructureInfo[$this->document->getDoc()->physicalStructure[$number]]['orderlabel']);
72 69
         $entry['page'] = $number;
Please login to merge, or discard this patch.
Classes/Controller/ToolboxController.php 1 patch
Braces   +14 added lines, -28 removed lines patch added patch discarded remove patch
@@ -23,15 +23,13 @@  discard block
 block discarded – undo
23 23
  * @subpackage dlf
24 24
  * @access public
25 25
  */
26
-class ToolboxController extends AbstractController
27
-{
26
+class ToolboxController extends AbstractController {
28 27
     /**
29 28
      * The main method of the plugin
30 29
      *
31 30
      * @return void
32 31
      */
33
-    public function mainAction()
34
-    {
32
+    public function mainAction() {
35 33
         // Load current document.
36 34
         $this->loadDocument($this->requestData);
37 35
 
@@ -52,8 +50,7 @@  discard block
 block discarded – undo
52 50
      *
53 51
      * @return void
54 52
      */
55
-    public function annotationtool()
56
-    {
53
+    public function annotationtool() {
57 54
         if (
58 55
             $this->document === null
59 56
             || $this->document->getDoc()->numPages < 1
@@ -94,8 +91,7 @@  discard block
 block discarded – undo
94 91
      *
95 92
      * @return void
96 93
      */
97
-    public function fulltextdownloadtool()
98
-    {
94
+    public function fulltextdownloadtool() {
99 95
         if (
100 96
             $this->document === null
101 97
             || $this->document->getDoc()->numPages < 1
@@ -140,8 +136,7 @@  discard block
 block discarded – undo
140 136
      *
141 137
      * @return void
142 138
      */
143
-    public function fulltexttool()
144
-    {
139
+    public function fulltexttool() {
145 140
         if (
146 141
             $this->document === null
147 142
             || $this->document->getDoc()->numPages < 1
@@ -186,8 +181,7 @@  discard block
 block discarded – undo
186 181
      *
187 182
      * @return void
188 183
      */
189
-    public function imagedownloadtool()
190
-    {
184
+    public function imagedownloadtool() {
191 185
         if (
192 186
             $this->document === null
193 187
             || $this->document->getDoc()->numPages < 1
@@ -230,8 +224,7 @@  discard block
 block discarded – undo
230 224
      *
231 225
      * @return array Array of image links and image format information
232 226
      */
233
-    protected function getImage($page)
234
-    {
227
+    protected function getImage($page) {
235 228
         $image = [];
236 229
         // Get @USE value of METS fileGrp.
237 230
         $fileGrps = \TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(',', $this->settings['fileGrpsImageDownload']);
@@ -264,8 +257,7 @@  discard block
 block discarded – undo
264 257
      *
265 258
      * @return void
266 259
      */
267
-    public function imagemanipulationtool()
268
-    {
260
+    public function imagemanipulationtool() {
269 261
         // Set parent element for initialization.
270 262
         $parentContainer = !empty($this->settings['parentContainer']) ? $this->settings['parentContainer'] : '.tx-dlf-imagemanipulationtool';
271 263
 
@@ -278,8 +270,7 @@  discard block
 block discarded – undo
278 270
      *
279 271
      * @return void
280 272
      */
281
-    public function pdfdownloadtool()
282
-    {
273
+    public function pdfdownloadtool() {
283 274
         if (
284 275
             $this->document === null
285 276
             || $this->document->getDoc() === null
@@ -318,8 +309,7 @@  discard block
 block discarded – undo
318 309
      *
319 310
      * @return array Link to downloadable page
320 311
      */
321
-    protected function getPageLink()
322
-    {
312
+    protected function getPageLink() {
323 313
         $page1Link = '';
324 314
         $page2Link = '';
325 315
         $pageLinkArray = [];
@@ -363,8 +353,7 @@  discard block
 block discarded – undo
363 353
      *
364 354
      * @return string Link to downloadable work
365 355
      */
366
-    protected function getWorkLink()
367
-    {
356
+    protected function getWorkLink() {
368 357
         $workLink = '';
369 358
         $fileGrpsDownload = GeneralUtility::trimExplode(',', $this->extConf['fileGrpDownload']);
370 359
         // Get work link.
@@ -393,8 +382,7 @@  discard block
 block discarded – undo
393 382
      *
394 383
      * @return void
395 384
      */
396
-    public function searchindocumenttool()
397
-    {
385
+    public function searchindocumenttool() {
398 386
         if (
399 387
             $this->document === null
400 388
             || $this->document->getDoc()->numPages < 1
@@ -457,8 +445,7 @@  discard block
 block discarded – undo
457 445
      *
458 446
      * @return string with current document id
459 447
      */
460
-    protected function getCurrentDocumentId()
461
-    {
448
+    protected function getCurrentDocumentId() {
462 449
         $id = $this->document->getUid();
463 450
 
464 451
         if ($id !== null && $id > 0) {
@@ -493,8 +480,7 @@  discard block
 block discarded – undo
493 480
      *
494 481
      * @return string with encrypted core name
495 482
      */
496
-    protected function getEncryptedCoreName()
497
-    {
483
+    protected function getEncryptedCoreName() {
498 484
         // Get core name.
499 485
         $name = Helper::getIndexNameFromUid($this->settings['solrcore'], 'tx_dlf_solrcores');
500 486
         // Encrypt core name.
Please login to merge, or discard this patch.
Classes/Controller/NavigationController.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -23,15 +23,13 @@
 block discarded – undo
23 23
  * @subpackage dlf
24 24
  * @access public
25 25
  */
26
-class NavigationController extends AbstractController
27
-{
26
+class NavigationController extends AbstractController {
28 27
     /**
29 28
      * The main method of the plugin
30 29
      *
31 30
      * @return void
32 31
      */
33
-    public function mainAction()
34
-    {
32
+    public function mainAction() {
35 33
         // Load current document.
36 34
         $this->loadDocument($this->requestData);
37 35
         if (
Please login to merge, or discard this patch.
Classes/Hooks/DataHandler.php 1 patch
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -34,8 +34,7 @@  discard block
 block discarded – undo
34 34
  * @subpackage dlf
35 35
  * @access public
36 36
  */
37
-class DataHandler implements LoggerAwareInterface
38
-{
37
+class DataHandler implements LoggerAwareInterface {
39 38
     use LoggerAwareTrait;
40 39
 
41 40
     /**
@@ -43,8 +42,7 @@  discard block
 block discarded – undo
43 42
      */
44 43
     protected $documentRepository;
45 44
 
46
-    protected function getDocumentRepository()
47
-    {
45
+    protected function getDocumentRepository() {
48 46
         if ($this->documentRepository === null) {
49 47
             $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
50 48
             $this->documentRepository = $objectManager->get(DocumentRepository::class);
@@ -65,8 +63,7 @@  discard block
 block discarded – undo
65 63
      *
66 64
      * @return void
67 65
      */
68
-    public function processDatamap_postProcessFieldArray($status, $table, $id, &$fieldArray)
69
-    {
66
+    public function processDatamap_postProcessFieldArray($status, $table, $id, &$fieldArray) {
70 67
         if ($status == 'new') {
71 68
             switch ($table) {
72 69
                     // Field post-processing for table "tx_dlf_documents".
@@ -195,8 +192,7 @@  discard block
 block discarded – undo
195 192
      *
196 193
      * @return void
197 194
      */
198
-    public function processDatamap_afterDatabaseOperations($status, $table, $id, &$fieldArray)
199
-    {
195
+    public function processDatamap_afterDatabaseOperations($status, $table, $id, &$fieldArray) {
200 196
         if ($status == 'update') {
201 197
             switch ($table) {
202 198
                     // After database operations for table "tx_dlf_documents".
@@ -275,8 +271,7 @@  discard block
 block discarded – undo
275 271
      *
276 272
      * @return void
277 273
      */
278
-    public function processCmdmap_postProcess($command, $table, $id)
279
-    {
274
+    public function processCmdmap_postProcess($command, $table, $id) {
280 275
         if (
281 276
             in_array($command, ['move', 'delete', 'undelete'])
282 277
             && $table == 'tx_dlf_documents'
Please login to merge, or discard this patch.
Classes/Hooks/ItemsProcFunc.php 1 patch
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -26,8 +26,7 @@  discard block
 block discarded – undo
26 26
  * @subpackage dlf
27 27
  * @access public
28 28
  */
29
-class ItemsProcFunc
30
-{
29
+class ItemsProcFunc {
31 30
     /**
32 31
      * @var int
33 32
      */
@@ -42,8 +41,7 @@  discard block
 block discarded – undo
42 41
      *
43 42
      * @return void
44 43
      */
45
-    public function toolList(&$params)
46
-    {
44
+    public function toolList(&$params) {
47 45
         foreach ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['dlf/Classes/Plugin/Toolbox.php']['tools'] as $class => $label) {
48 46
             $params['items'][] = [Helper::getLanguageService()->getLL($label), $class];
49 47
         }
@@ -56,8 +54,7 @@  discard block
 block discarded – undo
56 54
      *
57 55
      * @return void
58 56
      */
59
-    public function __construct()
60
-    {
57
+    public function __construct() {
61 58
         $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
62 59
         $configurationManager = $objectManager->get(ConfigurationManager::class);
63 60
         // we must get the storagePid from full TypoScript setup at this point.
@@ -74,8 +71,7 @@  discard block
 block discarded – undo
74 71
      *
75 72
      * @return void
76 73
      */
77
-    public function extendedSearchList(&$params)
78
-    {
74
+    public function extendedSearchList(&$params) {
79 75
         $this->generateList(
80 76
             $params,
81 77
             'label,index_name',
@@ -116,8 +112,7 @@  discard block
 block discarded – undo
116 112
      *
117 113
      * @return void
118 114
      */
119
-    protected function generateList(&$params, $fields, $table, $sorting, $andWhere = '')
120
-    {
115
+    protected function generateList(&$params, $fields, $table, $sorting, $andWhere = '') {
121 116
         $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
122 117
             ->getQueryBuilderForTable($table);
123 118
 
Please login to merge, or discard this patch.
Classes/Hooks/ThumbnailCustomElement.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,10 +14,8 @@
 block discarded – undo
14 14
 
15 15
 use TYPO3\CMS\Backend\Form\Element\AbstractFormElement;
16 16
 
17
-class ThumbnailCustomElement extends AbstractFormElement
18
-{
19
-    public function render()
20
-    {
17
+class ThumbnailCustomElement extends AbstractFormElement {
18
+    public function render() {
21 19
         // Custom TCA properties and other data can be found in $this->data, for example the above
22 20
         // parameters are available in $this->data['parameterArray']['fieldConf']['config']['parameters']
23 21
         $result = $this->initializeResultArray();
Please login to merge, or discard this patch.
Classes/Hooks/ConfigurationForm.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -29,8 +29,7 @@  discard block
 block discarded – undo
29 29
  * @subpackage dlf
30 30
  * @access public
31 31
  */
32
-class ConfigurationForm
33
-{
32
+class ConfigurationForm {
34 33
 
35 34
     /**
36 35
      * Check if a connection to a Solr server could be established with the given credentials.
@@ -39,8 +38,7 @@  discard block
 block discarded – undo
39 38
      *
40 39
      * @return string Message informing the user of success or failure
41 40
      */
42
-    public function checkSolrConnection()
43
-    {
41
+    public function checkSolrConnection() {
44 42
         $solr = Solr::getInstance();
45 43
         if ($solr->ready) {
46 44
             Helper::addMessage(
@@ -65,8 +63,7 @@  discard block
 block discarded – undo
65 63
      *
66 64
      * @return void
67 65
      */
68
-    public function __construct()
69
-    {
66
+    public function __construct() {
70 67
         // Load backend localization file.
71 68
         Helper::getLanguageService()->includeLLFile('EXT:dlf/Resources/Private/Language/locallang_be.xlf');
72 69
     }
Please login to merge, or discard this patch.
Classes/ExpressionLanguage/DocumentTypeFunctionProvider.php 1 patch
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -41,8 +41,7 @@  discard block
 block discarded – undo
41 41
     /**
42 42
      * @return ExpressionFunction[] An array of Function instances
43 43
      */
44
-    public function getFunctions()
45
-    {
44
+    public function getFunctions() {
46 45
         return [
47 46
             $this->getDocumentTypeFunction(),
48 47
         ];
@@ -68,8 +67,7 @@  discard block
 block discarded – undo
68 67
      *
69 68
      * @return void
70 69
      */
71
-    protected function initializeRepositories($storagePid)
72
-    {
70
+    protected function initializeRepositories($storagePid) {
73 71
         Helper::polyfillExtbaseClassesForTYPO3v9();
74 72
 
75 73
         // TODO: When we drop support for TYPO3v9, we needn't/shouldn't use ObjectManager anymore
@@ -92,12 +90,10 @@  discard block
 block discarded – undo
92 90
     {
93 91
         return new ExpressionFunction(
94 92
             'getDocumentType',
95
-            function()
96
-            {
93
+            function() {
97 94
                 // Not implemented, we only use the evaluator
98 95
             },
99
-            function($arguments, $cPid)
100
-            {
96
+            function($arguments, $cPid) {
101 97
                 /** @var RequestWrapper $requestWrapper */
102 98
                 $requestWrapper = $arguments['request'];
103 99
                 $queryParams = $requestWrapper->getQueryParams();
@@ -143,8 +139,7 @@  discard block
 block discarded – undo
143 139
      *
144 140
      * @return void
145 141
      */
146
-    protected function loadDocument($requestData, int $pid)
147
-    {
142
+    protected function loadDocument($requestData, int $pid) {
148 143
         // Try to get document format from database
149 144
         if (!empty($requestData['id'])) {
150 145
 
Please login to merge, or discard this patch.
Classes/Common/Solr.php 1 patch
Braces   +21 added lines, -42 removed lines patch added patch discarded remove patch
@@ -37,8 +37,7 @@  discard block
 block discarded – undo
37 37
  * @property-read bool $ready Is the Solr service instantiated successfully?
38 38
  * @property-read \Solarium\Client $service This holds the Solr service object
39 39
  */
40
-class Solr implements LoggerAwareInterface
41
-{
40
+class Solr implements LoggerAwareInterface {
42 41
     use LoggerAwareTrait;
43 42
 
44 43
     /**
@@ -130,8 +129,7 @@  discard block
 block discarded – undo
130 129
      *
131 130
      * @return string The name of the new core
132 131
      */
133
-    public static function createCore($core = '')
134
-    {
132
+    public static function createCore($core = '') {
135 133
         // Get next available core name if none given.
136 134
         if (empty($core)) {
137 135
             $core = 'dlfCore' . self::getNextCoreNumber();
@@ -178,8 +176,7 @@  discard block
 block discarded – undo
178 176
      *
179 177
      * @return string The escaped query string
180 178
      */
181
-    public static function escapeQuery($query)
182
-    {
179
+    public static function escapeQuery($query) {
183 180
         $helper = GeneralUtility::makeInstance(\Solarium\Core\Query\Helper::class);
184 181
         // Escape query phrase or term.
185 182
         if (preg_match('/^".*"$/', $query)) {
@@ -202,8 +199,7 @@  discard block
 block discarded – undo
202 199
      *
203 200
      * @return string The escaped query string
204 201
      */
205
-    public static function escapeQueryKeepField($query, $pid)
206
-    {
202
+    public static function escapeQueryKeepField($query, $pid) {
207 203
         // Is there a field query?
208 204
         if (preg_match('/^[[:alnum:]]+_[tu][su]i:\(?.*\)?$/', $query)) {
209 205
             $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
@@ -253,8 +249,7 @@  discard block
 block discarded – undo
253 249
      *
254 250
      * @return array fields
255 251
      */
256
-    public static function getFields()
257
-    {
252
+    public static function getFields() {
258 253
         $conf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get(self::$extKey);
259 254
 
260 255
         $fields = [];
@@ -296,8 +291,7 @@  discard block
 block discarded – undo
296 291
      *
297 292
      * @return \Kitodo\Dlf\Common\Solr Instance of this class
298 293
      */
299
-    public static function getInstance($core = null)
300
-    {
294
+    public static function getInstance($core = null) {
301 295
         // Get core name if UID is given.
302 296
         if (MathUtility::canBeInterpretedAsInteger($core)) {
303 297
             $core = Helper::getIndexNameFromUid($core, 'tx_dlf_solrcores');
@@ -337,8 +331,7 @@  discard block
 block discarded – undo
337 331
      *
338 332
      * @return int First unused core number found
339 333
      */
340
-    public static function getNextCoreNumber($number = 0)
341
-    {
334
+    public static function getNextCoreNumber($number = 0) {
342 335
         $number = max(intval($number), 0);
343 336
         // Check if core already exists.
344 337
         $solr = self::getInstance('dlfCore' . $number);
@@ -356,8 +349,7 @@  discard block
 block discarded – undo
356 349
      *
357 350
      * @return void
358 351
      */
359
-    protected function loadSolrConnectionInfo()
360
-    {
352
+    protected function loadSolrConnectionInfo() {
361 353
         if (empty($this->config)) {
362 354
             $config = [];
363 355
             // Extract extension configuration.
@@ -397,8 +389,7 @@  discard block
 block discarded – undo
397 389
      *
398 390
      * @return array The Apache Solr Documents that were fetched
399 391
      */
400
-    public function search_raw($parameters = [])
401
-    {
392
+    public function search_raw($parameters = []) {
402 393
         // Set additional query parameters.
403 394
         $parameters['start'] = 0;
404 395
         $parameters['rows'] = $this->limit;
@@ -428,8 +419,7 @@  discard block
 block discarded – undo
428 419
      *
429 420
      * @return string|null The core name of the current query endpoint or null if core admin endpoint
430 421
      */
431
-    protected function _getCore()
432
-    {
422
+    protected function _getCore() {
433 423
         return $this->core;
434 424
     }
435 425
 
@@ -440,8 +430,7 @@  discard block
 block discarded – undo
440 430
      *
441 431
      * @return int The max number of results
442 432
      */
443
-    protected function _getLimit()
444
-    {
433
+    protected function _getLimit() {
445 434
         return $this->limit;
446 435
     }
447 436
 
@@ -452,8 +441,7 @@  discard block
 block discarded – undo
452 441
      *
453 442
      * @return int Total number of hits for last search
454 443
      */
455
-    protected function _getNumberOfHits()
456
-    {
444
+    protected function _getNumberOfHits() {
457 445
         return $this->numberOfHits;
458 446
     }
459 447
 
@@ -464,8 +452,7 @@  discard block
 block discarded – undo
464 452
      *
465 453
      * @return bool Is the search instantiated successfully?
466 454
      */
467
-    protected function _getReady()
468
-    {
455
+    protected function _getReady() {
469 456
         return $this->ready;
470 457
     }
471 458
 
@@ -476,8 +463,7 @@  discard block
 block discarded – undo
476 463
      *
477 464
      * @return \Solarium\Client Apache Solr service object
478 465
      */
479
-    protected function _getService()
480
-    {
466
+    protected function _getService() {
481 467
         return $this->service;
482 468
     }
483 469
 
@@ -490,8 +476,7 @@  discard block
 block discarded – undo
490 476
      *
491 477
      * @return void
492 478
      */
493
-    protected function _setCPid($value)
494
-    {
479
+    protected function _setCPid($value) {
495 480
         $this->cPid = max(intval($value), 0);
496 481
     }
497 482
 
@@ -504,8 +489,7 @@  discard block
 block discarded – undo
504 489
      *
505 490
      * @return void
506 491
      */
507
-    protected function _setLimit($value)
508
-    {
492
+    protected function _setLimit($value) {
509 493
         $this->limit = max(intval($value), 0);
510 494
     }
511 495
 
@@ -518,8 +502,7 @@  discard block
 block discarded – undo
518 502
      *
519 503
      * @return void
520 504
      */
521
-    protected function _setParams(array $value)
522
-    {
505
+    protected function _setParams(array $value) {
523 506
         $this->params = $value;
524 507
     }
525 508
 
@@ -532,8 +515,7 @@  discard block
 block discarded – undo
532 515
      *
533 516
      * @return mixed Value of $this->$var
534 517
      */
535
-    public function __get($var)
536
-    {
518
+    public function __get($var) {
537 519
         $method = '_get' . ucfirst($var);
538 520
         if (
539 521
             !property_exists($this, $var)
@@ -555,8 +537,7 @@  discard block
 block discarded – undo
555 537
      *
556 538
      * @return bool true if variable is set and not empty, false otherwise
557 539
      */
558
-    public function __isset($var)
559
-    {
540
+    public function __isset($var) {
560 541
         return !empty($this->__get($var));
561 542
     }
562 543
 
@@ -570,8 +551,7 @@  discard block
 block discarded – undo
570 551
      *
571 552
      * @return void
572 553
      */
573
-    public function __set($var, $value)
574
-    {
554
+    public function __set($var, $value) {
575 555
         $method = '_set' . ucfirst($var);
576 556
         if (
577 557
             !property_exists($this, $var)
@@ -592,8 +572,7 @@  discard block
 block discarded – undo
592 572
      *
593 573
      * @return void
594 574
      */
595
-    protected function __construct($core)
596
-    {
575
+    protected function __construct($core) {
597 576
         // Get Solr connection parameters from configuration.
598 577
         $this->loadSolrConnectionInfo();
599 578
         // Configure connection adapter.
Please login to merge, or discard this patch.