Erikmitk / kitodo-presentation

Classes/Plugin/Collection.php

Braces +4 added lines, -8 removed lines

@@ -26,8 +26,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class Collection extends \Kitodo\Dlf\Common\AbstractPlugin
-{
+class Collection extends \Kitodo\Dlf\Common\AbstractPlugin {
     public $scriptRelPath = 'Classes/Plugin/Collection.php';
 
     /**
@@ -48,8 +47,7 @@ 
      *
      * @return string The content that is displayed on the website
      */
-    public function main($content, $conf)
-    {
+    public function main($content, $conf) {
         $this->init($conf);
         // Turn cache on.
         $this->setCache(true);
@@ -77,8 +75,7 @@ 
      *
      * @return string The list of collections ready to output
      */
-    protected function showCollectionList()
-    {
+    protected function showCollectionList() {
         $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
             ->getQueryBuilderForTable('tx_dlf_collections');
 
@@ -257,8 +254,7 @@ 
      *
      * @return void
      */
-    protected function showSingleCollection($id)
-    {
+    protected function showSingleCollection($id) {
         $connectionPool = GeneralUtility::makeInstance(ConnectionPool::class);
         $queryBuilder = $connectionPool->getQueryBuilderForTable('tx_dlf_collections');
 

Spacing +14 added lines, -14 removed lines

@@ -176,12 +176,12 @@ 
         foreach ($collections as $collection) {
             $solr_query = '';
             if ($collection['index_query'] != '') {
-                $solr_query .= '(' . $collection['index_query'] . ')';
+                $solr_query .= '('.$collection['index_query'].')';
             } else {
-                $solr_query .= 'collection:("' . $collection['index_name'] . '")';
+                $solr_query .= 'collection:("'.$collection['index_name'].'")';
             }
-            $partOfNothing = $solr->search_raw($solr_query . ' AND partof:0 AND toplevel:true', $params);
-            $partOfSomething = $solr->search_raw($solr_query . ' AND NOT partof:0 AND toplevel:true', $params);
+            $partOfNothing = $solr->search_raw($solr_query.' AND partof:0 AND toplevel:true', $params);
+            $partOfSomething = $solr->search_raw($solr_query.' AND NOT partof:0 AND toplevel:true', $params);
             // Titles are all documents that are "root" elements i.e. partof == 0
             $collection['titles'] = [];
             foreach ($partOfNothing as $doc) {
@@ -219,14 +219,14 @@ 
             $markerArray[$_key]['###TITLE###'] = $this->cObj->typoLink(htmlspecialchars($collection['label']), $conf);
             // Add feed link if applicable.
             if (!empty($this->conf['targetFeed'])) {
-                $img = '<img src="' . \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath($this->extKey)) . 'Resources/Public/Icons/txdlffeeds.png" alt="' . htmlspecialchars($this->pi_getLL('feedAlt', '')) . '" title="' . htmlspecialchars($this->pi_getLL('feedTitle', '')) . '" />';
+                $img = '<img src="'.\TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath($this->extKey)).'Resources/Public/Icons/txdlffeeds.png" alt="'.htmlspecialchars($this->pi_getLL('feedAlt', '')).'" title="'.htmlspecialchars($this->pi_getLL('feedTitle', '')).'" />';
                 $markerArray[$_key]['###FEED###'] = $this->pi_linkTP($img, [$this->prefixId => ['collection' => $collection['uid']]], false, $this->conf['targetFeed']);
             } else {
                 $markerArray[$_key]['###FEED###'] = '';
             }
             // Add thumbnail.
             if (!empty($collection['thumbnail'])) {
-                $markerArray[$_key]['###THUMBNAIL###'] = '<img alt="" title="' . htmlspecialchars($collection['label']) . '" src="' . $collection['thumbnail'] . '" />';
+                $markerArray[$_key]['###THUMBNAIL###'] = '<img alt="" title="'.htmlspecialchars($collection['label']).'" src="'.$collection['thumbnail'].'" />';
             } else {
                 $markerArray[$_key]['###THUMBNAIL###'] = '';
             }
@@ -234,9 +234,9 @@ 
             $markerArray[$_key]['###DESCRIPTION###'] = $this->pi_RTEcssText($collection['description']);
             // Build statistic's output.
             $labelTitles = $this->pi_getLL((count($collection['titles']) > 1 ? 'titles' : 'title'), '');
-            $markerArray[$_key]['###COUNT_TITLES###'] = htmlspecialchars(count($collection['titles']) . $labelTitles);
+            $markerArray[$_key]['###COUNT_TITLES###'] = htmlspecialchars(count($collection['titles']).$labelTitles);
             $labelVolumes = $this->pi_getLL((count($collection['volumes']) > 1 ? 'volumes' : 'volume'), '');
-            $markerArray[$_key]['###COUNT_VOLUMES###'] = htmlspecialchars(count($collection['volumes']) . $labelVolumes);
+            $markerArray[$_key]['###COUNT_VOLUMES###'] = htmlspecialchars(count($collection['volumes']).$labelVolumes);
         }
         // Randomize sorting?
         if (!empty($this->conf['randomize'])) {
@@ -320,14 +320,14 @@ 
                 $collectionData = $resArray;
             }
         } else {
-            $this->logger->warning('No collection with UID ' . $id . ' found.');
+            $this->logger->warning('No collection with UID '.$id.' found.');
             return;
         }
         // Fetch corresponding document UIDs from Solr.
         if ($collectionData['index_search'] != '') {
-            $solr_query = '(' . $collectionData['index_search'] . ')';
+            $solr_query = '('.$collectionData['index_search'].')';
         } else {
-            $solr_query = 'collection:("' . $collectionData['index_name'] . '") AND toplevel:true';
+            $solr_query = 'collection:("'.$collectionData['index_name'].'") AND toplevel:true';
         }
         $solr = Solr::getInstance($this->conf['solrcore']);
         if (!$solr->ready) {
@@ -376,7 +376,7 @@ 
                         'source' => 'collection',
                         'select' => $id,
                         'userid' => $collectionData['userid'],
-                        'params' => ['filterquery' => [['query' => 'collection_faceting:("' . $collectionData['index_name'] . '")']]],
+                        'params' => ['filterquery' => [['query' => 'collection_faceting:("'.$collectionData['index_name'].'")']]],
                         'core' => '',
                         'pid' => $this->conf['pages'],
                         'order' => 'title',
@@ -405,7 +405,7 @@ 
                 ];
             } else {
                 // volume_sorting should be always set - but it's not a required field. We append the uid to the array key to make it always unique.
-                $subparts[$resArray['partof']][$resArray['volume_sorting'] . str_pad($resArray['uid'], 9, '0', STR_PAD_LEFT)] = [
+                $subparts[$resArray['partof']][$resArray['volume_sorting'].str_pad($resArray['uid'], 9, '0', STR_PAD_LEFT)] = [
                     'u' => $resArray['uid'],
                     'h' => '',
                     's' => $sorting,
@@ -440,7 +440,7 @@ 
             'forceAbsoluteUrl' => !empty($this->conf['forceAbsoluteUrl']) ? 1 : 0,
             'forceAbsoluteUrl.' => ['scheme' => !empty($this->conf['forceAbsoluteUrl']) && !empty($this->conf['forceAbsoluteUrlHttps']) ? 'https' : 'http']
         ];
-        header('Location: ' . GeneralUtility::locationHeaderUrl($this->cObj->typoLink_URL($linkConf)));
+        header('Location: '.GeneralUtility::locationHeaderUrl($this->cObj->typoLink_URL($linkConf)));
         exit;
     }
 }

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -53,7 +53,7 @@ 
     {
         $this->init($conf);
         // Turn cache on.
-        $this->setCache(true);
+        $this->setCache(TRUE);
         // Quit without doing anything if required configuration variables are not set.
         if (empty($this->conf['pages'])) {
             $this->logger->warning('Incomplete plugin configuration');
@@ -213,14 +213,14 @@ 
                 'parameter' => $GLOBALS['TSFE']->id,
                 'forceAbsoluteUrl' => !empty($this->conf['forceAbsoluteUrl']) ? 1 : 0,
                 'forceAbsoluteUrl.' => ['scheme' => !empty($this->conf['forceAbsoluteUrl']) && !empty($this->conf['forceAbsoluteUrlHttps']) ? 'https' : 'http'],
-                'additionalParams' => GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', true, false)
+                'additionalParams' => GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', TRUE, FALSE)
             ];
             // Link collection's title to list view.
             $markerArray[$_key]['###TITLE###'] = $this->cObj->typoLink(htmlspecialchars($collection['label']), $conf);
             // Add feed link if applicable.
             if (!empty($this->conf['targetFeed'])) {
                 $img = '<img src="' . \TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath($this->extKey)) . 'Resources/Public/Icons/txdlffeeds.png" alt="' . htmlspecialchars($this->pi_getLL('feedAlt', '')) . '" title="' . htmlspecialchars($this->pi_getLL('feedTitle', '')) . '" />';
-                $markerArray[$_key]['###FEED###'] = $this->pi_linkTP($img, [$this->prefixId => ['collection' => $collection['uid']]], false, $this->conf['targetFeed']);
+                $markerArray[$_key]['###FEED###'] = $this->pi_linkTP($img, [$this->prefixId => ['collection' => $collection['uid']]], FALSE, $this->conf['targetFeed']);
             } else {
                 $markerArray[$_key]['###FEED###'] = '';
             }
@@ -242,7 +242,7 @@ 
         if (!empty($this->conf['randomize'])) {
             ksort($markerArray, SORT_NUMERIC);
             // Don't cache the output.
-            $this->setCache(false);
+            $this->setCache(FALSE);
         }
         $entry = $this->templateService->getSubpart($this->template, '###ENTRY###');
         foreach ($markerArray as $marker) {
@@ -254,7 +254,7 @@ 
                 $hookObj->showCollectionList_getCustomCollectionList($this, $this->conf['templateFile'], $content, $markerArray);
             }
         }
-        return $this->templateService->substituteSubpart($this->template, '###ENTRY###', $content, true);
+        return $this->templateService->substituteSubpart($this->template, '###ENTRY###', $content, TRUE);
     }
 
     /**
@@ -380,7 +380,7 @@ 
                         'core' => '',
                         'pid' => $this->conf['pages'],
                         'order' => 'title',
-                        'order.asc' => true
+                        'order.asc' => TRUE
                     ]
                 ];
             }

Classes/Plugin/Statistics.php

Braces +2 added lines, -4 removed lines

@@ -25,8 +25,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class Statistics extends \Kitodo\Dlf\Common\AbstractPlugin
-{
+class Statistics extends \Kitodo\Dlf\Common\AbstractPlugin {
     public $scriptRelPath = 'Classes/Plugin/Statistics.php';
 
     /**
@@ -39,8 +38,7 @@ 
      *
      * @return string The content that is displayed on the website
      */
-    public function main($content, $conf)
-    {
+    public function main($content, $conf) {
         $this->init($conf);
         // Turn cache on.
         $this->setCache(true);

Spacing +2 added lines, -2 removed lines

@@ -180,8 +180,8 @@
                 '###VOLUMES###'
             ],
             'value' => [
-                $countTitles . ($countTitles > 1 ? htmlspecialchars($this->pi_getLL('titles', '')) : htmlspecialchars($this->pi_getLL('title', ''))),
-                $countVolumes . ($countVolumes > 1 ? htmlspecialchars($this->pi_getLL('volumes', '')) : htmlspecialchars($this->pi_getLL('volume', '')))
+                $countTitles.($countTitles > 1 ? htmlspecialchars($this->pi_getLL('titles', '')) : htmlspecialchars($this->pi_getLL('title', ''))),
+                $countVolumes.($countVolumes > 1 ? htmlspecialchars($this->pi_getLL('volumes', '')) : htmlspecialchars($this->pi_getLL('volume', '')))
             ]
         ];
         // Apply replacements.

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
     {
         $this->init($conf);
         // Turn cache on.
-        $this->setCache(true);
+        $this->setCache(TRUE);
         // Quit without doing anything if required configuration variables are not set.
         if (empty($this->conf['pages'])) {
             $this->logger->warning('Incomplete plugin configuration');

Classes/Plugin/AudioPlayer.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
         // Load current document.
         $this->loadDocument();
         if (
-            $this->doc === null
+            $this->doc === NULL
             || $this->doc->numPages < 1
         ) {
             // Quit without doing anything if required variables are not set.

Spacing +4 added lines, -4 removed lines

@@ -55,12 +55,12 @@
             $(document).ready(function() {
                 AudioPlayer = new dlfAudioPlayer({
                     audio: {
-                        mimeType: "' . $this->audio['mimetype'] . '",
-                        title: "' . $this->audio['label'] . '",
-                        url:  "' . $this->audio['url'] . '"
+                        mimeType: "' . $this->audio['mimetype'].'",
+                        title: "' . $this->audio['label'].'",
+                        url:  "' . $this->audio['url'].'"
                     },
                     parentElId: "tx-dlf-audio",
-                    swfPath: "' . PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath($this->extKey)) . 'Resources/Public/Javascript/jPlayer/jquery.jplayer.swf"
+                    swfPath: "' . PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath($this->extKey)).'Resources/Public/Javascript/jPlayer/jquery.jplayer.swf"
                 });
             });
         ';

Braces +3 added lines, -6 removed lines

@@ -26,8 +26,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class AudioPlayer extends \Kitodo\Dlf\Common\AbstractPlugin
-{
+class AudioPlayer extends \Kitodo\Dlf\Common\AbstractPlugin {
     public $scriptRelPath = 'Classes/Plugin/AudioPlayer.php';
 
     /**
@@ -45,8 +44,7 @@ 
      *
      * @return void
      */
-    protected function addPlayerJS()
-    {
+    protected function addPlayerJS() {
         // Inline CSS.
         $inlineCSS = '#tx-dlf-audio { width: 100px; height: 100px; }';
 
@@ -80,8 +78,7 @@ 
      *
      * @return string The content that is displayed on the website
      */
-    public function main($content, $conf)
-    {
+    public function main($content, $conf) {
         $this->init($conf);
         // Load current document.
         $this->loadDocument();

Classes/Plugin/ListView.php

Braces +8 added lines, -16 removed lines

@@ -29,8 +29,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class ListView extends \Kitodo\Dlf\Common\AbstractPlugin
-{
+class ListView extends \Kitodo\Dlf\Common\AbstractPlugin {
     public $scriptRelPath = 'Classes/Plugin/ListView.php';
 
     /**
@@ -72,8 +71,7 @@ 
      *
      * @return string The rendered page browser ready for output
      */
-    protected function getPageBrowser()
-    {
+    protected function getPageBrowser() {
         // Get overall number of pages.
         $maxPages = intval(ceil($this->list->metadata['options']['numberOfToplevelHits'] / $this->conf['limit']));
         // Return empty pagebrowser if there is just one page.
@@ -124,8 +122,7 @@ 
      *
      * @return string The rendered entry ready for output
      */
-    protected function getEntry($number, $template)
-    {
+    protected function getEntry($number, $template) {
         $markerArray['###NUMBER###'] = ($this->piVars['pointer'] * $this->conf['limit']) + $number + 1;
         $markerArray['###METADATA###'] = '';
         $markerArray['###THUMBNAIL###'] = '';
@@ -227,8 +224,7 @@ 
      *
      * @return array The parsed fieldwrap
      */
-    private function getFieldWrap($index_name, $wrap)
-    {
+    private function getFieldWrap($index_name, $wrap) {
         if (isset($this->fieldwrap[$index_name])) {
             return $this->fieldwrap[$index_name];
         } else {
@@ -243,8 +239,7 @@ 
      *
      * @return string The rendered sorting dialog ready for output
      */
-    protected function getSortingForm()
-    {
+    protected function getSortingForm() {
         // Return nothing if there are no sortable metadata fields.
         if (!count($this->sortables)) {
             return '';
@@ -295,8 +290,7 @@ 
      *
      * @return string The rendered entries ready for output
      */
-    protected function getSubEntries($number, $template)
-    {
+    protected function getSubEntries($number, $template) {
         $content = '';
         $noTitle = $this->pi_getLL('noTitle');
         $highlight_word = preg_replace('/\s\s+/', ';', $this->list->metadata['searchString']);
@@ -399,8 +393,7 @@ 
      *
      * @return void
      */
-    protected function loadConfig()
-    {
+    protected function loadConfig() {
         $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
             ->getQueryBuilderForTable('tx_dlf_metadata');
 
@@ -446,8 +439,7 @@ 
      *
      * @return string The content that is displayed on the website
      */
-    public function main($content, $conf)
-    {
+    public function main($content, $conf) {
         $this->init($conf);
         // Don't cache the output.
         $this->setCache(false);

Spacing +25 added lines, -25 removed lines

@@ -81,12 +81,12 @@ 
             return '';
         }
         // Get separator.
-        $separator = '<span class="separator">' . htmlspecialchars($this->pi_getLL('separator', ' - ')) . '</span>';
+        $separator = '<span class="separator">'.htmlspecialchars($this->pi_getLL('separator', ' - ')).'</span>';
         // Add link to previous page.
         if ($this->piVars['pointer'] > 0) {
-            $output = $this->pi_linkTP_keepPIvars(htmlspecialchars($this->pi_getLL('prevPage', '<')), ['pointer' => $this->piVars['pointer'] - 1], true) . $separator;
+            $output = $this->pi_linkTP_keepPIvars(htmlspecialchars($this->pi_getLL('prevPage', '<')), ['pointer' => $this->piVars['pointer'] - 1], true).$separator;
         } else {
-            $output = '<span>' . htmlspecialchars($this->pi_getLL('prevPage', '<')) . '</span>' . $separator;
+            $output = '<span>'.htmlspecialchars($this->pi_getLL('prevPage', '<')).'</span>'.$separator;
         }
         $i = 0;
         $skip = null;
@@ -94,13 +94,13 @@ 
         while ($i < $maxPages) {
             if ($i < 3 || ($i > $this->piVars['pointer'] - 3 && $i < $this->piVars['pointer'] + 3) || $i > $maxPages - 4) {
                 if ($this->piVars['pointer'] != $i) {
-                    $output .= $this->pi_linkTP_keepPIvars(htmlspecialchars(sprintf($this->pi_getLL('page', '%d'), $i + 1)), ['pointer' => $i], true) . $separator;
+                    $output .= $this->pi_linkTP_keepPIvars(htmlspecialchars(sprintf($this->pi_getLL('page', '%d'), $i + 1)), ['pointer' => $i], true).$separator;
                 } else {
-                    $output .= '<span class="active">' . htmlspecialchars(sprintf($this->pi_getLL('page', '%d'), $i + 1)) . '</span>' . $separator;
+                    $output .= '<span class="active">'.htmlspecialchars(sprintf($this->pi_getLL('page', '%d'), $i + 1)).'</span>'.$separator;
                 }
                 $skip = true;
             } elseif ($skip === true) {
-                $output .= '<span class="skip">' . htmlspecialchars($this->pi_getLL('skip', '...')) . '</span>' . $separator;
+                $output .= '<span class="skip">'.htmlspecialchars($this->pi_getLL('skip', '...')).'</span>'.$separator;
                 $skip = false;
             }
             $i++;
@@ -109,7 +109,7 @@ 
         if ($this->piVars['pointer'] < $maxPages - 1) {
             $output .= $this->pi_linkTP_keepPIvars(htmlspecialchars($this->pi_getLL('nextPage', '>')), ['pointer' => $this->piVars['pointer'] + 1], true);
         } else {
-            $output .= '<span>' . htmlspecialchars($this->pi_getLL('nextPage', '>')) . '</span>';
+            $output .= '<span>'.htmlspecialchars($this->pi_getLL('nextPage', '>')).'</span>';
         }
         return $output;
     }
@@ -146,7 +146,7 @@ 
                         if (empty($value) && $this->conf['getTitle']) {
                             $superiorTitle = Document::getTitle($this->list[$number]['uid'], true);
                             if (!empty($superiorTitle)) {
-                                $value = '[' . $superiorTitle . ']';
+                                $value = '['.$superiorTitle.']';
                             }
                         }
                         // Set fake title if still not present.
@@ -195,7 +195,7 @@ 
         }
         // Add thumbnail.
         if (!empty($this->list[$number]['thumbnail'])) {
-            $markerArray['###THUMBNAIL###'] = '<img alt="' . $imgAlt . '" src="' . $this->list[$number]['thumbnail'] . '" />';
+            $markerArray['###THUMBNAIL###'] = '<img alt="'.$imgAlt.'" src="'.$this->list[$number]['thumbnail'].'" />';
         }
         // Add preview.
         if (!empty($this->list[$number]['preview'])) {
@@ -265,28 +265,28 @@ 
             $linkConf['additionalParams'] = GeneralUtility::implodeArrayForUrl($this->prefixId, ['logicalPage' => $this->piVars['logicalPage']], '', true, false);
         }
         // Build HTML form.
-        $sorting = '<form action="' . $this->cObj->typoLink_URL($linkConf) . '" method="get"><div><input type="hidden" name="id" value="' . $GLOBALS['TSFE']->id . '" />';
+        $sorting = '<form action="'.$this->cObj->typoLink_URL($linkConf).'" method="get"><div><input type="hidden" name="id" value="'.$GLOBALS['TSFE']->id.'" />';
         foreach ($this->piVars as $piVar => $value) {
             if ($piVar != 'order' && $piVar != 'DATA' && !empty($value)) {
-                $sorting .= '<input type="hidden" name="' . $this->prefixId . '[' . preg_replace('/[^A-Za-z0-9_-]/', '', $piVar) . ']" value="' . htmlspecialchars($value) . '" />';
+                $sorting .= '<input type="hidden" name="'.$this->prefixId.'['.preg_replace('/[^A-Za-z0-9_-]/', '', $piVar).']" value="'.htmlspecialchars($value).'" />';
             }
         }
         // Select sort field.
-        $uniqId = uniqid($prefix . '-');
-        $sorting .= '<label for="' . $uniqId . '">' . htmlspecialchars($this->pi_getLL('orderBy', '')) . '</label><select id="' . $uniqId . '" name="' . $this->prefixId . '[order]" onchange="javascript:this.form.submit();">';
+        $uniqId = uniqid($prefix.'-');
+        $sorting .= '<label for="'.$uniqId.'">'.htmlspecialchars($this->pi_getLL('orderBy', '')).'</label><select id="'.$uniqId.'" name="'.$this->prefixId.'[order]" onchange="javascript:this.form.submit();">';
         // Add relevance sorting if this is a search result list.
         if ($this->list->metadata['options']['source'] == 'search') {
-            $sorting .= '<option value="score"' . (($this->list->metadata['options']['order'] == 'score') ? ' selected="selected"' : '') . '>' . htmlspecialchars($this->pi_getLL('relevance', '')) . '</option>';
+            $sorting .= '<option value="score"'.(($this->list->metadata['options']['order'] == 'score') ? ' selected="selected"' : '').'>'.htmlspecialchars($this->pi_getLL('relevance', '')).'</option>';
         }
         foreach ($this->sortables as $index_name => $label) {
-            $sorting .= '<option value="' . htmlspecialchars($index_name) . '"' . (($this->list->metadata['options']['order'] == $index_name) ? ' selected="selected"' : '') . '>' . htmlspecialchars($label) . '</option>';
+            $sorting .= '<option value="'.htmlspecialchars($index_name).'"'.(($this->list->metadata['options']['order'] == $index_name) ? ' selected="selected"' : '').'>'.htmlspecialchars($label).'</option>';
         }
         $sorting .= '</select>';
         // Select sort direction.
-        $uniqId = uniqid($prefix . '-');
-        $sorting .= '<label for="' . $uniqId . '">' . htmlspecialchars($this->pi_getLL('direction', '')) . '</label><select id="' . $uniqId . '" name="' . $this->prefixId . '[asc]" onchange="javascript:this.form.submit();">';
-        $sorting .= '<option value="1" ' . ($this->list->metadata['options']['order.asc'] ? ' selected="selected"' : '') . '>' . htmlspecialchars($this->pi_getLL('direction.asc', '')) . '</option>';
-        $sorting .= '<option value="0" ' . (!$this->list->metadata['options']['order.asc'] ? ' selected="selected"' : '') . '>' . htmlspecialchars($this->pi_getLL('direction.desc', '')) . '</option>';
+        $uniqId = uniqid($prefix.'-');
+        $sorting .= '<label for="'.$uniqId.'">'.htmlspecialchars($this->pi_getLL('direction', '')).'</label><select id="'.$uniqId.'" name="'.$this->prefixId.'[asc]" onchange="javascript:this.form.submit();">';
+        $sorting .= '<option value="1" '.($this->list->metadata['options']['order.asc'] ? ' selected="selected"' : '').'>'.htmlspecialchars($this->pi_getLL('direction.asc', '')).'</option>';
+        $sorting .= '<option value="0" '.(!$this->list->metadata['options']['order.asc'] ? ' selected="selected"' : '').'>'.htmlspecialchars($this->pi_getLL('direction.desc', '')).'</option>';
         $sorting .= '</select></div></form>';
         return $sorting;
     }
@@ -322,7 +322,7 @@ 
                         if (empty($value) && $this->conf['getTitle']) {
                             $superiorTitle = Document::getTitle($subpart['uid'], true);
                             if (!empty($superiorTitle)) {
-                                $value = '[' . $superiorTitle . ']';
+                                $value = '['.$superiorTitle.']';
                             }
                         }
                         // Set fake title if still not present.
@@ -356,7 +356,7 @@ 
                         $value = htmlspecialchars(Helper::translate($value, 'tx_dlf_structures', $this->conf['pages']));
                         // Add page number for single pages.
                         if ($_value == 'page') {
-                            $value .= ' ' . intval($subpart['page']);
+                            $value .= ' '.intval($subpart['page']);
                         }
                     } elseif ($index_name == 'language' && !empty($value)) {
                         // Translate ISO 639 language code.
@@ -377,7 +377,7 @@ 
             }
             // Add thumbnail.
             if (!empty($subpart['thumbnail'])) {
-                $markerArray['###SUBTHUMBNAIL###'] = '<img alt="' . $imgAlt . '" src="' . $subpart['thumbnail'] . '" />';
+                $markerArray['###SUBTHUMBNAIL###'] = '<img alt="'.$imgAlt.'" src="'.$subpart['thumbnail'].'" />';
             }
             // Add preview.
             if (!empty($subpart['preview'])) {
@@ -491,7 +491,7 @@ 
                 || (isset($this->piVars['asc']) && $this->piVars['asc'] != $listMetadata['options']['order.asc'])
             ) {
                 // Update list's metadata.
-                $listMetadata['options']['params']['sort'] = [$this->piVars['order'] . "_sorting" => (bool) $this->piVars['asc'] ? 'asc' : 'desc'];
+                $listMetadata['options']['params']['sort'] = [$this->piVars['order']."_sorting" => (bool) $this->piVars['asc'] ? 'asc' : 'desc'];
                 $listMetadata['options']['order'] = $this->piVars['order'];
                 $listMetadata['options']['order.asc'] = (bool) $this->piVars['asc'];
                 // Reset pointer.
@@ -515,7 +515,7 @@ 
                 $this->list = $solr->search();
             }
             // Add list description
-            $listMetadata['description'] = '<p class="tx-dlf-search-numHits">' . htmlspecialchars(sprintf($this->pi_getLL('hits', ''), $this->list->metadata['options']['numberOfHits'], $this->list->metadata['options']['numberOfToplevelHits'])) . '</p>';
+            $listMetadata['description'] = '<p class="tx-dlf-search-numHits">'.htmlspecialchars(sprintf($this->pi_getLL('hits', ''), $this->list->metadata['options']['numberOfHits'], $this->list->metadata['options']['numberOfToplevelHits'])).'</p>';
             $this->list->metadata = $listMetadata;
             // Save updated list.
             $this->list->save();
@@ -544,7 +544,7 @@ 
         $markerArray['###LISTTITLE###'] = $this->list->metadata['label'];
         $markerArray['###LISTDESCRIPTION###'] = $this->list->metadata['description'];
         if (!empty($this->list->metadata['thumbnail'])) {
-            $markerArray['###LISTTHUMBNAIL###'] = '<img alt="" src="' . $this->list->metadata['thumbnail'] . '" />';
+            $markerArray['###LISTTHUMBNAIL###'] = '<img alt="" src="'.$this->list->metadata['thumbnail'].'" />';
         } else {
             $markerArray['###LISTTHUMBNAIL###'] = '';
         }

Upper-Lower-Casing +18 added lines, -18 removed lines

@@ -84,30 +84,30 @@ 
         $separator = '<span class="separator">' . htmlspecialchars($this->pi_getLL('separator', ' - ')) . '</span>';
         // Add link to previous page.
         if ($this->piVars['pointer'] > 0) {
-            $output = $this->pi_linkTP_keepPIvars(htmlspecialchars($this->pi_getLL('prevPage', '<')), ['pointer' => $this->piVars['pointer'] - 1], true) . $separator;
+            $output = $this->pi_linkTP_keepPIvars(htmlspecialchars($this->pi_getLL('prevPage', '<')), ['pointer' => $this->piVars['pointer'] - 1], TRUE) . $separator;
         } else {
             $output = '<span>' . htmlspecialchars($this->pi_getLL('prevPage', '<')) . '</span>' . $separator;
         }
         $i = 0;
-        $skip = null;
+        $skip = NULL;
         // Add links to pages.
         while ($i < $maxPages) {
             if ($i < 3 || ($i > $this->piVars['pointer'] - 3 && $i < $this->piVars['pointer'] + 3) || $i > $maxPages - 4) {
                 if ($this->piVars['pointer'] != $i) {
-                    $output .= $this->pi_linkTP_keepPIvars(htmlspecialchars(sprintf($this->pi_getLL('page', '%d'), $i + 1)), ['pointer' => $i], true) . $separator;
+                    $output .= $this->pi_linkTP_keepPIvars(htmlspecialchars(sprintf($this->pi_getLL('page', '%d'), $i + 1)), ['pointer' => $i], TRUE) . $separator;
                 } else {
                     $output .= '<span class="active">' . htmlspecialchars(sprintf($this->pi_getLL('page', '%d'), $i + 1)) . '</span>' . $separator;
                 }
-                $skip = true;
-            } elseif ($skip === true) {
+                $skip = TRUE;
+            } elseif ($skip === TRUE) {
                 $output .= '<span class="skip">' . htmlspecialchars($this->pi_getLL('skip', '...')) . '</span>' . $separator;
-                $skip = false;
+                $skip = FALSE;
             }
             $i++;
         }
         // Add link to next page.
         if ($this->piVars['pointer'] < $maxPages - 1) {
-            $output .= $this->pi_linkTP_keepPIvars(htmlspecialchars($this->pi_getLL('nextPage', '>')), ['pointer' => $this->piVars['pointer'] + 1], true);
+            $output .= $this->pi_linkTP_keepPIvars(htmlspecialchars($this->pi_getLL('nextPage', '>')), ['pointer' => $this->piVars['pointer'] + 1], TRUE);
         } else {
             $output .= '<span>' . htmlspecialchars($this->pi_getLL('nextPage', '>')) . '</span>';
         }
@@ -144,7 +144,7 @@ 
                     if ($index_name == 'title') {
                         // Get title of parent document if needed.
                         if (empty($value) && $this->conf['getTitle']) {
-                            $superiorTitle = Document::getTitle($this->list[$number]['uid'], true);
+                            $superiorTitle = Document::getTitle($this->list[$number]['uid'], TRUE);
                             if (!empty($superiorTitle)) {
                                 $value = '[' . $superiorTitle . ']';
                             }
@@ -166,7 +166,7 @@ 
                             'parameter' => $this->conf['targetPid'],
                             'forceAbsoluteUrl' => !empty($this->conf['forceAbsoluteUrl']) ? 1 : 0,
                             'forceAbsoluteUrl.' => ['scheme' => !empty($this->conf['forceAbsoluteUrl']) && !empty($this->conf['forceAbsoluteUrlHttps']) ? 'https' : 'http'],
-                            'additionalParams' => GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', true, false)
+                            'additionalParams' => GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', TRUE, FALSE)
                         ];
                         $value = $this->cObj->typoLink(htmlspecialchars($value), $conf);
                     } elseif ($index_name == 'owner' && !empty($value)) {
@@ -213,12 +213,12 @@ 
                 'parameter' => $this->conf['targetBasket'],
                 'forceAbsoluteUrl' => !empty($this->conf['forceAbsoluteUrl']) ? 1 : 0,
                 'forceAbsoluteUrl.' => ['scheme' => !empty($this->conf['forceAbsoluteUrl']) && !empty($this->conf['forceAbsoluteUrlHttps']) ? 'https' : 'http'],
-                'additionalParams' => GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', true, false)
+                'additionalParams' => GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', TRUE, FALSE)
             ];
             $link = $this->cObj->typoLink(htmlspecialchars($this->pi_getLL('addBasket', '')), $conf);
             $markerArray['###BASKETBUTTON###'] = $link;
         }
-        return $this->templateService->substituteMarkerArray($this->templateService->substituteSubpart($template['entry'], '###SUBTEMPLATE###', $subpart, true), $markerArray);
+        return $this->templateService->substituteMarkerArray($this->templateService->substituteSubpart($template['entry'], '###SUBTEMPLATE###', $subpart, TRUE), $markerArray);
     }
 
     /**
@@ -262,7 +262,7 @@ 
             'forceAbsoluteUrl.' => ['scheme' => !empty($this->conf['forceAbsoluteUrl']) && !empty($this->conf['forceAbsoluteUrlHttps']) ? 'https' : 'http']
         ];
         if (!empty($this->piVars['logicalPage'])) {
-            $linkConf['additionalParams'] = GeneralUtility::implodeArrayForUrl($this->prefixId, ['logicalPage' => $this->piVars['logicalPage']], '', true, false);
+            $linkConf['additionalParams'] = GeneralUtility::implodeArrayForUrl($this->prefixId, ['logicalPage' => $this->piVars['logicalPage']], '', TRUE, FALSE);
         }
         // Build HTML form.
         $sorting = '<form action="' . $this->cObj->typoLink_URL($linkConf) . '" method="get"><div><input type="hidden" name="id" value="' . $GLOBALS['TSFE']->id . '" />';
@@ -320,7 +320,7 @@ 
                     if ($index_name == 'title') {
                         // Get title of parent document if needed.
                         if (empty($value) && $this->conf['getTitle']) {
-                            $superiorTitle = Document::getTitle($subpart['uid'], true);
+                            $superiorTitle = Document::getTitle($subpart['uid'], TRUE);
                             if (!empty($superiorTitle)) {
                                 $value = '[' . $superiorTitle . ']';
                             }
@@ -344,7 +344,7 @@ 
                             'parameter' => $this->conf['targetPid'],
                             'forceAbsoluteUrl' => !empty($this->conf['forceAbsoluteUrl']) ? 1 : 0,
                             'forceAbsoluteUrl.' => ['scheme' => !empty($this->conf['forceAbsoluteUrl']) && !empty($this->conf['forceAbsoluteUrlHttps']) ? 'https' : 'http'],
-                            'additionalParams' => GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', true, false)
+                            'additionalParams' => GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', TRUE, FALSE)
                         ];
                         $value = $this->cObj->typoLink(htmlspecialchars($value), $conf);
                     } elseif ($index_name == 'owner' && !empty($value)) {
@@ -392,14 +392,14 @@ 
                     'parameter' => $this->conf['targetBasket'],
                     'forceAbsoluteUrl' => !empty($this->conf['forceAbsoluteUrl']) ? 1 : 0,
                     'forceAbsoluteUrl.' => ['scheme' => !empty($this->conf['forceAbsoluteUrl']) && !empty($this->conf['forceAbsoluteUrlHttps']) ? 'https' : 'http'],
-                    'additionalParams' => GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', true, false)
+                    'additionalParams' => GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', TRUE, FALSE)
                 ];
                 $link = $this->cObj->typoLink(htmlspecialchars($this->pi_getLL('addBasket', '')), $conf);
                 $markerArray['###SUBBASKETBUTTON###'] = $link;
             }
             $content .= $this->templateService->substituteMarkerArray($template['subentry'], $markerArray);
         }
-        return $this->templateService->substituteSubpart($this->templateService->getSubpart($this->template, '###SUBTEMPLATE###'), '###SUBENTRY###', $content, true);
+        return $this->templateService->substituteSubpart($this->templateService->getSubpart($this->template, '###SUBTEMPLATE###'), '###SUBENTRY###', $content, TRUE);
     }
 
     /**
@@ -460,7 +460,7 @@ 
     {
         $this->init($conf);
         // Don't cache the output.
-        $this->setCache(false);
+        $this->setCache(FALSE);
         // Load the list.
         $this->list = GeneralUtility::makeInstance(DocumentList::class);
         $currentEntry = $this->piVars['pointer'] * $this->conf['limit'];
@@ -557,7 +557,7 @@ 
         }
         $markerArray['###PAGEBROWSER###'] = $this->getPageBrowser();
         $markerArray['###SORTING###'] = $this->getSortingForm();
-        $content = $this->templateService->substituteMarkerArray($this->templateService->substituteSubpart($this->template, '###ENTRY###', $content, true), $markerArray);
+        $content = $this->templateService->substituteMarkerArray($this->templateService->substituteSubpart($this->template, '###ENTRY###', $content, TRUE), $markerArray);
         return $this->pi_wrapInBaseClass($content);
     }
 }

Classes/Hooks/ItemsProcFunc.php

Spacing +1 added lines, -1 removed lines

@@ -115,7 +115,7 @@
                         ->select(...explode(',', $fields))
                         ->from($table)
                         ->where(
-                            $queryBuilder->expr()->eq($table . '.pid', intval($page['uid'])),
+                            $queryBuilder->expr()->eq($table.'.pid', intval($page['uid'])),
                             $andWhere
                         )
                         ->orderBy($sorting)

Braces +8 added lines, -16 removed lines

@@ -24,8 +24,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class ItemsProcFunc
-{
+class ItemsProcFunc {
     /**
      * Helper to get flexform's items array for plugin "Collection"
      *
@@ -35,8 +34,7 @@ 
      *
      * @return void
      */
-    public function collectionList(&$params)
-    {
+    public function collectionList(&$params) {
         $this->generateList(
             $params,
             'label,uid',
@@ -54,8 +52,7 @@ 
      *
      * @return void
      */
-    public function extendedSearchList(&$params)
-    {
+    public function extendedSearchList(&$params) {
         $this->generateList(
             $params,
             'label,index_name',
@@ -74,8 +71,7 @@ 
      *
      * @return void
      */
-    public function facetsList(&$params)
-    {
+    public function facetsList(&$params) {
         $this->generateList(
             $params,
             'label,index_name',
@@ -98,8 +94,7 @@ 
      *
      * @return void
      */
-    protected function generateList(&$params, $fields, $table, $sorting, $andWhere = '')
-    {
+    protected function generateList(&$params, $fields, $table, $sorting, $andWhere = '') {
         $pages = $params['row']['pages'];
         if (!empty($pages)) {
             if (!is_array($pages)) {
@@ -140,8 +135,7 @@ 
      *
      * @return void
      */
-    public function libraryList(&$params)
-    {
+    public function libraryList(&$params) {
         $this->generateList(
             $params,
             'label,uid',
@@ -159,8 +153,7 @@ 
      *
      * @return void
      */
-    public function solrList(&$params)
-    {
+    public function solrList(&$params) {
         $this->generateList(
             $params,
             'label,uid',
@@ -178,8 +171,7 @@ 
      *
      * @return void
      */
-    public function toolList(&$params)
-    {
+    public function toolList(&$params) {
         foreach ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['dlf/Classes/Plugin/Toolbox.php']['tools'] as $class => $label) {
             $params['items'][] = [$GLOBALS['LANG']->sL($label), $class];
         }

Classes/Hooks/KitodoProductionHacks.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
                 }
                 $dmdIds = explode(' ', $id);
                 foreach ($dmdIds as $dmdId) {
-                    $recordIds = $xml->xpath('//mets:dmdSec[@ID="' . $dmdId . '"]//mods:mods/mods:recordInfo/mods:recordIdentifier');
+                    $recordIds = $xml->xpath('//mets:dmdSec[@ID="'.$dmdId.'"]//mods:mods/mods:recordInfo/mods:recordIdentifier');
                     if (!empty($recordIds)) {
                         $record_id = (string) $recordIds[0];
                         break;

Braces +2 added lines, -4 removed lines

@@ -20,8 +20,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class KitodoProductionHacks
-{
+class KitodoProductionHacks {
     /**
      * Hook for \Kitodo\Dlf\Common\MetsDocument::establishRecordId()
      * When using Kitodo.Production the record identifier is saved only in MODS, but not
@@ -34,8 +33,7 @@ 
      *
      * @return void
      */
-    public function construct_postProcessRecordId(\SimpleXMLElement &$xml, &$record_id)
-    {
+    public function construct_postProcessRecordId(\SimpleXMLElement &$xml, &$record_id) {
         if (!$record_id) {
             $xml->registerXPathNamespace('mods', 'http://www.loc.gov/mods/v3');
             // Get all logical structure nodes with metadata, but without associated METS-Pointers.

Classes/Module/NewTenant.php

Spacing +6 added lines, -6 removed lines

@@ -45,7 +45,7 @@ 
     protected function cmdAddMetadata()
     {
         // Include metadata definition file.
-        $metadataDefaults = include (ExtensionManagementUtility::extPath($this->extKey) . 'Resources/Private/Data/MetadataDefaults.php');
+        $metadataDefaults = include (ExtensionManagementUtility::extPath($this->extKey).'Resources/Private/Data/MetadataDefaults.php');
         $i = 0;
         // Build data array.
         foreach ($metadataDefaults as $index_name => $values) {
@@ -58,7 +58,7 @@ 
             }
             $data['tx_dlf_metadata'][uniqid('NEW')] = [
                 'pid' => intval($this->id),
-                'label' => $GLOBALS['LANG']->getLL('metadata.' . $index_name),
+                'label' => $GLOBALS['LANG']->getLL('metadata.'.$index_name),
                 'index_name' => $index_name,
                 'format' => implode(',', $formatIds),
                 'default_value' => $values['default_value'],
@@ -105,7 +105,7 @@ 
         // Build data array.
         $data['tx_dlf_solrcores'][uniqid('NEW')] = [
             'pid' => intval($this->id),
-            'label' => $GLOBALS['LANG']->getLL('solrcore') . ' (PID ' . $this->id . ')',
+            'label' => $GLOBALS['LANG']->getLL('solrcore').' (PID '.$this->id.')',
             'index_name' => '',
         ];
         $_ids = Helper::processDBasAdmin($data);
@@ -137,13 +137,13 @@ 
     protected function cmdAddStructure()
     {
         // Include structure definition file.
-        $structureDefaults = include (ExtensionManagementUtility::extPath($this->extKey) . 'Resources/Private/Data/StructureDefaults.php');
+        $structureDefaults = include (ExtensionManagementUtility::extPath($this->extKey).'Resources/Private/Data/StructureDefaults.php');
         // Build data array.
         foreach ($structureDefaults as $index_name => $values) {
             $data['tx_dlf_structures'][uniqid('NEW')] = [
                 'pid' => intval($this->id),
                 'toplevel' => $values['toplevel'],
-                'label' => $GLOBALS['LANG']->getLL('structure.' . $index_name),
+                'label' => $GLOBALS['LANG']->getLL('structure.'.$index_name),
                 'index_name' => $index_name,
                 'oai_name' => $values['oai_name'],
                 'thumbnail' => 0,
@@ -207,7 +207,7 @@ 
             // Should we do something?
             if (!empty($this->CMD)) {
                 // Sanitize input...
-                $_method = 'cmd' . ucfirst($this->CMD);
+                $_method = 'cmd'.ucfirst($this->CMD);
                 // ...and unset to prevent infinite looping.
                 unset($this->CMD);
                 if (method_exists($this, $_method)) {

Braces +4 added lines, -8 removed lines

@@ -27,8 +27,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class NewTenant extends \Kitodo\Dlf\Common\AbstractModule
-{
+class NewTenant extends \Kitodo\Dlf\Common\AbstractModule {
     protected $markerArray = [
         'CSH' => '',
         'MOD_MENU' => '',
@@ -42,8 +41,7 @@ 
      *
      * @return void
      */
-    protected function cmdAddMetadata()
-    {
+    protected function cmdAddMetadata() {
         // Include metadata definition file.
         $metadataDefaults = include (ExtensionManagementUtility::extPath($this->extKey) . 'Resources/Private/Data/MetadataDefaults.php');
         $i = 0;
@@ -100,8 +98,7 @@ 
      *
      * @return void
      */
-    protected function cmdAddSolrCore()
-    {
+    protected function cmdAddSolrCore() {
         // Build data array.
         $data['tx_dlf_solrcores'][uniqid('NEW')] = [
             'pid' => intval($this->id),
@@ -134,8 +131,7 @@ 
      *
      * @return void
      */
-    protected function cmdAddStructure()
-    {
+    protected function cmdAddStructure() {
         // Include structure definition file.
         $structureDefaults = include (ExtensionManagementUtility::extPath($this->extKey) . 'Resources/Private/Data/StructureDefaults.php');
         // Build data array.

Upper-Lower-Casing +16 added lines, -16 removed lines

@@ -74,20 +74,20 @@ 
             ];
             $i++;
         }
-        $_ids = Helper::processDBasAdmin($data, [], true);
+        $_ids = Helper::processDBasAdmin($data, [], TRUE);
         // Check for failed inserts.
         if (count($_ids) == $i) {
             // Fine.
             Helper::addMessage(
                 Helper::getMessage('flash.metadataAddedMsg'),
-                Helper::getMessage('flash.metadataAdded', true),
+                Helper::getMessage('flash.metadataAdded', TRUE),
                 \TYPO3\CMS\Core\Messaging\FlashMessage::OK
             );
         } else {
             // Something went wrong.
             Helper::addMessage(
                 Helper::getMessage('flash.metadataNotAddedMsg'),
-                Helper::getMessage('flash.metadataNotAdded', true),
+                Helper::getMessage('flash.metadataNotAdded', TRUE),
                 \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR
             );
         }
@@ -114,14 +114,14 @@ 
             // Fine.
             Helper::addMessage(
                 Helper::getMessage('flash.solrcoreAddedMsg'),
-                Helper::getMessage('flash.solrcoreAdded', true),
+                Helper::getMessage('flash.solrcoreAdded', TRUE),
                 \TYPO3\CMS\Core\Messaging\FlashMessage::OK
             );
         } else {
             // Something went wrong.
             Helper::addMessage(
                 Helper::getMessage('flash.solrcoreNotAddedMsg'),
-                Helper::getMessage('flash.solrcoreNotAdded', true),
+                Helper::getMessage('flash.solrcoreNotAdded', TRUE),
                 \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR
             );
         }
@@ -149,20 +149,20 @@ 
                 'thumbnail' => 0,
             ];
         }
-        $_ids = Helper::processDBasAdmin($data, [], true);
+        $_ids = Helper::processDBasAdmin($data, [], TRUE);
         // Check for failed inserts.
         if (count($_ids) == count($structureDefaults)) {
             // Fine.
             Helper::addMessage(
                 Helper::getMessage('flash.structureAddedMsg'),
-                Helper::getMessage('flash.structureAdded', true),
+                Helper::getMessage('flash.structureAdded', TRUE),
                 \TYPO3\CMS\Core\Messaging\FlashMessage::OK
             );
         } else {
             // Something went wrong.
             Helper::addMessage(
                 Helper::getMessage('flash.structureNotAddedMsg'),
-                Helper::getMessage('flash.structureNotAdded', true),
+                Helper::getMessage('flash.structureNotAdded', TRUE),
                 \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR
             );
         }
@@ -197,7 +197,7 @@ 
             if ($this->pageInfo['doktype'] != 254) {
                 Helper::addMessage(
                     Helper::getMessage('flash.wrongPageTypeMsg'),
-                    Helper::getMessage('flash.wrongPageType', true),
+                    Helper::getMessage('flash.wrongPageType', TRUE),
                     \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR
                 );
                 $this->markerArray['CONTENT'] .= Helper::renderFlashMessages();
@@ -232,7 +232,7 @@ 
                 // Fine.
                 Helper::addMessage(
                     Helper::getMessage('flash.structureOkayMsg'),
-                    Helper::getMessage('flash.structureOkay', true),
+                    Helper::getMessage('flash.structureOkay', TRUE),
                     \TYPO3\CMS\Core\Messaging\FlashMessage::OK
                 );
             } else {
@@ -240,7 +240,7 @@ 
                 $url = GeneralUtility::locationHeaderUrl(GeneralUtility::linkThisScript(['id' => $this->id, 'CMD' => 'addStructure']));
                 Helper::addMessage(
                     sprintf(Helper::getMessage('flash.structureNotOkayMsg'), $url),
-                    Helper::getMessage('flash.structureNotOkay', true),
+                    Helper::getMessage('flash.structureNotOkay', TRUE),
                     \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR
                 );
             }
@@ -262,7 +262,7 @@ 
                 // Fine.
                 Helper::addMessage(
                     Helper::getMessage('flash.metadataOkayMsg'),
-                    Helper::getMessage('flash.metadataOkay', true),
+                    Helper::getMessage('flash.metadataOkay', TRUE),
                     \TYPO3\CMS\Core\Messaging\FlashMessage::OK
                 );
             } else {
@@ -270,7 +270,7 @@ 
                 $url = GeneralUtility::locationHeaderUrl(GeneralUtility::linkThisScript(['id' => $this->id, 'CMD' => 'addMetadata']));
                 Helper::addMessage(
                     sprintf(Helper::getMessage('flash.metadataNotOkayMsg'), $url),
-                    Helper::getMessage('flash.metadataNotOkay', true),
+                    Helper::getMessage('flash.metadataNotOkay', TRUE),
                     \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR
                 );
             }
@@ -300,7 +300,7 @@ 
                     // Fine.
                     Helper::addMessage(
                         Helper::getMessage('flash.solrcoreOkayMsg'),
-                        Helper::getMessage('flash.solrcoreOkay', true),
+                        Helper::getMessage('flash.solrcoreOkay', TRUE),
                         \TYPO3\CMS\Core\Messaging\FlashMessage::OK
                     );
                 } else {
@@ -308,7 +308,7 @@ 
                     $url = GeneralUtility::locationHeaderUrl(GeneralUtility::linkThisScript(['id' => $this->id, 'CMD' => 'addSolrcore']));
                     Helper::addMessage(
                         sprintf(Helper::getMessage('flash.solrcoreDeprecatedMsg'), $url),
-                        Helper::getMessage('flash.solrcoreDeprecatedOkay', true),
+                        Helper::getMessage('flash.solrcoreDeprecatedOkay', TRUE),
                         \TYPO3\CMS\Core\Messaging\FlashMessage::NOTICE
                     );
                 }
@@ -317,7 +317,7 @@ 
                 $url = GeneralUtility::locationHeaderUrl(GeneralUtility::linkThisScript(['id' => $this->id, 'CMD' => 'addSolrcore']));
                 Helper::addMessage(
                     sprintf(Helper::getMessage('flash.solrcoreMissingMsg'), $url),
-                    Helper::getMessage('flash.solrcoreMissing', true),
+                    Helper::getMessage('flash.solrcoreMissing', TRUE),
                     \TYPO3\CMS\Core\Messaging\FlashMessage::WARNING
                 );
             }

Classes/Format/TeiHeader.php

Braces +2 added lines, -4 removed lines

@@ -20,8 +20,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class TeiHeader implements \Kitodo\Dlf\Common\MetadataInterface
-{
+class TeiHeader implements \Kitodo\Dlf\Common\MetadataInterface {
     /**
      * This extracts the essential TEIHDR metadata from XML
      *
@@ -32,8 +31,7 @@ 
      *
      * @return void
      */
-    public function extractMetadata(\SimpleXMLElement $xml, array &$metadata)
-    {
+    public function extractMetadata(\SimpleXMLElement $xml, array &$metadata) {
         $xml->registerXPathNamespace('teihdr', 'http://www.tei-c.org/ns/1.0');
     }
 }

Classes/Format/Mods.php

Spacing +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
                 }
                 // Append "valueURI" to name using Unicode unit separator.
                 if (isset($authors[$i]['valueURI'])) {
-                    $metadata['author'][$i] .= chr(31) . (string) $authors[$i]['valueURI'];
+                    $metadata['author'][$i] .= chr(31).(string) $authors[$i]['valueURI'];
                 }
             }
         }

Braces +2 added lines, -4 removed lines

@@ -20,8 +20,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class Mods implements \Kitodo\Dlf\Common\MetadataInterface
-{
+class Mods implements \Kitodo\Dlf\Common\MetadataInterface {
     /**
      * This extracts the essential MODS metadata from XML
      *
@@ -32,8 +31,7 @@ 
      *
      * @return void
      */
-    public function extractMetadata(\SimpleXMLElement $xml, array &$metadata)
-    {
+    public function extractMetadata(\SimpleXMLElement $xml, array &$metadata) {
         $xml->registerXPathNamespace('mods', 'http://www.loc.gov/mods/v3');
         // Get "author" and "author_sorting".
         $authors = $xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]');