Passed
Pull Request — master (#123)
by Sebastian
03:26
created
Classes/Controller/AbstractController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                 if ($this->document) {
126 126
                     $doc = Doc::getInstance($this->document->getLocation(), $this->settings, true);
127 127
                 } else {
128
-                    $this->logger->error('Invalid UID "' . $requestData['id'] . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
128
+                    $this->logger->error('Invalid UID "'.$requestData['id'].'" or PID "'.$this->settings['storagePid'].'" for document loading');
129 129
                 }
130 130
             } else if (GeneralUtility::isValidUrl($requestData['id'])) {
131 131
 
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 
144 144
                     $this->document->setLocation($requestData['id']);
145 145
                 } else {
146
-                    $this->logger->error('Invalid location given "' . $requestData['id'] . '" for document loading');
146
+                    $this->logger->error('Invalid location given "'.$requestData['id'].'" for document loading');
147 147
                 }
148 148
             }
149 149
 
@@ -160,11 +160,11 @@  discard block
 block discarded – undo
160 160
                 if ($this->document !== null && $doc !== null) {
161 161
                     $this->document->setDoc($doc);
162 162
                 } else {
163
-                    $this->logger->error('Failed to load document with record ID "' . $requestData['recordId'] . '"');
163
+                    $this->logger->error('Failed to load document with record ID "'.$requestData['recordId'].'"');
164 164
                 }
165 165
             }
166 166
         } else {
167
-            $this->logger->error('Invalid ID "' . $requestData['id'] . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
167
+            $this->logger->error('Invalid ID "'.$requestData['id'].'" or PID "'.$this->settings['storagePid'].'" for document loading');
168 168
         }
169 169
     }
170 170
 
Please login to merge, or discard this patch.
Classes/Controller/CollectionController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -96,14 +96,14 @@
 block discarded – undo
96 96
         foreach ($collections as $collection) {
97 97
             $solr_query = '';
98 98
             if ($collection->getIndexSearch() != '') {
99
-                $solr_query .= '(' . $collection->getIndexSearch() . ')';
99
+                $solr_query .= '('.$collection->getIndexSearch().')';
100 100
             } else {
101
-                $solr_query .= 'collection:("' . Solr::escapeQuery($collection->getIndexName()) . '")';
101
+                $solr_query .= 'collection:("'.Solr::escapeQuery($collection->getIndexName()).'")';
102 102
             }
103
-            $params['query'] = $solr_query . ' AND partof:0 AND toplevel:true';
103
+            $params['query'] = $solr_query.' AND partof:0 AND toplevel:true';
104 104
             $partOfNothing = $solr->search_raw($params);
105 105
 
106
-            $params['query'] = $solr_query . ' AND NOT partof:0 AND toplevel:true';
106
+            $params['query'] = $solr_query.' AND NOT partof:0 AND toplevel:true';
107 107
             $partOfSomething = $solr->search_raw($params);
108 108
             // Titles are all documents that are "root" elements i.e. partof == 0
109 109
             $collectionInfo['titles'] = [];
Please login to merge, or discard this patch.
Classes/Controller/ToolboxController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
                 $image['mimetypeLabel'] = $mimetypeLabel;
254 254
                 break;
255 255
             } else {
256
-                $this->logger->warning('File not found in fileGrp "' . $fileGrp . '"');
256
+                $this->logger->warning('File not found in fileGrp "'.$fileGrp.'"');
257 257
             }
258 258
         }
259 259
         return $image;
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
             empty($page1Link)
345 345
             && empty($page2Link)
346 346
         ) {
347
-            $this->logger->warning('File not found in fileGrps "' . $this->extConf['fileGrpDownload'] . '"');
347
+            $this->logger->warning('File not found in fileGrps "'.$this->extConf['fileGrpDownload'].'"');
348 348
         }
349 349
 
350 350
         if (!empty($page1Link)) {
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
         if (!empty($workLink)) {
384 384
             $workLink = $workLink;
385 385
         } else {
386
-            $this->logger->warning('File not found in fileGrps "' . $this->extConf['fileGrpDownload'] . '"');
386
+            $this->logger->warning('File not found in fileGrps "'.$this->extConf['fileGrpDownload'].'"');
387 387
         }
388 388
         return $workLink;
389 389
     }
Please login to merge, or discard this patch.
Classes/Controller/NavigationController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
 
75 75
         $pageOptions = [];
76 76
         for ($i = 1; $i <= $this->document->getDoc()->numPages; $i++) {
77
-            $pageOptions[$i] = '[' . $i . ']' . ($this->document->getDoc()->physicalStructureInfo[$this->document->getDoc()->physicalStructure[$i]]['orderlabel'] ? ' - ' . htmlspecialchars($this->document->getDoc()->physicalStructureInfo[$this->document->getDoc()->physicalStructure[$i]]['orderlabel']) : '');
77
+            $pageOptions[$i] = '['.$i.']'.($this->document->getDoc()->physicalStructureInfo[$this->document->getDoc()->physicalStructure[$i]]['orderlabel'] ? ' - '.htmlspecialchars($this->document->getDoc()->physicalStructureInfo[$this->document->getDoc()->physicalStructure[$i]]['orderlabel']) : '');
78 78
         }
79 79
         $this->view->assign('pageOptions', $pageOptions);
80 80
 
Please login to merge, or discard this patch.
Classes/Controller/TableOfContentsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@
 block discarded – undo
140 140
                 }
141 141
             }
142 142
             // Append "IFSUB" to "ITEM_STATE" if this entry has sub-entries.
143
-            $entryArray['ITEM_STATE'] = ($entryArray['ITEM_STATE'] == 'NO' ? 'IFSUB' : $entryArray['ITEM_STATE'] . 'IFSUB');
143
+            $entryArray['ITEM_STATE'] = ($entryArray['ITEM_STATE'] == 'NO' ? 'IFSUB' : $entryArray['ITEM_STATE'].'IFSUB');
144 144
         }
145 145
         return $entryArray;
146 146
     }
Please login to merge, or discard this patch.
Classes/Hooks/Form/FieldInformation/SolrCoreStatus.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
                     $uptimeInSeconds = floor($response->getUptime() / 1000);
56 56
                     $dateTimeFrom = new \DateTime('@0');
57 57
                     $dateTimeTo = new \DateTime("@$uptimeInSeconds");
58
-                    $uptime = $dateTimeFrom->diff($dateTimeTo)->format('%a ' . Helper::getLanguageService()->getLL('flash.days') . ', %H:%I:%S');
58
+                    $uptime = $dateTimeFrom->diff($dateTimeTo)->format('%a '.Helper::getLanguageService()->getLL('flash.days').', %H:%I:%S');
59 59
                     $numDocuments = $response->getNumberOfDocuments();
60 60
                     $startTime = $response->getStartTime() ? strftime('%c', $response->getStartTime()->getTimestamp()) : 'N/A';
61 61
                     $lastModified = $response->getLastModified() ? strftime('%c', $response->getLastModified()->getTimestamp()) : 'N/A';
Please login to merge, or discard this patch.
Classes/Hooks/DataHandler.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -139,10 +139,10 @@  discard block
 block discarded – undo
139 139
                     ) {
140 140
                         // Get current configuration.
141 141
                         $result = $queryBuilder
142
-                            ->select($table . '.is_listed AS is_listed')
142
+                            ->select($table.'.is_listed AS is_listed')
143 143
                             ->from($table)
144 144
                             ->where(
145
-                                $queryBuilder->expr()->eq($table . '.uid', intval($id)),
145
+                                $queryBuilder->expr()->eq($table.'.uid', intval($id)),
146 146
                                 Helper::whereExpression($table)
147 147
                             )
148 148
                             ->setMaxResults(1)
@@ -164,10 +164,10 @@  discard block
 block discarded – undo
164 164
                     ) {
165 165
                         // Get current configuration.
166 166
                         $result = $queryBuilder
167
-                            ->select($table . '.index_autocomplete AS index_autocomplete')
167
+                            ->select($table.'.index_autocomplete AS index_autocomplete')
168 168
                             ->from($table)
169 169
                             ->where(
170
-                                $queryBuilder->expr()->eq($table . '.uid', intval($id)),
170
+                                $queryBuilder->expr()->eq($table.'.uid', intval($id)),
171 171
                                 Helper::whereExpression($table)
172 172
                             )
173 173
                             ->setMaxResults(1)
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
                                 if ($solr->ready) {
243 243
                                     // Delete Solr document.
244 244
                                     $updateQuery = $solr->service->createUpdate();
245
-                                    $updateQuery->addDeleteQuery('uid:' . $id);
245
+                                    $updateQuery->addDeleteQuery('uid:'.$id);
246 246
                                     $updateQuery->addCommit();
247 247
                                     $solr->service->update($updateQuery);
248 248
                                 }
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
                                     $document->setDoc($doc);
255 255
                                     Indexer::add($document);
256 256
                                 } else {
257
-                                    $this->logger->error('Failed to re-index document with UID ' . $id);
257
+                                    $this->logger->error('Failed to re-index document with UID '.$id);
258 258
                                 }
259 259
                             }
260 260
                         }
@@ -321,7 +321,7 @@  discard block
 block discarded – undo
321 321
                         if ($solr->ready) {
322 322
                             // Delete Solr document.
323 323
                             $updateQuery = $solr->service->createUpdate();
324
-                            $updateQuery->addDeleteQuery('uid:' . $id);
324
+                            $updateQuery->addDeleteQuery('uid:'.$id);
325 325
                             $updateQuery->addCommit();
326 326
                             $solr->service->update($updateQuery);
327 327
                             if ($command == 'delete') {
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
                             $document->setDoc($doc);
337 337
                             Indexer::add($document);
338 338
                         } else {
339
-                            $this->logger->error('Failed to re-index document with UID ' . $id);
339
+                            $this->logger->error('Failed to re-index document with UID '.$id);
340 340
                         }
341 341
                         break;
342 342
                 }
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
                             // Nothing to do here.
388 388
                         }
389 389
                     }
390
-                    $this->logger->warning('Core ' . $resArray['core'] . ' could not be deleted from Apache Solr');
390
+                    $this->logger->warning('Core '.$resArray['core'].' could not be deleted from Apache Solr');
391 391
                 }
392 392
             }
393 393
         }
Please login to merge, or discard this patch.
Classes/Hooks/ItemsProcFunc.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -126,8 +126,8 @@
 block discarded – undo
126 126
             ->select(...explode(',', $fields))
127 127
             ->from($table)
128 128
             ->where(
129
-                $queryBuilder->expr()->eq($table . '.pid', intval($this->storagePid)),
130
-                $queryBuilder->expr()->in($table . '.sys_language_uid', [-1, 0]),
129
+                $queryBuilder->expr()->eq($table.'.pid', intval($this->storagePid)),
130
+                $queryBuilder->expr()->in($table.'.sys_language_uid', [-1, 0]),
131 131
                 $andWhere
132 132
             )
133 133
             ->orderBy($sorting)
Please login to merge, or discard this patch.
Classes/Hooks/ThumbnailCustomElement.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
         // parameters are available in $this->data['parameterArray']['fieldConf']['config']['parameters']
23 23
         $result = $this->initializeResultArray();
24 24
         if (!empty($this->data['databaseRow']['thumbnail'])) {
25
-            $result['html'] = '<img alt="Thumbnail" title="" src="' . $this->data['databaseRow']['thumbnail'] . '" />';
25
+            $result['html'] = '<img alt="Thumbnail" title="" src="'.$this->data['databaseRow']['thumbnail'].'" />';
26 26
         } else {
27 27
             $result['html'] = '';
28 28
         }
Please login to merge, or discard this patch.