Erikmitk / kitodo-presentation

Classes/Controller/AudioPlayerController.php

Spacing +4 added lines, -4 removed lines

@@ -52,12 +52,12 @@
             $(document).ready(function() {
                 AudioPlayer = new dlfAudioPlayer({
                     audio: {
-                        mimeType: "' . $this->audio['mimetype'] . '",
-                        title: "' . $this->audio['label'] . '",
-                        url:  "' . $this->audio['url'] . '"
+                        mimeType: "' . $this->audio['mimetype'].'",
+                        title: "' . $this->audio['label'].'",
+                        url:  "' . $this->audio['url'].'"
                     },
                     parentElId: "tx-dlf-audio",
-                    swfPath: "' . PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath('dlf')) . 'Resources/Public/JavaScript/jPlayer/jquery.jplayer.swf"
+                    swfPath: "' . PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath('dlf')).'Resources/Public/JavaScript/jPlayer/jquery.jplayer.swf"
                 });
             });
         ';

Classes/Api/Orcid/Profile.php

Spacing +1 added lines, -1 removed lines

@@ -129,7 +129,7 @@
             $this->raw->registerXPathNamespace('personal-details', 'http://www.orcid.org/ns/personal-details');
             $givenNames = $this->raw->xpath('./personal-details:name/personal-details:given-names');
             $familyName = $this->raw->xpath('./personal-details:name/personal-details:family-name');
-            return (string) $givenNames[0] . ' ' . (string) $familyName[0];
+            return (string) $givenNames[0].' '.(string) $familyName[0];
         } else {
             $this->logger->warning('No name found for given ORCID');
             return false;

Tests/routeFunctionalInstance.php

Spacing +3 added lines, -3 removed lines

@@ -15,10 +15,10 @@
 preg_match("@.*/(?:acceptance|functional-[a-z\d]+)@", $_SERVER['REQUEST_URI'], $matches);
 
 if (!empty($matches)) {
-    $root = realpath($_SERVER['DOCUMENT_ROOT'] . $matches[0]);
+    $root = realpath($_SERVER['DOCUMENT_ROOT'].$matches[0]);
     if ($root !== false) {
-        putenv('TYPO3_PATH_ROOT=' . $root);
-        putenv('TYPO3_PATH_APP=' . $root);
+        putenv('TYPO3_PATH_ROOT='.$root);
+        putenv('TYPO3_PATH_APP='.$root);
     }
 }
 

Classes/Hooks/KitodoProductionHacks.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
                 }
                 $dmdIds = explode(' ', $id);
                 foreach ($dmdIds as $dmdId) {
-                    $recordIds = $xml->xpath('//mets:dmdSec[@ID="' . $dmdId . '"]//mods:mods/mods:recordInfo/mods:recordIdentifier');
+                    $recordIds = $xml->xpath('//mets:dmdSec[@ID="'.$dmdId.'"]//mods:mods/mods:recordInfo/mods:recordIdentifier');
                     if (!empty($recordIds)) {
                         $recordId = (string) $recordIds[0];
                         break;

Classes/Updates/FileLocationUpdater.php

Spacing +4 added lines, -4 removed lines

@@ -190,9 +190,9 @@ 
                             $queryBuilder->createNamedParameter('', \PDO::PARAM_STR)
                         ),
                         $queryBuilder->expr()->comparison(
-                            'CAST(CAST(' . $queryBuilder->quoteIdentifier($this->fieldsToMigrate[$table]) . ' AS DECIMAL) AS CHAR)',
+                            'CAST(CAST('.$queryBuilder->quoteIdentifier($this->fieldsToMigrate[$table]).' AS DECIMAL) AS CHAR)',
                             ExpressionBuilder::NEQ,
-                            'CAST(' . $queryBuilder->quoteIdentifier($this->fieldsToMigrate[$table]) . ' AS CHAR)'
+                            'CAST('.$queryBuilder->quoteIdentifier($this->fieldsToMigrate[$table]).' AS CHAR)'
                         )
                     )
                     ->orderBy('uid')
@@ -205,7 +205,7 @@ 
                 }
             } catch (Exception $e) {
                 throw new \RuntimeException(
-                    'Database query failed. Error was: ' . $e->getPrevious()->getMessage(),
+                    'Database query failed. Error was: '.$e->getPrevious()->getMessage(),
                     1511950673
                 );
             }
@@ -271,7 +271,7 @@ 
         $connectionPool = GeneralUtility::makeInstance(ConnectionPool::class);
 
         $fileUid = null;
-        $sourcePath = Environment::getPublicPath() . '/' . $fieldItem;
+        $sourcePath = Environment::getPublicPath().'/'.$fieldItem;
 
         // maybe the file was already moved, so check if the original file still exists
         if (file_exists($sourcePath)) {

Classes/ExpressionLanguage/DocumentTypeFunctionProvider.php

Spacing +4 added lines, -4 removed lines

@@ -181,7 +181,7 @@ 
                 if ($this->document) {
                     $doc = AbstractDocument::getInstance($this->document->getLocation(), ['storagePid' => $pid], true);
                 } else {
-                    $this->logger->error('Invalid UID "' . $requestData['id'] . '" or PID "' . $pid . '" for document loading');
+                    $this->logger->error('Invalid UID "'.$requestData['id'].'" or PID "'.$pid.'" for document loading');
                 }
             } else if (GeneralUtility::isValidUrl($requestData['id'])) {
 
@@ -199,7 +199,7 @@ 
 
                     $this->document->setLocation($requestData['id']);
                 } else {
-                    $this->logger->error('Invalid location given "' . $requestData['id'] . '" for document loading');
+                    $this->logger->error('Invalid location given "'.$requestData['id'].'" for document loading');
                 }
             }
 
@@ -216,11 +216,11 @@ 
                 if ($doc !== null) {
                     $this->document->setCurrentDocument($doc);
                 } else {
-                    $this->logger->error('Failed to load document with record ID "' . $requestData['recordId'] . '"');
+                    $this->logger->error('Failed to load document with record ID "'.$requestData['recordId'].'"');
                 }
             }
         } else {
-            $this->logger->error('Empty UID or invalid PID "' . $pid . '" for document loading');
+            $this->logger->error('Empty UID or invalid PID "'.$pid.'" for document loading');
         }
     }
 }

Classes/Controller/AbstractController.php

Spacing +8 added lines, -8 removed lines

@@ -145,11 +145,11 @@ 
                 if ($doc !== null) {
                     $this->document->setCurrentDocument($doc);
                 } else {
-                    $this->logger->error('Failed to load document with record ID "' . $this->requestData['recordId'] . '"');
+                    $this->logger->error('Failed to load document with record ID "'.$this->requestData['recordId'].'"');
                 }
             }
         } else {
-            $this->logger->error('Invalid ID "' . $documentId . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
+            $this->logger->error('Invalid ID "'.$documentId.'" or PID "'.$this->settings['storagePid'].'" for document loading');
         }
     }
 
@@ -245,7 +245,7 @@ 
             && !MathUtility::canBeInterpretedAsInteger($this->requestData['id'])
             && !GeneralUtility::isValidUrl($this->requestData['id'])
         ) {
-            $this->logger->warning('Invalid ID or URI "' . $this->requestData['id'] . '" for document loading');
+            $this->logger->warning('Invalid ID or URI "'.$this->requestData['id'].'" for document loading');
             unset($this->requestData['id']);
         }
 
@@ -331,7 +331,7 @@ 
         $pages = [];
         $pagesSect = [];
         $aRange = [];
-        $nRange = 5;    // ToDo: should be made configurable
+        $nRange = 5; // ToDo: should be made configurable
 
         // lower limit of the range
         $nBottom = $currentPageNumber - $nRange;
@@ -346,7 +346,7 @@ 
 
         // check whether the first screen page is > 1, if yes then points must be added
         if ($aRange[0] > 1) {
-            array_push($pagesSect, ['label' => '...','startRecordNumber' => '...']);
+            array_push($pagesSect, ['label' => '...', 'startRecordNumber' => '...']);
         };
         $lastStartRecordNumberGrid = 0; // due to validity outside the loop
         foreach (range($firstPage, $lastPage) as $i) {
@@ -389,7 +389,7 @@ 
 
                 // Check if screen page is in range
                 if (in_array($i, $aRange)) {
-                    array_push($pagesSect, ['label' => $i,'startRecordNumber' => $startRecordNumber]);
+                    array_push($pagesSect, ['label' => $i, 'startRecordNumber' => $startRecordNumber]);
                 };
             };
         };
@@ -451,7 +451,7 @@ 
         if ($this->document) {
             $doc = AbstractDocument::getInstance($this->document->getLocation(), $this->settings, true);
         } else {
-            $this->logger->error('Invalid UID "' . $documentId . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
+            $this->logger->error('Invalid UID "'.$documentId.'" or PID "'.$this->settings['storagePid'].'" for document loading');
         }
 
         return $doc;
@@ -489,7 +489,7 @@ 
 
             $this->document->setLocation($documentId);
         } else {
-            $this->logger->error('Invalid location given "' . $documentId . '" for document loading');
+            $this->logger->error('Invalid location given "'.$documentId.'" for document loading');
         }
 
         return $doc;

Classes/Controller/OaiPmhController.php

Spacing +11 added lines, -11 removed lines

@@ -250,10 +250,10 @@ 
             if ($root->item(0) instanceof \DOMNode) {
                 $mets = $xml->saveXML($root->item(0));
             } else {
-                $this->logger->error('No METS part found in document with location "' . $record['location'] . '"');
+                $this->logger->error('No METS part found in document with location "'.$record['location'].'"');
             }
         } else {
-            $this->logger->error('Could not load XML file from "' . $record['location'] . '"');
+            $this->logger->error('Could not load XML file from "'.$record['location'].'"');
         }
         return $mets;
     }
@@ -421,7 +421,7 @@ 
             $pageSettings = $this->configurationManager->getConfiguration($this->configurationManager::CONFIGURATION_TYPE_FULL_TYPOSCRIPT);
             $storagePid = $pageSettings["plugin."]["tx_dlf."]["persistence."]["storagePid"];
             if ($storagePid > 0) {
-                $this->logger->notice('No records found with PID ' . $storagePid);
+                $this->logger->notice('No records found with PID '.$storagePid);
             } else {
                 $this->logger->notice('No records found');
             }
@@ -504,7 +504,7 @@ 
             if (!empty($resArray)) {
                 // check, if all required fields are available for a given identifier
                 foreach ($details['requiredFields'] as $required) {
-                    $methodName = 'get' . GeneralUtility::underscoredToUpperCamelCase($required);
+                    $methodName = 'get'.GeneralUtility::underscoredToUpperCamelCase($required);
                     if (empty($resArray->$methodName())) {
                         // Skip metadata formats whose requirements are not met.
                         continue 2;
@@ -610,9 +610,9 @@ 
             $resArray = $result->fetchAssociative();
             if ($resArray) {
                 if ($resArray['index_query'] != "") {
-                    $solrQuery .= '(' . $resArray['index_query'] . ')';
+                    $solrQuery .= '('.$resArray['index_query'].')';
                 } else {
-                    $solrQuery .= 'collection:' . '"' . $resArray['index_name'] . '"';
+                    $solrQuery .= 'collection:'.'"'.$resArray['index_name'].'"';
                 }
             } else {
                 $this->error = 'noSetHierarchy';
@@ -624,7 +624,7 @@ 
         }
         // Check for required fields.
         foreach ($this->formats[$this->parameters['metadataPrefix']]['requiredFields'] as $required) {
-            $solrQuery .= ' NOT ' . $required . ':""';
+            $solrQuery .= ' NOT '.$required.':""';
         }
         // toplevel="true" is always required
         $solrQuery .= ' AND toplevel:true';
@@ -638,7 +638,7 @@ 
             return $documentSet;
         }
 
-        $solrQuery .= ' AND timestamp:[' . $from . ' TO ' . $until . ']';
+        $solrQuery .= ' AND timestamp:['.$from.' TO '.$until.']';
 
         $solr = Solr::getInstance($this->settings['solrcore']);
         if (!$solr->ready) {
@@ -729,7 +729,7 @@ 
      */
     private function getDate(string $dateType)
     {
-        return strptime($this->parameters[$dateType], '%Y-%m-%dT%H:%M:%SZ') ?: strptime($this->parameters[$dateType], '%Y-%m-%d');
+        return strptime($this->parameters[$dateType], '%Y-%m-%dT%H:%M:%SZ') ? : strptime($this->parameters[$dateType], '%Y-%m-%d');
     }
 
     /**
@@ -752,7 +752,7 @@ 
             $date['tm_mday'],
             $date['tm_year'] + 1900
         );
-        return date("Y-m-d", $timestamp) . 'T' . date("H:i:s", $timestamp) . $end;
+        return date("Y-m-d", $timestamp).'T'.date("H:i:s", $timestamp).$end;
     }
 
     /**
@@ -865,7 +865,7 @@ 
         $resumptionTokenInfo['cursor'] = $currentCursor;
         $resumptionTokenInfo['completeListSize'] = $documentListSet['metadata']['completeListSize'];
         $expireDateTime = new \DateTime();
-        $expireDateTime->add(new \DateInterval('PT' . $this->settings['expired'] . 'S'));
+        $expireDateTime->add(new \DateInterval('PT'.$this->settings['expired'].'S'));
         $resumptionTokenInfo['expired'] = $expireDateTime;
 
         $omitResumptionToken = $currentCursor === 0 && $numShownDocuments >= $documentListSet['metadata']['completeListSize'];

Classes/Controller/NavigationController.php

Spacing +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
         $pageOptions = [];
         for ($i = 1; $i <= $this->document->getCurrentDocument()->numPages; $i++) {
             $orderLabel = $this->document->getCurrentDocument()->physicalStructureInfo[$this->document->getCurrentDocument()->physicalStructure[$i]]['orderlabel'];
-            $pageOptions[$i] = '[' . $i . ']' . ($orderLabel ? ' - ' . htmlspecialchars($orderLabel) : '');
+            $pageOptions[$i] = '['.$i.']'.($orderLabel ? ' - '.htmlspecialchars($orderLabel) : '');
         }
         $this->view->assign('pageOptions', $pageOptions);