Erikmitk / kitodo-presentation

Classes/Command/IndexCommand.php

Braces +1 added lines, -2 removed lines

@@ -31,8 +31,7 @@
  *
  * @access public
  */
-class IndexCommand extends BaseCommand
-{
+class IndexCommand extends BaseCommand {
 
     /**
      * Configure the command by defining the name, options and arguments

Spacing +12 added lines, -12 removed lines

@@ -98,7 +98,7 @@ 
         $this->initializeRepositories((int) $input->getOption('pid'));
 
         if ($this->storagePid == 0) {
-            $io->error('ERROR: No valid PID (' . $this->storagePid . ') given.');
+            $io->error('ERROR: No valid PID ('.$this->storagePid.') given.');
             return BaseCommand::FAILURE;
         }
 
@@ -113,13 +113,13 @@ 
             if (empty($solrCoreUid) || !in_array($solrCoreUid, $allSolrCores)) {
                 $outputSolrCores = [];
                 foreach ($allSolrCores as $indexName => $uid) {
-                    $outputSolrCores[] = $uid . ' : ' . $indexName;
+                    $outputSolrCores[] = $uid.' : '.$indexName;
                 }
                 if (empty($outputSolrCores)) {
-                    $io->error('ERROR: No valid Solr core ("' . $input->getOption('solr') . '") given. No valid cores found on PID ' . $this->storagePid . ".\n");
+                    $io->error('ERROR: No valid Solr core ("'.$input->getOption('solr').'") given. No valid cores found on PID '.$this->storagePid.".\n");
                     return BaseCommand::FAILURE;
                 } else {
-                    $io->error('ERROR: No valid Solr core ("' . $input->getOption('solr') . '") given. ' . "Valid cores are (<uid>:<index_name>):\n" . implode("\n", $outputSolrCores) . "\n");
+                    $io->error('ERROR: No valid Solr core ("'.$input->getOption('solr').'") given. '."Valid cores are (<uid>:<index_name>):\n".implode("\n", $outputSolrCores)."\n");
                     return BaseCommand::FAILURE;
                 }
             }
@@ -159,7 +159,7 @@ 
             $document = $this->documentRepository->findByUid($input->getOption('doc'));
 
             if ($document === null) {
-                $io->error('ERROR: Document with UID "' . $input->getOption('doc') . '" could not be found on PID ' . $this->storagePid . ' .');
+                $io->error('ERROR: Document with UID "'.$input->getOption('doc').'" could not be found on PID '.$this->storagePid.' .');
                 return BaseCommand::FAILURE;
             } else {
                 $doc = AbstractDocument::getInstance($document->getLocation(), ['storagePid' => $this->storagePid], true);
@@ -172,31 +172,31 @@ 
         }
 
         if ($doc === null) {
-            $io->error('ERROR: Document "' . $input->getOption('doc') . '" could not be loaded.');
+            $io->error('ERROR: Document "'.$input->getOption('doc').'" could not be loaded.');
             return BaseCommand::FAILURE;
         }
 
         $document->setSolrcore($solrCoreUid);
 
         if ($dryRun) {
-            $io->section('DRY RUN: Would index ' . $document->getUid() . ' ("' . $document->getLocation() . '") on PID ' . $this->storagePid . ' and Solr core ' . $solrCoreUid . '.');
+            $io->section('DRY RUN: Would index '.$document->getUid().' ("'.$document->getLocation().'") on PID '.$this->storagePid.' and Solr core '.$solrCoreUid.'.');
             $io->success('All done!');
             return BaseCommand::SUCCESS;
         } else {
             $document->setCurrentDocument($doc);
 
             if ($io->isVerbose()) {
-                $io->section('Indexing ' . $document->getUid() . ' ("' . $document->getLocation() . '") on PID ' . $this->storagePid . '.');
+                $io->section('Indexing '.$document->getUid().' ("'.$document->getLocation().'") on PID '.$this->storagePid.'.');
             }
             $isSaved = $this->saveToDatabase($document);
 
             if ($isSaved) {
                 if ($io->isVerbose()) {
-                    $io->section('Indexing ' . $document->getUid() . ' ("' . $document->getLocation() . '") on Solr core ' . $solrCoreUid . '.');
+                    $io->section('Indexing '.$document->getUid().' ("'.$document->getLocation().'") on Solr core '.$solrCoreUid.'.');
                 }
                 $isSaved = Indexer::add($document, $this->documentRepository);
             } else {
-                $io->error('ERROR: Document with UID "' . $document->getUid() . '" could not be indexed on PID ' . $this->storagePid . ' . There are missing mandatory fields (at least one of those: ' . $this->extConf['requiredMetadataFields'] . ') in this document.');
+                $io->error('ERROR: Document with UID "'.$document->getUid().'" could not be indexed on PID '.$this->storagePid.' . There are missing mandatory fields (at least one of those: '.$this->extConf['requiredMetadataFields'].') in this document.');
                 return BaseCommand::FAILURE;
             }
 
@@ -205,8 +205,8 @@ 
                 return BaseCommand::SUCCESS;
             }
 
-            $io->error('ERROR: Document with UID "' . $document->getUid() . '" could not be indexed on Solr core ' . $solrCoreUid . ' . There are missing mandatory fields (at least one of those: ' . $this->extConf['requiredMetadataFields'] . ') in this document.');
-            $io->info('INFO: Document with UID "' . $document->getUid() . '" is already in database. If you want to keep the database and index consistent you need to remove it.');
+            $io->error('ERROR: Document with UID "'.$document->getUid().'" could not be indexed on Solr core '.$solrCoreUid.' . There are missing mandatory fields (at least one of those: '.$this->extConf['requiredMetadataFields'].') in this document.');
+            $io->info('INFO: Document with UID "'.$document->getUid().'" is already in database. If you want to keep the database and index consistent you need to remove it.');
             return BaseCommand::FAILURE;
         }
     }

Upper-Lower-Casing +11 added lines, -11 removed lines

@@ -48,7 +48,7 @@ 
             ->setHelp('')
             ->addOption(
                 'dry-run',
-                null,
+                NULL,
                 InputOption::VALUE_NONE,
                 'If this option is set, the files will not actually be processed but the location URI is shown.'
             )
@@ -90,7 +90,7 @@ 
      */
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $dryRun = $input->getOption('dry-run') != false ? true : false;
+        $dryRun = $input->getOption('dry-run') != FALSE ? TRUE : FALSE;
 
         $io = new SymfonyStyle($input, $output);
         $io->title($this->getDescription());
@@ -147,31 +147,31 @@ 
                 $this->owner = $this->libraryRepository->findOneByIndexName((string) $input->getOption('owner'));
             }
         } else {
-            $this->owner = null;
+            $this->owner = NULL;
         }
 
-        $document = null;
-        $doc = null;
+        $document = NULL;
+        $doc = NULL;
 
         // Try to find existing document in database
         if (MathUtility::canBeInterpretedAsInteger($input->getOption('doc'))) {
 
             $document = $this->documentRepository->findByUid($input->getOption('doc'));
 
-            if ($document === null) {
+            if ($document === NULL) {
                 $io->error('ERROR: Document with UID "' . $input->getOption('doc') . '" could not be found on PID ' . $this->storagePid . ' .');
                 return BaseCommand::FAILURE;
             } else {
-                $doc = AbstractDocument::getInstance($document->getLocation(), ['storagePid' => $this->storagePid], true);
+                $doc = AbstractDocument::getInstance($document->getLocation(), ['storagePid' => $this->storagePid], TRUE);
             }
 
         } else if (GeneralUtility::isValidUrl($input->getOption('doc'))) {
-            $doc = AbstractDocument::getInstance($input->getOption('doc'), ['storagePid' => $this->storagePid], true);
+            $doc = AbstractDocument::getInstance($input->getOption('doc'), ['storagePid' => $this->storagePid], TRUE);
 
             $document = $this->getDocumentFromUrl($doc, $input->getOption('doc'));
         }
 
-        if ($doc === null) {
+        if ($doc === NULL) {
             $io->error('ERROR: Document "' . $input->getOption('doc') . '" could not be loaded.');
             return BaseCommand::FAILURE;
         }
@@ -223,7 +223,7 @@ 
      */
     private function getDocumentFromUrl($doc, string $url): Document
     {
-        $document = null;
+        $document = NULL;
 
         if ($doc->recordId) {
             $document = $this->documentRepository->findOneByRecordId($doc->recordId);
@@ -231,7 +231,7 @@ 
             $document = $this->documentRepository->findOneByLocation($url);
         }
 
-        if ($document === null) {
+        if ($document === NULL) {
             // create new Document object
             $document = GeneralUtility::makeInstance(Document::class);
         }

Classes/Domain/Repository/StructureRepository.php

Braces +1 added lines, -2 removed lines

@@ -22,7 +22,6 @@
  *
  * @access public
  */
-class StructureRepository extends Repository
-{
+class StructureRepository extends Repository {
 
 }

Classes/Domain/Repository/MetadataRepository.php

Braces +1 added lines, -2 removed lines

@@ -24,8 +24,7 @@
  *
  * @access public
  */
-class MetadataRepository extends Repository
-{
+class MetadataRepository extends Repository {
     /**
      * Finds all collection for the given settings
      *

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -41,11 +41,11 @@
 
         $constraints = [];
 
-        if (isset($settings['is_listed']) && $settings['is_listed'] == true) {
+        if (isset($settings['is_listed']) && $settings['is_listed'] == TRUE) {
             $constraints[] = $query->equals('is_listed', 1);
         }
 
-        if (isset($settings['is_sortable']) && $settings['is_sortable'] == true) {
+        if (isset($settings['is_sortable']) && $settings['is_sortable'] == TRUE) {
             $constraints[] = $query->equals('is_sortable', 1);
         }
 

Classes/Domain/Repository/FormatRepository.php

Braces +1 added lines, -2 removed lines

@@ -22,7 +22,6 @@
  *
  * @access public
  */
-class FormatRepository extends Repository
-{
+class FormatRepository extends Repository {
 
 }

Classes/Domain/Repository/TokenRepository.php

Braces +1 added lines, -2 removed lines

@@ -22,8 +22,7 @@
  *
  * @access public
  */
-class TokenRepository extends Repository
-{
+class TokenRepository extends Repository {
     /**
      * Delete all expired token
      *

Classes/Domain/Repository/SolrCoreRepository.php

Braces +1 added lines, -2 removed lines

@@ -22,7 +22,6 @@
  *
  * @access public
  */
-class SolrCoreRepository extends Repository
-{
+class SolrCoreRepository extends Repository {
 
 }

Classes/Domain/Repository/LibraryRepository.php

Braces +1 added lines, -2 removed lines

@@ -22,7 +22,6 @@
  *
  * @access public
  */
-class LibraryRepository extends Repository
-{
+class LibraryRepository extends Repository {
 
 }

Classes/Domain/Repository/ActionLogRepository.php

Braces +1 added lines, -2 removed lines

@@ -22,7 +22,6 @@
  *
  * @access public
  */
-class ActionLogRepository extends Repository
-{
+class ActionLogRepository extends Repository {
 
 }

Classes/Domain/Repository/MailRepository.php

Braces +2 added lines, -4 removed lines

@@ -25,8 +25,7 @@ 
  *
  * @access public
  */
-class MailRepository extends Repository
-{
+class MailRepository extends Repository {
 
     /**
      * Find all mails by pid.
@@ -37,8 +36,7 @@ 
      * 
      * @return array|QueryResultInterface
      */
-    public function findAllWithPid(int $pid)
-    {
+    public function findAllWithPid(int $pid) {
         /** @var Typo3QuerySettings $querySettings */
         $querySettings = GeneralUtility::makeInstance(Typo3QuerySettings::class);