Passed
Pull Request — master (#123)
by
unknown
11:14
created
Classes/Middleware/Embedded3DViewer.php 3 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
         $modelInfo = PathUtility::pathinfo($parameters['model']);
70 70
         $modelFormat = $modelInfo["extension"];
71 71
         if (empty($modelFormat)) {
72
-            return $this->warningResponse('Model path "' . $parameters['model'] . '" has no extension format', $request);
72
+            return $this->warningResponse('Model path "'.$parameters['model'].'" has no extension format', $request);
73 73
         }
74 74
 
75 75
         if (empty($parameters['viewer'])) {
@@ -88,30 +88,30 @@  discard block
 block discarded – undo
88 88
         $defaultStorage = $storageRepository->getDefaultStorage();
89 89
 
90 90
         if (!$defaultStorage->hasFolder(self::VIEWER_FOLDER)) {
91
-            return $this->errorResponse('Required folder "' . self::VIEWER_FOLDER . '" was not found in the default storage "' . $defaultStorage->getName() . '"', $request);
91
+            return $this->errorResponse('Required folder "'.self::VIEWER_FOLDER.'" was not found in the default storage "'.$defaultStorage->getName().'"', $request);
92 92
         }
93 93
 
94 94
         $viewerModules = $defaultStorage->getFolder(self::VIEWER_FOLDER);
95 95
         if (!$viewerModules->hasFolder($viewer)) {
96
-            return $this->errorResponse('Viewer folder "' . $viewer . '" was not found under the folder "' . self::VIEWER_FOLDER . '"', $request);
96
+            return $this->errorResponse('Viewer folder "'.$viewer.'" was not found under the folder "'.self::VIEWER_FOLDER.'"', $request);
97 97
         }
98 98
 
99 99
         $viewerFolder = $viewerModules->getSubfolder($viewer);
100 100
         if (!$viewerFolder->hasFile(self::VIEWER_CONFIG_YML)) {
101
-            return $this->errorResponse('Viewer folder "' . $viewer . '" does not contain a file named "' . self::VIEWER_CONFIG_YML . '"', $request);
101
+            return $this->errorResponse('Viewer folder "'.$viewer.'" does not contain a file named "'.self::VIEWER_CONFIG_YML.'"', $request);
102 102
         }
103 103
 
104 104
         /** @var YamlFileLoader $yamlFileLoader */
105 105
         $yamlFileLoader = GeneralUtility::makeInstance(YamlFileLoader::class);
106
-        $viewerConfigPath = $defaultStorage->getName() . "/" . self::VIEWER_FOLDER . "/" . $viewer . "/";
107
-        $config = $yamlFileLoader->load($viewerConfigPath . self::VIEWER_CONFIG_YML)["viewer"];
106
+        $viewerConfigPath = $defaultStorage->getName()."/".self::VIEWER_FOLDER."/".$viewer."/";
107
+        $config = $yamlFileLoader->load($viewerConfigPath.self::VIEWER_CONFIG_YML)["viewer"];
108 108
 
109 109
         if (!isset($config["supportedModelFormats"]) || empty($config["supportedModelFormats"])) {
110
-            return $this->errorResponse('Required key "supportedModelFormats" does not exist in the file "' . self::VIEWER_CONFIG_YML . '" of viewer "' . $viewer . '" or has no value', $request);
110
+            return $this->errorResponse('Required key "supportedModelFormats" does not exist in the file "'.self::VIEWER_CONFIG_YML.'" of viewer "'.$viewer.'" or has no value', $request);
111 111
         }
112 112
 
113 113
         if (array_search(strtolower($modelFormat), array_map('strtolower', $config["supportedModelFormats"])) === false) {
114
-            return $this->warningResponse('Viewer "' . $viewer . '" does not support the model format "' . $modelFormat . '"', $request);
114
+            return $this->warningResponse('Viewer "'.$viewer.'" does not support the model format "'.$modelFormat.'"', $request);
115 115
         }
116 116
 
117 117
         $html = $this->getViewerHtml($config, $viewerConfigPath, $viewerFolder, $parameters['model'], $modelInfo);
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,8 +34,7 @@
 block discarded – undo
34 34
  * @subpackage dlf
35 35
  * @access public
36 36
  */
37
-class Embedded3DViewer implements MiddlewareInterface
38
-{
37
+class Embedded3DViewer implements MiddlewareInterface {
39 38
     use LoggerAwareTrait;
40 39
 
41 40
     const VIEWER_FOLDER = "dlf_3d_viewers";
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@
 block discarded – undo
110 110
             return $this->errorResponse('Required key "supportedModelFormats" does not exist in the file "' . self::VIEWER_CONFIG_YML . '" of viewer "' . $viewer . '" or has no value', $request);
111 111
         }
112 112
 
113
-        if (array_search(strtolower($modelFormat), array_map('strtolower', $config["supportedModelFormats"])) === false) {
113
+        if (array_search(strtolower($modelFormat), array_map('strtolower', $config["supportedModelFormats"])) === FALSE) {
114 114
             return $this->warningResponse('Viewer "' . $viewer . '" does not support the model format "' . $modelFormat . '"', $request);
115 115
         }
116 116
 
Please login to merge, or discard this patch.