Erikmitk / kitodo-presentation

Configuration/TCA/tx_dlf_metadata.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -143,7 +143,7 @@ 
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_labels.xlf:tx_dlf_metadata.wrap',
             'config' => [
                 'behaviour' => [
-                    'allowLanguageSynchronization' => true
+                    'allowLanguageSynchronization' => TRUE
                 ],
                 'type' => 'text',
                 'cols' => 48,
@@ -151,8 +151,8 @@ 
                 'wrap' => 'off',
                 'eval' => 'trim',
                 'default' => "key.wrap = <dt>|</dt>\nvalue.required = 1\nvalue.wrap = <dd>|</dd>",
-                'fixedFont' => true,
-                'enableTabulator' => true
+                'fixedFont' => TRUE,
+                'enableTabulator' => TRUE
             ],
         ],
         'index_tokenized' => [

Configuration/TCA/tx_dlf_collections.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -157,14 +157,14 @@
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_labels.xlf:tx_dlf_collections.description',
             'config' => [
                 'behaviour' => [
-                    'allowLanguageSynchronization' => true
+                    'allowLanguageSynchronization' => TRUE
                 ],
                 'type' => 'text',
                 'cols' => 30,
                 'rows' => 10,
                 'wrap' => 'virtual',
                 'default' => '',
-                'enableRichtext' => true,
+                'enableRichtext' => TRUE,
             ],
         ],
         'thumbnail' => [

Tests/Unit/Format/ModsTest.php

Spacing +6 added lines, -6 removed lines

@@ -60,7 +60,7 @@ 
      */
     public function extractAuthorsIfNoAutRoleTermAssigned(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsAuthorNoAutRoleTerm.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsAuthorNoAutRoleTerm.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);
@@ -80,7 +80,7 @@ 
      */
     public function extractAuthorsWithAutRoleTermAssigned(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsAuthorWithAutRoleTerm.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsAuthorWithAutRoleTerm.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);
@@ -102,7 +102,7 @@ 
      */
     public function extractPlaces(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfo.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsOriginInfo.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);
@@ -131,7 +131,7 @@ 
      */
     public function extractYears(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfo.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsOriginInfo.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);
@@ -160,7 +160,7 @@ 
      */
     public function extractPlacesWithElectronicEdInside(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);
@@ -189,7 +189,7 @@ 
      */
     public function extractYearsWithElectronicEdInside(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);

Braces +1 added lines, -2 removed lines

@@ -15,8 +15,7 @@
 use Kitodo\Dlf\Format\Mods;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class ModsTest extends UnitTestCase
-{
+class ModsTest extends UnitTestCase {
     protected $metadata = [];
 
     public function setUp(): void

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -63,7 +63,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsAuthorNoAutRoleTerm.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
 
         self::assertEquals(
             [
@@ -83,7 +83,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsAuthorWithAutRoleTerm.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
         self::assertEquals(
             [
                 'May, Jack, I',
@@ -105,7 +105,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfo.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
 
         self::assertEquals(
             [
@@ -134,7 +134,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfo.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
 
         self::assertEquals(
             [
@@ -163,7 +163,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
 
         self::assertEquals(
             [
@@ -192,7 +192,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
 
         self::assertEquals(
             [

Tests/Unit/Format/AudioVideoMDTest.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
      */
     public function canExtractDuration(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/audioVideo.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/audioVideo.xml');
         $audioVideoMD = new AudioVideoMD();
 
         $videoXml = $xml->xpath('//mets:xmlData')[0];

Braces +1 added lines, -2 removed lines

@@ -15,8 +15,7 @@
 use Kitodo\Dlf\Format\AudioVideoMD;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class AudioVideoMDTest extends UnitTestCase
-{
+class AudioVideoMDTest extends UnitTestCase {
     protected $metadata = [];
 
     public function setUp(): void

Tests/Unit/Format/AltoTest.php

Spacing +5 added lines, -5 removed lines

@@ -23,7 +23,7 @@ 
      */
     public function getRawData(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/alto.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/alto.xml');
         $alto = new Alto();
 
         $rawText = $alto->getRawText($xml);
@@ -37,7 +37,7 @@ 
      */
     public function getTextAsMiniOcr(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/alto.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/alto.xml');
         $alto = new Alto();
 
         $rawText = $alto->getTextAsMiniOcr($xml);
@@ -75,7 +75,7 @@ 
      */
     public function getTextAsMiniOcrNoTextBlock(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/altoNoTextBlock.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/altoNoTextBlock.xml');
         $alto = new Alto();
 
         $rawText = $alto->getTextAsMiniOcr($xml);
@@ -89,7 +89,7 @@ 
      */
     public function getTextAsMiniOcrNoTextline(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/altoNoTextLine.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/altoNoTextLine.xml');
         $alto = new Alto();
 
         $rawText = $alto->getTextAsMiniOcr($xml);
@@ -103,7 +103,7 @@ 
      */
     public function getTextAsMiniOcrNoString(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/altoNoString.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/altoNoString.xml');
         $alto = new Alto();
 
         $rawText = $alto->getTextAsMiniOcr($xml);

Braces +1 added lines, -2 removed lines

@@ -15,8 +15,7 @@
 use Kitodo\Dlf\Format\Alto;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class AltoTest extends UnitTestCase
-{
+class AltoTest extends UnitTestCase {
     /**
      * @test
      * @group extract data

Tests/Unit/Format/TeiHeaderTest.php

Braces +1 added lines, -2 removed lines

@@ -14,8 +14,7 @@
 
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class TeiHeaderTest extends UnitTestCase
-{
+class TeiHeaderTest extends UnitTestCase {
     protected $metadata = [];
 
     public function setUp(): void

Tests/Unit/Common/HelperTest.php

Braces +2 added lines, -4 removed lines

@@ -15,10 +15,8 @@
 use Kitodo\Dlf\Common\Helper;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class HelperTest extends UnitTestCase
-{
-    public function assertInvalidXml($xml)
-    {
+class HelperTest extends UnitTestCase {
+    public function assertInvalidXml($xml) {
         $result = Helper::getXmlFileAsString($xml);
         self::assertEquals(false, $result);
     }

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -20,7 +20,7 @@ 
     public function assertInvalidXml($xml)
     {
         $result = Helper::getXmlFileAsString($xml);
-        self::assertEquals(false, $result);
+        self::assertEquals(FALSE, $result);
     }
 
     /**
@@ -29,8 +29,8 @@ 
      */
     public function invalidXmlYieldsFalse(): void
     {
-        self::assertInvalidXml(false);
-        self::assertInvalidXml(null);
+        self::assertInvalidXml(FALSE);
+        self::assertInvalidXml(NULL);
         self::assertInvalidXml(1);
         self::assertInvalidXml([]);
         self::assertInvalidXml(new \stdClass());
@@ -50,7 +50,7 @@ 
 <root>
     <single />
 </root>
-XML;
+xml;
         $node = Helper::getXmlFileAsString($xml);
         self::assertIsObject($node);
         self::assertEquals('root', $node->getName());

Tests/Functional/Repository/TokenRepositoryTest.php

Spacing +3 added lines, -3 removed lines

@@ -36,7 +36,7 @@ 
     {
         parent::tearDown();
 
-        unlink(__DIR__ . '/../../Fixtures/Repository/tokenTemp.csv');
+        unlink(__DIR__.'/../../Fixtures/Repository/tokenTemp.csv');
     }
 
     /**
@@ -45,8 +45,8 @@ 
      */
     public function deleteExpiredTokens(): void
     {
-        $inputCsvFile = __DIR__ . '/../../Fixtures/Repository/token.csv';
-        $outputCsvFile = __DIR__ . '/../../Fixtures/Repository/tokenTemp.csv';
+        $inputCsvFile = __DIR__.'/../../Fixtures/Repository/token.csv';
+        $outputCsvFile = __DIR__.'/../../Fixtures/Repository/tokenTemp.csv';
 
         $inputCsvData = file_get_contents($inputCsvFile);
         $csvData = str_getcsv($inputCsvData, "\n");

Braces +1 added lines, -2 removed lines

@@ -15,8 +15,7 @@
 use Kitodo\Dlf\Domain\Repository\TokenRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class TokenRepositoryTest extends FunctionalTestCase
-{
+class TokenRepositoryTest extends FunctionalTestCase {
     /**
      * @var TokenRepository
      */

Tests/Functional/Repository/CollectionRepositoryTest.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
             20000
         );
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Repository/collections.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Repository/collections.csv');
     }
 
     /**

Braces +1 added lines, -2 removed lines

@@ -16,8 +16,7 @@
 use Kitodo\Dlf\Domain\Repository\CollectionRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class CollectionRepositoryTest extends FunctionalTestCase
-{
+class CollectionRepositoryTest extends FunctionalTestCase {
     /**
      * @var CollectionRepository
      */

Upper-Lower-Casing +13 added lines, -13 removed lines

@@ -107,14 +107,14 @@ 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
                 'index_name' => ['Geschichte', 'collection-with-single-document'],
-                'show_userdefined' => true
+                'show_userdefined' => TRUE
             ]
         );
         self::assertCount(2, $collectionsByLabel);
         self::assertArrayHasKey('Geschichte', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
 
-        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => true]);
+        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => TRUE]);
         self::assertCount(4, $collectionsByLabel);
         self::assertArrayHasKey('Musik', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
@@ -125,20 +125,20 @@ 
             implode(', ', array_keys($collectionsByLabel))
         );
 
-        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => false]);
+        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => FALSE]);
         self::assertCount(2, $collectionsByLabel);
         self::assertArrayHasKey('Musik', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
 
-        $collectionsByLabel = $this->findCollectionsBySettings(['hideEmptyOaiNames' => true]);
+        $collectionsByLabel = $this->findCollectionsBySettings(['hideEmptyOaiNames' => TRUE]);
         self::assertCount(2, $collectionsByLabel);
         self::assertArrayHasKey('Musik', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
-                'hideEmptyOaiNames' => true,
-                'show_userdefined' => true
+                'hideEmptyOaiNames' => TRUE,
+                'show_userdefined' => TRUE
             ]
         );
         self::assertCount(3, $collectionsByLabel);
@@ -148,8 +148,8 @@ 
 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
-                'hideEmptyOaiNames' => false,
-                'show_userdefined' => true
+                'hideEmptyOaiNames' => FALSE,
+                'show_userdefined' => TRUE
             ]
         );
         self::assertCount(4, $collectionsByLabel);
@@ -161,8 +161,8 @@ 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
                 'collections' => '1101, 1102, 1103, 1104',
-                'show_userdefined' => true,
-                'hideEmptyOaiNames' => false,
+                'show_userdefined' => TRUE,
+                'hideEmptyOaiNames' => FALSE,
                 'index_name' => ['Geschichte', 'collection-with-single-document']
             ]
         );
@@ -179,7 +179,7 @@ 
     public function canGetIndexNameForSolr(): void
     {
         $indexName = $this->collectionRepository->getIndexNameForSolr(
-            ['show_userdefined' => true, 'storagePid' => '20000'], 'history'
+            ['show_userdefined' => TRUE, 'storagePid' => '20000'], 'history'
         );
         $result = $indexName->fetchAllAssociative();
         self::assertEquals(1, $indexName->rowCount());
@@ -188,12 +188,12 @@ 
         self::assertEquals('1103', $result[0]['uid']);
 
         $indexName = $this->collectionRepository->getIndexNameForSolr(
-            ['show_userdefined' => false, 'storagePid' => '20000'], 'history'
+            ['show_userdefined' => FALSE, 'storagePid' => '20000'], 'history'
         );
         self::assertEquals(0, $indexName->rowCount());
 
         $indexName = $this->collectionRepository->getIndexNameForSolr(
-            ['show_userdefined' => false, 'storagePid' => '20000'], 'collection-with-single-document'
+            ['show_userdefined' => FALSE, 'storagePid' => '20000'], 'collection-with-single-document'
         );
         self::assertEquals(1, $indexName->rowCount());
         self::assertEquals('collection-with-single-document', $indexName->fetchOne());