Erikmitk / kitodo-presentation

Configuration/TCA/tx_dlf_metadata.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -143,7 +143,7 @@ 
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_labels.xlf:tx_dlf_metadata.wrap',
             'config' => [
                 'behaviour' => [
-                    'allowLanguageSynchronization' => true
+                    'allowLanguageSynchronization' => TRUE
                 ],
                 'type' => 'text',
                 'cols' => 48,
@@ -151,8 +151,8 @@ 
                 'wrap' => 'off',
                 'eval' => 'trim',
                 'default' => "key.wrap = <dt>|</dt>\nvalue.required = 1\nvalue.wrap = <dd>|</dd>",
-                'fixedFont' => true,
-                'enableTabulator' => true
+                'fixedFont' => TRUE,
+                'enableTabulator' => TRUE
             ],
         ],
         'index_tokenized' => [

Configuration/TCA/tx_dlf_collections.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -157,14 +157,14 @@
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_labels.xlf:tx_dlf_collections.description',
             'config' => [
                 'behaviour' => [
-                    'allowLanguageSynchronization' => true
+                    'allowLanguageSynchronization' => TRUE
                 ],
                 'type' => 'text',
                 'cols' => 30,
                 'rows' => 10,
                 'wrap' => 'virtual',
                 'default' => '',
-                'enableRichtext' => true,
+                'enableRichtext' => TRUE,
             ],
         ],
         'thumbnail' => [

Build/Documentation/dbdocs/Generator.php

Braces +8 added lines, -16 removed lines

@@ -32,8 +32,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class Generator
-{
+class Generator {
     /**
      * @var LanguageService
      */
@@ -57,37 +56,32 @@ 
     /**
      * @param LanguageService $languageService
      */
-    public function injectLanguageService(LanguageService $languageService)
-    {
+    public function injectLanguageService(LanguageService $languageService) {
         $this->languageService = $languageService;
     }
 
     /**
      * @param DataMapper $dataMapper
      */
-    public function injectDataMapper(DataMapper $dataMapper)
-    {
+    public function injectDataMapper(DataMapper $dataMapper) {
         $this->dataMapper = $dataMapper;
     }
 
     /**
      * @param SqlReader $sqlReader
      */
-    public function injectSqlReader(DataMapper $sqlReader)
-    {
+    public function injectSqlReader(DataMapper $sqlReader) {
         $this->sqlReader = $sqlReader;
     }
 
     /**
      * @param ConfigurationManager $configurationManager
      */
-    public function injectConfigurationManager(ConfigurationManager $configurationManager)
-    {
+    public function injectConfigurationManager(ConfigurationManager $configurationManager) {
         $this->configurationManager = $configurationManager;
     }
 
-    public function __construct()
-    {
+    public function __construct() {
 
     }
 
@@ -205,8 +199,7 @@ 
         return $result;
     }
 
-    protected function parseDocComment($docComment)
-    {
+    protected function parseDocComment($docComment) {
         // TODO: Consider using phpDocumentor (though that splits the docblock into summary and description)
 
         // Adopted from DocCommentParser in TYPO3 v9
@@ -231,8 +224,7 @@ 
     /**
      * Transform table structure into .rst page.
      */
-    public function generatePage(array $tables)
-    {
+    public function generatePage(array $tables) {
         $page = new RstSection();
         $page->setHeader('Database Tables');
         $page->addText(<<<RST

Upper-Lower-Casing +10 added lines, -10 removed lines

@@ -97,7 +97,7 @@ 
      */
     public function collectTables(): array
     {
-        $sqlCode = $this->sqlReader->getTablesDefinitionString(true);
+        $sqlCode = $this->sqlReader->getTablesDefinitionString(TRUE);
         $createTableStatements = $this->sqlReader->getCreateTableStatementArray($sqlCode);
 
         $tableToClassName = $this->getTableClassMap();
@@ -113,7 +113,7 @@ 
                 continue;
             }
 
-            $className = $tableToClassName[$tableName] ?? null;
+            $className = $tableToClassName[$tableName] ?? NULL;
 
             $result[] = $this->getTableInfo($table, $className);
         }
@@ -151,7 +151,7 @@ 
         $isPrimary = [];
         if (!is_null($primaryKey = $table->getPrimaryKey())) {
             foreach ($primaryKey->getUnquotedColumns() as $primaryColumn) {
-                $isPrimary[$primaryColumn] = true;
+                $isPrimary[$primaryColumn] = TRUE;
             }
         }
 
@@ -172,14 +172,14 @@ 
         $result = (object) [
             'name' => $tableName,
             'columns' => $columns,
-            'modelClass' => null,
+            'modelClass' => NULL,
             'sqlComment' => $table->getComment() ?? '',
             'classComment' => '',
             'feComment' => $this->languageService->sL($GLOBALS['TCA'][$tableName]['ctrl']['title'] ?? ''),
         ];
 
         // Integrate doc-comments from model class and its fields
-        if ($className !== null) {
+        if ($className !== NULL) {
             $reflection = new ReflectionClass($className);
 
             $dataMap = $this->dataMapper->getDataMap($className);
@@ -189,7 +189,7 @@ 
                 // In that case, try to guess the column name from the property name.
 
                 $column = $dataMap->getColumnMap($property->getName());
-                $columnName = $column === null
+                $columnName = $column === NULL
                     ? GeneralUtility::camelCaseToLowerCaseUnderscored($property->getName())
                     : $column->getColumnName();
 
@@ -215,7 +215,7 @@ 
         $lines = explode("\n", $docComment);
         foreach ($lines as $line) {
             // Stop parsing at first tag
-            if ($line !== '' && strpos($line, '@') !== false) {
+            if ($line !== '' && strpos($line, '@') !== FALSE) {
                 break;
             }
 
@@ -239,7 +239,7 @@ 
 This is a reference of all database tables defined by Kitodo.Presentation.
 
 .. tip:: This page is auto-generated. If you would like to edit it, please use doc-comments in the model class, COMMENT fields in ``ext_tables.sql`` if the table does not have one, or TCA labels. Then, you may re-generate the page by running ``composer docs:db`` inside the Kitodo.Presentation base folder.
-RST);
+rst);
 
         // Sort tables alphabetically
         usort($tables, function ($lhs, $rhs) {
@@ -274,11 +274,11 @@ 
                     'field' => (
                         $page->format($column->name, ['bold' => $column->isPrimary])
                         . "\u{00a0}\u{00a0}"
-                        . $page->format($column->type->getName(), ['italic' => true])
+                        . $page->format($column->type->getName(), ['italic' => TRUE])
                     ),
 
                     'description' => $page->paragraphs([
-                        $page->format($column->feComment, ['italic' => true]),
+                        $page->format($column->feComment, ['italic' => TRUE]),
                         $column->fieldComment,
                         $column->sqlComment,
                     ]),

Tests/Unit/Format/ModsTest.php

Spacing +6 added lines, -6 removed lines

@@ -60,7 +60,7 @@ 
      */
     public function extractAuthorsIfNoAutRoleTermAssigned(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsAuthorNoAutRoleTerm.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsAuthorNoAutRoleTerm.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);
@@ -80,7 +80,7 @@ 
      */
     public function extractAuthorsWithAutRoleTermAssigned(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsAuthorWithAutRoleTerm.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsAuthorWithAutRoleTerm.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);
@@ -102,7 +102,7 @@ 
      */
     public function extractPlaces(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfo.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsOriginInfo.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);
@@ -131,7 +131,7 @@ 
      */
     public function extractYears(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfo.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsOriginInfo.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);
@@ -160,7 +160,7 @@ 
      */
     public function extractPlacesWithElectronicEdInside(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);
@@ -189,7 +189,7 @@ 
      */
     public function extractYearsWithElectronicEdInside(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
         $mods = new Mods();
 
         $mods->extractMetadata($xml, $this->metadata, false);

Braces +1 added lines, -2 removed lines

@@ -15,8 +15,7 @@
 use Kitodo\Dlf\Format\Mods;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class ModsTest extends UnitTestCase
-{
+class ModsTest extends UnitTestCase {
     protected $metadata = [];
 
     public function setUp(): void

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -63,7 +63,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsAuthorNoAutRoleTerm.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
 
         self::assertEquals(
             [
@@ -83,7 +83,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsAuthorWithAutRoleTerm.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
         self::assertEquals(
             [
                 'May, Jack, I',
@@ -105,7 +105,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfo.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
 
         self::assertEquals(
             [
@@ -134,7 +134,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfo.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
 
         self::assertEquals(
             [
@@ -163,7 +163,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
 
         self::assertEquals(
             [
@@ -192,7 +192,7 @@ 
         $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/modsOriginInfoWithEditionElectronicEd.xml');
         $mods = new Mods();
 
-        $mods->extractMetadata($xml, $this->metadata, false);
+        $mods->extractMetadata($xml, $this->metadata, FALSE);
 
         self::assertEquals(
             [

Tests/Unit/Format/AudioVideoMDTest.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
      */
     public function canExtractDuration(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/audioVideo.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/audioVideo.xml');
         $audioVideoMD = new AudioVideoMD();
 
         $videoXml = $xml->xpath('//mets:xmlData')[0];

Braces +1 added lines, -2 removed lines

@@ -15,8 +15,7 @@
 use Kitodo\Dlf\Format\AudioVideoMD;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class AudioVideoMDTest extends UnitTestCase
-{
+class AudioVideoMDTest extends UnitTestCase {
     protected $metadata = [];
 
     public function setUp(): void

Tests/Unit/Format/AltoTest.php

Spacing +5 added lines, -5 removed lines

@@ -23,7 +23,7 @@ 
      */
     public function getRawData(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/alto.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/alto.xml');
         $alto = new Alto();
 
         $rawText = $alto->getRawText($xml);
@@ -37,7 +37,7 @@ 
      */
     public function getTextAsMiniOcr(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/alto.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/alto.xml');
         $alto = new Alto();
 
         $rawText = $alto->getTextAsMiniOcr($xml);
@@ -75,7 +75,7 @@ 
      */
     public function getTextAsMiniOcrNoTextBlock(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/altoNoTextBlock.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/altoNoTextBlock.xml');
         $alto = new Alto();
 
         $rawText = $alto->getTextAsMiniOcr($xml);
@@ -89,7 +89,7 @@ 
      */
     public function getTextAsMiniOcrNoTextline(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/altoNoTextLine.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/altoNoTextLine.xml');
         $alto = new Alto();
 
         $rawText = $alto->getTextAsMiniOcr($xml);
@@ -103,7 +103,7 @@ 
      */
     public function getTextAsMiniOcrNoString(): void
     {
-        $xml = simplexml_load_file(__DIR__ . '/../../Fixtures/Format/altoNoString.xml');
+        $xml = simplexml_load_file(__DIR__.'/../../Fixtures/Format/altoNoString.xml');
         $alto = new Alto();
 
         $rawText = $alto->getTextAsMiniOcr($xml);

Braces +1 added lines, -2 removed lines

@@ -15,8 +15,7 @@
 use Kitodo\Dlf\Format\Alto;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class AltoTest extends UnitTestCase
-{
+class AltoTest extends UnitTestCase {
     /**
      * @test
      * @group extract data

Tests/Unit/Format/TeiHeaderTest.php

Braces +1 added lines, -2 removed lines

@@ -14,8 +14,7 @@
 
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class TeiHeaderTest extends UnitTestCase
-{
+class TeiHeaderTest extends UnitTestCase {
     protected $metadata = [];
 
     public function setUp(): void

Tests/Unit/Common/HelperTest.php

Braces +2 added lines, -4 removed lines

@@ -15,10 +15,8 @@
 use Kitodo\Dlf\Common\Helper;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class HelperTest extends UnitTestCase
-{
-    public function assertInvalidXml($xml)
-    {
+class HelperTest extends UnitTestCase {
+    public function assertInvalidXml($xml) {
         $result = Helper::getXmlFileAsString($xml);
         self::assertEquals(false, $result);
     }

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -20,7 +20,7 @@ 
     public function assertInvalidXml($xml)
     {
         $result = Helper::getXmlFileAsString($xml);
-        self::assertEquals(false, $result);
+        self::assertEquals(FALSE, $result);
     }
 
     /**
@@ -29,8 +29,8 @@ 
      */
     public function invalidXmlYieldsFalse(): void
     {
-        self::assertInvalidXml(false);
-        self::assertInvalidXml(null);
+        self::assertInvalidXml(FALSE);
+        self::assertInvalidXml(NULL);
         self::assertInvalidXml(1);
         self::assertInvalidXml([]);
         self::assertInvalidXml(new \stdClass());
@@ -50,7 +50,7 @@ 
 <root>
     <single />
 </root>
-XML;
+xml;
         $node = Helper::getXmlFileAsString($xml);
         self::assertIsObject($node);
         self::assertEquals('root', $node->getName());

Tests/Functional/Repository/TokenRepositoryTest.php

Spacing +3 added lines, -3 removed lines

@@ -36,7 +36,7 @@ 
     {
         parent::tearDown();
 
-        unlink(__DIR__ . '/../../Fixtures/Repository/tokenTemp.csv');
+        unlink(__DIR__.'/../../Fixtures/Repository/tokenTemp.csv');
     }
 
     /**
@@ -45,8 +45,8 @@ 
      */
     public function deleteExpiredTokens(): void
     {
-        $inputCsvFile = __DIR__ . '/../../Fixtures/Repository/token.csv';
-        $outputCsvFile = __DIR__ . '/../../Fixtures/Repository/tokenTemp.csv';
+        $inputCsvFile = __DIR__.'/../../Fixtures/Repository/token.csv';
+        $outputCsvFile = __DIR__.'/../../Fixtures/Repository/tokenTemp.csv';
 
         $inputCsvData = file_get_contents($inputCsvFile);
         $csvData = str_getcsv($inputCsvData, "\n");

Braces +1 added lines, -2 removed lines

@@ -15,8 +15,7 @@
 use Kitodo\Dlf\Domain\Repository\TokenRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class TokenRepositoryTest extends FunctionalTestCase
-{
+class TokenRepositoryTest extends FunctionalTestCase {
     /**
      * @var TokenRepository
      */