Erikmitk / kitodo-presentation

Classes/Domain/Model/Library.php

Braces +1 added lines, -2 removed lines

@@ -30,8 +30,7 @@
  *
  * @access public
  */
-class Library extends AbstractEntity
-{
+class Library extends AbstractEntity {
     /**
      * @access protected
      * @var string

Classes/Domain/Model/PageSelectForm.php

Braces +1 added lines, -2 removed lines

@@ -22,8 +22,7 @@
  *
  * @access public
  */
-class PageSelectForm extends AbstractEntity
-{
+class PageSelectForm extends AbstractEntity {
     /**
      * @access protected
      * @var integer

Classes/Domain/Model/ActionLog.php

Braces +1 added lines, -2 removed lines

@@ -22,8 +22,7 @@
  *
  * @access public
  */
-class ActionLog extends AbstractEntity
-{
+class ActionLog extends AbstractEntity {
     /**
      * @access protected
      * @var int

Classes/Domain/Model/SolrCore.php

Braces +1 added lines, -2 removed lines

@@ -24,8 +24,7 @@
  *
  * @access public
  */
-class SolrCore extends AbstractEntity
-{
+class SolrCore extends AbstractEntity {
     /**
      * @access protected
      * @var int

Classes/Middleware/SearchSuggest.php

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
         $output = [];
         $solrCore = (string) $parameters['solrcore'];
         $uHash = (string) $parameters['uHash'];
-        if (hash_equals(GeneralUtility::hmac((string) (new Typo3Version()) . Environment::getExtensionsPath(), 'SearchSuggest'), $uHash) === false) {
+        if (hash_equals(GeneralUtility::hmac((string) (new Typo3Version()).Environment::getExtensionsPath(), 'SearchSuggest'), $uHash) === false) {
             throw new \InvalidArgumentException('No valid parameter passed!', 1580585079);
         }
         // Perform Solr query.

Braces +1 added lines, -2 removed lines

@@ -30,8 +30,7 @@
  *
  * @access public
  */
-class SearchSuggest implements MiddlewareInterface
-{
+class SearchSuggest implements MiddlewareInterface {
     /**
      * The process method of the middleware.
      *

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
         $output = [];
         $solrCore = (string) $parameters['solrcore'];
         $uHash = (string) $parameters['uHash'];
-        if (hash_equals(GeneralUtility::hmac((string) (new Typo3Version()) . Environment::getExtensionsPath(), 'SearchSuggest'), $uHash) === false) {
+        if (hash_equals(GeneralUtility::hmac((string) (new Typo3Version()) . Environment::getExtensionsPath(), 'SearchSuggest'), $uHash) === FALSE) {
             throw new \InvalidArgumentException('No valid parameter passed!', 1580585079);
         }
         // Perform Solr query.

Classes/Middleware/SearchInDocument.php

Indentation +1 added lines, -1 removed lines

@@ -152,7 +152,7 @@
         // field for which highlighting is going to be performed,
         // is required if you want to have OCR highlighting
         $solrRequest->addParam('hl.ocr.fl', $this->fields['fulltext']);
-         // return the coordinates of highlighted search as absolute coordinates
+            // return the coordinates of highlighted search as absolute coordinates
         $solrRequest->addParam('hl.ocr.absoluteHighlights', 'on');
         // max amount of snippets for a single page
         $solrRequest->addParam('hl.snippets', '40');

Spacing +2 added lines, -2 removed lines

@@ -71,7 +71,7 @@ 
 
         $encrypted = (string) $parameters['encrypted'];
         if (empty($encrypted)) {
-            throw new \InvalidArgumentException('No valid parameter passed: ' . $parameters['middleware'] . '  ' . $parameters['encrypted'] . '!', 1580585079);
+            throw new \InvalidArgumentException('No valid parameter passed: '.$parameters['middleware'].'  '.$parameters['encrypted'].'!', 1580585079);
         }
 
         $output = [
@@ -174,7 +174,7 @@ 
      */
     private function getQuery(array $parameters): string
     {
-        return $this->fields['fulltext'] . ':(' . Solr::escapeQuery((string) $parameters['q']) . ') AND ' . $this->fields['uid'] . ':' . $this->getUid($parameters['uid']);
+        return $this->fields['fulltext'].':('.Solr::escapeQuery((string) $parameters['q']).') AND '.$this->fields['uid'].':'.$this->getUid($parameters['uid']);
     }
 
     /**

Braces +3 added lines, -6 removed lines

@@ -31,8 +31,7 @@ 
  *
  * @access public
  */
-class SearchInDocument implements MiddlewareInterface
-{
+class SearchInDocument implements MiddlewareInterface {
     /**
      * This holds the solr instance
      *
@@ -136,8 +135,7 @@ 
      *
      * @return \Solarium\Core\Query\Result\ResultInterface result
      */
-    private function executeSolrQuery($parameters)
-    {
+    private function executeSolrQuery($parameters) {
         $query = $this->solr->service->createSelect();
         $query->setFields([$this->fields['id'], $this->fields['uid'], $this->fields['page']]);
         $query->setQuery($this->getQuery($parameters));
@@ -187,8 +185,7 @@ 
      *
      * @return int|string uid of the document
      */
-    private function getUid(string $uid)
-    {
+    private function getUid(string $uid) {
         return is_numeric($uid) ? intval($uid) : $uid;
     }
 }

Configuration/TCA/tx_dlf_metadata.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -143,7 +143,7 @@ 
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_labels.xlf:tx_dlf_metadata.wrap',
             'config' => [
                 'behaviour' => [
-                    'allowLanguageSynchronization' => true
+                    'allowLanguageSynchronization' => TRUE
                 ],
                 'type' => 'text',
                 'cols' => 48,
@@ -151,8 +151,8 @@ 
                 'wrap' => 'off',
                 'eval' => 'trim',
                 'default' => "key.wrap = <dt>|</dt>\nvalue.required = 1\nvalue.wrap = <dd>|</dd>",
-                'fixedFont' => true,
-                'enableTabulator' => true
+                'fixedFont' => TRUE,
+                'enableTabulator' => TRUE
             ],
         ],
         'index_tokenized' => [

Configuration/TCA/tx_dlf_collections.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -157,14 +157,14 @@
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_labels.xlf:tx_dlf_collections.description',
             'config' => [
                 'behaviour' => [
-                    'allowLanguageSynchronization' => true
+                    'allowLanguageSynchronization' => TRUE
                 ],
                 'type' => 'text',
                 'cols' => 30,
                 'rows' => 10,
                 'wrap' => 'virtual',
                 'default' => '',
-                'enableRichtext' => true,
+                'enableRichtext' => TRUE,
             ],
         ],
         'thumbnail' => [

Build/Documentation/dbdocs/Generator.php

Braces +8 added lines, -16 removed lines

@@ -32,8 +32,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class Generator
-{
+class Generator {
     /**
      * @var LanguageService
      */
@@ -57,37 +56,32 @@ 
     /**
      * @param LanguageService $languageService
      */
-    public function injectLanguageService(LanguageService $languageService)
-    {
+    public function injectLanguageService(LanguageService $languageService) {
         $this->languageService = $languageService;
     }
 
     /**
      * @param DataMapper $dataMapper
      */
-    public function injectDataMapper(DataMapper $dataMapper)
-    {
+    public function injectDataMapper(DataMapper $dataMapper) {
         $this->dataMapper = $dataMapper;
     }
 
     /**
      * @param SqlReader $sqlReader
      */
-    public function injectSqlReader(DataMapper $sqlReader)
-    {
+    public function injectSqlReader(DataMapper $sqlReader) {
         $this->sqlReader = $sqlReader;
     }
 
     /**
      * @param ConfigurationManager $configurationManager
      */
-    public function injectConfigurationManager(ConfigurationManager $configurationManager)
-    {
+    public function injectConfigurationManager(ConfigurationManager $configurationManager) {
         $this->configurationManager = $configurationManager;
     }
 
-    public function __construct()
-    {
+    public function __construct() {
 
     }
 
@@ -205,8 +199,7 @@ 
         return $result;
     }
 
-    protected function parseDocComment($docComment)
-    {
+    protected function parseDocComment($docComment) {
         // TODO: Consider using phpDocumentor (though that splits the docblock into summary and description)
 
         // Adopted from DocCommentParser in TYPO3 v9
@@ -231,8 +224,7 @@ 
     /**
      * Transform table structure into .rst page.
      */
-    public function generatePage(array $tables)
-    {
+    public function generatePage(array $tables) {
         $page = new RstSection();
         $page->setHeader('Database Tables');
         $page->addText(<<<RST

Upper-Lower-Casing +10 added lines, -10 removed lines

@@ -97,7 +97,7 @@ 
      */
     public function collectTables(): array
     {
-        $sqlCode = $this->sqlReader->getTablesDefinitionString(true);
+        $sqlCode = $this->sqlReader->getTablesDefinitionString(TRUE);
         $createTableStatements = $this->sqlReader->getCreateTableStatementArray($sqlCode);
 
         $tableToClassName = $this->getTableClassMap();
@@ -113,7 +113,7 @@ 
                 continue;
             }
 
-            $className = $tableToClassName[$tableName] ?? null;
+            $className = $tableToClassName[$tableName] ?? NULL;
 
             $result[] = $this->getTableInfo($table, $className);
         }
@@ -151,7 +151,7 @@ 
         $isPrimary = [];
         if (!is_null($primaryKey = $table->getPrimaryKey())) {
             foreach ($primaryKey->getUnquotedColumns() as $primaryColumn) {
-                $isPrimary[$primaryColumn] = true;
+                $isPrimary[$primaryColumn] = TRUE;
             }
         }
 
@@ -172,14 +172,14 @@ 
         $result = (object) [
             'name' => $tableName,
             'columns' => $columns,
-            'modelClass' => null,
+            'modelClass' => NULL,
             'sqlComment' => $table->getComment() ?? '',
             'classComment' => '',
             'feComment' => $this->languageService->sL($GLOBALS['TCA'][$tableName]['ctrl']['title'] ?? ''),
         ];
 
         // Integrate doc-comments from model class and its fields
-        if ($className !== null) {
+        if ($className !== NULL) {
             $reflection = new ReflectionClass($className);
 
             $dataMap = $this->dataMapper->getDataMap($className);
@@ -189,7 +189,7 @@ 
                 // In that case, try to guess the column name from the property name.
 
                 $column = $dataMap->getColumnMap($property->getName());
-                $columnName = $column === null
+                $columnName = $column === NULL
                     ? GeneralUtility::camelCaseToLowerCaseUnderscored($property->getName())
                     : $column->getColumnName();
 
@@ -215,7 +215,7 @@ 
         $lines = explode("\n", $docComment);
         foreach ($lines as $line) {
             // Stop parsing at first tag
-            if ($line !== '' && strpos($line, '@') !== false) {
+            if ($line !== '' && strpos($line, '@') !== FALSE) {
                 break;
             }
 
@@ -239,7 +239,7 @@ 
 This is a reference of all database tables defined by Kitodo.Presentation.
 
 .. tip:: This page is auto-generated. If you would like to edit it, please use doc-comments in the model class, COMMENT fields in ``ext_tables.sql`` if the table does not have one, or TCA labels. Then, you may re-generate the page by running ``composer docs:db`` inside the Kitodo.Presentation base folder.
-RST);
+rst);
 
         // Sort tables alphabetically
         usort($tables, function ($lhs, $rhs) {
@@ -274,11 +274,11 @@ 
                     'field' => (
                         $page->format($column->name, ['bold' => $column->isPrimary])
                         . "\u{00a0}\u{00a0}"
-                        . $page->format($column->type->getName(), ['italic' => true])
+                        . $page->format($column->type->getName(), ['italic' => TRUE])
                     ),
 
                     'description' => $page->paragraphs([
-                        $page->format($column->feComment, ['italic' => true]),
+                        $page->format($column->feComment, ['italic' => TRUE]),
                         $column->fieldComment,
                         $column->sqlComment,
                     ]),