Erikmitk / kitodo-presentation

Classes/Controller/AnnotationController.php

Braces +2 added lines, -4 removed lines

@@ -21,15 +21,13 @@
  * @subpackage dlf
  * @access public
  */
-class AnnotationController extends AbstractController
-{
+class AnnotationController extends AbstractController {
     /**
      * The main method of the plugin
      *
      * @return void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         $this->loadDocument();
 
         if (

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -33,8 +33,8 @@
         $this->loadDocument();
 
         if (
-            $this->document === null
-            || $this->document->getCurrentDocument() === null
+            $this->document === NULL
+            || $this->document->getCurrentDocument() === NULL
         ) {
             // Quit without doing anything if required variables are not set.
             return;

Classes/ViewHelpers/IsArrayViewHelper.php

Braces +3 added lines, -6 removed lines

@@ -18,10 +18,8 @@ 
 /**
  * Checks if the given subject is an array.
  */
-class IsArrayViewHelper extends AbstractViewHelper
-{
-    public function initializeArguments()
-    {
+class IsArrayViewHelper extends AbstractViewHelper {
+    public function initializeArguments() {
         parent::initializeArguments();
         $this->registerArgument('subject', 'string', 'The subject');
     }
@@ -29,8 +27,7 @@ 
     /**
      * @return bool
      */
-    public static function renderStatic(array $arguments, \Closure $renderChildrenClosure, RenderingContextInterface $renderingContext)
-    {
+    public static function renderStatic(array $arguments, \Closure $renderChildrenClosure, RenderingContextInterface $renderingContext) {
         $subject = $arguments['subject'];
         if ($subject === null) {
             $subject = $renderChildrenClosure();

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     public static function renderStatic(array $arguments, \Closure $renderChildrenClosure, RenderingContextInterface $renderingContext)
     {
         $subject = $arguments['subject'];
-        if ($subject === null) {
+        if ($subject === NULL) {
             $subject = $renderChildrenClosure();
         }
 

Classes/ViewHelpers/IsInArrayViewHelper.php

Braces +3 added lines, -6 removed lines

@@ -13,10 +13,8 @@ 
 
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
 
-class IsInArrayViewHelper extends AbstractViewHelper
-{
-    public function initializeArguments()
-    {
+class IsInArrayViewHelper extends AbstractViewHelper {
+    public function initializeArguments() {
         parent::initializeArguments();
         $this->registerArgument('needle', 'mixed', 'The searched value', true);
         $this->registerArgument('haystack', 'array', 'The array', true);
@@ -27,8 +25,7 @@ 
      *
      * @return bool
      */
-    public function render()
-    {
+    public function render() {
         $needle = $this->arguments['needle'];
         $haystack = $this->arguments['haystack'];
 

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -18,8 +18,8 @@
     public function initializeArguments()
     {
         parent::initializeArguments();
-        $this->registerArgument('needle', 'mixed', 'The searched value', true);
-        $this->registerArgument('haystack', 'array', 'The array', true);
+        $this->registerArgument('needle', 'mixed', 'The searched value', TRUE);
+        $this->registerArgument('haystack', 'array', 'The array', TRUE);
     }
 
     /**

Classes/ViewHelpers/ImplodeViewHelper.php

Braces +3 added lines, -6 removed lines

@@ -13,10 +13,8 @@ 
 
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
 
-class ImplodeViewHelper extends AbstractViewHelper
-{
-    public function initializeArguments()
-    {
+class ImplodeViewHelper extends AbstractViewHelper {
+    public function initializeArguments() {
         parent::initializeArguments();
         $this->registerArgument('value', 'array', 'The array to be imploded', true);
         $this->registerArgument('delimiter', 'string', 'The delimiter ', true);
@@ -27,8 +25,7 @@ 
      *
      * @return string
      */
-    public function render()
-    {
+    public function render() {
         $value = $this->arguments['value'];
         $delimiter = $this->arguments['delimiter'];
 

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -18,8 +18,8 @@
     public function initializeArguments()
     {
         parent::initializeArguments();
-        $this->registerArgument('value', 'array', 'The array to be imploded', true);
-        $this->registerArgument('delimiter', 'string', 'The delimiter ', true);
+        $this->registerArgument('value', 'array', 'The array to be imploded', TRUE);
+        $this->registerArgument('delimiter', 'string', 'The delimiter ', TRUE);
     }
 
     /**

Classes/Common/AnnotationRequest.php

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@ 
      */
     public function __construct($apiUrl)
     {
-        $this->apiUrl =  trim($apiUrl, "/ ");
+        $this->apiUrl = trim($apiUrl, "/ ");
     }
 
 
@@ -59,7 +59,7 @@ 
     {
         $annotations = [];
 
-        $annotationData = $this->requestAnnotions($this->apiUrl . '?target=' . urlencode($id . '/*'));
+        $annotationData = $this->requestAnnotions($this->apiUrl.'?target='.urlencode($id.'/*'));
 
         if (array_key_exists('first', $annotationData)) {
             $annotationPageData = $annotationData['first'];

Braces +3 added lines, -6 removed lines

@@ -12,8 +12,7 @@ 
  * LICENSE.txt file that was distributed with this source code.
  */
 
-class AnnotationRequest
-{
+class AnnotationRequest {
     /**
      * @var string
      */
@@ -22,8 +21,7 @@ 
     /**
      * @param string $apiUrl The url of the annotation server api.
      */
-    public function __construct($apiUrl)
-    {
+    public function __construct($apiUrl) {
         $this->apiUrl =  trim($apiUrl, "/ ");
     }
 
@@ -55,8 +53,7 @@ 
      * @param string $id Document id (purl)
      * @return array
      */
-    public function getAll($id)
-    {
+    public function getAll($id) {
         $annotations = [];
 
         $annotationData = $this->requestAnnotions($this->apiUrl . '?target=' . urlencode($id . '/*'));

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
         $jsonld = Helper::getUrl($url);
 
         if ($jsonld) {
-            $annotationData = json_decode($jsonld, true);
+            $annotationData = json_decode($jsonld, TRUE);
 
             if ($annotationData) {
                 return $annotationData;

Classes/Common/MetsDocument.php

Spacing +35 added lines, -35 removed lines

@@ -230,7 +230,7 @@ 
     {
         $file = $this->getFileInfo($id);
         if ($file['mimeType'] === 'application/vnd.kitodo.iiif') {
-            $file['location'] = (strrpos($file['location'], 'info.json') === strlen($file['location']) - 9) ? $file['location'] : (strrpos($file['location'], '/') === strlen($file['location']) ? $file['location'] . 'info.json' : $file['location'] . '/info.json');
+            $file['location'] = (strrpos($file['location'], 'info.json') === strlen($file['location']) - 9) ? $file['location'] : (strrpos($file['location'], '/') === strlen($file['location']) ? $file['location'].'info.json' : $file['location'].'/info.json');
             $conf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get(self::$extKey, 'iiif');
             IiifHelper::setUrlReader(IiifUrlReader::getInstance());
             IiifHelper::setMaxThumbnailHeight($conf['thumbnailHeight']);
@@ -240,9 +240,9 @@ 
                 return $service->getImageUrl();
             }
         } elseif ($file['mimeType'] === 'application/vnd.netfpx') {
-            $baseURL = $file['location'] . (strpos($file['location'], '?') === false ? '?' : '');
+            $baseURL = $file['location'].(strpos($file['location'], '?') === false ? '?' : '');
             // TODO CVT is an optional IIP server capability; in theory, capabilities should be determined in the object request with '&obj=IIP-server'
-            return $baseURL . '&CVT=jpeg';
+            return $baseURL.'&CVT=jpeg';
         }
         return $file['location'];
     }
@@ -271,14 +271,14 @@ 
      */
     public function getFileLocation(string $id): string
     {
-        $location = $this->mets->xpath('./mets:fileSec/mets:fileGrp/mets:file[@ID="' . $id . '"]/mets:FLocat[@LOCTYPE="URL"]');
+        $location = $this->mets->xpath('./mets:fileSec/mets:fileGrp/mets:file[@ID="'.$id.'"]/mets:FLocat[@LOCTYPE="URL"]');
         if (
             !empty($id)
             && !empty($location)
         ) {
             return (string) $location[0]->attributes('http://www.w3.org/1999/xlink')->href;
         } else {
-            $this->logger->warning('There is no file node with @ID "' . $id . '"');
+            $this->logger->warning('There is no file node with @ID "'.$id.'"');
             return '';
         }
     }
@@ -290,9 +290,9 @@ 
     {
         $mets = $this->mets
             ->xpath(
-                './mets:structMap[@TYPE="PHYSICAL"]' .
-                '//mets:div[@ID="' .  $pageId .  '"]' .
-                '/mets:fptr[@FILEID="' .  $fileId .  '"]' .
+                './mets:structMap[@TYPE="PHYSICAL"]'.
+                '//mets:div[@ID="'.$pageId.'"]'.
+                '/mets:fptr[@FILEID="'.$fileId.'"]'.
                 '/mets:area/@BEGIN'
             );
         return empty($mets) ? '' : $mets[0]->__toString();
@@ -304,14 +304,14 @@ 
      */
     public function getFileMimeType(string $id): string
     {
-        $mimetype = $this->mets->xpath('./mets:fileSec/mets:fileGrp/mets:file[@ID="' . $id . '"]/@MIMETYPE');
+        $mimetype = $this->mets->xpath('./mets:fileSec/mets:fileGrp/mets:file[@ID="'.$id.'"]/@MIMETYPE');
         if (
             !empty($id)
             && !empty($mimetype)
         ) {
             return (string) $mimetype[0];
         } else {
-            $this->logger->warning('There is no file node with @ID "' . $id . '" or no MIME type specified');
+            $this->logger->warning('There is no file node with @ID "'.$id.'" or no MIME type specified');
             return '';
         }
     }
@@ -331,7 +331,7 @@ 
             return $this->logicalUnits[$id];
         } elseif (!empty($id)) {
             // Get specified logical unit.
-            $divs = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="' . $id . '"]');
+            $divs = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="'.$id.'"]');
         } else {
             // Get all logical units at top level.
             $divs = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]/mets:div');
@@ -546,7 +546,7 @@ 
         $cPid = max($cPid, 0);
         if ($cPid == 0 && ($this->cPid || $this->pid)) {
             // Retain current PID.
-            $cPid = $this->cPid ?: $this->pid;
+            $cPid = $this->cPid ? : $this->pid;
         }
         return $cPid;
     }
@@ -613,7 +613,7 @@ 
         if (isset($this->fileInfos[$id]) || in_array('dmdSec', $metadataSections)) {
             return $metadata;
         } else {
-            $this->logger->warning('No supported descriptive metadata found for logical structure with @ID "' . $id . '"');
+            $this->logger->warning('No supported descriptive metadata found for logical structure with @ID "'.$id.'"');
             return [];
         }
     }
@@ -692,7 +692,7 @@ 
         if (!empty($this->logicalUnits[$id])) {
             return [$this->logicalUnits[$id]['type']];
         } else {
-            $struct = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="' . $id . '"]/@TYPE');
+            $struct = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="'.$id.'"]/@TYPE');
             if (!empty($struct)) {
                 return [(string) $struct[0]];
             }
@@ -849,17 +849,17 @@ 
             if ($resArray['format'] > 0 && !empty($resArray['xpath_sorting'])) {
                 $values = $domXPath->evaluate($resArray['xpath_sorting'], $domNode);
                 if ($values instanceof DOMNodeList && $values->length > 0) {
-                    $metadata[$indexName . '_sorting'][0] = trim((string) $values->item(0)->nodeValue);
+                    $metadata[$indexName.'_sorting'][0] = trim((string) $values->item(0)->nodeValue);
                 } elseif (!($values instanceof DOMNodeList)) {
-                    $metadata[$indexName . '_sorting'][0] = trim((string) $values);
+                    $metadata[$indexName.'_sorting'][0] = trim((string) $values);
                 }
             }
-            if (empty($metadata[$indexName . '_sorting'][0])) {
+            if (empty($metadata[$indexName.'_sorting'][0])) {
                 if (is_array($currentMetadata)) {
                     $sortingValue = implode(',', array_column($currentMetadata, 0));
-                    $metadata[$indexName . '_sorting'][0] = $sortingValue;
+                    $metadata[$indexName.'_sorting'][0] = $sortingValue;
                 } else {
-                    $metadata[$indexName . '_sorting'][0] = $currentMetadata;
+                    $metadata[$indexName.'_sorting'][0] = $currentMetadata;
                 }
             }
         }
@@ -920,11 +920,11 @@ 
                         return true;
                     }
                 } else {
-                    $this->logger->warning('Invalid class/method "' . $class . '->extractMetadata()" for metadata format "' . $this->mdSec[$dmdId]['type'] . '"');
+                    $this->logger->warning('Invalid class/method "'.$class.'->extractMetadata()" for metadata format "'.$this->mdSec[$dmdId]['type'].'"');
                 }
             }
         } else {
-            $this->logger->notice('Unsupported metadata format "' . $this->mdSec[$dmdId]['type'] . '" in ' . $mdSectionType . ' with @ID "' . $dmdId . '"');
+            $this->logger->notice('Unsupported metadata format "'.$this->mdSec[$dmdId]['type'].'" in '.$mdSectionType.' with @ID "'.$dmdId.'"');
         }
         return false;
     }
@@ -1077,7 +1077,7 @@ 
             $dmdIds = $this->logicalUnits[$id]['dmdId'] ?? '';
             $admIds = $this->logicalUnits[$id]['admId'] ?? '';
         } else {
-            $mdSec = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="' . $id . '"]')[0];
+            $mdSec = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="'.$id.'"]')[0];
             if ($mdSec) {
                 $dmdIds = (string) $mdSec->attributes()->DMDID;
                 $admIds = (string) $mdSec->attributes()->ADMID;
@@ -1107,7 +1107,7 @@ 
 
         return array_filter(
             $allMdIds,
-            function ($element) {
+            function($element) {
                 return !empty($element);
             }
         );
@@ -1133,7 +1133,7 @@ 
      */
     public function getStructureDepth(string $logId)
     {
-        $ancestors = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="' . $logId . '"]/ancestor::*');
+        $ancestors = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="'.$logId.'"]/ancestor::*');
         if (!empty($ancestors)) {
             return count($ancestors);
         } else {
@@ -1157,9 +1157,9 @@ 
             $this->registerNamespaces($this->mets);
         } else {
             if (!empty($location)) {
-                $this->logger->error('No METS part found in document with location "' . $location . '".');
+                $this->logger->error('No METS part found in document with location "'.$location.'".');
             } elseif (!empty($this->recordId)) {
-                $this->logger->error('No METS part found in document with recordId "' . $this->recordId . '".');
+                $this->logger->error('No METS part found in document with recordId "'.$this->recordId.'".');
             } else {
                 $this->logger->error('No METS part found in current document.');
             }
@@ -1180,7 +1180,7 @@ 
                 return true;
             }
         }
-        $this->logger->error('Could not load XML file from "' . $location . '"');
+        $this->logger->error('Could not load XML file from "'.$location.'"');
         return false;
     }
 
@@ -1303,10 +1303,10 @@ 
 
         if (!empty($mdType) && !empty($this->formats[(string) $mdType[0]])) {
             $type = (string) $mdType[0];
-            $xml = $element->xpath('./mets:mdWrap[@MDTYPE="' . $type . '"]/mets:xmlData/' . strtolower($type) . ':' . $this->formats[$type]['rootElement']);
+            $xml = $element->xpath('./mets:mdWrap[@MDTYPE="'.$type.'"]/mets:xmlData/'.strtolower($type).':'.$this->formats[$type]['rootElement']);
         } elseif (!empty($otherMdType) && !empty($this->formats[(string) $otherMdType[0]])) {
             $type = (string) $otherMdType[0];
-            $xml = $element->xpath('./mets:mdWrap[@MDTYPE="OTHER"][@OTHERMDTYPE="' . $type . '"]/mets:xmlData/' . strtolower($type) . ':' . $this->formats[$type]['rootElement']);
+            $xml = $element->xpath('./mets:mdWrap[@MDTYPE="OTHER"][@OTHERMDTYPE="'.$type.'"]/mets:xmlData/'.strtolower($type).':'.$this->formats[$type]['rootElement']);
         }
 
         if (empty($xml)) {
@@ -1513,7 +1513,7 @@ 
             // Get track info wtih begin end extent time for later assignment with musical
             if ((string) $elementNode['TYPE'] === 'track') {
                 foreach ($elementNode->children('http://www.loc.gov/METS/')->fptr as $fptr) {
-                    if (isset($fptr->area) &&  ((string) $fptr->area->attributes()->BETYPE === 'TIME')) {
+                    if (isset($fptr->area) && ((string) $fptr->area->attributes()->BETYPE === 'TIME')) {
                         // Check if file has valid @USE attribute.
                         if (!empty($fileUse[(string) $fptr->area->attributes()->FILEID])) {
                             $this->physicalStructureInfo[$elements[(int) $elementNode['ORDER']]]['tracks'][$fileUse[(string) $fptr->area->attributes()->FILEID]] = [
@@ -1567,9 +1567,9 @@ 
             || $forceReload
         ) {
             // Retain current PID.
-            $cPid = $this->cPid ?: $this->pid;
+            $cPid = $this->cPid ? : $this->pid;
             if (!$cPid) {
-                $this->logger->error('Invalid PID ' . $cPid . ' for structure definitions');
+                $this->logger->error('Invalid PID '.$cPid.' for structure definitions');
                 $this->thumbnailLoaded = true;
                 return $this->thumbnail;
             }
@@ -1606,7 +1606,7 @@ 
                 if (!empty($resArray['thumbnail'])) {
                     $strctType = Helper::getIndexNameFromUid($resArray['thumbnail'], 'tx_dlf_structures', $cPid);
                     // Check if this document has a structure element of the desired type.
-                    $strctIds = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@TYPE="' . $strctType . '"]/@ID');
+                    $strctIds = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@TYPE="'.$strctType.'"]/@ID');
                     if (!empty($strctIds)) {
                         $strctId = (string) $strctIds[0];
                     }
@@ -1629,7 +1629,7 @@ 
                     }
                 }
             } else {
-                $this->logger->error('No structure of type "' . $metadata['type'][0] . '" found in database');
+                $this->logger->error('No structure of type "'.$metadata['type'][0].'" found in database');
             }
             $this->thumbnailLoaded = true;
         }
@@ -1675,7 +1675,7 @@ 
     {
         if (empty($this->parentHref)) {
             // Get the closest ancestor of the current document which has a MPTR child.
-            $parentMptr = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="' . $this->toplevelId . '"]/ancestor::mets:div[./mets:mptr][1]/mets:mptr');
+            $parentMptr = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="'.$this->toplevelId.'"]/ancestor::mets:div[./mets:mptr][1]/mets:mptr');
             if (!empty($parentMptr)) {
                 $this->parentHref = (string) $parentMptr[0]->attributes('http://www.w3.org/1999/xlink')->href;
             }

Braces +8 added lines, -16 removed lines

@@ -72,8 +72,7 @@ 
  * @property-read SimpleXMLElement $mets this holds the XML file's METS part as SimpleXMLElement object
  * @property-read string $parentHref URL of the parent document (determined via mptr element), or empty string if none is available
  */
-final class MetsDocument extends AbstractDocument
-{
+final class MetsDocument extends AbstractDocument {
     /**
      * @access protected
      * @var string[] Subsections / tags that may occur within `<mets:amdSec>`
@@ -286,8 +285,7 @@ 
     /**
      * This gets the measure beginning of a page
      */
-    public function getPageBeginning($pageId, $fileId)
-    {
+    public function getPageBeginning($pageId, $fileId) {
         $mets = $this->mets
             ->xpath(
                 './mets:structMap[@TYPE="PHYSICAL"]' .
@@ -482,8 +480,7 @@ 
      *
      * @return ?string thumbnail or null if not found
      */
-    private function getThumbnail(string $id = '')
-    {
+    private function getThumbnail(string $id = '') {
         // Load plugin configuration.
         $extConf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get(self::$extKey, 'files');
         $fileGrpsThumb = GeneralUtility::trimExplode(',', $extConf['fileGrpThumbs']);
@@ -624,8 +621,7 @@ 
      * @param DOMNode $parentNode
      * @return array|false
      */
-    private function getSubentries($allSubentries, string $parentIndex, DOMNode $parentNode)
-    {
+    private function getSubentries($allSubentries, string $parentIndex, DOMNode $parentNode) {
         $domXPath = new DOMXPath($parentNode->ownerDocument);
         $this->registerNamespaces($domXPath);
         $theseSubentries = [];
@@ -655,8 +651,7 @@ 
      * @param $subentry
      * @return array
      */
-    private function getSubentryValue($values, $subentry)
-    {
+    private function getSubentryValue($values, $subentry) {
         $theseSubentries = [];
         if (
             ($values instanceof DOMNodeList
@@ -906,8 +901,7 @@ 
      *
      * @return bool true if extraction successful, false otherwise
      */
-    private function extractMetadataIfTypeSupported(string $dmdId, string $mdSectionType, array &$metadata)
-    {
+    private function extractMetadataIfTypeSupported(string $dmdId, string $mdSectionType, array &$metadata) {
         // Is this metadata format supported?
         if (!empty($this->formats[$this->mdSec[$dmdId]['type']])) {
             if (!empty($this->formats[$this->mdSec[$dmdId]['type']]['class'])) {
@@ -939,8 +933,7 @@ 
      *
      * @return array additional metadata data queried from database
      */
-    private function getAdditionalMetadataFromDatabase(int $cPid, string $dmdId)
-    {
+    private function getAdditionalMetadataFromDatabase(int $cPid, string $dmdId) {
         $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
             ->getQueryBuilderForTable('tx_dlf_metadata');
         // Get hidden records, too.
@@ -1131,8 +1124,7 @@ 
     /**
      * @see AbstractDocument::getStructureDepth()
      */
-    public function getStructureDepth(string $logId)
-    {
+    public function getStructureDepth(string $logId) {
         $ancestors = $this->mets->xpath('./mets:structMap[@TYPE="LOGICAL"]//mets:div[@ID="' . $logId . '"]/ancestor::*');
         if (!empty($ancestors)) {
             return count($ancestors);

Upper-Lower-Casing +44 added lines, -44 removed lines

@@ -109,7 +109,7 @@ 
      *
      * @see MetsDocument::$mdSec
      */
-    protected bool $mdSecLoaded = false;
+    protected bool $mdSecLoaded = FALSE;
 
     /**
      * @access protected
@@ -131,7 +131,7 @@ 
      *
      * @see $fileGrps
      */
-    protected bool $fileGrpsLoaded = false;
+    protected bool $fileGrpsLoaded = FALSE;
 
     /**
      * @access protected
@@ -174,7 +174,7 @@ 
      * @var bool
      * @access protected
      */
-    protected bool $musicalStructureLoaded = false;
+    protected bool $musicalStructureLoaded = FALSE;
 
     /**
      * The holds the total number of measures
@@ -240,7 +240,7 @@ 
                 return $service->getImageUrl();
             }
         } elseif ($file['mimeType'] === 'application/vnd.netfpx') {
-            $baseURL = $file['location'] . (strpos($file['location'], '?') === false ? '?' : '');
+            $baseURL = $file['location'] . (strpos($file['location'], '?') === FALSE ? '?' : '');
             // TODO CVT is an optional IIP server capability; in theory, capabilities should be determined in the object request with '&obj=IIP-server'
             return $baseURL . '&CVT=jpeg';
         }
@@ -263,7 +263,7 @@ 
             $this->fileInfos[$id]['mimeType'] = $this->getFileMimeType($id);
         }
 
-        return $this->fileInfos[$id] ?? null;
+        return $this->fileInfos[$id] ?? NULL;
     }
 
     /**
@@ -319,7 +319,7 @@ 
     /**
      * @see AbstractDocument::getLogicalStructure()
      */
-    public function getLogicalStructure(string $id, bool $recursive = false): array
+    public function getLogicalStructure(string $id, bool $recursive = FALSE): array
     {
         $details = [];
         // Is the requested logical unit already loaded?
@@ -360,7 +360,7 @@ 
      *
      * @return array Array of the element's id, label, type and physical page indexes/mptr link
      */
-    protected function getLogicalStructureInfo(SimpleXMLElement $structure, bool $recursive = false): array
+    protected function getLogicalStructureInfo(SimpleXMLElement $structure, bool $recursive = FALSE): array
     {
         $attributes = $structure->attributes();
 
@@ -378,7 +378,7 @@ 
             'pagination' => '',
             'type' => isset($attributes['TYPE']) ? (string) $attributes['TYPE'] : '',
             'description' => '',
-            'thumbnailId' => null,
+            'thumbnailId' => NULL,
             'files' => [],
         ];
 
@@ -413,7 +413,7 @@ 
             $details['children'] = [];
             foreach ($structure->children('http://www.loc.gov/METS/')->div as $child) {
                 // Repeat for all children.
-                $details['children'][] = $this->getLogicalStructureInfo($child, true);
+                $details['children'][] = $this->getLogicalStructureInfo($child, TRUE);
             }
         }
         return $details;
@@ -459,7 +459,7 @@ 
             && array_key_exists($details['id'], $this->smLinks['l2p'])
         ) {
             // Link logical structure to the first corresponding physical page/track.
-            $details['points'] = max((int) array_search($this->smLinks['l2p'][$details['id']][0], $this->physicalStructure, true), 1);
+            $details['points'] = max((int) array_search($this->smLinks['l2p'][$details['id']][0], $this->physicalStructure, TRUE), 1);
             $details['thumbnailId'] = $this->getThumbnail();
             // Get page/track number of the first page/track related to this structure element.
             $details['pagination'] = $this->physicalStructureInfo[$this->smLinks['l2p'][$details['id']][0]]['orderlabel'];
@@ -468,7 +468,7 @@ 
             $details['points'] = 1;
             $details['thumbnailId'] = $this->getThumbnail();
         }
-        if ($details['thumbnailId'] === null) {
+        if ($details['thumbnailId'] === NULL) {
             unset($details['thumbnailId']);
         }
     }
@@ -488,14 +488,14 @@ 
         $extConf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get(self::$extKey, 'files');
         $fileGrpsThumb = GeneralUtility::trimExplode(',', $extConf['fileGrpThumbs']);
 
-        $thumbnail = null;
+        $thumbnail = NULL;
 
         while ($fileGrpThumb = array_shift($fileGrpsThumb)) {
             if (empty($id)) {
-                $thumbnail = $this->physicalStructureInfo[$this->physicalStructure[1]]['files'][$fileGrpThumb] ?? null;
+                $thumbnail = $this->physicalStructureInfo[$this->physicalStructure[1]]['files'][$fileGrpThumb] ?? NULL;
             } else {
-                $parentId = $this->smLinks['l2p'][$id][0] ?? null;
-                $thumbnail = $this->physicalStructureInfo[$parentId]['files'][$fileGrpThumb] ?? null;
+                $parentId = $this->smLinks['l2p'][$id][0] ?? NULL;
+                $thumbnail = $this->physicalStructureInfo[$parentId]['files'][$fileGrpThumb] ?? NULL;
             }
 
             if (!empty($thumbnail)) {
@@ -645,7 +645,7 @@ 
             }
         }
         if (empty($theseSubentries)) {
-            return false;
+            return FALSE;
         }
         return $theseSubentries;
     }
@@ -716,13 +716,13 @@ 
     private function extractAndProcessMetadata(string $dmdId, string $mdSectionType, array &$metadata, int $cPid, array $metadataSections): bool
     {
         if ($this->hasMetadataSection($metadataSections, $mdSectionType, 'dmdSec')) {
-            return true;
+            return TRUE;
         }
 
         $metadataExtracted = $this->extractMetadataIfTypeSupported($dmdId, $mdSectionType, $metadata);
 
         if (!$metadataExtracted) {
-            return false;
+            return FALSE;
         }
 
         $additionalMetadata = $this->getAdditionalMetadataFromDatabase($cPid, $dmdId);
@@ -733,7 +733,7 @@ 
 
         $this->processAdditionalMetadata($additionalMetadata, $domXPath, $domNode, $metadata);
 
-        return true;
+        return TRUE;
     }
 
     /**
@@ -917,7 +917,7 @@ 
                     $obj = GeneralUtility::makeInstance($class);
                     if ($obj instanceof MetadataInterface) {
                         $obj->extractMetadata($this->mdSec[$dmdId]['xml'], $metadata, GeneralUtility::makeInstance(ExtensionConfiguration::class)->get(self::$extKey, 'general')['useExternalApisForMetadata']);
-                        return true;
+                        return TRUE;
                     }
                 } else {
                     $this->logger->warning('Invalid class/method "' . $class . '->extractMetadata()" for metadata format "' . $this->mdSec[$dmdId]['type'] . '"');
@@ -926,7 +926,7 @@ 
         } else {
             $this->logger->notice('Unsupported metadata format "' . $this->mdSec[$dmdId]['type'] . '" in ' . $mdSectionType . ' with @ID "' . $dmdId . '"');
         }
-        return false;
+        return FALSE;
     }
 
     /**
@@ -1172,16 +1172,16 @@ 
     protected function loadLocation(string $location): bool
     {
         $fileResource = Helper::getUrl($location);
-        if ($fileResource !== false) {
+        if ($fileResource !== FALSE) {
             $xml = Helper::getXmlFileAsString($fileResource);
             // Set some basic properties.
-            if ($xml !== false) {
+            if ($xml !== FALSE) {
                 $this->xml = $xml;
-                return true;
+                return TRUE;
             }
         }
         $this->logger->error('Could not load XML file from "' . $location . '"');
-        return false;
+        return FALSE;
     }
 
     /**
@@ -1203,9 +1203,9 @@ 
 
         if ($preloadedDocument instanceof SimpleXMLElement) {
             $this->xml = $preloadedDocument;
-            return true;
+            return TRUE;
         }
-        return false;
+        return FALSE;
     }
 
     /**
@@ -1231,7 +1231,7 @@ 
             foreach ($this->mets->xpath('./mets:dmdSec') as $dmdSecTag) {
                 $dmdSec = $this->processMdSec($dmdSecTag);
 
-                if ($dmdSec !== null) {
+                if ($dmdSec !== NULL) {
                     $this->mdSec[$dmdSec['id']] = $dmdSec;
                     $this->dmdSec[$dmdSec['id']] = $dmdSec;
                 }
@@ -1248,7 +1248,7 @@ 
                     // TODO: Should we check that the format may occur within this type (e.g., to ignore VIDEOMD within rightsMD)?
                     $mdSec = $this->processMdSec($mdSecTag);
 
-                    if ($mdSec !== null) {
+                    if ($mdSec !== NULL) {
                         $this->mdSec[$mdSec['id']] = $mdSec;
 
                         $childIds[] = $mdSec['id'];
@@ -1261,7 +1261,7 @@ 
                 }
             }
 
-            $this->mdSecLoaded = true;
+            $this->mdSecLoaded = TRUE;
         }
         return $this->mdSec;
     }
@@ -1292,7 +1292,7 @@ 
     {
         $mdId = (string) $element->attributes()->ID;
         if (empty($mdId)) {
-            return null;
+            return NULL;
         }
 
         $this->registerNamespaces($element);
@@ -1310,7 +1310,7 @@ 
         }
 
         if (empty($xml)) {
-            return null;
+            return NULL;
         }
 
         $this->registerNamespaces($xml[0]);
@@ -1376,9 +1376,9 @@ 
                 !empty($extConf['fileGrpFulltext'])
                 && array_intersect(GeneralUtility::trimExplode(',', $extConf['fileGrpFulltext']), $this->fileGrps) !== []
             ) {
-                $this->hasFulltext = true;
+                $this->hasFulltext = TRUE;
             }
-            $this->fileGrpsLoaded = true;
+            $this->fileGrpsLoaded = TRUE;
         }
         return $this->fileGrps;
     }
@@ -1439,7 +1439,7 @@ 
 
                 $this->physicalStructure = $this->getPhysicalElements($elementNodes, $fileUse);
             }
-            $this->physicalStructureLoaded = true;
+            $this->physicalStructureLoaded = TRUE;
 
         }
 
@@ -1552,7 +1552,7 @@ 
                     $this->smLinks['p2l'][(string) $smLink->attributes('http://www.w3.org/1999/xlink')->to][] = (string) $smLink->attributes('http://www.w3.org/1999/xlink')->from;
                 }
             }
-            $this->smLinksLoaded = true;
+            $this->smLinksLoaded = TRUE;
         }
         return $this->smLinks;
     }
@@ -1560,7 +1560,7 @@ 
     /**
      * @see AbstractDocument::magicGetThumbnail()
      */
-    protected function magicGetThumbnail(bool $forceReload = false): string
+    protected function magicGetThumbnail(bool $forceReload = FALSE): string
     {
         if (
             !$this->thumbnailLoaded
@@ -1570,14 +1570,14 @@ 
             $cPid = $this->cPid ?: $this->pid;
             if (!$cPid) {
                 $this->logger->error('Invalid PID ' . $cPid . ' for structure definitions');
-                $this->thumbnailLoaded = true;
+                $this->thumbnailLoaded = TRUE;
                 return $this->thumbnail;
             }
             // Load extension configuration.
             $extConf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get(self::$extKey, 'files');
             if (empty($extConf['fileGrpThumbs'])) {
                 $this->logger->warning('No fileGrp for thumbnails specified');
-                $this->thumbnailLoaded = true;
+                $this->thumbnailLoaded = TRUE;
                 return $this->thumbnail;
             }
             $strctId = $this->magicGetToplevelId();
@@ -1631,7 +1631,7 @@ 
             } else {
                 $this->logger->error('No structure of type "' . $metadata['type'][0] . '" found in database');
             }
-            $this->thumbnailLoaded = true;
+            $this->thumbnailLoaded = TRUE;
         }
         return $this->thumbnail;
     }
@@ -1709,8 +1709,8 @@ 
     public function __toString(): string
     {
         $xml = new DOMDocument('1.0', 'utf-8');
-        $xml->appendChild($xml->importNode(dom_import_simplexml($this->mets), true));
-        $xml->formatOutput = true;
+        $xml->appendChild($xml->importNode(dom_import_simplexml($this->mets), TRUE));
+        $xml->formatOutput = TRUE;
         return $xml->saveXML();
     }
 
@@ -1725,7 +1725,7 @@ 
     public function __wakeup(): void
     {
         $xml = Helper::getXmlFileAsString($this->asXML);
-        if ($xml !== false) {
+        if ($xml !== FALSE) {
             $this->asXML = '';
             $this->xml = $xml;
             // Rebuild the unserializable properties.
@@ -1848,7 +1848,7 @@ 
                 }
 
             }
-            $this->musicalStructureLoaded = true;
+            $this->musicalStructureLoaded = TRUE;
         }
 
         return $this->musicalStructure;

Classes/Common/DocumentAnnotation.php

Indentation +3 added lines, -3 removed lines

@@ -130,11 +130,11 @@
                             );
                         }
                     } elseif ($annotationTarget->getObjectId()) {
-                         $objectTargetPages = [];
+                            $objectTargetPages = [];
                         foreach ($this->document->getCurrentDocument()->physicalStructureInfo as $physInfo) {
-                             $order = $physInfo['order'];
+                                $order = $physInfo['order'];
                             if ($order) {
-                                 $objectTargetPages[] = $order;
+                                    $objectTargetPages[] = $order;
                             }
                         }
                         if ($objectTargetPages) {

Spacing +11 added lines, -11 removed lines

@@ -108,8 +108,8 @@ 
                                     ];
                                 } else {
                                     $this->logger->warning(
-                                        ' No target pages found! Annotation: "' . $annotation->getId() . '", '
-                                        . 'Target: "' . $annotationTarget->getUrl() . '"'
+                                        ' No target pages found! Annotation: "'.$annotation->getId().'", '
+                                        . 'Target: "'.$annotationTarget->getUrl().'"'
                                     );
                                 }
                             }
@@ -125,8 +125,8 @@ 
                             ];
                         } else {
                             $this->logger->warning(
-                                ' No target pages found! Annotation: "' . $annotation->getId() . '", '
-                                . 'Target: "' . $annotationTarget->getUrl() . '"'
+                                ' No target pages found! Annotation: "'.$annotation->getId().'", '
+                                . 'Target: "'.$annotationTarget->getUrl().'"'
                             );
                         }
                     } elseif ($annotationTarget->getObjectId()) {
@@ -145,14 +145,14 @@ 
                         }
                     } else {
                         $this->logger->warning(
-                            ' No target pages found! Annotation: "' . $annotation->getId() . '", '
-                            . 'Target: "' . $annotationTarget->getUrl() . '"'
+                            ' No target pages found! Annotation: "'.$annotation->getId().'", '
+                            . 'Target: "'.$annotationTarget->getUrl().'"'
                         );
                     }
                 } else {
                     $this->logger->warning(
-                        'Invalid target! Annotation: "' . $annotation->getId() . '", '
-                        . 'Target: "' . $annotationTarget->getUrl() . '"'
+                        'Invalid target! Annotation: "'.$annotation->getId().'", '
+                        . 'Target: "'.$annotationTarget->getUrl().'"'
                     );
                 }
             }
@@ -267,10 +267,10 @@ 
                 $intervalTo = \DateTime::createFromFormat('U.u', $to);
             }
             foreach ($tracks as $index => $track) {
-                $begin = new DateTime("1970-01-01 " . $track['begin']);
-                $extent = new DateTime("1970-01-01 " . $track['extent']);
+                $begin = new DateTime("1970-01-01 ".$track['begin']);
+                $extent = new DateTime("1970-01-01 ".$track['extent']);
                 $diff = (new DateTime("1970-01-01 00:00:00"))->diff($extent);
-                $end = (new DateTime("1970-01-01 " . $track['begin']))->add($diff);
+                $end = (new DateTime("1970-01-01 ".$track['begin']))->add($diff);
                 if (
                     !(
                         $intervalFrom < $end && (

Braces +11 added lines, -22 removed lines

@@ -28,8 +28,7 @@ 
  *
  * @access public
  */
-class DocumentAnnotation
-{
+class DocumentAnnotation {
     /**
      * @var null|DocumentAnnotation
      */
@@ -55,8 +54,7 @@ 
      * @param array $annotationData
      * @param Document $document
      */
-    private function __construct($annotationData, $document)
-    {
+    private function __construct($annotationData, $document) {
         $this->annotationData = $annotationData;
         $this->document = $document;
         $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(static::class);
@@ -67,8 +65,7 @@ 
      *
      * @return Annotation[]|array
      */
-    public function getAnnotations()
-    {
+    public function getAnnotations() {
         if (empty($this->annotationData)) {
             return [];
         }
@@ -168,8 +165,7 @@ 
      * @param string $logicalId
      * @return array
      */
-    protected function getPagesByLogicalId($logicalId)
-    {
+    protected function getPagesByLogicalId($logicalId) {
         $pages = [];
         if (
             array_key_exists('l2p', $this->document->getCurrentDocument()->smLinks) &&
@@ -193,8 +189,7 @@ 
      * @param string $physicalId
      * @return array
      */
-    protected function getPagesByPhysicalId($physicalId)
-    {
+    protected function getPagesByPhysicalId($physicalId) {
         $pages = [];
         foreach ($this->document->getCurrentDocument()->physicalStructureInfo as $physicalInfo) {
             $order = $physicalInfo['order'];
@@ -217,8 +212,7 @@ 
      * @param string $fileId
      * @return array
      */
-    protected function getPagesByFileId($fileId)
-    {
+    protected function getPagesByFileId($fileId) {
         $pages = [];
         foreach ($this->document->getCurrentDocument()->physicalStructureInfo as $physicalInfo) {
             if (
@@ -243,8 +237,7 @@ 
      * @param string $range
      * @return array
      */
-    protected function getAudioPagesByFileId($fileId, $range = null)
-    {
+    protected function getAudioPagesByFileId($fileId, $range = null) {
         $tracks = [];
         foreach ($this->document->getCurrentDocument()->physicalStructureInfo as $physicalInfo) {
             if (array_key_exists('tracks', $physicalInfo) && is_array($physicalInfo['tracks'])) {
@@ -299,8 +292,7 @@ 
      * @param string $range
      * @return array
      */
-    protected function getMeasurePagesByFileId($fileId, $range = null)
-    {
+    protected function getMeasurePagesByFileId($fileId, $range = null) {
         // Get all measures referencing the fileid
         $measures = [];
         // Get the related page numbers
@@ -355,8 +347,7 @@ 
      *
      * @return array
      */
-    public function getVerovioRelevantAnnotations()
-    {
+    public function getVerovioRelevantAnnotations() {
         $annotations = [];
         /** @var Annotation $annotation */
         foreach ($this->getAnnotations() as $annotation) {
@@ -373,8 +364,7 @@ 
      * @param Document $document
      * @return array
      */
-    protected static function loadData($document)
-    {
+    protected static function loadData($document) {
         $annotationData = [];
         $conf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get('dlf');
         $apiBaseUrl = $conf['annotationServerUrl'];
@@ -393,8 +383,7 @@ 
      * @return DocumentAnnotation|null
      *
      */
-    public static function getInstance($document)
-    {
+    public static function getInstance($document) {
         if (self::$instance == null) {
             $annotationData = self::loadData($document);
             self::$instance = new DocumentAnnotation($annotationData, $document);

Upper-Lower-Casing +7 added lines, -7 removed lines

@@ -90,7 +90,7 @@ 
                                     $targetPages[] = [
                                         'target' => $annotationTarget,
                                         'pages' => $meiTargetPages,
-                                        'verovioRelevant' => true
+                                        'verovioRelevant' => TRUE
                                     ];
                                 } elseif (
                                     $audioTargetPages = $this->getAudioPagesByFileId(
@@ -243,7 +243,7 @@ 
      * @param string $range
      * @return array
      */
-    protected function getAudioPagesByFileId($fileId, $range = null)
+    protected function getAudioPagesByFileId($fileId, $range = NULL)
     {
         $tracks = [];
         foreach ($this->document->getCurrentDocument()->physicalStructureInfo as $physicalInfo) {
@@ -261,7 +261,7 @@ 
             $from = sprintf('%02.6f', (empty($from) ? "0" : $from));
             $intervalFrom = \DateTime::createFromFormat('U.u', $from);
             if (empty($to)) {
-                $intervalTo = null;
+                $intervalTo = NULL;
             } else {
                 $to = sprintf('%02.6f', $to);
                 $intervalTo = \DateTime::createFromFormat('U.u', $to);
@@ -274,7 +274,7 @@ 
                 if (
                     !(
                         $intervalFrom < $end && (
-                            $intervalTo === null || $intervalTo > $begin
+                            $intervalTo === NULL || $intervalTo > $begin
                         )
                     )
                 ) {
@@ -285,7 +285,7 @@ 
         // Get the related page numbers
         $trackPages = [];
         foreach ($tracks as $track) {
-            if ($track['order'] !== null) {
+            if ($track['order'] !== NULL) {
                 $trackPages[] = $track['order'];
             }
         }
@@ -299,7 +299,7 @@ 
      * @param string $range
      * @return array
      */
-    protected function getMeasurePagesByFileId($fileId, $range = null)
+    protected function getMeasurePagesByFileId($fileId, $range = NULL)
     {
         // Get all measures referencing the fileid
         $measures = [];
@@ -395,7 +395,7 @@ 
      */
     public static function getInstance($document)
     {
-        if (self::$instance == null) {
+        if (self::$instance == NULL) {
             $annotationData = self::loadData($document);
             self::$instance = new DocumentAnnotation($annotationData, $document);
         }

Configuration/TCA/tx_dlf_metadatasubentries.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -87,7 +87,7 @@ 
             'label' => 'LLL:EXT:dlf/Resources/Private/Language/locallang_labels.xlf:tx_dlf_metadata.wrap',
             'config' => [
                 'behaviour' => [
-                    'allowLanguageSynchronization' => true
+                    'allowLanguageSynchronization' => TRUE
                 ],
                 'type' => 'text',
                 'cols' => 48,
@@ -95,8 +95,8 @@ 
                 'wrap' => 'off',
                 'eval' => 'trim',
                 'default' => "key.wrap = <strong>|:</strong>\nvalue.required = 1\nvalue.wrap = <span>|</span>\nall.wrap = <li>|</li>",
-                'fixedFont' => true,
-                'enableTabulator' => true
+                'fixedFont' => TRUE,
+                'enableTabulator' => TRUE
             ],
         ],
     ],

Classes/Controller/AbstractController.php

Braces +9 added lines, -12 removed lines

@@ -35,8 +35,7 @@ 
  *
  * @abstract
  */
-abstract class AbstractController extends ActionController implements LoggerAwareInterface
-{
+abstract class AbstractController extends ActionController implements LoggerAwareInterface {
     use LoggerAwareTrait;
 
     /**
@@ -236,8 +235,7 @@ 
      *
      * @return null|string|array
      */
-    protected function getParametersSafely(string $parameterName)
-    {
+    protected function getParametersSafely(string $parameterName) {
         if ($this->request->hasArgument($parameterName)) {
             return $this->request->getArgument($parameterName);
         }
@@ -333,8 +331,7 @@ 
      *
      * @return void
      */
-    public function __construct()
-    {
+    public function __construct() {
         $this->initialize();
     }
 
@@ -375,7 +372,8 @@ 
         $lastStartRecordNumberGrid = 0; // due to validity outside the loop
         foreach (range($firstPage, $lastPage) as $i) {
             // detect which pagination is active: ListView or GridView
-            if (get_class($pagination) == 'TYPO3\CMS\Core\Pagination\SimplePagination') {  // ListView
+            if (get_class($pagination) == 'TYPO3\CMS\Core\Pagination\SimplePagination') {
+// ListView
                 $lastStartRecordNumberGrid = $i; // save last $startRecordNumber for LastPage button
 
                 $pages[$i] = [
@@ -388,7 +386,8 @@ 
                 if (in_array($i, $aRange)) {
                     array_push($pagesSect, ['label' => $i, 'startRecordNumber' => $i]);
                 };
-            } else { // GridView
+            } else {
+// GridView
                 // to calculate the values for generation the links for the pagination pages
                 /** @var \Kitodo\Dlf\Pagination\PageGridPaginator $paginator */
                 $itemsPerPage = $paginator->getPublicItemsPerPage();
@@ -468,8 +467,7 @@ 
      *
      * @return AbstractDocument
      */
-    private function getDocumentByUid(int $documentId)
-    {
+    private function getDocumentByUid(int $documentId) {
         $doc = null;
         $this->document = $this->documentRepository->findOneByIdAndSettings($documentId);
 
@@ -491,8 +489,7 @@ 
      *
      * @return AbstractDocument
      */
-    protected function getDocumentByUrl(string $documentId)
-    {
+    protected function getDocumentByUrl(string $documentId) {
         $doc = AbstractDocument::getInstance($documentId, $this->settings, true);
 
         if (isset($this->settings['multiViewType']) && $doc->tableOfContents[0]['type'] === $this->settings['multiViewType']) {

Upper-Lower-Casing +19 added lines, -19 removed lines

@@ -61,7 +61,7 @@ 
      * @access protected
      * @var Document|null This holds the current document
      */
-    protected ?Document $document = null;
+    protected ?Document $document = NULL;
 
     /**
      * @access protected
@@ -137,7 +137,7 @@ 
         // Try to get document format from database
         if (!empty($documentId)) {
 
-            $doc = null;
+            $doc = NULL;
 
             if (MathUtility::canBeInterpretedAsInteger($documentId)) {
                 $doc = $this->getDocumentByUid($documentId);
@@ -145,7 +145,7 @@ 
                 $doc = $this->getDocumentByUrl($documentId);
             }
 
-            if ($this->document !== null && $doc !== null) {
+            if ($this->document !== NULL && $doc !== NULL) {
                 $this->document->setCurrentDocument($doc);
             }
 
@@ -153,9 +153,9 @@ 
 
             $this->document = $this->documentRepository->findOneByRecordId($this->requestData['recordId']);
 
-            if ($this->document !== null) {
-                $doc = AbstractDocument::getInstance($this->document->getLocation(), $this->settings, true);
-                if ($doc !== null) {
+            if ($this->document !== NULL) {
+                $doc = AbstractDocument::getInstance($this->document->getLocation(), $this->settings, TRUE);
+                if ($doc !== NULL) {
                     $this->document->setCurrentDocument($doc);
                 } else {
                     $this->logger->error('Failed to load document with record ID "' . $this->requestData['recordId'] . '"');
@@ -212,7 +212,7 @@ 
      */
     protected function isDocMissing(): bool
     {
-        return $this->document === null || $this->document->getCurrentDocument() === null;
+        return $this->document === NULL || $this->document->getCurrentDocument() === NULL;
     }
 
     /**
@@ -241,7 +241,7 @@ 
         if ($this->request->hasArgument($parameterName)) {
             return $this->request->getArgument($parameterName);
         }
-        return null;
+        return NULL;
     }
 
     /**
@@ -313,7 +313,7 @@ 
             if (isset($this->settings['multiViewType']) && $this->document->getCurrentDocument()->tableOfContents[0]['type'] === $this->settings['multiViewType']) {
                 $i = 0;
                 foreach ($this->documentArray as $document) {
-                    if ($document !== null) {
+                    if ($document !== NULL) {
                         $this->requestData['docPage'][$i] = MathUtility::forceIntegerInRange((int) $this->requestData['docPage'][$i], 1, $document->numPages, 1);
                         $i++;
                     }
@@ -424,8 +424,8 @@ 
         };
 
         // Safely get the next and previous page numbers
-        $nextPageNumber = isset($pages[$currentPageNumber + 1]) ? $pages[$currentPageNumber + 1]['startRecordNumber'] : null;
-        $previousPageNumber = isset($pages[$currentPageNumber - 1]) ? $pages[$currentPageNumber - 1]['startRecordNumber'] : null;
+        $nextPageNumber = isset($pages[$currentPageNumber + 1]) ? $pages[$currentPageNumber + 1]['startRecordNumber'] : NULL;
+        $previousPageNumber = isset($pages[$currentPageNumber - 1]) ? $pages[$currentPageNumber - 1]['startRecordNumber'] : NULL;
 
         // 'startRecordNumber' is not required in GridView, only the variant for each loop is required
         // 'endRecordNumber' is not required in both views
@@ -470,11 +470,11 @@ 
      */
     private function getDocumentByUid(int $documentId)
     {
-        $doc = null;
+        $doc = NULL;
         $this->document = $this->documentRepository->findOneByIdAndSettings($documentId);
 
         if ($this->document) {
-            $doc = AbstractDocument::getInstance($this->document->getLocation(), $this->settings, true);
+            $doc = AbstractDocument::getInstance($this->document->getLocation(), $this->settings, TRUE);
         } else {
             $this->logger->error('Invalid UID "' . $documentId . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
         }
@@ -493,13 +493,13 @@ 
      */
     protected function getDocumentByUrl(string $documentId)
     {
-        $doc = AbstractDocument::getInstance($documentId, $this->settings, true);
+        $doc = AbstractDocument::getInstance($documentId, $this->settings, TRUE);
 
         if (isset($this->settings['multiViewType']) && $doc->tableOfContents[0]['type'] === $this->settings['multiViewType']) {
             $childDocuments = $doc->tableOfContents[0]['children'];
             $i = 0;
             foreach ($childDocuments as $document) {
-                $this->documentArray[] = AbstractDocument::getInstance($document['points'], $this->settings, true);
+                $this->documentArray[] = AbstractDocument::getInstance($document['points'], $this->settings, TRUE);
                 if (!isset($this->requestData['docPage'][$i]) && isset(explode('#', $document['points'])[1])) {
                     $initPage = explode('#', $document['points'])[1];
                     $this->requestData['docPage'][$i] = $initPage;
@@ -512,21 +512,21 @@ 
         if ($this->requestData['multipleSource'] && is_array($this->requestData['multipleSource'])) {
             $i = 0;
             foreach ($this->requestData['multipleSource'] as $location) {
-                $document = AbstractDocument::getInstance($location, $this->settings, true);
-                if ($document !== null) {
+                $document = AbstractDocument::getInstance($location, $this->settings, TRUE);
+                if ($document !== NULL) {
                     $this->documentArray['extra_' . $i] = $document;
                 }
                 $i++;
             }
         }
 
-        if ($doc !== null) {
+        if ($doc !== NULL) {
             $this->document = GeneralUtility::makeInstance(Document::class);
 
             if ($doc->recordId) {
                 // find document from repository by recordId
                 $docFromRepository = $this->documentRepository->findOneByRecordId($doc->recordId);
-                if ($docFromRepository !== null) {
+                if ($docFromRepository !== NULL) {
                     $this->document = $docFromRepository;
                 }
             }

Spacing +10 added lines, -10 removed lines

@@ -158,11 +158,11 @@ 
                 if ($doc !== null) {
                     $this->document->setCurrentDocument($doc);
                 } else {
-                    $this->logger->error('Failed to load document with record ID "' . $this->requestData['recordId'] . '"');
+                    $this->logger->error('Failed to load document with record ID "'.$this->requestData['recordId'].'"');
                 }
             }
         } else {
-            $this->logger->error('Invalid ID "' . $documentId . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
+            $this->logger->error('Invalid ID "'.$documentId.'" or PID "'.$this->settings['storagePid'].'" for document loading');
         }
     }
 
@@ -259,7 +259,7 @@ 
             && !MathUtility::canBeInterpretedAsInteger($this->requestData['id'])
             && !GeneralUtility::isValidUrl($this->requestData['id'])
         ) {
-            $this->logger->warning('Invalid ID or URI "' . $this->requestData['id'] . '" for document loading');
+            $this->logger->warning('Invalid ID or URI "'.$this->requestData['id'].'" for document loading');
             unset($this->requestData['id']);
         }
 
@@ -319,7 +319,7 @@ 
     {
         if (empty($this->settings[$setting])) {
             $this->settings[$setting] = $value;
-            $this->logger->warning('Setting "' . $setting . '" not set, using default value "' . $value . '". Probably FlexForm for controller "' . get_class($this) . '" is not read.');
+            $this->logger->warning('Setting "'.$setting.'" not set, using default value "'.$value.'". Probably FlexForm for controller "'.get_class($this).'" is not read.');
         } else {
             $this->settings[$setting] = (int) $this->settings[$setting];
         }
@@ -404,7 +404,7 @@ 
         $pages = [];
         $pagesSect = [];
         $aRange = [];
-        $nRange = 5;    // ToDo: should be made configurable
+        $nRange = 5; // ToDo: should be made configurable
 
         // lower limit of the range
         $nBottom = $currentPageNumber - $nRange;
@@ -419,7 +419,7 @@ 
 
         // check whether the first screen page is > 1, if yes then points must be added
         if ($aRange[0] > 1) {
-            array_push($pagesSect, ['label' => '...','startRecordNumber' => '...']);
+            array_push($pagesSect, ['label' => '...', 'startRecordNumber' => '...']);
         };
         $lastStartRecordNumberGrid = 0; // due to validity outside the loop
         foreach (range($firstPage, $lastPage) as $i) {
@@ -462,7 +462,7 @@ 
 
                 // Check if screen page is in range
                 if (in_array($i, $aRange)) {
-                    array_push($pagesSect, ['label' => $i,'startRecordNumber' => $startRecordNumber]);
+                    array_push($pagesSect, ['label' => $i, 'startRecordNumber' => $startRecordNumber]);
                 };
             };
         };
@@ -525,7 +525,7 @@ 
         if ($this->document) {
             $doc = AbstractDocument::getInstance($this->document->getLocation(), $this->settings, true);
         } else {
-            $this->logger->error('Invalid UID "' . $documentId . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
+            $this->logger->error('Invalid UID "'.$documentId.'" or PID "'.$this->settings['storagePid'].'" for document loading');
         }
 
         return $doc;
@@ -563,7 +563,7 @@ 
             foreach ($this->requestData['multipleSource'] as $location) {
                 $document = AbstractDocument::getInstance($location, $this->settings, true);
                 if ($document !== null) {
-                    $this->documentArray['extra_' . $i] = $document;
+                    $this->documentArray['extra_'.$i] = $document;
                 }
                 $i++;
             }
@@ -587,7 +587,7 @@ 
 
             $this->document->setLocation($documentId);
         } else {
-            $this->logger->error('Invalid location given "' . $documentId . '" for document loading');
+            $this->logger->error('Invalid location given "'.$documentId.'" for document loading');
         }
 
         return $doc;