Erikmitk / kitodo-presentation

Tests/Functional/Api/OaiPmhTest.php

Spacing +9 added lines, -9 removed lines

@@ -51,15 +51,15 @@ 
     {
         parent::setUp();
 
-        $this->oaiUrl = $this->baseUrl . 'index.php?id=' . $this->oaiPage;
-        $this->oaiUrlNoStoragePid = $this->baseUrl . 'index.php?id=' . $this->oaiPageNoStoragePid;
+        $this->oaiUrl = $this->baseUrl.'index.php?id='.$this->oaiPage;
+        $this->oaiUrlNoStoragePid = $this->baseUrl.'index.php?id='.$this->oaiPageNoStoragePid;
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/documents_1.csv');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/metadata.csv');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/libraries.csv');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/pages.csv');
-        $this->importDataSet(__DIR__ . '/../../Fixtures/OaiPmh/pages.xml');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/OaiPmh/solrcores.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/documents_1.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/metadata.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/libraries.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/pages.csv');
+        $this->importDataSet(__DIR__.'/../../Fixtures/OaiPmh/pages.xml');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/OaiPmh/solrcores.csv');
 
         $this->solrCoreRepository = $this->initializeRepository(SolrCoreRepository::class, 20000);
 
@@ -75,7 +75,7 @@ 
             $coreName = Solr::createCore();
             $solr = Solr::getInstance($coreName);
 
-            $this->importSolrDocuments($solr, __DIR__ . '/../../Fixtures/Common/documents_1.solr.json');
+            $this->importSolrDocuments($solr, __DIR__.'/../../Fixtures/Common/documents_1.solr.json');
         }
 
         $oaiCoreModel = $this->solrCoreRepository->findByUid(11001);

Braces +14 added lines, -28 removed lines

@@ -21,8 +21,7 @@ 
 use Phpoaipmh\Exception\OaipmhException;
 use SimpleXMLElement;
 
-class OaiPmhTest extends FunctionalTestCase
-{
+class OaiPmhTest extends FunctionalTestCase {
     protected $disableJsonWrappedResponse = true;
 
     protected $coreExtensionsToLoad = [
@@ -66,8 +65,7 @@ 
         $this->setUpOaiSolr();
     }
 
-    protected function setUpOaiSolr()
-    {
+    protected function setUpOaiSolr() {
         // Setup Solr only once for all tests in this suite
         static $solr = null;
 
@@ -87,8 +85,7 @@ 
     /**
      * @test
      */
-    public function correctlyRespondsOnBadVerb()
-    {
+    public function correctlyRespondsOnBadVerb() {
         $client = new HttpClient();
         $response = $client->get($this->baseUrl, [
             'query' => [
@@ -113,8 +110,7 @@ 
     /**
      * @test
      */
-    public function canIdentify()
-    {
+    public function canIdentify() {
         $oai = Endpoint::build($this->oaiUrl);
         $identity = $oai->identify();
 
@@ -127,8 +123,7 @@ 
     /**
      * @test
      */
-    public function identifyGivesFallbackDatestampWhenNoDocuments()
-    {
+    public function identifyGivesFallbackDatestampWhenNoDocuments() {
         $oai = Endpoint::build($this->oaiUrlNoStoragePid);
         $identity = $oai->identify();
 
@@ -138,8 +133,7 @@ 
     /**
      * @test
      */
-    public function canListMetadataFormats()
-    {
+    public function canListMetadataFormats() {
         $oai = Endpoint::build($this->oaiUrl);
         $formats = $oai->listMetadataFormats();
 
@@ -154,8 +148,7 @@ 
     /**
      * @test
      */
-    public function canListRecords()
-    {
+    public function canListRecords() {
         $oai = Endpoint::build($this->oaiUrl);
         $result = $oai->listRecords('mets');
 
@@ -168,8 +161,7 @@ 
     /**
      * @test
      */
-    public function noRecordsUntil1900()
-    {
+    public function noRecordsUntil1900() {
         $this->expectException(OaipmhException::class);
         $this->expectExceptionMessage('empty list');
 
@@ -182,8 +174,7 @@ 
     /**
      * @test
      */
-    public function canUseResumptionToken()
-    {
+    public function canUseResumptionToken() {
         // NOTE: cursor and expirationDate are optional by the specification,
         //       but we include them in our implementation
 
@@ -241,8 +232,7 @@ 
     /**
      * @test
      */
-    public function noResumptionTokenForCompleteList()
-    {
+    public function noResumptionTokenForCompleteList() {
         $client = new HttpClient();
 
         foreach (['ListIdentifiers', 'ListRecords'] as $verb) {
@@ -264,8 +254,7 @@ 
     /**
      * @test
      */
-    public function canListAndResumeIdentifiers()
-    {
+    public function canListAndResumeIdentifiers() {
         $oai = Endpoint::build($this->oaiUrl);
         $result = $oai->listIdentifiers('mets');
 
@@ -278,18 +267,15 @@ 
         self::assertEquals('oai:de:slub-dresden:db:id-476248086', $record->identifier);
     }
 
-    protected function parseUtc(string $dateTime)
-    {
+    protected function parseUtc(string $dateTime) {
         return DateTime::createFromFormat('Y-m-d\TH:i:s\Z', $dateTime);
     }
 
-    protected function assertUtcDateString(string $dateTime)
-    {
+    protected function assertUtcDateString(string $dateTime) {
         self::assertInstanceOf(DateTime::class, $this->parseUtc($dateTime));
     }
 
-    protected function assertInFuture(string $dateTime)
-    {
+    protected function assertInFuture(string $dateTime) {
         self::assertGreaterThan(new DateTime(), $this->parseUtc($dateTime));
     }
 }

Tests/Functional/ViewHelpers/JsFooterViewHelperTest.php

Braces +1 added lines, -2 removed lines

@@ -20,8 +20,7 @@
 /**
  * @covers JsFooterViewHelper
  */
-class JsFooterViewHelperTest extends FunctionalTestCase
-{
+class JsFooterViewHelperTest extends FunctionalTestCase {
     /**
      * @var bool Speed up this test case, it needs no database
      */

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     /**
      * @var bool Speed up this test case, it needs no database
      */
-    protected $initializeDatabase = false;
+    protected $initializeDatabase = FALSE;
 
     /**
      * @test

Tests/Functional/ViewHelpers/MetadataWrapVariableViewHelperTest.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 
         $view->assign(
             'configObject',
-            [ 'wrap' => 'all.wrap = <article class="shlb-metadata-text-item metadata-title">|</article>
+            ['wrap' => 'all.wrap = <article class="shlb-metadata-text-item metadata-title">|</article>
                  key.wrap = <label>|</label>
                  value.required = 1
                  value.wrap = <li>|</li>'

Braces +1 added lines, -2 removed lines

@@ -18,8 +18,7 @@
 /**
  * @covers MetadataWrapVariableViewHelper
  */
-class MetadataWrapVariableViewHelperTest extends FunctionalTestCase
-{
+class MetadataWrapVariableViewHelperTest extends FunctionalTestCase {
     /**
      * @var bool Speed up this test case, it needs no database
      */

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     /**
      * @var bool Speed up this test case, it needs no database
      */
-    protected $initializeDatabase = false;
+    protected $initializeDatabase = FALSE;
 
     /**
      * @test

Tests/Functional/ViewHelpers/StdWrapViewHelperTest.php

Braces +1 added lines, -2 removed lines

@@ -18,8 +18,7 @@
 /**
  * @covers StdWrapViewHelper
  */
-class StdWrapViewHelperTest extends FunctionalTestCase
-{
+class StdWrapViewHelperTest extends FunctionalTestCase {
     /**
      * @var bool Speed up this test case, it needs no database
      */

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     /**
      * @var bool Speed up this test case, it needs no database
      */
-    protected $initializeDatabase = false;
+    protected $initializeDatabase = FALSE;
 
     /**
      * @test

Tests/Functional/Common/HelperTest.php

Spacing +2 added lines, -2 removed lines

@@ -21,8 +21,8 @@
     {
         parent::setUp();
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/libraries.csv');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/metadata.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/libraries.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/metadata.csv');
     }
 
     /**

Braces +4 added lines, -8 removed lines

@@ -15,8 +15,7 @@ 
 use Kitodo\Dlf\Common\Helper;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class HelperTest extends FunctionalTestCase
-{
+class HelperTest extends FunctionalTestCase {
     public function setUp(): void
     {
         parent::setUp();
@@ -28,8 +27,7 @@ 
     /**
      * @test
      */
-    public function canGetIndexNameFromUid()
-    {
+    public function canGetIndexNameFromUid() {
         // Repeat to make sure caching isn't broken
         for ($n = 0; $n < 2; $n++) {
             // Good UID, no PID
@@ -78,8 +76,7 @@ 
      * @test
      * @group getLanguageName
      */
-    public function canTranslateLanguageNameToEnglish()
-    {
+    public function canTranslateLanguageNameToEnglish() {
         // NOTE: This only tests in BE mode
 
         $this->initLanguageService('default');
@@ -93,8 +90,7 @@ 
      * @test
      * @group getLanguageName
      */
-    public function canTranslateLanguageNameToGerman()
-    {
+    public function canTranslateLanguageNameToGerman() {
         // NOTE: This only tests in BE mode
 
         $this->initLanguageService('de');

Tests/Functional/Common/IiifUrlReaderTest.php

Braces +2 added lines, -4 removed lines

@@ -15,14 +15,12 @@
 use Kitodo\Dlf\Common\IiifUrlReader;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class IiifUrlReaderTest extends FunctionalTestCase
-{
+class IiifUrlReaderTest extends FunctionalTestCase {
     /**
      * @test
      * @group getContent
      */
-    public function getContentCheck()
-    {
+    public function getContentCheck() {
         $iiifUrlReader = new IiifUrlReader();
 
         $correctUrl = 'http://web:8001/Tests/Fixtures/Common/correct.txt';

Tests/Functional/Common/SolrSearchTest.php

Spacing +2 added lines, -2 removed lines

@@ -21,11 +21,11 @@
 class SolrSearchTest extends FunctionalTestCase
 {
     private static array $databaseFixtures = [
-        __DIR__ . '/../../Fixtures/Common/solrcores.csv'
+        __DIR__.'/../../Fixtures/Common/solrcores.csv'
     ];
 
     private static array $solrFixtures = [
-        __DIR__ . '/../../Fixtures/Common/documents_1.solr.json'
+        __DIR__.'/../../Fixtures/Common/documents_1.solr.json'
     ];
 
     private Solr $solr;

Braces +3 added lines, -6 removed lines

@@ -18,8 +18,7 @@ 
 use Kitodo\Dlf\Domain\Repository\SolrCoreRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class SolrSearchTest extends FunctionalTestCase
-{
+class SolrSearchTest extends FunctionalTestCase {
     private static array $databaseFixtures = [
         __DIR__ . '/../../Fixtures/Common/solrcores.csv'
     ];
@@ -41,8 +40,7 @@ 
     /**
      * @test
      */
-    public function canPrepareAndSubmit()
-    {
+    public function canPrepareAndSubmit() {
         $documentRepository = $this->initializeRepository(DocumentRepository::class, 0);
         $solrCoreName = $this->solrCoreRepository->findByUid(5)->getIndexName();
         $settings = ['solrcore' => $solrCoreName, 'storagePid' => 0];
@@ -80,8 +78,7 @@ 
         $this->initializeRepository(DocumentRepository::class, 0);
     }
 
-    protected function setUpSolr($uid, $storagePid, $solrFixtures)
-    {
+    protected function setUpSolr($uid, $storagePid, $solrFixtures) {
         $this->solrCoreRepository = $this->initializeRepository(SolrCoreRepository::class, $storagePid);
 
         // Setup Solr only once for all tests in this suite

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -51,21 +51,21 @@ 
         $this->assertCount(33, $resultSet);
 
         $params1 = ['query' => '*'];
-        $search = new SolrSearch($documentRepository, null, $settings, $params1);
+        $search = new SolrSearch($documentRepository, NULL, $settings, $params1);
         $search->prepare();
         $this->assertEquals(33, $search->getNumFound());
         $this->assertEquals(3, $search->getSolrResults()['numberOfToplevels']);
         $this->assertCount(15, $search->getSolrResults()['documents']);
 
         $params2 = ['query' => '10 Keyboard pieces'];
-        $search2 = new SolrSearch($documentRepository, null, $settings, $params2);
+        $search2 = new SolrSearch($documentRepository, NULL, $settings, $params2);
         $search2->prepare();
         $this->assertEquals(1, $search2->getNumFound());
         $this->assertEquals(1, $search2->getSolrResults()['numberOfToplevels']);
         $this->assertCount(1, $search2->getSolrResults()['documents']);
 
         $params3 = ['query' => 'foobar'];
-        $search3 = new SolrSearch($documentRepository, null, $settings, $params3);
+        $search3 = new SolrSearch($documentRepository, NULL, $settings, $params3);
         $search3->prepare();
         $this->assertEquals(0, $search3->getNumFound());
         $this->assertEquals(0, $search3->getSolrResults()['numberOfToplevels']);
@@ -85,9 +85,9 @@ 
         $this->solrCoreRepository = $this->initializeRepository(SolrCoreRepository::class, $storagePid);
 
         // Setup Solr only once for all tests in this suite
-        static $solr = null;
+        static $solr = NULL;
 
-        if ($solr === null) {
+        if ($solr === NULL) {
             $coreName = Solr::createCore();
             $solr = Solr::getInstance($coreName);
             foreach ($solrFixtures as $filePath) {

Tests/Functional/Common/SolrIndexingTest.php

Spacing +6 added lines, -6 removed lines

@@ -45,9 +45,9 @@ 
         $this->documentRepository = $this->initializeRepository(DocumentRepository::class, 20000);
         $this->solrCoreRepository = $this->initializeRepository(SolrCoreRepository::class, 20000);
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/documents_1.csv');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/libraries.csv');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/metadata.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/documents_1.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/libraries.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/metadata.csv');
     }
 
     /**
@@ -128,9 +128,9 @@ 
     {
         $core = $this->createSolrCore();
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/documents_fulltext.csv');
-        $this->importSolrDocuments($core->solr, __DIR__ . '/../../Fixtures/Common/documents_1.solr.json');
-        $this->importSolrDocuments($core->solr, __DIR__ . '/../../Fixtures/Common/documents_fulltext.solr.json');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/documents_fulltext.csv');
+        $this->importSolrDocuments($core->solr, __DIR__.'/../../Fixtures/Common/documents_1.solr.json');
+        $this->importSolrDocuments($core->solr, __DIR__.'/../../Fixtures/Common/documents_fulltext.solr.json');
 
         $collections = $this->collectionRepository->findCollectionsBySettings([
             'index_name' => ['Musik', 'Projekt: Dresdner Hefte'],

Braces +5 added lines, -10 removed lines

@@ -23,8 +23,7 @@ 
 use TYPO3\CMS\Core\Core\Bootstrap;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
-class SolrIndexingTest extends FunctionalTestCase
-{
+class SolrIndexingTest extends FunctionalTestCase {
     /** @var CollectionRepository */
     protected $collectionRepository;
 
@@ -53,8 +52,7 @@ 
     /**
      * @test
      */
-    public function canCreateCore()
-    {
+    public function canCreateCore() {
         $coreName = uniqid('testCore');
         $solr = Solr::getInstance($coreName);
         self::assertNull($solr->core);
@@ -69,8 +67,7 @@ 
     /**
      * @test
      */
-    public function canIndexAndSearchDocument()
-    {
+    public function canIndexAndSearchDocument() {
         $core = $this->createSolrCore();
 
         $document = $this->documentRepository->findByUid(1001);
@@ -124,8 +121,7 @@ 
     /**
      * @test
      */
-    public function canSearchInCollections()
-    {
+    public function canSearchInCollections() {
         $core = $this->createSolrCore();
 
         $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/documents_fulltext.csv');
@@ -165,8 +161,7 @@ 
     /**
      * @test
      */
-    public function canGetIndexFieldName()
-    {
+    public function canGetIndexFieldName() {
         $this->assertEquals('title_usi', Indexer::getIndexFieldName('title', 20000));
         $this->assertEquals('year_uuu', Indexer::getIndexFieldName('year', 20000));
         $this->assertEquals('', Indexer::getIndexFieldName('title'));

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -94,11 +94,11 @@
         self::assertEquals(15, $solrSearch->getNumFound());
 
         // Check that the title stored in Solr matches the title of database entry
-        $docTitleInSolr = false;
+        $docTitleInSolr = FALSE;
         foreach ($solrSearch->getSolrResults()['documents'] as $solrDoc) {
             if ($solrDoc['toplevel'] && intval($solrDoc['uid']) === intval($document->getUid())) {
                 self::assertEquals($document->getTitle(), $solrDoc['title']);
-                $docTitleInSolr = true;
+                $docTitleInSolr = TRUE;
                 break;
             }
         }

Tests/Functional/Common/SolrSearchQueryTest.php

Spacing +4 added lines, -4 removed lines

@@ -23,13 +23,13 @@
     private $solrCoreRepository;
 
     private static array $databaseFixtures = [
-        __DIR__ . '/../../Fixtures/Common/documents_1.csv',
-        __DIR__ . '/../../Fixtures/Common/pages.csv',
-        __DIR__ . '/../../Fixtures/Common/solrcores.csv'
+        __DIR__.'/../../Fixtures/Common/documents_1.csv',
+        __DIR__.'/../../Fixtures/Common/pages.csv',
+        __DIR__.'/../../Fixtures/Common/solrcores.csv'
     ];
 
     private static array $solrFixtures = [
-        __DIR__ . '/../../Fixtures/Common/documents_1.solr.json'
+        __DIR__.'/../../Fixtures/Common/documents_1.solr.json'
     ];
 
     public function setUp(): void

Braces +3 added lines, -6 removed lines

@@ -18,8 +18,7 @@ 
 use Kitodo\Dlf\Domain\Repository\SolrCoreRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class SolrSearchQueryTest extends FunctionalTestCase
-{
+class SolrSearchQueryTest extends FunctionalTestCase {
     private $solrCoreRepository;
 
     private static array $databaseFixtures = [
@@ -43,8 +42,7 @@ 
      * @test
      * @ignore
      */
-    public function canExecute()
-    {
+    public function canExecute() {
         $documentRepository = $this->initializeRepository(DocumentRepository::class, 0);
         $settings = ['solrcore' => 4, 'storagePid' => 0];
 
@@ -68,8 +66,7 @@ 
         $this->initializeRepository(DocumentRepository::class, 0);
     }
 
-    protected function setUpSolr($uid, $storagePid, $solrFixtures)
-    {
+    protected function setUpSolr($uid, $storagePid, $solrFixtures) {
         $this->solrCoreRepository = $this->initializeRepository(SolrCoreRepository::class, $storagePid);
 
         // Setup Solr only once for all tests in this suite

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -73,9 +73,9 @@
         $this->solrCoreRepository = $this->initializeRepository(SolrCoreRepository::class, $storagePid);
 
         // Setup Solr only once for all tests in this suite
-        static $solr = null;
+        static $solr = NULL;
 
-        if ($solr === null) {
+        if ($solr === NULL) {
             $coreName = Solr::createCore();
             $solr = Solr::getInstance($coreName);
             foreach ($solrFixtures as $filePath) {