Erikmitk / kitodo-presentation

Tests/Functional/Repository/CollectionRepositoryTest.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
             20000
         );
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Repository/collections.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Repository/collections.csv');
     }
 
     /**

Braces +1 added lines, -2 removed lines

@@ -16,8 +16,7 @@
 use Kitodo\Dlf\Domain\Repository\CollectionRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class CollectionRepositoryTest extends FunctionalTestCase
-{
+class CollectionRepositoryTest extends FunctionalTestCase {
     /**
      * @var CollectionRepository
      */

Upper-Lower-Casing +13 added lines, -13 removed lines

@@ -107,14 +107,14 @@ 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
                 'index_name' => ['Geschichte', 'collection-with-single-document'],
-                'show_userdefined' => true
+                'show_userdefined' => TRUE
             ]
         );
         self::assertCount(2, $collectionsByLabel);
         self::assertArrayHasKey('Geschichte', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
 
-        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => true]);
+        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => TRUE]);
         self::assertCount(4, $collectionsByLabel);
         self::assertArrayHasKey('Musik', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
@@ -125,20 +125,20 @@ 
             implode(', ', array_keys($collectionsByLabel))
         );
 
-        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => false]);
+        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => FALSE]);
         self::assertCount(2, $collectionsByLabel);
         self::assertArrayHasKey('Musik', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
 
-        $collectionsByLabel = $this->findCollectionsBySettings(['hideEmptyOaiNames' => true]);
+        $collectionsByLabel = $this->findCollectionsBySettings(['hideEmptyOaiNames' => TRUE]);
         self::assertCount(2, $collectionsByLabel);
         self::assertArrayHasKey('Musik', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
-                'hideEmptyOaiNames' => true,
-                'show_userdefined' => true
+                'hideEmptyOaiNames' => TRUE,
+                'show_userdefined' => TRUE
             ]
         );
         self::assertCount(3, $collectionsByLabel);
@@ -148,8 +148,8 @@ 
 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
-                'hideEmptyOaiNames' => false,
-                'show_userdefined' => true
+                'hideEmptyOaiNames' => FALSE,
+                'show_userdefined' => TRUE
             ]
         );
         self::assertCount(4, $collectionsByLabel);
@@ -161,8 +161,8 @@ 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
                 'collections' => '1101, 1102, 1103, 1104',
-                'show_userdefined' => true,
-                'hideEmptyOaiNames' => false,
+                'show_userdefined' => TRUE,
+                'hideEmptyOaiNames' => FALSE,
                 'index_name' => ['Geschichte', 'collection-with-single-document']
             ]
         );
@@ -179,7 +179,7 @@ 
     public function canGetIndexNameForSolr(): void
     {
         $indexName = $this->collectionRepository->getIndexNameForSolr(
-            ['show_userdefined' => true, 'storagePid' => '20000'], 'history'
+            ['show_userdefined' => TRUE, 'storagePid' => '20000'], 'history'
         );
         $result = $indexName->fetchAllAssociative();
         self::assertEquals(1, $indexName->rowCount());
@@ -188,12 +188,12 @@ 
         self::assertEquals('1103', $result[0]['uid']);
 
         $indexName = $this->collectionRepository->getIndexNameForSolr(
-            ['show_userdefined' => false, 'storagePid' => '20000'], 'history'
+            ['show_userdefined' => FALSE, 'storagePid' => '20000'], 'history'
         );
         self::assertEquals(0, $indexName->rowCount());
 
         $indexName = $this->collectionRepository->getIndexNameForSolr(
-            ['show_userdefined' => false, 'storagePid' => '20000'], 'collection-with-single-document'
+            ['show_userdefined' => FALSE, 'storagePid' => '20000'], 'collection-with-single-document'
         );
         self::assertEquals(1, $indexName->rowCount());
         self::assertEquals('collection-with-single-document', $indexName->fetchOne());

Tests/Functional/Repository/MailRepositoryTest.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
             20000
         );
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Repository/mail.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Repository/mail.csv');
     }
 
     /**

Braces +1 added lines, -2 removed lines

@@ -16,8 +16,7 @@
 use Kitodo\Dlf\Domain\Repository\MailRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class MailRepositoryTest extends FunctionalTestCase
-{
+class MailRepositoryTest extends FunctionalTestCase {
     /**
      * @var MailRepository
      */

Tests/Functional/Repository/MetatdataRepositoryTest.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
             20000
         );
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Repository/metadata.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Repository/metadata.csv');
     }
 
 

Braces +2 added lines, -4 removed lines

@@ -16,8 +16,7 @@ 
 use Kitodo\Dlf\Domain\Repository\MetadataRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class MetadataRepositoryTest extends FunctionalTestCase
-{
+class MetadataRepositoryTest extends FunctionalTestCase {
     /**
      * @var MetadataRepository
      */
@@ -40,8 +39,7 @@ 
      * @param $settings
      * @return array
      */
-    protected function findBySettings($settings)
-    {
+    protected function findBySettings($settings) {
         $metadata = $this->metadataRepository->findBySettings($settings);
         self::assertNotNull($metadata);
         self::assertInstanceOf(QueryResult::class, $metadata);

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -67,14 +67,14 @@ 
             implode(', ', array_keys($metadataByLabel))
         );
 
-        $metadataByLabel = $this->findBySettings(['is_listed' => true]);
+        $metadataByLabel = $this->findBySettings(['is_listed' => TRUE]);
         self::assertCount(3, $metadataByLabel);
         self::assertEquals(
             'Autor, Institution, Titel',
             implode(', ', array_keys($metadataByLabel))
         );
 
-        $metadataByLabel = $this->findBySettings(['is_sortable' => true]);
+        $metadataByLabel = $this->findBySettings(['is_sortable' => TRUE]);
         self::assertCount(4, $metadataByLabel);
         self::assertEquals(
             'Ort, Untertitel, Autor, Titel',
@@ -83,8 +83,8 @@ 
 
         $metadataByLabel = $this->findBySettings(
             [
-                'is_sortable' => true,
-                'is_listed' => true
+                'is_sortable' => TRUE,
+                'is_listed' => TRUE
             ]
         );
         self::assertCount(2, $metadataByLabel);

Tests/Functional/Api/PageViewProxyTest.php

Spacing +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
         ]);
 
         self::assertEquals(200, $response->getStatusCode());
-        self::assertEquals('This is some plain text test file.' . "\n", (string) $response->getBody());
+        self::assertEquals('This is some plain text test file.'."\n", (string) $response->getBody());
     }
 
     /**

Braces +3 added lines, -6 removed lines

@@ -15,12 +15,10 @@ 
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
-class PageViewProxyTest extends FunctionalTestCase
-{
+class PageViewProxyTest extends FunctionalTestCase {
     protected $disableJsonWrappedResponse = true;
 
-    protected function getDlfConfiguration()
-    {
+    protected function getDlfConfiguration() {
         return array_merge(parent::getDlfConfiguration(), [
             'general' => [
                 'enableInternalProxy' => true
@@ -28,8 +26,7 @@ 
         ]);
     }
 
-    protected function queryProxy(array $query, string $method = 'GET')
-    {
+    protected function queryProxy(array $query, string $method = 'GET') {
         $query['eID'] = 'tx_dlf_pageview_proxy';
 
         return $this->httpClient->request($method, '', [

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -17,13 +17,13 @@
 
 class PageViewProxyTest extends FunctionalTestCase
 {
-    protected $disableJsonWrappedResponse = true;
+    protected $disableJsonWrappedResponse = TRUE;
 
     protected function getDlfConfiguration()
     {
         return array_merge(parent::getDlfConfiguration(), [
             'general' => [
-                'enableInternalProxy' => true
+                'enableInternalProxy' => TRUE
             ]
         ]);
     }

Tests/Functional/ViewHelpers/JsFooterViewHelperTest.php

Braces +1 added lines, -2 removed lines

@@ -20,8 +20,7 @@
 /**
  * @covers JsFooterViewHelper
  */
-class JsFooterViewHelperTest extends FunctionalTestCase
-{
+class JsFooterViewHelperTest extends FunctionalTestCase {
     /**
      * @var bool Speed up this test case, it needs no database
      */

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     /**
      * @var bool Speed up this test case, it needs no database
      */
-    protected $initializeDatabase = false;
+    protected $initializeDatabase = FALSE;
 
     /**
      * @test

Tests/Functional/ViewHelpers/MetadataWrapVariableViewHelperTest.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 
         $view->assign(
             'configObject',
-            [ 'wrap' => 'all.wrap = <article class="shlb-metadata-text-item metadata-title">|</article>
+            ['wrap' => 'all.wrap = <article class="shlb-metadata-text-item metadata-title">|</article>
                  key.wrap = <label>|</label>
                  value.required = 1
                  value.wrap = <li>|</li>'

Braces +1 added lines, -2 removed lines

@@ -18,8 +18,7 @@
 /**
  * @covers MetadataWrapVariableViewHelper
  */
-class MetadataWrapVariableViewHelperTest extends FunctionalTestCase
-{
+class MetadataWrapVariableViewHelperTest extends FunctionalTestCase {
     /**
      * @var bool Speed up this test case, it needs no database
      */

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     /**
      * @var bool Speed up this test case, it needs no database
      */
-    protected $initializeDatabase = false;
+    protected $initializeDatabase = FALSE;
 
     /**
      * @test

Tests/Functional/ViewHelpers/StdWrapViewHelperTest.php

Braces +1 added lines, -2 removed lines

@@ -18,8 +18,7 @@
 /**
  * @covers StdWrapViewHelper
  */
-class StdWrapViewHelperTest extends FunctionalTestCase
-{
+class StdWrapViewHelperTest extends FunctionalTestCase {
     /**
      * @var bool Speed up this test case, it needs no database
      */

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     /**
      * @var bool Speed up this test case, it needs no database
      */
-    protected $initializeDatabase = false;
+    protected $initializeDatabase = FALSE;
 
     /**
      * @test

Tests/Functional/Common/HelperTest.php

Spacing +2 added lines, -2 removed lines

@@ -21,8 +21,8 @@
     {
         parent::setUp();
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/libraries.csv');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/metadata.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/libraries.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/metadata.csv');
     }
 
     /**

Braces +4 added lines, -8 removed lines

@@ -15,8 +15,7 @@ 
 use Kitodo\Dlf\Common\Helper;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class HelperTest extends FunctionalTestCase
-{
+class HelperTest extends FunctionalTestCase {
     public function setUp(): void
     {
         parent::setUp();
@@ -28,8 +27,7 @@ 
     /**
      * @test
      */
-    public function canGetIndexNameFromUid()
-    {
+    public function canGetIndexNameFromUid() {
         // Repeat to make sure caching isn't broken
         for ($n = 0; $n < 2; $n++) {
             // Good UID, no PID
@@ -78,8 +76,7 @@ 
      * @test
      * @group getLanguageName
      */
-    public function canTranslateLanguageNameToEnglish()
-    {
+    public function canTranslateLanguageNameToEnglish() {
         // NOTE: This only tests in BE mode
 
         $this->initLanguageService('default');
@@ -93,8 +90,7 @@ 
      * @test
      * @group getLanguageName
      */
-    public function canTranslateLanguageNameToGerman()
-    {
+    public function canTranslateLanguageNameToGerman() {
         // NOTE: This only tests in BE mode
 
         $this->initLanguageService('de');

Tests/Functional/Common/IiifUrlReaderTest.php

Braces +2 added lines, -4 removed lines

@@ -15,14 +15,12 @@
 use Kitodo\Dlf\Common\IiifUrlReader;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class IiifUrlReaderTest extends FunctionalTestCase
-{
+class IiifUrlReaderTest extends FunctionalTestCase {
     /**
      * @test
      * @group getContent
      */
-    public function getContentCheck()
-    {
+    public function getContentCheck() {
         $iiifUrlReader = new IiifUrlReader();
 
         $correctUrl = 'http://web:8001/Tests/Fixtures/Common/correct.txt';