Erikmitk / kitodo-presentation

Tests/Unit/Common/HelperTest.php

Braces +2 added lines, -4 removed lines

@@ -15,10 +15,8 @@
 use Kitodo\Dlf\Common\Helper;
 use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
-class HelperTest extends UnitTestCase
-{
-    public function assertInvalidXml($xml)
-    {
+class HelperTest extends UnitTestCase {
+    public function assertInvalidXml($xml) {
         $result = Helper::getXmlFileAsString($xml);
         self::assertEquals(false, $result);
     }

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -20,7 +20,7 @@ 
     public function assertInvalidXml($xml)
     {
         $result = Helper::getXmlFileAsString($xml);
-        self::assertEquals(false, $result);
+        self::assertEquals(FALSE, $result);
     }
 
     /**
@@ -29,8 +29,8 @@ 
      */
     public function invalidXmlYieldsFalse(): void
     {
-        self::assertInvalidXml(false);
-        self::assertInvalidXml(null);
+        self::assertInvalidXml(FALSE);
+        self::assertInvalidXml(NULL);
         self::assertInvalidXml(1);
         self::assertInvalidXml([]);
         self::assertInvalidXml(new \stdClass());
@@ -50,7 +50,7 @@ 
 <root>
     <single />
 </root>
-XML;
+xml;
         $node = Helper::getXmlFileAsString($xml);
         self::assertIsObject($node);
         self::assertEquals('root', $node->getName());

Tests/Functional/Repository/TokenRepositoryTest.php

Spacing +3 added lines, -3 removed lines

@@ -36,7 +36,7 @@ 
     {
         parent::tearDown();
 
-        unlink(__DIR__ . '/../../Fixtures/Repository/tokenTemp.csv');
+        unlink(__DIR__.'/../../Fixtures/Repository/tokenTemp.csv');
     }
 
     /**
@@ -45,8 +45,8 @@ 
      */
     public function deleteExpiredTokens(): void
     {
-        $inputCsvFile = __DIR__ . '/../../Fixtures/Repository/token.csv';
-        $outputCsvFile = __DIR__ . '/../../Fixtures/Repository/tokenTemp.csv';
+        $inputCsvFile = __DIR__.'/../../Fixtures/Repository/token.csv';
+        $outputCsvFile = __DIR__.'/../../Fixtures/Repository/tokenTemp.csv';
 
         $inputCsvData = file_get_contents($inputCsvFile);
         $csvData = str_getcsv($inputCsvData, "\n");

Braces +1 added lines, -2 removed lines

@@ -15,8 +15,7 @@
 use Kitodo\Dlf\Domain\Repository\TokenRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class TokenRepositoryTest extends FunctionalTestCase
-{
+class TokenRepositoryTest extends FunctionalTestCase {
     /**
      * @var TokenRepository
      */

Tests/Functional/Repository/CollectionRepositoryTest.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
             20000
         );
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Repository/collections.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Repository/collections.csv');
     }
 
     /**

Braces +1 added lines, -2 removed lines

@@ -16,8 +16,7 @@
 use Kitodo\Dlf\Domain\Repository\CollectionRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class CollectionRepositoryTest extends FunctionalTestCase
-{
+class CollectionRepositoryTest extends FunctionalTestCase {
     /**
      * @var CollectionRepository
      */

Upper-Lower-Casing +13 added lines, -13 removed lines

@@ -107,14 +107,14 @@ 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
                 'index_name' => ['Geschichte', 'collection-with-single-document'],
-                'show_userdefined' => true
+                'show_userdefined' => TRUE
             ]
         );
         self::assertCount(2, $collectionsByLabel);
         self::assertArrayHasKey('Geschichte', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
 
-        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => true]);
+        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => TRUE]);
         self::assertCount(4, $collectionsByLabel);
         self::assertArrayHasKey('Musik', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
@@ -125,20 +125,20 @@ 
             implode(', ', array_keys($collectionsByLabel))
         );
 
-        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => false]);
+        $collectionsByLabel = $this->findCollectionsBySettings(['show_userdefined' => FALSE]);
         self::assertCount(2, $collectionsByLabel);
         self::assertArrayHasKey('Musik', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
 
-        $collectionsByLabel = $this->findCollectionsBySettings(['hideEmptyOaiNames' => true]);
+        $collectionsByLabel = $this->findCollectionsBySettings(['hideEmptyOaiNames' => TRUE]);
         self::assertCount(2, $collectionsByLabel);
         self::assertArrayHasKey('Musik', $collectionsByLabel);
         self::assertArrayHasKey('Collection with single document', $collectionsByLabel);
 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
-                'hideEmptyOaiNames' => true,
-                'show_userdefined' => true
+                'hideEmptyOaiNames' => TRUE,
+                'show_userdefined' => TRUE
             ]
         );
         self::assertCount(3, $collectionsByLabel);
@@ -148,8 +148,8 @@ 
 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
-                'hideEmptyOaiNames' => false,
-                'show_userdefined' => true
+                'hideEmptyOaiNames' => FALSE,
+                'show_userdefined' => TRUE
             ]
         );
         self::assertCount(4, $collectionsByLabel);
@@ -161,8 +161,8 @@ 
         $collectionsByLabel = $this->findCollectionsBySettings(
             [
                 'collections' => '1101, 1102, 1103, 1104',
-                'show_userdefined' => true,
-                'hideEmptyOaiNames' => false,
+                'show_userdefined' => TRUE,
+                'hideEmptyOaiNames' => FALSE,
                 'index_name' => ['Geschichte', 'collection-with-single-document']
             ]
         );
@@ -179,7 +179,7 @@ 
     public function canGetIndexNameForSolr(): void
     {
         $indexName = $this->collectionRepository->getIndexNameForSolr(
-            ['show_userdefined' => true, 'storagePid' => '20000'], 'history'
+            ['show_userdefined' => TRUE, 'storagePid' => '20000'], 'history'
         );
         $result = $indexName->fetchAllAssociative();
         self::assertEquals(1, $indexName->rowCount());
@@ -188,12 +188,12 @@ 
         self::assertEquals('1103', $result[0]['uid']);
 
         $indexName = $this->collectionRepository->getIndexNameForSolr(
-            ['show_userdefined' => false, 'storagePid' => '20000'], 'history'
+            ['show_userdefined' => FALSE, 'storagePid' => '20000'], 'history'
         );
         self::assertEquals(0, $indexName->rowCount());
 
         $indexName = $this->collectionRepository->getIndexNameForSolr(
-            ['show_userdefined' => false, 'storagePid' => '20000'], 'collection-with-single-document'
+            ['show_userdefined' => FALSE, 'storagePid' => '20000'], 'collection-with-single-document'
         );
         self::assertEquals(1, $indexName->rowCount());
         self::assertEquals('collection-with-single-document', $indexName->fetchOne());

Tests/Functional/Repository/DocumentRepositoryTest.php

Spacing +3 added lines, -3 removed lines

@@ -31,9 +31,9 @@
 
         $this->documentRepository = $this->initializeRepository(DocumentRepository::class, 20000);
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/documents_1.csv');
-        $this->importDataSet(__DIR__ . '/../../Fixtures/Common/pages.xml');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/libraries.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/documents_1.csv');
+        $this->importDataSet(__DIR__.'/../../Fixtures/Common/pages.xml');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/libraries.csv');
     }
 
     /**

Tests/Functional/Repository/MailRepositoryTest.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
             20000
         );
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Repository/mail.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Repository/mail.csv');
     }
 
     /**

Braces +1 added lines, -2 removed lines

@@ -16,8 +16,7 @@
 use Kitodo\Dlf\Domain\Repository\MailRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class MailRepositoryTest extends FunctionalTestCase
-{
+class MailRepositoryTest extends FunctionalTestCase {
     /**
      * @var MailRepository
      */

Tests/Functional/Repository/MetatdataRepositoryTest.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
             20000
         );
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Repository/metadata.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Repository/metadata.csv');
     }
 
 

Braces +2 added lines, -4 removed lines

@@ -16,8 +16,7 @@ 
 use Kitodo\Dlf\Domain\Repository\MetadataRepository;
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 
-class MetadataRepositoryTest extends FunctionalTestCase
-{
+class MetadataRepositoryTest extends FunctionalTestCase {
     /**
      * @var MetadataRepository
      */
@@ -40,8 +39,7 @@ 
      * @param $settings
      * @return array
      */
-    protected function findBySettings($settings)
-    {
+    protected function findBySettings($settings) {
         $metadata = $this->metadataRepository->findBySettings($settings);
         self::assertNotNull($metadata);
         self::assertInstanceOf(QueryResult::class, $metadata);

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -67,14 +67,14 @@ 
             implode(', ', array_keys($metadataByLabel))
         );
 
-        $metadataByLabel = $this->findBySettings(['is_listed' => true]);
+        $metadataByLabel = $this->findBySettings(['is_listed' => TRUE]);
         self::assertCount(3, $metadataByLabel);
         self::assertEquals(
             'Autor, Institution, Titel',
             implode(', ', array_keys($metadataByLabel))
         );
 
-        $metadataByLabel = $this->findBySettings(['is_sortable' => true]);
+        $metadataByLabel = $this->findBySettings(['is_sortable' => TRUE]);
         self::assertCount(4, $metadataByLabel);
         self::assertEquals(
             'Ort, Untertitel, Autor, Titel',
@@ -83,8 +83,8 @@ 
 
         $metadataByLabel = $this->findBySettings(
             [
-                'is_sortable' => true,
-                'is_listed' => true
+                'is_sortable' => TRUE,
+                'is_listed' => TRUE
             ]
         );
         self::assertCount(2, $metadataByLabel);

Tests/Functional/Api/PageViewProxyTest.php

Spacing +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
         ]);
 
         self::assertEquals(200, $response->getStatusCode());
-        self::assertEquals('This is some plain text test file.' . "\n", (string) $response->getBody());
+        self::assertEquals('This is some plain text test file.'."\n", (string) $response->getBody());
     }
 
     /**

Braces +3 added lines, -6 removed lines

@@ -15,12 +15,10 @@ 
 use Kitodo\Dlf\Tests\Functional\FunctionalTestCase;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
-class PageViewProxyTest extends FunctionalTestCase
-{
+class PageViewProxyTest extends FunctionalTestCase {
     protected $disableJsonWrappedResponse = true;
 
-    protected function getDlfConfiguration()
-    {
+    protected function getDlfConfiguration() {
         return array_merge(parent::getDlfConfiguration(), [
             'general' => [
                 'enableInternalProxy' => true
@@ -28,8 +26,7 @@ 
         ]);
     }
 
-    protected function queryProxy(array $query, string $method = 'GET')
-    {
+    protected function queryProxy(array $query, string $method = 'GET') {
         $query['eID'] = 'tx_dlf_pageview_proxy';
 
         return $this->httpClient->request($method, '', [

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -17,13 +17,13 @@
 
 class PageViewProxyTest extends FunctionalTestCase
 {
-    protected $disableJsonWrappedResponse = true;
+    protected $disableJsonWrappedResponse = TRUE;
 
     protected function getDlfConfiguration()
     {
         return array_merge(parent::getDlfConfiguration(), [
             'general' => [
-                'enableInternalProxy' => true
+                'enableInternalProxy' => TRUE
             ]
         ]);
     }

Tests/Functional/Api/OaiPmhTest.php

Spacing +9 added lines, -9 removed lines

@@ -51,15 +51,15 @@ 
     {
         parent::setUp();
 
-        $this->oaiUrl = $this->baseUrl . 'index.php?id=' . $this->oaiPage;
-        $this->oaiUrlNoStoragePid = $this->baseUrl . 'index.php?id=' . $this->oaiPageNoStoragePid;
+        $this->oaiUrl = $this->baseUrl.'index.php?id='.$this->oaiPage;
+        $this->oaiUrlNoStoragePid = $this->baseUrl.'index.php?id='.$this->oaiPageNoStoragePid;
 
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/documents_1.csv');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/metadata.csv');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/libraries.csv');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/Common/pages.csv');
-        $this->importDataSet(__DIR__ . '/../../Fixtures/OaiPmh/pages.xml');
-        $this->importCSVDataSet(__DIR__ . '/../../Fixtures/OaiPmh/solrcores.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/documents_1.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/metadata.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/libraries.csv');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/Common/pages.csv');
+        $this->importDataSet(__DIR__.'/../../Fixtures/OaiPmh/pages.xml');
+        $this->importCSVDataSet(__DIR__.'/../../Fixtures/OaiPmh/solrcores.csv');
 
         $this->solrCoreRepository = $this->initializeRepository(SolrCoreRepository::class, 20000);
 
@@ -75,7 +75,7 @@ 
             $coreName = Solr::createCore();
             $solr = Solr::getInstance($coreName);
 
-            $this->importSolrDocuments($solr, __DIR__ . '/../../Fixtures/Common/documents_1.solr.json');
+            $this->importSolrDocuments($solr, __DIR__.'/../../Fixtures/Common/documents_1.solr.json');
         }
 
         $oaiCoreModel = $this->solrCoreRepository->findByUid(11001);

Braces +14 added lines, -28 removed lines

@@ -21,8 +21,7 @@ 
 use Phpoaipmh\Exception\OaipmhException;
 use SimpleXMLElement;
 
-class OaiPmhTest extends FunctionalTestCase
-{
+class OaiPmhTest extends FunctionalTestCase {
     protected $disableJsonWrappedResponse = true;
 
     protected $coreExtensionsToLoad = [
@@ -66,8 +65,7 @@ 
         $this->setUpOaiSolr();
     }
 
-    protected function setUpOaiSolr()
-    {
+    protected function setUpOaiSolr() {
         // Setup Solr only once for all tests in this suite
         static $solr = null;
 
@@ -87,8 +85,7 @@ 
     /**
      * @test
      */
-    public function correctlyRespondsOnBadVerb()
-    {
+    public function correctlyRespondsOnBadVerb() {
         $client = new HttpClient();
         $response = $client->get($this->baseUrl, [
             'query' => [
@@ -113,8 +110,7 @@ 
     /**
      * @test
      */
-    public function canIdentify()
-    {
+    public function canIdentify() {
         $oai = Endpoint::build($this->oaiUrl);
         $identity = $oai->identify();
 
@@ -127,8 +123,7 @@ 
     /**
      * @test
      */
-    public function identifyGivesFallbackDatestampWhenNoDocuments()
-    {
+    public function identifyGivesFallbackDatestampWhenNoDocuments() {
         $oai = Endpoint::build($this->oaiUrlNoStoragePid);
         $identity = $oai->identify();
 
@@ -138,8 +133,7 @@ 
     /**
      * @test
      */
-    public function canListMetadataFormats()
-    {
+    public function canListMetadataFormats() {
         $oai = Endpoint::build($this->oaiUrl);
         $formats = $oai->listMetadataFormats();
 
@@ -154,8 +148,7 @@ 
     /**
      * @test
      */
-    public function canListRecords()
-    {
+    public function canListRecords() {
         $oai = Endpoint::build($this->oaiUrl);
         $result = $oai->listRecords('mets');
 
@@ -168,8 +161,7 @@ 
     /**
      * @test
      */
-    public function noRecordsUntil1900()
-    {
+    public function noRecordsUntil1900() {
         $this->expectException(OaipmhException::class);
         $this->expectExceptionMessage('empty list');
 
@@ -182,8 +174,7 @@ 
     /**
      * @test
      */
-    public function canUseResumptionToken()
-    {
+    public function canUseResumptionToken() {
         // NOTE: cursor and expirationDate are optional by the specification,
         //       but we include them in our implementation
 
@@ -241,8 +232,7 @@ 
     /**
      * @test
      */
-    public function noResumptionTokenForCompleteList()
-    {
+    public function noResumptionTokenForCompleteList() {
         $client = new HttpClient();
 
         foreach (['ListIdentifiers', 'ListRecords'] as $verb) {
@@ -264,8 +254,7 @@ 
     /**
      * @test
      */
-    public function canListAndResumeIdentifiers()
-    {
+    public function canListAndResumeIdentifiers() {
         $oai = Endpoint::build($this->oaiUrl);
         $result = $oai->listIdentifiers('mets');
 
@@ -278,18 +267,15 @@ 
         self::assertEquals('oai:de:slub-dresden:db:id-476248086', $record->identifier);
     }
 
-    protected function parseUtc(string $dateTime)
-    {
+    protected function parseUtc(string $dateTime) {
         return DateTime::createFromFormat('Y-m-d\TH:i:s\Z', $dateTime);
     }
 
-    protected function assertUtcDateString(string $dateTime)
-    {
+    protected function assertUtcDateString(string $dateTime) {
         self::assertInstanceOf(DateTime::class, $this->parseUtc($dateTime));
     }
 
-    protected function assertInFuture(string $dateTime)
-    {
+    protected function assertInFuture(string $dateTime) {
         self::assertGreaterThan(new DateTime(), $this->parseUtc($dateTime));
     }
 }

Tests/Functional/ViewHelpers/JsFooterViewHelperTest.php

Braces +1 added lines, -2 removed lines

@@ -20,8 +20,7 @@
 /**
  * @covers JsFooterViewHelper
  */
-class JsFooterViewHelperTest extends FunctionalTestCase
-{
+class JsFooterViewHelperTest extends FunctionalTestCase {
     /**
      * @var bool Speed up this test case, it needs no database
      */

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     /**
      * @var bool Speed up this test case, it needs no database
      */
-    protected $initializeDatabase = false;
+    protected $initializeDatabase = FALSE;
 
     /**
      * @test