Passed
Pull Request — master (#123)
by
unknown
05:28 queued 29s
created
Classes/Controller/PageGridController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
         $pageGridPagination = new PageGridPagination($pageGridPaginator);
69 69
 
70 70
         $pagination = $this->buildSimplePagination($pageGridPagination, $pageGridPaginator);
71
-        $this->view->assignMultiple([ 'pagination' => $pagination, 'paginator' => $pageGridPaginator ]);
71
+        $this->view->assignMultiple(['pagination' => $pagination, 'paginator' => $pageGridPaginator]);
72 72
 
73 73
         $this->view->assign('docUid', $this->requestData['id']);
74 74
     }
Please login to merge, or discard this patch.
Classes/Controller/TableOfContentsController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
                 }
198 198
             }
199 199
             // Append "IFSUB" to "ITEM_STATE" if this entry has sub-entries.
200
-            $entryArray['ITEM_STATE'] = ($entryArray['ITEM_STATE'] == 'NO' ? 'IFSUB' : $entryArray['ITEM_STATE'] . 'IFSUB');
200
+            $entryArray['ITEM_STATE'] = ($entryArray['ITEM_STATE'] == 'NO' ? 'IFSUB' : $entryArray['ITEM_STATE'].'IFSUB');
201 201
         }
202 202
         return $entryArray;
203 203
     }
@@ -309,9 +309,9 @@  discard block
 block discarded – undo
309 309
                     $title = '';
310 310
                     foreach ($fields as $field) {
311 311
                         if ($field == 'type') {
312
-                            $title .= $this->getTranslatedType($entry['type']) . ' ';
312
+                            $title .= $this->getTranslatedType($entry['type']).' ';
313 313
                         } else {
314
-                            $title .= $entry[$field] . ' ';
314
+                            $title .= $entry[$field].' ';
315 315
                         }
316 316
                     }
317 317
         
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
                 }
320 320
             }
321 321
         }
322
-        return $entry['label'] ?: $entry['orderlabel'];
322
+        return $entry['label'] ? : $entry['orderlabel'];
323 323
     }
324 324
 
325 325
     /**
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
      */
353 353
     private function sortSubMenu(array &$menu): void
354 354
     {
355
-        usort($menu[0]['_SUB_MENU'], function ($firstElement, $secondElement) {
355
+        usort($menu[0]['_SUB_MENU'], function($firstElement, $secondElement) {
356 356
             if (!empty($firstElement['orderlabel'])) {
357 357
                 return $firstElement['orderlabel'] <=> $secondElement['orderlabel'];
358 358
             }
Please login to merge, or discard this patch.
Classes/Controller/FeedsController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
         if ($library) {
76 76
             $feedMeta['copyright'] = $library->getLabel();
77 77
         } else {
78
-            $this->logger->error('Failed to fetch label of selected library with "' . $this->settings['library'] . '"');
78
+            $this->logger->error('Failed to fetch label of selected library with "'.$this->settings['library'].'"');
79 79
         }
80 80
 
81 81
         if (
@@ -95,12 +95,12 @@  discard block
 block discarded – undo
95 95
                 ) {
96 96
                     $superiorTitle = AbstractDocument::getTitle($document->getPartof(), true);
97 97
                     if (!empty($superiorTitle)) {
98
-                        $title .= '[' . $superiorTitle . ']';
98
+                        $title .= '['.$superiorTitle.']';
99 99
                     }
100 100
                 }
101 101
                 // Get title of document.
102 102
                 if (!empty($document->getTitle())) {
103
-                    $title .= ' ' . $document->getTitle();
103
+                    $title .= ' '.$document->getTitle();
104 104
                 }
105 105
                 // Set default title if empty.
106 106
                 if (empty($title)) {
@@ -108,13 +108,13 @@  discard block
 block discarded – undo
108 108
                 }
109 109
                 // Append volume information.
110 110
                 if (!empty($document->getVolume())) {
111
-                    $title .= ', ' . LocalizationUtility::translate('volume', 'dlf') . ' ' . $document->getVolume();
111
+                    $title .= ', '.LocalizationUtility::translate('volume', 'dlf').' '.$document->getVolume();
112 112
                 }
113 113
                 // Is this document new or updated?
114 114
                 if ($document->getCrdate() == $document->getTstamp()) {
115
-                    $title = LocalizationUtility::translate('plugins.feeds.new', 'dlf') . ' ' . trim($title);
115
+                    $title = LocalizationUtility::translate('plugins.feeds.new', 'dlf').' '.trim($title);
116 116
                 } else {
117
-                    $title = LocalizationUtility::translate('plugins.feeds.update', 'dlf') . ' ' . trim($title);
117
+                    $title = LocalizationUtility::translate('plugins.feeds.update', 'dlf').' '.trim($title);
118 118
                 }
119 119
 
120 120
                 $document->setTitle($title);
Please login to merge, or discard this patch.
Classes/Controller/CalendarController.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -134,8 +134,8 @@  discard block
 block discarded – undo
134 134
         $this->view->assign('calendarData', $calendarData);
135 135
         $this->view->assign('documentId', $this->document->getUid());
136 136
         $this->view->assign('yearLinkTitle', $yearLinkTitle);
137
-        $this->view->assign('parentDocumentId', $this->document->getPartof() ?: $this->document->getCurrentDocument()->tableOfContents[0]['points']);
138
-        $this->view->assign('allYearDocTitle', $this->document->getCurrentDocument()->getTitle($this->document->getPartof()) ?: $this->document->getCurrentDocument()->tableOfContents[0]['label']);
137
+        $this->view->assign('parentDocumentId', $this->document->getPartof() ? : $this->document->getCurrentDocument()->tableOfContents[0]['points']);
138
+        $this->view->assign('allYearDocTitle', $this->document->getCurrentDocument()->getTitle($this->document->getPartof()) ? : $this->document->getCurrentDocument()->tableOfContents[0]['label']);
139 139
     }
140 140
 
141 141
     /**
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
         }
221 221
 
222 222
         $this->view->assign('documentId', $this->document->getUid());
223
-        $this->view->assign('allYearDocTitle', $this->document->getCurrentDocument()->getTitle((int) $this->document->getUid()) ?: $this->document->getCurrentDocument()->tableOfContents[0]['label']);
223
+        $this->view->assign('allYearDocTitle', $this->document->getCurrentDocument()->getTitle((int) $this->document->getUid()) ? : $this->document->getCurrentDocument()->tableOfContents[0]['label']);
224 224
     }
225 225
 
226 226
     /**
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
     protected function getCalendarYear(array &$calendarData, array $calendarIssuesByMonth, int $year, int $firstMonth = 1, int $lastMonth = 12): void
240 240
     {
241 241
         for ($i = $firstMonth; $i <= $lastMonth; $i++) {
242
-            $key = $year . '-' . $i;
242
+            $key = $year.'-'.$i;
243 243
 
244 244
             $calendarData[$key] = [
245 245
                 'DAYMON_NAME' => strftime('%a', strtotime('last Monday')),
@@ -249,16 +249,16 @@  discard block
 block discarded – undo
249 249
                 'DAYFRI_NAME' => strftime('%a', strtotime('last Friday')),
250 250
                 'DAYSAT_NAME' => strftime('%a', strtotime('last Saturday')),
251 251
                 'DAYSUN_NAME' => strftime('%a', strtotime('last Sunday')),
252
-                'MONTHNAME'  => strftime('%B', strtotime($year . '-' . $i . '-1')) . ' ' . $year,
252
+                'MONTHNAME'  => strftime('%B', strtotime($year.'-'.$i.'-1')).' '.$year,
253 253
                 'CALYEAR' => ($i == $firstMonth) ? $year : ''
254 254
             ];
255 255
 
256
-            $firstOfMonth = strtotime($year . '-' . $i . '-1');
256
+            $firstOfMonth = strtotime($year.'-'.$i.'-1');
257 257
             $lastOfMonth = strtotime('last day of', ($firstOfMonth));
258 258
             $firstOfMonthStart = strtotime('last Monday', $firstOfMonth);
259 259
             // There are never more than 6 weeks in a month.
260 260
             for ($j = 0; $j <= 5; $j++) {
261
-                $firstDayOfWeek = strtotime('+ ' . $j . ' Week', $firstOfMonthStart);
261
+                $firstDayOfWeek = strtotime('+ '.$j.' Week', $firstOfMonthStart);
262 262
 
263 263
                 $calendarData[$key]['week'][$j] = [
264 264
                     'DAYMON' => ['dayValue' => '&nbsp;'],
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
                 ];
272 272
                 // Every week has seven days. ;-)
273 273
                 for ($k = 0; $k <= 6; $k++) {
274
-                    $currentDayTime = strtotime('+ ' . $k . ' Day', $firstDayOfWeek);
274
+                    $currentDayTime = strtotime('+ '.$k.' Day', $firstDayOfWeek);
275 275
                     if (
276 276
                         $currentDayTime >= $firstOfMonth
277 277
                         && $currentDayTime <= $lastOfMonth
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
      */
343 343
     private function fillCalendar(array &$calendarData, int $currentDayTime, string $dayLinks, array $dayLinkDiv, int $firstDayOfWeek, int $k): void
344 344
     {
345
-        switch (strftime('%w', strtotime('+ ' . $k . ' Day', $firstDayOfWeek))) {
345
+        switch (strftime('%w', strtotime('+ '.$k.' Day', $firstDayOfWeek))) {
346 346
             case '0':
347 347
                 $this->fillDay($calendarData, $currentDayTime, 'DAYSUN', $dayLinks, $dayLinkDiv);
348 348
                 break;
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
                 $_day = date('j', $dateTimestamp);
447 447
                 $issuesByYear[$_year][$_month][$_day][] = $issue;
448 448
             } else {
449
-                $this->logger->warning('Document with UID ' . $issue['uid'] . 'has no valid date of publication');
449
+                $this->logger->warning('Document with UID '.$issue['uid'].'has no valid date of publication');
450 450
             }
451 451
         }
452 452
         // Sort by years.
@@ -489,7 +489,7 @@  discard block
 block discarded – undo
489 489
             foreach ($year['children'] as $month) {
490 490
                 foreach ($month['children'] as $day) {
491 491
                     foreach ($day['children'] as $issue) {
492
-                        $title = $issue['label'] ?: $issue['orderlabel'];
492
+                        $title = $issue['label'] ? : $issue['orderlabel'];
493 493
                         if (strtotime($title) !== false) {
494 494
                             $title = strftime('%x', strtotime($title));
495 495
                         }
Please login to merge, or discard this patch.
Classes/Format/AudioVideoMD.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
             $metadata['video_duration'] = [$videoDuration];
54 54
         }
55 55
 
56
-        $metadata['duration'] = $metadata['video_duration'] ?: $metadata['audio_duration'] ?: [];
56
+        $metadata['duration'] = $metadata['video_duration'] ? : $metadata['audio_duration'] ? : [];
57 57
 
58 58
         if ($useExternalApis) {
59 59
             // TODO?
Please login to merge, or discard this patch.
Classes/Format/Alto.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
             }
124 124
             return ' ';
125 125
         }
126
-        return htmlspecialchars((string) $attributes['CONTENT']) . ' ';
126
+        return htmlspecialchars((string) $attributes['CONTENT']).' ';
127 127
     }
128 128
 
129 129
     /**
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
      */
138 138
     private function getCoordinates(\SimpleXMLElement $attributes): string
139 139
     {
140
-        return (string) $attributes['HPOS'] . ' ' . (string) $attributes['VPOS'] . ' ' . (string) $attributes['WIDTH'] . ' ' . (string) $attributes['HEIGHT'];
140
+        return (string) $attributes['HPOS'].' '.(string) $attributes['VPOS'].' '.(string) $attributes['WIDTH'].' '.(string) $attributes['HEIGHT'];
141 141
     }
142 142
 
143 143
     /**
Please login to merge, or discard this patch.
Classes/Api/Viaf/Client.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     public function __construct(string $viaf, RequestFactory $requestFactory)
66 66
     {
67 67
         $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(static::class);
68
-        $this->viafUrl = 'http://viaf.org/viaf/' . $viaf;
68
+        $this->viafUrl = 'http://viaf.org/viaf/'.$viaf;
69 69
         $this->requestFactory = $requestFactory;
70 70
     }
71 71
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
         try {
96 96
             $response = $this->requestFactory->request($url);
97 97
         } catch (\Exception $e) {
98
-            $this->logger->warning('Could not fetch data from URL "' . $url . '". Error: ' . $e->getMessage() . '.');
98
+            $this->logger->warning('Could not fetch data from URL "'.$url.'". Error: '.$e->getMessage().'.');
99 99
             return false;
100 100
         }
101 101
         return $response->getBody()->getContents();
@@ -110,6 +110,6 @@  discard block
 block discarded – undo
110 110
      **/
111 111
     private function getApiEndpoint(): string
112 112
     {
113
-        return $this->viafUrl . '/' . $this->endpoint;
113
+        return $this->viafUrl.'/'.$this->endpoint;
114 114
     }
115 115
 }
Please login to merge, or discard this patch.
Classes/Api/Orcid/Client.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         try {
112 112
             $response = $this->requestFactory->request($url);
113 113
         } catch (\Exception $e) {
114
-            $this->logger->warning('Could not fetch data from URL "' . $url . '". Error: ' . $e->getMessage() . '.');
114
+            $this->logger->warning('Could not fetch data from URL "'.$url.'". Error: '.$e->getMessage().'.');
115 115
             return false;
116 116
         }
117 117
         return $response->getBody()->getContents();
@@ -126,10 +126,10 @@  discard block
 block discarded – undo
126 126
      **/
127 127
     private function getApiEndpoint(): string
128 128
     {
129
-        $url  = 'https://' . $this->level . '.' . self::HOSTNAME;
130
-        $url .= '/v' . self::VERSION . '/';
129
+        $url  = 'https://'.$this->level.'.'.self::HOSTNAME;
130
+        $url .= '/v'.self::VERSION.'/';
131 131
         $url .= $this->orcid;
132
-        $url .= '/' . $this->endpoint;
132
+        $url .= '/'.$this->endpoint;
133 133
         return $url;
134 134
     }
135 135
 }
Please login to merge, or discard this patch.
Classes/Common/IiifManifest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -653,16 +653,16 @@  discard block
 block discarded – undo
653 653
                 if ($resArray['format'] > 0 && !empty($resArray['xpath_sorting'])) {
654 654
                     $values = $iiifResource->jsonPath($resArray['xpath_sorting']);
655 655
                     if (is_string($values)) {
656
-                        $metadata[$resArray['index_name'] . '_sorting'][0] = [trim((string) $values)];
656
+                        $metadata[$resArray['index_name'].'_sorting'][0] = [trim((string) $values)];
657 657
                     } elseif ($values instanceof JSONPath && is_array($values->data()) && count($values->data()) > 1) {
658 658
                         $metadata[$resArray['index_name']] = [];
659 659
                         foreach ($values->data() as $value) {
660
-                            $metadata[$resArray['index_name'] . '_sorting'][0] = trim((string) $value);
660
+                            $metadata[$resArray['index_name'].'_sorting'][0] = trim((string) $value);
661 661
                         }
662 662
                     }
663 663
                 }
664
-                if (empty($metadata[$resArray['index_name'] . '_sorting'][0])) {
665
-                    $metadata[$resArray['index_name'] . '_sorting'][0] = $metadata[$resArray['index_name']][0];
664
+                if (empty($metadata[$resArray['index_name'].'_sorting'][0])) {
665
+                    $metadata[$resArray['index_name'].'_sorting'][0] = $metadata[$resArray['index_name']][0];
666 666
                 }
667 667
             }
668 668
         }
@@ -772,7 +772,7 @@  discard block
 block discarded – undo
772 772
                     }
773 773
                 }
774 774
             } else {
775
-                $this->logger->warning('Invalid structure resource @id "' . $id . '"');
775
+                $this->logger->warning('Invalid structure resource @id "'.$id.'"');
776 776
                 return $rawText;
777 777
             }
778 778
             $this->rawTextArray[$id] = $rawText;
@@ -817,7 +817,7 @@  discard block
 block discarded – undo
817 817
                 return true;
818 818
             }
819 819
         }
820
-        $this->logger->error('Could not load IIIF manifest from "' . $location . '"');
820
+        $this->logger->error('Could not load IIIF manifest from "'.$location.'"');
821 821
         return false;
822 822
     }
823 823
 
Please login to merge, or discard this patch.