Passed
Pull Request — master (#123)
by
unknown
05:28 queued 29s
created
Build/Documentation/dbdocs/Generator.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 
184 184
             // There may be a single non-signifying space after the doc-comment asterisk,
185 185
             // which is not included.
186
-            $text .= preg_replace('#\\s*/?[*/]*\\s?(.*)$#', '$1', $line) . "\n";
186
+            $text .= preg_replace('#\\s*/?[*/]*\\s?(.*)$#', '$1', $line)."\n";
187 187
         }
188 188
         $text = trim($text);
189 189
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 RST);
205 205
 
206 206
         // Sort tables alphabetically
207
-        usort($tables, function ($lhs, $rhs) {
207
+        usort($tables, function($lhs, $rhs) {
208 208
             return $lhs->name <=> $rhs->name;
209 209
         });
210 210
 
@@ -214,13 +214,13 @@  discard block
 block discarded – undo
214 214
             // Set header
215 215
             $header = $tableInfo->name;
216 216
             if (!empty($tableInfo->feComment)) {
217
-                $header .= ': ' . $tableInfo->feComment;
217
+                $header .= ': '.$tableInfo->feComment;
218 218
             }
219 219
             $section->setHeader($header);
220 220
 
221 221
             // Set introductory text of subsection
222 222
             if ($tableInfo->modelClass) {
223
-                $section->addText('Extbase domain model: ``' . $tableInfo->modelClass . '``');
223
+                $section->addText('Extbase domain model: ``'.$tableInfo->modelClass.'``');
224 224
             }
225 225
             $section->addText($tableInfo->classComment);
226 226
             $section->addText($tableInfo->sqlComment);
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
                 'description' => 'Description',
232 232
             ]];
233 233
 
234
-            $rows = array_map(function ($column) use ($page) {
234
+            $rows = array_map(function($column) use ($page) {
235 235
                 return [
236 236
                     'field' => (
237 237
                         $page->format($column->name, ['bold' => $column->isPrimary])
Please login to merge, or discard this patch.
Classes/Controller/StatisticsController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,13 +33,13 @@
 block discarded – undo
33 33
         $foundNumbers = $this->documentRepository->getStatisticsForSelectedCollection($this->settings);
34 34
 
35 35
         // Set replacements.
36
-        $args['###TITLES###'] = $foundNumbers['titles'] . ' ' . htmlspecialchars(
36
+        $args['###TITLES###'] = $foundNumbers['titles'].' '.htmlspecialchars(
37 37
             LocalizationUtility::translate(
38 38
                 ($foundNumbers['titles'] > 1 ? 'titles' : 'title'), 'dlf'
39 39
             )
40 40
         );
41 41
 
42
-        $args['###VOLUMES###'] = $foundNumbers['volumes'] . ' ' . htmlspecialchars(
42
+        $args['###VOLUMES###'] = $foundNumbers['volumes'].' '.htmlspecialchars(
43 43
             LocalizationUtility::translate(
44 44
                 ($foundNumbers['volumes'] > 1 ? 'volumes' : 'volume'), 'dlf'
45 45
             )
Please login to merge, or discard this patch.
Classes/Controller/View3DController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,8 +48,8 @@
 block discarded – undo
48 48
 
49 49
             $settingsParts = explode("/", $model);
50 50
             $fileName = end($settingsParts);
51
-            $path = substr($model, 0,  strrpos($model, $fileName));
52
-            $modelSettings = $path . "metadata/" . $fileName . "_viewer";
51
+            $path = substr($model, 0, strrpos($model, $fileName));
52
+            $modelSettings = $path."metadata/".$fileName."_viewer";
53 53
 
54 54
             if (!empty($modelConverted)) {
55 55
                 $model = $modelConverted;
Please login to merge, or discard this patch.
Classes/Controller/AudioPlayerController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -52,12 +52,12 @@
 block discarded – undo
52 52
             $(document).ready(function() {
53 53
                 AudioPlayer = new dlfAudioPlayer({
54 54
                     audio: {
55
-                        mimeType: "' . $this->audio['mimetype'] . '",
56
-                        title: "' . $this->audio['label'] . '",
57
-                        url:  "' . $this->audio['url'] . '"
55
+                        mimeType: "' . $this->audio['mimetype'].'",
56
+                        title: "' . $this->audio['label'].'",
57
+                        url:  "' . $this->audio['url'].'"
58 58
                     },
59 59
                     parentElId: "tx-dlf-audio",
60
-                    swfPath: "' . PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath('dlf')) . 'Resources/Public/JavaScript/jPlayer/jquery.jplayer.swf"
60
+                    swfPath: "' . PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath('dlf')).'Resources/Public/JavaScript/jPlayer/jquery.jplayer.swf"
61 61
                 });
62 62
             });
63 63
         ';
Please login to merge, or discard this patch.
Classes/Api/Orcid/Profile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@
 block discarded – undo
129 129
             $this->raw->registerXPathNamespace('personal-details', 'http://www.orcid.org/ns/personal-details');
130 130
             $givenNames = $this->raw->xpath('./personal-details:name/personal-details:given-names');
131 131
             $familyName = $this->raw->xpath('./personal-details:name/personal-details:family-name');
132
-            return (string) $givenNames[0] . ' ' . (string) $familyName[0];
132
+            return (string) $givenNames[0].' '.(string) $familyName[0];
133 133
         } else {
134 134
             $this->logger->warning('No name found for given ORCID');
135 135
             return false;
Please login to merge, or discard this patch.
Tests/routeFunctionalInstance.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -15,10 +15,10 @@
 block discarded – undo
15 15
 preg_match("@.*/(?:acceptance|functional-[a-z\d]+)@", $_SERVER['REQUEST_URI'], $matches);
16 16
 
17 17
 if (!empty($matches)) {
18
-    $root = realpath($_SERVER['DOCUMENT_ROOT'] . $matches[0]);
18
+    $root = realpath($_SERVER['DOCUMENT_ROOT'].$matches[0]);
19 19
     if ($root !== false) {
20
-        putenv('TYPO3_PATH_ROOT=' . $root);
21
-        putenv('TYPO3_PATH_APP=' . $root);
20
+        putenv('TYPO3_PATH_ROOT='.$root);
21
+        putenv('TYPO3_PATH_APP='.$root);
22 22
     }
23 23
 }
24 24
 
Please login to merge, or discard this patch.
Classes/Hooks/DataHandler.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -148,10 +148,10 @@  discard block
 block discarded – undo
148 148
                     ) {
149 149
                         // Get current configuration.
150 150
                         $result = $queryBuilder
151
-                            ->select($table . '.is_listed AS is_listed')
151
+                            ->select($table.'.is_listed AS is_listed')
152 152
                             ->from($table)
153 153
                             ->where(
154
-                                $queryBuilder->expr()->eq($table . '.uid', (int) $id),
154
+                                $queryBuilder->expr()->eq($table.'.uid', (int) $id),
155 155
                                 Helper::whereExpression($table)
156 156
                             )
157 157
                             ->setMaxResults(1)
@@ -173,10 +173,10 @@  discard block
 block discarded – undo
173 173
                     ) {
174 174
                         // Get current configuration.
175 175
                         $result = $queryBuilder
176
-                            ->select($table . '.index_autocomplete AS index_autocomplete')
176
+                            ->select($table.'.index_autocomplete AS index_autocomplete')
177 177
                             ->from($table)
178 178
                             ->where(
179
-                                $queryBuilder->expr()->eq($table . '.uid', (int) $id),
179
+                                $queryBuilder->expr()->eq($table.'.uid', (int) $id),
180 180
                                 Helper::whereExpression($table)
181 181
                             )
182 182
                             ->setMaxResults(1)
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
                                 if ($solr->ready) {
252 252
                                     // Delete Solr document.
253 253
                                     $updateQuery = $solr->service->createUpdate();
254
-                                    $updateQuery->addDeleteQuery('uid:' . (int) $id);
254
+                                    $updateQuery->addDeleteQuery('uid:'.(int) $id);
255 255
                                     $updateQuery->addCommit();
256 256
                                     $solr->service->update($updateQuery);
257 257
                                 }
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
                                     $document->setCurrentDocument($doc);
264 264
                                     Indexer::add($document, $this->getDocumentRepository());
265 265
                                 } else {
266
-                                    $this->logger->error('Failed to re-index document with UID ' . (string) $id);
266
+                                    $this->logger->error('Failed to re-index document with UID '.(string) $id);
267 267
                                 }
268 268
                             }
269 269
                         }
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
330 330
                         if ($solr->ready) {
331 331
                             // Delete Solr document.
332 332
                             $updateQuery = $solr->service->createUpdate();
333
-                            $updateQuery->addDeleteQuery('uid:' . (int) $id);
333
+                            $updateQuery->addDeleteQuery('uid:'.(int) $id);
334 334
                             $updateQuery->addCommit();
335 335
                             $solr->service->update($updateQuery);
336 336
                             if ($command == 'delete') {
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
                             $document->setCurrentDocument($doc);
346 346
                             Indexer::add($document, $this->getDocumentRepository());
347 347
                         } else {
348
-                            $this->logger->error('Failed to re-index document with UID ' . (string) $id);
348
+                            $this->logger->error('Failed to re-index document with UID '.(string) $id);
349 349
                         }
350 350
                         break;
351 351
                 }
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
                             // Nothing to do here.
397 397
                         }
398 398
                     }
399
-                    $this->logger->warning('Core ' . $resArray['core'] . ' could not be deleted from Apache Solr');
399
+                    $this->logger->warning('Core '.$resArray['core'].' could not be deleted from Apache Solr');
400 400
                 }
401 401
             }
402 402
         }
Please login to merge, or discard this patch.
Classes/Hooks/KitodoProductionHacks.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
                 }
58 58
                 $dmdIds = explode(' ', $id);
59 59
                 foreach ($dmdIds as $dmdId) {
60
-                    $recordIds = $xml->xpath('//mets:dmdSec[@ID="' . $dmdId . '"]//mods:mods/mods:recordInfo/mods:recordIdentifier');
60
+                    $recordIds = $xml->xpath('//mets:dmdSec[@ID="'.$dmdId.'"]//mods:mods/mods:recordInfo/mods:recordIdentifier');
61 61
                     if (!empty($recordIds)) {
62 62
                         $recordId = (string) $recordIds[0];
63 63
                         break;
Please login to merge, or discard this patch.
Classes/Updates/FileLocationUpdater.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -190,9 +190,9 @@  discard block
 block discarded – undo
190 190
                             $queryBuilder->createNamedParameter('', \PDO::PARAM_STR)
191 191
                         ),
192 192
                         $queryBuilder->expr()->comparison(
193
-                            'CAST(CAST(' . $queryBuilder->quoteIdentifier($this->fieldsToMigrate[$table]) . ' AS DECIMAL) AS CHAR)',
193
+                            'CAST(CAST('.$queryBuilder->quoteIdentifier($this->fieldsToMigrate[$table]).' AS DECIMAL) AS CHAR)',
194 194
                             ExpressionBuilder::NEQ,
195
-                            'CAST(' . $queryBuilder->quoteIdentifier($this->fieldsToMigrate[$table]) . ' AS CHAR)'
195
+                            'CAST('.$queryBuilder->quoteIdentifier($this->fieldsToMigrate[$table]).' AS CHAR)'
196 196
                         )
197 197
                     )
198 198
                     ->orderBy('uid')
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
                 }
206 206
             } catch (Exception $e) {
207 207
                 throw new \RuntimeException(
208
-                    'Database query failed. Error was: ' . $e->getPrevious()->getMessage(),
208
+                    'Database query failed. Error was: '.$e->getPrevious()->getMessage(),
209 209
                     1511950673
210 210
                 );
211 211
             }
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
         $connectionPool = GeneralUtility::makeInstance(ConnectionPool::class);
272 272
 
273 273
         $fileUid = null;
274
-        $sourcePath = Environment::getPublicPath() . '/' . $fieldItem;
274
+        $sourcePath = Environment::getPublicPath().'/'.$fieldItem;
275 275
 
276 276
         // maybe the file was already moved, so check if the original file still exists
277 277
         if (file_exists($sourcePath)) {
Please login to merge, or discard this patch.