Erikmitk / kitodo-presentation

Classes/Format/Alto.php

Spacing +2 added lines, -2 removed lines

@@ -123,7 +123,7 @@ 
             }
             return ' ';
         }
-        return htmlspecialchars((string) $attributes['CONTENT']) . ' ';
+        return htmlspecialchars((string) $attributes['CONTENT']).' ';
     }
 
     /**
@@ -137,7 +137,7 @@ 
      */
     private function getCoordinates(\SimpleXMLElement $attributes): string
     {
-        return (string) $attributes['HPOS'] . ' ' . (string) $attributes['VPOS'] . ' ' . (string) $attributes['WIDTH'] . ' ' . (string) $attributes['HEIGHT'];
+        return (string) $attributes['HPOS'].' '.(string) $attributes['VPOS'].' '.(string) $attributes['WIDTH'].' '.(string) $attributes['HEIGHT'];
     }
 
     /**

Braces +1 added lines, -2 removed lines

@@ -147,8 +147,7 @@
      *
      * @param \SimpleXMLElement &$xml: The XML to register the namespace for
      */
-    private function registerAltoNamespace(\SimpleXMLElement &$xml)
-    {
+    private function registerAltoNamespace(\SimpleXMLElement &$xml) {
         $namespace = $xml->getDocNamespaces();
 
         if (in_array('http://www.loc.gov/standards/alto/ns-v2#', $namespace, true)) {

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -151,11 +151,11 @@
     {
         $namespace = $xml->getDocNamespaces();
 
-        if (in_array('http://www.loc.gov/standards/alto/ns-v2#', $namespace, true)) {
+        if (in_array('http://www.loc.gov/standards/alto/ns-v2#', $namespace, TRUE)) {
             $xml->registerXPathNamespace('alto', 'http://www.loc.gov/standards/alto/ns-v2#');
-        } elseif (in_array('http://www.loc.gov/standards/alto/ns-v3#', $namespace, true)) {
+        } elseif (in_array('http://www.loc.gov/standards/alto/ns-v3#', $namespace, TRUE)) {
             $xml->registerXPathNamespace('alto', 'http://www.loc.gov/standards/alto/ns-v3#');
-        } elseif (in_array('http://www.loc.gov/standards/alto/ns-v4#', $namespace, true)) {
+        } elseif (in_array('http://www.loc.gov/standards/alto/ns-v4#', $namespace, TRUE)) {
             $xml->registerXPathNamespace('alto', 'http://www.loc.gov/standards/alto/ns-v4#');
         }
     }

Classes/Format/Mods.php

Braces +1 added lines, -2 removed lines

@@ -24,8 +24,7 @@
  *
  * @access public
  */
-class Mods implements MetadataInterface
-{
+class Mods implements MetadataInterface {
     /**
      * @access private
      * @var \SimpleXMLElement The metadata XML

Spacing +4 added lines, -4 removed lines

@@ -124,7 +124,7 @@ 
         if (!empty($name)) {
             $this->metadata['author'][$i] = [
                 'name' => $name,
-                'url' => 'https://orcid.org/' . $orcidId
+                'url' => 'https://orcid.org/'.$orcidId
             ];
         } else {
             //fallback into display form
@@ -181,7 +181,7 @@ 
         }
         // Append "valueURI" to name using Unicode unit separator.
         if (!empty($authors[$i]->getValueURI())) {
-            $this->metadata['author'][$i] .= pack('C', 31) . $authors[$i]->getValueURI();
+            $this->metadata['author'][$i] .= pack('C', 31).$authors[$i]->getValueURI();
         }
     }
 
@@ -244,7 +244,7 @@ 
         if (!empty($name)) {
             $this->metadata['holder'][$i] = [
                 'name' => $name,
-                'url' => 'http://viaf.org/viaf/' . $viafId
+                'url' => 'http://viaf.org/viaf/'.$viafId
             ];
         } else {
             //fallback into display form
@@ -267,7 +267,7 @@ 
         $this->getHolderFromXmlDisplayForm($holders, $i);
         // Append "valueURI" to name using Unicode unit separator.
         if (!empty($holders[$i]->getValueURI())) {
-            $this->metadata['holder'][$i] .= pack('C', 31) . $holders[$i]->getValueURI();
+            $this->metadata['holder'][$i] .= pack('C', 31).$holders[$i]->getValueURI();
         }
     }
 

Classes/Format/TeiHeader.php

Braces +1 added lines, -2 removed lines

@@ -22,8 +22,7 @@
  *
  * @access public
  */
-class TeiHeader implements MetadataInterface
-{
+class TeiHeader implements MetadataInterface {
     /**
      * This extracts the essential TEIHDR metadata from XML
      *

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
      *
      * @return void
      */
-    public function extractMetadata(\SimpleXMLElement $xml, array &$metadata, bool $useExternalApis = false): void
+    public function extractMetadata(\SimpleXMLElement $xml, array &$metadata, bool $useExternalApis = FALSE): void
     {
         $xml->registerXPathNamespace('teihdr', 'http://www.tei-c.org/ns/1.0');
     }

Classes/Api/Viaf/Client.php

Spacing +3 added lines, -3 removed lines

@@ -65,7 +65,7 @@ 
     public function __construct(string $viaf, RequestFactory $requestFactory)
     {
         $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(static::class);
-        $this->viafUrl = 'http://viaf.org/viaf/' . $viaf;
+        $this->viafUrl = 'http://viaf.org/viaf/'.$viaf;
         $this->requestFactory = $requestFactory;
     }
 
@@ -95,7 +95,7 @@ 
         try {
             $response = $this->requestFactory->request($url);
         } catch (\Exception $e) {
-            $this->logger->warning('Could not fetch data from URL "' . $url . '". Error: ' . $e->getMessage() . '.');
+            $this->logger->warning('Could not fetch data from URL "'.$url.'". Error: '.$e->getMessage().'.');
             return false;
         }
         return $response->getBody()->getContents();
@@ -110,6 +110,6 @@ 
      **/
     private function getApiEndpoint(): string
     {
-        return $this->viafUrl . '/' . $this->endpoint;
+        return $this->viafUrl.'/'.$this->endpoint;
     }
 }

Braces +3 added lines, -6 removed lines

@@ -26,8 +26,7 @@ 
  *
  * @access public
  **/
-class Client
-{
+class Client {
     /**
      * @access protected
      * @var Logger This holds the logger
@@ -62,8 +61,7 @@ 
      *
      * @return void
      **/
-    public function __construct(string $viaf, RequestFactory $requestFactory)
-    {
+    public function __construct(string $viaf, RequestFactory $requestFactory) {
         $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(static::class);
         $this->viafUrl = 'http://viaf.org/viaf/' . $viaf;
         $this->requestFactory = $requestFactory;
@@ -89,8 +87,7 @@ 
      *
      * @return object|bool
      **/
-    public function getData()
-    {
+    public function getData() {
         $url = $this->getApiEndpoint();
         try {
             $response = $this->requestFactory->request($url);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
             $response = $this->requestFactory->request($url);
         } catch (\Exception $e) {
             $this->logger->warning('Could not fetch data from URL "' . $url . '". Error: ' . $e->getMessage() . '.');
-            return false;
+            return FALSE;
         }
         return $response->getBody()->getContents();
     }

Classes/Api/Viaf/Profile.php

Braces +5 added lines, -10 removed lines

@@ -26,8 +26,7 @@ 
  *
  * @access public
  **/
-class Profile
-{
+class Profile {
     /**
      * @access private
      * @var Logger This holds the logger
@@ -55,8 +54,7 @@ 
      *
      * @return void
      **/
-    public function __construct(string $viaf)
-    {
+    public function __construct(string $viaf) {
         $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(static::class);
         $this->client = new Client($viaf, GeneralUtility::makeInstance(RequestFactory::class));
     }
@@ -68,8 +66,7 @@ 
      *
      * @return array|false
      **/
-    public function getData()
-    {
+    public function getData() {
         $this->getRaw();
         if ($this->raw !== false && !empty($this->raw)) {
             $data = [];
@@ -89,8 +86,7 @@ 
      *
      * @return string|false
      **/
-    public function getAddress()
-    {
+    public function getAddress() {
         $this->getRaw();
         if ($this->raw !== false && !empty($this->raw->asXML())) {
             return (string) $this->raw->xpath('./ns1:nationalityOfEntity/ns1:data/ns1:text')[0];
@@ -107,8 +103,7 @@ 
      *
      * @return string|false
      **/
-    public function getFullName()
-    {
+    public function getFullName() {
         $this->getRaw();
         if ($this->raw !== false && !empty($this->raw->asXML())) {
             $rawName = $this->raw->xpath('./ns1:mainHeadings/ns1:data/ns1:text');

Upper-Lower-Casing +9 added lines, -9 removed lines

@@ -44,7 +44,7 @@ 
      * @access private
      * @var \SimpleXmlElement|false The raw VIAF profile or false if not found
      **/
-    private $raw = false;
+    private $raw = FALSE;
 
     /**
      * Constructs client instance
@@ -71,14 +71,14 @@ 
     public function getData()
     {
         $this->getRaw();
-        if ($this->raw !== false && !empty($this->raw)) {
+        if ($this->raw !== FALSE && !empty($this->raw)) {
             $data = [];
             $data['address'] = $this->getAddress();
             $data['fullName'] = $this->getFullName();
             return $data;
         } else {
             $this->logger->warning('No data found for given VIAF URL');
-            return false;
+            return FALSE;
         }
     }
 
@@ -92,11 +92,11 @@ 
     public function getAddress()
     {
         $this->getRaw();
-        if ($this->raw !== false && !empty($this->raw->asXML())) {
+        if ($this->raw !== FALSE && !empty($this->raw->asXML())) {
             return (string) $this->raw->xpath('./ns1:nationalityOfEntity/ns1:data/ns1:text')[0];
         } else {
             $this->logger->warning('No address found for given VIAF URL');
-            return false;
+            return FALSE;
         }
     }
 
@@ -110,14 +110,14 @@ 
     public function getFullName()
     {
         $this->getRaw();
-        if ($this->raw !== false && !empty($this->raw->asXML())) {
+        if ($this->raw !== FALSE && !empty($this->raw->asXML())) {
             $rawName = $this->raw->xpath('./ns1:mainHeadings/ns1:data/ns1:text');
             $name = (string) $rawName[0];
             $name = trim(trim(trim($name), ','), '.');
             return $name;
         } else {
             $this->logger->warning('No name found for given VIAF URL');
-            return false;
+            return FALSE;
         }
     }
 
@@ -131,9 +131,9 @@ 
     private function getRaw(): void
     {
         $data = $this->client->getData();
-        if ($data != false) {
+        if ($data != FALSE) {
             $this->raw = Helper::getXmlFileAsString($data);
-            if ($this->raw != false && !empty($this->raw->asXML())) {
+            if ($this->raw != FALSE && !empty($this->raw->asXML())) {
                 $this->raw->registerXPathNamespace('ns1', 'http://viaf.org/viaf/terms#');
             }
         }

Classes/Api/Orcid/Client.php

Spacing +4 added lines, -4 removed lines

@@ -111,7 +111,7 @@ 
         try {
             $response = $this->requestFactory->request($url);
         } catch (\Exception $e) {
-            $this->logger->warning('Could not fetch data from URL "' . $url . '". Error: ' . $e->getMessage() . '.');
+            $this->logger->warning('Could not fetch data from URL "'.$url.'". Error: '.$e->getMessage().'.');
             return false;
         }
         return $response->getBody()->getContents();
@@ -126,10 +126,10 @@ 
      **/
     private function getApiEndpoint(): string
     {
-        $url  = 'https://' . $this->level . '.' . self::HOSTNAME;
-        $url .= '/v' . self::VERSION . '/';
+        $url  = 'https://'.$this->level.'.'.self::HOSTNAME;
+        $url .= '/v'.self::VERSION.'/';
         $url .= $this->orcid;
-        $url .= '/' . $this->endpoint;
+        $url .= '/'.$this->endpoint;
         return $url;
     }
 }

Braces +3 added lines, -6 removed lines

@@ -26,8 +26,7 @@ 
  *
  * @access public
  **/
-class Client
-{
+class Client {
     /**
      * @var string constant for API hostname
      **/
@@ -78,8 +77,7 @@ 
      *
      * @return void
      **/
-    public function __construct(string $orcid, RequestFactory $requestFactory)
-    {
+    public function __construct(string $orcid, RequestFactory $requestFactory) {
         $this->logger = GeneralUtility::makeInstance(LogManager::class)->getLogger(static::class);
         $this->orcid = $orcid;
         $this->requestFactory = $requestFactory;
@@ -105,8 +103,7 @@ 
      *
      * @return object|bool
      **/
-    public function getData()
-    {
+    public function getData() {
         $url = $this->getApiEndpoint();
         try {
             $response = $this->requestFactory->request($url);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
             $response = $this->requestFactory->request($url);
         } catch (\Exception $e) {
             $this->logger->warning('Could not fetch data from URL "' . $url . '". Error: ' . $e->getMessage() . '.');
-            return false;
+            return FALSE;
         }
         return $response->getBody()->getContents();
     }

Classes/ViewHelpers/StdWrapViewHelper.php

Braces +1 added lines, -2 removed lines

@@ -23,8 +23,7 @@
  *
  * @access public
  */
-class StdWrapViewHelper extends AbstractViewHelper
-{
+class StdWrapViewHelper extends AbstractViewHelper {
     /**
      * @access protected
      * @var bool

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -29,7 +29,7 @@ 
      * @access protected
      * @var bool
      */
-    protected $escapeOutput = false;
+    protected $escapeOutput = FALSE;
 
     /**
      * Initializes arguments.
@@ -41,8 +41,8 @@ 
     public function initializeArguments(): void
     {
         parent::initializeArguments();
-        $this->registerArgument('wrap', 'string', 'The wrap information', true);
-        $this->registerArgument('data', 'array', 'Data for the content object', false);
+        $this->registerArgument('wrap', 'string', 'The wrap information', TRUE);
+        $this->registerArgument('data', 'array', 'Data for the content object', FALSE);
     }
 
     /**

Classes/ViewHelpers/MetadataWrapVariableViewHelper.php

Braces +1 added lines, -2 removed lines

@@ -39,8 +39,7 @@
  *
  * @access public
  */
-class MetadataWrapVariableViewHelper extends AbstractViewHelper
-{
+class MetadataWrapVariableViewHelper extends AbstractViewHelper {
     /**
      * @access public
      *

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
      */
     public function initializeArguments(): void
     {
-        $this->registerArgument('name', 'string', 'Name of variable to create', true);
+        $this->registerArgument('name', 'string', 'Name of variable to create', TRUE);
     }
 
     /**

Classes/ViewHelpers/JsFooterViewHelper.php

Braces +1 added lines, -2 removed lines

@@ -25,8 +25,7 @@
  *
  * @access public
  */
-class JsFooterViewHelper extends AbstractViewHelper
-{
+class JsFooterViewHelper extends AbstractViewHelper {
     /**
      * Initialize arguments.
      *

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     public function initializeArguments(): void
     {
         parent::initializeArguments();
-        $this->registerArgument('inlineCode', 'string', 'Inline JavaScript', true);
+        $this->registerArgument('inlineCode', 'string', 'Inline JavaScript', TRUE);
     }
 
     /**