Passed
Pull Request — master (#123)
by
unknown
03:57
created
Classes/Controller/ListViewController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         // extract collection(s) from collection parameter
83 83
         $collections = [];
84 84
         if ($this->searchParams['collection']) {
85
-            foreach(explode(',', $this->searchParams['collection']) as $collectionEntry) {
85
+            foreach (explode(',', $this->searchParams['collection']) as $collectionEntry) {
86 86
                 $collections[] = $this->collectionRepository->findByUid((int) $collectionEntry);
87 87
             }
88 88
         }
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
             $simplePagination = new SimplePagination($solrPaginator);
114 114
 
115 115
             $pagination = $this->buildSimplePagination($simplePagination, $solrPaginator);
116
-            $this->view->assignMultiple([ 'pagination' => $pagination, 'paginator' => $solrPaginator ]);
116
+            $this->view->assignMultiple(['pagination' => $pagination, 'paginator' => $solrPaginator]);
117 117
         }
118 118
 
119 119
         $this->view->assign('viewData', $this->viewData);
Please login to merge, or discard this patch.
Classes/Controller/NavigationController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@
 block discarded – undo
104 104
         $pageOptions = [];
105 105
         for ($i = 1; $i <= $this->document->getCurrentDocument()->numPages; $i++) {
106 106
             $orderLabel = $this->document->getCurrentDocument()->physicalStructureInfo[$this->document->getCurrentDocument()->physicalStructure[$i]]['orderlabel'];
107
-            $pageOptions[$i] = '[' . $i . ']' . ($orderLabel ? ' - ' . htmlspecialchars($orderLabel) : '');
107
+            $pageOptions[$i] = '['.$i.']'.($orderLabel ? ' - '.htmlspecialchars($orderLabel) : '');
108 108
         }
109 109
         $this->view->assign('pageOptions', $pageOptions);
110 110
 
Please login to merge, or discard this patch.
Classes/Controller/PageGridController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
         $pageGridPagination = new PageGridPagination($pageGridPaginator);
69 69
 
70 70
         $pagination = $this->buildSimplePagination($pageGridPagination, $pageGridPaginator);
71
-        $this->view->assignMultiple([ 'pagination' => $pagination, 'paginator' => $pageGridPaginator ]);
71
+        $this->view->assignMultiple(['pagination' => $pagination, 'paginator' => $pageGridPaginator]);
72 72
 
73 73
         $this->view->assign('docUid', $this->requestData['id']);
74 74
     }
Please login to merge, or discard this patch.
Classes/Controller/MetadataController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
         }
136 136
         // @phpstan-ignore-next-line
137 137
         if (!$metadata) {
138
-            $this->logger->warning('No metadata found for document with UID ' . $this->document->getUid());
138
+            $this->logger->warning('No metadata found for document with UID '.$this->document->getUid());
139 139
             return;
140 140
         }
141 141
         ksort($metadata);
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
                     $this->parseMetadata($i, $name, $value, $metadata);
174 174
 
175 175
                     if (is_array($metadata[$i][$name])) {
176
-                        $metadata[$i][$name] = array_values(array_filter($metadata[$i][$name], function ($metadataValue) {
176
+                        $metadata[$i][$name] = array_values(array_filter($metadata[$i][$name], function($metadataValue) {
177 177
                             return !empty($metadataValue);
178 178
                         }));
179 179
                     }
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
         if (empty(implode('', $value)) && $this->settings['getTitle'] && $this->document->getPartof()) {
391 391
             $superiorTitle = AbstractDocument::getTitle($this->document->getPartof(), true);
392 392
             if (!empty($superiorTitle)) {
393
-                $metadata[$i]['title'] = ['[' . $superiorTitle . ']'];
393
+                $metadata[$i]['title'] = ['['.$superiorTitle.']'];
394 394
             }
395 395
         }
396 396
     }
Please login to merge, or discard this patch.
Classes/Controller/TableOfContentsController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
                 }
198 198
             }
199 199
             // Append "IFSUB" to "ITEM_STATE" if this entry has sub-entries.
200
-            $entryArray['ITEM_STATE'] = ($entryArray['ITEM_STATE'] == 'NO' ? 'IFSUB' : $entryArray['ITEM_STATE'] . 'IFSUB');
200
+            $entryArray['ITEM_STATE'] = ($entryArray['ITEM_STATE'] == 'NO' ? 'IFSUB' : $entryArray['ITEM_STATE'].'IFSUB');
201 201
         }
202 202
         return $entryArray;
203 203
     }
@@ -309,9 +309,9 @@  discard block
 block discarded – undo
309 309
                     $title = '';
310 310
                     foreach ($fields as $field) {
311 311
                         if ($field == 'type') {
312
-                            $title .= $this->getTranslatedType($entry['type']) . ' ';
312
+                            $title .= $this->getTranslatedType($entry['type']).' ';
313 313
                         } else {
314
-                            $title .= $entry[$field] . ' ';
314
+                            $title .= $entry[$field].' ';
315 315
                         }
316 316
                     }
317 317
         
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
                 }
320 320
             }
321 321
         }
322
-        return $entry['label'] ?: $entry['orderlabel'];
322
+        return $entry['label'] ? : $entry['orderlabel'];
323 323
     }
324 324
 
325 325
     /**
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
      */
353 353
     private function sortSubMenu(array &$menu): void
354 354
     {
355
-        usort($menu[0]['_SUB_MENU'], function ($firstElement, $secondElement) {
355
+        usort($menu[0]['_SUB_MENU'], function($firstElement, $secondElement) {
356 356
             if (!empty($firstElement['orderlabel'])) {
357 357
                 return $firstElement['orderlabel'] <=> $secondElement['orderlabel'];
358 358
             }
Please login to merge, or discard this patch.
Classes/Controller/FeedsController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
         if ($library) {
76 76
             $feedMeta['copyright'] = $library->getLabel();
77 77
         } else {
78
-            $this->logger->error('Failed to fetch label of selected library with "' . $this->settings['library'] . '"');
78
+            $this->logger->error('Failed to fetch label of selected library with "'.$this->settings['library'].'"');
79 79
         }
80 80
 
81 81
         if (
@@ -95,12 +95,12 @@  discard block
 block discarded – undo
95 95
                 ) {
96 96
                     $superiorTitle = AbstractDocument::getTitle($document->getPartof(), true);
97 97
                     if (!empty($superiorTitle)) {
98
-                        $title .= '[' . $superiorTitle . ']';
98
+                        $title .= '['.$superiorTitle.']';
99 99
                     }
100 100
                 }
101 101
                 // Get title of document.
102 102
                 if (!empty($document->getTitle())) {
103
-                    $title .= ' ' . $document->getTitle();
103
+                    $title .= ' '.$document->getTitle();
104 104
                 }
105 105
                 // Set default title if empty.
106 106
                 if (empty($title)) {
@@ -108,13 +108,13 @@  discard block
 block discarded – undo
108 108
                 }
109 109
                 // Append volume information.
110 110
                 if (!empty($document->getVolume())) {
111
-                    $title .= ', ' . LocalizationUtility::translate('volume', 'dlf') . ' ' . $document->getVolume();
111
+                    $title .= ', '.LocalizationUtility::translate('volume', 'dlf').' '.$document->getVolume();
112 112
                 }
113 113
                 // Is this document new or updated?
114 114
                 if ($document->getCrdate() == $document->getTstamp()) {
115
-                    $title = LocalizationUtility::translate('plugins.feeds.new', 'dlf') . ' ' . trim($title);
115
+                    $title = LocalizationUtility::translate('plugins.feeds.new', 'dlf').' '.trim($title);
116 116
                 } else {
117
-                    $title = LocalizationUtility::translate('plugins.feeds.update', 'dlf') . ' ' . trim($title);
117
+                    $title = LocalizationUtility::translate('plugins.feeds.update', 'dlf').' '.trim($title);
118 118
                 }
119 119
 
120 120
                 $document->setTitle($title);
Please login to merge, or discard this patch.
Classes/Controller/ToolboxController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
                         $this->renderToolByName('renderSearchInDocumentTool');
100 100
                         break;
101 101
                     default:
102
-                        $this->logger->warning('Incorrect tool configuration: "' . $this->settings['tools'] . '". Tool "' . $tool . '" does not exist.');
102
+                        $this->logger->warning('Incorrect tool configuration: "'.$this->settings['tools'].'". Tool "'.$tool.'" does not exist.');
103 103
                 }
104 104
             }
105 105
         }
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
                 }
263 263
                 break;
264 264
             } else {
265
-                $this->logger->warning('File not found in fileGrp "' . $fileGrp . '"');
265
+                $this->logger->warning('File not found in fileGrp "'.$fileGrp.'"');
266 266
             }
267 267
         }
268 268
         return $image;
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
             empty($firstPageLink)
347 347
             && empty($secondPageLink)
348 348
         ) {
349
-            $this->logger->warning('File not found in fileGrps "' . $this->extConf['fileGrpDownload'] . '"');
349
+            $this->logger->warning('File not found in fileGrps "'.$this->extConf['fileGrpDownload'].'"');
350 350
         }
351 351
 
352 352
         if (!empty($firstPageLink)) {
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
             }
385 385
         }
386 386
         if (empty($workLink)) {
387
-            $this->logger->warning('File not found in fileGrps "' . $this->extConf['fileGrpDownload'] . '"');
387
+            $this->logger->warning('File not found in fileGrps "'.$this->extConf['fileGrpDownload'].'"');
388 388
         }
389 389
         return $workLink;
390 390
     }
Please login to merge, or discard this patch.
Classes/Controller/PageViewController.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -119,11 +119,11 @@  discard block
 block discarded – undo
119 119
                 $fulltext['mimetype'] = $file['mimeType'];
120 120
                 break;
121 121
             } else {
122
-                $this->logger->notice('No full-text file found for page "' . $page . '" in fileGrp "' . $fileGrpFulltext . '"');
122
+                $this->logger->notice('No full-text file found for page "'.$page.'" in fileGrp "'.$fileGrpFulltext.'"');
123 123
             }
124 124
         }
125 125
         if (empty($fulltext)) {
126
-            $this->logger->notice('No full-text file found for page "' . $page . '" in fileGrps "' . $this->extConf['fileGrpFulltext'] . '"');
126
+            $this->logger->notice('No full-text file found for page "'.$page.'" in fileGrps "'.$this->extConf['fileGrpFulltext'].'"');
127 127
         }
128 128
         return $fulltext;
129 129
     }
@@ -141,13 +141,13 @@  discard block
 block discarded – undo
141 141
         $viewerConfiguration = '$(document).ready(function() {
142 142
                 if (dlfUtils.exists(dlfViewer)) {
143 143
                     tx_dlf_viewer = new dlfViewer({
144
-                        controls: ["' . implode('", "', $this->controls) . '"],
145
-                        div: "' . $this->settings['elementId'] . '",
146
-                        progressElementId: "' . $this->settings['progressElementId'] . '",
147
-                        images: ' . json_encode($this->images) . ',
148
-                        fulltexts: ' . json_encode($this->fulltexts) . ',
149
-                        annotationContainers: ' . json_encode($this->annotationContainers) . ',
150
-                        useInternalProxy: ' . ($this->settings['useInternalProxy'] ? 1 : 0) . '
144
+                        controls: ["' . implode('", "', $this->controls).'"],
145
+                        div: "' . $this->settings['elementId'].'",
146
+                        progressElementId: "' . $this->settings['progressElementId'].'",
147
+                        images: ' . json_encode($this->images).',
148
+                        fulltexts: ' . json_encode($this->fulltexts).',
149
+                        annotationContainers: ' . json_encode($this->annotationContainers).',
150
+                        useInternalProxy: ' . ($this->settings['useInternalProxy'] ? 1 : 0).'
151 151
                     });
152 152
                 }
153 153
             });';
@@ -240,11 +240,11 @@  discard block
 block discarded – undo
240 240
                 }
241 241
                 break;
242 242
             } else {
243
-                $this->logger->notice('No image file found for page "' . $page . '" in fileGrp "' . $fileGrpImages . '"');
243
+                $this->logger->notice('No image file found for page "'.$page.'" in fileGrp "'.$fileGrpImages.'"');
244 244
             }
245 245
         }
246 246
         if (empty($image)) {
247
-            $this->logger->warning('No image file found for page "' . $page . '" in fileGrps "' . $this->extConf['fileGrpImages'] . '"');
247
+            $this->logger->warning('No image file found for page "'.$page.'" in fileGrps "'.$this->extConf['fileGrpImages'].'"');
248 248
         }
249 249
         return $image;
250 250
     }
Please login to merge, or discard this patch.
Classes/Controller/CalendarController.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -134,8 +134,8 @@  discard block
 block discarded – undo
134 134
         $this->view->assign('calendarData', $calendarData);
135 135
         $this->view->assign('documentId', $this->document->getUid());
136 136
         $this->view->assign('yearLinkTitle', $yearLinkTitle);
137
-        $this->view->assign('parentDocumentId', $this->document->getPartof() ?: $this->document->getCurrentDocument()->tableOfContents[0]['points']);
138
-        $this->view->assign('allYearDocTitle', $this->document->getCurrentDocument()->getTitle($this->document->getPartof()) ?: $this->document->getCurrentDocument()->tableOfContents[0]['label']);
137
+        $this->view->assign('parentDocumentId', $this->document->getPartof() ? : $this->document->getCurrentDocument()->tableOfContents[0]['points']);
138
+        $this->view->assign('allYearDocTitle', $this->document->getCurrentDocument()->getTitle($this->document->getPartof()) ? : $this->document->getCurrentDocument()->tableOfContents[0]['label']);
139 139
     }
140 140
 
141 141
     /**
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
         }
221 221
 
222 222
         $this->view->assign('documentId', $this->document->getUid());
223
-        $this->view->assign('allYearDocTitle', $this->document->getCurrentDocument()->getTitle((int) $this->document->getUid()) ?: $this->document->getCurrentDocument()->tableOfContents[0]['label']);
223
+        $this->view->assign('allYearDocTitle', $this->document->getCurrentDocument()->getTitle((int) $this->document->getUid()) ? : $this->document->getCurrentDocument()->tableOfContents[0]['label']);
224 224
     }
225 225
 
226 226
     /**
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
     protected function getCalendarYear(array &$calendarData, array $calendarIssuesByMonth, int $year, int $firstMonth = 1, int $lastMonth = 12): void
240 240
     {
241 241
         for ($i = $firstMonth; $i <= $lastMonth; $i++) {
242
-            $key = $year . '-' . $i;
242
+            $key = $year.'-'.$i;
243 243
 
244 244
             $calendarData[$key] = [
245 245
                 'DAYMON_NAME' => strftime('%a', strtotime('last Monday')),
@@ -249,16 +249,16 @@  discard block
 block discarded – undo
249 249
                 'DAYFRI_NAME' => strftime('%a', strtotime('last Friday')),
250 250
                 'DAYSAT_NAME' => strftime('%a', strtotime('last Saturday')),
251 251
                 'DAYSUN_NAME' => strftime('%a', strtotime('last Sunday')),
252
-                'MONTHNAME'  => strftime('%B', strtotime($year . '-' . $i . '-1')) . ' ' . $year,
252
+                'MONTHNAME'  => strftime('%B', strtotime($year.'-'.$i.'-1')).' '.$year,
253 253
                 'CALYEAR' => ($i == $firstMonth) ? $year : ''
254 254
             ];
255 255
 
256
-            $firstOfMonth = strtotime($year . '-' . $i . '-1');
256
+            $firstOfMonth = strtotime($year.'-'.$i.'-1');
257 257
             $lastOfMonth = strtotime('last day of', ($firstOfMonth));
258 258
             $firstOfMonthStart = strtotime('last Monday', $firstOfMonth);
259 259
             // There are never more than 6 weeks in a month.
260 260
             for ($j = 0; $j <= 5; $j++) {
261
-                $firstDayOfWeek = strtotime('+ ' . $j . ' Week', $firstOfMonthStart);
261
+                $firstDayOfWeek = strtotime('+ '.$j.' Week', $firstOfMonthStart);
262 262
 
263 263
                 $calendarData[$key]['week'][$j] = [
264 264
                     'DAYMON' => ['dayValue' => '&nbsp;'],
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
                 ];
272 272
                 // Every week has seven days. ;-)
273 273
                 for ($k = 0; $k <= 6; $k++) {
274
-                    $currentDayTime = strtotime('+ ' . $k . ' Day', $firstDayOfWeek);
274
+                    $currentDayTime = strtotime('+ '.$k.' Day', $firstDayOfWeek);
275 275
                     if (
276 276
                         $currentDayTime >= $firstOfMonth
277 277
                         && $currentDayTime <= $lastOfMonth
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
      */
343 343
     private function fillCalendar(array &$calendarData, int $currentDayTime, string $dayLinks, array $dayLinkDiv, int $firstDayOfWeek, int $k): void
344 344
     {
345
-        switch (strftime('%w', strtotime('+ ' . $k . ' Day', $firstDayOfWeek))) {
345
+        switch (strftime('%w', strtotime('+ '.$k.' Day', $firstDayOfWeek))) {
346 346
             case '0':
347 347
                 $this->fillDay($calendarData, $currentDayTime, 'DAYSUN', $dayLinks, $dayLinkDiv);
348 348
                 break;
@@ -446,7 +446,7 @@  discard block
 block discarded – undo
446 446
                 $_day = date('j', $dateTimestamp);
447 447
                 $issuesByYear[$_year][$_month][$_day][] = $issue;
448 448
             } else {
449
-                $this->logger->warning('Document with UID ' . $issue['uid'] . 'has no valid date of publication');
449
+                $this->logger->warning('Document with UID '.$issue['uid'].'has no valid date of publication');
450 450
             }
451 451
         }
452 452
         // Sort by years.
@@ -489,7 +489,7 @@  discard block
 block discarded – undo
489 489
             foreach ($year['children'] as $month) {
490 490
                 foreach ($month['children'] as $day) {
491 491
                     foreach ($day['children'] as $issue) {
492
-                        $title = $issue['label'] ?: $issue['orderlabel'];
492
+                        $title = $issue['label'] ? : $issue['orderlabel'];
493 493
                         if (strtotime($title) !== false) {
494 494
                             $title = strftime('%x', strtotime($title));
495 495
                         }
Please login to merge, or discard this patch.