Kitodo\Dlf\Common\Solr\Solr

Complexity

Total Complexity

64

Size/Duplication

Total Lines	664
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

22 Methods

Rating	Name	Duplication	Size	Complexity
B	createCore()	0	37	6
A	searchRaw()	0	23	3
A	magicGetService()	0	3	1
A	magicGetLimit()	0	3	1
A	__isset()	0	3	1
A	getNextCoreNumber()	0	9	2
A	__set()	0	10	3
A	magicGetNumberOfHits()	0	3	1
A	magicSetParams()	0	3	1
A	__get()	0	11	3
B	getInstance()	0	30	8
A	magicGetReady()	0	3	1
A	magicSetLimit()	0	3	1
B	__construct()	0	70	9
B	escapeQueryKeepField()	0	42	6
A	escapeQuery()	0	6	1
A	loadSolrConnectionInfo()	0	25	6
A	magicSetConfigPid()	0	3	1
A	magicGetCore()	0	3	1
A	getFields()	0	34	2
A	optimize()	0	23	4
A	suggestBuild()	0	12	2

<?php

/**
 * (c) Kitodo. Key to digital objects e.V. <contact@kitodo.org>
 *
 * This file is part of the Kitodo and TYPO3 projects.
 *
 * @license GNU General Public License version 3 or later.
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 */

namespace Kitodo\Dlf\Common\Solr;

use Kitodo\Dlf\Common\Helper;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use Solarium\Client;
use Solarium\Core\Client\Adapter\Http;
use Solarium\QueryType\Server\CoreAdmin\Result\StatusResult;
use TYPO3\CMS\Core\Cache\CacheManager;
use TYPO3\CMS\Core\Configuration\ExtensionConfiguration;
use TYPO3\CMS\Core\Database\ConnectionPool;
use TYPO3\CMS\Core\EventDispatcher\EventDispatcher;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use TYPO3\CMS\Core\Utility\MathUtility;

/**
 * Solr class for the 'dlf' extension
 *
 * @package TYPO3
 * @subpackage dlf
 *
 * @access public
 *
 * @property array $config this holds the Solr configuration
 * @property-read string|null $core this holds the core name for the current instance
 * @property-write int $configPid this holds the PID for the configuration
 * @property int $limit this holds the max results
 * @property-read int $numberOfHits this holds the number of hits for last search
 * @property-write array $params this holds the additional query parameters
 * @property-read bool $ready flag if the Solr service is instantiated successfully
 * @property-read Client $service this holds the Solr service object
 */
class Solr implements LoggerAwareInterface
{
    use LoggerAwareTrait;

    /**
     * @access protected
     * @var array This holds the Solr configuration
     */
    protected array $config = [];

    /**
     * @access protected
     * @var string|null This holds the core name
     */
    protected ?string $core = null;

    /**
     * @access protected
     * @var int This holds the PID for the configuration
     */
    protected int $configPid = 0;

    /**
     * @access public
     * @static
     * @var string The extension key
     */
    public static string $extKey = 'dlf';

    /**
     * @access public
     * @static
     * @var array The fields for SOLR index
     */
    public static array $fields = [];

    /**
     * @access protected
     * @var int This holds the max results
     */
    protected int $limit = 50000;

    /**
     * @access protected
     * @var int This holds the number of hits for last search
     */
    protected int $numberOfHits = 0;

    /**
     * @access protected
     * @var array This holds the additional query parameters
     */
    protected array $params = [];

    /**
     * @access protected
     * @var bool Is the search instantiated successfully?
     */
    protected bool $ready = false;

    /**
     * @access protected
     * @var array(Solr) This holds the singleton search objects with their core as array key
     */
    protected static array $registry = [];

    /**
     * @access protected
     * @var Client This holds the Solr service object
     */
    protected Client $service;

    /**
     * Add a new core to Apache Solr
     *
     * @access public
     *
     * @param string $core The name of the new core. If empty, the next available core name is used.
     *
     * @return string The name of the new core
     */
    public static function createCore($core = ''): string
    {
        // Get next available core name if none given.
        if (empty($core)) {
            $core = 'dlfCore' . self::getNextCoreNumber();
        }
        // Get Solr service instance.
        $solr = self::getInstance($core);
        // Create new core if core with given name doesn't exist.
        if ($solr->ready) {
            // Core already exists.
            return $core;
        } else {
            // Core doesn't exist yet.
            $solrAdmin = self::getInstance();
            if ($solrAdmin->ready) {
                $query = $solrAdmin->service->createCoreAdmin();
                $action = $query->createCreate();
                $action->setConfigSet('dlf');
                $action->setCore($core);
                $action->setDataDir('data');
                $action->setInstanceDir($core);
                $query->setAction($action);
                try {
                    $response = $solrAdmin->service->coreAdmin($query);
                    if ($response->getWasSuccessful()) {
                        // Core successfully created.
                        return $core;
                    }
                } catch (\Exception $e) {
                    // Nothing to do here.
                }
            } else {
                Helper::log('Apache Solr not available', LOG_SEVERITY_ERROR);
            }
        }
        return '';
    }

    /**
     * Escape special characters in a query string
     *
     * @access public
     *
     * @param string $query The query string
     *
     * @return string The escaped query string
     */
    public static function escapeQuery(string $query): string
    {
        // Escape query by disallowing range and field operators
        // Permit operators: wildcard, boolean, fuzzy, proximity, boost, grouping
        // https://solr.apache.org/guide/solr/latest/query-guide/standard-query-parser.html
        return preg_replace('/(\{|}|\[|]|:|\/|\\\)/', '\\\$1', $query);
    }

    /**
     * Escape all special characters in a query string while retaining valid field queries
     *
     * @access public
     *
     * @param string $query The query string
     * @param int $pid The PID for the field configuration
     *
     * @return string The escaped query string
     */
    public static function escapeQueryKeepField(string $query, int $pid): string
    {
        // Is there a field query?
        if (preg_match('/^[[:alnum:]]+_[tu][su]i:\(?.*\)?$/', $query)) {
            $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
                ->getQueryBuilderForTable('tx_dlf_metadata');

            // Get all indexed fields.
            $fields = [];
            $result = $queryBuilder
                ->select(
                    'tx_dlf_metadata.index_name AS index_name',
                    'tx_dlf_metadata.index_tokenized AS index_tokenized',
                    'tx_dlf_metadata.index_stored AS index_stored'
                )
                ->from('tx_dlf_metadata')
                ->where(
                    $queryBuilder->expr()->eq('tx_dlf_metadata.index_indexed', 1),
                    $queryBuilder->expr()->eq('tx_dlf_metadata.pid', (int) $pid),
                    $queryBuilder->expr()->orX(
                        $queryBuilder->expr()->in('tx_dlf_metadata.sys_language_uid', [-1, 0]),
                        $queryBuilder->expr()->eq('tx_dlf_metadata.l18n_parent', 0)
                    ),
                    Helper::whereExpression('tx_dlf_metadata')
                )
                ->execute();

            while ($resArray = $result->fetchAssociative()) {
                $fields[] = $resArray['index_name'] . '_' . ($resArray['index_tokenized'] ? 't' : 'u') . ($resArray['index_stored'] ? 's' : 'u') . 'i';
            }

            // Check if queried field is valid.
            $splitQuery = explode(':', $query, 2);
            if (in_array($splitQuery[0], $fields)) {
                $query = $splitQuery[0] . ':(' . self::escapeQuery(trim($splitQuery[1], '()')) . ')';
            } else {
                $query = self::escapeQuery($query);
            }
        } else {
            $query = self::escapeQuery($query);
        }
        return $query;
    }

    /**
     * Get fields for index.
     *
     * @access public
     *
     * @return array fields
     */
    public static function getFields(): array
    {
        if (empty(self::$fields)) {
            $conf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get(self::$extKey, 'solr');
            $solrFields = $conf['fields'];
            self::$fields['id'] = $solrFields['id'];
            self::$fields['uid'] = $solrFields['uid'];
            self::$fields['pid'] = $solrFields['pid'];
            self::$fields['page'] = $solrFields['page'];
            self::$fields['partof'] = $solrFields['partof'];
            self::$fields['root'] = $solrFields['root'];
            self::$fields['sid'] = $solrFields['sid'];
            self::$fields['toplevel'] = $solrFields['toplevel'];
            self::$fields['type'] = $solrFields['type'];
            self::$fields['title'] = $solrFields['title'];
            self::$fields['volume'] = $solrFields['volume'];
            self::$fields['date'] = $solrFields['date'];
            self::$fields['thumbnail'] = $solrFields['thumbnail'];
            self::$fields['default'] = $solrFields['default'];
            self::$fields['timestamp'] = $solrFields['timestamp'];
            self::$fields['autocomplete'] = $solrFields['autocomplete'];
            self::$fields['fulltext'] = $solrFields['fulltext'];
            self::$fields['record_id'] = $solrFields['recordId'];
            self::$fields['purl'] = $solrFields['purl'];
            self::$fields['urn'] = $solrFields['urn'];
            self::$fields['location'] = $solrFields['location'];
            self::$fields['collection'] = $solrFields['collection'];
            self::$fields['license'] = $solrFields['license'];
            self::$fields['terms'] = $solrFields['terms'];
            self::$fields['restrictions'] = $solrFields['restrictions'];
            self::$fields['geom'] = $solrFields['geom'];
        }

        return self::$fields;
    }

    /**
     * This is a singleton class, thus instances must be created by this method
     *
     * @access public
     *
     * @param mixed $core Name or UID of the core to load or null to get core admin endpoint
     *
     * @return Solr Instance of this class
     */
    public static function getInstance($core = null): Solr
    {
        // Get core name if UID is given.
        if (MathUtility::canBeInterpretedAsInteger($core)) {
            $core = Helper::getIndexNameFromUid($core, 'tx_dlf_solrcores');

It seems like $core can also be of type null; however, parameter $uid of Kitodo\Dlf\Common\Helper::getIndexNameFromUid() does only seem to accept integer, maybe add an additional type check?

        }
        // Check if core is set or null.
        if (
            empty($core)
            && $core !== null

The condition $core !== null is always false.

        ) {
            Helper::log('Invalid core UID or name given for Apache Solr', LOG_SEVERITY_ERROR);
        }
        if (!empty($core)) {
            // Check if there is an instance in the registry already.
            if (
                array_key_exists($core, self::$registry)
                && self::$registry[$core] instanceof self
            ) {
                // Return singleton instance if available.
                return self::$registry[$core];
            }
        }
        // Create new instance...
        $instance = new self($core);
        // ...and save it to registry.
        if (!empty($instance->core)) {
            self::$registry[$instance->core] = $instance;
        }
        return $instance;
    }

    /**
     * Get next unused Solr core number
     *
     * @access public
     *
     * @param int $number Number to start with
     *
     * @return int First unused core number found
     */
    public static function getNextCoreNumber(int $number = 0): int
    {
        $number = max($number, 0);
        // Check if core already exists.
        $solr = self::getInstance('dlfCore' . $number);
        if (!$solr->ready) {
            return $number;
        } else {
            return self::getNextCoreNumber($number + 1);
        }
    }

    /**
     * Sets the connection information for Solr
     *
     * @access protected
     *
     * @return void
     */
    protected function loadSolrConnectionInfo(): void
    {
        if (empty($this->config)) {
            $config = [];
            // Extract extension configuration.
            $conf = GeneralUtility::makeInstance(ExtensionConfiguration::class)->get(self::$extKey, 'solr');
            // Derive Solr scheme
            $config['scheme'] = empty($conf['https']) ? 'http' : 'https';
            // Derive Solr host name.
            $config['host'] = ($conf['host'] ? $conf['host'] : '127.0.0.1');
            // Set username and password.
            $config['username'] = $conf['user'];
            $config['password'] = $conf['pass'];
            // Set port if not set.
            $config['port'] = MathUtility::forceIntegerInRange($conf['port'], 1, 65535, 8983);
            // Trim path of slashes and (re-)add trailing slash if path not empty.
            $config['path'] = trim($conf['path'], '/');
            if (!empty($config['path'])) {
                $config['path'] .= '/';
            }

            // Set connection timeout lower than PHP's max_execution_time.
            $maxExecutionTime = (int) ini_get('max_execution_time') ? : 30;
            $config['timeout'] = MathUtility::forceIntegerInRange($conf['timeout'], 1, $maxExecutionTime, 10);
            $this->config = $config;
        }
    }

    /**
     * Processes a search request and returns the raw Apache Solr Documents.
     *
     * @access public
     *
     * @param array $parameters Additional search parameters
     *
     * @return array The Apache Solr Documents that were fetched
     */
    public function searchRaw(array $parameters = []): array
    {
        // Set additional query parameters.
        $parameters['start'] = 0;
        $parameters['rows'] = $this->limit;
        // Calculate cache identifier.
        $cacheIdentifier = Helper::digest($this->core . print_r(array_merge($this->params, $parameters), true));

The property params is declared write-only in Kitodo\Dlf\Common\Solr\Solr.

Are you sure print_r(array_merge($this->params, $parameters), true) of type string|true can be used in concatenation?

        $cache = GeneralUtility::makeInstance(CacheManager::class)->getCache('tx_dlf_solr');
        $resultSet = [];
        $entry = $cache->get($cacheIdentifier);
        if ($entry === false) {
            $selectQuery = $this->service->createSelect(array_merge($this->params, $parameters));
            $result = $this->service->select($selectQuery);
            foreach ($result as $doc) {
                $resultSet[] = $doc;
            }
            // Save value in cache.
            $cache->set($cacheIdentifier, $resultSet);
        } else {
            // Return cache hit.
            $resultSet = $entry;
        }
        return $resultSet;
    }

    /**
     * This returns $this->core via __get()
     *
     * @access protected
     *
     * @return string|null The core name of the current query endpoint or null if core admin endpoint
     */
    protected function magicGetCore(): ?string
    {
        return $this->core;
    }

    /**
     * This returns $this->limit via __get()
     *
     * @access protected
     *
     * @return int The max number of results
     */
    protected function magicGetLimit(): int
    {
        return $this->limit;
    }

    /**
     * This returns $this->numberOfHits via __get()
     *
     * @access protected
     *
     * @return int Total number of hits for last search
     */
    protected function magicGetNumberOfHits(): int
    {
        return $this->numberOfHits;
    }

    /**
     * This returns $this->ready via __get()
     *
     * @access protected
     *
     * @return bool Is the search instantiated successfully?
     */
    protected function magicGetReady(): bool
    {
        return $this->ready;
    }

    /**
     * This returns $this->service via __get()
     *
     * @access protected
     *
     * @return Client Apache Solr service object
     */
    protected function magicGetService(): Client
    {
        return $this->service;
    }

    /**
     * This sets $this->configPid via __set()
     *
     * @access protected
     *
     * @param int $value The new PID for the metadata definitions
     *
     * @return void
     */
    protected function magicSetConfigPid(int $value): void
    {
        $this->configPid = max($value, 0);
    }

    /**
     * This sets $this->limit via __set()
     *
     * @access protected
     *
     * @param int $value The max number of results
     *
     * @return void
     */
    protected function magicSetLimit(int $value): void
    {
        $this->limit = max($value, 0);
    }

    /**
     * This sets $this->params via __set()
     *
     * @access protected
     *
     * @param array $value The query parameters
     *
     * @return void
     */
    protected function magicSetParams(array $value): void
    {
        $this->params = $value;
    }

    /**
     * This magic method is called each time an invisible property is referenced from the object
     *
     * @access public
     *
     * @param string $var Name of variable to get
     *
     * @return mixed Value of $this->$var
     */
    public function __get(string $var)
    {
        $method = 'magicGet' . ucfirst($var);
        if (
            !property_exists($this, $var)
            || !method_exists($this, $method)
        ) {
            $this->logger->warning('There is no getter function for property "' . $var . '"');

The method warning() does not exist on null.

            return null;
        } else {
            return $this->$method();
        }
    }

    /**
     * This magic method is called each time an invisible property is checked for isset() or empty()
     *
     * @access public
     *
     * @param string $var Name of variable to check
     *
     * @return bool true if variable is set and not empty, false otherwise
     */
    public function __isset(string $var): bool
    {
        return !empty($this->__get($var));
    }

    /**
     * This magic method is called each time an invisible property is referenced from the object
     *
     * @access public
     *
     * @param string $var Name of variable to set
     * @param mixed $value New value of variable
     *
     * @return void
     */
    public function __set(string $var, $value): void
    {
        $method = 'magicSet' . ucfirst($var);
        if (
            !property_exists($this, $var)
            || !method_exists($this, $method)
        ) {
            $this->logger->warning('There is no setter function for property "' . $var . '"');
        } else {
            $this->$method($value);
        }
    }

    /**
     * This is a singleton class, thus the constructor should be private/protected
     *
     * @access protected
     *
     * @param string|null $core The name of the core to use or null for core admin endpoint
     *
     * @return void
     */
    protected function __construct(?string $core)
    {
        // Solarium requires different code for version 5 and 6.
        $isSolarium5 = Client::checkExact('5');
        // Get Solr connection parameters from configuration.
        $this->loadSolrConnectionInfo();
        // Configure connection adapter.
        $adapter = GeneralUtility::makeInstance(Http::class);
        $adapter->setTimeout($this->config['timeout']);
        // Configure event dispatcher.
        if ($isSolarium5) {
            $eventDispatcher = null;
        } else {
            // When updating to TYPO3 >=10.x and Solarium >=6.x
            // we have to provide an PSR-14 Event Dispatcher instead of
            // "null".
            $eventDispatcher = GeneralUtility::makeInstance(EventDispatcher::class);
        }
        // Configure endpoint.
        $config = [
            'endpoint' => [
                'default' => [
                    'scheme' => $this->config['scheme'],
                    'host' => $this->config['host'],
                    'port' => $this->config['port'],
                    'path' => '/' . $this->config['path'],
                    'core' => $core,
                    'username' => $this->config['username'],
                    'password' => $this->config['password']
                ]
            ]
        ];
        // Instantiate Solarium\Client class.
        if ($isSolarium5) {
            $this->service = GeneralUtility::makeInstance(Client::class, $config);

The property service is declared read-only in Kitodo\Dlf\Common\Solr\Solr.

        } else {
            // When updating to TYPO3 >=10.x and Solarium >=6.x
            // $adapter and $eventDispatcher are mandatory arguments
            // of the \Solarium\Client constructor.
            $this->service = GeneralUtility::makeInstance(Client::class, $adapter, $eventDispatcher, $config);
        }
        $this->service->setAdapter($adapter);
        // Check if connection is established.
        $query = $this->service->createCoreAdmin();
        $action = $query->createStatus();
        if ($core !== null) {
            $action->setCore($core);
        }
        $query->setAction($action);
        try {
            $response = $this->service->coreAdmin($query);
            if ($response->getWasSuccessful()) {
                // Solr is reachable, but is the core as well?
                if ($core !== null) {
                    $result = $response->getStatusResult();
                    if (
                        $result instanceof StatusResult
                        && $result->getUptime() > 0
                    ) {
                        // Set core name.
                        $this->core = $core;

The property core is declared read-only in Kitodo\Dlf\Common\Solr\Solr.

                    } else {
                        // Core not available.
                        return;
                    }
                }
                // Instantiation successful!
                $this->ready = true;

The property ready is declared read-only in Kitodo\Dlf\Common\Solr\Solr.

            }
        } catch (\Exception $e) {
            // Nothing to do here.
        }
    }

    /**
     * Sends the commit and optimize command to the index.
     *
     * @access public
     *
     * @param bool $commit If true, the commit command is sent to the index
     * @param bool $optimize If true, the optimize command is sent to the index
     *
     * @return bool true if executing the command worked
     */
    public function optimize(bool $commit, bool $optimize): bool
    {
        // get an update query instance
        $update = $this->service->createUpdate();

        // commit the index
        if ($commit) {
            $update->addCommit(false);
        }

        // optimize the index
        if ($optimize) {
            $update->addOptimize(false);
        }

        // this executes the query and returns the result
        $result = $this->service->update($update);

        if ($result->getStatus()) {

The expression $result->getStatus() of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            return false;
        }

        return true;
    }

    /**
     * Sends the suggest.build=true command to the index.
     *
     * @access public
     *
     * @return bool true if executing the command worked
     */
    public function suggestBuild(): bool
    {
        $query = $this->service->createSuggester();
        $query->addParam('suggest.build', 'true');
        $query->setCount(0);
        $result = $this->service->execute($query);

        if ($result->getResponse()->getStatusCode() == 400) {
            return false;
        }

        return true;
    }
}