Erikmitk / kitodo-presentation

Classes/Controller/TableOfContentsController.php

Upper-Lower-Casing +13 added lines, -13 removed lines

@@ -51,7 +51,7 @@ 
         $this->filterParams = $this->getParametersSafely('filterParameter');
 
         // output is done by main action
-        $this->forward('main', null, null, ['filterParameter' => $this->filterParams]);
+        $this->forward('main', NULL, NULL, ['filterParameter' => $this->filterParams]);
     }
 
     /**
@@ -64,8 +64,8 @@ 
         // Load current document.
         $this->loadDocument($this->requestData);
         if (
-            $this->document === null
-            || $this->document->getDoc() === null
+            $this->document === NULL
+            || $this->document->getDoc() === NULL
         ) {
             // Quit without doing anything if required variables are not set.
             return;
@@ -127,12 +127,12 @@ 
             }
             // Go through table of contents and create all menu entries.
             foreach ($this->document->getDoc()->tableOfContents as $entry) {
-                $menuArray[] = $this->getMenuEntry($entry, true);
+                $menuArray[] = $this->getMenuEntry($entry, TRUE);
             }
         } else {
             // Go through table of contents and create top-level menu entries.
             foreach ($this->document->getDoc()->tableOfContents as $entry) {
-                $menuArray[] = $this->getMenuEntry($entry, false);
+                $menuArray[] = $this->getMenuEntry($entry, FALSE);
             }
             // Build table of contents from database.
             $result = $this->documentRepository->getTableOfContentsFromDb($this->document->getUid(), $this->document->getPid(), $this->settings);
@@ -151,7 +151,7 @@ 
                         'pagination' => '',
                         'targetUid' => $resArray['uid']
                     ];
-                    $menuArray[0]['_SUB_MENU'][] = $this->getMenuEntry($entry, false);
+                    $menuArray[0]['_SUB_MENU'][] = $this->getMenuEntry($entry, FALSE);
                 }
             }
         }
@@ -174,7 +174,7 @@ 
 
         // Go through table of contents and create all menu entries.
         foreach ($this->document->getDoc()->tableOfContents as $entry) {
-            $menuEntry = $this->getMenuEntryWithImage($entry, true);
+            $menuEntry = $this->getMenuEntryWithImage($entry, TRUE);
             if (!empty($menuEntry)) {
                 $menuArray[] = $menuEntry;
             }
@@ -192,7 +192,7 @@ 
      *
      * @return array HMENU array for menu entry
      */
-    protected function getMenuEntry(array $entry, $recursive = false)
+    protected function getMenuEntry(array $entry, $recursive = FALSE)
     {
         $entry = $this->resolveMenuEntry($entry);
 
@@ -250,7 +250,7 @@ 
         }
         // Build sub-menu if available and called recursively.
         if (
-            $recursive === true
+            $recursive === TRUE
             && !empty($entry['children'])
         ) {
             // Build sub-menu only if one of the following conditions apply:
@@ -268,7 +268,7 @@ 
                     if (in_array($child['id'], $this->activeEntries)) {
                         $entryArray['ITEM_STATE'] = 'ACT';
                     }
-                    $entryArray['_SUB_MENU'][] = $this->getMenuEntry($child, true);
+                    $entryArray['_SUB_MENU'][] = $this->getMenuEntry($child, TRUE);
                 }
             }
             // Append "IFSUB" to "ITEM_STATE" if this entry has sub-entries.
@@ -304,7 +304,7 @@ 
         return $entry;
     }
 
-    protected function getMenuEntryWithImage(array $entry, $recursive = false)
+    protected function getMenuEntryWithImage(array $entry, $recursive = FALSE)
     {
         $entryArray = [];
 
@@ -325,7 +325,7 @@ 
         $entryArray['doNotLinkIt'] = 1;
         $entryArray['ITEM_STATE'] = 'HEADER';
 
-        if ($entry['children'] === null) {
+        if ($entry['children'] === NULL) {
             $entryArray['description'] = $entry['description'];
             $id = $this->document->getDoc()->smLinks['l2p'][$entry['id']][0];
             $entryArray['image'] = $this->document->getDoc()->getFileLocation($this->document->getDoc()->physicalStructureInfo[$id]['files']['THUMBS']);
@@ -338,7 +338,7 @@ 
 
         // Build sub-menu if available and called recursively.
         if (
-            $recursive == true
+            $recursive == TRUE
             && !empty($entry['children'])
         ) {
             // Build sub-menu only if one of the following conditions apply:

Classes/Controller/MetadataController.php

Upper-Lower-Casing +9 added lines, -9 removed lines

@@ -80,8 +80,8 @@ 
         // Load current document.
         $this->loadDocument($this->requestData);
         if (
-            $this->document === null
-            || $this->document->getDoc() === null
+            $this->document === NULL
+            || $this->document->getDoc() === NULL
         ) {
             // Quit without doing anything if required variables are not set.
             return '';
@@ -130,7 +130,7 @@ 
      *
      * @return string The metadata array ready for output
      */
-    protected function printMetadata(array $metadataArray, $useOriginalIiifManifestMetadata = false)
+    protected function printMetadata(array $metadataArray, $useOriginalIiifManifestMetadata = FALSE)
     {
         if ($useOriginalIiifManifestMetadata) {
             $iiifData = [];
@@ -148,14 +148,14 @@ 
                             $iiifData[$key] = [
                                 'label' => $key,
                                 'value' => $group,
-                                'buildUrl' => true,
+                                'buildUrl' => TRUE,
                             ];
                         } else {
                             // Data output
                             $iiifData[$key] = [
                                 'label' => $key,
                                 'value' => $group,
-                                'buildUrl' => false,
+                                'buildUrl' => FALSE,
                             ];
                         }
                     } else {
@@ -172,18 +172,18 @@ 
                                 $iiifData[$key]['data'][] = [
                                     'label' => $nolabel ? '' : $label,
                                     'value' => $value,
-                                    'buildUrl' => true,
+                                    'buildUrl' => TRUE,
                                 ];
                             } else {
                                 $iiifData[$key]['data'][] = [
                                     'label' => $label,
                                     'value' => $value,
-                                    'buildUrl' => false,
+                                    'buildUrl' => FALSE,
                                 ];
                             }
                         }
                     }
-                    $this->view->assign('useIiif', true);
+                    $this->view->assign('useIiif', TRUE);
                     $this->view->assign('iiifData', $iiifData);
                 }
             }
@@ -213,7 +213,7 @@ 
                     if ($metadataName == 'title') {
                         // Get title of parent document if needed.
                         if (empty(implode('', $metadataValue)) && $this->settings['getTitle'] && $this->document->getPartof()) {
-                            $superiorTitle = Doc::getTitle($this->document->getPartof(), true);
+                            $superiorTitle = Doc::getTitle($this->document->getPartof(), TRUE);
                             if (!empty($superiorTitle)) {
                                 $metadataArray[$i][$metadataName] = ['[' . $superiorTitle . ']'];
                             }

Classes/Api/Orcid/Profile.php

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -48,7 +48,7 @@ 
      *
      * @var SimpleXmlElement
      **/
-    private $raw = null;
+    private $raw = NULL;
 
     /**
      * Constructs client instance
@@ -79,7 +79,7 @@ 
             return $data;
         } else {
             $this->logger->warning('No data found for given ORCID');
-            return false;
+            return FALSE;
         }
     }
 
@@ -96,7 +96,7 @@ 
             return (string) $this->raw->xpath('./address:address/address:country')[0];
         } else {
             $this->logger->warning('No address found for given ORCID');
-            return false;
+            return FALSE;
         }
     }
 
@@ -113,7 +113,7 @@ 
             return (string) $this->raw->xpath('./email:email/email:email')[0];
         } else {
             $this->logger->warning('No email found for given ORCID');
-            return false;
+            return FALSE;
         }
     }
 
@@ -132,7 +132,7 @@ 
             return (string) $givenNames[0] . ' ' . (string) $familyName[0];
         } else {
             $this->logger->warning('No name found for given ORCID');
-            return false;
+            return FALSE;
         }
     }
 
@@ -147,7 +147,7 @@ 
     {
         $this->client->setEndpoint($endpoint);
         $data = $this->client->getData();
-        if (!isset($this->raw) && $data != false) {
+        if (!isset($this->raw) && $data != FALSE) {
             $this->raw = Helper::getXmlFileAsString($data);
         }
     }

Classes/Api/Orcid/Client.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -60,14 +60,14 @@ 
      *
      * @var string
      **/
-    private $orcid = null;
+    private $orcid = NULL;
 
     /**
      * The request object
      *
      * @var RequestFactoryInterface
      **/
-    private $requestFactory = null;
+    private $requestFactory = NULL;
 
     /**
      * Constructs a new instance
@@ -102,7 +102,7 @@ 
             $response = $this->requestFactory->request($url);
         } catch (\Exception $e) {
             $this->logger->warning('Could not fetch data from URL "' . $url . '". Error: ' . $e->getMessage() . '.');
-            return false;
+            return FALSE;
         }
         return $response->getBody()->getContents();
     }

Classes/Controller/SearchController.php

Upper-Lower-Casing +11 added lines, -11 removed lines

@@ -77,7 +77,7 @@ 
         $this->searchParams = $this->getParametersSafely('searchParameter');
 
         // output is done by main action
-        $this->forward('main', null, null, ['searchParameter' => $this->searchParams]);
+        $this->forward('main', NULL, NULL, ['searchParameter' => $this->searchParams]);
     }
 
     /**
@@ -89,7 +89,7 @@ 
      */
     public function mainAction()
     {
-        $listViewSearch = false;
+        $listViewSearch = FALSE;
         // Quit without doing anything if required variables are not set.
         if (empty($this->settings['solrcore'])) {
             $this->logger->warning('Incomplete plugin configuration');
@@ -103,7 +103,7 @@ 
 
         if (isset($listRequestData['searchParameter']) && is_array($listRequestData['searchParameter'])) {
             $this->searchParams = array_merge($this->searchParams ? : [], $listRequestData['searchParameter']);
-            $listViewSearch = true;
+            $listViewSearch = TRUE;
         }
 
         // sanitize date search input
@@ -127,7 +127,7 @@ 
 
         // If a targetPid is given, the results will be shown by ListView on the target page.
         if (!empty($this->settings['targetPid']) && !empty($this->searchParams) && !$listViewSearch) {
-            $this->redirect('main', 'ListView', null,
+            $this->redirect('main', 'ListView', NULL,
                 [
                     'searchParameter' => $this->searchParams,
                     'widgetPage' => $widgetPage
@@ -138,16 +138,16 @@ 
         // If no search has been executed, no variables habe to be prepared. An empty form will be shown.
         if (is_array($this->searchParams) && !empty($this->searchParams)) {
             // get all sortable metadata records
-            $sortableMetadata = $this->metadataRepository->findByIsSortable(true);
+            $sortableMetadata = $this->metadataRepository->findByIsSortable(TRUE);
 
             // get all metadata records to be shown in results
-            $listedMetadata = $this->metadataRepository->findByIsListed(true);
+            $listedMetadata = $this->metadataRepository->findByIsListed(TRUE);
 
             $solrResults = [];
             $numResults = 0;
             // Do not execute the Solr search if used together with ListView plugin.
             if (!$listViewSearch) {
-                $solrResults = $this->documentRepository->findSolrByCollection(null, $this->settings, $this->searchParams, $listedMetadata);
+                $solrResults = $this->documentRepository->findSolrByCollection(NULL, $this->settings, $this->searchParams, $listedMetadata);
                 $numResults = $solrResults->getNumFound();
             }
 
@@ -196,7 +196,7 @@ 
 
         // Get facets from plugin configuration.
         $facets = [];
-        foreach (GeneralUtility::trimExplode(',', $this->settings['facets'], true) as $facet) {
+        foreach (GeneralUtility::trimExplode(',', $this->settings['facets'], TRUE) as $facet) {
             $facets[$facet . '_faceting'] = Helper::translate($facet, 'tx_dlf_metadata', $this->settings['storagePid']);
         }
 
@@ -404,7 +404,7 @@ 
         // Check if facet is already selected.
         $queryColumn = array_column($search['params']['filterquery'], 'query');
         $index = array_search($field . ':("' . Solr::escapeQuery($value) . '")', $queryColumn);
-        if ($index !== false) {
+        if ($index !== FALSE) {
             // Facet is selected, thus remove it from filter.
             unset($queryColumn[$index]);
             $queryColumn = array_values($queryColumn);
@@ -412,7 +412,7 @@ 
             $state = 'ACTIFSUB';
             // Reset facets
             if ($this->settings['resetFacets']) {
-                $entryArray['resetFacet'] = true;
+                $entryArray['resetFacet'] = TRUE;
                 $entryArray['queryColumn'] = $queryColumn;
             }
         } else {
@@ -443,7 +443,7 @@ 
         }
 
         // Get field selector options.
-        $searchFields = GeneralUtility::trimExplode(',', $this->settings['extendedFields'], true);
+        $searchFields = GeneralUtility::trimExplode(',', $this->settings['extendedFields'], TRUE);
 
         $slotCountArray = [];
         for ($i = 0; $i < $this->settings['extendedSlotCount']; $i++) {

Classes/Common/Indexer.php

Upper-Lower-Casing +24 added lines, -24 removed lines

@@ -66,7 +66,7 @@ 
      * @var bool
      * @access protected
      */
-    protected static $fieldsLoaded = false;
+    protected static $fieldsLoaded = FALSE;
 
     /**
      * List of already processed documents
@@ -96,9 +96,9 @@ 
     public static function add(Document $document)
     {
         if (in_array($document->getUid(), self::$processedDocs)) {
-            return true;
+            return TRUE;
         } elseif (self::solrConnect($document->getSolrcore(), $document->getPid())) {
-            $success = true;
+            $success = TRUE;
             Helper::getLanguageService()->includeLLFile('EXT:dlf/Resources/Private/Language/locallang_be.xlf');
             // Handle multi-volume documents.
             if ($parentId = $document->getPartof()) {
@@ -110,13 +110,13 @@ 
                 $parent = $documentRepository->findByUid($parentId);
                 if ($parent) {
                     // get XML document of parent
-                    $doc = Doc::getInstance($parent->getLocation(), ['storagePid' => $parent->getPid()], true);
-                    if ($doc !== null) {
+                    $doc = Doc::getInstance($parent->getLocation(), ['storagePid' => $parent->getPid()], TRUE);
+                    if ($doc !== NULL) {
                         $parent->setDoc($doc);
                         $success = self::add($parent);
                     } else {
                         Helper::log('Could not load parent document with UID ' . $document->getDoc()->parentId, LOG_SEVERITY_ERROR);
-                        return false;
+                        return FALSE;
                     }
                 }
             }
@@ -157,7 +157,7 @@ 
                             sprintf(Helper::getLanguageService()->getLL('flash.documentIndexed'), $document->getTitle(), $document->getUid()),
                             Helper::getLanguageService()->getLL('flash.done'),
                             FlashMessage::OK,
-                            true,
+                            TRUE,
                             'core.template.flashMessages'
                         );
                     } else {
@@ -165,7 +165,7 @@ 
                             sprintf(Helper::getLanguageService()->getLL('flash.documentNotIndexed'), $document->getTitle(), $document->getUid()),
                             Helper::getLanguageService()->getLL('flash.error'),
                             FlashMessage::ERROR,
-                            true,
+                            TRUE,
                             'core.template.flashMessages'
                         );
                     }
@@ -177,12 +177,12 @@ 
                         Helper::getLanguageService()->getLL('flash.solrException') . ' ' . htmlspecialchars($e->getMessage()),
                         Helper::getLanguageService()->getLL('flash.error'),
                         FlashMessage::ERROR,
-                        true,
+                        TRUE,
                         'core.template.flashMessages'
                     );
                 }
                 Helper::log('Apache Solr threw exception: "' . $e->getMessage() . '"', LOG_SEVERITY_ERROR);
-                return false;
+                return FALSE;
             }
         } else {
             if (!(\TYPO3_REQUESTTYPE & \TYPO3_REQUESTTYPE_CLI)) {
@@ -190,12 +190,12 @@ 
                     Helper::getLanguageService()->getLL('flash.solrNoConnection'),
                     Helper::getLanguageService()->getLL('flash.warning'),
                     FlashMessage::WARNING,
-                    true,
+                    TRUE,
                     'core.template.flashMessages'
                 );
             }
             Helper::log('Could not connect to Apache Solr server', LOG_SEVERITY_ERROR);
-            return false;
+            return FALSE;
         }
     }
 
@@ -290,10 +290,10 @@ 
                 if ($indexing['index_boost'] > 0.0) {
                     self::$fields['fieldboost'][$indexing['index_name']] = floatval($indexing['index_boost']);
                 } else {
-                    self::$fields['fieldboost'][$indexing['index_name']] = false;
+                    self::$fields['fieldboost'][$indexing['index_name']] = FALSE;
                 }
             }
-            self::$fieldsLoaded = true;
+            self::$fieldsLoaded = TRUE;
         }
     }
 
@@ -309,7 +309,7 @@ 
      */
     protected static function processLogical(Document $document, array $logicalUnit)
     {
-        $success = true;
+        $success = TRUE;
         $doc = $document->getDoc();
         $doc->cPid = $document->getPid();
         // Get metadata for logical unit.
@@ -333,7 +333,7 @@ 
                 $solrDoc->setField('thumbnail', $doc->getFileLocation($logicalUnit['thumbnailId']));
             }
             // There can be only one toplevel unit per UID, independently of backend configuration
-            $solrDoc->setField('toplevel', $logicalUnit['id'] == $doc->toplevelId ? true : false);
+            $solrDoc->setField('toplevel', $logicalUnit['id'] == $doc->toplevelId ? TRUE : FALSE);
             $solrDoc->setField('title', $metadata['title'][0], self::$fields['fieldboost']['title']);
             $solrDoc->setField('volume', $metadata['volume'][0], self::$fields['fieldboost']['volume']);
             // verify date formatting
@@ -406,12 +406,12 @@ 
                         Helper::getLanguageService()->getLL('flash.solrException') . '<br />' . htmlspecialchars($e->getMessage()),
                         Helper::getLanguageService()->getLL('flash.error'),
                         FlashMessage::ERROR,
-                        true,
+                        TRUE,
                         'core.template.flashMessages'
                     );
                 }
                 Helper::log('Apache Solr threw exception: "' . $e->getMessage() . '"', LOG_SEVERITY_ERROR);
-                return false;
+                return FALSE;
             }
         }
         // Check for child elements...
@@ -457,7 +457,7 @@ 
                     break;
                 }
             }
-            $solrDoc->setField('toplevel', false);
+            $solrDoc->setField('toplevel', FALSE);
             $solrDoc->setField('type', $physicalUnit['type'], self::$fields['fieldboost']['type']);
             $solrDoc->setField('collection', $doc->metadataArray[$doc->toplevelId]['collection']);
 
@@ -497,15 +497,15 @@ 
                         Helper::getLanguageService()->getLL('flash.solrException') . '<br />' . htmlspecialchars($e->getMessage()),
                         Helper::getLanguageService()->getLL('flash.error'),
                         FlashMessage::ERROR,
-                        true,
+                        TRUE,
                         'core.template.flashMessages'
                     );
                 }
                 Helper::log('Apache Solr threw exception: "' . $e->getMessage() . '"', LOG_SEVERITY_ERROR);
-                return false;
+                return FALSE;
             }
         }
-        return true;
+        return TRUE;
     }
 
     /**
@@ -531,10 +531,10 @@ 
                     self::loadIndexConf($pid);
                 }
             } else {
-                return false;
+                return FALSE;
             }
         }
-        return true;
+        return TRUE;
     }
 
     /**