Erikmitk / kitodo-presentation

Build/Documentation/dbdocs/RstSection.php

Spacing +8 added lines, -8 removed lines

@@ -35,9 +35,9 @@ 
     {
         if (!empty($text)) {
             if ($format['bold'] ?? false) {
-                $text = '**' . $text . '**';
+                $text = '**'.$text.'**';
             } elseif ($format['italic'] ?? false) {
-                $text = '*' . $text . '*';
+                $text = '*'.$text.'*';
             }
         }
 
@@ -46,7 +46,7 @@ 
 
     public static function paragraphs(array $paragraphs)
     {
-        $paragraphs = array_values(array_filter($paragraphs, function ($entry) {
+        $paragraphs = array_values(array_filter($paragraphs, function($entry) {
             return !empty($entry);
         }));
 
@@ -68,7 +68,7 @@ 
     public function addText(string $text)
     {
         if (!empty($text)) {
-            $this->text .= $text . "\n\n";
+            $this->text .= $text."\n\n";
         }
     }
 
@@ -97,10 +97,10 @@ 
                 $numLines = count($valueLines);
                 for ($i = 0; $i < $numLines; $i++) {
                     $prefix = $i === 0
-                        ? '     :' . $key . ':'
+                        ? '     :'.$key.':'
                         : '';
 
-                    $entry .= str_pad($prefix, 32) . trim($valueLines[$i]) . "\n";
+                    $entry .= str_pad($prefix, 32).trim($valueLines[$i])."\n";
                 }
             }
 
@@ -138,10 +138,10 @@ 
         $headerSep = str_repeat($headerChar, mb_strlen($this->header));
 
         if ($level === 0) {
-            $result .= $headerSep . "\n";
+            $result .= $headerSep."\n";
         }
 
-        $result .= $this->header . "\n" . $headerSep . "\n\n";
+        $result .= $this->header."\n".$headerSep."\n\n";
 
         return $result;
     }

Braces +9 added lines, -18 removed lines

@@ -20,8 +20,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class RstSection
-{
+class RstSection {
     /** @var string */
     protected $header = '';
 
@@ -31,8 +30,7 @@ 
     /** @var RstSection[] */
     protected $subsections = [];
 
-    public static function format(string $text, array $format = [])
-    {
+    public static function format(string $text, array $format = []) {
         if (!empty($text)) {
             if ($format['bold'] ?? false) {
                 $text = '**' . $text . '**';
@@ -44,8 +42,7 @@ 
         return $text;
     }
 
-    public static function paragraphs(array $paragraphs)
-    {
+    public static function paragraphs(array $paragraphs) {
         $paragraphs = array_values(array_filter($paragraphs, function ($entry) {
             return !empty($entry);
         }));
@@ -53,27 +50,23 @@ 
         return implode("\n\n", $paragraphs);
     }
 
-    public function subsection()
-    {
+    public function subsection() {
         $section = new static();
         $this->subsections[] = $section;
         return $section;
     }
 
-    public function setHeader(string $text)
-    {
+    public function setHeader(string $text) {
         $this->header = $text;
     }
 
-    public function addText(string $text)
-    {
+    public function addText(string $text) {
         if (!empty($text)) {
             $this->text .= $text . "\n\n";
         }
     }
 
-    public function addTable(array $rows, array $headerRows)
-    {
+    public function addTable(array $rows, array $headerRows) {
         $numHeaderRows = count($headerRows);
 
         $tableRst = <<<RST
@@ -115,8 +108,7 @@ 
         $this->addText($tableRst);
     }
 
-    public function render(int $level = 0)
-    {
+    public function render(int $level = 0) {
         $result = '';
 
         $result .= $this->renderHeader($level);
@@ -130,8 +122,7 @@ 
         return $result;
     }
 
-    protected function renderHeader(int $level)
-    {
+    protected function renderHeader(int $level) {
         $result = '';
 
         $headerChar = ['=', '=', '-', '~', '"'][$level];

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -34,9 +34,9 @@ 
     public static function format(string $text, array $format = [])
     {
         if (!empty($text)) {
-            if ($format['bold'] ?? false) {
+            if ($format['bold'] ?? FALSE) {
                 $text = '**' . $text . '**';
-            } elseif ($format['italic'] ?? false) {
+            } elseif ($format['italic'] ?? FALSE) {
                 $text = '*' . $text . '*';
             }
         }
@@ -81,7 +81,7 @@ 
    :header-rows: $numHeaderRows
 
 
-RST;
+rst;
 
         // Pattern for a row:
         //

Build/Documentation/dbdocs/generate.php

Spacing +4 added lines, -4 removed lines

@@ -11,16 +11,16 @@
  * LICENSE.txt file that was distributed with this source code.
  */
 
-$classLoader = require_once __DIR__ . '/../../../vendor/autoload.php';
+$classLoader = require_once __DIR__.'/../../../vendor/autoload.php';
 
 $outputPath = $argv[1] ?? null;
 if (empty($outputPath) || !is_writable(($outputPath))) {
-    echo 'Error: Output path not specified or not writable' . "\n";
+    echo 'Error: Output path not specified or not writable'."\n";
     exit(1);
 }
 
-putenv('TYPO3_PATH_ROOT=' . __DIR__ . '/public');
-putenv('TYPO3_PATH_APP=' . __DIR__);
+putenv('TYPO3_PATH_ROOT='.__DIR__.'/public');
+putenv('TYPO3_PATH_APP='.__DIR__);
 
 // For compatibility with TYPO v9
 define('PATH_thisScript', __FILE__);

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -13,7 +13,7 @@ 
 
 $classLoader = require_once __DIR__ . '/../../../vendor/autoload.php';
 
-$outputPath = $argv[1] ?? null;
+$outputPath = $argv[1] ?? NULL;
 if (empty($outputPath) || !is_writable(($outputPath))) {
     echo 'Error: Output path not specified or not writable' . "\n";
     exit(1);
@@ -27,7 +27,7 @@ 
 
 // For request types other than "FE", the configuration manager would try to access the database.
 \TYPO3\CMS\Core\Core\SystemEnvironmentBuilder::run(1, \TYPO3\CMS\Core\Core\SystemEnvironmentBuilder::REQUESTTYPE_FE);
-\TYPO3\CMS\Core\Core\Bootstrap::init($classLoader, false);
+\TYPO3\CMS\Core\Core\Bootstrap::init($classLoader, FALSE);
 
 $generator = new \Kitodo\DbDocs\Generator();
 $tables = $generator->collectTables();

Classes/ViewHelpers/MetadataWrapVariableViewHelper.php

Braces +2 added lines, -4 removed lines

@@ -35,13 +35,11 @@
  *     {typoscript -> kitodo:metadataWrapVariable(name: 'wrapInfo')}
  *
  */
-class MetadataWrapVariableViewHelper extends AbstractViewHelper
-{
+class MetadataWrapVariableViewHelper extends AbstractViewHelper {
     /**
      * @return void
      */
-    public function initializeArguments()
-    {
+    public function initializeArguments() {
         $this->registerArgument('name', 'string', 'Name of variable to create', true);
     }
 

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
      */
     public function initializeArguments()
     {
-        $this->registerArgument('name', 'string', 'Name of variable to create', true);
+        $this->registerArgument('name', 'string', 'Name of variable to create', TRUE);
     }
 
     /**

Classes/Controller/FeedsController.php

Spacing +6 added lines, -6 removed lines

@@ -71,7 +71,7 @@ 
         if ($library) {
             $feedMeta['copyright'] = $library->getLabel();
         } else {
-            $this->logger->error('Failed to fetch label of selected library with "' . $this->settings['library'] . '"');
+            $this->logger->error('Failed to fetch label of selected library with "'.$this->settings['library'].'"');
         }
 
         if (
@@ -91,12 +91,12 @@ 
                 ) {
                     $superiorTitle = Doc::getTitle($document->getPartof(), true);
                     if (!empty($superiorTitle)) {
-                        $title .= '[' . $superiorTitle . ']';
+                        $title .= '['.$superiorTitle.']';
                     }
                 }
                 // Get title of document.
                 if (!empty($document->getTitle())) {
-                    $title .= ' ' . $document->getTitle();
+                    $title .= ' '.$document->getTitle();
                 }
                 // Set default title if empty.
                 if (empty($title)) {
@@ -104,13 +104,13 @@ 
                 }
                 // Append volume information.
                 if (!empty($document->getVolume())) {
-                    $title .= ', ' . LocalizationUtility::translate('volume', 'dlf') . ' ' . $document->getVolume();
+                    $title .= ', '.LocalizationUtility::translate('volume', 'dlf').' '.$document->getVolume();
                 }
                 // Is this document new or updated?
                 if ($document->getCrdate() == $document->getTstamp()) {
-                    $title = LocalizationUtility::translate('plugins.feeds.new', 'dlf') . ' ' . trim($title);
+                    $title = LocalizationUtility::translate('plugins.feeds.new', 'dlf').' '.trim($title);
                 } else {
-                    $title = LocalizationUtility::translate('plugins.feeds.update', 'dlf') . ' ' . trim($title);
+                    $title = LocalizationUtility::translate('plugins.feeds.update', 'dlf').' '.trim($title);
                 }
 
                 $document->setTitle($title);

Braces +4 added lines, -8 removed lines

@@ -25,8 +25,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class FeedsController extends AbstractController
-{
+class FeedsController extends AbstractController {
 
     /**
      * @var LibraryRepository
@@ -36,8 +35,7 @@ 
     /**
      * @param LibraryRepository $libraryRepository
      */
-    public function injectLibraryRepository(LibraryRepository $libraryRepository)
-    {
+    public function injectLibraryRepository(LibraryRepository $libraryRepository) {
         $this->libraryRepository = $libraryRepository;
     }
 
@@ -46,8 +44,7 @@ 
      *
      * @return void
      */
-    public function initializeAction()
-    {
+    public function initializeAction() {
         $this->request->setFormat('xml');
     }
 
@@ -56,8 +53,7 @@ 
      *
      * @return void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         // access to GET parameter tx_dlf_feeds['collection']
         $requestData = $this->request->getArguments();
 

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -80,7 +80,7 @@ 
             || GeneralUtility::inList($this->settings['collections'], $requestData['collection'])
         ) {
 
-            $documents = $this->documentRepository->findAllByCollectionsLimited(GeneralUtility::intExplode(',', $requestData['collection'], true), $this->settings['limit']);
+            $documents = $this->documentRepository->findAllByCollectionsLimited(GeneralUtility::intExplode(',', $requestData['collection'], TRUE), $this->settings['limit']);
 
             foreach ($documents as $document) {
 
@@ -89,7 +89,7 @@ 
                 if ((empty($document->getTitle()) || !empty($this->settings['prependSuperiorTitle']))
                     && !empty($document->getPartof())
                 ) {
-                    $superiorTitle = Doc::getTitle($document->getPartof(), true);
+                    $superiorTitle = Doc::getTitle($document->getPartof(), TRUE);
                     if (!empty($superiorTitle)) {
                         $title .= '[' . $superiorTitle . ']';
                     }

Classes/Controller/OaiPmhController.php

Spacing +11 added lines, -11 removed lines

@@ -243,10 +243,10 @@ 
             if ($root->item(0) instanceof \DOMNode) {
                 $mets = $xml->saveXML($root->item(0));
             } else {
-                $this->logger->error('No METS part found in document with location "' . $record['location'] . '"');
+                $this->logger->error('No METS part found in document with location "'.$record['location'].'"');
             }
         } else {
-            $this->logger->error('Could not load XML file from "' . $record['location'] . '"');
+            $this->logger->error('Could not load XML file from "'.$record['location'].'"');
         }
         return $mets;
     }
@@ -412,7 +412,7 @@ 
             $pageSettings = $this->configurationManager->getConfiguration($this->configurationManager::CONFIGURATION_TYPE_FULL_TYPOSCRIPT);
             $storagePid = $pageSettings["plugin."]["tx_dlf."]["persistence."]["storagePid"];
             if ($storagePid > 0) {
-                $this->logger->notice('No records found with PID ' . $storagePid);
+                $this->logger->notice('No records found with PID '.$storagePid);
             } else {
                 $this->logger->notice('No records found');
             }
@@ -495,7 +495,7 @@ 
             if (!empty($resArray)) {
                 // check, if all required fields are available for a given identifier
                 foreach ($details['requiredFields'] as $required) {
-                    $methodName = 'get' . GeneralUtility::underscoredToUpperCamelCase($required);
+                    $methodName = 'get'.GeneralUtility::underscoredToUpperCamelCase($required);
                     if (empty($resArray->$methodName())) {
                         // Skip metadata formats whose requirements are not met.
                         continue 2;
@@ -600,9 +600,9 @@ 
 
             if ($resArray = $result->fetch()) {
                 if ($resArray['index_query'] != "") {
-                    $solr_query .= '(' . $resArray['index_query'] . ')';
+                    $solr_query .= '('.$resArray['index_query'].')';
                 } else {
-                    $solr_query .= 'collection:' . '"' . $resArray['index_name'] . '"';
+                    $solr_query .= 'collection:'.'"'.$resArray['index_name'].'"';
                 }
             } else {
                 $this->error = 'noSetHierarchy';
@@ -614,7 +614,7 @@ 
         }
         // Check for required fields.
         foreach ($this->formats[$this->parameters['metadataPrefix']]['requiredFields'] as $required) {
-            $solr_query .= ' NOT ' . $required . ':""';
+            $solr_query .= ' NOT '.$required.':""';
         }
         // toplevel="true" is always required
         $solr_query .= ' AND toplevel:true';
@@ -628,7 +628,7 @@ 
             ) {
                 $timestamp = gmmktime($date_array['tm_hour'], $date_array['tm_min'], $date_array['tm_sec'],
                     $date_array['tm_mon'] + 1, $date_array['tm_mday'], $date_array['tm_year'] + 1900);
-                $from = date("Y-m-d", $timestamp) . 'T' . date("H:i:s", $timestamp) . '.000Z';
+                $from = date("Y-m-d", $timestamp).'T'.date("H:i:s", $timestamp).'.000Z';
             } else {
                 $this->error = 'badArgument';
                 return;
@@ -644,7 +644,7 @@ 
             ) {
                 $timestamp = gmmktime($date_array['tm_hour'], $date_array['tm_min'], $date_array['tm_sec'],
                     $date_array['tm_mon'] + 1, $date_array['tm_mday'], $date_array['tm_year'] + 1900);
-                $until = date("Y-m-d", $timestamp) . 'T' . date("H:i:s", $timestamp) . '.999Z';
+                $until = date("Y-m-d", $timestamp).'T'.date("H:i:s", $timestamp).'.999Z';
                 if ($from != "*" && $from > $until) {
                     $this->error = 'badArgument';
                 }
@@ -661,7 +661,7 @@ 
                 $this->error = 'badArgument';
             }
         }
-        $solr_query .= ' AND timestamp:[' . $from . ' TO ' . $until . ']';
+        $solr_query .= ' AND timestamp:['.$from.' TO '.$until.']';
         $documentSet = [];
         $solr = Solr::getInstance($this->settings['solrcore']);
         if (!$solr->ready) {
@@ -780,7 +780,7 @@ 
         $resumptionTokenInfo['cursor'] = $currentCursor;
         $resumptionTokenInfo['completeListSize'] = $documentListSet['metadata']['completeListSize'];
         $expireDateTime = new \DateTime();
-        $expireDateTime->add(new \DateInterval('PT' . $this->settings['expired'] . 'S'));
+        $expireDateTime->add(new \DateInterval('PT'.$this->settings['expired'].'S'));
         $resumptionTokenInfo['expired'] = $expireDateTime;
 
         $omitResumptionToken = $currentCursor === 0 && $numShownDocuments >= $documentListSet['metadata']['completeListSize'];

Braces +19 added lines, -38 removed lines

@@ -27,8 +27,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class OaiPmhController extends AbstractController
-{
+class OaiPmhController extends AbstractController {
     /**
      * @var TokenRepository
      */
@@ -37,8 +36,7 @@ 
     /**
      * @param TokenRepository $tokenRepository
      */
-    public function injectTokenRepository(TokenRepository $tokenRepository)
-    {
+    public function injectTokenRepository(TokenRepository $tokenRepository) {
         $this->tokenRepository = $tokenRepository;
     }
 
@@ -50,8 +48,7 @@ 
     /**
      * @param CollectionRepository $collectionRepository
      */
-    public function injectCollectionRepository(CollectionRepository $collectionRepository)
-    {
+    public function injectCollectionRepository(CollectionRepository $collectionRepository) {
         $this->collectionRepository = $collectionRepository;
     }
 
@@ -63,8 +60,7 @@ 
     /**
      * @param LibraryRepository $libraryRepository
      */
-    public function injectLibraryRepository(LibraryRepository $libraryRepository)
-    {
+    public function injectLibraryRepository(LibraryRepository $libraryRepository) {
         $this->libraryRepository = $libraryRepository;
     }
 
@@ -73,8 +69,7 @@ 
      *
      * @return void
      */
-    public function initializeAction()
-    {
+    public function initializeAction() {
         $this->request->setFormat('xml');
     }
 
@@ -122,8 +117,7 @@ 
      *
      * @return void
      */
-    protected function deleteExpiredTokens()
-    {
+    protected function deleteExpiredTokens() {
         // Delete expired resumption tokens.
         $this->tokenRepository->deleteExpiredTokens($this->settings['expired']);
     }
@@ -135,8 +129,7 @@ 
      *
      * @return void
      */
-    protected function getUrlParams()
-    {
+    protected function getUrlParams() {
         $allowedParams = [
             'verb',
             'identifier',
@@ -166,8 +159,7 @@ 
      *
      * @return array $metadata: The mapped metadata array
      */
-    protected function getDcData(array $record)
-    {
+    protected function getDcData(array $record) {
         $metadata = [];
 
         $metadata[] = ['dc:identifier' => $record['record_id']];
@@ -232,8 +224,7 @@ 
      *
      * @return string: The fetched METS XML
      */
-    protected function getMetsData(array $record)
-    {
+    protected function getMetsData(array $record) {
         $mets = null;
         // Load METS file.
         $xml = new \DOMDocument();
@@ -256,8 +247,7 @@ 
      *
      * @return void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         // Get allowed GET and POST variables.
         $this->getUrlParams();
 
@@ -324,8 +314,7 @@ 
      *
      * @return void
      */
-    protected function verbGetRecord()
-    {
+    protected function verbGetRecord() {
         if (count($this->parameters) !== 3 || empty($this->parameters['metadataPrefix']) || empty($this->parameters['identifier'])) {
             $this->error = 'badArgument';
             return;
@@ -377,8 +366,7 @@ 
      *
      * @return void
      */
-    protected function verbIdentify()
-    {
+    protected function verbIdentify() {
         $library = $this->libraryRepository->findByUid($this->settings['library']);
 
         $oaiIdentifyInfo = [];
@@ -427,8 +415,7 @@ 
      *
      * @return void
      */
-    protected function verbListIdentifiers()
-    {
+    protected function verbListIdentifiers() {
         // If we have a resumption token we can continue our work
         if (!empty($this->parameters['resumptionToken'])) {
             // "resumptionToken" is an exclusive argument.
@@ -482,8 +469,7 @@ 
      *
      * @return void
      */
-    protected function verbListMetadataFormats()
-    {
+    protected function verbListMetadataFormats() {
         $resArray = [];
         // check for the optional "identifier" parameter
         if (isset($this->parameters['identifier'])) {
@@ -515,8 +501,7 @@ 
      *
      * @return void
      */
-    protected function verbListRecords()
-    {
+    protected function verbListRecords() {
         // Check for invalid arguments.
         if (!empty($this->parameters['resumptionToken'])) {
             // "resumptionToken" is an exclusive argument.
@@ -571,8 +556,7 @@ 
      *
      * @return void
      */
-    protected function verbListSets()
-    {
+    protected function verbListSets() {
         // It is required to set a oai_name inside the collection record to be shown in oai-pmh plugin.
         $this->settings['hideEmptyOaiNames'] = true;
 
@@ -588,8 +572,7 @@ 
      *
      * @return array|null Array of matching records
      */
-    protected function fetchDocumentUIDs()
-    {
+    protected function fetchDocumentUIDs() {
         $solr_query = '';
         // Check "set" for valid value.
         if (!empty($this->parameters['set'])) {
@@ -698,8 +681,7 @@ 
      *
      * @return array of enriched records
      */
-    protected function generateOutputForDocumentList(array $documentListSet)
-    {
+    protected function generateOutputForDocumentList(array $documentListSet) {
         $documentsToProcess = array_splice($documentListSet['elements'], 0, (int) $this->settings['limit']);
         if (empty($documentsToProcess)) {
             $this->error = 'noRecordsMatch';
@@ -752,8 +734,7 @@ 
      *
      * @return void
      */
-    protected function generateResumptionTokenForDocumentListSet(array $documentListSet, int $numShownDocuments)
-    {
+    protected function generateResumptionTokenForDocumentListSet(array $documentListSet, int $numShownDocuments) {
         // The cursor specifies how many elements have already been returned in previous requests
         // See http://www.openarchives.org/OAI/openarchivesprotocol.html#FlowControl
         $currentCursor = $documentListSet['metadata']['cursor'];

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -234,7 +234,7 @@ 
      */
     protected function getMetsData(array $record)
     {
-        $mets = null;
+        $mets = NULL;
         // Load METS file.
         $xml = new \DOMDocument();
         if ($xml->load($record['location'])) {
@@ -313,7 +313,7 @@ 
         } else {
             // No resumption token found or resumption token expired.
             $this->error = 'badResumptionToken';
-            return null;
+            return NULL;
         }
     }
 
@@ -574,7 +574,7 @@ 
     protected function verbListSets()
     {
         // It is required to set a oai_name inside the collection record to be shown in oai-pmh plugin.
-        $this->settings['hideEmptyOaiNames'] = true;
+        $this->settings['hideEmptyOaiNames'] = TRUE;
 
         $oaiSets = $this->collectionRepository->findCollectionsBySettings($this->settings);
 
@@ -606,7 +606,7 @@ 
                 }
             } else {
                 $this->error = 'noSetHierarchy';
-                return null;
+                return NULL;
             }
         } else {
             // If no set is specified we have to query for all collections
@@ -759,7 +759,7 @@ 
         $currentCursor = $documentListSet['metadata']['cursor'];
 
         if (count($documentListSet['elements']) !== 0) {
-            $resumptionToken = uniqid('', false);
+            $resumptionToken = uniqid('', FALSE);
 
             $documentListSet['metadata']['cursor'] += $numShownDocuments;
 

Classes/Controller/AbstractController.php

Spacing +4 added lines, -4 removed lines

@@ -125,7 +125,7 @@ 
                 if ($this->document) {
                     $doc = Doc::getInstance($this->document->getLocation(), $this->settings, true);
                 } else {
-                    $this->logger->error('Invalid UID "' . $requestData['id'] . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
+                    $this->logger->error('Invalid UID "'.$requestData['id'].'" or PID "'.$this->settings['storagePid'].'" for document loading');
                 }
             } else if (GeneralUtility::isValidUrl($requestData['id'])) {
 
@@ -143,7 +143,7 @@ 
 
                     $this->document->setLocation($requestData['id']);
                 } else {
-                    $this->logger->error('Invalid location given "' . $requestData['id'] . '" for document loading');
+                    $this->logger->error('Invalid location given "'.$requestData['id'].'" for document loading');
                 }
             }
 
@@ -160,11 +160,11 @@ 
                 if ($this->document !== null && $doc !== null) {
                     $this->document->setDoc($doc);
                 } else {
-                    $this->logger->error('Failed to load document with record ID "' . $requestData['recordId'] . '"');
+                    $this->logger->error('Failed to load document with record ID "'.$requestData['recordId'].'"');
                 }
             }
         } else {
-            $this->logger->error('Invalid ID "' . $requestData['id'] . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
+            $this->logger->error('Invalid ID "'.$requestData['id'].'" or PID "'.$this->settings['storagePid'].'" for document loading');
         }
     }
 

Upper-Lower-Casing +10 added lines, -10 removed lines

@@ -117,26 +117,26 @@ 
         // Try to get document format from database
         if (!empty($requestData['id'])) {
 
-            $doc = null;
+            $doc = NULL;
 
             if (MathUtility::canBeInterpretedAsInteger($requestData['id'])) {
                 // find document from repository by uid
                 $this->document = $this->documentRepository->findOneByIdAndSettings((int) $requestData['id']);
                 if ($this->document) {
-                    $doc = Doc::getInstance($this->document->getLocation(), $this->settings, true);
+                    $doc = Doc::getInstance($this->document->getLocation(), $this->settings, TRUE);
                 } else {
                     $this->logger->error('Invalid UID "' . $requestData['id'] . '" or PID "' . $this->settings['storagePid'] . '" for document loading');
                 }
             } else if (GeneralUtility::isValidUrl($requestData['id'])) {
 
-                $doc = Doc::getInstance($requestData['id'], $this->settings, true);
+                $doc = Doc::getInstance($requestData['id'], $this->settings, TRUE);
 
-                if ($doc !== null) {
+                if ($doc !== NULL) {
                     if ($doc->recordId) {
                         $this->document = $this->documentRepository->findOneByRecordId($doc->recordId);
                     }
 
-                    if ($this->document === null) {
+                    if ($this->document === NULL) {
                         // create new dummy Document object
                         $this->document = GeneralUtility::makeInstance(Document::class);
                     }
@@ -147,7 +147,7 @@ 
                 }
             }
 
-            if ($this->document !== null && $doc !== null) {
+            if ($this->document !== NULL && $doc !== NULL) {
                 $this->document->setDoc($doc);
             }
 
@@ -155,9 +155,9 @@ 
 
             $this->document = $this->documentRepository->findOneByRecordId($requestData['recordId']);
 
-            if ($this->document !== null) {
-                $doc = Doc::getInstance($this->document->getLocation(), $this->settings, true);
-                if ($this->document !== null && $doc !== null) {
+            if ($this->document !== NULL) {
+                $doc = Doc::getInstance($this->document->getLocation(), $this->settings, TRUE);
+                if ($this->document !== NULL && $doc !== NULL) {
                     $this->document->setDoc($doc);
                 } else {
                     $this->logger->error('Failed to load document with record ID "' . $requestData['recordId'] . '"');
@@ -191,7 +191,7 @@ 
         if ($this->request->hasArgument($parameterName)) {
             return $this->request->getArgument($parameterName);
         }
-        return null;
+        return NULL;
     }
 
     /**

Braces +5 added lines, -10 removed lines

@@ -44,8 +44,7 @@ 
     /**
      * @param DocumentRepository $documentRepository
      */
-    public function injectDocumentRepository(DocumentRepository $documentRepository)
-    {
+    public function injectDocumentRepository(DocumentRepository $documentRepository) {
         $this->documentRepository = $documentRepository;
     }
 
@@ -85,8 +84,7 @@ 
      * @access protected
      * @return void
      */
-    protected function initialize()
-    {
+    protected function initialize() {
         $this->requestData = GeneralUtility::_GPmerged('tx_dlf');
         if (empty($this->requestData['page'])) {
             $this->requestData['page'] = 1;
@@ -112,8 +110,7 @@ 
      *
      * @return void
      */
-    protected function loadDocument($requestData)
-    {
+    protected function loadDocument($requestData) {
         // Try to get document format from database
         if (!empty($requestData['id'])) {
 
@@ -186,8 +183,7 @@ 
      *
      * @return null|string|array
      */
-    protected function getParametersSafely($parameterName)
-    {
+    protected function getParametersSafely($parameterName) {
         if ($this->request->hasArgument($parameterName)) {
             return $this->request->getArgument($parameterName);
         }
@@ -201,8 +197,7 @@ 
      *
      * @return void
      */
-    public function __construct()
-    {
+    public function __construct() {
         $this->initialize();
     }
 }

Classes/Controller/CollectionController.php

Spacing +4 added lines, -4 removed lines

@@ -96,14 +96,14 @@
         foreach ($collections as $collection) {
             $solr_query = '';
             if ($collection->getIndexSearch() != '') {
-                $solr_query .= '(' . $collection->getIndexSearch() . ')';
+                $solr_query .= '('.$collection->getIndexSearch().')';
             } else {
-                $solr_query .= 'collection:("' . Solr::escapeQuery($collection->getIndexName()) . '")';
+                $solr_query .= 'collection:("'.Solr::escapeQuery($collection->getIndexName()).'")';
             }
-            $params['query'] = $solr_query . ' AND partof:0 AND toplevel:true';
+            $params['query'] = $solr_query.' AND partof:0 AND toplevel:true';
             $partOfNothing = $solr->search_raw($params);
 
-            $params['query'] = $solr_query . ' AND NOT partof:0 AND toplevel:true';
+            $params['query'] = $solr_query.' AND NOT partof:0 AND toplevel:true';
             $partOfSomething = $solr->search_raw($params);
             // Titles are all documents that are "root" elements i.e. partof == 0
             $collectionInfo['titles'] = [];

Braces +6 added lines, -12 removed lines

@@ -29,8 +29,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class CollectionController extends AbstractController
-{
+class CollectionController extends AbstractController {
     /**
      * @var CollectionRepository
      */
@@ -39,8 +38,7 @@ 
     /**
      * @param CollectionRepository $collectionRepository
      */
-    public function injectCollectionRepository(CollectionRepository $collectionRepository)
-    {
+    public function injectCollectionRepository(CollectionRepository $collectionRepository) {
         $this->collectionRepository = $collectionRepository;
     }
 
@@ -52,8 +50,7 @@ 
     /**
      * @param MetadataRepository $metadataRepository
      */
-    public function injectMetadataRepository(MetadataRepository $metadataRepository)
-    {
+    public function injectMetadataRepository(MetadataRepository $metadataRepository) {
         $this->metadataRepository = $metadataRepository;
     }
 
@@ -62,8 +59,7 @@ 
      *
      * @return void
      */
-    public function listAction()
-    {
+    public function listAction() {
         $solr = Solr::getInstance($this->settings['solrcore']);
 
         if (!$solr->ready) {
@@ -146,8 +142,7 @@ 
      *
      * @return void
      */
-    public function showAction(\Kitodo\Dlf\Domain\Model\Collection $collection)
-    {
+    public function showAction(\Kitodo\Dlf\Domain\Model\Collection $collection) {
         $searchParams = $this->getParametersSafely('searchParameter');
 
         // Instaniate the Solr. Without Solr present, we can't do anything.
@@ -199,8 +194,7 @@ 
      *
      * @return void
      */
-    public function showSortedAction()
-    {
+    public function showSortedAction() {
         // if search was triggered, get search parameters from POST variables
         $searchParams = $this->getParametersSafely('searchParameter');
 

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -87,7 +87,7 @@ 
         }
 
         if (count($collections) == 1 && empty($this->settings['dont_show_single']) && is_array($collections)) {
-            $this->forward('show', null, null, ['collection' => array_pop($collections)]);
+            $this->forward('show', NULL, NULL, ['collection' => array_pop($collections)]);
         }
 
         $processedCollections = [];
@@ -166,7 +166,7 @@ 
         $searchParams['collection'] = $collection;
         // If a targetPid is given, the results will be shown by ListView on the target page.
         if (!empty($this->settings['targetPid'])) {
-            $this->redirect('main', 'ListView', null,
+            $this->redirect('main', 'ListView', NULL,
                 [
                     'searchParameter' => $searchParams,
                     'widgetPage' => $widgetPage
@@ -175,10 +175,10 @@ 
         }
 
         // get all metadata records to be shown in results
-        $listedMetadata = $this->metadataRepository->findByIsListed(true);
+        $listedMetadata = $this->metadataRepository->findByIsListed(TRUE);
 
         // get all sortable metadata records
-        $sortableMetadata = $this->metadataRepository->findByIsSortable(true);
+        $sortableMetadata = $this->metadataRepository->findByIsSortable(TRUE);
 
         // get all documents of given collection
         $solrResults = $this->documentRepository->findSolrByCollection($collection, $this->settings, $searchParams, $listedMetadata);
@@ -204,13 +204,13 @@ 
         // if search was triggered, get search parameters from POST variables
         $searchParams = $this->getParametersSafely('searchParameter');
 
-        $collection = null;
+        $collection = NULL;
         if ($searchParams['collection']['__identity'] && MathUtility::canBeInterpretedAsInteger($searchParams['collection']['__identity'])) {
             $collection = $this->collectionRepository->findByUid($searchParams['collection']['__identity']);
         }
 
         // output is done by show action
-        $this->forward('show', null, null, ['searchParameter' => $searchParams, 'collection' => $collection]);
+        $this->forward('show', NULL, NULL, ['searchParameter' => $searchParams, 'collection' => $collection]);
 
     }
 }

Classes/Controller/AudioPlayerController.php

Braces +3 added lines, -6 removed lines

@@ -25,8 +25,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class AudioplayerController extends AbstractController
-{
+class AudioplayerController extends AbstractController {
     /**
      * Holds the current audio file's URL, MIME type and optional label
      *
@@ -42,8 +41,7 @@ 
      *
      * @return void
      */
-    protected function addPlayerJS()
-    {
+    protected function addPlayerJS() {
         // Inline CSS.
         $inlineCSS = '#tx-dlf-audio { width: 100px; height: 100px; }';
 
@@ -72,8 +70,7 @@ 
      *
      * @return void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         // Load current document.
         $this->loadDocument($this->requestData);
         if (

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -77,8 +77,8 @@
         // Load current document.
         $this->loadDocument($this->requestData);
         if (
-            $this->document === null
-            || $this->document->getDoc() === null
+            $this->document === NULL
+            || $this->document->getDoc() === NULL
             || $this->document->getDoc()->numPages < 1
         ) {
             // Quit without doing anything if required variables are not set.

Spacing +4 added lines, -4 removed lines

@@ -52,12 +52,12 @@
             $(document).ready(function() {
                 AudioPlayer = new dlfAudioPlayer({
                     audio: {
-                        mimeType: "' . $this->audio['mimetype'] . '",
-                        title: "' . $this->audio['label'] . '",
-                        url:  "' . $this->audio['url'] . '"
+                        mimeType: "' . $this->audio['mimetype'].'",
+                        title: "' . $this->audio['label'].'",
+                        url:  "' . $this->audio['url'].'"
                     },
                     parentElId: "tx-dlf-audio",
-                    swfPath: "' . PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath('dlf')) . 'Resources/Public/JavaScript/jPlayer/jquery.jplayer.swf"
+                    swfPath: "' . PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath('dlf')).'Resources/Public/JavaScript/jPlayer/jquery.jplayer.swf"
                 });
             });
         ';

Classes/Controller/ListViewController.php

Braces +4 added lines, -8 removed lines

@@ -29,8 +29,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class ListViewController extends AbstractController
-{
+class ListViewController extends AbstractController {
     /**
      * @var CollectionRepository
      */
@@ -39,8 +38,7 @@ 
     /**
      * @param CollectionRepository $collectionRepository
      */
-    public function injectCollectionRepository(CollectionRepository $collectionRepository)
-    {
+    public function injectCollectionRepository(CollectionRepository $collectionRepository) {
         $this->collectionRepository = $collectionRepository;
     }
 
@@ -52,8 +50,7 @@ 
     /**
      * @param MetadataRepository $metadataRepository
      */
-    public function injectMetadataRepository(MetadataRepository $metadataRepository)
-    {
+    public function injectMetadataRepository(MetadataRepository $metadataRepository) {
         $this->metadataRepository = $metadataRepository;
     }
 
@@ -68,8 +65,7 @@ 
      *
      * @return void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         $this->searchParams = $this->getParametersSafely('searchParameter');
 
         $collection = null;

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -72,7 +72,7 @@ 
     {
         $this->searchParams = $this->getParametersSafely('searchParameter');
 
-        $collection = null;
+        $collection = NULL;
         if ($this->searchParams['collection'] && MathUtility::canBeInterpretedAsInteger($this->searchParams['collection'])) {
             $collection = $this->collectionRepository->findByUid($this->searchParams['collection']);
         }
@@ -83,15 +83,15 @@ 
         }
 
         // get all sortable metadata records
-        $sortableMetadata = $this->metadataRepository->findByIsSortable(true);
+        $sortableMetadata = $this->metadataRepository->findByIsSortable(TRUE);
 
         // get all metadata records to be shown in results
-        $listedMetadata = $this->metadataRepository->findByIsListed(true);
+        $listedMetadata = $this->metadataRepository->findByIsListed(TRUE);
 
         $solrResults = [];
         $numResults = 0;
         if (is_array($this->searchParams) && !empty($this->searchParams)) {
-            $solrResults = $this->documentRepository->findSolrByCollection($collection ? : null, $this->settings, $this->searchParams, $listedMetadata);
+            $solrResults = $this->documentRepository->findSolrByCollection($collection ? : NULL, $this->settings, $this->searchParams, $listedMetadata);
             $numResults = $solrResults->getNumFound();
         }