Erikmitk / kitodo-presentation

Classes/Controller/CollectionController.php

Spacing +4 added lines, -4 removed lines

@@ -96,14 +96,14 @@
         foreach ($collections as $collection) {
             $solr_query = '';
             if ($collection->getIndexSearch() != '') {
-                $solr_query .= '(' . $collection->getIndexSearch() . ')';
+                $solr_query .= '('.$collection->getIndexSearch().')';
             } else {
-                $solr_query .= 'collection:("' . Solr::escapeQuery($collection->getIndexName()) . '")';
+                $solr_query .= 'collection:("'.Solr::escapeQuery($collection->getIndexName()).'")';
             }
-            $params['query'] = $solr_query . ' AND partof:0 AND toplevel:true';
+            $params['query'] = $solr_query.' AND partof:0 AND toplevel:true';
             $partOfNothing = $solr->search_raw($params);
 
-            $params['query'] = $solr_query . ' AND NOT partof:0 AND toplevel:true';
+            $params['query'] = $solr_query.' AND NOT partof:0 AND toplevel:true';
             $partOfSomething = $solr->search_raw($params);
             // Titles are all documents that are "root" elements i.e. partof == 0
             $collectionInfo['titles'] = [];

Braces +6 added lines, -12 removed lines

@@ -29,8 +29,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class CollectionController extends AbstractController
-{
+class CollectionController extends AbstractController {
     /**
      * @var CollectionRepository
      */
@@ -39,8 +38,7 @@ 
     /**
      * @param CollectionRepository $collectionRepository
      */
-    public function injectCollectionRepository(CollectionRepository $collectionRepository)
-    {
+    public function injectCollectionRepository(CollectionRepository $collectionRepository) {
         $this->collectionRepository = $collectionRepository;
     }
 
@@ -52,8 +50,7 @@ 
     /**
      * @param MetadataRepository $metadataRepository
      */
-    public function injectMetadataRepository(MetadataRepository $metadataRepository)
-    {
+    public function injectMetadataRepository(MetadataRepository $metadataRepository) {
         $this->metadataRepository = $metadataRepository;
     }
 
@@ -62,8 +59,7 @@ 
      *
      * @return void
      */
-    public function listAction()
-    {
+    public function listAction() {
         $solr = Solr::getInstance($this->settings['solrcore']);
 
         if (!$solr->ready) {
@@ -146,8 +142,7 @@ 
      *
      * @return void
      */
-    public function showAction(\Kitodo\Dlf\Domain\Model\Collection $collection)
-    {
+    public function showAction(\Kitodo\Dlf\Domain\Model\Collection $collection) {
         $searchParams = $this->getParametersSafely('searchParameter');
 
         // Instaniate the Solr. Without Solr present, we can't do anything.
@@ -199,8 +194,7 @@ 
      *
      * @return void
      */
-    public function showSortedAction()
-    {
+    public function showSortedAction() {
         // if search was triggered, get search parameters from POST variables
         $searchParams = $this->getParametersSafely('searchParameter');
 

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -87,7 +87,7 @@ 
         }
 
         if (count($collections) == 1 && empty($this->settings['dont_show_single']) && is_array($collections)) {
-            $this->forward('show', null, null, ['collection' => array_pop($collections)]);
+            $this->forward('show', NULL, NULL, ['collection' => array_pop($collections)]);
         }
 
         $processedCollections = [];
@@ -166,7 +166,7 @@ 
         $searchParams['collection'] = $collection;
         // If a targetPid is given, the results will be shown by ListView on the target page.
         if (!empty($this->settings['targetPid'])) {
-            $this->redirect('main', 'ListView', null,
+            $this->redirect('main', 'ListView', NULL,
                 [
                     'searchParameter' => $searchParams,
                     'widgetPage' => $widgetPage
@@ -175,10 +175,10 @@ 
         }
 
         // get all metadata records to be shown in results
-        $listedMetadata = $this->metadataRepository->findByIsListed(true);
+        $listedMetadata = $this->metadataRepository->findByIsListed(TRUE);
 
         // get all sortable metadata records
-        $sortableMetadata = $this->metadataRepository->findByIsSortable(true);
+        $sortableMetadata = $this->metadataRepository->findByIsSortable(TRUE);
 
         // get all documents of given collection
         $documents = $this->documentRepository->findSolrByCollection($collection, $this->settings, $searchParams, $listedMetadata);
@@ -204,13 +204,13 @@ 
         // if search was triggered, get search parameters from POST variables
         $searchParams = $this->getParametersSafely('searchParameter');
 
-        $collection = null;
+        $collection = NULL;
         if ($searchParams['collection']['__identity'] && MathUtility::canBeInterpretedAsInteger($searchParams['collection']['__identity'])) {
             $collection = $this->collectionRepository->findByUid($searchParams['collection']['__identity']);
         }
 
         // output is done by show action
-        $this->forward('show', null, null, ['searchParameter' => $searchParams, 'collection' => $collection]);
+        $this->forward('show', NULL, NULL, ['searchParameter' => $searchParams, 'collection' => $collection]);
 
     }
 }

Classes/Controller/AudioPlayerController.php

Spacing +4 added lines, -4 removed lines

@@ -52,12 +52,12 @@
             $(document).ready(function() {
                 AudioPlayer = new dlfAudioPlayer({
                     audio: {
-                        mimeType: "' . $this->audio['mimetype'] . '",
-                        title: "' . $this->audio['label'] . '",
-                        url:  "' . $this->audio['url'] . '"
+                        mimeType: "' . $this->audio['mimetype'].'",
+                        title: "' . $this->audio['label'].'",
+                        url:  "' . $this->audio['url'].'"
                     },
                     parentElId: "tx-dlf-audio",
-                    swfPath: "' . PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath('dlf')) . 'Resources/Public/Javascript/jPlayer/jquery.jplayer.swf"
+                    swfPath: "' . PathUtility::stripPathSitePrefix(ExtensionManagementUtility::extPath('dlf')).'Resources/Public/Javascript/jPlayer/jquery.jplayer.swf"
                 });
             });
         ';

Braces +3 added lines, -6 removed lines

@@ -25,8 +25,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class AudioplayerController extends AbstractController
-{
+class AudioplayerController extends AbstractController {
     /**
      * Holds the current audio file's URL, MIME type and optional label
      *
@@ -42,8 +41,7 @@ 
      *
      * @return void
      */
-    protected function addPlayerJS()
-    {
+    protected function addPlayerJS() {
         // Inline CSS.
         $inlineCSS = '#tx-dlf-audio { width: 100px; height: 100px; }';
 
@@ -72,8 +70,7 @@ 
      *
      * @return void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         // Load current document.
         $this->loadDocument($this->requestData);
         if (

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -77,8 +77,8 @@
         // Load current document.
         $this->loadDocument($this->requestData);
         if (
-            $this->document === null
-            || $this->document->getDoc() === null
+            $this->document === NULL
+            || $this->document->getDoc() === NULL
             || $this->document->getDoc()->numPages < 1
         ) {
             // Quit without doing anything if required variables are not set.

Classes/Controller/MetadataController.php

Spacing +2 added lines, -2 removed lines

@@ -155,7 +155,7 @@ 
             array_unshift($metadata, $data);
         }
         if (empty($metadata)) {
-            $this->logger->warning('No metadata found for document with UID ' . $this->document->getUid());
+            $this->logger->warning('No metadata found for document with UID '.$this->document->getUid());
             return '';
         }
         ksort($metadata);
@@ -255,7 +255,7 @@ 
                         if (empty($metadataValue) && $this->settings['getTitle'] && $this->document->getDoc()->parentId) {
                             $superiorTitle = Doc::getTitle($this->document->getPartof(), true);
                             if (!empty($superiorTitle)) {
-                                $metadataArray[$i][$metadataName] = ['[' . $superiorTitle . ']'];
+                                $metadataArray[$i][$metadataName] = ['['.$superiorTitle.']'];
                             }
                         }
                         if (!empty($metadataValue)) {

Upper-Lower-Casing +9 added lines, -9 removed lines

@@ -80,8 +80,8 @@ 
         // Load current document.
         $this->loadDocument($this->requestData);
         if (
-            $this->document === null
-            || $this->document->getDoc() === null
+            $this->document === NULL
+            || $this->document->getDoc() === NULL
         ) {
             // Quit without doing anything if required variables are not set.
             return '';
@@ -180,7 +180,7 @@ 
      *
      * @return string The metadata array ready for output
      */
-    protected function printMetadata(array $metadataArray, $useOriginalIiifManifestMetadata = false)
+    protected function printMetadata(array $metadataArray, $useOriginalIiifManifestMetadata = FALSE)
     {
         if ($useOriginalIiifManifestMetadata) {
             $iiifData = [];
@@ -198,14 +198,14 @@ 
                             $iiifData[$key] = [
                                 'label' => $key,
                                 'value' => $group,
-                                'buildUrl' => true,
+                                'buildUrl' => TRUE,
                             ];
                         } else {
                             // Data output
                             $iiifData[$key] = [
                                 'label' => $key,
                                 'value' => $group,
-                                'buildUrl' => false,
+                                'buildUrl' => FALSE,
                             ];
                         }
                     } else {
@@ -222,18 +222,18 @@ 
                                 $iiifData[$key]['data'][] = [
                                     'label' => $nolabel ? '' : $label,
                                     'value' => $value,
-                                    'buildUrl' => true,
+                                    'buildUrl' => TRUE,
                                 ];
                             } else {
                                 $iiifData[$key]['data'][] = [
                                     'label' => $label,
                                     'value' => $value,
-                                    'buildUrl' => false,
+                                    'buildUrl' => FALSE,
                                 ];
                             }
                         }
                     }
-                    $this->view->assign('useIiif', true);
+                    $this->view->assign('useIiif', TRUE);
                     $this->view->assign('iiifData', $iiifData);
                 }
             }
@@ -253,7 +253,7 @@ 
                     if ($metadataName == 'title') {
                         // Get title of parent document if needed.
                         if (empty($metadataValue) && $this->settings['getTitle'] && $this->document->getDoc()->parentId) {
-                            $superiorTitle = Doc::getTitle($this->document->getPartof(), true);
+                            $superiorTitle = Doc::getTitle($this->document->getPartof(), TRUE);
                             if (!empty($superiorTitle)) {
                                 $metadataArray[$i][$metadataName] = ['[' . $superiorTitle . ']'];
                             }

Braces +9 added lines, -18 removed lines

@@ -29,8 +29,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class MetadataController extends AbstractController
-{
+class MetadataController extends AbstractController {
     /**
      * @var CollectionRepository
      */
@@ -39,8 +38,7 @@ 
     /**
      * @param CollectionRepository $collectionRepository
      */
-    public function injectCollectionRepository(CollectionRepository $collectionRepository)
-    {
+    public function injectCollectionRepository(CollectionRepository $collectionRepository) {
         $this->collectionRepository = $collectionRepository;
     }
 
@@ -52,8 +50,7 @@ 
     /**
      * @param MetadataRepository $metadataRepository
      */
-    public function injectMetadataRepository(MetadataRepository $metadataRepository)
-    {
+    public function injectMetadataRepository(MetadataRepository $metadataRepository) {
         $this->metadataRepository = $metadataRepository;
     }
 
@@ -65,16 +62,14 @@ 
     /**
      * @param StructureRepository $structureRepository
      */
-    public function injectStructureRepository(StructureRepository $structureRepository)
-    {
+    public function injectStructureRepository(StructureRepository $structureRepository) {
         $this->structureRepository = $structureRepository;
     }
 
     /**
      * @return string|void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         $this->cObj = $this->configurationManager->getContentObject();
 
         // Load current document.
@@ -130,8 +125,7 @@ 
      *
      * @return string The metadata array ready for output
      */
-    protected function printMetadata(array $metadataArray, $useOriginalIiifManifestMetadata = false)
-    {
+    protected function printMetadata(array $metadataArray, $useOriginalIiifManifestMetadata = false) {
         if ($useOriginalIiifManifestMetadata) {
             $iiifData = [];
             foreach ($metadataArray as $metadata) {
@@ -250,8 +244,7 @@ 
                     }
 
                     if (is_array($metadataArray[$i][$metadataName])) {
-                        $metadataArray[$i][$metadataName] = array_values(array_filter($metadataArray[$i][$metadataName], function($value)
-                        {
+                        $metadataArray[$i][$metadataName] = array_values(array_filter($metadataArray[$i][$metadataName], function($value) {
                             return !empty($value);
                         }));
                     }
@@ -273,8 +266,7 @@ 
      *
      * @return array metadata
      */
-    private function getMetadata()
-    {
+    private function getMetadata() {
         $metadata = [];
         if ($this->settings['rootline'] < 2) {
             // Get current structure's @ID.
@@ -312,8 +304,7 @@ 
      *
      * @return array metadata
      */
-    private function getMetadataForIds($id, $metadata)
-    {
+    private function getMetadataForIds($id, $metadata) {
         $useOriginalIiifManifestMetadata = $this->settings['originalIiifMetadata'] == 1 && $this->document->getDoc() instanceof IiifManifest;
         foreach ($id as $sid) {
             if ($useOriginalIiifManifestMetadata) {

Classes/Controller/ListViewController.php

Braces +4 added lines, -8 removed lines

@@ -29,8 +29,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class ListViewController extends AbstractController
-{
+class ListViewController extends AbstractController {
     /**
      * @var CollectionRepository
      */
@@ -39,8 +38,7 @@ 
     /**
      * @param CollectionRepository $collectionRepository
      */
-    public function injectCollectionRepository(CollectionRepository $collectionRepository)
-    {
+    public function injectCollectionRepository(CollectionRepository $collectionRepository) {
         $this->collectionRepository = $collectionRepository;
     }
 
@@ -52,8 +50,7 @@ 
     /**
      * @param MetadataRepository $metadataRepository
      */
-    public function injectMetadataRepository(MetadataRepository $metadataRepository)
-    {
+    public function injectMetadataRepository(MetadataRepository $metadataRepository) {
         $this->metadataRepository = $metadataRepository;
     }
 
@@ -68,8 +65,7 @@ 
      *
      * @return void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         $this->searchParams = $this->getParametersSafely('searchParameter');
 
         $collection = null;

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -72,7 +72,7 @@ 
     {
         $this->searchParams = $this->getParametersSafely('searchParameter');
 
-        $collection = null;
+        $collection = NULL;
         if ($this->searchParams['collection'] && MathUtility::canBeInterpretedAsInteger($this->searchParams['collection'])) {
             $collection = $this->collectionRepository->findByUid($this->searchParams['collection']);
         }
@@ -83,14 +83,14 @@ 
         }
 
         // get all sortable metadata records
-        $sortableMetadata = $this->metadataRepository->findByIsSortable(true);
+        $sortableMetadata = $this->metadataRepository->findByIsSortable(TRUE);
 
         // get all metadata records to be shown in results
-        $listedMetadata = $this->metadataRepository->findByIsListed(true);
+        $listedMetadata = $this->metadataRepository->findByIsListed(TRUE);
 
         $solrResults = [];
         if (is_array($this->searchParams) && !empty($this->searchParams)) {
-            $solrResults = $this->documentRepository->findSolrByCollection($collection ? : null, $this->settings, $this->searchParams, $listedMetadata);
+            $solrResults = $this->documentRepository->findSolrByCollection($collection ? : NULL, $this->settings, $this->searchParams, $listedMetadata);
         }
 
         $this->view->assign('viewData', $this->viewData);

Classes/Controller/PageGridController.php

Braces +3 added lines, -6 removed lines

@@ -22,15 +22,13 @@ 
  * @subpackage dlf
  * @access public
  */
-class PageGridController extends AbstractController
-{
+class PageGridController extends AbstractController {
     /**
      * The main method of the plugin
      *
      * @return void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         $this->loadDocument($this->requestData);
         if (
             $this->document === null
@@ -65,8 +63,7 @@ 
      *
      * @return array The rendered entry ready for fluid
      */
-    protected function getEntry($number, $fileGrpThumbs)
-    {
+    protected function getEntry($number, $fileGrpThumbs) {
         // Set pagination.
         $entry['pagination'] = htmlspecialchars($this->document->getDoc()->physicalStructureInfo[$this->document->getDoc()->physicalStructure[$number]]['orderlabel']);
         $entry['page'] = $number;

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
     {
         $this->loadDocument($this->requestData);
         if (
-            $this->document === null
+            $this->document === NULL
             || $this->document->getDoc()->numPages < 1
             || empty($this->extConf['fileGrpThumbs'])
         ) {

Classes/Controller/ToolboxController.php

Spacing +3 added lines, -3 removed lines

@@ -253,7 +253,7 @@ 
                 $image['mimetypeLabel'] = $mimetypeLabel;
                 break;
             } else {
-                $this->logger->warning('File not found in fileGrp "' . $fileGrp . '"');
+                $this->logger->warning('File not found in fileGrp "'.$fileGrp.'"');
             }
         }
         return $image;
@@ -344,7 +344,7 @@ 
             empty($page1Link)
             && empty($page2Link)
         ) {
-            $this->logger->warning('File not found in fileGrps "' . $this->extConf['fileGrpDownload'] . '"');
+            $this->logger->warning('File not found in fileGrps "'.$this->extConf['fileGrpDownload'].'"');
         }
 
         if (!empty($page1Link)) {
@@ -383,7 +383,7 @@ 
         if (!empty($workLink)) {
             $workLink = $workLink;
         } else {
-            $this->logger->warning('File not found in fileGrps "' . $this->extConf['fileGrpDownload'] . '"');
+            $this->logger->warning('File not found in fileGrps "'.$this->extConf['fileGrpDownload'].'"');
         }
         return $workLink;
     }

Braces +14 added lines, -28 removed lines

@@ -23,15 +23,13 @@ 
  * @subpackage dlf
  * @access public
  */
-class ToolboxController extends AbstractController
-{
+class ToolboxController extends AbstractController {
     /**
      * The main method of the plugin
      *
      * @return void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         // Load current document.
         $this->loadDocument($this->requestData);
 
@@ -52,8 +50,7 @@ 
      *
      * @return void
      */
-    public function annotationtool()
-    {
+    public function annotationtool() {
         if (
             $this->document === null
             || $this->document->getDoc()->numPages < 1
@@ -94,8 +91,7 @@ 
      *
      * @return void
      */
-    public function fulltextdownloadtool()
-    {
+    public function fulltextdownloadtool() {
         if (
             $this->document === null
             || $this->document->getDoc()->numPages < 1
@@ -140,8 +136,7 @@ 
      *
      * @return void
      */
-    public function fulltexttool()
-    {
+    public function fulltexttool() {
         if (
             $this->document === null
             || $this->document->getDoc()->numPages < 1
@@ -186,8 +181,7 @@ 
      *
      * @return void
      */
-    public function imagedownloadtool()
-    {
+    public function imagedownloadtool() {
         if (
             $this->document === null
             || $this->document->getDoc()->numPages < 1
@@ -230,8 +224,7 @@ 
      *
      * @return array Array of image links and image format information
      */
-    protected function getImage($page)
-    {
+    protected function getImage($page) {
         $image = [];
         // Get @USE value of METS fileGrp.
         $fileGrps = \TYPO3\CMS\Core\Utility\GeneralUtility::trimExplode(',', $this->settings['fileGrpsImageDownload']);
@@ -264,8 +257,7 @@ 
      *
      * @return void
      */
-    public function imagemanipulationtool()
-    {
+    public function imagemanipulationtool() {
         // Set parent element for initialization.
         $parentContainer = !empty($this->settings['parentContainer']) ? $this->settings['parentContainer'] : '.tx-dlf-imagemanipulationtool';
 
@@ -278,8 +270,7 @@ 
      *
      * @return void
      */
-    public function pdfdownloadtool()
-    {
+    public function pdfdownloadtool() {
         if (
             $this->document === null
             || $this->document->getDoc() === null
@@ -318,8 +309,7 @@ 
      *
      * @return array Link to downloadable page
      */
-    protected function getPageLink()
-    {
+    protected function getPageLink() {
         $page1Link = '';
         $page2Link = '';
         $pageLinkArray = [];
@@ -363,8 +353,7 @@ 
      *
      * @return string Link to downloadable work
      */
-    protected function getWorkLink()
-    {
+    protected function getWorkLink() {
         $workLink = '';
         $fileGrpsDownload = GeneralUtility::trimExplode(',', $this->extConf['fileGrpDownload']);
         // Get work link.
@@ -393,8 +382,7 @@ 
      *
      * @return void
      */
-    public function searchindocumenttool()
-    {
+    public function searchindocumenttool() {
         if (
             $this->document === null
             || $this->document->getDoc()->numPages < 1
@@ -457,8 +445,7 @@ 
      *
      * @return string with current document id
      */
-    protected function getCurrentDocumentId()
-    {
+    protected function getCurrentDocumentId() {
         $id = $this->document->getUid();
 
         if ($id !== null && $id > 0) {
@@ -493,8 +480,7 @@ 
      *
      * @return string with encrypted core name
      */
-    protected function getEncryptedCoreName()
-    {
+    protected function getEncryptedCoreName() {
         // Get core name.
         $name = Helper::getIndexNameFromUid($this->settings['solrcore'], 'tx_dlf_solrcores');
         // Encrypt core name.

Upper-Lower-Casing +17 added lines, -17 removed lines

@@ -43,7 +43,7 @@ 
         foreach ($tools as $tool) {
             $tool = trim(str_replace('tx_dlf_', '', $tool));
             $this->$tool();
-            $this->view->assign($tool, true);
+            $this->view->assign($tool, TRUE);
         }
     }
 
@@ -55,7 +55,7 @@ 
     public function annotationtool()
     {
         if (
-            $this->document === null
+            $this->document === NULL
             || $this->document->getDoc()->numPages < 1
         ) {
             // Quit without doing anything if required variables are not set.
@@ -80,12 +80,12 @@ 
 
         $annotationContainers = $this->document->getDoc()->physicalStructureInfo[$this->document->getDoc()->physicalStructure[$this->requestData['page']]]['annotationContainers'];
         if (
-            $annotationContainers != null
+            $annotationContainers != NULL
             && sizeof($annotationContainers) > 0
         ) {
-            $this->view->assign('annotationTool', true);
+            $this->view->assign('annotationTool', TRUE);
         } else {
-            $this->view->assign('annotationTool', false);
+            $this->view->assign('annotationTool', FALSE);
         }
     }
 
@@ -97,7 +97,7 @@ 
     public function fulltextdownloadtool()
     {
         if (
-            $this->document === null
+            $this->document === NULL
             || $this->document->getDoc()->numPages < 1
             || empty($this->extConf['fileGrpFulltext'])
         ) {
@@ -129,9 +129,9 @@ 
             }
         }
         if (!empty($fullTextFile)) {
-            $this->view->assign('fulltextDownload', true);
+            $this->view->assign('fulltextDownload', TRUE);
         } else {
-            $this->view->assign('fulltextDownload', false);
+            $this->view->assign('fulltextDownload', FALSE);
         }
     }
 
@@ -143,7 +143,7 @@ 
     public function fulltexttool()
     {
         if (
-            $this->document === null
+            $this->document === NULL
             || $this->document->getDoc()->numPages < 1
             || empty($this->extConf['fileGrpFulltext'])
         ) {
@@ -174,10 +174,10 @@ 
             }
         }
         if (!empty($fullTextFile)) {
-            $this->view->assign('fulltext', true);
+            $this->view->assign('fulltext', TRUE);
             $this->view->assign('activateFullTextInitially', MathUtility::forceIntegerInRange($this->settings['activateFullTextInitially'], 0, 1, 0));
         } else {
-            $this->view->assign('fulltext', false);
+            $this->view->assign('fulltext', FALSE);
         }
     }
 
@@ -189,7 +189,7 @@ 
     public function imagedownloadtool()
     {
         if (
-            $this->document === null
+            $this->document === NULL
             || $this->document->getDoc()->numPages < 1
             || empty($this->settings['fileGrpsImageDownload'])
         ) {
@@ -269,7 +269,7 @@ 
         // Set parent element for initialization.
         $parentContainer = !empty($this->settings['parentContainer']) ? $this->settings['parentContainer'] : '.tx-dlf-imagemanipulationtool';
 
-        $this->view->assign('imageManipulation', true);
+        $this->view->assign('imageManipulation', TRUE);
         $this->view->assign('parentContainer', $parentContainer);
     }
 
@@ -281,8 +281,8 @@ 
     public function pdfdownloadtool()
     {
         if (
-            $this->document === null
-            || $this->document->getDoc() === null
+            $this->document === NULL
+            || $this->document->getDoc() === NULL
             || $this->document->getDoc()->numPages < 1
             || empty($this->extConf['fileGrpDownload'])
         ) {
@@ -396,7 +396,7 @@ 
     public function searchindocumenttool()
     {
         if (
-            $this->document === null
+            $this->document === NULL
             || $this->document->getDoc()->numPages < 1
             || empty($this->extConf['fileGrpFulltext'])
             || empty($this->settings['solrcore'])
@@ -461,7 +461,7 @@ 
     {
         $id = $this->document->getUid();
 
-        if ($id !== null && $id > 0) {
+        if ($id !== NULL && $id > 0) {
             // we found the document uid
             return (string) $id;
         } else {

Classes/Controller/NavigationController.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
 
         $pageOptions = [];
         for ($i = 1; $i <= $this->document->getDoc()->numPages; $i++) {
-            $pageOptions[$i] = '[' . $i . ']' . ($this->document->getDoc()->physicalStructureInfo[$this->document->getDoc()->physicalStructure[$i]]['orderlabel'] ? ' - ' . htmlspecialchars($this->document->getDoc()->physicalStructureInfo[$this->document->getDoc()->physicalStructure[$i]]['orderlabel']) : '');
+            $pageOptions[$i] = '['.$i.']'.($this->document->getDoc()->physicalStructureInfo[$this->document->getDoc()->physicalStructure[$i]]['orderlabel'] ? ' - '.htmlspecialchars($this->document->getDoc()->physicalStructureInfo[$this->document->getDoc()->physicalStructure[$i]]['orderlabel']) : '');
         }
         $this->view->assign('pageOptions', $pageOptions);
 

Braces +2 added lines, -4 removed lines

@@ -23,15 +23,13 @@
  * @subpackage dlf
  * @access public
  */
-class NavigationController extends AbstractController
-{
+class NavigationController extends AbstractController {
     /**
      * The main method of the plugin
      *
      * @return void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         // Load current document.
         $this->loadDocument($this->requestData);
         if (

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -35,8 +35,8 @@ 
         // Load current document.
         $this->loadDocument($this->requestData);
         if (
-            $this->document === null
-            || $this->document->getDoc() === null
+            $this->document === NULL
+            || $this->document->getDoc() === NULL
         ) {
             // Quit without doing anything if required variables are not set.
             return;
@@ -81,7 +81,7 @@ 
         // prepare feature array for fluid
         $features = [];
         foreach (explode(',', $this->settings['features']) as $feature) {
-            $features[$feature] = true;
+            $features[$feature] = TRUE;
         }
         $this->view->assign('features', $features);
     }

Classes/Controller/TableOfContentsController.php

Spacing +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
                 }
             }
             // Append "IFSUB" to "ITEM_STATE" if this entry has sub-entries.
-            $entryArray['ITEM_STATE'] = ($entryArray['ITEM_STATE'] == 'NO' ? 'IFSUB' : $entryArray['ITEM_STATE'] . 'IFSUB');
+            $entryArray['ITEM_STATE'] = ($entryArray['ITEM_STATE'] == 'NO' ? 'IFSUB' : $entryArray['ITEM_STATE'].'IFSUB');
         }
         return $entryArray;
     }

Upper-Lower-Casing +8 added lines, -8 removed lines

@@ -60,7 +60,7 @@ 
      *
      * @return array HMENU array for menu entry
      */
-    protected function getMenuEntry(array $entry, $recursive = false)
+    protected function getMenuEntry(array $entry, $recursive = FALSE)
     {
         $entryArray = [];
         // Set "title", "volume", "type" and "pagination" from $entry array.
@@ -116,7 +116,7 @@ 
         }
         // Build sub-menu if available and called recursively.
         if (
-            $recursive === true
+            $recursive === TRUE
             && !empty($entry['children'])
         ) {
             // Build sub-menu only if one of the following conditions apply:
@@ -136,7 +136,7 @@ 
                     if (in_array($child['id'], $this->activeEntries)) {
                         $entryArray['ITEM_STATE'] = 'ACT';
                     }
-                    $entryArray['_SUB_MENU'][] = $this->getMenuEntry($child, true);
+                    $entryArray['_SUB_MENU'][] = $this->getMenuEntry($child, TRUE);
                 }
             }
             // Append "IFSUB" to "ITEM_STATE" if this entry has sub-entries.
@@ -171,8 +171,8 @@ 
         // Load current document.
         $this->loadDocument($this->requestData);
         if (
-            $this->document === null
-            || $this->document->getDoc() === null
+            $this->document === NULL
+            || $this->document->getDoc() === NULL
         ) {
             // Quit without doing anything if required variables are not set.
             return [];
@@ -219,12 +219,12 @@ 
             }
             // Go through table of contents and create all menu entries.
             foreach ($this->document->getDoc()->tableOfContents as $entry) {
-                $menuArray[] = $this->getMenuEntry($entry, true);
+                $menuArray[] = $this->getMenuEntry($entry, TRUE);
             }
         } else {
             // Go through table of contents and create top-level menu entries.
             foreach ($this->document->getDoc()->tableOfContents as $entry) {
-                $menuArray[] = $this->getMenuEntry($entry, false);
+                $menuArray[] = $this->getMenuEntry($entry, FALSE);
             }
             // Build table of contents from database.
             $result = $this->documentRepository->getTableOfContentsFromDb($this->document->getUid(), $this->document->getPid(), $this->settings);
@@ -243,7 +243,7 @@ 
                         'pagination' => '',
                         'targetUid' => $resArray['uid']
                     ];
-                    $menuArray[0]['_SUB_MENU'][] = $this->getMenuEntry($entry, false);
+                    $menuArray[0]['_SUB_MENU'][] = $this->getMenuEntry($entry, FALSE);
                 }
             }
         }

Braces +4 added lines, -8 removed lines

@@ -23,8 +23,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class TableOfContentsController extends AbstractController
-{
+class TableOfContentsController extends AbstractController {
     /**
      * This holds the active entries according to the currently selected page
      *
@@ -43,8 +42,7 @@ 
      *
      * @return array HMENU array for menu entry
      */
-    protected function getMenuEntry(array $entry, $recursive = false)
-    {
+    protected function getMenuEntry(array $entry, $recursive = false) {
         $entryArray = [];
         // Set "title", "volume", "type" and "pagination" from $entry array.
         $entryArray['title'] = !empty($entry['label']) ? $entry['label'] : $entry['orderlabel'];
@@ -131,8 +129,7 @@ 
      *
      * @return void
      */
-    public function mainAction()
-    {
+    public function mainAction() {
         $this->view->assign('toc', $this->makeMenuArray());
     }
 
@@ -142,8 +139,7 @@ 
      * @access public
      * @return array HMENU array
      */
-    public function makeMenuArray()
-    {
+    public function makeMenuArray() {
         // Load current document.
         $this->loadDocument($this->requestData);
         if (

Classes/Hooks/DataHandler.php

Spacing +9 added lines, -9 removed lines

@@ -139,10 +139,10 @@ 
                     ) {
                         // Get current configuration.
                         $result = $queryBuilder
-                            ->select($table . '.is_listed AS is_listed')
+                            ->select($table.'.is_listed AS is_listed')
                             ->from($table)
                             ->where(
-                                $queryBuilder->expr()->eq($table . '.uid', intval($id)),
+                                $queryBuilder->expr()->eq($table.'.uid', intval($id)),
                                 Helper::whereExpression($table)
                             )
                             ->setMaxResults(1)
@@ -164,10 +164,10 @@ 
                     ) {
                         // Get current configuration.
                         $result = $queryBuilder
-                            ->select($table . '.index_autocomplete AS index_autocomplete')
+                            ->select($table.'.index_autocomplete AS index_autocomplete')
                             ->from($table)
                             ->where(
-                                $queryBuilder->expr()->eq($table . '.uid', intval($id)),
+                                $queryBuilder->expr()->eq($table.'.uid', intval($id)),
                                 Helper::whereExpression($table)
                             )
                             ->setMaxResults(1)
@@ -242,7 +242,7 @@ 
                                 if ($solr->ready) {
                                     // Delete Solr document.
                                     $updateQuery = $solr->service->createUpdate();
-                                    $updateQuery->addDeleteQuery('uid:' . $id);
+                                    $updateQuery->addDeleteQuery('uid:'.$id);
                                     $updateQuery->addCommit();
                                     $solr->service->update($updateQuery);
                                 }
@@ -254,7 +254,7 @@ 
                                     $document->setDoc($doc);
                                     Indexer::add($document);
                                 } else {
-                                    $this->logger->error('Failed to re-index document with UID ' . $id);
+                                    $this->logger->error('Failed to re-index document with UID '.$id);
                                 }
                             }
                         }
@@ -321,7 +321,7 @@ 
                         if ($solr->ready) {
                             // Delete Solr document.
                             $updateQuery = $solr->service->createUpdate();
-                            $updateQuery->addDeleteQuery('uid:' . $id);
+                            $updateQuery->addDeleteQuery('uid:'.$id);
                             $updateQuery->addCommit();
                             $solr->service->update($updateQuery);
                             if ($command == 'delete') {
@@ -336,7 +336,7 @@ 
                             $document->setDoc($doc);
                             Indexer::add($document);
                         } else {
-                            $this->logger->error('Failed to re-index document with UID ' . $id);
+                            $this->logger->error('Failed to re-index document with UID '.$id);
                         }
                         break;
                 }
@@ -387,7 +387,7 @@ 
                             // Nothing to do here.
                         }
                     }
-                    $this->logger->warning('Core ' . $resArray['core'] . ' could not be deleted from Apache Solr');
+                    $this->logger->warning('Core '.$resArray['core'].' could not be deleted from Apache Solr');
                 }
             }
         }

Braces +5 added lines, -10 removed lines

@@ -34,8 +34,7 @@ 
  * @subpackage dlf
  * @access public
  */
-class DataHandler implements LoggerAwareInterface
-{
+class DataHandler implements LoggerAwareInterface {
     use LoggerAwareTrait;
 
     /**
@@ -43,8 +42,7 @@ 
      */
     protected $documentRepository;
 
-    protected function getDocumentRepository()
-    {
+    protected function getDocumentRepository() {
         if ($this->documentRepository === null) {
             $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
             $this->documentRepository = $objectManager->get(DocumentRepository::class);
@@ -65,8 +63,7 @@ 
      *
      * @return void
      */
-    public function processDatamap_postProcessFieldArray($status, $table, $id, &$fieldArray)
-    {
+    public function processDatamap_postProcessFieldArray($status, $table, $id, &$fieldArray) {
         if ($status == 'new') {
             switch ($table) {
                     // Field post-processing for table "tx_dlf_documents".
@@ -195,8 +192,7 @@ 
      *
      * @return void
      */
-    public function processDatamap_afterDatabaseOperations($status, $table, $id, &$fieldArray)
-    {
+    public function processDatamap_afterDatabaseOperations($status, $table, $id, &$fieldArray) {
         if ($status == 'update') {
             switch ($table) {
                     // After database operations for table "tx_dlf_documents".
@@ -275,8 +271,7 @@ 
      *
      * @return void
      */
-    public function processCmdmap_postProcess($command, $table, $id)
-    {
+    public function processCmdmap_postProcess($command, $table, $id) {
         if (
             in_array($command, ['move', 'delete', 'undelete'])
             && $table == 'tx_dlf_documents'

Upper-Lower-Casing +8 added lines, -8 removed lines

@@ -45,7 +45,7 @@ 
 
     protected function getDocumentRepository()
     {
-        if ($this->documentRepository === null) {
+        if ($this->documentRepository === NULL) {
             $objectManager = GeneralUtility::makeInstance(ObjectManager::class);
             $this->documentRepository = $objectManager->get(DocumentRepository::class);
         }
@@ -249,8 +249,8 @@ 
                             } else {
                                 // Reindex document.
                                 $document = $this->getDocumentRepository()->findByUid($id);
-                                $doc = Doc::getInstance($document->getLocation(), ['storagePid' => $document->getPid()], true);
-                                if ($document !== null && $doc !== null) {
+                                $doc = Doc::getInstance($document->getLocation(), ['storagePid' => $document->getPid()], TRUE);
+                                if ($document !== NULL && $doc !== NULL) {
                                     $document->setDoc($doc);
                                     Indexer::add($document);
                                 } else {
@@ -331,8 +331,8 @@ 
                     case 'undelete':
                         // Reindex document.
                         $document = $this->getDocumentRepository()->findByUid($id);
-                        $doc = Doc::getInstance($document->getLocation(), ['storagePid' => $document->getPid()], true);
-                        if ($document !== null && $doc !== null) {
+                        $doc = Doc::getInstance($document->getLocation(), ['storagePid' => $document->getPid()], TRUE);
+                        if ($document !== NULL && $doc !== NULL) {
                             $document->setDoc($doc);
                             Indexer::add($document);
                         } else {
@@ -374,9 +374,9 @@ 
                         $query = $solr->service->createCoreAdmin();
                         $action = $query->createUnload();
                         $action->setCore($resArray['core']);
-                        $action->setDeleteDataDir(true);
-                        $action->setDeleteIndex(true);
-                        $action->setDeleteInstanceDir(true);
+                        $action->setDeleteDataDir(TRUE);
+                        $action->setDeleteIndex(TRUE);
+                        $action->setDeleteInstanceDir(TRUE);
                         $query->setAction($action);
                         try {
                             $response = $solr->service->coreAdmin($query);