Completed
Push — master ( 8008ee...08c94e )
by
unknown
17s queued 13s
created
Classes/Plugin/Tools/SearchInDocumentTool.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
             '###LABEL_PAGE###' => htmlspecialchars($this->pi_getLL('label.logicalPage')),
109 109
             '###LABEL_NORESULT###' => htmlspecialchars($this->pi_getLL('label.noresult')),
110 110
             '###CURRENT_DOCUMENT###' => $this->doc->uid,
111
-            '###SOLR_ENCRYPTED###' => $encryptedSolr ?: '',
111
+            '###SOLR_ENCRYPTED###' => $encryptedSolr ? : '',
112 112
         ];
113 113
 
114 114
         $content .= $this->templateService->substituteMarkerArray($this->template, $markerArray);
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     protected function addSearchInDocumentJS()
126 126
     {
127 127
         $pageRenderer = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Page\PageRenderer::class);
128
-        $pageRenderer->addJsFooterFile(\TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath($this->extKey)) . 'Resources/Public/Javascript/Search/SearchInDocument.js');
128
+        $pageRenderer->addJsFooterFile(\TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath($this->extKey)).'Resources/Public/Javascript/Search/SearchInDocument.js');
129 129
     }
130 130
 
131 131
     /**
Please login to merge, or discard this patch.
Classes/Plugin/Search.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 
62 62
         if ($result->rowCount() == 1) {
63 63
             $pageRenderer = GeneralUtility::makeInstance(\TYPO3\CMS\Core\Page\PageRenderer::class);
64
-            $pageRenderer->addJsFooterFile(\TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath($this->extKey)) . 'Resources/Public/Javascript/Search/Suggester.js');
64
+            $pageRenderer->addJsFooterFile(\TYPO3\CMS\Core\Utility\PathUtility::stripPathSitePrefix(\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath($this->extKey)).'Resources/Public/Javascript/Search/Suggester.js');
65 65
         } else {
66 66
             Helper::devLog('No metadata fields configured for search suggestions', DEVLOG_SEVERITY_WARNING);
67 67
         }
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
             && $list->metadata['options']['source'] == 'collection'
84 84
         ) {
85 85
             // Get collection's UID.
86
-            return '<input type="hidden" name="' . $this->prefixId . '[collection]" value="' . $list->metadata['options']['select'] . '" />';
86
+            return '<input type="hidden" name="'.$this->prefixId.'[collection]" value="'.$list->metadata['options']['select'].'" />';
87 87
         } elseif (!empty($list->metadata['options']['params']['filterquery'])) {
88 88
             // Get collection's UID from search metadata.
89 89
             foreach ($list->metadata['options']['params']['filterquery'] as $facet) {
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
                     $collectionId = Helper::getUidFromIndexName(trim($facetKeyVal[1], '(")'), 'tx_dlf_collections');
96 96
                 }
97 97
             }
98
-            return '<input type="hidden" name="' . $this->prefixId . '[collection]" value="' . $collectionId . '" />';
98
+            return '<input type="hidden" name="'.$this->prefixId.'[collection]" value="'.$collectionId.'" />';
99 99
         }
100 100
         return '';
101 101
     }
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
             $this->loadDocument();
120 120
             // Get document's UID or parent ID.
121 121
             if ($this->doc->ready) {
122
-                return '<input type="hidden" name="' . $this->prefixId . '[id]" value="' . ($this->doc->parentId > 0 ? $this->doc->parentId : $this->doc->uid) . '" />';
122
+                return '<input type="hidden" name="'.$this->prefixId.'[id]" value="'.($this->doc->parentId > 0 ? $this->doc->parentId : $this->doc->uid).'" />';
123 123
             }
124 124
         } elseif (!empty($list->metadata['options']['params']['filterquery'])) {
125 125
             // Get document's UID from search metadata.
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
                     $documentId = (int) substr($facetKeyVal[1], 1, strpos($facetKeyVal[1], ')'));
130 130
                 }
131 131
             }
132
-            return '<input type="hidden" name="' . $this->prefixId . '[id]" value="' . $documentId . '" />';
132
+            return '<input type="hidden" name="'.$this->prefixId.'[id]" value="'.$documentId.'" />';
133 133
         }
134 134
         return '';
135 135
     }
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
         }
152 152
         // Add encrypted fields to search form.
153 153
         if ($name !== false) {
154
-            return '<input type="hidden" name="' . $this->prefixId . '[encrypted]" value="' . $name . '" />';
154
+            return '<input type="hidden" name="'.$this->prefixId.'[encrypted]" value="'.$name.'" />';
155 155
         } else {
156 156
             return '';
157 157
         }
@@ -177,19 +177,19 @@  discard block
 block discarded – undo
177 177
         // Get operator options.
178 178
         $operatorOptions = '';
179 179
         foreach (['AND', 'OR', 'NOT'] as $operator) {
180
-            $operatorOptions .= '<option class="tx-dlf-search-operator-option tx-dlf-search-operator-' . $operator . '" value="' . $operator . '">' . htmlspecialchars($this->pi_getLL($operator, '')) . '</option>';
180
+            $operatorOptions .= '<option class="tx-dlf-search-operator-option tx-dlf-search-operator-'.$operator.'" value="'.$operator.'">'.htmlspecialchars($this->pi_getLL($operator, '')).'</option>';
181 181
         }
182 182
         // Get field selector options.
183 183
         $fieldSelectorOptions = '';
184 184
         $searchFields = GeneralUtility::trimExplode(',', $this->conf['extendedFields'], true);
185 185
         foreach ($searchFields as $searchField) {
186
-            $fieldSelectorOptions .= '<option class="tx-dlf-search-field-option tx-dlf-search-field-' . $searchField . '" value="' . $searchField . '">' . Helper::translate($searchField, 'tx_dlf_metadata', $this->conf['pages']) . '</option>';
186
+            $fieldSelectorOptions .= '<option class="tx-dlf-search-field-option tx-dlf-search-field-'.$searchField.'" value="'.$searchField.'">'.Helper::translate($searchField, 'tx_dlf_metadata', $this->conf['pages']).'</option>';
187 187
         }
188 188
         for ($i = 0; $i < $this->conf['extendedSlotCount']; $i++) {
189 189
             $markerArray = [
190
-                '###EXT_SEARCH_OPERATOR###' => '<select class="tx-dlf-search-operator tx-dlf-search-operator-' . $i . '" name="' . $this->prefixId . '[extOperator][' . $i . ']">' . $operatorOptions . '</select>',
191
-                '###EXT_SEARCH_FIELDSELECTOR###' => '<select class="tx-dlf-search-field tx-dlf-search-field-' . $i . '" name="' . $this->prefixId . '[extField][' . $i . ']">' . $fieldSelectorOptions . '</select>',
192
-                '###EXT_SEARCH_FIELDQUERY###' => '<input class="tx-dlf-search-query tx-dlf-search-query-' . $i . '" type="text" name="' . $this->prefixId . '[extQuery][' . $i . ']" />'
190
+                '###EXT_SEARCH_OPERATOR###' => '<select class="tx-dlf-search-operator tx-dlf-search-operator-'.$i.'" name="'.$this->prefixId.'[extOperator]['.$i.']">'.$operatorOptions.'</select>',
191
+                '###EXT_SEARCH_FIELDSELECTOR###' => '<select class="tx-dlf-search-field tx-dlf-search-field-'.$i.'" name="'.$this->prefixId.'[extField]['.$i.']">'.$fieldSelectorOptions.'</select>',
192
+                '###EXT_SEARCH_FIELDQUERY###' => '<input class="tx-dlf-search-query tx-dlf-search-query-'.$i.'" type="text" name="'.$this->prefixId.'[extQuery]['.$i.']" />'
193 193
             ];
194 194
             $extendedSearch .= $this->templateService->substituteMarkerArray($this->templateService->getSubpart($this->template, '###EXT_SEARCH_ENTRY###'), $markerArray);
195 195
         }
@@ -217,12 +217,12 @@  discard block
 block discarded – undo
217 217
         // Get facets from plugin configuration.
218 218
         $facets = [];
219 219
         foreach (GeneralUtility::trimExplode(',', $this->conf['facets'], true) as $facet) {
220
-            $facets[$facet . '_faceting'] = Helper::translate($facet, 'tx_dlf_metadata', $this->conf['pages']);
220
+            $facets[$facet.'_faceting'] = Helper::translate($facet, 'tx_dlf_metadata', $this->conf['pages']);
221 221
         }
222 222
         // Render facets menu.
223 223
         $TSconfig = [];
224 224
         $TSconfig['special'] = 'userfunction';
225
-        $TSconfig['special.']['userFunc'] = \Kitodo\Dlf\Plugin\Search::class . '->makeFacetsMenuArray';
225
+        $TSconfig['special.']['userFunc'] = \Kitodo\Dlf\Plugin\Search::class.'->makeFacetsMenuArray';
226 226
         $TSconfig['special.']['facets'] = $facets;
227 227
         $TSconfig['special.']['limit'] = max(intval($this->conf['limitFacets']), 1);
228 228
         $TSconfig = Helper::mergeRecursiveWithOverrule($this->conf['facetsConf.'], $TSconfig);
@@ -243,10 +243,10 @@  discard block
 block discarded – undo
243 243
         $output = '';
244 244
         // Check for plugin configuration.
245 245
         if (!empty($this->conf['fulltext'])) {
246
-            $output .= ' <input class="tx-dlf-search-fulltext" id="tx-dlf-search-fulltext-no" type="radio" name="' . $this->prefixId . '[fulltext]" value="0" ' . ($isFulltextSearch == 0 ? 'checked="checked"' : '') . ' />';
247
-            $output .= ' <label for="tx-dlf-search-fulltext-no">' . htmlspecialchars($this->pi_getLL('label.inMetadata', '')) . '</label>';
248
-            $output .= ' <input class="tx-dlf-search-fulltext" id="tx-dlf-search-fulltext-yes" type="radio" name="' . $this->prefixId . '[fulltext]" value="1" ' . ($isFulltextSearch == 1 ? 'checked="checked"' : '') . '/>';
249
-            $output .= ' <label for="tx-dlf-search-fulltext-yes">' . htmlspecialchars($this->pi_getLL('label.inFulltext', '')) . '</label>';
246
+            $output .= ' <input class="tx-dlf-search-fulltext" id="tx-dlf-search-fulltext-no" type="radio" name="'.$this->prefixId.'[fulltext]" value="0" '.($isFulltextSearch == 0 ? 'checked="checked"' : '').' />';
247
+            $output .= ' <label for="tx-dlf-search-fulltext-no">'.htmlspecialchars($this->pi_getLL('label.inMetadata', '')).'</label>';
248
+            $output .= ' <input class="tx-dlf-search-fulltext" id="tx-dlf-search-fulltext-yes" type="radio" name="'.$this->prefixId.'[fulltext]" value="1" '.($isFulltextSearch == 1 ? 'checked="checked"' : '').'/>';
249
+            $output .= ' <label for="tx-dlf-search-fulltext-yes">'.htmlspecialchars($this->pi_getLL('label.inFulltext', '')).'</label>';
250 250
         }
251 251
         return $output;
252 252
     }
@@ -263,8 +263,8 @@  discard block
 block discarded – undo
263 263
         $output = '';
264 264
         // Check for plugin configuration.
265 265
         if (!empty($this->conf['showLogicalPageField'])) {
266
-            $output .= ' <label for="tx-dlf-search-logical-page">' . htmlspecialchars($this->pi_getLL('label.logicalPage', '')) . ': </label>';
267
-            $output .= ' <input class="tx-dlf-search-logical-page" id="tx-dlf-search-logical-page" type="text" name="' . $this->prefixId . '[logicalPage]" />';
266
+            $output .= ' <label for="tx-dlf-search-logical-page">'.htmlspecialchars($this->pi_getLL('label.logicalPage', '')).': </label>';
267
+            $output .= ' <input class="tx-dlf-search-logical-page" id="tx-dlf-search-logical-page" type="text" name="'.$this->prefixId.'[logicalPage]" />';
268 268
         }
269 269
         return $output;
270 270
     }
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
305 305
         $entryArray['doNotLinkIt'] = 0;
306 306
         // Check if facet is already selected.
307 307
         $queryColumn = array_column($search['params']['filterquery'], 'query');
308
-        $index = array_search($field . ':("' . Solr::escapeQuery($value) . '")', $queryColumn);
308
+        $index = array_search($field.':("'.Solr::escapeQuery($value).'")', $queryColumn);
309 309
         if ($index !== false) {
310 310
             // Facet is selected, thus remove it from filter.
311 311
             unset($queryColumn[$index]);
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
             }
323 323
         } else {
324 324
             // Facet is not selected, thus add it to filter.
325
-            $queryColumn[] = $field . ':("' . Solr::escapeQuery($value) . '")';
325
+            $queryColumn[] = $field.':("'.Solr::escapeQuery($value).'")';
326 326
             $entryArray['ITEM_STATE'] = 'NO';
327 327
         }
328 328
         $entryArray['_OVERRIDE_HREF'] = $this->pi_linkTP_keepPIvars_url(['query' => $search['query'], 'fq' => $queryColumn]);
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
                 '###ACTION_URL###' => $this->cObj->typoLink_URL($linkConf),
379 379
                 '###LABEL_QUERY###' => (!empty($search['query']) ? htmlspecialchars($search['query']) : htmlspecialchars($this->pi_getLL('label.query'))),
380 380
                 '###LABEL_SUBMIT###' => htmlspecialchars($this->pi_getLL('label.submit')),
381
-                '###FIELD_QUERY###' => $this->prefixId . '[query]',
381
+                '###FIELD_QUERY###' => $this->prefixId.'[query]',
382 382
                 '###QUERY###' => (!empty($search['query']) ? htmlspecialchars($search['query']) : ''),
383 383
                 '###FULLTEXTSWITCH###' => $this->addFulltextSwitch($list->metadata['fulltextSearch']),
384 384
                 '###FIELD_DOC###' => ($this->conf['searchIn'] == 'document' || $this->conf['searchIn'] == 'all' ? $this->addCurrentDocument() : ''),
@@ -410,7 +410,7 @@  discard block
 block discarded – undo
410 410
                 $this->piVars['query'] = empty($matches[1]) ? $this->piVars['query'] : $matches[1];
411 411
                 // Search in fulltext field if applicable. Query must not be empty!
412 412
                 if (!empty($this->piVars['query'])) {
413
-                    $query = 'fulltext:(' . Solr::escapeQuery(trim($this->piVars['query'])) . ')';
413
+                    $query = 'fulltext:('.Solr::escapeQuery(trim($this->piVars['query'])).')';
414 414
                 }
415 415
             } else {
416 416
                 // Retain given search field if valid.
@@ -431,9 +431,9 @@  discard block
 block discarded – undo
431 431
                             && in_array($this->piVars['extField'][$i], $allowedFields)
432 432
                         ) {
433 433
                             if (!empty($query)) {
434
-                                $query .= ' ' . $this->piVars['extOperator'][$i] . ' ';
434
+                                $query .= ' '.$this->piVars['extOperator'][$i].' ';
435 435
                             }
436
-                            $query .= Indexer::getIndexFieldName($this->piVars['extField'][$i], $this->conf['pages']) . ':(' . Solr::escapeQuery($this->piVars['extQuery'][$i]) . ')';
436
+                            $query .= Indexer::getIndexFieldName($this->piVars['extField'][$i], $this->conf['pages']).':('.Solr::escapeQuery($this->piVars['extQuery'][$i]).')';
437 437
                         }
438 438
                     }
439 439
                 }
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
                     !empty($this->piVars['id'])
454 454
                     && \TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($this->piVars['id'])
455 455
                 ) {
456
-                    $params['filterquery'][]['query'] = 'uid:(' . $this->piVars['id'] . ') OR partof:(' . $this->piVars['id'] . ')';
456
+                    $params['filterquery'][]['query'] = 'uid:('.$this->piVars['id'].') OR partof:('.$this->piVars['id'].')';
457 457
                     $label .= htmlspecialchars(sprintf($this->pi_getLL('in', ''), Document::getTitle($this->piVars['id'])));
458 458
                 }
459 459
             }
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
                     && \TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($this->piVars['collection'])
468 468
                 ) {
469 469
                     $index_name = Helper::getIndexNameFromUid($this->piVars['collection'], 'tx_dlf_collections', $this->conf['pages']);
470
-                    $params['filterquery'][]['query'] = 'collection_faceting:("' . Solr::escapeQuery($index_name) . '")';
470
+                    $params['filterquery'][]['query'] = 'collection_faceting:("'.Solr::escapeQuery($index_name).'")';
471 471
                     $label .= sprintf($this->pi_getLL('in', '', true), Helper::translate($index_name, 'tx_dlf_collections', $this->conf['pages']));
472 472
                 }
473 473
             }
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
                     $collIndexNames[] = Solr::escapeQuery(Helper::getIndexNameFromUid(intval($collId), 'tx_dlf_collections', $this->conf['pages']));
480 480
                 }
481 481
                 // Last value is fake and used for distinction in $this->addCurrentCollection()
482
-                $params['filterquery'][]['query'] = 'collection_faceting:("' . implode('" OR "', $collIndexNames) . '" OR "FakeValueForDistinction")';
482
+                $params['filterquery'][]['query'] = 'collection_faceting:("'.implode('" OR "', $collIndexNames).'" OR "FakeValueForDistinction")';
483 483
             }
484 484
             // Set some query parameters.
485 485
             $params['query'] = !empty($query) ? $query : '*';
@@ -529,7 +529,7 @@  discard block
 block discarded – undo
529 529
             $linkConf['forceAbsoluteUrl.']['scheme'] = !empty($this->conf['forceAbsoluteUrl']) && !empty($this->conf['forceAbsoluteUrlHttps']) ? 'https' : 'http';
530 530
             $linkConf['additionalParams'] = GeneralUtility::implodeArrayForUrl($this->prefixId, $additionalParams, '', true, false);
531 531
             // Send headers.
532
-            header('Location: ' . GeneralUtility::locationHeaderUrl($this->cObj->typoLink_URL($linkConf)));
532
+            header('Location: '.GeneralUtility::locationHeaderUrl($this->cObj->typoLink_URL($linkConf)));
533 533
             exit;
534 534
         }
535 535
     }
Please login to merge, or discard this patch.
Classes/Common/Solr.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     {
129 129
         // Get next available core name if none given.
130 130
         if (empty($core)) {
131
-            $core = 'dlfCore' . self::getNextCoreNumber();
131
+            $core = 'dlfCore'.self::getNextCoreNumber();
132 132
         }
133 133
         // Get Solr service instance.
134 134
         $solr = self::getInstance($core);
@@ -224,13 +224,13 @@  discard block
 block discarded – undo
224 224
                 ->execute();
225 225
 
226 226
             while ($resArray = $result->fetch()) {
227
-                $fields[] = $resArray['index_name'] . '_' . ($resArray['index_tokenized'] ? 't' : 'u') . ($resArray['index_stored'] ? 's' : 'u') . 'i';
227
+                $fields[] = $resArray['index_name'].'_'.($resArray['index_tokenized'] ? 't' : 'u').($resArray['index_stored'] ? 's' : 'u').'i';
228 228
             }
229 229
 
230 230
             // Check if queried field is valid.
231 231
             $splitQuery = explode(':', $query, 2);
232 232
             if (in_array($splitQuery[0], $fields)) {
233
-                $query = $splitQuery[0] . ':(' . self::escapeQuery(trim($splitQuery[1], '()')) . ')';
233
+                $query = $splitQuery[0].':('.self::escapeQuery(trim($splitQuery[1], '()')).')';
234 234
             } else {
235 235
                 $query = self::escapeQuery($query);
236 236
             }
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
     {
295 295
         $number = max(intval($number), 0);
296 296
         // Check if core already exists.
297
-        $solr = self::getInstance('dlfCore' . $number);
297
+        $solr = self::getInstance('dlfCore'.$number);
298 298
         if (!$solr->ready) {
299 299
             return $number;
300 300
         } else {
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
                 $config['path'] .= 'solr/';
336 336
             }
337 337
             // Set connection timeout lower than PHP's max_execution_time.
338
-            $max_execution_time = intval(ini_get('max_execution_time')) ?: 30;
338
+            $max_execution_time = intval(ini_get('max_execution_time')) ? : 30;
339 339
             $config['timeout'] = MathUtility::forceIntegerInRange($conf['solrTimeout'], 1, $max_execution_time, 10);
340 340
             $this->config = $config;
341 341
         }
@@ -369,13 +369,13 @@  discard block
 block discarded – undo
369 369
         // Extend filter query to get all documents with the same uids.
370 370
         foreach ($params['filterquery'] as $key => $value) {
371 371
             if (isset($value['query'])) {
372
-                $params['filterquery'][$key]['query'] = '{!join from=uid to=uid}' . $value['query'];
372
+                $params['filterquery'][$key]['query'] = '{!join from=uid to=uid}'.$value['query'];
373 373
             }
374 374
         }
375 375
         // Set filter query to just get toplevel documents.
376 376
         $params['filterquery'][] = ['query' => 'toplevel:true'];
377 377
         // Set join query to get all documents with the same uids.
378
-        $params['query'] = '{!join from=uid to=uid}' . $params['query'];
378
+        $params['query'] = '{!join from=uid to=uid}'.$params['query'];
379 379
         // Perform search to determine the total number of toplevel hits and fetch the required rows.
380 380
         $selectQuery = $this->service->createSelect($params);
381 381
         $results = $this->service->select($selectQuery);
@@ -432,7 +432,7 @@  discard block
 block discarded – undo
432 432
         // Set query.
433 433
         $parameters['query'] = $query;
434 434
         // Calculate cache identifier.
435
-        $cacheIdentifier = Helper::digest($this->core . print_r(array_merge($this->params, $parameters), true));
435
+        $cacheIdentifier = Helper::digest($this->core.print_r(array_merge($this->params, $parameters), true));
436 436
         $cache = GeneralUtility::makeInstance(CacheManager::class)->getCache('tx_dlf_solr');
437 437
         $resultSet = [];
438 438
         if (($entry = $cache->get($cacheIdentifier)) === false) {
@@ -563,12 +563,12 @@  discard block
 block discarded – undo
563 563
      */
564 564
     public function __get($var)
565 565
     {
566
-        $method = '_get' . ucfirst($var);
566
+        $method = '_get'.ucfirst($var);
567 567
         if (
568 568
             !property_exists($this, $var)
569 569
             || !method_exists($this, $method)
570 570
         ) {
571
-            Helper::devLog('There is no getter function for property "' . $var . '"', DEVLOG_SEVERITY_WARNING);
571
+            Helper::devLog('There is no getter function for property "'.$var.'"', DEVLOG_SEVERITY_WARNING);
572 572
             return;
573 573
         } else {
574 574
             return $this->$method();
@@ -601,12 +601,12 @@  discard block
 block discarded – undo
601 601
      */
602 602
     public function __set($var, $value)
603 603
     {
604
-        $method = '_set' . ucfirst($var);
604
+        $method = '_set'.ucfirst($var);
605 605
         if (
606 606
             !property_exists($this, $var)
607 607
             || !method_exists($this, $method)
608 608
         ) {
609
-            Helper::devLog('There is no setter function for property "' . $var . '"', DEVLOG_SEVERITY_WARNING);
609
+            Helper::devLog('There is no setter function for property "'.$var.'"', DEVLOG_SEVERITY_WARNING);
610 610
         } else {
611 611
             $this->$method($value);
612 612
         }
@@ -643,7 +643,7 @@  discard block
 block discarded – undo
643 643
                     'scheme' => $this->config['scheme'],
644 644
                     'host' => $this->config['host'],
645 645
                     'port' => $this->config['port'],
646
-                    'path' => '/' . $this->config['path'],
646
+                    'path' => '/'.$this->config['path'],
647 647
                     'core' => $core,
648 648
                     'username' => $this->config['username'],
649 649
                     'password' => $this->config['password'],
Please login to merge, or discard this patch.
Classes/Common/Helper.php 1 patch
Spacing   +48 added lines, -48 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
                 if (!preg_match('/[0-9]{8}-[0-9]{1}/i', $id)) {
136 136
                     return false;
137 137
                 } elseif ($checksum == 10) {
138
-                    return self::checkIdentifier(($digits + 1) . substr($id, -2, 2), 'SWD');
138
+                    return self::checkIdentifier(($digits + 1).substr($id, -2, 2), 'SWD');
139 139
                 } elseif (substr($id, -1, 1) != $checksum) {
140 140
                     return false;
141 141
                 }
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
             $args = [];
215 215
             $data = [];
216 216
             if (!empty($stacktrace[1])) {
217
-                $caller = $stacktrace[1]['class'] . $stacktrace[1]['type'] . $stacktrace[1]['function'];
217
+                $caller = $stacktrace[1]['class'].$stacktrace[1]['type'].$stacktrace[1]['function'];
218 218
                 foreach ($stacktrace[1]['args'] as $arg) {
219 219
                     if (is_bool($arg)) {
220 220
                         $args[] = ($arg ? 'true' : 'false');
@@ -226,14 +226,14 @@  discard block
 block discarded – undo
226 226
                         $args[] = '[data]';
227 227
                         $data[] = $arg;
228 228
                     } elseif (is_object($arg)) {
229
-                        $args[] = '[' . get_class($arg) . ']';
229
+                        $args[] = '['.get_class($arg).']';
230 230
                         $data[] = $arg;
231 231
                     }
232 232
                 }
233 233
             }
234
-            $arguments = '(' . implode(', ', $args) . ')';
234
+            $arguments = '('.implode(', ', $args).')';
235 235
             $additionalData = (empty($data) ? false : $data);
236
-            /** @scrutinizer ignore-deprecated */ \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('[' . $caller . $arguments . '] ' . $message, self::$extKey, $severity, $additionalData);
236
+            /** @scrutinizer ignore-deprecated */ \TYPO3\CMS\Core\Utility\GeneralUtility::devLog('['.$caller.$arguments.'] '.$message, self::$extKey, $severity, $additionalData);
237 237
         }
238 238
     }
239 239
 
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
         $encrypted = openssl_encrypt($string, self::$cipherAlgorithm, $key, OPENSSL_RAW_DATA, $iv);
287 287
         // Merge initialisation vector and encrypted data.
288 288
         if ($encrypted !== false) {
289
-            $encrypted = base64_encode($iv . $encrypted);
289
+            $encrypted = base64_encode($iv.$encrypted);
290 290
         }
291 291
         return $encrypted;
292 292
     }
@@ -340,8 +340,8 @@  discard block
 block discarded – undo
340 340
     public static function getHookObjects($scriptRelPath)
341 341
     {
342 342
         $hookObjects = [];
343
-        if (is_array($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][self::$extKey . '/' . $scriptRelPath]['hookClass'])) {
344
-            foreach ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][self::$extKey . '/' . $scriptRelPath]['hookClass'] as $classRef) {
343
+        if (is_array($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][self::$extKey.'/'.$scriptRelPath]['hookClass'])) {
344
+            foreach ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][self::$extKey.'/'.$scriptRelPath]['hookClass'] as $classRef) {
345 345
                 $hookObjects[] = &\TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance($classRef);
346 346
             }
347 347
         }
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
             !$uid
368 368
             || !in_array($table, ['tx_dlf_collections', 'tx_dlf_libraries', 'tx_dlf_metadata', 'tx_dlf_structures', 'tx_dlf_solrcores'])
369 369
         ) {
370
-            self::devLog('Invalid UID "' . $uid . '" or table "' . $table . '"', DEVLOG_SEVERITY_ERROR);
370
+            self::devLog('Invalid UID "'.$uid.'" or table "'.$table.'"', DEVLOG_SEVERITY_ERROR);
371 371
             return '';
372 372
         }
373 373
 
@@ -378,15 +378,15 @@  discard block
 block discarded – undo
378 378
         // Should we check for a specific PID, too?
379 379
         if ($pid !== -1) {
380 380
             $pid = max(intval($pid), 0);
381
-            $where = $queryBuilder->expr()->eq($table . '.pid', $pid);
381
+            $where = $queryBuilder->expr()->eq($table.'.pid', $pid);
382 382
         }
383 383
 
384 384
         // Get index_name from database.
385 385
         $result = $queryBuilder
386
-            ->select($table . '.index_name AS index_name')
386
+            ->select($table.'.index_name AS index_name')
387 387
             ->from($table)
388 388
             ->where(
389
-                $queryBuilder->expr()->eq($table . '.uid', $uid),
389
+                $queryBuilder->expr()->eq($table.'.uid', $uid),
390 390
                 $where,
391 391
                 self::whereExpression($table)
392 392
             )
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
         if ($resArray = $result->fetch()) {
397 397
             return $resArray['index_name'];
398 398
         } else {
399
-            self::devLog('No "index_name" with UID ' . $uid . ' and PID ' . $pid . ' found in table "' . $table . '"', DEVLOG_SEVERITY_WARNING);
399
+            self::devLog('No "index_name" with UID '.$uid.' and PID '.$pid.' found in table "'.$table.'"', DEVLOG_SEVERITY_WARNING);
400 400
             return '';
401 401
         }
402 402
     }
@@ -415,9 +415,9 @@  discard block
 block discarded – undo
415 415
         // Analyze code and set appropriate ISO table.
416 416
         $isoCode = strtolower(trim($code));
417 417
         if (preg_match('/^[a-z]{3}$/', $isoCode)) {
418
-            $file = \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath(self::$extKey) . 'Resources/Private/Data/iso-639-2b.xml';
418
+            $file = \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath(self::$extKey).'Resources/Private/Data/iso-639-2b.xml';
419 419
         } elseif (preg_match('/^[a-z]{2}$/', $isoCode)) {
420
-            $file = \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath(self::$extKey) . 'Resources/Private/Data/iso-639-1.xml';
420
+            $file = \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath(self::$extKey).'Resources/Private/Data/iso-639-1.xml';
421 421
         } else {
422 422
             // No ISO code, return unchanged.
423 423
             return $code;
@@ -434,13 +434,13 @@  discard block
 block discarded – undo
434 434
                 $lang = $GLOBALS['LANG']->getLLL($isoCode, $iso639);
435 435
             }
436 436
         } else {
437
-            self::devLog('Unexpected TYPO3_MODE "' . \TYPO3_MODE . '"', DEVLOG_SEVERITY_ERROR);
437
+            self::devLog('Unexpected TYPO3_MODE "'.\TYPO3_MODE.'"', DEVLOG_SEVERITY_ERROR);
438 438
             return $code;
439 439
         }
440 440
         if (!empty($lang)) {
441 441
             return $lang;
442 442
         } else {
443
-            self::devLog('Language code "' . $code . '" not found in ISO-639 table', DEVLOG_SEVERITY_NOTICE);
443
+            self::devLog('Language code "'.$code.'" not found in ISO-639 table', DEVLOG_SEVERITY_NOTICE);
444 444
             return $code;
445 445
         }
446 446
     }
@@ -468,7 +468,7 @@  discard block
 block discarded – undo
468 468
             } elseif (\TYPO3_MODE === 'BE') {
469 469
                 self::$messages = $GLOBALS['LANG']->includeLLFile($file, false, true);
470 470
             } else {
471
-                self::devLog('Unexpected TYPO3_MODE "' . \TYPO3_MODE . '"', DEVLOG_SEVERITY_ERROR);
471
+                self::devLog('Unexpected TYPO3_MODE "'.\TYPO3_MODE.'"', DEVLOG_SEVERITY_ERROR);
472 472
             }
473 473
         }
474 474
         // Get translation.
@@ -478,7 +478,7 @@  discard block
 block discarded – undo
478 478
             } elseif (\TYPO3_MODE === 'BE') {
479 479
                 $translated = $GLOBALS['LANG']->getLLL($key, self::$messages);
480 480
             } else {
481
-                self::devLog('Unexpected TYPO3_MODE "' . \TYPO3_MODE . '"', DEVLOG_SEVERITY_ERROR);
481
+                self::devLog('Unexpected TYPO3_MODE "'.\TYPO3_MODE.'"', DEVLOG_SEVERITY_ERROR);
482 482
             }
483 483
         }
484 484
         // Escape HTML characters if applicable.
@@ -505,7 +505,7 @@  discard block
 block discarded – undo
505 505
             !$index_name
506 506
             || !in_array($table, ['tx_dlf_collections', 'tx_dlf_libraries', 'tx_dlf_metadata', 'tx_dlf_structures', 'tx_dlf_solrcores'])
507 507
         ) {
508
-            self::devLog('Invalid UID ' . $index_name . ' or table "' . $table . '"', DEVLOG_SEVERITY_ERROR);
508
+            self::devLog('Invalid UID '.$index_name.' or table "'.$table.'"', DEVLOG_SEVERITY_ERROR);
509 509
             return '';
510 510
         }
511 511
 
@@ -516,14 +516,14 @@  discard block
 block discarded – undo
516 516
         // Should we check for a specific PID, too?
517 517
         if ($pid !== -1) {
518 518
             $pid = max(intval($pid), 0);
519
-            $where = $queryBuilder->expr()->eq($table . '.pid', $pid);
519
+            $where = $queryBuilder->expr()->eq($table.'.pid', $pid);
520 520
         }
521 521
         // Get index_name from database.
522 522
         $result = $queryBuilder
523
-            ->select($table . '.uid AS uid')
523
+            ->select($table.'.uid AS uid')
524 524
             ->from($table)
525 525
             ->where(
526
-                $queryBuilder->expr()->eq($table . '.index_name', $queryBuilder->expr()->literal($index_name)),
526
+                $queryBuilder->expr()->eq($table.'.index_name', $queryBuilder->expr()->literal($index_name)),
527 527
                 $where,
528 528
                 self::whereExpression($table)
529 529
             )
@@ -535,7 +535,7 @@  discard block
 block discarded – undo
535 535
         if (count($allResults) == 1) {
536 536
             return $allResults[0]['uid'];
537 537
         } else {
538
-            self::devLog('No UID for given index_name "' . $index_name . '" and PID ' . $pid . ' found in table "' . $table . '"', DEVLOG_SEVERITY_WARNING);
538
+            self::devLog('No UID for given index_name "'.$index_name.'" and PID '.$pid.' found in table "'.$table.'"', DEVLOG_SEVERITY_WARNING);
539 539
             return '';
540 540
         }
541 541
     }
@@ -593,7 +593,7 @@  discard block
 block discarded – undo
593 593
             '-' => 39,
594 594
             ':' => 17,
595 595
         ];
596
-        $urn = strtolower($base . $id);
596
+        $urn = strtolower($base.$id);
597 597
         if (preg_match('/[^a-z0-9:-]/', $urn)) {
598 598
             self::devLog('Invalid chars in given parameters', DEVLOG_SEVERITY_WARNING);
599 599
             return '';
@@ -607,7 +607,7 @@  discard block
 block discarded – undo
607 607
             $checksum += ($i + 1) * intval(substr($digits, $i, 1));
608 608
         }
609 609
         $checksum = substr(intval($checksum / intval(substr($digits, -1, 1))), -1, 1);
610
-        return $base . $id . $checksum;
610
+        return $base.$id.$checksum;
611 611
     }
612 612
 
613 613
     /**
@@ -638,7 +638,7 @@  discard block
 block discarded – undo
638 638
         // Cast to string for security reasons.
639 639
         $key = (string) $key;
640 640
         if (!$key) {
641
-            self::devLog('Invalid key "' . $key . '" for session data retrieval', DEVLOG_SEVERITY_WARNING);
641
+            self::devLog('Invalid key "'.$key.'" for session data retrieval', DEVLOG_SEVERITY_WARNING);
642 642
             return;
643 643
         }
644 644
         // Get the session data.
@@ -647,7 +647,7 @@  discard block
 block discarded – undo
647 647
         } elseif (\TYPO3_MODE === 'BE') {
648 648
             return $GLOBALS['BE_USER']->getSessionData($key);
649 649
         } else {
650
-            self::devLog('Unexpected TYPO3_MODE "' . \TYPO3_MODE . '"', DEVLOG_SEVERITY_ERROR);
650
+            self::devLog('Unexpected TYPO3_MODE "'.\TYPO3_MODE.'"', DEVLOG_SEVERITY_ERROR);
651 651
             return;
652 652
         }
653 653
     }
@@ -756,7 +756,7 @@  discard block
 block discarded – undo
756 756
         // Cast to string for security reasons.
757 757
         $key = (string) $key;
758 758
         if (!$key) {
759
-            self::devLog('Invalid key "' . $key . '" for session data saving', DEVLOG_SEVERITY_WARNING);
759
+            self::devLog('Invalid key "'.$key.'" for session data saving', DEVLOG_SEVERITY_WARNING);
760 760
             return false;
761 761
         }
762 762
         // Save value in session data.
@@ -768,7 +768,7 @@  discard block
 block discarded – undo
768 768
             $GLOBALS['BE_USER']->setAndSaveSessionData($key, $value);
769 769
             return true;
770 770
         } else {
771
-            self::devLog('Unexpected TYPO3_MODE "' . \TYPO3_MODE . '"', DEVLOG_SEVERITY_ERROR);
771
+            self::devLog('Unexpected TYPO3_MODE "'.\TYPO3_MODE.'"', DEVLOG_SEVERITY_ERROR);
772 772
             return false;
773 773
         }
774 774
     }
@@ -791,7 +791,7 @@  discard block
 block discarded – undo
791 791
         // Sanitize input.
792 792
         $pid = max(intval($pid), 0);
793 793
         if (!$pid) {
794
-            self::devLog('Invalid PID ' . $pid . ' for translation', DEVLOG_SEVERITY_WARNING);
794
+            self::devLog('Invalid PID '.$pid.' for translation', DEVLOG_SEVERITY_WARNING);
795 795
             return $index_name;
796 796
         }
797 797
         // Check if "index_name" is an UID.
@@ -808,13 +808,13 @@  discard block
 block discarded – undo
808 808
         // First fetch the uid of the received index_name
809 809
         $result = $queryBuilder
810 810
             ->select(
811
-                $table . '.uid AS uid',
812
-                $table . '.l18n_parent AS l18n_parent'
811
+                $table.'.uid AS uid',
812
+                $table.'.l18n_parent AS l18n_parent'
813 813
             )
814 814
             ->from($table)
815 815
             ->where(
816
-                $queryBuilder->expr()->eq($table . '.pid', $pid),
817
-                $queryBuilder->expr()->eq($table . '.index_name', $queryBuilder->expr()->literal($index_name)),
816
+                $queryBuilder->expr()->eq($table.'.pid', $pid),
817
+                $queryBuilder->expr()->eq($table.'.index_name', $queryBuilder->expr()->literal($index_name)),
818 818
                 self::whereExpression($table, true)
819 819
             )
820 820
             ->setMaxResults(1)
@@ -827,12 +827,12 @@  discard block
 block discarded – undo
827 827
             $resArray = $allResults[0];
828 828
 
829 829
             $result = $queryBuilder
830
-                ->select($table . '.index_name AS index_name')
830
+                ->select($table.'.index_name AS index_name')
831 831
                 ->from($table)
832 832
                 ->where(
833
-                    $queryBuilder->expr()->eq($table . '.pid', $pid),
834
-                    $queryBuilder->expr()->eq($table . '.uid', $resArray['l18n_parent']),
835
-                    $queryBuilder->expr()->eq($table . '.sys_language_uid', intval($GLOBALS['TSFE']->sys_language_content)),
833
+                    $queryBuilder->expr()->eq($table.'.pid', $pid),
834
+                    $queryBuilder->expr()->eq($table.'.uid', $resArray['l18n_parent']),
835
+                    $queryBuilder->expr()->eq($table.'.sys_language_uid', intval($GLOBALS['TSFE']->sys_language_content)),
836 836
                     self::whereExpression($table, true)
837 837
                 )
838 838
                 ->setMaxResults(1)
@@ -850,14 +850,14 @@  discard block
 block discarded – undo
850 850
         if (empty($labels[$table][$pid][$GLOBALS['TSFE']->sys_language_content][$index_name])) {
851 851
             // Check if this table is allowed for translation.
852 852
             if (in_array($table, ['tx_dlf_collections', 'tx_dlf_libraries', 'tx_dlf_metadata', 'tx_dlf_structures'])) {
853
-                $additionalWhere = $queryBuilder->expr()->in($table . '.sys_language_uid', [-1, 0]);
853
+                $additionalWhere = $queryBuilder->expr()->in($table.'.sys_language_uid', [-1, 0]);
854 854
                 if ($GLOBALS['TSFE']->sys_language_content > 0) {
855 855
                     $additionalWhere = $queryBuilder->expr()->andX(
856 856
                         $queryBuilder->expr()->orX(
857
-                            $queryBuilder->expr()->in($table . '.sys_language_uid', [-1, 0]),
858
-                            $queryBuilder->expr()->eq($table . '.sys_language_uid', intval($GLOBALS['TSFE']->sys_language_content))
857
+                            $queryBuilder->expr()->in($table.'.sys_language_uid', [-1, 0]),
858
+                            $queryBuilder->expr()->eq($table.'.sys_language_uid', intval($GLOBALS['TSFE']->sys_language_content))
859 859
                         ),
860
-                        $queryBuilder->expr()->eq($table . '.l18n_parent', 0)
860
+                        $queryBuilder->expr()->eq($table.'.l18n_parent', 0)
861 861
                     );
862 862
                 }
863 863
 
@@ -866,7 +866,7 @@  discard block
 block discarded – undo
866 866
                     ->select('*')
867 867
                     ->from($table)
868 868
                     ->where(
869
-                        $queryBuilder->expr()->eq($table . '.pid', $pid),
869
+                        $queryBuilder->expr()->eq($table.'.pid', $pid),
870 870
                         $additionalWhere,
871 871
                         self::whereExpression($table, true)
872 872
                     )
@@ -884,10 +884,10 @@  discard block
 block discarded – undo
884 884
                         }
885 885
                     }
886 886
                 } else {
887
-                    self::devLog('No translation with PID ' . $pid . ' available in table "' . $table . '" or translation not accessible', DEVLOG_SEVERITY_NOTICE);
887
+                    self::devLog('No translation with PID '.$pid.' available in table "'.$table.'" or translation not accessible', DEVLOG_SEVERITY_NOTICE);
888 888
                 }
889 889
             } else {
890
-                self::devLog('No translations available for table "' . $table . '"', DEVLOG_SEVERITY_WARNING);
890
+                self::devLog('No translations available for table "'.$table.'"', DEVLOG_SEVERITY_WARNING);
891 891
             }
892 892
         }
893 893
 
@@ -926,9 +926,9 @@  discard block
 block discarded – undo
926 926
             return GeneralUtility::makeInstance(ConnectionPool::class)
927 927
                 ->getQueryBuilderForTable($table)
928 928
                 ->expr()
929
-                ->eq($table . '.' . $GLOBALS['TCA'][$table]['ctrl']['delete'], 0);
929
+                ->eq($table.'.'.$GLOBALS['TCA'][$table]['ctrl']['delete'], 0);
930 930
         } else {
931
-            self::devLog('Unexpected TYPO3_MODE "' . \TYPO3_MODE . '"', DEVLOG_SEVERITY_ERROR);
931
+            self::devLog('Unexpected TYPO3_MODE "'.\TYPO3_MODE.'"', DEVLOG_SEVERITY_ERROR);
932 932
             return '1=-1';
933 933
         }
934 934
     }
Please login to merge, or discard this patch.