Inspection of "Another round of spaces to tabs" - Erikmitk/kitodo-presentation - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — oai_solr (423cc8)

by Erik

created 2017-12-21 13:59 UTC

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -21,11 +21,11 @@  discard block
 block discarded – undo
 
 	protected $modPath = 'indexing/';
 
-	protected $buttonArray = array (
+	protected $buttonArray = array(
 		'SHORTCUT' => '',
 	);
 
-	protected $markerArray = array (
+	protected $markerArray = array(
 		'CSH' => '',
 		'MOD_MENU' => '',
 		'CONTENT' => '',
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
 		$this->list->save();
 
 		// Save document to database and index.
-		$doc =& tx_dlf_document::getInstance($uid, 0, TRUE);
+		$doc = & tx_dlf_document::getInstance($uid, 0, TRUE);
 
 		if ($doc->ready) {
 
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
 		$this->markerArray['CONTENT'] .= $_message->render();
 
 		// Start next loop.
-		$this->markerArray['CONTENT'] .= '<script type="text/javascript">window.location.href=unescape("'.\TYPO3\CMS\Core\Utility\GeneralUtility::rawUrlEncodeJS(\TYPO3\CMS\Core\Utility\GeneralUtility::locationHeaderUrl(\TYPO3\CMS\Core\Utility\GeneralUtility::linkThisScript(array ('id' => $this->id, 'CMD' => 'indexLoop', $this->prefixId => array ('core' => $this->data['core']), 'random' => uniqid())))).'");</script>';
+		$this->markerArray['CONTENT'] .= '<script type="text/javascript">window.location.href=unescape("'.\TYPO3\CMS\Core\Utility\GeneralUtility::rawUrlEncodeJS(\TYPO3\CMS\Core\Utility\GeneralUtility::locationHeaderUrl(\TYPO3\CMS\Core\Utility\GeneralUtility::linkThisScript(array('id' => $this->id, 'CMD' => 'indexLoop', $this->prefixId => array('core' => $this->data['core']), 'random' => uniqid())))).'");</script>';
 
 		$this->printContent();
 
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
 					if (!empty($this->data['id']) && isset($this->data['core'])) {
 
 						// Save document to database and index.
-						$doc =& tx_dlf_document::getInstance($this->data['id'], $this->id, TRUE);
+						$doc = & tx_dlf_document::getInstance($this->data['id'], $this->id, TRUE);
 
 						if ($doc->ready) {
 
@@ -275,11 +275,11 @@  discard block
 block discarded – undo
 						}
 
 						// Save them as a list object in user's session.
-						$elements = array ();
+						$elements = array();
 
 						while ($resArray = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($_result)) {
 
-							$elements[] = array ($resArray['uid'], $resArray['title']);
+							$elements[] = array($resArray['uid'], $resArray['title']);
 
 						}
 
@@ -372,8 +372,8 @@  discard block
 block discarded – undo
 	 */
 	protected function setMOD_MENU() {
 
-		$this->MOD_MENU = array (
-			'function' => array (
+		$this->MOD_MENU = array(
+			'function' => array(
 				'indexFile' => $GLOBALS['LANG']->getLL('function.indexFile'),
 				//'reindexDoc' => $GLOBALS['LANG']->getLL('function.reindexDoc'),
 				'reindexDocs' => $GLOBALS['LANG']->getLL('function.reindexDocs'),

Please login to merge, or discard this patch.

dlf/cli/class.tx_dlf_cli.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -48,11 +48,11 @@  discard block
 block discarded – undo
 			case 'index':
 
 				// Add command line arguments.
-				$this->cli_options[] = array ('-doc UID/URL', 'UID or (properly encoded) URL of the document.');
+				$this->cli_options[] = array('-doc UID/URL', 'UID or (properly encoded) URL of the document.');
 
-				$this->cli_options[] = array ('-pid UID', 'UID of the page the document should be added to.');
+				$this->cli_options[] = array('-pid UID', 'UID of the page the document should be added to.');
 
-				$this->cli_options[] = array ('-core UID', 'UID of the Solr core the document should be added to.');
+				$this->cli_options[] = array('-core UID', 'UID of the Solr core the document should be added to.');
 
 				// Check the command line arguments.
 				$this->cli_validateArgs();
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
 				}
 
 				// Get the document...
-				$doc =& tx_dlf_document::getInstance($this->cli_args['-doc'][0], $this->cli_args['-pid'][0], TRUE);
+				$doc = & tx_dlf_document::getInstance($this->cli_args['-doc'][0], $this->cli_args['-pid'][0], TRUE);
 
 				if ($doc->ready) {
 
@@ -116,11 +116,11 @@  discard block
 block discarded – undo
 			case 'reindex':
 
 				// Add command line arguments.
-				$this->cli_options[] = array ('-coll UID', 'UID of the collection.');
+				$this->cli_options[] = array('-coll UID', 'UID of the collection.');
 
-				$this->cli_options[] = array ('-pid UID', 'UID of the page the document should be added to.');
+				$this->cli_options[] = array('-pid UID', 'UID of the page the document should be added to.');
 
-				$this->cli_options[] = array ('-core UID', 'UID of the Solr core the document should be added to.');
+				$this->cli_options[] = array('-core UID', 'UID of the Solr core the document should be added to.');
 
 				// Check the command line arguments.
 				$this->cli_validateArgs();
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
 				while ($resArray = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($result)) {
 
 					// Get the document...
-					$doc =& tx_dlf_document::getInstance($resArray['uid'], $this->cli_args['-pid'][0], TRUE);
+					$doc = & tx_dlf_document::getInstance($resArray['uid'], $this->cli_args['-pid'][0], TRUE);
 
 					if ($doc->ready) {
 
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
 	public function __construct() {
 
 		// Set basic information about the script.
-		$this->cli_help = array (
+		$this->cli_help = array(
 			'name' => 'Command Line Interface for Kitodo.Presentation',
 			'synopsis' => '###OPTIONS###',
 			'description' => 'Currently the only tasks available are "index" and "reindex".'.LF.'Try "/PATH/TO/TYPO3/cli_dispatch.phpsh dlf TASK" for more options.',

Please login to merge, or discard this patch.

		@@ -21,11 +21,11 @@ discard block
		block discarded – undo
21	21
22	22	protected $modPath = 'indexing/';
23	23
24		- protected $buttonArray = array (
	24	+ protected $buttonArray = array(
25	25	'SHORTCUT' => '',
26	26	);
27	27
28		- protected $markerArray = array (
	28	+ protected $markerArray = array(
29	29	'CSH' => '',
30	30	'MOD_MENU' => '',
31	31	'CONTENT' => '',
		@@ -162,7 +162,7 @@ discard block
		block discarded – undo
162	162	$this->list->save();
163	163
164	164	// Save document to database and index.
165		- $doc =& tx_dlf_document::getInstance($uid, 0, TRUE);
	165	+ $doc = & tx_dlf_document::getInstance($uid, 0, TRUE);
166	166
167	167	if ($doc->ready) {
168	168
		@@ -182,7 +182,7 @@ discard block
		block discarded – undo
182	182	$this->markerArray['CONTENT'] .= $_message->render();
183	183
184	184	// Start next loop.
185		- $this->markerArray['CONTENT'] .= '<script type="text/javascript">window.location.href=unescape("'.\TYPO3\CMS\Core\Utility\GeneralUtility::rawUrlEncodeJS(\TYPO3\CMS\Core\Utility\GeneralUtility::locationHeaderUrl(\TYPO3\CMS\Core\Utility\GeneralUtility::linkThisScript(array ('id' => $this->id, 'CMD' => 'indexLoop', $this->prefixId => array ('core' => $this->data['core']), 'random' => uniqid())))).'");</script>';
	185	+ $this->markerArray['CONTENT'] .= '<script type="text/javascript">window.location.href=unescape("'.\TYPO3\CMS\Core\Utility\GeneralUtility::rawUrlEncodeJS(\TYPO3\CMS\Core\Utility\GeneralUtility::locationHeaderUrl(\TYPO3\CMS\Core\Utility\GeneralUtility::linkThisScript(array('id' => $this->id, 'CMD' => 'indexLoop', $this->prefixId => array('core' => $this->data['core']), 'random' => uniqid())))).'");</script>';
186	186
187	187	$this->printContent();
188	188
		@@ -218,7 +218,7 @@ discard block
		block discarded – undo
218	218	if (!empty($this->data['id']) && isset($this->data['core'])) {
219	219
220	220	// Save document to database and index.
221		- $doc =& tx_dlf_document::getInstance($this->data['id'], $this->id, TRUE);
	221	+ $doc = & tx_dlf_document::getInstance($this->data['id'], $this->id, TRUE);
222	222
223	223	if ($doc->ready) {
224	224
		@@ -275,11 +275,11 @@ discard block
		block discarded – undo
275	275	}
276	276
277	277	// Save them as a list object in user's session.
278		- $elements = array ();
	278	+ $elements = array();
279	279
280	280	while ($resArray = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($_result)) {
281	281
282		- $elements[] = array ($resArray['uid'], $resArray['title']);
	282	+ $elements[] = array($resArray['uid'], $resArray['title']);
283	283
284	284	}
285	285
		@@ -372,8 +372,8 @@ discard block
		block discarded – undo
372	372	*/
373	373	protected function setMOD_MENU() {
374	374
375		- $this->MOD_MENU = array (
376		- 'function' => array (
	375	+ $this->MOD_MENU = array(
	376	+ 'function' => array(
377	377	'indexFile' => $GLOBALS['LANG']->getLL('function.indexFile'),
378	378	//'reindexDoc' => $GLOBALS['LANG']->getLL('function.reindexDoc'),
379	379	'reindexDocs' => $GLOBALS['LANG']->getLL('function.reindexDocs'),

		@@ -48,11 +48,11 @@ discard block
		block discarded – undo
48	48	case 'index':
49	49
50	50	// Add command line arguments.
51		- $this->cli_options[] = array ('-doc UID/URL', 'UID or (properly encoded) URL of the document.');
	51	+ $this->cli_options[] = array('-doc UID/URL', 'UID or (properly encoded) URL of the document.');
52	52
53		- $this->cli_options[] = array ('-pid UID', 'UID of the page the document should be added to.');
	53	+ $this->cli_options[] = array('-pid UID', 'UID of the page the document should be added to.');
54	54
55		- $this->cli_options[] = array ('-core UID', 'UID of the Solr core the document should be added to.');
	55	+ $this->cli_options[] = array('-core UID', 'UID of the Solr core the document should be added to.');
56	56
57	57	// Check the command line arguments.
58	58	$this->cli_validateArgs();
		@@ -89,7 +89,7 @@ discard block
		block discarded – undo
89	89	}
90	90
91	91	// Get the document...
92		- $doc =& tx_dlf_document::getInstance($this->cli_args['-doc'][0], $this->cli_args['-pid'][0], TRUE);
	92	+ $doc = & tx_dlf_document::getInstance($this->cli_args['-doc'][0], $this->cli_args['-pid'][0], TRUE);
93	93
94	94	if ($doc->ready) {
95	95
		@@ -116,11 +116,11 @@ discard block
		block discarded – undo
116	116	case 'reindex':
117	117
118	118	// Add command line arguments.
119		- $this->cli_options[] = array ('-coll UID', 'UID of the collection.');
	119	+ $this->cli_options[] = array('-coll UID', 'UID of the collection.');
120	120
121		- $this->cli_options[] = array ('-pid UID', 'UID of the page the document should be added to.');
	121	+ $this->cli_options[] = array('-pid UID', 'UID of the page the document should be added to.');
122	122
123		- $this->cli_options[] = array ('-core UID', 'UID of the Solr core the document should be added to.');
	123	+ $this->cli_options[] = array('-core UID', 'UID of the Solr core the document should be added to.');
124	124
125	125	// Check the command line arguments.
126	126	$this->cli_validateArgs();
		@@ -170,7 +170,7 @@ discard block
		block discarded – undo
170	170	while ($resArray = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($result)) {
171	171
172	172	// Get the document...
173		- $doc =& tx_dlf_document::getInstance($resArray['uid'], $this->cli_args['-pid'][0], TRUE);
	173	+ $doc = & tx_dlf_document::getInstance($resArray['uid'], $this->cli_args['-pid'][0], TRUE);
174	174
175	175	if ($doc->ready) {
176	176
		@@ -213,7 +213,7 @@ discard block
		block discarded – undo
213	213	public function __construct() {
214	214
215	215	// Set basic information about the script.
216		- $this->cli_help = array (
	216	+ $this->cli_help = array(
217	217	'name' => 'Command Line Interface for Kitodo.Presentation',
218	218	'synopsis' => '###OPTIONS###',
219	219	'description' => 'Currently the only tasks available are "index" and "reindex".'.LF.'Try "/PATH/TO/TYPO3/cli_dispatch.phpsh dlf TASK" for more options.',

Erikmitk / kitodo-presentation

Branch — oai_solr (423cc8)

Category

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch