Erikmitk / kitodo-presentation

Classes/Validation/AbstractDlfValidationStack.php

Spacing +3 added lines, -3 removed lines

@@ -54,7 +54,7 @@ 
     {
         foreach ($configuration as $configurationItem) {
             if (!class_exists($configurationItem["className"])) {
-                $this->logger->error('Unable to load class ' . $configurationItem["className"] . '.');
+                $this->logger->error('Unable to load class '.$configurationItem["className"].'.');
                 throw new InvalidArgumentException('Unable to load validator class.', 1723200537037);
             }
             $breakOnError = !isset($configurationItem["breakOnError"]) || $configurationItem["breakOnError"] !== "false";
@@ -83,7 +83,7 @@ 
         }
 
         if (!$validator instanceof AbstractDlfValidator) {
-            $this->logger->error($className . ' must be an instance of AbstractDlfValidator.');
+            $this->logger->error($className.' must be an instance of AbstractDlfValidator.');
             throw new InvalidArgumentException('Class must be an instance of AbstractDlfValidator.', 1723121212747);
         }
 
@@ -104,7 +104,7 @@ 
     protected function isValid($value): void
     {
         if (!$value instanceof $this->valueClassName) {
-            $this->logger->error('Value must be an instance of ' . $this->valueClassName . '.');
+            $this->logger->error('Value must be an instance of '.$this->valueClassName.'.');
             throw new InvalidArgumentException('Type of value is not valid.', 1723127564821);
         }
 

Classes/Validation/SaxonXslToSvrlValidator.php

Spacing +2 added lines, -2 removed lines

@@ -61,11 +61,11 @@
     protected function process(mixed $value): string
     {
         // using source from standard input
-        $process = new Process(['java', '-jar', $this->jar, '-xsl:' . $this->xsl, '-s:-'], null, null, $value->saveXML());
+        $process = new Process(['java', '-jar', $this->jar, '-xsl:'.$this->xsl, '-s:-'], null, null, $value->saveXML());
         $process->run();
         // executes after the command finish
         if (!$process->isSuccessful()) {
-            $this->logger->error('Processing exits with code "' . $process->getExitCode() . '"');
+            $this->logger->error('Processing exits with code "'.$process->getExitCode().'"');
             throw new InvalidArgumentException('Processing was not successful.', 1724862680);
         }
         return $process->getOutput();

Classes/Middleware/DOMDocumentValidation.php

Spacing +3 added lines, -3 removed lines

@@ -78,19 +78,19 @@
         $validation = GeneralUtility::makeInstance(DOMDocumentValidationStack::class, $settings['domDocumentValidationValidators']);
 
         if (!GeneralUtility::isValidUrl($urlParam)) {
-            $this->logger->debug('Parameter "' . $urlParam . '" is not a valid url.');
+            $this->logger->debug('Parameter "'.$urlParam.'" is not a valid url.');
             throw new InvalidArgumentException('Value of url parameter is not a valid url.', 1724852611);
         }
 
         $content = GeneralUtility::getUrl($urlParam);
         if ($content === false) {
-            $this->logger->debug('Error while loading content of "' . $urlParam . '"');
+            $this->logger->debug('Error while loading content of "'.$urlParam.'"');
             throw new InvalidArgumentException('Error while loading content of url.', 1724420640);
         }
 
         $document = new DOMDocument();
         if ($document->loadXML($content) === false) {
-            $this->logger->debug('Error converting content of "' . $urlParam . '" to xml.');
+            $this->logger->debug('Error converting content of "'.$urlParam.'" to xml.');
             throw new InvalidArgumentException('Error converting content to xml.', 1724420648);
         }
 

Tests/Unit/Validation/SaxonXslToSvrlValidatorTest.php

Spacing +3 added lines, -3 removed lines

@@ -48,7 +48,7 @@ 
     {
         parent::setUp();
         $this->resetSingletonInstances = true;
-        $this->dlfExtensionPath = Environment::getExtensionsPath() . 'dlf';
+        $this->dlfExtensionPath = Environment::getExtensionsPath().'dlf';
     }
 
     public function testJarFileNotFound(): void
@@ -63,12 +63,12 @@ 
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage("XSL Schematron file not found.");
         // It only checks if a file exists at the specified path, so we can use one of the test files.
-        new SaxonXslToSvrlValidator(["jar" => $this->dlfExtensionPath . '/Tests/Fixtures/Format/alto.xml']);
+        new SaxonXslToSvrlValidator(["jar" => $this->dlfExtensionPath.'/Tests/Fixtures/Format/alto.xml']);
     }
 
     public function testValidation(): void
     {
-        $saxonXslToSvrlValidator = new SaxonXslToSvrlValidator(["jar" => $this->dlfExtensionPath . '/Tests/Fixtures/Format/alto.xml', "xsl" => $this->dlfExtensionPath . '/Tests/Fixtures/Format/alto.xml']);
+        $saxonXslToSvrlValidator = new SaxonXslToSvrlValidator(["jar" => $this->dlfExtensionPath.'/Tests/Fixtures/Format/alto.xml', "xsl" => $this->dlfExtensionPath.'/Tests/Fixtures/Format/alto.xml']);
         $reflection = new ReflectionClass($saxonXslToSvrlValidator);
 
         $result = $reflection->getProperty("result");