Passed
Pull Request — master (#113)
by
unknown
03:39
created
Classes/Hooks/KitodoProductionHacks.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
                 }
58 58
                 $dmdIds = explode(' ', $id);
59 59
                 foreach ($dmdIds as $dmdId) {
60
-                    $recordIds = $xml->xpath('//mets:dmdSec[@ID="' . $dmdId . '"]//mods:mods/mods:recordInfo/mods:recordIdentifier');
60
+                    $recordIds = $xml->xpath('//mets:dmdSec[@ID="'.$dmdId.'"]//mods:mods/mods:recordInfo/mods:recordIdentifier');
61 61
                     if (!empty($recordIds)) {
62 62
                         $record_id = (string) $recordIds[0];
63 63
                         break;
Please login to merge, or discard this patch.
Classes/Format/Mods.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@
 block discarded – undo
82 82
                 }
83 83
                 // Append "valueURI" to name using Unicode unit separator.
84 84
                 if (isset($authors[$i]['valueURI'])) {
85
-                    $metadata['author'][$i] .= chr(31) . (string) $authors[$i]['valueURI'];
85
+                    $metadata['author'][$i] .= chr(31).(string) $authors[$i]['valueURI'];
86 86
                 }
87 87
             }
88 88
         }
Please login to merge, or discard this patch.
Classes/Common/KitodoFlashMessageRenderer.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function getClass(FlashMessage $flashMessage): string
67 67
     {
68
-        return 'alert-' . self::$classes[$flashMessage->getSeverity()];
68
+        return 'alert-'.self::$classes[$flashMessage->getSeverity()];
69 69
     }
70 70
 
71 71
     /**
@@ -95,19 +95,19 @@  discard block
 block discarded – undo
95 95
         $markup[] = '<div class="typo3-messages">';
96 96
         foreach ($flashMessages as $flashMessage) {
97 97
             $messageTitle = $flashMessage->getTitle();
98
-            $markup[] = '<div class="alert ' . htmlspecialchars($this->getClass($flashMessage)) . '">';
98
+            $markup[] = '<div class="alert '.htmlspecialchars($this->getClass($flashMessage)).'">';
99 99
             $markup[] = '  <div class="media">';
100 100
             $markup[] = '    <div class="media-left">';
101 101
             $markup[] = '      <span class="fa-stack fa-lg">';
102 102
             $markup[] = '        <i class="fa fa-circle fa-stack-2x"></i>';
103
-            $markup[] = '        <i class="fa fa-' . htmlspecialchars($this->getIconName($flashMessage)) . ' fa-stack-1x"></i>';
103
+            $markup[] = '        <i class="fa fa-'.htmlspecialchars($this->getIconName($flashMessage)).' fa-stack-1x"></i>';
104 104
             $markup[] = '      </span>';
105 105
             $markup[] = '    </div>';
106 106
             $markup[] = '    <div class="media-body">';
107 107
             if ($messageTitle !== '') {
108
-                $markup[] = '      <h4 class="alert-title">' . htmlspecialchars($messageTitle) . '</h4>';
108
+                $markup[] = '      <h4 class="alert-title">'.htmlspecialchars($messageTitle).'</h4>';
109 109
             }
110
-            $markup[] = '      <p class="alert-message">' . $flashMessage->getMessage() . '</p>';
110
+            $markup[] = '      <p class="alert-message">'.$flashMessage->getMessage().'</p>';
111 111
             $markup[] = '    </div>';
112 112
             $markup[] = '  </div>';
113 113
             $markup[] = '</div>';
Please login to merge, or discard this patch.
Classes/Common/IiifManifest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -694,16 +694,16 @@  discard block
 block discarded – undo
694 694
                     && ($values = $iiifResource->jsonPath($resArray['xpath_sorting']) != null)
695 695
                 ) {
696 696
                     if (is_string($values)) {
697
-                        $metadata[$resArray['index_name'] . '_sorting'][0] = [trim((string) $values)];
697
+                        $metadata[$resArray['index_name'].'_sorting'][0] = [trim((string) $values)];
698 698
                     } elseif ($values instanceof JSONPath && is_array($values->data()) && count($values->data()) > 1) {
699 699
                         $metadata[$resArray['index_name']] = [];
700 700
                         foreach ($values->data() as $value) {
701
-                            $metadata[$resArray['index_name'] . '_sorting'][0] = trim((string) $value);
701
+                            $metadata[$resArray['index_name'].'_sorting'][0] = trim((string) $value);
702 702
                         }
703 703
                     }
704 704
                 }
705
-                if (empty($metadata[$resArray['index_name'] . '_sorting'][0])) {
706
-                    $metadata[$resArray['index_name'] . '_sorting'][0] = $metadata[$resArray['index_name']][0];
705
+                if (empty($metadata[$resArray['index_name'].'_sorting'][0])) {
706
+                    $metadata[$resArray['index_name'].'_sorting'][0] = $metadata[$resArray['index_name']][0];
707 707
                 }
708 708
             }
709 709
         }
@@ -831,7 +831,7 @@  discard block
 block discarded – undo
831 831
                     }
832 832
                 }
833 833
             } else {
834
-                $this->logger->warning('Invalid structure resource @id "' . $id . '"');
834
+                $this->logger->warning('Invalid structure resource @id "'.$id.'"');
835 835
                 return $rawText;
836 836
             }
837 837
             $this->rawTextArray[$id] = $rawText;
@@ -880,7 +880,7 @@  discard block
 block discarded – undo
880 880
                 }
881 881
             }
882 882
         }
883
-        $this->logger->error('Could not load IIIF manifest from "' . $location . '"');
883
+        $this->logger->error('Could not load IIIF manifest from "'.$location.'"');
884 884
         return false;
885 885
     }
886 886
 
Please login to merge, or discard this patch.
Classes/Common/SolrSearchResult/Highlight.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
         $this->xEndPosition = $highlight['lrx'];
88 88
         $this->yBeginPosition = $highlight['uly'];
89 89
         $this->yEndPosition = $highlight['lry'];
90
-        $this->id = $this->xBeginPosition . '_' . $this->yBeginPosition;
90
+        $this->id = $this->xBeginPosition.'_'.$this->yBeginPosition;
91 91
     }
92 92
 
93 93
     /**
Please login to merge, or discard this patch.
Classes/Format/Alto.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
      */
102 102
     private function getWord($attributes)
103 103
     {
104
-        return htmlspecialchars((string) $attributes['CONTENT']) . ' ';
104
+        return htmlspecialchars((string) $attributes['CONTENT']).' ';
105 105
     }
106 106
 
107 107
     /**
@@ -115,6 +115,6 @@  discard block
 block discarded – undo
115 115
      */
116 116
     private function getCoordinates($attributes)
117 117
     {
118
-        return (string) $attributes['HPOS'] . ' ' . (string) $attributes['VPOS'] . ' ' . (string) $attributes['WIDTH'] . ' ' . (string) $attributes['HEIGHT'];
118
+        return (string) $attributes['HPOS'].' '.(string) $attributes['VPOS'].' '.(string) $attributes['WIDTH'].' '.(string) $attributes['HEIGHT'];
119 119
     }
120 120
 }
Please login to merge, or discard this patch.
Configuration/TCA/Overrides/tt_content.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -16,63 +16,63 @@
 block discarded – undo
16 16
 // Plugin "audioplayer".
17 17
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_audioplayer'] = 'layout,select_key,pages,recursive';
18 18
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_audioplayer'] = 'pi_flexform';
19
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_audioplayer', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/AudioPlayer.xml');
19
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_audioplayer', 'FILE:EXT:'.'dlf/Configuration/Flexforms/AudioPlayer.xml');
20 20
 // Plugin "basket".
21 21
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_basket'] = 'layout,select_key,pages,recursive';
22 22
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_basket'] = 'pi_flexform';
23
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_basket', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/Basket.xml');
23
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_basket', 'FILE:EXT:'.'dlf/Configuration/Flexforms/Basket.xml');
24 24
 // Plugin "calendar".
25 25
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_calendar'] = 'layout,select_key,pages,recursive';
26 26
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_calendar'] = 'pi_flexform';
27
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_calendar', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/Calendar.xml');
27
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_calendar', 'FILE:EXT:'.'dlf/Configuration/Flexforms/Calendar.xml');
28 28
 // Plugin "collection".
29 29
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_collection'] = 'layout,select_key,pages,recursive';
30 30
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_collection'] = 'pi_flexform';
31
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_collection', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/Collection.xml');
31
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_collection', 'FILE:EXT:'.'dlf/Configuration/Flexforms/Collection.xml');
32 32
 // Plugin "feeds".
33 33
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_feeds'] = 'layout,select_key,pages,recursive';
34 34
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_feeds'] = 'pi_flexform';
35
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_feeds', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/Feeds.xml');
35
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_feeds', 'FILE:EXT:'.'dlf/Configuration/Flexforms/Feeds.xml');
36 36
 // Plugin "listview".
37 37
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_listview'] = 'layout,select_key,pages,recursive';
38 38
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_listview'] = 'pi_flexform';
39
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_listview', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/ListView.xml');
39
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_listview', 'FILE:EXT:'.'dlf/Configuration/Flexforms/ListView.xml');
40 40
 // Plugin "metadata".
41 41
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_metadata'] = 'layout,select_key,pages,recursive';
42 42
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_metadata'] = 'pi_flexform';
43
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_metadata', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/Metadata.xml');
43
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_metadata', 'FILE:EXT:'.'dlf/Configuration/Flexforms/Metadata.xml');
44 44
 // Plugin "navigation".
45 45
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_navigation'] = 'layout,select_key,pages,recursive';
46 46
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_navigation'] = 'pi_flexform';
47
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_navigation', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/Navigation.xml');
47
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_navigation', 'FILE:EXT:'.'dlf/Configuration/Flexforms/Navigation.xml');
48 48
 // Plugin "oaipmh".
49 49
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_oaipmh'] = 'layout,select_key,pages,recursive';
50 50
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_oaipmh'] = 'pi_flexform';
51
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_oaipmh', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/OaiPmh.xml');
51
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_oaipmh', 'FILE:EXT:'.'dlf/Configuration/Flexforms/OaiPmh.xml');
52 52
 // Plugin "pagegrid".
53 53
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_pagegrid'] = 'layout,select_key,pages,recursive';
54 54
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_pagegrid'] = 'pi_flexform';
55
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_pagegrid', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/PageGrid.xml');
55
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_pagegrid', 'FILE:EXT:'.'dlf/Configuration/Flexforms/PageGrid.xml');
56 56
 // Plugin "pageview".
57 57
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_pageview'] = 'layout,select_key,pages,recursive';
58 58
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_pageview'] = 'pi_flexform';
59
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_pageview', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/PageView.xml');
59
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_pageview', 'FILE:EXT:'.'dlf/Configuration/Flexforms/PageView.xml');
60 60
 // Plugin "search".
61 61
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_search'] = 'layout,select_key,pages,recursive';
62 62
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_search'] = 'pi_flexform';
63
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_search', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/Search.xml');
63
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_search', 'FILE:EXT:'.'dlf/Configuration/Flexforms/Search.xml');
64 64
 // Plugin "statistics".
65 65
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_statistics'] = 'layout,select_key,pages,recursive';
66 66
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_statistics'] = 'pi_flexform';
67
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_statistics', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/Statistics.xml');
67
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_statistics', 'FILE:EXT:'.'dlf/Configuration/Flexforms/Statistics.xml');
68 68
 // Plugin "tableofcontents".
69 69
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_tableofcontents'] = 'layout,select_key,pages,recursive';
70 70
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_tableofcontents'] = 'pi_flexform';
71
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_tableofcontents', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/TableOfContents.xml');
71
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_tableofcontents', 'FILE:EXT:'.'dlf/Configuration/Flexforms/TableOfContents.xml');
72 72
 // Plugin "toolbox".
73 73
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_excludelist']['dlf_toolbox'] = 'layout,select_key,pages,recursive';
74 74
 $GLOBALS['TCA']['tt_content']['types']['list']['subtypes_addlist']['dlf_toolbox'] = 'pi_flexform';
75
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_toolbox', 'FILE:EXT:' . 'dlf/Configuration/Flexforms/Toolbox.xml');
75
+\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPiFlexFormValue('dlf_toolbox', 'FILE:EXT:'.'dlf/Configuration/Flexforms/Toolbox.xml');
76 76
 
77 77
 \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin(
78 78
     'Kitodo.Dlf',
Please login to merge, or discard this patch.
Configuration/Extbase/Persistence/Classes.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 return [
5 5
     \Kitodo\Dlf\Domain\Model\ActionLog::class => [
Please login to merge, or discard this patch.
Build/Documentation/dbdocs/RstSection.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -35,9 +35,9 @@  discard block
 block discarded – undo
35 35
     {
36 36
         if (!empty($text)) {
37 37
             if ($format['bold'] ?? false) {
38
-                $text = '**' . $text . '**';
38
+                $text = '**'.$text.'**';
39 39
             } elseif ($format['italic'] ?? false) {
40
-                $text = '*' . $text . '*';
40
+                $text = '*'.$text.'*';
41 41
             }
42 42
         }
43 43
 
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 
47 47
     public static function paragraphs(array $paragraphs)
48 48
     {
49
-        $paragraphs = array_values(array_filter($paragraphs, function ($entry) {
49
+        $paragraphs = array_values(array_filter($paragraphs, function($entry) {
50 50
             return !empty($entry);
51 51
         }));
52 52
 
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
     public function addText(string $text)
69 69
     {
70 70
         if (!empty($text)) {
71
-            $this->text .= $text . "\n\n";
71
+            $this->text .= $text."\n\n";
72 72
         }
73 73
     }
74 74
 
@@ -97,10 +97,10 @@  discard block
 block discarded – undo
97 97
                 $numLines = count($valueLines);
98 98
                 for ($i = 0; $i < $numLines; $i++) {
99 99
                     $prefix = $i === 0
100
-                        ? '     :' . $key . ':'
100
+                        ? '     :'.$key.':'
101 101
                         : '';
102 102
 
103
-                    $entry .= str_pad($prefix, 32) . trim($valueLines[$i]) . "\n";
103
+                    $entry .= str_pad($prefix, 32).trim($valueLines[$i])."\n";
104 104
                 }
105 105
             }
106 106
 
@@ -138,10 +138,10 @@  discard block
 block discarded – undo
138 138
         $headerSep = str_repeat($headerChar, mb_strlen($this->header));
139 139
 
140 140
         if ($level === 0) {
141
-            $result .= $headerSep . "\n";
141
+            $result .= $headerSep."\n";
142 142
         }
143 143
 
144
-        $result .= $this->header . "\n" . $headerSep . "\n\n";
144
+        $result .= $this->header."\n".$headerSep."\n\n";
145 145
 
146 146
         return $result;
147 147
     }
Please login to merge, or discard this patch.