Erikmitk / kitodo-presentation

Classes/Updates/MigrateSettings.php

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -108,11 +108,11 @@ 
 
             // exit if at least one update statement is not successful
             if (!((bool) $updateResult)) {
-                return false;
+                return FALSE;
             }
         }
 
-        return true;
+        return TRUE;
     }
 
     /**
@@ -126,7 +126,7 @@ 
      */
     public function updateNecessary(): bool
     {
-        $oldSettingsFound = false;
+        $oldSettingsFound = FALSE;
 
         $connection = GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionForTable('tt_content');
 
@@ -144,7 +144,7 @@ 
         // Update the found record sets
         while ($record = $statement->fetchAssociative()) {
             $oldSettingsFound = $this->checkForOldSettings($record['pi_flexform']);
-            if ($oldSettingsFound === true) {
+            if ($oldSettingsFound === TRUE) {
                 // We found at least one field to be updated --> break here
                 break;
             }
@@ -187,7 +187,7 @@ 
 
         foreach ($fields as $field) {
             // change the index attribute if it doesn't start with 'settings.' yet
-            if (strpos($field['index'], 'settings.') === false) {
+            if (strpos($field['index'], 'settings.') === FALSE) {
                 $field['index'] = 'settings.' . $field['index'];
             }
         }

Classes/Updates/FileLocationUpdater.php

Upper-Lower-Casing +12 added lines, -12 removed lines

@@ -105,11 +105,11 @@ 
     public function updateNecessary(): bool
     {
         /** @var int */
-        $numRecords = $this->getRecordsFromTable(true);
+        $numRecords = $this->getRecordsFromTable(TRUE);
         if ($numRecords > 0) {
-            return true;
+            return TRUE;
         }
-        return false;
+        return FALSE;
     }
 
     /**
@@ -145,16 +145,16 @@ 
      */
     public function executeUpdate(): bool
     {
-        $result = true;
+        $result = TRUE;
         try {
             /** @var int */
-            $numRecords = $this->getRecordsFromTable(true);
+            $numRecords = $this->getRecordsFromTable(TRUE);
             if ($numRecords > 0) {
                 $this->performUpdate();
             }
         } catch (\Exception $e) {
             // If something goes wrong, migrateField() logs an error
-            $result = false;
+            $result = FALSE;
         }
         return $result;
     }
@@ -171,7 +171,7 @@ 
      *
      * @throws \RuntimeException
      */
-    protected function getRecordsFromTable(bool $countOnly = false)
+    protected function getRecordsFromTable(bool $countOnly = FALSE)
     {
         $connectionPool = GeneralUtility::makeInstance(ConnectionPool::class);
         $allResults = [];
@@ -198,7 +198,7 @@ 
                     ->orderBy('uid')
                     ->execute()
                     ->fetchAllAssociative();
-                if ($countOnly === true) {
+                if ($countOnly === TRUE) {
                     $numResults += count($result);
                 } else {
                     $allResults[$table] = $result;
@@ -211,7 +211,7 @@ 
             }
         }
 
-        if ($countOnly === true) {
+        if ($countOnly === TRUE) {
             return $numResults;
         } else {
             return $allResults;
@@ -228,7 +228,7 @@ 
      */
     protected function performUpdate(): bool
     {
-        $result = true;
+        $result = TRUE;
 
         try {
             $storages = GeneralUtility::makeInstance(StorageRepository::class)->findAll();
@@ -241,7 +241,7 @@ 
                 }
             }
         } catch (\Exception $e) {
-            $result = false;
+            $result = FALSE;
         }
 
         return $result;
@@ -270,7 +270,7 @@ 
         $storageUid = (int) $this->storage->getUid();
         $connectionPool = GeneralUtility::makeInstance(ConnectionPool::class);
 
-        $fileUid = null;
+        $fileUid = NULL;
         $sourcePath = Environment::getPublicPath() . '/' . $fieldItem;
 
         // maybe the file was already moved, so check if the original file still exists

Classes/Pagination/PageGridPagination.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -36,12 +36,12 @@ 
         $previousPage = (int) (($this->paginator->getCurrentPageNumber() - 1) * $this->paginator->getPublicItemsPerPage()) - ($this->paginator->getPublicItemsPerPage() - 1);
 
         if ($previousPage > $this->paginator->getNumberOfPages()) {
-            return null;
+            return NULL;
         }
 
         return $previousPage >= $this->getFirstPageNumber()
             ? $previousPage
-            : null
+            : NULL
             ;
     }
 
@@ -51,7 +51,7 @@ 
 
         return $nextPage <= $this->paginator->getNumberOfPages()
             ? $nextPage
-            : null
+            : NULL
             ;
     }
 

Classes/Controller/MetadataController.php

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -155,7 +155,7 @@ 
     protected function printMetadata(array $metadata): void
     {
         if ($this->useOriginalIiifManifestMetadata) {
-            $this->view->assign('useIiif', true);
+            $this->view->assign('useIiif', TRUE);
             $this->view->assign('iiifData', $this->buildIiifData($metadata));
         } else {
             // findBySettings also sorts entries by the `sorting` field
@@ -245,9 +245,9 @@ 
         if (IRI::isAbsoluteIri($value) && ($scheme == 'http' || $scheme == 'https')) {
             //TODO: should really label be converted to empty string if equal to value?
             $label = $value == $label ? '' : $label;
-            $buildUrl = true;
+            $buildUrl = TRUE;
         } else {
-            $buildUrl = false;
+            $buildUrl = FALSE;
         }
 
         return [
@@ -388,7 +388,7 @@ 
     private function parseParentTitle(int $i, $value, array &$metadata) : void
     {
         if (empty(implode('', $value)) && $this->settings['getTitle'] && $this->document->getPartof()) {
-            $superiorTitle = AbstractDocument::getTitle($this->document->getPartof(), true);
+            $superiorTitle = AbstractDocument::getTitle($this->document->getPartof(), TRUE);
             if (!empty($superiorTitle)) {
                 $metadata[$i]['title'] = ['[' . $superiorTitle . ']'];
             }

Classes/Controller/BasketController.php

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -190,7 +190,7 @@ 
 
         $countDocs = 0;
         if ($basket->getDocIds()) {
-            $countDocs = count(json_decode($basket->getDocIds(), true));
+            $countDocs = count(json_decode($basket->getDocIds(), TRUE));
         }
         $this->view->assign('countDocs', $countDocs);
 
@@ -253,7 +253,7 @@ 
         }
 
         // session does not exist
-        if ($basket === null) {
+        if ($basket === NULL) {
             // create new basket in db
             $basket = GeneralUtility::makeInstance(Basket::class);
             $basket->setSessionId($userSession->getIdentifier());
@@ -388,7 +388,7 @@ 
                 'record_id' => $this->document->getRecordId(),
             ];
         }
-        return false;
+        return FALSE;
     }
 
     /**
@@ -410,7 +410,7 @@ 
         } else {
             $page = (int) $piVars['startpage'];
         }
-        if ($page != null || $piVars['addToBasket'] == 'list') {
+        if ($page != NULL || $piVars['addToBasket'] == 'list') {
             $documentItem = [
                 'id' => (int) $piVars['id'],
                 'startpage' => (int) $piVars['startpage'],
@@ -433,7 +433,7 @@ 
             $this->loadDocument((int) $documentItem['id']);
             if ($this->isDocMissing()) {
                 // Quit without doing anything if required variables are not set.
-                return null;
+                return NULL;
             }
             // set endpage for toc and subentry based on logid
             if (($piVars['addToBasket'] == 'subentry') or ($piVars['addToBasket'] == 'toc')) {
@@ -487,7 +487,7 @@ 
             }
 
             $basket->setDocIds(json_encode($items));
-            if ($basket->getUid() === null) {
+            if ($basket->getUid() === NULL) {
                 $this->basketRepository->add($basket);
             } else {
                 $this->basketRepository->update($basket);

Classes/Format/AudioVideoMD.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
      *
      * @return void
      */
-    public function extractMetadata(\SimpleXMLElement $xml, array &$metadata, bool $useExternalApis = false): void
+    public function extractMetadata(\SimpleXMLElement $xml, array &$metadata, bool $useExternalApis = FALSE): void
     {
         $xml->registerXPathNamespace('audiomd', 'http://www.loc.gov/audioMD/');
         $xml->registerXPathNamespace('videomd', 'http://www.loc.gov/videoMD/');

Classes/Format/Alto.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -151,11 +151,11 @@
     {
         $namespace = $xml->getDocNamespaces();
 
-        if (in_array('http://www.loc.gov/standards/alto/ns-v2#', $namespace, true)) {
+        if (in_array('http://www.loc.gov/standards/alto/ns-v2#', $namespace, TRUE)) {
             $xml->registerXPathNamespace('alto', 'http://www.loc.gov/standards/alto/ns-v2#');
-        } elseif (in_array('http://www.loc.gov/standards/alto/ns-v3#', $namespace, true)) {
+        } elseif (in_array('http://www.loc.gov/standards/alto/ns-v3#', $namespace, TRUE)) {
             $xml->registerXPathNamespace('alto', 'http://www.loc.gov/standards/alto/ns-v3#');
-        } elseif (in_array('http://www.loc.gov/standards/alto/ns-v4#', $namespace, true)) {
+        } elseif (in_array('http://www.loc.gov/standards/alto/ns-v4#', $namespace, TRUE)) {
             $xml->registerXPathNamespace('alto', 'http://www.loc.gov/standards/alto/ns-v4#');
         }
     }

Classes/Format/TeiHeader.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
      *
      * @return void
      */
-    public function extractMetadata(\SimpleXMLElement $xml, array &$metadata, bool $useExternalApis = false): void
+    public function extractMetadata(\SimpleXMLElement $xml, array &$metadata, bool $useExternalApis = FALSE): void
     {
         $xml->registerXPathNamespace('teihdr', 'http://www.tei-c.org/ns/1.0');
     }

Classes/Api/Viaf/Client.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
             $response = $this->requestFactory->request($url);
         } catch (\Exception $e) {
             $this->logger->warning('Could not fetch data from URL "' . $url . '". Error: ' . $e->getMessage() . '.');
-            return false;
+            return FALSE;
         }
         return $response->getBody()->getContents();
     }