tx_dlf_cli

Complexity

Total Complexity

18

Size/Duplication

Total Lines	202
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
F	main()	0	167	17
A	__construct()	0	15	1

<?php
/**
 * (c) Kitodo. Key to digital objects e.V. <contact@kitodo.org>
 *
 * This file is part of the Kitodo and TYPO3 projects.
 *
 * @license GNU General Public License version 3 or later.
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 */

if (!defined('TYPO3_cliMode')) {

    die('You cannot run this script directly!');

}

/**
 * CLI script for the 'dlf' extension.
 *
 * @author	Sebastian Meyer <sebastian.meyer@slub-dresden.de>
 * @package	TYPO3
 * @subpackage	tx_dlf
 * @access	public
 */
class tx_dlf_cli extends \TYPO3\CMS\Core\Controller\CommandLineController {

The type TYPO3\CMS\Core\Controller\CommandLineController was not found. Maybe you did not declare it correctly or list all dependencies?

    /**
     * This is the return code.
     *
     * @var	integer
     * @access protected
     */
    protected $return = 0;

    /**
     * Main function of the script.
     *
     * @access	public
     *
     * @return	void
     */
    public function main() {

        switch ((string) $this->cli_args['_DEFAULT'][1]) {

            // (Re-)Index a single document.
            case 'index':

                // Add command line arguments.
                $this->cli_options[] = array ('-doc UID/URL', 'UID or (properly encoded) URL of the document.');

The property cli_options does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                $this->cli_options[] = array ('-pid UID', 'UID of the page the document should be added to.');

                $this->cli_options[] = array ('-core UID', 'UID of the Solr core the document should be added to.');

                // Check the command line arguments.
                $this->cli_validateArgs();

                if (!\TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($this->cli_args['-doc'][0])

The type TYPO3\CMS\Core\Utility\MathUtility was not found. Maybe you did not declare it correctly or list all dependencies?

                    && !\TYPO3\CMS\Core\Utility\GeneralUtility::isValidUrl($this->cli_args['-doc'][0])) {

The type TYPO3\CMS\Core\Utility\GeneralUtility was not found. Maybe you did not declare it correctly or list all dependencies?

                    $this->cli_echo('ERROR: "'.$this->cli_args['-doc'][0].'" is not a valid document UID or URL.'.LF, TRUE);

The constant LF was not found. Maybe you did not declare it correctly or list all dependencies?

                    $this->return = 1;

                }

                if (!\TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($this->cli_args['-pid'][0])) {

                    $this->cli_echo('ERROR: "'.$this->cli_args['-pid'][0].'" is not a valid page UID.'.LF, TRUE);

                    $this->return = 1;

                }

                if (!\TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($this->cli_args['-core'][0])) {

                    $this->cli_echo('ERROR: "'.$this->cli_args['-core'][0].'" is not a valid core UID.'.LF, TRUE);

                    $this->return = 1;

                }

                if ($this->return > 0) {

                    break;

                }

                // Get the document...
                $doc = & tx_dlf_document::getInstance($this->cli_args['-doc'][0], $this->cli_args['-pid'][0], TRUE);

                if ($doc->ready) {

                    // ...and save it to the database...
                    if (!$doc->save(intval($this->cli_args['-pid'][0]), intval($this->cli_args['-core'][0]))) {

                        $this->cli_echo('ERROR: Document "'.$this->cli_args['-doc'][0].'" not saved and indexed.'.LF, TRUE);

                        $this->return = 1;

                    }

                } else {

                    $this->cli_echo('ERROR: Document "'.$this->cli_args['-doc'][0].'" could not be loaded.'.LF, TRUE);

                    $this->return = 1;

                }

                break;

            // Re-index all documents of a collection.
            case 'reindex':

                // Add command line arguments.
                $this->cli_options[] = array ('-coll UID', 'UID of the collection.');

                $this->cli_options[] = array ('-pid UID', 'UID of the page the document should be added to.');

                $this->cli_options[] = array ('-core UID', 'UID of the Solr core the document should be added to.');

                // Check the command line arguments.
                $this->cli_validateArgs();

                if (!\TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($this->cli_args['-coll'][0])) {

                    $this->cli_echo('ERROR: "'.$this->cli_args['-coll'][0].'" is not a valid collection UID.'.LF, TRUE);

                    $this->return = 1;

                }

                if (!\TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($this->cli_args['-pid'][0])) {

                    $this->cli_echo('ERROR: "'.$this->cli_args['-pid'][0].'" is not a valid page UID.'.LF, TRUE);

                    $this->return = 1;

                }

                if (!\TYPO3\CMS\Core\Utility\MathUtility::canBeInterpretedAsInteger($this->cli_args['-core'][0])) {

                    $this->cli_echo('ERROR: "'.$this->cli_args['-core'][0].'" is not a valid core UID.'.LF, TRUE);

                    $this->return = 1;

                }

                if ($this->return > 0) {

                    break;

                }

                // Get the collection.
                $result = $GLOBALS['TYPO3_DB']->exec_SELECT_mm_query(
                    'tx_dlf_documents.uid AS uid',
                    'tx_dlf_documents',
                    'tx_dlf_relations',
                    'tx_dlf_collections',
                    'AND tx_dlf_collections.uid='.intval($this->cli_args['-coll'][0]).' AND tx_dlf_collections.pid='.intval($this->cli_args['-pid'][0]).' AND tx_dlf_relations.ident='.$GLOBALS['TYPO3_DB']->fullQuoteStr('docs_colls', 'tx_dlf_relations').tx_dlf_helper::whereClause('tx_dlf_documents').tx_dlf_helper::whereClause('tx_dlf_collections'),
                    '',
                    '',
                    ''
                );

                while ($resArray = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($result)) {

                    // Get the document...
                    $doc = & tx_dlf_document::getInstance($resArray['uid'], $this->cli_args['-pid'][0], TRUE);

                    if ($doc->ready) {

                        // ...and save it to the database...
                        if (!$doc->save(intval($this->cli_args['-pid'][0]), intval($this->cli_args['-core'][0]))) {

                            $this->cli_echo('ERROR: Document "'.$resArray['uid'].'" not saved and indexed.'.LF, TRUE);

                            $this->return = 1;

                        }

                    } else {

                        $this->cli_echo('ERROR: Document "'.$resArray['uid'].'" could not be loaded.'.LF, TRUE);

                        $this->return = 1;

                    }

                    // Clear document registry to prevent memory exhaustion.
                    tx_dlf_document::clearRegistry();

                }

                break;

            default:

                $this->cli_help();

                break;

        }

        exit ($this->return);

Using exit here is not recommended.

    }

    public function __construct() {

        // Set basic information about the script.
        $this->cli_help = array (

The property cli_help does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            'name' => 'Command Line Interface for Kitodo.Presentation',
            'synopsis' => '###OPTIONS###',
            'description' => 'Currently the only tasks available are "index" and "reindex".'.LF.'Try "/PATH/TO/TYPO3/cli_dispatch.phpsh dlf TASK" for more options.',

The constant LF was not found. Maybe you did not declare it correctly or list all dependencies?

            'examples' => '/PATH/TO/TYPO3/cli_dispatch.phpsh dlf TASK -ARG1=VALUE1 -ARG2=VALUE2',
            'options' => '',
            'license' => 'GNU GPL - free software!',
            'author' => 'Kitodo. Key to digital objects e.V. <contact@kitodo.org>',
        );

        // Run parent constructor.
        parent::__construct();

    }

}

$SOBE = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('tx_dlf_cli');

$SOBE->main();