Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | class HomepageTest extends BaseTestCase |
||
6 | { |
||
7 | /** |
||
8 | * Test that the index route returns a rendered response containing the text 'SlimFramework' but not a greeting |
||
9 | */ |
||
10 | View Code Duplication | public function testGetHomepageWithoutName() |
|
18 | |||
19 | /** |
||
20 | * Test that the index route with optional name argument returns a rendered greeting |
||
21 | */ |
||
22 | View Code Duplication | public function testGetHomepageWithGreeting() |
|
29 | |||
30 | /** |
||
31 | * Test that the index route won't accept a post request |
||
32 | */ |
||
33 | View Code Duplication | public function testPostHomepageNotAllowed() |
|
40 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.