Ajax - Code Metrics - Inspection of "update credits" - Erdiko/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — erdiko2 (81b309)

by John

created 2017-03-28 04:17 UTC

Ajax A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	1
dl	38
loc	38
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	5	5	1
A	_before()	4	4	1
A	setStatusCode()	6	6	2
A	setErrors()	6	6	2

How to fix Duplicated Code

<?php
/**
 * Ajax Controller
 *
 * @package     erdiko/controllers
 * @copyright   2012-2017 Arroyo Labs, Inc. http://www.arroyolabs.com
 * @author      John Arroyo <[email protected]>
 * @author      Andy Armstrong <[email protected]>
 */
namespace erdiko\controllers;


class Ajax extends \erdiko\Controller

{

  /**
   * Contructor
   */
    public function __construct()
    {
        $this->_webroot = ERDIKO_ROOT;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->_response = new \erdiko\core\AjaxResponse;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /** 
     * Before 
     */
    public function _before()
    {
        // Do nothing, it overrides the core before function which prepares for theming
    }

    /**
     * setStatusCode
     *
     */
    public function setStatusCode($code = null)
    {
        if (!empty($code)) {
            $this->_response->setStatusCode($code);
        }
    }

    public function setErrors($errors = null)
    {
        if (!empty($errors)) {
            $this->_response->setErrors($errors);
        }
    }
}


1		<?php
2		/**
3		* Ajax Controller
4		*
5		* @package erdiko/controllers
6		* @copyright 2012-2017 Arroyo Labs, Inc. http://www.arroyolabs.com
7		* @author John Arroyo <[email protected]>
8		* @author Andy Armstrong <[email protected]>
9		*/
10		namespace erdiko\controllers;
11
12
13	View Code Duplication	class Ajax extends \erdiko\Controller
		0 ignored issues – show Duplication introduced 2017-03-28 04:19 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		{
15
16		/**
17		* Contructor
18		*/
19		public function __construct()
20		{
21		$this->_webroot = ERDIKO_ROOT;
		0 ignored issues – show Bug introduced 2017-03-28 04:19 UTC by Report Bug Copy Issue Report The property `_webroot` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22		$this->_response = new \erdiko\core\AjaxResponse;
		0 ignored issues – show Bug introduced 2017-03-28 04:19 UTC by Report Bug Copy Issue Report The property `_response` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23		}
24
25		/**
26		* Before
27		*/
28		public function _before()
29		{
30		// Do nothing, it overrides the core before function which prepares for theming
31		}
32
33		/**
34		* setStatusCode
35		*
36		*/
37		public function setStatusCode($code = null)
38		{
39		if (!empty($code)) {
40		$this->_response->setStatusCode($code);
41		}
42		}
43
44		public function setErrors($errors = null)
45		{
46		if (!empty($errors)) {
47		$this->_response->setErrors($errors);
48		}
49		}
50		}
51

Erdiko / core

Branch — erdiko2 (81b309)

Ajax A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like