ToroHook::get_instance() - Code Metrics - Inspection of "attempt to use diff docker script" - Erdiko/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 36f8ff...81ebd3 )

by John

created 2017-02-17 22:21 UTC

ToroHook::get_instance() A

↳ Parent: ToroHook

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	0

<?php
/**
 * ToroHook
 * Taken from https://github.com/anandkunal/ToroPHP
 * @package     erdiko/core
 */
namespace erdiko\core;


class ToroHook
{
    private static $instance;

    private $hooks = array();


    private function __construct()
    {
    }
    private function __clone()
    {
    }

    public static function add($hook_name, $fn)
    {
        $instance = static::get_instance();
        $instance->hooks[$hook_name][] = $fn;
    }

    public static function fire($hook_name, $params = null)
    {
        $instance = static::get_instance();
        if (isset($instance->hooks[$hook_name])) {
            foreach ($instance->hooks[$hook_name] as $fn) {
                call_user_func_array($fn, array(&$params));
            }
        }
    }

    public static function get_instance()
    {
        if (empty(static::$instance)) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            static::$instance = new ToroHook();
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }
        return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }
}


1			<?php
2			/**
3			* ToroHook
4			* Taken from https://github.com/anandkunal/ToroPHP
5			* @package erdiko/core
6			*/
7			namespace erdiko\core;
8
9
10			class ToroHook
11			{
12			private static $instance;
13
14			private $hooks = array();
			0 ignored issues – show Unused Code introduced 2017-01-06 19:47 UTC by Report Bug Copy Issue Report The property `$hooks` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
15
16			private function __construct()
17			{
18			}
19			private function __clone()
20			{
21			}
22
23			public static function add($hook_name, $fn)
24			{
25			$instance = static::get_instance();
26			$instance->hooks[$hook_name][] = $fn;
27			}
28
29			public static function fire($hook_name, $params = null)
30			{
31			$instance = static::get_instance();
32			if (isset($instance->hooks[$hook_name])) {
33			foreach ($instance->hooks[$hook_name] as $fn) {
34			call_user_func_array($fn, array(&$params));
35			}
36			}
37			}
38
39			public static function get_instance()
40			{
41			if (empty(static::$instance)) {
			0 ignored issues – show Bug introduced 2017-02-17 22:23 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
42			static::$instance = new ToroHook();
			0 ignored issues – show Bug introduced 2017-02-17 22:23 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
43			}
44			return static::$instance;
			0 ignored issues – show Bug introduced 2017-02-17 22:23 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
45			}
46			}
47

Erdiko / core

Push — master ( 36f8ff...81ebd3 )

ToroHook::get_instance() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like